19
18
* along with this program. If not, see
20
19
* <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@recompile.se>.
21
* Contact the authors at <mandos@fukt.bsnet.se>.
25
24
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
27
26
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
27
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
28
EXIT_SUCCESS, realloc() */
30
29
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* DIR, fdopendir(), fstat(), struct
30
#include <stdio.h> /* perror, popen(), fileno(),
31
fprintf(), stderr, STDOUT_FILENO */
32
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
33
stat, waitpid(), WIFEXITED(),
35
34
WEXITSTATUS(), wait(), pid_t,
36
35
uid_t, gid_t, getuid(), getgid(),
38
37
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
38
FD_SET(), FD_ISSET(), FD_CLR */
40
39
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG(),
43
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
41
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
44
42
#include <iso646.h> /* and, or, not */
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
43
#include <dirent.h> /* DIR, struct dirent, opendir(),
46
44
readdir(), closedir(), dirfd() */
47
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
48
FD_CLOEXEC, write(), STDOUT_FILENO,
49
struct stat, fstat(), close(),
50
setgid(), setuid(), S_ISREG(),
51
faccessat() pipe(), fork(),
52
_exit(), dup2(), fexecve(), read()
45
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
46
fcntl(), setuid(), setgid(),
47
F_GETFD, F_SETFD, FD_CLOEXEC,
48
access(), pipe(), fork(), close()
49
dup2, STDOUT_FILENO, _exit(),
50
execv(), write(), read(),
54
52
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
FD_CLOEXEC, openat() */
56
#include <string.h> /* strsep, strlen(), strsignal(),
57
strcmp(), strncmp() */
54
#include <string.h> /* strsep, strlen(), asprintf() */
58
55
#include <errno.h> /* errno */
59
56
#include <argp.h> /* struct argp_option, struct
60
57
argp_state, struct argp,
64
61
#include <signal.h> /* struct sigaction, sigemptyset(),
65
62
sigaddset(), sigaction(),
66
63
sigprocmask(), SIG_BLOCK, SIGCHLD,
67
SIG_UNBLOCK, kill(), sig_atomic_t
64
SIG_UNBLOCK, kill() */
69
65
#include <errno.h> /* errno, EBADF */
70
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
71
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
72
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
73
#include <errno.h> /* errno */
74
#include <error.h> /* error() */
76
67
#define BUFFER_SIZE 256
78
69
#define PDIR "/lib/mandos/plugins.d"
79
70
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
81
const char *argp_program_version = "plugin-runner " VERSION;
82
const char *argp_program_bug_address = "<mandos@recompile.se>";
72
const char *argp_program_version = "plugin-runner 1.0";
73
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
84
77
typedef struct plugin{
85
78
char *name; /* can be NULL or any plugin name */
106
99
/* Gets an existing plugin based on name,
107
100
or if none is found, creates a new one */
108
__attribute__((warn_unused_result))
109
101
static plugin *getplugin(char *name){
110
/* Check for existing plugin with that name */
111
for(plugin *p = plugin_list; p != NULL; p = p->next){
113
or (p->name and name and (strcmp(p->name, name) == 0))){
102
/* Check for exiting plugin with that name */
103
for (plugin *p = plugin_list; p != NULL; p = p->next){
104
if ((p->name == name)
105
or (p->name and name and (strcmp(p->name, name) == 0))){
117
109
/* Create a new plugin */
118
plugin *new_plugin = NULL;
120
new_plugin = malloc(sizeof(plugin));
121
} while(new_plugin == NULL and errno == EINTR);
122
if(new_plugin == NULL){
110
plugin *new_plugin = malloc(sizeof(plugin));
111
if (new_plugin == NULL){
125
114
char *copy_name = NULL;
126
115
if(name != NULL){
128
copy_name = strdup(name);
129
} while(copy_name == NULL and errno == EINTR);
116
copy_name = strdup(name);
130
117
if(copy_name == NULL){
138
*new_plugin = (plugin){ .name = copy_name,
141
.next = plugin_list };
122
*new_plugin = (plugin) { .name = copy_name,
125
.next = plugin_list };
144
new_plugin->argv = malloc(sizeof(char *) * 2);
145
} while(new_plugin->argv == NULL and errno == EINTR);
146
if(new_plugin->argv == NULL){
127
new_plugin->argv = malloc(sizeof(char *) * 2);
128
if (new_plugin->argv == NULL){
149
130
free(new_plugin);
153
133
new_plugin->argv[0] = copy_name;
154
134
new_plugin->argv[1] = NULL;
157
new_plugin->environ = malloc(sizeof(char *));
158
} while(new_plugin->environ == NULL and errno == EINTR);
136
new_plugin->environ = malloc(sizeof(char *));
159
137
if(new_plugin->environ == NULL){
162
139
free(new_plugin->argv);
163
140
free(new_plugin);
167
143
new_plugin->environ[0] = NULL;
244
207
* Based on the example in the GNU LibC manual chapter 13.13 "File
245
208
* Descriptor Flags".
246
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
209
* *Note File Descriptor Flags:(libc)Descriptor Flags.
248
__attribute__((warn_unused_result))
249
static int set_cloexec_flag(int fd){
250
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
211
static int set_cloexec_flag(int fd)
213
int ret = fcntl(fd, F_GETFD, 0);
251
214
/* If reading the flags failed, return error indication now. */
255
218
/* Store modified flag word in the descriptor. */
256
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
219
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
261
223
/* Mark processes as completed when they exit, and save their exit
263
static void handle_sigchld(__attribute__((unused)) int sig){
264
int old_errno = errno;
225
void handle_sigchld(__attribute__((unused)) int sig){
266
227
plugin *proc = plugin_list;
414
370
.doc = "Group ID the plugins will run as", .group = 3 },
415
371
{ .name = "debug", .key = 132,
416
372
.doc = "Debug mode", .group = 4 },
418
* These reproduce what we would get without ARGP_NO_HELP
420
{ .name = "help", .key = '?',
421
.doc = "Give this help list", .group = -1 },
422
{ .name = "usage", .key = -3,
423
.doc = "Give a short usage message", .group = -1 },
424
{ .name = "version", .key = 'V',
425
.doc = "Print program version", .group = -1 },
429
__attribute__((nonnull(3)))
430
error_t parse_opt(int key, char *arg, struct argp_state *state){
376
error_t parse_opt (int key, char *arg, __attribute__((unused))
377
struct argp_state *state) {
435
379
case 'g': /* --global-options */
438
while((plugin_option = strsep(&arg, ",")) != NULL){
439
if(not add_argument(getplugin(NULL), plugin_option)){
382
while((p = strsep(&arg, ",")) != NULL){
386
if(not add_argument(getplugin(NULL), p)){
387
perror("add_argument");
388
return ARGP_ERR_UNKNOWN;
446
393
case 'G': /* --global-env */
447
if(add_environment(getplugin(NULL), arg, true)){
397
if(not add_environment(getplugin(NULL), arg, true)){
398
perror("add_environment");
451
401
case 'o': /* --options-for */
453
char *option_list = strchr(arg, ':');
454
if(option_list == NULL){
455
argp_error(state, "No colon in \"%s\"", arg);
462
argp_error(state, "Empty plugin name");
467
while((option = strsep(&option_list, ",")) != NULL){
468
if(not add_argument(getplugin(arg), option)){
403
char *p_name = strsep(&arg, ":");
404
if(p_name[0] == '\0' or arg == NULL){
407
char *opt = strsep(&arg, ":");
408
if(opt[0] == '\0' or opt == NULL){
412
while((p = strsep(&opt, ",")) != NULL){
416
if(not add_argument(getplugin(p_name), p)){
417
perror("add_argument");
418
return ARGP_ERR_UNKNOWN;
475
423
case 'E': /* --env-for */
477
428
char *envdef = strchr(arg, ':');
478
429
if(envdef == NULL){
479
argp_error(state, "No colon in \"%s\"", arg);
486
argp_error(state, "Empty plugin name");
490
if(add_environment(getplugin(arg), envdef, true)){
433
if(not add_environment(getplugin(arg), envdef+1, true)){
434
perror("add_environment");
495
438
case 'd': /* --disable */
497
440
plugin *p = getplugin(arg);
442
return ARGP_ERR_UNKNOWN;
504
447
case 'e': /* --enable */
506
449
plugin *p = getplugin(arg);
451
return ARGP_ERR_UNKNOWN;
513
456
case 128: /* --plugin-dir */
515
458
plugindir = strdup(arg);
516
if(plugindir != NULL){
459
if(plugindir == NULL){
520
463
case 129: /* --config-file */
521
464
/* This is already done by parse_opt_config_file() */
523
466
case 130: /* --userid */
524
tmp_id = strtoimax(arg, &tmp, 10);
525
if(errno != 0 or tmp == arg or *tmp != '\0'
526
or tmp_id != (uid_t)tmp_id){
527
argp_error(state, "Bad user ID number: \"%s\", using %"
528
PRIdMAX, arg, (intmax_t)uid);
467
uid = (uid_t)strtol(arg, NULL, 10);
534
469
case 131: /* --groupid */
535
tmp_id = strtoimax(arg, &tmp, 10);
536
if(errno != 0 or tmp == arg or *tmp != '\0'
537
or tmp_id != (gid_t)tmp_id){
538
argp_error(state, "Bad group ID number: \"%s\", using %"
539
PRIdMAX, arg, (intmax_t)gid);
470
gid = (gid_t)strtol(arg, NULL, 10);
545
472
case 132: /* --debug */
549
* These reproduce what we would get without ARGP_NO_HELP
551
case '?': /* --help */
552
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
553
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
554
case -3: /* --usage */
555
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
556
argp_state_help(state, state->out_stream,
557
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
558
case 'V': /* --version */
559
fprintf(state->out_stream, "%s\n", argp_program_version);
563
* When adding more options before this line, remember to also add a
564
* "case" to the "parse_opt_config_file" function below.
566
475
case ARGP_KEY_ARG:
567
/* Cryptsetup always passes an argument, which is an empty
568
string if "none" was specified in /etc/crypttab. So if
569
argument was empty, we ignore it silently. */
476
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
574
481
return ARGP_ERR_UNKNOWN;
576
return errno; /* Set to 0 at start */
579
486
/* This option parser is the same as parse_opt() above, except it
580
487
ignores everything but the --config-file option. */
581
error_t parse_opt_config_file(int key, char *arg,
582
__attribute__((unused))
583
struct argp_state *state){
488
error_t parse_opt_config_file (int key, char *arg,
489
__attribute__((unused))
490
struct argp_state *state) {
586
492
case 'g': /* --global-options */
587
493
case 'G': /* --global-env */
588
494
case 'o': /* --options-for */
679
574
new_arg = strdup(p);
680
575
if(new_arg == NULL){
681
error(0, errno, "strdup");
682
exitstatus = EX_OSERR;
577
exitstatus = EXIT_FAILURE;
687
582
custom_argc += 1;
689
char **new_argv = realloc(custom_argv, sizeof(char *)
692
if(new_argv == NULL){
693
error(0, errno, "realloc");
694
exitstatus = EX_OSERR;
699
custom_argv = new_argv;
583
custom_argv = realloc(custom_argv, sizeof(char *)
584
* ((unsigned int) custom_argc + 1));
585
if(custom_argv == NULL){
587
exitstatus = EXIT_FAILURE;
702
591
custom_argv[custom_argc-1] = new_arg;
703
custom_argv[custom_argc] = NULL;
592
custom_argv[custom_argc] = NULL;
707
ret = fclose(conffp);
708
} while(ret == EOF and errno == EINTR);
710
error(0, errno, "fclose");
711
exitstatus = EX_IOERR;
716
597
/* Check for harmful errors and go to fallback. Other errors might
717
598
not affect opening plugins */
718
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
719
error(0, errno, "fopen");
720
exitstatus = EX_OSERR;
599
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
601
exitstatus = EXIT_FAILURE;
724
/* If there were any arguments from the configuration file, pass
725
them to parser as command line arguments */
605
/* If there was any arguments from configuration file,
606
pass them to parser as command arguments */
726
607
if(custom_argv != NULL){
727
ret = argp_parse(&argp, custom_argc, custom_argv,
728
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
736
error(0, errno, "argp_parse");
737
exitstatus = EX_OSERR;
740
exitstatus = EX_CONFIG;
608
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
610
if (ret == ARGP_ERR_UNKNOWN){
611
fprintf(stderr, "Unknown error while parsing arguments\n");
612
exitstatus = EXIT_FAILURE;
745
617
/* Parse actual command line arguments, to let them override the
747
ret = argp_parse(&argp, argc, argv,
748
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
756
error(0, errno, "argp_parse");
757
exitstatus = EX_OSERR;
760
exitstatus = EX_USAGE;
619
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
620
if (ret == ARGP_ERR_UNKNOWN){
621
fprintf(stderr, "Unknown error while parsing arguments\n");
622
exitstatus = EXIT_FAILURE;
768
630
for(char **a = p->argv; *a != NULL; a++){
769
631
fprintf(stderr, "\tArg: %s\n", *a);
771
fprintf(stderr, "...and %d environment variables\n", p->envc);
633
fprintf(stderr, "...and %u environment variables\n", p->envc);
772
634
for(char **a = p->environ; *a != NULL; a++){
773
635
fprintf(stderr, "\t%s\n", *a);
779
/* Work around Debian bug #633582:
780
<http://bugs.debian.org/633582> */
781
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
782
if(plugindir_fd == -1){
784
error(0, errno, "open(\"" PDIR "\")");
787
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
789
error(0, errno, "fstat");
791
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
792
ret = fchown(plugindir_fd, uid, gid);
794
error(0, errno, "fchown");
798
TEMP_FAILURE_RETRY(close(plugindir_fd));
802
/* Lower permissions */
805
error(0, errno, "setgid");
640
/* Strip permissions down to nobody */
807
641
ret = setuid(uid);
809
error(0, errno, "setuid");
812
/* Open plugin directory with close_on_exec flag */
650
if (plugindir == NULL){
653
dir = opendir(plugindir);
657
perror("Could not open plugin dir");
658
exitstatus = EXIT_FAILURE;
662
/* Set the FD_CLOEXEC flag on the directory, if possible */
814
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
817
#else /* not O_CLOEXEC */
819
#endif /* not O_CLOEXEC */
822
error(0, errno, "Could not open plugin dir");
823
exitstatus = EX_UNAVAILABLE;
828
/* Set the FD_CLOEXEC flag on the directory */
829
ret = set_cloexec_flag(dir_fd);
831
error(0, errno, "set_cloexec_flag");
832
TEMP_FAILURE_RETRY(close(dir_fd));
833
exitstatus = EX_OSERR;
836
#endif /* O_CLOEXEC */
838
dir = fdopendir(dir_fd);
840
error(0, errno, "Could not open plugin dir");
841
TEMP_FAILURE_RETRY(close(dir_fd));
842
exitstatus = EX_OSERR;
664
int dir_fd = dirfd(dir);
666
ret = set_cloexec_flag(dir_fd);
668
perror("set_cloexec_flag");
669
exitstatus = EXIT_FAILURE;
927
int plugin_fd = openat(dir_fd, dirst->d_name, O_RDONLY |
930
#else /* not O_CLOEXEC */
932
#endif /* not O_CLOEXEC */
935
error(0, errno, "Could not open plugin");
737
if(plugindir == NULL){
738
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
740
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
939
/* Set the FD_CLOEXEC flag on the plugin FD */
940
ret = set_cloexec_flag(plugin_fd);
942
error(0, errno, "set_cloexec_flag");
943
TEMP_FAILURE_RETRY(close(plugin_fd));
946
#endif /* O_CLOEXEC */
947
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
949
error(0, errno, "stat");
950
TEMP_FAILURE_RETRY(close(plugin_fd));
747
ret = stat(filename, &st);
954
754
/* Ignore non-executable files */
955
if(not S_ISREG(st.st_mode)
956
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, dirst->d_name, X_OK,
755
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
959
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
960
" with bad type or mode\n",
961
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
757
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
758
" with bad type or mode\n", filename);
963
TEMP_FAILURE_RETRY(close(plugin_fd));
967
764
plugin *p = getplugin(dirst->d_name);
969
error(0, errno, "getplugin");
970
TEMP_FAILURE_RETRY(close(plugin_fd));
985
782
for(char **a = g->argv + 1; *a != NULL; a++){
986
783
if(not add_argument(p, *a)){
987
error(0, errno, "add_argument");
784
perror("add_argument");
990
787
/* Add global environment variables */
991
788
for(char **e = g->environ; *e != NULL; e++){
992
789
if(not add_environment(p, *e, false)){
993
error(0, errno, "add_environment");
790
perror("add_environment");
998
/* If this plugin has any environment variables, we need to
999
duplicate the environment from this process, too. */
795
/* If this plugin has any environment variables, we will call
796
using execve and need to duplicate the environment from this
1000
798
if(p->environ[0] != NULL){
1001
799
for(char **e = environ; *e != NULL; e++){
1002
800
if(not add_environment(p, *e, false)){
1003
error(0, errno, "add_environment");
801
perror("add_environment");
1009
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1011
error(0, errno, "pipe");
1012
exitstatus = EX_OSERR;
810
exitstatus = EXIT_FAILURE;
1015
813
/* Ask OS to automatic close the pipe on exec */
1016
814
ret = set_cloexec_flag(pipefd[0]);
1018
error(0, errno, "set_cloexec_flag");
1019
exitstatus = EX_OSERR;
816
perror("set_cloexec_flag");
817
exitstatus = EXIT_FAILURE;
1022
820
ret = set_cloexec_flag(pipefd[1]);
1024
error(0, errno, "set_cloexec_flag");
1025
exitstatus = EX_OSERR;
822
perror("set_cloexec_flag");
823
exitstatus = EXIT_FAILURE;
1028
826
/* Block SIGCHLD until process is safely in process list */
1029
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1030
&sigchld_action.sa_mask,
827
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1033
error(0, errno, "sigprocmask");
1034
exitstatus = EX_OSERR;
829
perror("sigprocmask");
830
exitstatus = EXIT_FAILURE;
1037
833
/* Starting a new process to be watched */
1041
} while(pid == -1 and errno == EINTR);
1043
error(0, errno, "fork");
1044
exitstatus = EX_OSERR;
837
exitstatus = EXIT_FAILURE;
1048
841
/* this is the child process */
1049
842
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1051
error(0, errno, "sigaction");
1054
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
847
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1056
error(0, errno, "sigprocmask");
849
perror("sigprocmask");
1060
853
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1062
error(0, errno, "dup2");
1066
859
if(dirfd(dir) < 0){
1068
861
above and must now close it manually here. */
1071
if(fexecve(plugin_fd, p->argv,
1072
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1073
error(0, errno, "fexecve for %s/%s",
1074
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
864
if(p->environ[0] == NULL){
865
if(execv(filename, p->argv) < 0){
870
if(execve(filename, p->argv, p->environ) < 0){
1079
877
/* Parent process */
1080
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1082
TEMP_FAILURE_RETRY(close(plugin_fd));
878
close(pipefd[1]); /* Close unused write end of pipe */
1083
880
plugin *new_plugin = getplugin(dirst->d_name);
1084
if(new_plugin == NULL){
1085
error(0, errno, "getplugin");
1086
ret = (int)(TEMP_FAILURE_RETRY
1087
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
881
if (new_plugin == NULL){
883
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1090
error(0, errno, "sigprocmask");
885
perror("sigprocmask");
1092
exitstatus = EX_OSERR;
887
exitstatus = EXIT_FAILURE;
1099
894
/* Unblock SIGCHLD so signal handler can be run if this process
1100
895
has already completed */
1101
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1102
&sigchld_action.sa_mask,
896
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1105
error(0, errno, "sigprocmask");
1106
exitstatus = EX_OSERR;
898
perror("sigprocmask");
899
exitstatus = EXIT_FAILURE;
1110
#if defined (__GNUC__) and defined (__GLIBC__)
1111
#if not __GLIBC_PREREQ(2, 16)
1112
#pragma GCC diagnostic push
1113
#pragma GCC diagnostic ignored "-Wsign-conversion"
1116
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1117
-Wconversion in GNU libc
1119
#if defined (__GNUC__) and defined (__GLIBC__)
1120
#if not __GLIBC_PREREQ(2, 16)
1121
#pragma GCC diagnostic pop
903
FD_SET(new_plugin->fd, &rfds_all);
1125
if(maxfd < new_plugin->fd){
905
if (maxfd < new_plugin->fd){
1126
906
maxfd = new_plugin->fd;
1130
TEMP_FAILURE_RETRY(closedir(dir));
1132
free_plugin(getplugin(NULL));
1134
914
for(plugin *p = plugin_list; p != NULL; p = p->next){
1135
915
if(p->pid != 0){
1141
921
free_plugin_list();
1145
925
/* Main loop while running plugins exist */
1146
926
while(plugin_list){
1147
927
fd_set rfds = rfds_all;
1148
928
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
1149
if(select_ret == -1 and errno != EINTR){
1150
error(0, errno, "select");
1151
exitstatus = EX_OSERR;
929
if (select_ret == -1){
931
exitstatus = EXIT_FAILURE;
1154
934
/* OK, now either a process completed, or something can be read
1155
935
from one of them */
1156
936
for(plugin *proc = plugin_list; proc != NULL;){
1157
937
/* Is this process completely done? */
1158
if(proc->completed and proc->eof){
938
if(proc->eof and proc->completed){
1159
939
/* Only accept the plugin output if it exited cleanly */
1160
940
if(not WIFEXITED(proc->status)
1161
941
or WEXITSTATUS(proc->status) != 0){
1162
942
/* Bad exit by plugin */
1165
945
if(WIFEXITED(proc->status)){
1166
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1167
" status %d\n", proc->name,
1168
(intmax_t) (proc->pid),
946
fprintf(stderr, "Plugin %u exited with status %d\n",
947
(unsigned int) (proc->pid),
1169
948
WEXITSTATUS(proc->status));
1170
} else if(WIFSIGNALED(proc->status)){
1171
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1172
" signal %d: %s\n", proc->name,
1173
(intmax_t) (proc->pid),
1174
WTERMSIG(proc->status),
1175
strsignal(WTERMSIG(proc->status)));
949
} else if(WIFSIGNALED(proc->status)) {
950
fprintf(stderr, "Plugin %u killed by signal %d\n",
951
(unsigned int) (proc->pid),
952
WTERMSIG(proc->status));
1176
953
} else if(WCOREDUMP(proc->status)){
1177
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1178
" core\n", proc->name, (intmax_t) (proc->pid));
954
fprintf(stderr, "Plugin %d dumped core\n",
955
(unsigned int) (proc->pid));
1182
959
/* Remove the plugin */
1183
#if defined (__GNUC__) and defined (__GLIBC__)
1184
#if not __GLIBC_PREREQ(2, 16)
1185
#pragma GCC diagnostic push
1186
#pragma GCC diagnostic ignored "-Wsign-conversion"
1189
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1190
-Wconversion in GNU libc
1192
#if defined (__GNUC__) and defined (__GLIBC__)
1193
#if not __GLIBC_PREREQ(2, 16)
1194
#pragma GCC diagnostic pop
960
FD_CLR(proc->fd, &rfds_all);
1198
962
/* Block signal while modifying process_list */
1199
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1201
&sigchld_action.sa_mask,
1204
error(0, errno, "sigprocmask");
1205
exitstatus = EX_OSERR;
963
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
965
perror("sigprocmask");
966
exitstatus = EXIT_FAILURE;
970
/* We are done modifying process list, so unblock signal */
971
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,
974
perror("sigprocmask");
975
exitstatus = EXIT_FAILURE;
979
if(plugin_list == NULL){
1209
983
plugin *next_plugin = proc->next;
1210
984
free_plugin(proc);
1211
985
proc = next_plugin;
1213
/* We are done modifying process list, so unblock signal */
1214
ret = (int)(TEMP_FAILURE_RETRY
1215
(sigprocmask(SIG_UNBLOCK,
1216
&sigchld_action.sa_mask, NULL)));
1218
error(0, errno, "sigprocmask");
1219
exitstatus = EX_OSERR;
1223
if(plugin_list == NULL){
1230
989
/* This process exited nicely, so print its buffer */
1232
991
bool bret = print_out_password(proc->buffer,
1233
992
proc->buffer_length);
1235
error(0, errno, "print_out_password");
1236
exitstatus = EX_IOERR;
994
perror("print_out_password");
995
exitstatus = EXIT_FAILURE;
1241
1000
/* This process has not completed. Does it have any output? */
1242
#if defined (__GNUC__) and defined (__GLIBC__)
1243
#if not __GLIBC_PREREQ(2, 16)
1244
#pragma GCC diagnostic push
1245
#pragma GCC diagnostic ignored "-Wsign-conversion"
1248
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1254
#if defined (__GNUC__) and defined (__GLIBC__)
1255
#if not __GLIBC_PREREQ(2, 16)
1256
#pragma GCC diagnostic pop
1001
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1259
1002
/* This process had nothing to say at this time */
1260
1003
proc = proc->next;
1263
1006
/* Before reading, make the process' data buffer large enough */
1264
1007
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1265
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1266
+ (size_t) BUFFER_SIZE);
1267
if(new_buffer == NULL){
1268
error(0, errno, "malloc");
1269
exitstatus = EX_OSERR;
1008
proc->buffer = realloc(proc->buffer, proc->buffer_size
1009
+ (size_t) BUFFER_SIZE);
1010
if (proc->buffer == NULL){
1012
exitstatus = EXIT_FAILURE;
1272
proc->buffer = new_buffer;
1273
1015
proc->buffer_size += BUFFER_SIZE;
1275
1017
/* Read from the process */
1276
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1278
+ proc->buffer_length,
1018
ret = read(proc->fd, proc->buffer + proc->buffer_length,
1281
1021
/* Read error from this process; ignore the error */
1282
1022
proc = proc->next;
1287
1027
proc->eof = true;
1289
proc->buffer_length += (size_t) sret;
1029
proc->buffer_length += (size_t) ret;
1297
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1298
and exitstatus != EX_OK)){
1037
if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
1299
1038
/* Fallback if all plugins failed, none are found or an error