/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to DBUS-API

  • Committer: Teddy Hogeborn
  • Date: 2023-02-07 23:03:33 UTC
  • Revision ID: teddy@recompile.se-20230207230333-5halrp7943pgb3w1
Server: Bug fix: Stagger checker runs when creating clients

* mandos (Client.enable()): Do not set self.expires here; move it to
  "init_checker".
  (Client.init_checker()): Take new "randomize_start" argument.  If
  True, randomize delay before starting checker.  Also, do not start
  checker right now, but instead extend expire time so that the
  scheduled checker always has time to run.
  (Checker.start_checker): Take new "start_was_randomized" argument.
  If True, reset scheduled checker runs to be 'interval' apart,
  instead of using the initial delay.  (Bug fix)
  (main): On startup, pass argument randomize_start=True to
  client.init_checker() when initizlizing checkers for all enabled
  clients.

Reported-by: Louis Charreau <Louis.Charreau@vadesecure.com>
Suggested-by: Louis Charreau <Louis.Charreau@vadesecure.com>
Fixes: 1200 ("Server: Stagger checker runs when creating clients")

Show diffs side-by-side

added added

removed removed

Lines of Context:
55
55
   
56
56
   | Name                    | Type | Access     | clients.conf        |
57
57
   |-------------------------+------+------------+---------------------|
58
 
   | ApprovedByDefault       | b    | Read/Write | approved_by_default |
59
58
   | ApprovalDelay (a)       | t    | Read/Write | approval_delay      |
60
59
   | ApprovalDuration (a)    | t    | Read/Write | approval_duration   |
61
60
   | ApprovalPending (b)     | b    | Read       | N/A                 |
 
61
   | ApprovedByDefault       | b    | Read/Write | approved_by_default |
62
62
   | Checker                 | s    | Read/Write | checker             |
63
63
   | CheckerRunning (c)      | b    | Read/Write | N/A                 |
64
64
   | Created (d)             | s    | Read       | N/A                 |
66
66
   | Expires (f)             | s    | Read       | N/A                 |
67
67
   | ExtendedTimeout (a)     | t    | Read/Write | extended_timeout    |
68
68
   | Fingerprint             | s    | Read       | fingerprint         |
69
 
   | KeyID                   | s    | Read       | key_id              |
70
69
   | Host                    | s    | Read/Write | host                |
71
70
   | Interval (a)            | t    | Read/Write | interval            |
 
71
   | KeyID                   | s    | Read       | key_id              |
72
72
   | LastApprovalRequest (g) | s    | Read       | N/A                 |
73
73
   | LastCheckedOK (h)       | s    | Read/Write | N/A                 |
74
74
   | LastCheckerStatus (i)   | n    | Read       | N/A                 |
131
131
 
132
132
* Copyright
133
133
 
134
 
    Copyright © 2010-2019 Teddy Hogeborn
135
 
    Copyright © 2010-2019 Björn Påhlsson
 
134
    Copyright © 2010-2020 Teddy Hogeborn
 
135
    Copyright © 2010-2020 Björn Påhlsson
136
136
  
137
137
** License:
138
138