To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 1263
- compare with another revision
- download diff
- download tarball
- view history from revision 1263
- Committer: Teddy Hogeborn
- Date: 2023-02-07 19:11:25 UTC
- Revision ID: teddy@recompile.se-20230207191125-u7wl4mshb7cl3xi2
White space fixes only
* mandos-keygen: Reformat; remove white space from empty lines.
* mandos-keygen: Reformat; remove white space from empty lines.
- files added:
- bugs.xml
- debian/tests
- dracut-module
- plugin-helpers
- files removed:
- initramfs-tools-hook-conf
- files modified:
- .bzrignore
added
removed
plugin-runner.c
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2008-2014 Teddy Hogeborn
6
* Copyright © 2008-2014 Björn Påhlsson
7
*
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
12
*
13
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2022 Teddy Hogeborn
6
* Copyright © 2008-2022 Björn Påhlsson
7
*
8
* This file is part of Mandos.
9
*
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
14
*
15
* Mandos is distributed in the hope that it will be useful, but
14
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
15
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16
18
* General Public License for more details.
17
19
*
18
20
* You should have received a copy of the GNU General Public License
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
21
22
*
22
23
* Contact the authors at <mandos@recompile.se>.
23
24
*/
24
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
O_CLOEXEC */
26
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
27
getline(), asprintf(), O_CLOEXEC,
28
scandirat(), pipe2() */
29
#include <argp.h> /* argp_program_version,
30
argp_program_bug_address,
31
struct argp_option,
32
struct argp_state, argp_error(),
33
ARGP_NO_EXIT, argp_state_help,
34
ARGP_HELP_STD_HELP,
35
ARGP_HELP_USAGE, ARGP_HELP_EXIT_OK,
36
ARGP_KEY_ARG, ARGP_ERR_UNKNOWN,
37
struct argp, argp_parse(),
38
ARGP_IN_ORDER, ARGP_NO_HELP */
39
#include <stdbool.h> /* bool, false, true */
40
#include <sys/types.h> /* pid_t, sig_atomic_t, uid_t, gid_t,
41
getuid(), setgid(), setuid() */
27
42
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
29
realloc() */
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* DIR, fdopendir(), fstat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
37
dirfd() */
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
FD_SET(), FD_ISSET(), FD_CLR */
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG(),
42
WCOREDUMP() */
43
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
44
#include <iso646.h> /* and, or, not */
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
46
readdir(), closedir(), dirfd() */
47
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
48
FD_CLOEXEC, write(), STDOUT_FILENO,
49
struct stat, fstat(), close(),
50
setgid(), setuid(), S_ISREG(),
51
faccessat() pipe(), fork(),
52
_exit(), dup2(), fexecve(), read()
53
*/
43
#include <iso646.h> /* or, and, not */
44
#include <string.h> /* strcmp(), strdup(), strchrnul(),
45
strncmp(), strlen(), strcpy(),
46
strsep(), strchr(), strsignal() */
47
#include <stdlib.h> /* malloc(), free(), reallocarray(),
48
realloc(), EXIT_SUCCESS */
49
#include <errno.h> /* errno, EINTR, ENOMEM, ECHILD,
50
error_t, EINVAL, EMFILE, ENFILE,
51
ENOENT, ESRCH */
52
#include <stdint.h> /* SIZE_MAX */
53
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
54
getline(), asprintf(), O_CLOEXEC,
55
scandirat(), pipe2() */
56
#include <unistd.h> /* TEMP_FAILURE_RETRY(), ssize_t,
57
write(), STDOUT_FILENO, uid_t,
58
gid_t, getuid(), fchown(), close(),
59
symlink(), setgid(), setuid(),
60
faccessat(), X_OK, pipe(), pipe2(),
61
fork(), _exit(), dup2(), fexecve(),
62
read(), getpass() */
54
63
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
FD_CLOEXEC, openat() */
56
#include <string.h> /* strsep, strlen(), strsignal(),
57
strcmp(), strncmp() */
58
#include <errno.h> /* errno */
59
#include <argp.h> /* struct argp_option, struct
60
argp_state, struct argp,
61
argp_parse(), ARGP_ERR_UNKNOWN,
62
ARGP_KEY_END, ARGP_KEY_ARG,
63
error_t */
64
#include <signal.h> /* struct sigaction, sigemptyset(),
65
sigaddset(), sigaction(),
66
sigprocmask(), SIG_BLOCK, SIGCHLD,
67
SIG_UNBLOCK, kill(), sig_atomic_t
68
*/
69
#include <errno.h> /* errno, EBADF */
70
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
64
FD_CLOEXEC, open(), O_RDONLY,
65
O_CLOEXEC, openat() */
66
#include <sys/wait.h> /* waitpid(), WNOHANG, WIFEXITED(),
67
WEXITSTATUS(), WIFSIGNALED(),
68
WTERMSIG(), wait() */
69
#include <error.h> /* error() */
70
#include <stdio.h> /* FILE, fprintf(), fopen(),
71
getline(), fclose(), EOF,
72
asprintf(), stderr */
73
#include <dirent.h> /* struct dirent, scandirat(),
74
alphasort() */
75
#include <sys/stat.h> /* struct stat, fstat(), S_ISDIR(),
76
lstat(), S_ISREG() */
77
#include <sys/select.h> /* fd_set, FD_ZERO(), FD_SETSIZE,
78
FD_SET(), select(), FD_CLR(),
79
FD_ISSET() */
80
#include <signal.h> /* struct sigaction, SA_NOCLDSTOP,
81
sigemptyset(), sigaddset(),
82
SIGCHLD, sigprocmask(), SIG_BLOCK,
83
SIG_UNBLOCK, kill(), SIGTERM */
71
84
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
72
85
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
73
#include <errno.h> /* errno */
74
#include <error.h> /* error() */
75
#include <fnmatch.h> /* fnmatch() */
86
#include <inttypes.h> /* intmax_t, strtoimax(), PRIdMAX */
87
#include <fnmatch.h> /* fnmatch(), FNM_FILE_NAME,
88
FNM_PERIOD, FNM_NOMATCH */
76
89
77
90
#define BUFFER_SIZE 256
78
91
79
92
#define PDIR "/lib/mandos/plugins.d"
93
#define PHDIR "/lib/mandos/plugin-helpers"
80
94
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
81
95
82
96
const char *argp_program_version = "plugin-runner " VERSION;
179
193
/* Resize the pointed-to array to hold one more pointer */
180
194
char **new_array = NULL;
181
195
do {
182
new_array = realloc(*array, sizeof(char *)
183
* (size_t) ((*len) + 2));
196
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
197
new_array = reallocarray(*array, (size_t)((*len) + 2),
198
sizeof(char *));
199
#else
200
if(((size_t)((*len) + 2)) > (SIZE_MAX / sizeof(char *))){
201
/* overflow */
202
new_array = NULL;
203
errno = ENOMEM;
204
} else {
205
new_array = realloc(*array, (size_t)((*len) + 2)
206
* sizeof(char *));
207
}
208
#endif
184
209
} while(new_array == NULL and errno == EINTR);
185
210
/* Malloc check */
186
211
if(new_array == NULL){
241
266
return add_to_char_array(def, &(p->environ), &(p->envc));
242
267
}
243
268
269
#ifndef O_CLOEXEC
244
270
/*
245
271
* Based on the example in the GNU LibC manual chapter 13.13 "File
246
272
* Descriptor Flags".
257
283
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
258
284
ret | FD_CLOEXEC));
259
285
}
286
#endif /* not O_CLOEXEC */
260
287
261
288
262
289
/* Mark processes as completed when they exit, and save their exit
311
338
__attribute__((nonnull))
312
339
static void free_plugin(plugin *plugin_node){
313
340
314
for(char **arg = plugin_node->argv; *arg != NULL; arg++){
341
for(char **arg = (plugin_node->argv)+1; *arg != NULL; arg++){
315
342
free(*arg);
316
343
}
344
free(plugin_node->name);
317
345
free(plugin_node->argv);
318
346
for(char **env = plugin_node->environ; *env != NULL; env++){
319
347
free(*env);
346
374
347
375
int main(int argc, char *argv[]){
348
376
char *plugindir = NULL;
377
char *pluginhelperdir = NULL;
349
378
char *argfile = NULL;
350
379
FILE *conffp;
351
DIR *dir = NULL;
352
struct dirent *dirst;
380
struct dirent **direntries = NULL;
353
381
struct stat st;
354
382
fd_set rfds_all;
355
383
int ret, maxfd = 0;
363
391
.sa_flags = SA_NOCLDSTOP };
364
392
char **custom_argv = NULL;
365
393
int custom_argc = 0;
366
int dir_fd;
394
int dir_fd = -1;
367
395
368
396
/* Establish a signal handler */
369
397
sigemptyset(&sigchld_action.sa_mask);
414
442
.doc = "Group ID the plugins will run as", .group = 3 },
415
443
{ .name = "debug", .key = 132,
416
444
.doc = "Debug mode", .group = 4 },
445
{ .name = "plugin-helper-dir", .key = 133,
446
.arg = "DIRECTORY",
447
.doc = "Specify a different plugin helper directory",
448
.group = 2 },
417
449
/*
418
450
* These reproduce what we would get without ARGP_NO_HELP
419
451
*/
545
577
case 132: /* --debug */
546
578
debug = true;
547
579
break;
580
case 133: /* --plugin-helper-dir */
581
free(pluginhelperdir);
582
pluginhelperdir = strdup(arg);
583
if(pluginhelperdir != NULL){
584
errno = 0;
585
}
586
break;
548
587
/*
549
588
* These reproduce what we would get without ARGP_NO_HELP
550
589
*/
551
590
case '?': /* --help */
552
591
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
553
592
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
593
__builtin_unreachable();
554
594
case -3: /* --usage */
555
595
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
556
596
argp_state_help(state, state->out_stream,
557
597
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
598
__builtin_unreachable();
558
599
case 'V': /* --version */
559
600
fprintf(state->out_stream, "%s\n", argp_program_version);
560
601
exit(EXIT_SUCCESS);
570
611
if(arg[0] == '\0'){
571
612
break;
572
613
}
614
#if __GNUC__ >= 7
615
__attribute__((fallthrough));
616
#else
617
/* FALLTHROUGH */
618
#endif
573
619
default:
574
620
return ARGP_ERR_UNKNOWN;
575
621
}
601
647
case 130: /* --userid */
602
648
case 131: /* --groupid */
603
649
case 132: /* --debug */
650
case 133: /* --plugin-helper-dir */
604
651
case '?': /* --help */
605
652
case -3: /* --usage */
606
653
case 'V': /* --version */
686
733
687
734
custom_argc += 1;
688
735
{
689
char **new_argv = realloc(custom_argv, sizeof(char *)
690
* ((unsigned int)
691
custom_argc + 1));
736
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
737
char **new_argv = reallocarray(custom_argv,
738
(size_t)custom_argc + 1,
739
sizeof(char *));
740
#else
741
char **new_argv = NULL;
742
if(((size_t)custom_argc + 1) > (SIZE_MAX / sizeof(char *))){
743
/* overflow */
744
errno = ENOMEM;
745
} else {
746
new_argv = realloc(custom_argv, ((size_t)custom_argc + 1)
747
* sizeof(char *));
748
}
749
#endif
692
750
if(new_argv == NULL){
693
error(0, errno, "realloc");
751
error(0, errno, "reallocarray");
694
752
exitstatus = EX_OSERR;
695
753
free(new_arg);
696
754
free(org_line);
761
819
goto fallback;
762
820
}
763
821
822
{
823
char *pluginhelperenv;
824
bool bret = true;
825
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
826
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
827
if(ret != -1){
828
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
829
}
830
if(ret == -1 or not bret){
831
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
832
" environment variable to \"%s\" for all plugins\n",
833
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
834
}
835
if(ret != -1){
836
free(pluginhelperenv);
837
}
838
}
839
764
840
if(debug){
765
for(plugin *p = plugin_list; p != NULL; p=p->next){
841
for(plugin *p = plugin_list; p != NULL; p = p->next){
766
842
fprintf(stderr, "Plugin: %s has %d arguments\n",
767
843
p->name ? p->name : "Global", p->argc - 1);
768
844
for(char **a = p->argv; *a != NULL; a++){
777
853
778
854
if(getuid() == 0){
779
855
/* Work around Debian bug #633582:
780
<http://bugs.debian.org/633582> */
856
<https://bugs.debian.org/633582> */
781
857
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
782
858
if(plugindir_fd == -1){
783
859
if(errno != ENOENT){
795
871
}
796
872
}
797
873
}
798
TEMP_FAILURE_RETRY(close(plugindir_fd));
874
close(plugindir_fd);
875
}
876
877
/* Work around Debian bug #981302
878
<https://bugs.debian.org/981302> */
879
if(lstat("/dev/fd", &st) != 0 and errno == ENOENT){
880
ret = symlink("/proc/self/fd", "/dev/fd");
881
if(ret == -1){
882
error(0, errno, "Failed to create /dev/fd symlink");
883
}
799
884
}
800
885
}
801
886
829
914
ret = set_cloexec_flag(dir_fd);
830
915
if(ret < 0){
831
916
error(0, errno, "set_cloexec_flag");
832
TEMP_FAILURE_RETRY(close(dir_fd));
833
917
exitstatus = EX_OSERR;
834
918
goto fallback;
835
919
}
836
920
#endif /* O_CLOEXEC */
837
838
dir = fdopendir(dir_fd);
839
if(dir == NULL){
840
error(0, errno, "Could not open plugin dir");
841
TEMP_FAILURE_RETRY(close(dir_fd));
842
exitstatus = EX_OSERR;
843
goto fallback;
921
}
922
923
int good_name(const struct dirent * const dirent){
924
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
925
"*.dpkg-old", "*.dpkg-bak",
926
"*.dpkg-divert", NULL };
927
#ifdef __GNUC__
928
#pragma GCC diagnostic push
929
#pragma GCC diagnostic ignored "-Wcast-qual"
930
#endif
931
for(const char **pat = (const char **)patterns;
932
*pat != NULL; pat++){
933
#ifdef __GNUC__
934
#pragma GCC diagnostic pop
935
#endif
936
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
937
!= FNM_NOMATCH){
938
if(debug){
939
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
940
" matching pattern %s\n", dirent->d_name, *pat);
941
}
942
return 0;
943
}
844
944
}
945
return 1;
946
}
947
948
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
949
alphasort);
950
if(numplugins == -1){
951
error(0, errno, "Could not scan plugin dir");
952
direntries = NULL;
953
exitstatus = EX_OSERR;
954
goto fallback;
845
955
}
846
956
847
957
FD_ZERO(&rfds_all);
848
958
849
959
/* Read and execute any executable in the plugin directory*/
850
while(true){
851
do {
852
dirst = readdir(dir);
853
} while(dirst == NULL and errno == EINTR);
854
855
/* All directory entries have been processed */
856
if(dirst == NULL){
857
if(errno == EBADF){
858
error(0, errno, "readdir");
859
exitstatus = EX_IOERR;
860
goto fallback;
861
}
862
break;
863
}
864
865
/* Ignore dotfiles, backup files and other junk */
866
{
867
bool bad_name = false;
868
const char * const patterns[] = { ".*", "#*#", "*~",
869
"*.dpkg-new", "*.dpkg-old",
870
"*.dpkg-bak", "*.dpkg-divert",
871
NULL };
872
#ifdef __GNUC__
873
#pragma GCC diagnostic push
874
#pragma GCC diagnostic ignored "-Wcast-qual"
875
#endif
876
for(const char **pat = (const char **)patterns;
877
*pat != NULL; pat++){
878
#ifdef __GNUC__
879
#pragma GCC diagnostic pop
880
#endif
881
if(fnmatch(*pat, dirst->d_name,
882
FNM_FILE_NAME | FNM_PERIOD) != FNM_NOMATCH){
883
if(debug){
884
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
885
" matching pattern %s\n", dirst->d_name, *pat);
886
}
887
bad_name = true;
888
break;
889
}
890
}
891
if(bad_name){
892
continue;
893
}
894
}
895
896
int plugin_fd = openat(dir_fd, dirst->d_name, O_RDONLY |
897
#ifdef O_CLOEXEC
898
O_CLOEXEC
899
#else /* not O_CLOEXEC */
900
0
901
#endif /* not O_CLOEXEC */
902
);
960
for(int i = 0; i < numplugins; i++){
961
962
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
903
963
if(plugin_fd == -1){
904
964
error(0, errno, "Could not open plugin");
905
continue;
906
}
907
#ifndef O_CLOEXEC
908
/* Set the FD_CLOEXEC flag on the plugin FD */
909
ret = set_cloexec_flag(plugin_fd);
910
if(ret < 0){
911
error(0, errno, "set_cloexec_flag");
912
TEMP_FAILURE_RETRY(close(plugin_fd));
913
continue;
914
}
915
#endif /* O_CLOEXEC */
965
free(direntries[i]);
966
continue;
967
}
916
968
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
917
969
if(ret == -1){
918
970
error(0, errno, "stat");
919
TEMP_FAILURE_RETRY(close(plugin_fd));
971
close(plugin_fd);
972
free(direntries[i]);
920
973
continue;
921
974
}
922
975
923
976
/* Ignore non-executable files */
924
977
if(not S_ISREG(st.st_mode)
925
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, dirst->d_name, X_OK,
926
0)) != 0)){
978
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
979
X_OK, 0)) != 0)){
927
980
if(debug){
928
981
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
929
982
" with bad type or mode\n",
930
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
983
plugindir != NULL ? plugindir : PDIR,
984
direntries[i]->d_name);
931
985
}
932
TEMP_FAILURE_RETRY(close(plugin_fd));
986
close(plugin_fd);
987
free(direntries[i]);
933
988
continue;
934
989
}
935
990
936
plugin *p = getplugin(dirst->d_name);
991
plugin *p = getplugin(direntries[i]->d_name);
937
992
if(p == NULL){
938
993
error(0, errno, "getplugin");
939
TEMP_FAILURE_RETRY(close(plugin_fd));
994
close(plugin_fd);
995
free(direntries[i]);
940
996
continue;
941
997
}
942
998
if(p->disabled){
943
999
if(debug){
944
1000
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
945
dirst->d_name);
1001
direntries[i]->d_name);
946
1002
}
947
TEMP_FAILURE_RETRY(close(plugin_fd));
1003
close(plugin_fd);
1004
free(direntries[i]);
948
1005
continue;
949
1006
}
950
1007
{
975
1032
}
976
1033
977
1034
int pipefd[2];
1035
#ifndef O_CLOEXEC
978
1036
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1037
#else /* O_CLOEXEC */
1038
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
1039
#endif /* O_CLOEXEC */
979
1040
if(ret == -1){
980
1041
error(0, errno, "pipe");
981
1042
exitstatus = EX_OSERR;
982
goto fallback;
983
}
1043
free(direntries[i]);
1044
goto fallback;
1045
}
1046
if(pipefd[0] >= FD_SETSIZE){
1047
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1048
FD_SETSIZE);
1049
close(pipefd[0]);
1050
close(pipefd[1]);
1051
exitstatus = EX_OSERR;
1052
free(direntries[i]);
1053
goto fallback;
1054
}
1055
#ifndef O_CLOEXEC
984
1056
/* Ask OS to automatic close the pipe on exec */
985
1057
ret = set_cloexec_flag(pipefd[0]);
986
1058
if(ret < 0){
987
1059
error(0, errno, "set_cloexec_flag");
988
TEMP_FAILURE_RETRY(close(pipefd[0]));
989
TEMP_FAILURE_RETRY(close(pipefd[1]));
1060
close(pipefd[0]);
1061
close(pipefd[1]);
990
1062
exitstatus = EX_OSERR;
1063
free(direntries[i]);
991
1064
goto fallback;
992
1065
}
993
1066
ret = set_cloexec_flag(pipefd[1]);
994
1067
if(ret < 0){
995
1068
error(0, errno, "set_cloexec_flag");
996
TEMP_FAILURE_RETRY(close(pipefd[0]));
997
TEMP_FAILURE_RETRY(close(pipefd[1]));
1069
close(pipefd[0]);
1070
close(pipefd[1]);
998
1071
exitstatus = EX_OSERR;
1072
free(direntries[i]);
999
1073
goto fallback;
1000
1074
}
1075
#endif /* not O_CLOEXEC */
1001
1076
/* Block SIGCHLD until process is safely in process list */
1002
1077
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1003
1078
&sigchld_action.sa_mask,
1005
1080
if(ret < 0){
1006
1081
error(0, errno, "sigprocmask");
1007
1082
exitstatus = EX_OSERR;
1083
free(direntries[i]);
1008
1084
goto fallback;
1009
1085
}
1010
1086
/* Starting a new process to be watched */
1014
1090
} while(pid == -1 and errno == EINTR);
1015
1091
if(pid == -1){
1016
1092
error(0, errno, "fork");
1093
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1094
&sigchld_action.sa_mask, NULL));
1095
close(pipefd[0]);
1096
close(pipefd[1]);
1017
1097
exitstatus = EX_OSERR;
1098
free(direntries[i]);
1018
1099
goto fallback;
1019
1100
}
1020
1101
if(pid == 0){
1036
1117
_exit(EX_OSERR);
1037
1118
}
1038
1119
1039
if(dirfd(dir) < 0){
1040
/* If dir has no file descriptor, we could not set FD_CLOEXEC
1041
above and must now close it manually here. */
1042
closedir(dir);
1043
}
1044
1120
if(fexecve(plugin_fd, p->argv,
1045
1121
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1046
1122
error(0, errno, "fexecve for %s/%s",
1047
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
1123
plugindir != NULL ? plugindir : PDIR,
1124
direntries[i]->d_name);
1048
1125
_exit(EX_OSERR);
1049
1126
}
1050
1127
/* no return */
1051
1128
}
1052
1129
/* Parent process */
1053
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1054
pipe */
1055
TEMP_FAILURE_RETRY(close(plugin_fd));
1056
plugin *new_plugin = getplugin(dirst->d_name);
1130
close(pipefd[1]); /* Close unused write end of pipe */
1131
close(plugin_fd);
1132
plugin *new_plugin = getplugin(direntries[i]->d_name);
1057
1133
if(new_plugin == NULL){
1058
1134
error(0, errno, "getplugin");
1059
1135
ret = (int)(TEMP_FAILURE_RETRY
1063
1139
error(0, errno, "sigprocmask");
1064
1140
}
1065
1141
exitstatus = EX_OSERR;
1142
free(direntries[i]);
1066
1143
goto fallback;
1067
1144
}
1145
free(direntries[i]);
1068
1146
1069
1147
new_plugin->pid = pid;
1070
1148
new_plugin->fd = pipefd[0];
1071
1149
1150
if(debug){
1151
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1152
new_plugin->name, (intmax_t) (new_plugin->pid));
1153
}
1154
1072
1155
/* Unblock SIGCHLD so signal handler can be run if this process
1073
1156
has already completed */
1074
1157
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1080
1163
goto fallback;
1081
1164
}
1082
1165
1083
#if defined (__GNUC__) and defined (__GLIBC__)
1084
#if not __GLIBC_PREREQ(2, 16)
1085
#pragma GCC diagnostic push
1086
#pragma GCC diagnostic ignored "-Wsign-conversion"
1087
#endif
1088
#endif
1089
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1090
-Wconversion in GNU libc
1091
before 2.16 */
1092
#if defined (__GNUC__) and defined (__GLIBC__)
1093
#if not __GLIBC_PREREQ(2, 16)
1094
#pragma GCC diagnostic pop
1095
#endif
1096
#endif
1166
FD_SET(new_plugin->fd, &rfds_all);
1097
1167
1098
1168
if(maxfd < new_plugin->fd){
1099
1169
maxfd = new_plugin->fd;
1100
1170
}
1101
1171
}
1102
1172
1103
TEMP_FAILURE_RETRY(closedir(dir));
1104
dir = NULL;
1173
free(direntries);
1174
direntries = NULL;
1175
close(dir_fd);
1176
dir_fd = -1;
1105
1177
free_plugin(getplugin(NULL));
1106
1178
1107
1179
for(plugin *p = plugin_list; p != NULL; p = p->next){
1146
1218
(intmax_t) (proc->pid),
1147
1219
WTERMSIG(proc->status),
1148
1220
strsignal(WTERMSIG(proc->status)));
1149
} else if(WCOREDUMP(proc->status)){
1150
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1151
" core\n", proc->name, (intmax_t) (proc->pid));
1152
1221
}
1153
1222
}
1154
1223
1155
1224
/* Remove the plugin */
1156
#if defined (__GNUC__) and defined (__GLIBC__)
1157
#if not __GLIBC_PREREQ(2, 16)
1158
#pragma GCC diagnostic push
1159
#pragma GCC diagnostic ignored "-Wsign-conversion"
1160
#endif
1161
#endif
1162
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1163
-Wconversion in GNU libc
1164
before 2.16 */
1165
#if defined (__GNUC__) and defined (__GLIBC__)
1166
#if not __GLIBC_PREREQ(2, 16)
1167
#pragma GCC diagnostic pop
1168
#endif
1169
#endif
1225
FD_CLR(proc->fd, &rfds_all);
1170
1226
1171
1227
/* Block signal while modifying process_list */
1172
1228
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1212
1268
}
1213
1269
1214
1270
/* This process has not completed. Does it have any output? */
1215
#if defined (__GNUC__) and defined (__GLIBC__)
1216
#if not __GLIBC_PREREQ(2, 16)
1217
#pragma GCC diagnostic push
1218
#pragma GCC diagnostic ignored "-Wsign-conversion"
1219
#endif
1220
#endif
1221
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1222
warning from
1223
-Wconversion
1224
in GNU libc
1225
before
1226
2.16 */
1227
#if defined (__GNUC__) and defined (__GLIBC__)
1228
#if not __GLIBC_PREREQ(2, 16)
1229
#pragma GCC diagnostic pop
1230
#endif
1231
#endif
1271
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1232
1272
/* This process had nothing to say at this time */
1233
1273
proc = proc->next;
1234
1274
continue;
1301
1341
free(custom_argv);
1302
1342
}
1303
1343
1304
if(dir != NULL){
1305
closedir(dir);
1344
free(direntries);
1345
1346
if(dir_fd != -1){
1347
close(dir_fd);
1306
1348
}
1307
1349
1308
1350
/* Kill the processes */
1328
1370
free_plugin_list();
1329
1371
1330
1372
free(plugindir);
1373
free(pluginhelperdir);
1331
1374
free(argfile);
1332
1375
1333
1376
return exitstatus;
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0