3
3
* Mandos plugin runner - Run Mandos plugins
5
* Copyright © 2008,2009 Teddy Hogeborn
6
* Copyright © 2008,2009 Björn Påhlsson
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
13
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2021 Teddy Hogeborn
6
* Copyright © 2008-2021 Björn Påhlsson
8
* This file is part of Mandos.
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
15
* Mandos is distributed in the hope that it will be useful, but
14
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
15
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16
18
* General Public License for more details.
18
20
* You should have received a copy of the GNU General Public License
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
23
* Contact the authors at <mandos@recompile.se>.
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
27
getline(), asprintf(), O_CLOEXEC,
28
scandirat(), pipe2() */
29
#include <argp.h> /* argp_program_version,
30
argp_program_bug_address,
32
struct argp_state, argp_error(),
33
ARGP_NO_EXIT, argp_state_help,
35
ARGP_HELP_USAGE, ARGP_HELP_EXIT_OK,
36
ARGP_KEY_ARG, ARGP_ERR_UNKNOWN,
37
struct argp, argp_parse(),
38
ARGP_IN_ORDER, ARGP_NO_HELP */
39
#include <stdbool.h> /* bool, false, true */
40
#include <sys/types.h> /* pid_t, sig_atomic_t, uid_t, gid_t,
41
getuid(), setgid(), setuid() */
27
42
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
FD_SET(), FD_ISSET(), FD_CLR */
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG(),
43
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
44
#include <iso646.h> /* and, or, not */
45
#include <dirent.h> /* DIR, struct dirent, opendir(),
46
readdir(), closedir(), dirfd() */
47
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
48
fcntl(), setuid(), setgid(),
49
F_GETFD, F_SETFD, FD_CLOEXEC,
50
access(), pipe(), fork(), close()
51
dup2(), STDOUT_FILENO, _exit(),
52
execv(), write(), read(),
43
#include <iso646.h> /* or, and, not */
44
#include <string.h> /* strcmp(), strdup(), strchrnul(),
45
strncmp(), strlen(), strcpy(),
46
strsep(), strchr(), strsignal() */
47
#include <stdlib.h> /* malloc(), free(), reallocarray(),
48
realloc(), EXIT_SUCCESS */
49
#include <errno.h> /* errno, EINTR, ENOMEM, ECHILD,
50
error_t, EINVAL, EMFILE, ENFILE,
52
#include <stdint.h> /* SIZE_MAX */
53
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
54
getline(), asprintf(), O_CLOEXEC,
55
scandirat(), pipe2() */
56
#include <unistd.h> /* TEMP_FAILURE_RETRY(), ssize_t,
57
write(), STDOUT_FILENO, uid_t,
58
gid_t, getuid(), fchown(), close(),
59
symlink(), setgid(), setuid(),
60
faccessat(), X_OK, pipe(), pipe2(),
61
fork(), _exit(), dup2(), fexecve(),
54
63
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
56
#include <string.h> /* strsep, strlen(), asprintf(),
57
strsignal(), strcmp(), strncmp() */
58
#include <errno.h> /* errno */
59
#include <argp.h> /* struct argp_option, struct
60
argp_state, struct argp,
61
argp_parse(), ARGP_ERR_UNKNOWN,
62
ARGP_KEY_END, ARGP_KEY_ARG,
64
#include <signal.h> /* struct sigaction, sigemptyset(),
65
sigaddset(), sigaction(),
66
sigprocmask(), SIG_BLOCK, SIGCHLD,
67
SIG_UNBLOCK, kill(), sig_atomic_t
69
#include <errno.h> /* errno, EBADF */
70
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
64
FD_CLOEXEC, open(), O_RDONLY,
65
O_CLOEXEC, openat() */
66
#include <sys/wait.h> /* waitpid(), WNOHANG, WIFEXITED(),
67
WEXITSTATUS(), WIFSIGNALED(),
69
#include <error.h> /* error() */
70
#include <stdio.h> /* FILE, fprintf(), fopen(),
71
getline(), fclose(), EOF,
73
#include <dirent.h> /* struct dirent, scandirat(),
75
#include <sys/stat.h> /* struct stat, fstat(), S_ISDIR(),
77
#include <sys/select.h> /* fd_set, FD_ZERO(), FD_SETSIZE,
78
FD_SET(), select(), FD_CLR(),
80
#include <signal.h> /* struct sigaction, SA_NOCLDSTOP,
81
sigemptyset(), sigaddset(),
82
SIGCHLD, sigprocmask(), SIG_BLOCK,
83
SIG_UNBLOCK, kill(), SIGTERM */
84
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
85
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
86
#include <inttypes.h> /* intmax_t, strtoimax(), PRIdMAX */
87
#include <fnmatch.h> /* fnmatch(), FNM_FILE_NAME,
88
FNM_PERIOD, FNM_NOMATCH */
72
90
#define BUFFER_SIZE 256
74
92
#define PDIR "/lib/mandos/plugins.d"
93
#define PHDIR "/lib/mandos/plugin-helpers"
75
94
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
77
96
const char *argp_program_version = "plugin-runner " VERSION;
78
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
97
const char *argp_program_bug_address = "<mandos@recompile.se>";
80
99
typedef struct plugin{
81
100
char *name; /* can be NULL or any plugin name */
394
442
.doc = "Group ID the plugins will run as", .group = 3 },
395
443
{ .name = "debug", .key = 132,
396
444
.doc = "Debug mode", .group = 4 },
445
{ .name = "plugin-helper-dir", .key = 133,
447
.doc = "Specify a different plugin helper directory",
450
* These reproduce what we would get without ARGP_NO_HELP
452
{ .name = "help", .key = '?',
453
.doc = "Give this help list", .group = -1 },
454
{ .name = "usage", .key = -3,
455
.doc = "Give a short usage message", .group = -1 },
456
{ .name = "version", .key = 'V',
457
.doc = "Print program version", .group = -1 },
400
error_t parse_opt(int key, char *arg, __attribute__((unused))
401
struct argp_state *state){
461
__attribute__((nonnull(3)))
462
error_t parse_opt(int key, char *arg, struct argp_state *state){
405
467
case 'g': /* --global-options */
407
469
char *plugin_option;
408
470
while((plugin_option = strsep(&arg, ",")) != NULL){
409
if(plugin_option[0] == '\0'){
412
471
if(not add_argument(getplugin(NULL), plugin_option)){
413
perror("add_argument");
414
return ARGP_ERR_UNKNOWN;
419
478
case 'G': /* --global-env */
423
if(not add_environment(getplugin(NULL), arg, true)){
424
perror("add_environment");
479
if(add_environment(getplugin(NULL), arg, true)){
427
483
case 'o': /* --options-for */
429
char *plugin_name = strsep(&arg, ":");
430
if(plugin_name[0] == '\0'){
434
while((plugin_option = strsep(&arg, ",")) != NULL){
435
if(not add_argument(getplugin(plugin_name), plugin_option)){
436
perror("add_argument");
437
return ARGP_ERR_UNKNOWN;
485
char *option_list = strchr(arg, ':');
486
if(option_list == NULL){
487
argp_error(state, "No colon in \"%s\"", arg);
494
argp_error(state, "Empty plugin name");
499
while((option = strsep(&option_list, ",")) != NULL){
500
if(not add_argument(getplugin(arg), option)){
442
507
case 'E': /* --env-for */
447
509
char *envdef = strchr(arg, ':');
448
510
if(envdef == NULL){
511
argp_error(state, "No colon in \"%s\"", arg);
452
if(not add_environment(getplugin(arg), envdef+1, true)){
453
perror("add_environment");
518
argp_error(state, "Empty plugin name");
522
if(add_environment(getplugin(arg), envdef, true)){
457
527
case 'd': /* --disable */
459
529
plugin *p = getplugin(arg);
461
return ARGP_ERR_UNKNOWN;
466
536
case 'e': /* --enable */
468
538
plugin *p = getplugin(arg);
470
return ARGP_ERR_UNKNOWN;
475
545
case 128: /* --plugin-dir */
477
547
plugindir = strdup(arg);
478
if(plugindir == NULL){
548
if(plugindir != NULL){
482
552
case 129: /* --config-file */
483
553
/* This is already done by parse_opt_config_file() */
485
555
case 130: /* --userid */
487
tmpmax = strtoimax(arg, &tmp, 10);
556
tmp_id = strtoimax(arg, &tmp, 10);
488
557
if(errno != 0 or tmp == arg or *tmp != '\0'
489
or tmpmax != (uid_t)tmpmax){
490
fprintf(stderr, "Bad user ID number: \"%s\", using %"
491
PRIdMAX "\n", arg, (intmax_t)uid);
558
or tmp_id != (uid_t)tmp_id){
559
argp_error(state, "Bad user ID number: \"%s\", using %"
560
PRIdMAX, arg, (intmax_t)uid);
496
566
case 131: /* --groupid */
498
tmpmax = strtoimax(arg, &tmp, 10);
567
tmp_id = strtoimax(arg, &tmp, 10);
499
568
if(errno != 0 or tmp == arg or *tmp != '\0'
500
or tmpmax != (gid_t)tmpmax){
501
fprintf(stderr, "Bad group ID number: \"%s\", using %"
502
PRIdMAX "\n", arg, (intmax_t)gid);
569
or tmp_id != (gid_t)tmp_id){
570
argp_error(state, "Bad group ID number: \"%s\", using %"
571
PRIdMAX, arg, (intmax_t)gid);
507
577
case 132: /* --debug */
580
case 133: /* --plugin-helper-dir */
581
free(pluginhelperdir);
582
pluginhelperdir = strdup(arg);
583
if(pluginhelperdir != NULL){
588
* These reproduce what we would get without ARGP_NO_HELP
590
case '?': /* --help */
591
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
592
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
593
__builtin_unreachable();
594
case -3: /* --usage */
595
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
596
argp_state_help(state, state->out_stream,
597
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
598
__builtin_unreachable();
599
case 'V': /* --version */
600
fprintf(state->out_stream, "%s\n", argp_program_version);
511
604
* When adding more options before this line, remember to also add a
512
605
* "case" to the "parse_opt_config_file" function below.
648
774
/* Check for harmful errors and go to fallback. Other errors might
649
775
not affect opening plugins */
650
776
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
652
exitstatus = EXIT_FAILURE;
777
error(0, errno, "fopen");
778
exitstatus = EX_OSERR;
656
/* If there was any arguments from configuration file,
657
pass them to parser as command arguments */
782
/* If there were any arguments from the configuration file, pass
783
them to parser as command line arguments */
658
784
if(custom_argv != NULL){
659
ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
661
if(ret == ARGP_ERR_UNKNOWN){
662
fprintf(stderr, "Unknown error while parsing arguments\n");
663
exitstatus = EXIT_FAILURE;
785
ret = argp_parse(&argp, custom_argc, custom_argv,
786
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
794
error(0, errno, "argp_parse");
795
exitstatus = EX_OSERR;
798
exitstatus = EX_CONFIG;
668
803
/* Parse actual command line arguments, to let them override the
670
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
671
if(ret == ARGP_ERR_UNKNOWN){
672
fprintf(stderr, "Unknown error while parsing arguments\n");
673
exitstatus = EXIT_FAILURE;
805
ret = argp_parse(&argp, argc, argv,
806
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
814
error(0, errno, "argp_parse");
815
exitstatus = EX_OSERR;
818
exitstatus = EX_USAGE;
823
char *pluginhelperenv;
825
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
826
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
828
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
830
if(ret == -1 or not bret){
831
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
832
" environment variable to \"%s\" for all plugins\n",
833
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
836
free(pluginhelperenv);
678
for(plugin *p = plugin_list; p != NULL; p=p->next){
841
for(plugin *p = plugin_list; p != NULL; p = p->next){
679
842
fprintf(stderr, "Plugin: %s has %d arguments\n",
680
843
p->name ? p->name : "Global", p->argc - 1);
681
844
for(char **a = p->argv; *a != NULL; a++){
691
/* Strip permissions down to nobody */
855
/* Work around Debian bug #633582:
856
<https://bugs.debian.org/633582> */
857
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
858
if(plugindir_fd == -1){
860
error(0, errno, "open(\"" PDIR "\")");
863
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
865
error(0, errno, "fstat");
867
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
868
ret = fchown(plugindir_fd, uid, gid);
870
error(0, errno, "fchown");
877
/* Work around Debian bug #981302
878
<https://bugs.debian.org/981302> */
879
if(lstat("/dev/fd", &st) != 0 and errno == ENOENT){
880
ret = symlink("/proc/self/fd", "/dev/fd");
882
error(0, errno, "Failed to create /dev/fd symlink");
887
/* Lower permissions */
890
error(0, errno, "setgid");
696
892
ret = setuid(uid);
701
if(plugindir == NULL){
704
dir = opendir(plugindir);
708
perror("Could not open plugin dir");
709
exitstatus = EXIT_FAILURE;
713
/* Set the FD_CLOEXEC flag on the directory, if possible */
894
error(0, errno, "setuid");
897
/* Open plugin directory with close_on_exec flag */
715
int dir_fd = dirfd(dir);
717
ret = set_cloexec_flag(dir_fd);
719
perror("set_cloexec_flag");
720
exitstatus = EXIT_FAILURE;
899
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
902
#else /* not O_CLOEXEC */
904
#endif /* not O_CLOEXEC */
907
error(0, errno, "Could not open plugin dir");
908
exitstatus = EX_UNAVAILABLE;
913
/* Set the FD_CLOEXEC flag on the directory */
914
ret = set_cloexec_flag(dir_fd);
916
error(0, errno, "set_cloexec_flag");
917
exitstatus = EX_OSERR;
920
#endif /* O_CLOEXEC */
923
int good_name(const struct dirent * const dirent){
924
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
925
"*.dpkg-old", "*.dpkg-bak",
926
"*.dpkg-divert", NULL };
928
#pragma GCC diagnostic push
929
#pragma GCC diagnostic ignored "-Wcast-qual"
931
for(const char **pat = (const char **)patterns;
932
*pat != NULL; pat++){
934
#pragma GCC diagnostic pop
936
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
939
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
940
" matching pattern %s\n", dirent->d_name, *pat);
948
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
950
if(numplugins == -1){
951
error(0, errno, "Could not scan plugin dir");
953
exitstatus = EX_OSERR;
726
957
FD_ZERO(&rfds_all);
728
959
/* Read and execute any executable in the plugin directory*/
731
dirst = readdir(dir);
732
} while(dirst == NULL and errno == EINTR);
734
/* All directory entries have been processed */
738
exitstatus = EXIT_FAILURE;
744
d_name_len = strlen(dirst->d_name);
746
/* Ignore dotfiles, backup files and other junk */
748
bool bad_name = false;
750
const char const *bad_prefixes[] = { ".", "#", NULL };
752
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
755
".dpkg-divert", NULL };
756
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
757
size_t pre_len = strlen(*pre);
758
if((d_name_len >= pre_len)
759
and strncmp((dirst->d_name), *pre, pre_len) == 0){
761
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
762
" with bad prefix %s\n", dirst->d_name, *pre);
771
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
772
size_t suf_len = strlen(*suf);
773
if((d_name_len >= suf_len)
774
and (strcmp((dirst->d_name) + d_name_len-suf_len, *suf)
777
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
778
" with bad suffix %s\n", dirst->d_name, *suf);
791
if(plugindir == NULL){
792
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, PDIR "/%s",
795
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, "%s/%s",
960
for(int i = 0; i < numplugins; i++){
962
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
964
error(0, errno, "Could not open plugin");
804
ret = (int)TEMP_FAILURE_RETRY(stat(filename, &st));
968
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
970
error(0, errno, "stat");
811
976
/* Ignore non-executable files */
812
977
if(not S_ISREG(st.st_mode)
813
or (TEMP_FAILURE_RETRY(access(filename, X_OK)) != 0)){
978
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
815
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
816
" with bad type or mode\n", filename);
981
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
982
" with bad type or mode\n",
983
plugindir != NULL ? plugindir : PDIR,
984
direntries[i]->d_name);
822
plugin *p = getplugin(dirst->d_name);
991
plugin *p = getplugin(direntries[i]->d_name);
993
error(0, errno, "getplugin");
830
1000
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
1001
direntries[i]->d_name);
1004
free(direntries[i]);
840
1011
for(char **a = g->argv + 1; *a != NULL; a++){
841
1012
if(not add_argument(p, *a)){
842
perror("add_argument");
1013
error(0, errno, "add_argument");
845
1016
/* Add global environment variables */
846
1017
for(char **e = g->environ; *e != NULL; e++){
847
1018
if(not add_environment(p, *e, false)){
848
perror("add_environment");
1019
error(0, errno, "add_environment");
853
/* If this plugin has any environment variables, we will call
854
using execve and need to duplicate the environment from this
1024
/* If this plugin has any environment variables, we need to
1025
duplicate the environment from this process, too. */
856
1026
if(p->environ[0] != NULL){
857
1027
for(char **e = environ; *e != NULL; e++){
858
1028
if(not add_environment(p, *e, false)){
859
perror("add_environment");
1029
error(0, errno, "add_environment");
865
1036
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1037
#else /* O_CLOEXEC */
1038
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
1039
#endif /* O_CLOEXEC */
868
exitstatus = EXIT_FAILURE;
1041
error(0, errno, "pipe");
1042
exitstatus = EX_OSERR;
1043
free(direntries[i]);
1046
if(pipefd[0] >= FD_SETSIZE){
1047
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1051
exitstatus = EX_OSERR;
1052
free(direntries[i]);
871
1056
/* Ask OS to automatic close the pipe on exec */
872
1057
ret = set_cloexec_flag(pipefd[0]);
874
perror("set_cloexec_flag");
875
exitstatus = EXIT_FAILURE;
1059
error(0, errno, "set_cloexec_flag");
1062
exitstatus = EX_OSERR;
1063
free(direntries[i]);
878
1066
ret = set_cloexec_flag(pipefd[1]);
880
perror("set_cloexec_flag");
881
exitstatus = EXIT_FAILURE;
1068
error(0, errno, "set_cloexec_flag");
1071
exitstatus = EX_OSERR;
1072
free(direntries[i]);
1075
#endif /* not O_CLOEXEC */
884
1076
/* Block SIGCHLD until process is safely in process list */
885
1077
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
886
1078
&sigchld_action.sa_mask,
889
perror("sigprocmask");
890
exitstatus = EXIT_FAILURE;
1081
error(0, errno, "sigprocmask");
1082
exitstatus = EX_OSERR;
1083
free(direntries[i]);
893
1086
/* Starting a new process to be watched */
897
1090
} while(pid == -1 and errno == EINTR);
900
exitstatus = EXIT_FAILURE;
1092
error(0, errno, "fork");
1093
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1094
&sigchld_action.sa_mask, NULL));
1097
exitstatus = EX_OSERR;
1098
free(direntries[i]);
904
1102
/* this is the child process */
905
1103
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1105
error(0, errno, "sigaction");
910
1108
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
912
perror("sigprocmask");
1110
error(0, errno, "sigprocmask");
916
1114
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1116
error(0, errno, "dup2");
923
/* If dir has no file descriptor, we could not set FD_CLOEXEC
924
above and must now close it manually here. */
927
if(p->environ[0] == NULL){
928
if(execv(filename, p->argv) < 0){
933
if(execve(filename, p->argv, p->environ) < 0){
1120
if(fexecve(plugin_fd, p->argv,
1121
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1122
error(0, errno, "fexecve for %s/%s",
1123
plugindir != NULL ? plugindir : PDIR,
1124
direntries[i]->d_name);
940
1129
/* Parent process */
941
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
944
plugin *new_plugin = getplugin(dirst->d_name);
1130
close(pipefd[1]); /* Close unused write end of pipe */
1132
plugin *new_plugin = getplugin(direntries[i]->d_name);
945
1133
if(new_plugin == NULL){
1134
error(0, errno, "getplugin");
947
1135
ret = (int)(TEMP_FAILURE_RETRY
948
1136
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
951
perror("sigprocmask");
1139
error(0, errno, "sigprocmask");
953
exitstatus = EXIT_FAILURE;
1141
exitstatus = EX_OSERR;
1142
free(direntries[i]);
1145
free(direntries[i]);
957
1147
new_plugin->pid = pid;
958
1148
new_plugin->fd = pipefd[0];
1151
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1152
new_plugin->name, (intmax_t) (new_plugin->pid));
960
1155
/* Unblock SIGCHLD so signal handler can be run if this process
961
1156
has already completed */
962
1157
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
963
1158
&sigchld_action.sa_mask,
966
perror("sigprocmask");
967
exitstatus = EXIT_FAILURE;
1161
error(0, errno, "sigprocmask");
1162
exitstatus = EX_OSERR;
971
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1166
FD_SET(new_plugin->fd, &rfds_all);
974
1168
if(maxfd < new_plugin->fd){
975
1169
maxfd = new_plugin->fd;
979
TEMP_FAILURE_RETRY(closedir(dir));
981
1177
free_plugin(getplugin(NULL));
983
1179
for(plugin *p = plugin_list; p != NULL; p = p->next){