/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to Makefile

  • Committer: Teddy Hogeborn
  • Date: 2022-04-23 23:58:39 UTC
  • Revision ID: teddy@recompile.se-20220423235839-cnt9aq1kjveqaydc
Bug fix in mandos-ctl: handle backslashes in password

* mandos-ctl (mode=password): When sending the password to gpg, use
  "printf" instead of "echo -n".  This avoids the behavior of the
  "echo" builtin in "dash", which always interprets backslash escape
  codes.

Reported-By: Jesse Norell <jesse@kci.net>

Show diffs side-by-side

added added

removed removed

Lines of Context:
Makefile
29
29
 
30
30
# For info about _FORTIFY_SOURCE, see feature_test_macros(7)
31
31
# and <https://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>.
32
 
FORTIFY:=-D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIC
 
32
FORTIFY:=-D_FORTIFY_SOURCE=3 -fstack-protector-all -fPIC
33
33
LINK_FORTIFY_LD:=-z relro -z now
34
34
LINK_FORTIFY:=
35
35
 
41
41
#COVERAGE=--coverage
42
42
OPTIMIZE:=-Os -fno-strict-aliasing
43
43
LANGUAGE:=-std=gnu11
 
44
FEATURES:=-D_FILE_OFFSET_BITS=64
44
45
htmldir:=man
45
 
version:=1.8.4
 
46
version:=1.8.14
46
47
SED:=sed
 
48
PKG_CONFIG?=pkg-config
47
49
 
48
50
USER:=$(firstword $(subst :, ,$(shell getent passwd _mandos \
49
51
        || getent passwd nobody || echo 65534)))
50
52
GROUP:=$(firstword $(subst :, ,$(shell getent group _mandos \
51
53
        || getent group nogroup || echo 65534)))
52
54
 
 
55
LINUXVERSION:=$(shell uname --kernel-release)
 
56
 
53
57
## Use these settings for a traditional /usr/local install
54
58
# PREFIX:=$(DESTDIR)/usr/local
55
59
# CONFDIR:=$(DESTDIR)/etc/mandos
71
75
STATEDIR:=$(DESTDIR)/var/lib/mandos
72
76
LIBDIR:=$(shell \
73
77
        for d in \
74
 
        "/usr/lib/`dpkg-architecture -qDEB_HOST_MULTIARCH 2>/dev/null`" \
 
78
        "/usr/lib/`dpkg-architecture \
 
79
                        -qDEB_HOST_MULTIARCH 2>/dev/null`" \
75
80
        "`rpm --eval='%{_libdir}' 2>/dev/null`" /usr/lib; do \
76
81
                if [ -d "$$d" -a "$$d" = "$${d%/}" ]; then \
77
82
                        echo "$(DESTDIR)$$d"; \
80
85
        done)
81
86
##
82
87
 
83
 
SYSTEMD:=$(DESTDIR)$(shell pkg-config systemd --variable=systemdsystemunitdir)
84
 
TMPFILES:=$(DESTDIR)$(shell pkg-config systemd --variable=tmpfilesdir)
 
88
SYSTEMD:=$(DESTDIR)$(shell $(PKG_CONFIG) systemd \
 
89
                        --variable=systemdsystemunitdir)
 
90
TMPFILES:=$(DESTDIR)$(shell $(PKG_CONFIG) systemd \
 
91
                        --variable=tmpfilesdir)
 
92
SYSUSERS:=$(DESTDIR)$(shell $(PKG_CONFIG) systemd \
 
93
                        --variable=sysusersdir)
85
94
 
86
 
GNUTLS_CFLAGS:=$(shell pkg-config --cflags-only-I gnutls)
87
 
GNUTLS_LIBS:=$(shell pkg-config --libs gnutls)
88
 
AVAHI_CFLAGS:=$(shell pkg-config --cflags-only-I avahi-core)
89
 
AVAHI_LIBS:=$(shell pkg-config --libs avahi-core)
 
95
GNUTLS_CFLAGS:=$(shell $(PKG_CONFIG) --cflags-only-I gnutls)
 
96
GNUTLS_LIBS:=$(shell $(PKG_CONFIG) --libs gnutls)
 
97
AVAHI_CFLAGS:=$(shell $(PKG_CONFIG) --cflags-only-I avahi-core)
 
98
AVAHI_LIBS:=$(shell $(PKG_CONFIG) --libs avahi-core)
90
99
GPGME_CFLAGS:=$(shell gpgme-config --cflags; getconf LFS_CFLAGS)
91
100
GPGME_LIBS:=$(shell gpgme-config --libs; getconf LFS_LIBS; \
92
101
        getconf LFS_LDFLAGS)
93
 
LIBNL3_CFLAGS:=$(shell pkg-config --cflags-only-I libnl-route-3.0)
94
 
LIBNL3_LIBS:=$(shell pkg-config --libs libnl-route-3.0)
95
 
GLIB_CFLAGS:=$(shell pkg-config --cflags glib-2.0)
96
 
GLIB_LIBS:=$(shell pkg-config --libs glib-2.0)
 
102
LIBNL3_CFLAGS:=$(shell $(PKG_CONFIG) --cflags-only-I libnl-route-3.0)
 
103
LIBNL3_LIBS:=$(shell $(PKG_CONFIG) --libs libnl-route-3.0)
 
104
GLIB_CFLAGS:=$(shell $(PKG_CONFIG) --cflags glib-2.0)
 
105
GLIB_LIBS:=$(shell $(PKG_CONFIG) --libs glib-2.0)
97
106
 
98
107
# Do not change these two
99
 
CFLAGS+=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) \
100
 
        $(OPTIMIZE) $(LANGUAGE) -DVERSION='"$(version)"'
 
108
CFLAGS+=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) $(OPTIMIZE) \
 
109
        $(LANGUAGE) $(FEATURES) -DVERSION='"$(version)"'
101
110
LDFLAGS+=-Xlinker --as-needed $(COVERAGE) $(LINK_FORTIFY) $(strip \
102
111
        ) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
103
112
 
147
156
 
148
157
objects:=$(addsuffix .o,$(CPROGS))
149
158
 
 
159
.PHONY: all
150
160
all: $(PROGS) mandos.lsm
151
161
 
 
162
.PHONY: doc
152
163
doc: $(DOCS)
153
164
 
 
165
.PHONY: html
154
166
html: $(htmldocs)
155
167
 
156
168
%.5: %.xml common.ent legalnotice.xml
273
285
                $@)
274
286
 
275
287
# Need to add the GnuTLS, Avahi and GPGME libraries
276
 
plugins.d/mandos-client: plugins.d/mandos-client.c
277
 
        $(LINK.c) $^ $(GNUTLS_CFLAGS) $(AVAHI_CFLAGS) $(strip\
278
 
                ) $(GPGME_CFLAGS) $(GNUTLS_LIBS) $(strip\
279
 
                ) $(AVAHI_LIBS) $(GPGME_LIBS) $(LOADLIBES) $(strip\
280
 
                ) $(LDLIBS) -o $@
 
288
plugins.d/mandos-client: CFLAGS += $(GNUTLS_CFLAGS) $(strip \
 
289
        ) $(AVAHI_CFLAGS) $(GPGME_CFLAGS)
 
290
plugins.d/mandos-client: LDLIBS += $(GNUTLS_LIBS) $(strip \
 
291
        ) $(AVAHI_LIBS) $(GPGME_LIBS)
281
292
 
282
293
# Need to add the libnl-route library
283
 
plugin-helpers/mandos-client-iprouteadddel: plugin-helpers/mandos-client-iprouteadddel.c
284
 
        $(LINK.c) $(LIBNL3_CFLAGS) $^ $(LIBNL3_LIBS) $(strip\
285
 
                ) $(LOADLIBES) $(LDLIBS) -o $@
 
294
plugin-helpers/mandos-client-iprouteadddel: CFLAGS += $(LIBNL3_CFLAGS)
 
295
plugin-helpers/mandos-client-iprouteadddel: LDLIBS += $(LIBNL3_LIBS)
286
296
 
287
297
# Need to add the GLib and pthread libraries
288
 
dracut-module/password-agent: dracut-module/password-agent.c
289
 
        $(LINK.c) $(GLIB_CFLAGS) $^ $(GLIB_LIBS) -lpthread $(strip\
290
 
                ) $(LOADLIBES) $(LDLIBS) -o $@
291
 
 
292
 
.PHONY : all doc html clean distclean mostlyclean maintainer-clean \
293
 
        check run-client run-server install install-html \
294
 
        install-server install-client-nokey install-client uninstall \
295
 
        uninstall-server uninstall-client purge purge-server \
296
 
        purge-client
297
 
 
 
298
dracut-module/password-agent: CFLAGS += $(GLIB_CFLAGS)
 
299
# Note: -lpthread is unnecessary with the GNU C library 2.34 or later
 
300
dracut-module/password-agent: LDLIBS += $(GLIB_LIBS) -lpthread
 
301
 
 
302
.PHONY: clean
298
303
clean:
299
304
        -rm --force $(CPROGS) $(objects) $(htmldocs) $(DOCS) core
300
305
 
 
306
.PHONY: distclean
301
307
distclean: clean
 
308
.PHONY: mostlyclean
302
309
mostlyclean: clean
 
310
.PHONY: maintainer-clean
303
311
maintainer-clean: clean
304
312
        -rm --force --recursive keydir confdir statedir
305
313
 
 
314
.PHONY: check
306
315
check: all
307
316
        ./mandos --check
308
317
        ./mandos-ctl --check
312
321
        ./dracut-module/password-agent --test
313
322
 
314
323
# Run the client with a local config and key
315
 
run-client: all keydir/seckey.txt keydir/pubkey.txt keydir/tls-privkey.pem keydir/tls-pubkey.pem
316
 
        @echo "###################################################################"
317
 
        @echo "# The following error messages are harmless and can be safely     #"
318
 
        @echo "# ignored:                                                        #"
319
 
        @echo "# From plugin-runner: setgid: Operation not permitted             #"
320
 
        @echo "#                     setuid: Operation not permitted             #"
321
 
        @echo "# From askpass-fifo:  mkfifo: Permission denied                   #"
322
 
        @echo "# From mandos-client:                                             #"
323
 
        @echo "#             Failed to raise privileges: Operation not permitted #"
324
 
        @echo "#             Warning: network hook \"*\" exited with status *      #"
325
 
        @echo "#                                                                 #"
326
 
        @echo "# (The messages are caused by not running as root, but you should #"
327
 
        @echo "# NOT run \"make run-client\" as root unless you also unpacked and  #"
328
 
        @echo "# compiled Mandos as root, which is also NOT recommended.)        #"
329
 
        @echo "###################################################################"
 
324
.PHONY: run-client
 
325
run-client: all keydir/seckey.txt keydir/pubkey.txt \
 
326
                        keydir/tls-privkey.pem keydir/tls-pubkey.pem
 
327
        @echo '######################################################'
 
328
        @echo '# The following error messages are harmless and can  #'
 
329
        @echo '#  be safely ignored:                                #'
 
330
        @echo '## From plugin-runner:                               #'
 
331
        @echo '# setgid: Operation not permitted                    #'
 
332
        @echo '# setuid: Operation not permitted                    #'
 
333
        @echo '## From askpass-fifo:                                #'
 
334
        @echo '# mkfifo: Permission denied                          #'
 
335
        @echo '## From mandos-client:                               #'
 
336
        @echo '# Failed to raise privileges: Operation not permi... #'
 
337
        @echo '# Warning: network hook "*" exited with status *     #'
 
338
        @echo '# ioctl SIOCSIFFLAGS +IFF_UP: Operation not permi... #'
 
339
        @echo '# Failed to bring up interface "*": Operation not... #'
 
340
        @echo '#                                                    #'
 
341
        @echo '# (The messages are caused by not running as root,   #'
 
342
        @echo '# but you should NOT run "make run-client" as root   #'
 
343
        @echo '# unless you also unpacked and compiled Mandos as    #'
 
344
        @echo '# root, which is also NOT recommended.)              #'
 
345
        @echo '######################################################'
330
346
# We set GNOME_KEYRING_CONTROL to block pam_gnome_keyring
331
347
        ./plugin-runner --plugin-dir=plugins.d \
332
348
                --plugin-helper-dir=plugin-helpers \
339
355
keydir/seckey.txt keydir/pubkey.txt keydir/tls-privkey.pem keydir/tls-pubkey.pem: mandos-keygen
340
356
        install --directory keydir
341
357
        ./mandos-keygen --dir keydir --force
 
358
        if ! [ -e keydir/tls-privkey.pem ]; then \
 
359
                install --mode=u=rw /dev/null keydir/tls-privkey.pem; \
 
360
        fi
 
361
        if ! [ -e keydir/tls-pubkey.pem ]; then \
 
362
                install --mode=u=rw /dev/null keydir/tls-pubkey.pem; \
 
363
        fi
342
364
 
343
365
# Run the server with a local config
 
366
.PHONY: run-server
344
367
run-server: confdir/mandos.conf confdir/clients.conf statedir
345
368
        ./mandos --debug --no-dbus --configdir=confdir \
346
369
                --statedir=statedir $(SERVERARGS)
357
380
statedir:
358
381
        install --directory statedir
359
382
 
 
383
.PHONY: install
360
384
install: install-server install-client-nokey
361
385
 
 
386
.PHONY: install-html
362
387
install-html: html
363
388
        install --directory $(htmldir)
364
389
        install --mode=u=rw,go=r --target-directory=$(htmldir) \
365
390
                $(htmldocs)
366
391
 
 
392
.PHONY: install-server
367
393
install-server: doc
368
394
        install --directory $(CONFDIR)
369
395
        if install --directory --mode=u=rwx --owner=$(USER) \
372
398
        elif install --directory --mode=u=rwx $(STATEDIR); then \
373
399
                chown -- $(USER):$(GROUP) $(STATEDIR) || :; \
374
400
        fi
375
 
        if [ "$(TMPFILES)" != "$(DESTDIR)" -a -d "$(TMPFILES)" ]; then \
 
401
        if [ "$(TMPFILES)" != "$(DESTDIR)" \
 
402
                        -a -d "$(TMPFILES)" ]; then \
376
403
                install --mode=u=rw,go=r tmpfiles.d-mandos.conf \
377
404
                        $(TMPFILES)/mandos.conf; \
378
405
        fi
 
406
        if [ "$(SYSUSERS)" != "$(DESTDIR)" \
 
407
                        -a -d "$(SYSUSERS)" ]; then \
 
408
                install --mode=u=rw,go=r sysusers.d-mandos.conf \
 
409
                        $(SYSUSERS)/mandos.conf; \
 
410
        fi
379
411
        install --mode=u=rwx,go=rx mandos $(PREFIX)/sbin/mandos
380
412
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
381
413
                mandos-ctl
410
442
        gzip --best --to-stdout intro.8mandos \
411
443
                > $(MANDIR)/man8/intro.8mandos.gz
412
444
 
 
445
.PHONY: install-client-nokey
413
446
install-client-nokey: all doc
414
447
        install --directory $(LIBDIR)/mandos $(CONFDIR)
415
448
        install --directory --mode=u=rwx $(KEYDIR) \
416
449
                $(LIBDIR)/mandos/plugins.d \
417
450
                $(LIBDIR)/mandos/plugin-helpers
 
451
        if [ "$(SYSUSERS)" != "$(DESTDIR)" \
 
452
                        -a -d "$(SYSUSERS)" ]; then \
 
453
                install --mode=u=rw,go=r sysusers.d-mandos.conf \
 
454
                        $(SYSUSERS)/mandos-client.conf; \
 
455
        fi
418
456
        if [ "$(CONFDIR)" != "$(LIBDIR)/mandos" ]; then \
419
457
                install --mode=u=rwx \
420
458
                        --directory "$(CONFDIR)/plugins.d" \
425
463
        install --mode=u=rwx,go=rx \
426
464
                --target-directory=$(LIBDIR)/mandos plugin-runner
427
465
        install --mode=u=rwx,go=rx \
428
 
                --target-directory=$(LIBDIR)/mandos mandos-to-cryptroot-unlock
 
466
                --target-directory=$(LIBDIR)/mandos \
 
467
                mandos-to-cryptroot-unlock
429
468
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
430
469
                mandos-keygen
431
470
        install --mode=u=rwx,go=rx \
488
527
        gzip --best --to-stdout dracut-module/password-agent.8mandos \
489
528
                > $(MANDIR)/man8/password-agent.8mandos.gz
490
529
 
 
530
.PHONY: install-client
491
531
install-client: install-client-nokey
492
532
# Post-installation stuff
493
533
        -$(PREFIX)/sbin/mandos-keygen --dir "$(KEYDIR)"
494
534
        if command -v update-initramfs >/dev/null; then \
495
535
            update-initramfs -k all -u; \
496
536
        elif command -v dracut >/dev/null; then \
497
 
            for initrd in $(DESTDIR)/boot/initr*-$(shell uname --kernel-release); do \
 
537
            for initrd in $(DESTDIR)/boot/initr*-$(LINUXVERSION); do \
498
538
                if [ -w "$$initrd" ]; then \
499
539
                    chmod go-r "$$initrd"; \
500
540
                    dracut --force "$$initrd"; \
503
543
        fi
504
544
        echo "Now run mandos-keygen --password --dir $(KEYDIR)"
505
545
 
 
546
.PHONY: uninstall
506
547
uninstall: uninstall-server uninstall-client
507
548
 
 
549
.PHONY: uninstall-server
508
550
uninstall-server:
509
551
        -rm --force $(PREFIX)/sbin/mandos \
510
552
                $(PREFIX)/sbin/mandos-ctl \
517
559
        update-rc.d -f mandos remove
518
560
        -rmdir $(CONFDIR)
519
561
 
 
562
.PHONY: uninstall-client
520
563
uninstall-client:
521
564
# Refuse to uninstall client if /etc/crypttab is explicitly configured
522
565
# to use it.
553
596
        if command -v update-initramfs >/dev/null; then \
554
597
            update-initramfs -k all -u; \
555
598
        elif command -v dracut >/dev/null; then \
556
 
            for initrd in $(DESTDIR)/boot/initr*-$(shell uname --kernel-release); do \
 
599
            for initrd in $(DESTDIR)/boot/initr*-$(LINUXVERSION); do \
557
600
                test -w "$$initrd" && dracut --force "$$initrd"; \
558
601
            done; \
559
602
        fi
560
603
 
 
604
.PHONY: purge
561
605
purge: purge-server purge-client
562
606
 
 
607
.PHONY: purge-server
563
608
purge-server: uninstall-server
564
609
        -rm --force $(CONFDIR)/mandos.conf $(CONFDIR)/clients.conf \
565
610
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
570
615
                $(DESTDIR)/var/run/mandos.pid
571
616
        -rmdir $(CONFDIR)
572
617
 
 
618
.PHONY: purge-client
573
619
purge-client: uninstall-client
574
620
        -shred --remove $(KEYDIR)/seckey.txt $(KEYDIR)/tls-privkey.pem
575
621
        -rm --force $(CONFDIR)/plugin-runner.conf \