To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 1243
- compare with another revision
- download diff
- download tarball
- view history from revision 1243
- Committer: Teddy Hogeborn
- Date: 2021-03-21 20:46:40 UTC
- Revision ID: teddy@recompile.se-20210321204640-lpsyen8jr9lw1jma
Some cleanup of GnuTLS interface
Rename opaque internal GnuTLS structures named *_int to also start
with underscore (_), as is the custom in Python programs.
Decode byte strings from UTF-8 where needed. (Fixing, among other
things, all "DEBUG: GnuTLS" lines having a "b'" prefix in Python 3.)
Simplify calling C functions by:
1. Using the "_as_parameter_" attribute to store the ctypes object.
2. Creating and using helper classes to automatically create pointers
or cast typed pointers to pointers to void.
3. Providing the "from_param()" method on relevant classes.
Remove "restype" attribute on C functions where "errcheck" attribute
is already set.
* mandos (gnutls.session_int): Rename to start with "_".
(gnutls.openpgp_crt_int): - '' -
(gnutls.Error.__init__): Decode byte string from gnutls.strerror().
(gnutls.PointerTo): New helper class.
(gnutls.CastToVoidPointer): - '' -
(gnutls.With_from_param): - '' -
(gnutls.Credentials): Inherit from "With_from_param" and store the
ctypes object in the "_as_parameter_" attribute instead of
"_c_object".
(gnutls._error_code): Use "gnutls.E_SUCCESS" instead of the unadorned
numerical constant "0".
(gnutls._retry_on_error): - '' -
(gnutls.priority_set_direct.argtypes): Use "ClientSession" instead
of "session_t", and change all callers to match.
(gnutls.init.argtypes): Use "PointerTo(ClientSession)" instead of
"ctypes.POINTER(session_t)", and change all callers to match.
(gnutls.set_default_priority.argtypes): Use "ClientSession" instead
of "session_t", and change all callers to match.
(gnutls.record_send.argtypes): - '' -
(gnutls.certificate_allocate_credentials.argtypes): Use
"PointerTo(Credentials)" instead of
"ctypes.POINTER(certificate_credentials_t)", and change all callers
to match.
(gnutls.certificate_free_credentials.argtypes): Use "Credentials"
instead of "certificate_credentials_t", and change all callers to
match.
(gnutls.handshake_set_private_extensions.argtypes): Use
"ClientSession" instead of "session_t", and change all callers to
match.
(gnutls.credentials_set.argtypes): Use
"CastToVoidPointer(Credentials)" instead of "ctypes.c_void_p", and
change all callers to match.
(gnutls.certificate_type_get.argtypes): Use "ClientSession" instead
of "session_t", and change all callers to match.
(gnutls.certificate_get_peers.argtypes): - '' -
(gnutls.deinit.argtypes): - '' -
(gnutls.handshake.argtypes): - '' -
(gnutls.handshake.restype): Change from "_error_code" to
"ctypes.c_int".
(gnutls.transport_set_ptr.argtypes): Use "ClientSession" instead of
"session_t", and change all callers to match.
(gnutls.bye.argtypes): - '' -
(gnutls.bye.restype): Change from "_error_code" to "ctypes.c_int".
(gnutls.certificate_type_get2.argtypes): Use "ClientSession" instead
of "session_t", and change all callers to match.
(ClientHandler.handle): Decode "key_id" bytes to string before
logging it in the debug log.
(main.debug_gnutls): Decode GnuTLS log message from bytes to string
before logging it in the debug log.
Rename opaque internal GnuTLS structures named *_int to also start
with underscore (_), as is the custom in Python programs.
Decode byte strings from UTF-8 where needed. (Fixing, among other
things, all "DEBUG: GnuTLS" lines having a "b'" prefix in Python 3.)
Simplify calling C functions by:
1. Using the "_as_parameter_" attribute to store the ctypes object.
2. Creating and using helper classes to automatically create pointers
or cast typed pointers to pointers to void.
3. Providing the "from_param()" method on relevant classes.
Remove "restype" attribute on C functions where "errcheck" attribute
is already set.
* mandos (gnutls.session_int): Rename to start with "_".
(gnutls.openpgp_crt_int): - '' -
(gnutls.Error.__init__): Decode byte string from gnutls.strerror().
(gnutls.PointerTo): New helper class.
(gnutls.CastToVoidPointer): - '' -
(gnutls.With_from_param): - '' -
(gnutls.Credentials): Inherit from "With_from_param" and store the
ctypes object in the "_as_parameter_" attribute instead of
"_c_object".
(gnutls._error_code): Use "gnutls.E_SUCCESS" instead of the unadorned
numerical constant "0".
(gnutls._retry_on_error): - '' -
(gnutls.priority_set_direct.argtypes): Use "ClientSession" instead
of "session_t", and change all callers to match.
(gnutls.init.argtypes): Use "PointerTo(ClientSession)" instead of
"ctypes.POINTER(session_t)", and change all callers to match.
(gnutls.set_default_priority.argtypes): Use "ClientSession" instead
of "session_t", and change all callers to match.
(gnutls.record_send.argtypes): - '' -
(gnutls.certificate_allocate_credentials.argtypes): Use
"PointerTo(Credentials)" instead of
"ctypes.POINTER(certificate_credentials_t)", and change all callers
to match.
(gnutls.certificate_free_credentials.argtypes): Use "Credentials"
instead of "certificate_credentials_t", and change all callers to
match.
(gnutls.handshake_set_private_extensions.argtypes): Use
"ClientSession" instead of "session_t", and change all callers to
match.
(gnutls.credentials_set.argtypes): Use
"CastToVoidPointer(Credentials)" instead of "ctypes.c_void_p", and
change all callers to match.
(gnutls.certificate_type_get.argtypes): Use "ClientSession" instead
of "session_t", and change all callers to match.
(gnutls.certificate_get_peers.argtypes): - '' -
(gnutls.deinit.argtypes): - '' -
(gnutls.handshake.argtypes): - '' -
(gnutls.handshake.restype): Change from "_error_code" to
"ctypes.c_int".
(gnutls.transport_set_ptr.argtypes): Use "ClientSession" instead of
"session_t", and change all callers to match.
(gnutls.bye.argtypes): - '' -
(gnutls.bye.restype): Change from "_error_code" to "ctypes.c_int".
(gnutls.certificate_type_get2.argtypes): Use "ClientSession" instead
of "session_t", and change all callers to match.
(ClientHandler.handle): Decode "key_id" bytes to string before
logging it in the debug log.
(main.debug_gnutls): Decode GnuTLS log message from bytes to string
before logging it in the debug log.
- files added:
- bugs.xml
- debian/tests
- debian/upstream
- dracut-module
- plugin-helpers
- files removed:
- debian/upstream-signing-key.pgp
- files modified:
- .bzrignore
added
removed
plugin-runner.c
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2008-2013 Teddy Hogeborn
6
* Copyright © 2008-2013 Björn Påhlsson
7
*
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
12
*
13
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2021 Teddy Hogeborn
6
* Copyright © 2008-2021 Björn Påhlsson
7
*
8
* This file is part of Mandos.
9
*
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
14
*
15
* Mandos is distributed in the hope that it will be useful, but
14
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
15
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16
18
* General Public License for more details.
17
19
*
18
20
* You should have received a copy of the GNU General Public License
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
21
22
*
22
23
* Contact the authors at <mandos@recompile.se>.
23
24
*/
24
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
asprintf(), O_CLOEXEC */
26
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
27
getline(), asprintf(), O_CLOEXEC,
28
scandirat(), pipe2() */
29
#include <argp.h> /* argp_program_version,
30
argp_program_bug_address,
31
struct argp_option,
32
struct argp_state, argp_error(),
33
ARGP_NO_EXIT, argp_state_help,
34
ARGP_HELP_STD_HELP,
35
ARGP_HELP_USAGE, ARGP_HELP_EXIT_OK,
36
ARGP_KEY_ARG, ARGP_ERR_UNKNOWN,
37
struct argp, argp_parse(),
38
ARGP_IN_ORDER, ARGP_NO_HELP */
39
#include <stdbool.h> /* bool, false, true */
40
#include <sys/types.h> /* pid_t, sig_atomic_t, uid_t, gid_t,
41
getuid(), setgid(), setuid() */
27
42
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
29
realloc() */
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, fdopendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
37
dirfd() */
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
FD_SET(), FD_ISSET(), FD_CLR */
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG(),
42
WCOREDUMP() */
43
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
44
#include <iso646.h> /* and, or, not */
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
46
readdir(), closedir(), dirfd() */
47
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
48
fcntl(), setuid(), setgid(),
49
F_GETFD, F_SETFD, FD_CLOEXEC,
50
access(), pipe(), fork(), close()
51
dup2(), STDOUT_FILENO, _exit(),
52
execv(), write(), read(),
53
close() */
43
#include <iso646.h> /* or, and, not */
44
#include <string.h> /* strcmp(), strdup(), strchrnul(),
45
strncmp(), strlen(), strcpy(),
46
strsep(), strchr(), strsignal() */
47
#include <stdlib.h> /* malloc(), free(), reallocarray(),
48
realloc(), EXIT_SUCCESS */
49
#include <errno.h> /* errno, EINTR, ENOMEM, ECHILD,
50
error_t, EINVAL, EMFILE, ENFILE,
51
ENOENT, ESRCH */
52
#include <stdint.h> /* SIZE_MAX */
53
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
54
getline(), asprintf(), O_CLOEXEC,
55
scandirat(), pipe2() */
56
#include <unistd.h> /* TEMP_FAILURE_RETRY(), ssize_t,
57
write(), STDOUT_FILENO, uid_t,
58
gid_t, getuid(), fchown(), close(),
59
symlink(), setgid(), setuid(),
60
faccessat(), X_OK, pipe(), pipe2(),
61
fork(), _exit(), dup2(), fexecve(),
62
read(), getpass() */
54
63
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
FD_CLOEXEC */
56
#include <string.h> /* strsep, strlen(), asprintf(),
57
strsignal(), strcmp(), strncmp() */
58
#include <errno.h> /* errno */
59
#include <argp.h> /* struct argp_option, struct
60
argp_state, struct argp,
61
argp_parse(), ARGP_ERR_UNKNOWN,
62
ARGP_KEY_END, ARGP_KEY_ARG,
63
error_t */
64
#include <signal.h> /* struct sigaction, sigemptyset(),
65
sigaddset(), sigaction(),
66
sigprocmask(), SIG_BLOCK, SIGCHLD,
67
SIG_UNBLOCK, kill(), sig_atomic_t
68
*/
69
#include <errno.h> /* errno, EBADF */
70
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
64
FD_CLOEXEC, open(), O_RDONLY,
65
O_CLOEXEC, openat() */
66
#include <sys/wait.h> /* waitpid(), WNOHANG, WIFEXITED(),
67
WEXITSTATUS(), WIFSIGNALED(),
68
WTERMSIG(), wait() */
69
#include <error.h> /* error() */
70
#include <stdio.h> /* FILE, fprintf(), fopen(),
71
getline(), fclose(), EOF,
72
asprintf(), stderr */
73
#include <dirent.h> /* struct dirent, scandirat(),
74
alphasort() */
75
#include <sys/stat.h> /* struct stat, fstat(), S_ISDIR(),
76
lstat(), S_ISREG() */
77
#include <sys/select.h> /* fd_set, FD_ZERO(), FD_SETSIZE,
78
FD_SET(), select(), FD_CLR(),
79
FD_ISSET() */
80
#include <signal.h> /* struct sigaction, SA_NOCLDSTOP,
81
sigemptyset(), sigaddset(),
82
SIGCHLD, sigprocmask(), SIG_BLOCK,
83
SIG_UNBLOCK, kill(), SIGTERM */
71
84
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
72
85
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
73
#include <errno.h> /* errno */
74
#include <error.h> /* error() */
86
#include <inttypes.h> /* intmax_t, strtoimax(), PRIdMAX */
87
#include <fnmatch.h> /* fnmatch(), FNM_FILE_NAME,
88
FNM_PERIOD, FNM_NOMATCH */
75
89
76
90
#define BUFFER_SIZE 256
77
91
78
92
#define PDIR "/lib/mandos/plugins.d"
93
#define PHDIR "/lib/mandos/plugin-helpers"
79
94
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
80
95
81
96
const char *argp_program_version = "plugin-runner " VERSION;
105
120
106
121
/* Gets an existing plugin based on name,
107
122
or if none is found, creates a new one */
123
__attribute__((warn_unused_result))
108
124
static plugin *getplugin(char *name){
109
125
/* Check for existing plugin with that name */
110
126
for(plugin *p = plugin_list; p != NULL; p = p->next){
171
187
}
172
188
173
189
/* Helper function for add_argument and add_environment */
174
__attribute__((nonnull))
190
__attribute__((nonnull, warn_unused_result))
175
191
static bool add_to_char_array(const char *new, char ***array,
176
192
int *len){
177
193
/* Resize the pointed-to array to hold one more pointer */
178
194
char **new_array = NULL;
179
195
do {
180
new_array = realloc(*array, sizeof(char *)
181
* (size_t) ((*len) + 2));
196
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
197
new_array = reallocarray(*array, (size_t)((*len) + 2),
198
sizeof(char *));
199
#else
200
if(((size_t)((*len) + 2)) > (SIZE_MAX / sizeof(char *))){
201
/* overflow */
202
new_array = NULL;
203
errno = ENOMEM;
204
} else {
205
new_array = realloc(*array, (size_t)((*len) + 2)
206
* sizeof(char *));
207
}
208
#endif
182
209
} while(new_array == NULL and errno == EINTR);
183
210
/* Malloc check */
184
211
if(new_array == NULL){
202
229
}
203
230
204
231
/* Add to a plugin's argument vector */
205
__attribute__((nonnull(2)))
232
__attribute__((nonnull(2), warn_unused_result))
206
233
static bool add_argument(plugin *p, const char *arg){
207
234
if(p == NULL){
208
235
return false;
211
238
}
212
239
213
240
/* Add to a plugin's environment */
214
__attribute__((nonnull(2)))
241
__attribute__((nonnull(2), warn_unused_result))
215
242
static bool add_environment(plugin *p, const char *def, bool replace){
216
243
if(p == NULL){
217
244
return false;
239
266
return add_to_char_array(def, &(p->environ), &(p->envc));
240
267
}
241
268
269
#ifndef O_CLOEXEC
242
270
/*
243
271
* Based on the example in the GNU LibC manual chapter 13.13 "File
244
272
* Descriptor Flags".
245
273
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
246
274
*/
275
__attribute__((warn_unused_result))
247
276
static int set_cloexec_flag(int fd){
248
277
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
249
278
/* If reading the flags failed, return error indication now. */
254
283
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
255
284
ret | FD_CLOEXEC));
256
285
}
286
#endif /* not O_CLOEXEC */
257
287
258
288
259
289
/* Mark processes as completed when they exit, and save their exit
291
321
}
292
322
293
323
/* Prints out a password to stdout */
294
__attribute__((nonnull))
324
__attribute__((nonnull, warn_unused_result))
295
325
static bool print_out_password(const char *buffer, size_t length){
296
326
ssize_t ret;
297
327
for(size_t written = 0; written < length; written += (size_t)ret){
308
338
__attribute__((nonnull))
309
339
static void free_plugin(plugin *plugin_node){
310
340
311
for(char **arg = plugin_node->argv; *arg != NULL; arg++){
341
for(char **arg = (plugin_node->argv)+1; *arg != NULL; arg++){
312
342
free(*arg);
313
343
}
344
free(plugin_node->name);
314
345
free(plugin_node->argv);
315
346
for(char **env = plugin_node->environ; *env != NULL; env++){
316
347
free(*env);
343
374
344
375
int main(int argc, char *argv[]){
345
376
char *plugindir = NULL;
377
char *pluginhelperdir = NULL;
346
378
char *argfile = NULL;
347
379
FILE *conffp;
348
size_t d_name_len;
349
DIR *dir = NULL;
350
struct dirent *dirst;
380
struct dirent **direntries = NULL;
351
381
struct stat st;
352
382
fd_set rfds_all;
353
383
int ret, maxfd = 0;
361
391
.sa_flags = SA_NOCLDSTOP };
362
392
char **custom_argv = NULL;
363
393
int custom_argc = 0;
394
int dir_fd = -1;
364
395
365
396
/* Establish a signal handler */
366
397
sigemptyset(&sigchld_action.sa_mask);
411
442
.doc = "Group ID the plugins will run as", .group = 3 },
412
443
{ .name = "debug", .key = 132,
413
444
.doc = "Debug mode", .group = 4 },
445
{ .name = "plugin-helper-dir", .key = 133,
446
.arg = "DIRECTORY",
447
.doc = "Specify a different plugin helper directory",
448
.group = 2 },
414
449
/*
415
450
* These reproduce what we would get without ARGP_NO_HELP
416
451
*/
437
472
break;
438
473
}
439
474
}
475
errno = 0;
440
476
}
441
477
break;
442
478
case 'G': /* --global-env */
443
add_environment(getplugin(NULL), arg, true);
479
if(add_environment(getplugin(NULL), arg, true)){
480
errno = 0;
481
}
444
482
break;
445
483
case 'o': /* --options-for */
446
484
{
463
501
break;
464
502
}
465
503
}
504
errno = 0;
466
505
}
467
506
break;
468
507
case 'E': /* --env-for */
480
519
errno = EINVAL;
481
520
break;
482
521
}
483
add_environment(getplugin(arg), envdef, true);
522
if(add_environment(getplugin(arg), envdef, true)){
523
errno = 0;
524
}
484
525
}
485
526
break;
486
527
case 'd': /* --disable */
488
529
plugin *p = getplugin(arg);
489
530
if(p != NULL){
490
531
p->disabled = true;
532
errno = 0;
491
533
}
492
534
}
493
535
break;
496
538
plugin *p = getplugin(arg);
497
539
if(p != NULL){
498
540
p->disabled = false;
541
errno = 0;
499
542
}
500
543
}
501
544
break;
502
545
case 128: /* --plugin-dir */
503
546
free(plugindir);
504
547
plugindir = strdup(arg);
548
if(plugindir != NULL){
549
errno = 0;
550
}
505
551
break;
506
552
case 129: /* --config-file */
507
553
/* This is already done by parse_opt_config_file() */
515
561
break;
516
562
}
517
563
uid = (uid_t)tmp_id;
564
errno = 0;
518
565
break;
519
566
case 131: /* --groupid */
520
567
tmp_id = strtoimax(arg, &tmp, 10);
525
572
break;
526
573
}
527
574
gid = (gid_t)tmp_id;
575
errno = 0;
528
576
break;
529
577
case 132: /* --debug */
530
578
debug = true;
531
579
break;
580
case 133: /* --plugin-helper-dir */
581
free(pluginhelperdir);
582
pluginhelperdir = strdup(arg);
583
if(pluginhelperdir != NULL){
584
errno = 0;
585
}
586
break;
532
587
/*
533
588
* These reproduce what we would get without ARGP_NO_HELP
534
589
*/
535
590
case '?': /* --help */
536
591
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
537
592
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
593
__builtin_unreachable();
538
594
case -3: /* --usage */
539
595
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
540
596
argp_state_help(state, state->out_stream,
541
597
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
598
__builtin_unreachable();
542
599
case 'V': /* --version */
543
600
fprintf(state->out_stream, "%s\n", argp_program_version);
544
601
exit(EXIT_SUCCESS);
554
611
if(arg[0] == '\0'){
555
612
break;
556
613
}
614
#if __GNUC__ >= 7
615
__attribute__((fallthrough));
616
#else
617
/* FALLTHROUGH */
618
#endif
557
619
default:
558
620
return ARGP_ERR_UNKNOWN;
559
621
}
578
640
case 129: /* --config-file */
579
641
free(argfile);
580
642
argfile = strdup(arg);
643
if(argfile != NULL){
644
errno = 0;
645
}
581
646
break;
582
647
case 130: /* --userid */
583
648
case 131: /* --groupid */
584
649
case 132: /* --debug */
650
case 133: /* --plugin-helper-dir */
585
651
case '?': /* --help */
586
652
case -3: /* --usage */
587
653
case 'V': /* --version */
667
733
668
734
custom_argc += 1;
669
735
{
670
char **new_argv = realloc(custom_argv, sizeof(char *)
671
* ((unsigned int)
672
custom_argc + 1));
736
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
737
char **new_argv = reallocarray(custom_argv,
738
(size_t)custom_argc + 1,
739
sizeof(char *));
740
#else
741
char **new_argv = NULL;
742
if(((size_t)custom_argc + 1) > (SIZE_MAX / sizeof(char *))){
743
/* overflow */
744
errno = ENOMEM;
745
} else {
746
new_argv = realloc(custom_argv, ((size_t)custom_argc + 1)
747
* sizeof(char *));
748
}
749
#endif
673
750
if(new_argv == NULL){
674
error(0, errno, "realloc");
751
error(0, errno, "reallocarray");
675
752
exitstatus = EX_OSERR;
676
753
free(new_arg);
677
754
free(org_line);
742
819
goto fallback;
743
820
}
744
821
822
{
823
char *pluginhelperenv;
824
bool bret = true;
825
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
826
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
827
if(ret != -1){
828
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
829
}
830
if(ret == -1 or not bret){
831
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
832
" environment variable to \"%s\" for all plugins\n",
833
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
834
}
835
if(ret != -1){
836
free(pluginhelperenv);
837
}
838
}
839
745
840
if(debug){
746
for(plugin *p = plugin_list; p != NULL; p=p->next){
841
for(plugin *p = plugin_list; p != NULL; p = p->next){
747
842
fprintf(stderr, "Plugin: %s has %d arguments\n",
748
843
p->name ? p->name : "Global", p->argc - 1);
749
844
for(char **a = p->argv; *a != NULL; a++){
758
853
759
854
if(getuid() == 0){
760
855
/* Work around Debian bug #633582:
761
<http://bugs.debian.org/633582> */
856
<https://bugs.debian.org/633582> */
762
857
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
763
858
if(plugindir_fd == -1){
764
error(0, errno, "open");
859
if(errno != ENOENT){
860
error(0, errno, "open(\"" PDIR "\")");
861
}
765
862
} else {
766
863
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
767
864
if(ret == -1){
774
871
}
775
872
}
776
873
}
777
TEMP_FAILURE_RETRY(close(plugindir_fd));
874
close(plugindir_fd);
875
}
876
877
/* Work around Debian bug #981302
878
<https://bugs.debian.org/981302> */
879
if(lstat("/dev/fd", &st) != 0 and errno == ENOENT){
880
ret = symlink("/proc/self/fd", "/dev/fd");
881
if(ret == -1){
882
error(0, errno, "Failed to create /dev/fd symlink");
883
}
778
884
}
779
885
}
780
886
790
896
791
897
/* Open plugin directory with close_on_exec flag */
792
898
{
793
int dir_fd = -1;
794
if(plugindir == NULL){
795
dir_fd = open(PDIR, O_RDONLY |
796
#ifdef O_CLOEXEC
797
O_CLOEXEC
798
#else /* not O_CLOEXEC */
799
0
800
#endif /* not O_CLOEXEC */
801
);
802
} else {
803
dir_fd = open(plugindir, O_RDONLY |
804
#ifdef O_CLOEXEC
805
O_CLOEXEC
806
#else /* not O_CLOEXEC */
807
0
808
#endif /* not O_CLOEXEC */
809
);
810
}
899
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
900
#ifdef O_CLOEXEC
901
O_CLOEXEC
902
#else /* not O_CLOEXEC */
903
0
904
#endif /* not O_CLOEXEC */
905
);
811
906
if(dir_fd == -1){
812
907
error(0, errno, "Could not open plugin dir");
813
908
exitstatus = EX_UNAVAILABLE;
819
914
ret = set_cloexec_flag(dir_fd);
820
915
if(ret < 0){
821
916
error(0, errno, "set_cloexec_flag");
822
TEMP_FAILURE_RETRY(close(dir_fd));
823
917
exitstatus = EX_OSERR;
824
918
goto fallback;
825
919
}
826
920
#endif /* O_CLOEXEC */
827
828
dir = fdopendir(dir_fd);
829
if(dir == NULL){
830
error(0, errno, "Could not open plugin dir");
831
TEMP_FAILURE_RETRY(close(dir_fd));
832
exitstatus = EX_OSERR;
833
goto fallback;
921
}
922
923
int good_name(const struct dirent * const dirent){
924
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
925
"*.dpkg-old", "*.dpkg-bak",
926
"*.dpkg-divert", NULL };
927
#ifdef __GNUC__
928
#pragma GCC diagnostic push
929
#pragma GCC diagnostic ignored "-Wcast-qual"
930
#endif
931
for(const char **pat = (const char **)patterns;
932
*pat != NULL; pat++){
933
#ifdef __GNUC__
934
#pragma GCC diagnostic pop
935
#endif
936
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
937
!= FNM_NOMATCH){
938
if(debug){
939
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
940
" matching pattern %s\n", dirent->d_name, *pat);
941
}
942
return 0;
943
}
834
944
}
945
return 1;
946
}
947
948
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
949
alphasort);
950
if(numplugins == -1){
951
error(0, errno, "Could not scan plugin dir");
952
direntries = NULL;
953
exitstatus = EX_OSERR;
954
goto fallback;
835
955
}
836
956
837
957
FD_ZERO(&rfds_all);
838
958
839
959
/* Read and execute any executable in the plugin directory*/
840
while(true){
841
do {
842
dirst = readdir(dir);
843
} while(dirst == NULL and errno == EINTR);
844
845
/* All directory entries have been processed */
846
if(dirst == NULL){
847
if(errno == EBADF){
848
error(0, errno, "readdir");
849
exitstatus = EX_IOERR;
850
goto fallback;
851
}
852
break;
853
}
854
855
d_name_len = strlen(dirst->d_name);
856
857
/* Ignore dotfiles, backup files and other junk */
858
{
859
bool bad_name = false;
860
861
const char * const bad_prefixes[] = { ".", "#", NULL };
862
863
const char * const bad_suffixes[] = { "~", "#", ".dpkg-new",
864
".dpkg-old",
865
".dpkg-bak",
866
".dpkg-divert", NULL };
867
#ifdef __GNUC__
868
#pragma GCC diagnostic push
869
#pragma GCC diagnostic ignored "-Wcast-qual"
870
#endif
871
for(const char **pre = (const char **)bad_prefixes;
872
*pre != NULL; pre++){
873
#ifdef __GNUC__
874
#pragma GCC diagnostic pop
875
#endif
876
size_t pre_len = strlen(*pre);
877
if((d_name_len >= pre_len)
878
and strncmp((dirst->d_name), *pre, pre_len) == 0){
879
if(debug){
880
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
881
" with bad prefix %s\n", dirst->d_name, *pre);
882
}
883
bad_name = true;
884
break;
885
}
886
}
887
if(bad_name){
888
continue;
889
}
890
#ifdef __GNUC__
891
#pragma GCC diagnostic push
892
#pragma GCC diagnostic ignored "-Wcast-qual"
893
#endif
894
for(const char **suf = (const char **)bad_suffixes;
895
*suf != NULL; suf++){
896
#ifdef __GNUC__
897
#pragma GCC diagnostic pop
898
#endif
899
size_t suf_len = strlen(*suf);
900
if((d_name_len >= suf_len)
901
and (strcmp((dirst->d_name) + d_name_len-suf_len, *suf)
902
== 0)){
903
if(debug){
904
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
905
" with bad suffix %s\n", dirst->d_name, *suf);
906
}
907
bad_name = true;
908
break;
909
}
910
}
911
912
if(bad_name){
913
continue;
914
}
915
}
916
917
char *filename;
918
if(plugindir == NULL){
919
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, PDIR "/%s",
920
dirst->d_name));
921
} else {
922
ret = (int)TEMP_FAILURE_RETRY(asprintf(&filename, "%s/%s",
923
plugindir,
924
dirst->d_name));
925
}
926
if(ret < 0){
927
error(0, errno, "asprintf");
960
for(int i = 0; i < numplugins; i++){
961
962
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
963
if(plugin_fd == -1){
964
error(0, errno, "Could not open plugin");
965
free(direntries[i]);
928
966
continue;
929
967
}
930
931
ret = (int)TEMP_FAILURE_RETRY(stat(filename, &st));
968
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
932
969
if(ret == -1){
933
970
error(0, errno, "stat");
934
free(filename);
971
close(plugin_fd);
972
free(direntries[i]);
935
973
continue;
936
974
}
937
975
938
976
/* Ignore non-executable files */
939
977
if(not S_ISREG(st.st_mode)
940
or (TEMP_FAILURE_RETRY(access(filename, X_OK)) != 0)){
978
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
979
X_OK, 0)) != 0)){
941
980
if(debug){
942
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
943
" with bad type or mode\n", filename);
981
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
982
" with bad type or mode\n",
983
plugindir != NULL ? plugindir : PDIR,
984
direntries[i]->d_name);
944
985
}
945
free(filename);
986
close(plugin_fd);
987
free(direntries[i]);
946
988
continue;
947
989
}
948
990
949
plugin *p = getplugin(dirst->d_name);
991
plugin *p = getplugin(direntries[i]->d_name);
950
992
if(p == NULL){
951
993
error(0, errno, "getplugin");
952
free(filename);
994
close(plugin_fd);
995
free(direntries[i]);
953
996
continue;
954
997
}
955
998
if(p->disabled){
956
999
if(debug){
957
1000
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
958
dirst->d_name);
1001
direntries[i]->d_name);
959
1002
}
960
free(filename);
1003
close(plugin_fd);
1004
free(direntries[i]);
961
1005
continue;
962
1006
}
963
1007
{
977
1021
}
978
1022
}
979
1023
}
980
/* If this plugin has any environment variables, we will call
981
using execve and need to duplicate the environment from this
982
process, too. */
1024
/* If this plugin has any environment variables, we need to
1025
duplicate the environment from this process, too. */
983
1026
if(p->environ[0] != NULL){
984
1027
for(char **e = environ; *e != NULL; e++){
985
1028
if(not add_environment(p, *e, false)){
989
1032
}
990
1033
991
1034
int pipefd[2];
1035
#ifndef O_CLOEXEC
992
1036
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1037
#else /* O_CLOEXEC */
1038
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
1039
#endif /* O_CLOEXEC */
993
1040
if(ret == -1){
994
1041
error(0, errno, "pipe");
995
1042
exitstatus = EX_OSERR;
996
goto fallback;
997
}
1043
free(direntries[i]);
1044
goto fallback;
1045
}
1046
if(pipefd[0] >= FD_SETSIZE){
1047
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1048
FD_SETSIZE);
1049
close(pipefd[0]);
1050
close(pipefd[1]);
1051
exitstatus = EX_OSERR;
1052
free(direntries[i]);
1053
goto fallback;
1054
}
1055
#ifndef O_CLOEXEC
998
1056
/* Ask OS to automatic close the pipe on exec */
999
1057
ret = set_cloexec_flag(pipefd[0]);
1000
1058
if(ret < 0){
1001
1059
error(0, errno, "set_cloexec_flag");
1060
close(pipefd[0]);
1061
close(pipefd[1]);
1002
1062
exitstatus = EX_OSERR;
1063
free(direntries[i]);
1003
1064
goto fallback;
1004
1065
}
1005
1066
ret = set_cloexec_flag(pipefd[1]);
1006
1067
if(ret < 0){
1007
1068
error(0, errno, "set_cloexec_flag");
1069
close(pipefd[0]);
1070
close(pipefd[1]);
1008
1071
exitstatus = EX_OSERR;
1072
free(direntries[i]);
1009
1073
goto fallback;
1010
1074
}
1075
#endif /* not O_CLOEXEC */
1011
1076
/* Block SIGCHLD until process is safely in process list */
1012
1077
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1013
1078
&sigchld_action.sa_mask,
1015
1080
if(ret < 0){
1016
1081
error(0, errno, "sigprocmask");
1017
1082
exitstatus = EX_OSERR;
1083
free(direntries[i]);
1018
1084
goto fallback;
1019
1085
}
1020
1086
/* Starting a new process to be watched */
1024
1090
} while(pid == -1 and errno == EINTR);
1025
1091
if(pid == -1){
1026
1092
error(0, errno, "fork");
1093
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1094
&sigchld_action.sa_mask, NULL));
1095
close(pipefd[0]);
1096
close(pipefd[1]);
1027
1097
exitstatus = EX_OSERR;
1098
free(direntries[i]);
1028
1099
goto fallback;
1029
1100
}
1030
1101
if(pid == 0){
1046
1117
_exit(EX_OSERR);
1047
1118
}
1048
1119
1049
if(dirfd(dir) < 0){
1050
/* If dir has no file descriptor, we could not set FD_CLOEXEC
1051
above and must now close it manually here. */
1052
closedir(dir);
1053
}
1054
if(p->environ[0] == NULL){
1055
if(execv(filename, p->argv) < 0){
1056
error(0, errno, "execv for %s", filename);
1057
_exit(EX_OSERR);
1058
}
1059
} else {
1060
if(execve(filename, p->argv, p->environ) < 0){
1061
error(0, errno, "execve for %s", filename);
1062
_exit(EX_OSERR);
1063
}
1120
if(fexecve(plugin_fd, p->argv,
1121
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1122
error(0, errno, "fexecve for %s/%s",
1123
plugindir != NULL ? plugindir : PDIR,
1124
direntries[i]->d_name);
1125
_exit(EX_OSERR);
1064
1126
}
1065
1127
/* no return */
1066
1128
}
1067
1129
/* Parent process */
1068
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1069
pipe */
1070
free(filename);
1071
plugin *new_plugin = getplugin(dirst->d_name);
1130
close(pipefd[1]); /* Close unused write end of pipe */
1131
close(plugin_fd);
1132
plugin *new_plugin = getplugin(direntries[i]->d_name);
1072
1133
if(new_plugin == NULL){
1073
1134
error(0, errno, "getplugin");
1074
1135
ret = (int)(TEMP_FAILURE_RETRY
1078
1139
error(0, errno, "sigprocmask");
1079
1140
}
1080
1141
exitstatus = EX_OSERR;
1142
free(direntries[i]);
1081
1143
goto fallback;
1082
1144
}
1145
free(direntries[i]);
1083
1146
1084
1147
new_plugin->pid = pid;
1085
1148
new_plugin->fd = pipefd[0];
1086
1149
1150
if(debug){
1151
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1152
new_plugin->name, (intmax_t) (new_plugin->pid));
1153
}
1154
1087
1155
/* Unblock SIGCHLD so signal handler can be run if this process
1088
1156
has already completed */
1089
1157
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1095
1163
goto fallback;
1096
1164
}
1097
1165
1098
#if defined (__GNUC__) and defined (__GLIBC__)
1099
#if not __GLIBC_PREREQ(2, 16)
1100
#pragma GCC diagnostic push
1101
#pragma GCC diagnostic ignored "-Wsign-conversion"
1102
#endif
1103
#endif
1104
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1105
-Wconversion in GNU libc
1106
before 2.16 */
1107
#if defined (__GNUC__) and defined (__GLIBC__)
1108
#if not __GLIBC_PREREQ(2, 16)
1109
#pragma GCC diagnostic pop
1110
#endif
1111
#endif
1166
FD_SET(new_plugin->fd, &rfds_all);
1112
1167
1113
1168
if(maxfd < new_plugin->fd){
1114
1169
maxfd = new_plugin->fd;
1115
1170
}
1116
1171
}
1117
1172
1118
TEMP_FAILURE_RETRY(closedir(dir));
1119
dir = NULL;
1173
free(direntries);
1174
direntries = NULL;
1175
close(dir_fd);
1176
dir_fd = -1;
1120
1177
free_plugin(getplugin(NULL));
1121
1178
1122
1179
for(plugin *p = plugin_list; p != NULL; p = p->next){
1161
1218
(intmax_t) (proc->pid),
1162
1219
WTERMSIG(proc->status),
1163
1220
strsignal(WTERMSIG(proc->status)));
1164
} else if(WCOREDUMP(proc->status)){
1165
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1166
" core\n", proc->name, (intmax_t) (proc->pid));
1167
1221
}
1168
1222
}
1169
1223
1170
1224
/* Remove the plugin */
1171
#if defined (__GNUC__) and defined (__GLIBC__)
1172
#if not __GLIBC_PREREQ(2, 16)
1173
#pragma GCC diagnostic push
1174
#pragma GCC diagnostic ignored "-Wsign-conversion"
1175
#endif
1176
#endif
1177
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1178
-Wconversion in GNU libc
1179
before 2.16 */
1180
#if defined (__GNUC__) and defined (__GLIBC__)
1181
#if not __GLIBC_PREREQ(2, 16)
1182
#pragma GCC diagnostic pop
1183
#endif
1184
#endif
1225
FD_CLR(proc->fd, &rfds_all);
1185
1226
1186
1227
/* Block signal while modifying process_list */
1187
1228
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1227
1268
}
1228
1269
1229
1270
/* This process has not completed. Does it have any output? */
1230
#if defined (__GNUC__) and defined (__GLIBC__)
1231
#if not __GLIBC_PREREQ(2, 16)
1232
#pragma GCC diagnostic push
1233
#pragma GCC diagnostic ignored "-Wsign-conversion"
1234
#endif
1235
#endif
1236
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1237
warning from
1238
-Wconversion
1239
in GNU libc
1240
before
1241
2.16 */
1242
#if defined (__GNUC__) and defined (__GLIBC__)
1243
#if not __GLIBC_PREREQ(2, 16)
1244
#pragma GCC diagnostic pop
1245
#endif
1246
#endif
1271
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1247
1272
/* This process had nothing to say at this time */
1248
1273
proc = proc->next;
1249
1274
continue;
1316
1341
free(custom_argv);
1317
1342
}
1318
1343
1319
if(dir != NULL){
1320
closedir(dir);
1344
free(direntries);
1345
1346
if(dir_fd != -1){
1347
close(dir_fd);
1321
1348
}
1322
1349
1323
1350
/* Kill the processes */
1343
1370
free_plugin_list();
1344
1371
1345
1372
free(plugindir);
1373
free(pluginhelperdir);
1346
1374
free(argfile);
1347
1375
1348
1376
return exitstatus;
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0