To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 1237
- compare with another revision
- download diff
- download tarball
- view history from revision 1237
- Committer: Teddy Hogeborn
- Date: 2021-02-03 23:10:42 UTC
- Revision ID: teddy@recompile.se-20210203231042-2z3egrvpo1zt7nej
mandos-ctl: Fix bad test for command.Remove and related minor issues
The test for command.Remove removes all clients from the spy server,
and then loops over all clients, looking for the corresponding Remove
command as recorded by the spy server. But since since there aren't
any clients left after they were removed, no assertions are made, and
the test therefore does nothing. Fix this.
In tests for command.Approve and command.Deny, add checks that clients
were not somehow removed by the command (in which case, likewise, no
assertions are made).
Add related checks to TestPropertySetterCmd.runTest; i.e. test that a
sequence is not empty before looping over it and making assertions.
* mandos-ctl (TestBaseCommands.test_Remove): Save a copy of the
original "clients" dict, and loop over those instead. Add assertion
that all clients were indeed removed. Also fix the code which looks
for the Remove command, which now needs to actually work.
(TestBaseCommands.test_Approve, TestBaseCommands.test_Deny): Add
assertion that there are still clients before looping over them.
(TestPropertySetterCmd.runTest): Add assertion that the list of
values to get is not empty before looping over them. Also add check
that there are still clients before looping over clients.
The test for command.Remove removes all clients from the spy server,
and then loops over all clients, looking for the corresponding Remove
command as recorded by the spy server. But since since there aren't
any clients left after they were removed, no assertions are made, and
the test therefore does nothing. Fix this.
In tests for command.Approve and command.Deny, add checks that clients
were not somehow removed by the command (in which case, likewise, no
assertions are made).
Add related checks to TestPropertySetterCmd.runTest; i.e. test that a
sequence is not empty before looping over it and making assertions.
* mandos-ctl (TestBaseCommands.test_Remove): Save a copy of the
original "clients" dict, and loop over those instead. Add assertion
that all clients were indeed removed. Also fix the code which looks
for the Remove command, which now needs to actually work.
(TestBaseCommands.test_Approve, TestBaseCommands.test_Deny): Add
assertion that there are still clients before looping over them.
(TestPropertySetterCmd.runTest): Add assertion that the list of
values to get is not empty before looping over them. Also add check
that there are still clients before looping over clients.
- files added:
- .bzr-builddeb
- debian
- debian/po
- debian/source
- debian/tests
- debian/upstream
- dracut-module
- network-hooks.d
- plugin-helpers
- files removed:
- network-protocol.txt
- files renamed:
- mandos-client.c => plugin-runner.c
- mandos-client.xml => plugin-runner.xml
- plugins.d/password-request.c => plugins.d/mandos-client.c
- plugins.d/password-request.xml => plugins.d/mandos-client.xml
- files modified:
- Makefile
added
removed
plugin-runner.c
1
/* -*- coding: utf-8 -*- */
1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2007-2008 Teddy Hogeborn & Björn Påhlsson
6
*
7
* This program is free software: you can redistribute it and/or
8
* modify it under the terms of the GNU General Public License as
9
* published by the Free Software Foundation, either version 3 of the
10
* License, or (at your option) any later version.
11
*
12
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2021 Teddy Hogeborn
6
* Copyright © 2008-2021 Björn Påhlsson
7
*
8
* This file is part of Mandos.
9
*
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
14
*
15
* Mandos is distributed in the hope that it will be useful, but
13
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
14
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15
18
* General Public License for more details.
16
19
*
17
20
* You should have received a copy of the GNU General Public License
18
* along with this program. If not, see
19
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
20
22
*
21
* Contact the authors at <mandos@fukt.bsnet.se>.
23
* Contact the authors at <mandos@recompile.se>.
22
24
*/
23
25
24
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY() */
25
26
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
27
getline(), asprintf(), O_CLOEXEC,
28
scandirat(), pipe2() */
29
#include <argp.h> /* argp_program_version,
30
argp_program_bug_address,
31
struct argp_option,
32
struct argp_state, argp_error(),
33
ARGP_NO_EXIT, argp_state_help,
34
ARGP_HELP_STD_HELP,
35
ARGP_HELP_USAGE, ARGP_HELP_EXIT_OK,
36
ARGP_KEY_ARG, ARGP_ERR_UNKNOWN,
37
struct argp, argp_parse(),
38
ARGP_IN_ORDER, ARGP_NO_HELP */
39
#include <stdbool.h> /* bool, false, true */
40
#include <sys/types.h> /* pid_t, sig_atomic_t, uid_t, gid_t,
41
getuid(), setgid(), setuid() */
26
42
#include <stddef.h> /* size_t, NULL */
27
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
28
EXIT_SUCCESS, realloc() */
29
#include <stdbool.h> /* bool, true, false */
30
#include <stdio.h> /* perror, popen(), fileno(),
31
fprintf(), stderr, STDOUT_FILENO */
32
#include <sys/types.h> /* DIR, opendir(), stat(), struct
33
stat, waitpid(), WIFEXITED(),
34
WEXITSTATUS(), wait(), pid_t,
35
uid_t, gid_t, getuid(), getgid(),
36
dirfd() */
37
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
38
FD_SET(), FD_ISSET(), FD_CLR */
39
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
40
WEXITSTATUS() */
41
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
42
#include <iso646.h> /* and, or, not */
43
#include <dirent.h> /* DIR, struct dirent, opendir(),
44
readdir(), closedir(), dirfd() */
45
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
46
fcntl(), setuid(), setgid(),
47
F_GETFD, F_SETFD, FD_CLOEXEC,
48
access(), pipe(), fork(), close()
49
dup2, STDOUT_FILENO, _exit(),
50
execv(), write(), read(),
51
close() */
43
#include <iso646.h> /* or, and, not */
44
#include <string.h> /* strcmp(), strdup(), strchrnul(),
45
strncmp(), strlen(), strcpy(),
46
strsep(), strchr(), strsignal() */
47
#include <stdlib.h> /* malloc(), free(), reallocarray(),
48
realloc(), EXIT_SUCCESS */
49
#include <errno.h> /* errno, EINTR, ENOMEM, ECHILD,
50
error_t, EINVAL, EMFILE, ENFILE,
51
ENOENT, ESRCH */
52
#include <stdint.h> /* SIZE_MAX */
53
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
54
getline(), asprintf(), O_CLOEXEC,
55
scandirat(), pipe2() */
56
#include <unistd.h> /* TEMP_FAILURE_RETRY(), ssize_t,
57
write(), STDOUT_FILENO, uid_t,
58
gid_t, getuid(), fchown(), close(),
59
symlink(), setgid(), setuid(),
60
faccessat(), X_OK, pipe(), pipe2(),
61
fork(), _exit(), dup2(), fexecve(),
62
read(), getpass() */
52
63
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
53
FD_CLOEXEC */
54
#include <string.h> /* strtok, strlen(), strcpy(),
55
strcat() */
56
#include <errno.h> /* errno */
57
#include <argp.h> /* struct argp_option, struct
58
argp_state, struct argp,
59
argp_parse(), ARGP_ERR_UNKNOWN,
60
ARGP_KEY_END, ARGP_KEY_ARG, error_t */
61
#include <signal.h> /* struct sigaction, sigemptyset(),
62
sigaddset(), sigaction(),
63
sigprocmask(), SIG_BLOCK, SIGCHLD,
64
SIG_UNBLOCK, kill() */
65
#include <errno.h> /* errno, EBADF */
64
FD_CLOEXEC, open(), O_RDONLY,
65
O_CLOEXEC, openat() */
66
#include <sys/wait.h> /* waitpid(), WNOHANG, WIFEXITED(),
67
WEXITSTATUS(), WIFSIGNALED(),
68
WTERMSIG(), wait() */
69
#include <error.h> /* error() */
70
#include <stdio.h> /* FILE, fprintf(), fopen(),
71
getline(), fclose(), EOF,
72
asprintf(), stderr */
73
#include <dirent.h> /* struct dirent, scandirat(),
74
alphasort() */
75
#include <sys/stat.h> /* struct stat, fstat(), S_ISDIR(),
76
lstat(), S_ISREG() */
77
#include <sys/select.h> /* fd_set, FD_ZERO(), FD_SETSIZE,
78
FD_SET(), select(), FD_CLR(),
79
FD_ISSET() */
80
#include <signal.h> /* struct sigaction, SA_NOCLDSTOP,
81
sigemptyset(), sigaddset(),
82
SIGCHLD, sigprocmask(), SIG_BLOCK,
83
SIG_UNBLOCK, kill(), SIGTERM */
84
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
85
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
86
#include <inttypes.h> /* intmax_t, strtoimax(), PRIdMAX */
87
#include <fnmatch.h> /* fnmatch(), FNM_FILE_NAME,
88
FNM_PERIOD, FNM_NOMATCH */
66
89
67
90
#define BUFFER_SIZE 256
68
91
69
struct process;
70
71
typedef struct process{
92
#define PDIR "/lib/mandos/plugins.d"
93
#define PHDIR "/lib/mandos/plugin-helpers"
94
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
95
96
const char *argp_program_version = "plugin-runner " VERSION;
97
const char *argp_program_bug_address = "<mandos@recompile.se>";
98
99
typedef struct plugin{
100
char *name; /* can be NULL or any plugin name */
101
char **argv;
102
int argc;
103
char **environ;
104
int envc;
105
bool disabled;
106
107
/* Variables used for running processes*/
72
108
pid_t pid;
73
109
int fd;
74
110
char *buffer;
75
111
size_t buffer_size;
76
112
size_t buffer_length;
77
113
bool eof;
78
bool completed;
114
volatile sig_atomic_t completed;
79
115
int status;
80
struct process *next;
81
} process;
82
83
typedef struct plugin{
84
char *name; /* can be NULL or any plugin name */
85
char **argv;
86
int argc;
87
bool disabled;
88
116
struct plugin *next;
89
117
} plugin;
90
118
91
static plugin *getplugin(char *name, plugin **plugin_list){
92
for (plugin *p = *plugin_list; p != NULL; p = p->next){
93
if ((p->name == name)
94
or (p->name and name and (strcmp(p->name, name) == 0))){
119
static plugin *plugin_list = NULL;
120
121
/* Gets an existing plugin based on name,
122
or if none is found, creates a new one */
123
__attribute__((warn_unused_result))
124
static plugin *getplugin(char *name){
125
/* Check for existing plugin with that name */
126
for(plugin *p = plugin_list; p != NULL; p = p->next){
127
if((p->name == name)
128
or (p->name and name and (strcmp(p->name, name) == 0))){
95
129
return p;
96
130
}
97
131
}
98
132
/* Create a new plugin */
99
plugin *new_plugin = malloc(sizeof(plugin));
100
if (new_plugin == NULL){
101
perror("malloc");
102
exit(EXIT_FAILURE);
103
}
104
new_plugin->name = name;
105
new_plugin->argv = malloc(sizeof(char *) * 2);
106
if (new_plugin->argv == NULL){
107
perror("malloc");
108
exit(EXIT_FAILURE);
109
}
110
new_plugin->argv[0] = name;
133
plugin *new_plugin = NULL;
134
do {
135
new_plugin = malloc(sizeof(plugin));
136
} while(new_plugin == NULL and errno == EINTR);
137
if(new_plugin == NULL){
138
return NULL;
139
}
140
char *copy_name = NULL;
141
if(name != NULL){
142
do {
143
copy_name = strdup(name);
144
} while(copy_name == NULL and errno == EINTR);
145
if(copy_name == NULL){
146
int e = errno;
147
free(new_plugin);
148
errno = e;
149
return NULL;
150
}
151
}
152
153
*new_plugin = (plugin){ .name = copy_name,
154
.argc = 1,
155
.disabled = false,
156
.next = plugin_list };
157
158
do {
159
new_plugin->argv = malloc(sizeof(char *) * 2);
160
} while(new_plugin->argv == NULL and errno == EINTR);
161
if(new_plugin->argv == NULL){
162
int e = errno;
163
free(copy_name);
164
free(new_plugin);
165
errno = e;
166
return NULL;
167
}
168
new_plugin->argv[0] = copy_name;
111
169
new_plugin->argv[1] = NULL;
112
new_plugin->argc = 1;
113
new_plugin->disabled = false;
114
new_plugin->next = *plugin_list;
170
171
do {
172
new_plugin->environ = malloc(sizeof(char *));
173
} while(new_plugin->environ == NULL and errno == EINTR);
174
if(new_plugin->environ == NULL){
175
int e = errno;
176
free(copy_name);
177
free(new_plugin->argv);
178
free(new_plugin);
179
errno = e;
180
return NULL;
181
}
182
new_plugin->environ[0] = NULL;
183
115
184
/* Append the new plugin to the list */
116
*plugin_list = new_plugin;
185
plugin_list = new_plugin;
117
186
return new_plugin;
118
187
}
119
188
120
static void addargument(plugin *p, char *arg){
121
p->argv[p->argc] = arg;
122
p->argv = realloc(p->argv, sizeof(char *) * (size_t)(p->argc + 2));
123
if (p->argv == NULL){
124
perror("malloc");
125
exit(EXIT_FAILURE);
126
}
127
p->argc++;
128
p->argv[p->argc] = NULL;
129
}
130
189
/* Helper function for add_argument and add_environment */
190
__attribute__((nonnull, warn_unused_result))
191
static bool add_to_char_array(const char *new, char ***array,
192
int *len){
193
/* Resize the pointed-to array to hold one more pointer */
194
char **new_array = NULL;
195
do {
196
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
197
new_array = reallocarray(*array, (size_t)((*len) + 2),
198
sizeof(char *));
199
#else
200
if(((size_t)((*len) + 2)) > (SIZE_MAX / sizeof(char *))){
201
/* overflow */
202
new_array = NULL;
203
errno = ENOMEM;
204
} else {
205
new_array = realloc(*array, (size_t)((*len) + 2)
206
* sizeof(char *));
207
}
208
#endif
209
} while(new_array == NULL and errno == EINTR);
210
/* Malloc check */
211
if(new_array == NULL){
212
return false;
213
}
214
*array = new_array;
215
/* Make a copy of the new string */
216
char *copy;
217
do {
218
copy = strdup(new);
219
} while(copy == NULL and errno == EINTR);
220
if(copy == NULL){
221
return false;
222
}
223
/* Insert the copy */
224
(*array)[*len] = copy;
225
(*len)++;
226
/* Add a new terminating NULL pointer to the last element */
227
(*array)[*len] = NULL;
228
return true;
229
}
230
231
/* Add to a plugin's argument vector */
232
__attribute__((nonnull(2), warn_unused_result))
233
static bool add_argument(plugin *p, const char *arg){
234
if(p == NULL){
235
return false;
236
}
237
return add_to_char_array(arg, &(p->argv), &(p->argc));
238
}
239
240
/* Add to a plugin's environment */
241
__attribute__((nonnull(2), warn_unused_result))
242
static bool add_environment(plugin *p, const char *def, bool replace){
243
if(p == NULL){
244
return false;
245
}
246
/* namelen = length of name of environment variable */
247
size_t namelen = (size_t)(strchrnul(def, '=') - def);
248
/* Search for this environment variable */
249
for(char **envdef = p->environ; *envdef != NULL; envdef++){
250
if(strncmp(*envdef, def, namelen + 1) == 0){
251
/* It already exists */
252
if(replace){
253
char *new_envdef;
254
do {
255
new_envdef = realloc(*envdef, strlen(def) + 1);
256
} while(new_envdef == NULL and errno == EINTR);
257
if(new_envdef == NULL){
258
return false;
259
}
260
*envdef = new_envdef;
261
strcpy(*envdef, def);
262
}
263
return true;
264
}
265
}
266
return add_to_char_array(def, &(p->environ), &(p->envc));
267
}
268
269
#ifndef O_CLOEXEC
131
270
/*
132
271
* Based on the example in the GNU LibC manual chapter 13.13 "File
133
272
* Descriptor Flags".
134
* *Note File Descriptor Flags:(libc)Descriptor Flags.
273
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
135
274
*/
136
static int set_cloexec_flag(int fd)
137
{
138
int ret = fcntl(fd, F_GETFD, 0);
275
__attribute__((warn_unused_result))
276
static int set_cloexec_flag(int fd){
277
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
139
278
/* If reading the flags failed, return error indication now. */
140
279
if(ret < 0){
141
280
return ret;
142
281
}
143
282
/* Store modified flag word in the descriptor. */
144
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
283
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
284
ret | FD_CLOEXEC));
145
285
}
146
147
const char *argp_program_version = "plugbasedclient 0.9";
148
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
149
150
process *process_list = NULL;
151
152
/* Mark a process as completed when it exits, and save its exit
286
#endif /* not O_CLOEXEC */
287
288
289
/* Mark processes as completed when they exit, and save their exit
153
290
status. */
154
void handle_sigchld(__attribute__((unused)) int sig){
155
process *proc = process_list;
156
int status;
157
pid_t pid = wait(&status);
158
if(pid == -1){
159
perror("wait");
160
return;
161
}
162
while(proc != NULL and proc->pid != pid){
163
proc = proc->next;
164
}
165
if(proc == NULL){
166
/* Process not found in process list */
167
return;
168
}
169
proc->status = status;
170
proc->completed = true;
291
static void handle_sigchld(__attribute__((unused)) int sig){
292
int old_errno = errno;
293
while(true){
294
plugin *proc = plugin_list;
295
int status;
296
pid_t pid = waitpid(-1, &status, WNOHANG);
297
if(pid == 0){
298
/* Only still running child processes */
299
break;
300
}
301
if(pid == -1){
302
if(errno == ECHILD){
303
/* No child processes */
304
break;
305
}
306
error(0, errno, "waitpid");
307
}
308
309
/* A child exited, find it in process_list */
310
while(proc != NULL and proc->pid != pid){
311
proc = proc->next;
312
}
313
if(proc == NULL){
314
/* Process not found in process list */
315
continue;
316
}
317
proc->status = status;
318
proc->completed = 1;
319
}
320
errno = old_errno;
321
}
322
323
/* Prints out a password to stdout */
324
__attribute__((nonnull, warn_unused_result))
325
static bool print_out_password(const char *buffer, size_t length){
326
ssize_t ret;
327
for(size_t written = 0; written < length; written += (size_t)ret){
328
ret = TEMP_FAILURE_RETRY(write(STDOUT_FILENO, buffer + written,
329
length - written));
330
if(ret < 0){
331
return false;
332
}
333
}
334
return true;
335
}
336
337
/* Removes and free a plugin from the plugin list */
338
__attribute__((nonnull))
339
static void free_plugin(plugin *plugin_node){
340
341
for(char **arg = (plugin_node->argv)+1; *arg != NULL; arg++){
342
free(*arg);
343
}
344
free(plugin_node->name);
345
free(plugin_node->argv);
346
for(char **env = plugin_node->environ; *env != NULL; env++){
347
free(*env);
348
}
349
free(plugin_node->environ);
350
free(plugin_node->buffer);
351
352
/* Removes the plugin from the singly-linked list */
353
if(plugin_node == plugin_list){
354
/* First one - simple */
355
plugin_list = plugin_list->next;
356
} else {
357
/* Second one or later */
358
for(plugin *p = plugin_list; p != NULL; p = p->next){
359
if(p->next == plugin_node){
360
p->next = plugin_node->next;
361
break;
362
}
363
}
364
}
365
366
free(plugin_node);
367
}
368
369
static void free_plugin_list(void){
370
while(plugin_list != NULL){
371
free_plugin(plugin_list);
372
}
171
373
}
172
374
173
375
int main(int argc, char *argv[]){
174
const char *plugindir = "/conf/conf.d/mandos/plugins.d";
175
size_t d_name_len;
176
DIR *dir = NULL;
177
struct dirent *dirst;
376
char *plugindir = NULL;
377
char *pluginhelperdir = NULL;
378
char *argfile = NULL;
379
FILE *conffp;
380
struct dirent **direntries = NULL;
178
381
struct stat st;
179
382
fd_set rfds_all;
180
383
int ret, maxfd = 0;
384
ssize_t sret;
181
385
uid_t uid = 65534;
182
386
gid_t gid = 65534;
183
387
bool debug = false;
185
389
struct sigaction old_sigchld_action;
186
390
struct sigaction sigchld_action = { .sa_handler = handle_sigchld,
187
391
.sa_flags = SA_NOCLDSTOP };
188
char *plus_options = NULL;
189
char **plus_argv = NULL;
392
char **custom_argv = NULL;
393
int custom_argc = 0;
394
int dir_fd = -1;
190
395
191
396
/* Establish a signal handler */
192
397
sigemptyset(&sigchld_action.sa_mask);
193
398
ret = sigaddset(&sigchld_action.sa_mask, SIGCHLD);
194
if(ret < 0){
195
perror("sigaddset");
196
exit(EXIT_FAILURE);
399
if(ret == -1){
400
error(0, errno, "sigaddset");
401
exitstatus = EX_OSERR;
402
goto fallback;
197
403
}
198
404
ret = sigaction(SIGCHLD, &sigchld_action, &old_sigchld_action);
199
if(ret < 0){
200
perror("sigaction");
201
exit(EXIT_FAILURE);
405
if(ret == -1){
406
error(0, errno, "sigaction");
407
exitstatus = EX_OSERR;
408
goto fallback;
202
409
}
203
410
204
411
/* The options we understand. */
206
413
{ .name = "global-options", .key = 'g',
207
414
.arg = "OPTION[,OPTION[,...]]",
208
415
.doc = "Options passed to all plugins" },
416
{ .name = "global-env", .key = 'G',
417
.arg = "VAR=value",
418
.doc = "Environment variable passed to all plugins" },
209
419
{ .name = "options-for", .key = 'o',
210
420
.arg = "PLUGIN:OPTION[,OPTION[,...]]",
211
421
.doc = "Options passed only to specified plugin" },
422
{ .name = "env-for", .key = 'E',
423
.arg = "PLUGIN:ENV=value",
424
.doc = "Environment variable passed to specified plugin" },
212
425
{ .name = "disable", .key = 'd',
213
426
.arg = "PLUGIN",
214
427
.doc = "Disable a specific plugin", .group = 1 },
428
{ .name = "enable", .key = 'e',
429
.arg = "PLUGIN",
430
.doc = "Enable a specific plugin", .group = 1 },
215
431
{ .name = "plugin-dir", .key = 128,
216
432
.arg = "DIRECTORY",
217
433
.doc = "Specify a different plugin directory", .group = 2 },
218
{ .name = "userid", .key = 129,
219
.arg = "ID", .flags = 0,
220
.doc = "User ID the plugins will run as", .group = 2 },
221
{ .name = "groupid", .key = 130,
222
.arg = "ID", .flags = 0,
223
.doc = "Group ID the plugins will run as", .group = 2 },
224
{ .name = "debug", .key = 131,
225
.doc = "Debug mode", .group = 3 },
434
{ .name = "config-file", .key = 129,
435
.arg = "FILE",
436
.doc = "Specify a different configuration file", .group = 2 },
437
{ .name = "userid", .key = 130,
438
.arg = "ID", .flags = 0,
439
.doc = "User ID the plugins will run as", .group = 3 },
440
{ .name = "groupid", .key = 131,
441
.arg = "ID", .flags = 0,
442
.doc = "Group ID the plugins will run as", .group = 3 },
443
{ .name = "debug", .key = 132,
444
.doc = "Debug mode", .group = 4 },
445
{ .name = "plugin-helper-dir", .key = 133,
446
.arg = "DIRECTORY",
447
.doc = "Specify a different plugin helper directory",
448
.group = 2 },
449
/*
450
* These reproduce what we would get without ARGP_NO_HELP
451
*/
452
{ .name = "help", .key = '?',
453
.doc = "Give this help list", .group = -1 },
454
{ .name = "usage", .key = -3,
455
.doc = "Give a short usage message", .group = -1 },
456
{ .name = "version", .key = 'V',
457
.doc = "Print program version", .group = -1 },
226
458
{ .name = NULL }
227
459
};
228
460
229
error_t parse_opt (int key, char *arg, struct argp_state *state) {
230
/* Get the INPUT argument from `argp_parse', which we know is a
231
pointer to our plugin list pointer. */
232
plugin **plugins = state->input;
233
switch (key) {
234
case 'g':
235
if (arg != NULL){
236
char *p = strtok(arg, ",");
237
do{
238
addargument(getplugin(NULL, plugins), p);
239
p = strtok(NULL, ",");
240
} while (p != NULL);
241
}
242
break;
243
case 'o':
244
if (arg != NULL){
245
char *name = strtok(arg, ":");
246
char *p = strtok(NULL, ":");
247
if(p != NULL){
248
p = strtok(p, ",");
249
do{
250
addargument(getplugin(name, plugins), p);
251
p = strtok(NULL, ",");
252
} while (p != NULL);
253
}
254
}
255
break;
256
case 'd':
257
if (arg != NULL){
258
getplugin(arg, plugins)->disabled = true;
259
}
260
break;
261
case 128:
262
plugindir = arg;
263
break;
264
case 129:
265
uid = (uid_t)strtol(arg, NULL, 10);
266
break;
267
case 130:
268
gid = (gid_t)strtol(arg, NULL, 10);
269
break;
270
case 131:
461
__attribute__((nonnull(3)))
462
error_t parse_opt(int key, char *arg, struct argp_state *state){
463
errno = 0;
464
switch(key){
465
char *tmp;
466
intmax_t tmp_id;
467
case 'g': /* --global-options */
468
{
469
char *plugin_option;
470
while((plugin_option = strsep(&arg, ",")) != NULL){
471
if(not add_argument(getplugin(NULL), plugin_option)){
472
break;
473
}
474
}
475
errno = 0;
476
}
477
break;
478
case 'G': /* --global-env */
479
if(add_environment(getplugin(NULL), arg, true)){
480
errno = 0;
481
}
482
break;
483
case 'o': /* --options-for */
484
{
485
char *option_list = strchr(arg, ':');
486
if(option_list == NULL){
487
argp_error(state, "No colon in \"%s\"", arg);
488
errno = EINVAL;
489
break;
490
}
491
*option_list = '\0';
492
option_list++;
493
if(arg[0] == '\0'){
494
argp_error(state, "Empty plugin name");
495
errno = EINVAL;
496
break;
497
}
498
char *option;
499
while((option = strsep(&option_list, ",")) != NULL){
500
if(not add_argument(getplugin(arg), option)){
501
break;
502
}
503
}
504
errno = 0;
505
}
506
break;
507
case 'E': /* --env-for */
508
{
509
char *envdef = strchr(arg, ':');
510
if(envdef == NULL){
511
argp_error(state, "No colon in \"%s\"", arg);
512
errno = EINVAL;
513
break;
514
}
515
*envdef = '\0';
516
envdef++;
517
if(arg[0] == '\0'){
518
argp_error(state, "Empty plugin name");
519
errno = EINVAL;
520
break;
521
}
522
if(add_environment(getplugin(arg), envdef, true)){
523
errno = 0;
524
}
525
}
526
break;
527
case 'd': /* --disable */
528
{
529
plugin *p = getplugin(arg);
530
if(p != NULL){
531
p->disabled = true;
532
errno = 0;
533
}
534
}
535
break;
536
case 'e': /* --enable */
537
{
538
plugin *p = getplugin(arg);
539
if(p != NULL){
540
p->disabled = false;
541
errno = 0;
542
}
543
}
544
break;
545
case 128: /* --plugin-dir */
546
free(plugindir);
547
plugindir = strdup(arg);
548
if(plugindir != NULL){
549
errno = 0;
550
}
551
break;
552
case 129: /* --config-file */
553
/* This is already done by parse_opt_config_file() */
554
break;
555
case 130: /* --userid */
556
tmp_id = strtoimax(arg, &tmp, 10);
557
if(errno != 0 or tmp == arg or *tmp != '\0'
558
or tmp_id != (uid_t)tmp_id){
559
argp_error(state, "Bad user ID number: \"%s\", using %"
560
PRIdMAX, arg, (intmax_t)uid);
561
break;
562
}
563
uid = (uid_t)tmp_id;
564
errno = 0;
565
break;
566
case 131: /* --groupid */
567
tmp_id = strtoimax(arg, &tmp, 10);
568
if(errno != 0 or tmp == arg or *tmp != '\0'
569
or tmp_id != (gid_t)tmp_id){
570
argp_error(state, "Bad group ID number: \"%s\", using %"
571
PRIdMAX, arg, (intmax_t)gid);
572
break;
573
}
574
gid = (gid_t)tmp_id;
575
errno = 0;
576
break;
577
case 132: /* --debug */
271
578
debug = true;
272
579
break;
273
case ARGP_KEY_ARG:
274
if(plus_options != NULL or arg == NULL or arg[0] != '+'){
275
argp_usage (state);
276
}
277
plus_options = arg;
278
break;
279
case ARGP_KEY_END:
280
break;
281
default:
282
return ARGP_ERR_UNKNOWN;
283
}
284
return 0;
285
}
286
287
plugin *plugin_list = NULL;
288
289
struct argp argp = { .options = options, .parser = parse_opt,
290
.args_doc = "[+PLUS_SEPARATED_OPTIONS]",
580
case 133: /* --plugin-helper-dir */
581
free(pluginhelperdir);
582
pluginhelperdir = strdup(arg);
583
if(pluginhelperdir != NULL){
584
errno = 0;
585
}
586
break;
587
/*
588
* These reproduce what we would get without ARGP_NO_HELP
589
*/
590
case '?': /* --help */
591
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
592
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
593
__builtin_unreachable();
594
case -3: /* --usage */
595
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
596
argp_state_help(state, state->out_stream,
597
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
598
__builtin_unreachable();
599
case 'V': /* --version */
600
fprintf(state->out_stream, "%s\n", argp_program_version);
601
exit(EXIT_SUCCESS);
602
break;
603
/*
604
* When adding more options before this line, remember to also add a
605
* "case" to the "parse_opt_config_file" function below.
606
*/
607
case ARGP_KEY_ARG:
608
/* Cryptsetup always passes an argument, which is an empty
609
string if "none" was specified in /etc/crypttab. So if
610
argument was empty, we ignore it silently. */
611
if(arg[0] == '\0'){
612
break;
613
}
614
#if __GNUC__ >= 7
615
__attribute__((fallthrough));
616
#else
617
/* FALLTHROUGH */
618
#endif
619
default:
620
return ARGP_ERR_UNKNOWN;
621
}
622
return errno; /* Set to 0 at start */
623
}
624
625
/* This option parser is the same as parse_opt() above, except it
626
ignores everything but the --config-file option. */
627
error_t parse_opt_config_file(int key, char *arg,
628
__attribute__((unused))
629
struct argp_state *state){
630
errno = 0;
631
switch(key){
632
case 'g': /* --global-options */
633
case 'G': /* --global-env */
634
case 'o': /* --options-for */
635
case 'E': /* --env-for */
636
case 'd': /* --disable */
637
case 'e': /* --enable */
638
case 128: /* --plugin-dir */
639
break;
640
case 129: /* --config-file */
641
free(argfile);
642
argfile = strdup(arg);
643
if(argfile != NULL){
644
errno = 0;
645
}
646
break;
647
case 130: /* --userid */
648
case 131: /* --groupid */
649
case 132: /* --debug */
650
case 133: /* --plugin-helper-dir */
651
case '?': /* --help */
652
case -3: /* --usage */
653
case 'V': /* --version */
654
case ARGP_KEY_ARG:
655
break;
656
default:
657
return ARGP_ERR_UNKNOWN;
658
}
659
return errno;
660
}
661
662
struct argp argp = { .options = options,
663
.parser = parse_opt_config_file,
664
.args_doc = "",
291
665
.doc = "Mandos plugin runner -- Run plugins" };
292
666
293
ret = argp_parse (&argp, argc, argv, 0, 0, &plugin_list);
294
if (ret == ARGP_ERR_UNKNOWN){
295
fprintf(stderr, "Unkown error while parsing arguments\n");
296
exitstatus = EXIT_FAILURE;
297
goto end;
298
}
299
300
if(plus_options){
301
/* This is a mangled argument in the form of
302
"+--option+--other-option=parameter+--yet-another-option", etc */
303
/* Make new argc and argv vars, and call argp_parse() again. */
304
plus_options++; /* skip the first '+' character */
305
const char delims[] = "+";
306
char *arg;
307
int new_argc = 1;
308
plus_argv = malloc(sizeof(char*) * 2);
309
if(plus_argv == NULL){
310
perror("malloc");
311
exitstatus = EXIT_FAILURE;
312
goto end;
313
}
314
plus_argv[0] = argv[0];
315
plus_argv[1] = NULL;
316
arg = strtok(plus_options, delims); /* Get first argument */
317
while(arg != NULL){
318
new_argc++;
319
plus_argv = realloc(plus_argv, sizeof(char *)
320
* ((unsigned int) new_argc + 1));
321
if(plus_argv == NULL){
322
perror("realloc");
323
exitstatus = EXIT_FAILURE;
324
goto end;
325
}
326
plus_argv[new_argc-1] = arg;
327
plus_argv[new_argc] = NULL;
328
arg = strtok(NULL, delims); /* Get next argument */
329
}
330
ret = argp_parse (&argp, new_argc, plus_argv, 0, 0, &plugin_list);
331
if (ret == ARGP_ERR_UNKNOWN){
332
fprintf(stderr, "Unkown error while parsing arguments\n");
333
exitstatus = EXIT_FAILURE;
334
goto end;
667
/* Parse using parse_opt_config_file() in order to get the custom
668
config file location, if any. */
669
ret = argp_parse(&argp, argc, argv,
670
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
671
NULL, NULL);
672
switch(ret){
673
case 0:
674
break;
675
case ENOMEM:
676
default:
677
errno = ret;
678
error(0, errno, "argp_parse");
679
exitstatus = EX_OSERR;
680
goto fallback;
681
case EINVAL:
682
exitstatus = EX_USAGE;
683
goto fallback;
684
}
685
686
/* Reset to the normal argument parser */
687
argp.parser = parse_opt;
688
689
/* Open the configfile if available */
690
if(argfile == NULL){
691
conffp = fopen(AFILE, "r");
692
} else {
693
conffp = fopen(argfile, "r");
694
}
695
if(conffp != NULL){
696
char *org_line = NULL;
697
char *p, *arg, *new_arg, *line;
698
size_t size = 0;
699
const char whitespace_delims[] = " \r\t\f\v\n";
700
const char comment_delim[] = "#";
701
702
custom_argc = 1;
703
custom_argv = malloc(sizeof(char*) * 2);
704
if(custom_argv == NULL){
705
error(0, errno, "malloc");
706
exitstatus = EX_OSERR;
707
goto fallback;
708
}
709
custom_argv[0] = argv[0];
710
custom_argv[1] = NULL;
711
712
/* for each line in the config file, strip whitespace and ignore
713
commented text */
714
while(true){
715
sret = getline(&org_line, &size, conffp);
716
if(sret == -1){
717
break;
718
}
719
720
line = org_line;
721
arg = strsep(&line, comment_delim);
722
while((p = strsep(&arg, whitespace_delims)) != NULL){
723
if(p[0] == '\0'){
724
continue;
725
}
726
new_arg = strdup(p);
727
if(new_arg == NULL){
728
error(0, errno, "strdup");
729
exitstatus = EX_OSERR;
730
free(org_line);
731
goto fallback;
732
}
733
734
custom_argc += 1;
735
{
736
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
737
char **new_argv = reallocarray(custom_argv, (size_t)custom_argc + 1,
738
sizeof(char *));
739
#else
740
char **new_argv = NULL;
741
if(((size_t)custom_argc + 1) > (SIZE_MAX / sizeof(char *))){
742
/* overflow */
743
errno = ENOMEM;
744
} else {
745
new_argv = realloc(custom_argv, ((size_t)custom_argc + 1)
746
* sizeof(char *));
747
}
748
#endif
749
if(new_argv == NULL){
750
error(0, errno, "reallocarray");
751
exitstatus = EX_OSERR;
752
free(new_arg);
753
free(org_line);
754
goto fallback;
755
} else {
756
custom_argv = new_argv;
757
}
758
}
759
custom_argv[custom_argc-1] = new_arg;
760
custom_argv[custom_argc] = NULL;
761
}
762
}
763
do {
764
ret = fclose(conffp);
765
} while(ret == EOF and errno == EINTR);
766
if(ret == EOF){
767
error(0, errno, "fclose");
768
exitstatus = EX_IOERR;
769
goto fallback;
770
}
771
free(org_line);
772
} else {
773
/* Check for harmful errors and go to fallback. Other errors might
774
not affect opening plugins */
775
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
776
error(0, errno, "fopen");
777
exitstatus = EX_OSERR;
778
goto fallback;
779
}
780
}
781
/* If there were any arguments from the configuration file, pass
782
them to parser as command line arguments */
783
if(custom_argv != NULL){
784
ret = argp_parse(&argp, custom_argc, custom_argv,
785
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
786
NULL, NULL);
787
switch(ret){
788
case 0:
789
break;
790
case ENOMEM:
791
default:
792
errno = ret;
793
error(0, errno, "argp_parse");
794
exitstatus = EX_OSERR;
795
goto fallback;
796
case EINVAL:
797
exitstatus = EX_CONFIG;
798
goto fallback;
799
}
800
}
801
802
/* Parse actual command line arguments, to let them override the
803
config file */
804
ret = argp_parse(&argp, argc, argv,
805
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
806
NULL, NULL);
807
switch(ret){
808
case 0:
809
break;
810
case ENOMEM:
811
default:
812
errno = ret;
813
error(0, errno, "argp_parse");
814
exitstatus = EX_OSERR;
815
goto fallback;
816
case EINVAL:
817
exitstatus = EX_USAGE;
818
goto fallback;
819
}
820
821
{
822
char *pluginhelperenv;
823
bool bret = true;
824
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
825
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
826
if(ret != -1){
827
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
828
}
829
if(ret == -1 or not bret){
830
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
831
" environment variable to \"%s\" for all plugins\n",
832
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
833
}
834
if(ret != -1){
835
free(pluginhelperenv);
335
836
}
336
837
}
337
838
338
839
if(debug){
339
for(plugin *p = plugin_list; p != NULL; p=p->next){
840
for(plugin *p = plugin_list; p != NULL; p = p->next){
340
841
fprintf(stderr, "Plugin: %s has %d arguments\n",
341
842
p->name ? p->name : "Global", p->argc - 1);
342
843
for(char **a = p->argv; *a != NULL; a++){
343
844
fprintf(stderr, "\tArg: %s\n", *a);
344
845
}
345
}
346
}
347
846
fprintf(stderr, "...and %d environment variables\n", p->envc);
847
for(char **a = p->environ; *a != NULL; a++){
848
fprintf(stderr, "\t%s\n", *a);
849
}
850
}
851
}
852
853
if(getuid() == 0){
854
/* Work around Debian bug #633582:
855
<https://bugs.debian.org/633582> */
856
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
857
if(plugindir_fd == -1){
858
if(errno != ENOENT){
859
error(0, errno, "open(\"" PDIR "\")");
860
}
861
} else {
862
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
863
if(ret == -1){
864
error(0, errno, "fstat");
865
} else {
866
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
867
ret = fchown(plugindir_fd, uid, gid);
868
if(ret == -1){
869
error(0, errno, "fchown");
870
}
871
}
872
}
873
close(plugindir_fd);
874
}
875
876
/* Work around Debian bug #981302
877
<https://bugs.debian.org/981302> */
878
if(lstat("/dev/fd", &st) != 0 and errno == ENOENT){
879
ret = symlink("/proc/self/fd", "/dev/fd");
880
if(ret == -1){
881
error(0, errno, "Failed to create /dev/fd symlink");
882
}
883
}
884
}
885
886
/* Lower permissions */
887
ret = setgid(gid);
888
if(ret == -1){
889
error(0, errno, "setgid");
890
}
348
891
ret = setuid(uid);
349
if (ret == -1){
350
perror("setuid");
351
}
352
353
setgid(gid);
354
if (ret == -1){
355
perror("setgid");
356
}
357
358
dir = opendir(plugindir);
359
if(dir == NULL){
360
perror("Could not open plugin dir");
361
exitstatus = EXIT_FAILURE;
362
goto end;
363
}
364
365
/* Set the FD_CLOEXEC flag on the directory, if possible */
892
if(ret == -1){
893
error(0, errno, "setuid");
894
}
895
896
/* Open plugin directory with close_on_exec flag */
366
897
{
367
int dir_fd = dirfd(dir);
368
if(dir_fd >= 0){
369
ret = set_cloexec_flag(dir_fd);
370
if(ret < 0){
371
perror("set_cloexec_flag");
372
exitstatus = EXIT_FAILURE;
373
goto end;
898
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
899
#ifdef O_CLOEXEC
900
O_CLOEXEC
901
#else /* not O_CLOEXEC */
902
0
903
#endif /* not O_CLOEXEC */
904
);
905
if(dir_fd == -1){
906
error(0, errno, "Could not open plugin dir");
907
exitstatus = EX_UNAVAILABLE;
908
goto fallback;
909
}
910
911
#ifndef O_CLOEXEC
912
/* Set the FD_CLOEXEC flag on the directory */
913
ret = set_cloexec_flag(dir_fd);
914
if(ret < 0){
915
error(0, errno, "set_cloexec_flag");
916
exitstatus = EX_OSERR;
917
goto fallback;
918
}
919
#endif /* O_CLOEXEC */
920
}
921
922
int good_name(const struct dirent * const dirent){
923
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
924
"*.dpkg-old", "*.dpkg-bak",
925
"*.dpkg-divert", NULL };
926
#ifdef __GNUC__
927
#pragma GCC diagnostic push
928
#pragma GCC diagnostic ignored "-Wcast-qual"
929
#endif
930
for(const char **pat = (const char **)patterns;
931
*pat != NULL; pat++){
932
#ifdef __GNUC__
933
#pragma GCC diagnostic pop
934
#endif
935
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
936
!= FNM_NOMATCH){
937
if(debug){
938
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
939
" matching pattern %s\n", dirent->d_name, *pat);
940
}
941
return 0;
374
942
}
375
943
}
944
return 1;
945
}
946
947
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
948
alphasort);
949
if(numplugins == -1){
950
error(0, errno, "Could not scan plugin dir");
951
direntries = NULL;
952
exitstatus = EX_OSERR;
953
goto fallback;
376
954
}
377
955
378
956
FD_ZERO(&rfds_all);
379
957
380
while(true){
381
dirst = readdir(dir);
382
383
// All directory entries have been processed
384
if(dirst == NULL){
385
if (errno == EBADF){
386
perror("readdir");
387
exitstatus = EXIT_FAILURE;
388
goto end;
389
}
390
break;
391
}
392
393
d_name_len = strlen(dirst->d_name);
394
395
// Ignore dotfiles, backup files and other junk
396
{
397
bool bad_name = false;
398
399
const char const *bad_prefixes[] = { ".", "#", NULL };
400
401
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
402
".dpkg-old",
403
".dpkg-divert", NULL };
404
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
405
size_t pre_len = strlen(*pre);
406
if((d_name_len >= pre_len)
407
and strncmp((dirst->d_name), *pre, pre_len) == 0){
408
if(debug){
409
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
410
" with bad prefix %s\n", dirst->d_name, *pre);
411
}
412
bad_name = true;
413
break;
414
}
415
}
416
417
if(bad_name){
418
continue;
419
}
420
421
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
422
size_t suf_len = strlen(*suf);
423
if((d_name_len >= suf_len)
424
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
425
== 0)){
426
if(debug){
427
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
428
" with bad suffix %s\n", dirst->d_name, *suf);
429
}
430
bad_name = true;
431
break;
432
}
433
}
434
435
if(bad_name){
436
continue;
437
}
438
}
439
440
char *filename = malloc(d_name_len + strlen(plugindir) + 2);
441
if (filename == NULL){
442
perror("malloc");
443
exitstatus = EXIT_FAILURE;
444
goto end;
445
}
446
strcpy(filename, plugindir); /* Spurious warning */
447
strcat(filename, "/"); /* Spurious warning */
448
strcat(filename, dirst->d_name); /* Spurious warning */
449
450
ret = stat(filename, &st);
451
if (ret == -1){
452
perror("stat");
453
exitstatus = EXIT_FAILURE;
454
goto end;
455
}
456
457
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
958
/* Read and execute any executable in the plugin directory*/
959
for(int i = 0; i < numplugins; i++){
960
961
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
962
if(plugin_fd == -1){
963
error(0, errno, "Could not open plugin");
964
free(direntries[i]);
965
continue;
966
}
967
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
968
if(ret == -1){
969
error(0, errno, "stat");
970
close(plugin_fd);
971
free(direntries[i]);
972
continue;
973
}
974
975
/* Ignore non-executable files */
976
if(not S_ISREG(st.st_mode)
977
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
978
X_OK, 0)) != 0)){
458
979
if(debug){
459
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
460
" with bad type or mode\n", filename);
980
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
981
" with bad type or mode\n",
982
plugindir != NULL ? plugindir : PDIR,
983
direntries[i]->d_name);
461
984
}
462
free(filename);
463
continue;
464
}
465
if(getplugin(dirst->d_name, &plugin_list)->disabled){
985
close(plugin_fd);
986
free(direntries[i]);
987
continue;
988
}
989
990
plugin *p = getplugin(direntries[i]->d_name);
991
if(p == NULL){
992
error(0, errno, "getplugin");
993
close(plugin_fd);
994
free(direntries[i]);
995
continue;
996
}
997
if(p->disabled){
466
998
if(debug){
467
999
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
468
dirst->d_name);
1000
direntries[i]->d_name);
469
1001
}
470
free(filename);
1002
close(plugin_fd);
1003
free(direntries[i]);
471
1004
continue;
472
1005
}
473
plugin *p = getplugin(dirst->d_name, &plugin_list);
474
1006
{
475
1007
/* Add global arguments to argument list for this plugin */
476
plugin *g = getplugin(NULL, &plugin_list);
477
for(char **a = g->argv + 1; *a != NULL; a++){
478
addargument(p, *a);
479
}
480
}
481
int pipefd[2];
482
ret = pipe(pipefd);
483
if (ret == -1){
484
perror("pipe");
485
exitstatus = EXIT_FAILURE;
486
goto end;
487
}
1008
plugin *g = getplugin(NULL);
1009
if(g != NULL){
1010
for(char **a = g->argv + 1; *a != NULL; a++){
1011
if(not add_argument(p, *a)){
1012
error(0, errno, "add_argument");
1013
}
1014
}
1015
/* Add global environment variables */
1016
for(char **e = g->environ; *e != NULL; e++){
1017
if(not add_environment(p, *e, false)){
1018
error(0, errno, "add_environment");
1019
}
1020
}
1021
}
1022
}
1023
/* If this plugin has any environment variables, we need to
1024
duplicate the environment from this process, too. */
1025
if(p->environ[0] != NULL){
1026
for(char **e = environ; *e != NULL; e++){
1027
if(not add_environment(p, *e, false)){
1028
error(0, errno, "add_environment");
1029
}
1030
}
1031
}
1032
1033
int pipefd[2];
1034
#ifndef O_CLOEXEC
1035
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1036
#else /* O_CLOEXEC */
1037
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
1038
#endif /* O_CLOEXEC */
1039
if(ret == -1){
1040
error(0, errno, "pipe");
1041
exitstatus = EX_OSERR;
1042
free(direntries[i]);
1043
goto fallback;
1044
}
1045
if(pipefd[0] >= FD_SETSIZE){
1046
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1047
FD_SETSIZE);
1048
close(pipefd[0]);
1049
close(pipefd[1]);
1050
exitstatus = EX_OSERR;
1051
free(direntries[i]);
1052
goto fallback;
1053
}
1054
#ifndef O_CLOEXEC
1055
/* Ask OS to automatic close the pipe on exec */
488
1056
ret = set_cloexec_flag(pipefd[0]);
489
1057
if(ret < 0){
490
perror("set_cloexec_flag");
491
exitstatus = EXIT_FAILURE;
492
goto end;
1058
error(0, errno, "set_cloexec_flag");
1059
close(pipefd[0]);
1060
close(pipefd[1]);
1061
exitstatus = EX_OSERR;
1062
free(direntries[i]);
1063
goto fallback;
493
1064
}
494
1065
ret = set_cloexec_flag(pipefd[1]);
495
1066
if(ret < 0){
496
perror("set_cloexec_flag");
497
exitstatus = EXIT_FAILURE;
498
goto end;
1067
error(0, errno, "set_cloexec_flag");
1068
close(pipefd[0]);
1069
close(pipefd[1]);
1070
exitstatus = EX_OSERR;
1071
free(direntries[i]);
1072
goto fallback;
499
1073
}
1074
#endif /* not O_CLOEXEC */
500
1075
/* Block SIGCHLD until process is safely in process list */
501
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1076
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1077
&sigchld_action.sa_mask,
1078
NULL));
502
1079
if(ret < 0){
503
perror("sigprocmask");
504
exitstatus = EXIT_FAILURE;
505
goto end;
506
}
507
// Starting a new process to be watched
508
pid_t pid = fork();
1080
error(0, errno, "sigprocmask");
1081
exitstatus = EX_OSERR;
1082
free(direntries[i]);
1083
goto fallback;
1084
}
1085
/* Starting a new process to be watched */
1086
pid_t pid;
1087
do {
1088
pid = fork();
1089
} while(pid == -1 and errno == EINTR);
1090
if(pid == -1){
1091
error(0, errno, "fork");
1092
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1093
&sigchld_action.sa_mask, NULL));
1094
close(pipefd[0]);
1095
close(pipefd[1]);
1096
exitstatus = EX_OSERR;
1097
free(direntries[i]);
1098
goto fallback;
1099
}
509
1100
if(pid == 0){
510
1101
/* this is the child process */
511
1102
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
512
1103
if(ret < 0){
513
perror("sigaction");
514
_exit(EXIT_FAILURE);
1104
error(0, errno, "sigaction");
1105
_exit(EX_OSERR);
515
1106
}
516
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1107
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
517
1108
if(ret < 0){
518
perror("sigprocmask");
519
_exit(EXIT_FAILURE);
1109
error(0, errno, "sigprocmask");
1110
_exit(EX_OSERR);
520
1111
}
521
1112
522
1113
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
523
1114
if(ret == -1){
524
perror("dup2");
525
_exit(EXIT_FAILURE);
1115
error(0, errno, "dup2");
1116
_exit(EX_OSERR);
526
1117
}
527
1118
528
if(dirfd(dir) < 0){
529
/* If dir has no file descriptor, we could not set FD_CLOEXEC
530
above and must now close it manually here. */
531
closedir(dir);
532
}
533
if(execv(filename, p->argv) < 0){
534
perror("execv");
535
_exit(EXIT_FAILURE);
1119
if(fexecve(plugin_fd, p->argv,
1120
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1121
error(0, errno, "fexecve for %s/%s",
1122
plugindir != NULL ? plugindir : PDIR,
1123
direntries[i]->d_name);
1124
_exit(EX_OSERR);
536
1125
}
537
1126
/* no return */
538
1127
}
539
/* parent process */
540
free(filename);
541
close(pipefd[1]); /* close unused write end of pipe */
542
process *new_process = malloc(sizeof(process));
543
if (new_process == NULL){
544
perror("malloc");
545
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1128
/* Parent process */
1129
close(pipefd[1]); /* Close unused write end of pipe */
1130
close(plugin_fd);
1131
plugin *new_plugin = getplugin(direntries[i]->d_name);
1132
if(new_plugin == NULL){
1133
error(0, errno, "getplugin");
1134
ret = (int)(TEMP_FAILURE_RETRY
1135
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
1136
NULL)));
546
1137
if(ret < 0){
547
perror("sigprocmask");
1138
error(0, errno, "sigprocmask");
548
1139
}
549
exitstatus = EXIT_FAILURE;
550
goto end;
1140
exitstatus = EX_OSERR;
1141
free(direntries[i]);
1142
goto fallback;
551
1143
}
1144
free(direntries[i]);
552
1145
553
*new_process = (struct process){ .pid = pid,
554
.fd = pipefd[0],
555
.next = process_list };
556
// List handling
557
process_list = new_process;
1146
new_plugin->pid = pid;
1147
new_plugin->fd = pipefd[0];
1148
1149
if(debug){
1150
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1151
new_plugin->name, (intmax_t) (new_plugin->pid));
1152
}
1153
558
1154
/* Unblock SIGCHLD so signal handler can be run if this process
559
1155
has already completed */
560
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1156
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1157
&sigchld_action.sa_mask,
1158
NULL));
561
1159
if(ret < 0){
562
perror("sigprocmask");
563
exitstatus = EXIT_FAILURE;
564
goto end;
565
}
566
567
FD_SET(new_process->fd, &rfds_all);
568
569
if (maxfd < new_process->fd){
570
maxfd = new_process->fd;
571
}
572
573
}
574
575
/* Free the plugin list */
576
for(plugin *next; plugin_list != NULL; plugin_list = next){
577
next = plugin_list->next;
578
free(plugin_list->argv);
579
free(plugin_list);
580
}
581
582
closedir(dir);
583
dir = NULL;
584
585
if (process_list == NULL){
586
fprintf(stderr, "No plugin processes started, exiting\n");
587
exitstatus = EXIT_FAILURE;
588
goto end;
589
}
590
while(process_list){
1160
error(0, errno, "sigprocmask");
1161
exitstatus = EX_OSERR;
1162
goto fallback;
1163
}
1164
1165
FD_SET(new_plugin->fd, &rfds_all);
1166
1167
if(maxfd < new_plugin->fd){
1168
maxfd = new_plugin->fd;
1169
}
1170
}
1171
1172
free(direntries);
1173
direntries = NULL;
1174
close(dir_fd);
1175
dir_fd = -1;
1176
free_plugin(getplugin(NULL));
1177
1178
for(plugin *p = plugin_list; p != NULL; p = p->next){
1179
if(p->pid != 0){
1180
break;
1181
}
1182
if(p->next == NULL){
1183
fprintf(stderr, "No plugin processes started. Incorrect plugin"
1184
" directory?\n");
1185
free_plugin_list();
1186
}
1187
}
1188
1189
/* Main loop while running plugins exist */
1190
while(plugin_list){
591
1191
fd_set rfds = rfds_all;
592
1192
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
593
if (select_ret == -1){
594
perror("select");
595
exitstatus = EXIT_FAILURE;
596
goto end;
1193
if(select_ret == -1 and errno != EINTR){
1194
error(0, errno, "select");
1195
exitstatus = EX_OSERR;
1196
goto fallback;
597
1197
}
598
1198
/* OK, now either a process completed, or something can be read
599
1199
from one of them */
600
for(process *proc = process_list; proc ; proc = proc->next){
1200
for(plugin *proc = plugin_list; proc != NULL;){
601
1201
/* Is this process completely done? */
602
if(proc->eof and proc->completed){
1202
if(proc->completed and proc->eof){
603
1203
/* Only accept the plugin output if it exited cleanly */
604
1204
if(not WIFEXITED(proc->status)
605
1205
or WEXITSTATUS(proc->status) != 0){
606
1206
/* Bad exit by plugin */
1207
607
1208
if(debug){
608
1209
if(WIFEXITED(proc->status)){
609
fprintf(stderr, "Plugin %d exited with status %d\n",
610
proc->pid, WEXITSTATUS(proc->status));
611
} else if(WIFSIGNALED(proc->status)) {
612
fprintf(stderr, "Plugin %d killed by signal %d\n",
613
proc->pid, WTERMSIG(proc->status));
614
} else if(WCOREDUMP(proc->status)){
615
fprintf(stderr, "Plugin %d dumped core\n", proc->pid);
1210
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1211
" status %d\n", proc->name,
1212
(intmax_t) (proc->pid),
1213
WEXITSTATUS(proc->status));
1214
} else if(WIFSIGNALED(proc->status)){
1215
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1216
" signal %d: %s\n", proc->name,
1217
(intmax_t) (proc->pid),
1218
WTERMSIG(proc->status),
1219
strsignal(WTERMSIG(proc->status)));
616
1220
}
617
1221
}
1222
618
1223
/* Remove the plugin */
619
1224
FD_CLR(proc->fd, &rfds_all);
1225
620
1226
/* Block signal while modifying process_list */
621
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1227
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1228
(SIG_BLOCK,
1229
&sigchld_action.sa_mask,
1230
NULL));
622
1231
if(ret < 0){
623
perror("sigprocmask");
624
exitstatus = EXIT_FAILURE;
625
goto end;
626
}
627
/* Delete this process entry from the list */
628
if(process_list == proc){
629
/* First one - simple */
630
process_list = proc->next;
631
} else {
632
/* Second one or later */
633
for(process *p = process_list; p != NULL; p = p->next){
634
if(p->next == proc){
635
p->next = proc->next;
636
break;
637
}
638
}
639
}
1232
error(0, errno, "sigprocmask");
1233
exitstatus = EX_OSERR;
1234
goto fallback;
1235
}
1236
1237
plugin *next_plugin = proc->next;
1238
free_plugin(proc);
1239
proc = next_plugin;
1240
640
1241
/* We are done modifying process list, so unblock signal */
641
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,
642
NULL);
1242
ret = (int)(TEMP_FAILURE_RETRY
1243
(sigprocmask(SIG_UNBLOCK,
1244
&sigchld_action.sa_mask, NULL)));
643
1245
if(ret < 0){
644
perror("sigprocmask");
645
}
646
free(proc->buffer);
647
free(proc);
648
/* We deleted this process from the list, so we can't go
649
proc->next. Therefore, start over from the beginning of
650
the process list */
651
break;
1246
error(0, errno, "sigprocmask");
1247
exitstatus = EX_OSERR;
1248
goto fallback;
1249
}
1250
1251
if(plugin_list == NULL){
1252
break;
1253
}
1254
1255
continue;
652
1256
}
1257
653
1258
/* This process exited nicely, so print its buffer */
654
for(size_t written = 0; written < proc->buffer_length;
655
written += (size_t)ret){
656
ret = TEMP_FAILURE_RETRY(write(STDOUT_FILENO,
657
proc->buffer + written,
658
proc->buffer_length
659
- written));
660
if(ret < 0){
661
perror("write");
662
exitstatus = EXIT_FAILURE;
663
goto end;
664
}
1259
1260
bool bret = print_out_password(proc->buffer,
1261
proc->buffer_length);
1262
if(not bret){
1263
error(0, errno, "print_out_password");
1264
exitstatus = EX_IOERR;
665
1265
}
666
goto end;
1266
goto fallback;
667
1267
}
1268
668
1269
/* This process has not completed. Does it have any output? */
669
1270
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
670
1271
/* This process had nothing to say at this time */
1272
proc = proc->next;
671
1273
continue;
672
1274
}
673
1275
/* Before reading, make the process' data buffer large enough */
674
1276
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
675
proc->buffer = realloc(proc->buffer, proc->buffer_size
676
+ (size_t) BUFFER_SIZE);
677
if (proc->buffer == NULL){
678
perror("malloc");
679
exitstatus = EXIT_FAILURE;
680
goto end;
1277
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1278
+ (size_t) BUFFER_SIZE);
1279
if(new_buffer == NULL){
1280
error(0, errno, "malloc");
1281
exitstatus = EX_OSERR;
1282
goto fallback;
681
1283
}
1284
proc->buffer = new_buffer;
682
1285
proc->buffer_size += BUFFER_SIZE;
683
1286
}
684
1287
/* Read from the process */
685
ret = read(proc->fd, proc->buffer + proc->buffer_length,
686
BUFFER_SIZE);
687
if(ret < 0){
1288
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1289
proc->buffer
1290
+ proc->buffer_length,
1291
BUFFER_SIZE));
1292
if(sret < 0){
688
1293
/* Read error from this process; ignore the error */
1294
proc = proc->next;
689
1295
continue;
690
1296
}
691
if(ret == 0){
1297
if(sret == 0){
692
1298
/* got EOF */
693
1299
proc->eof = true;
694
1300
} else {
695
proc->buffer_length += (size_t) ret;
1301
proc->buffer_length += (size_t) sret;
696
1302
}
697
1303
}
698
1304
}
699
if(process_list == NULL){
700
fprintf(stderr, "All plugin processes failed, exiting\n");
701
exitstatus = EXIT_FAILURE;
1305
1306
1307
fallback:
1308
1309
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1310
and exitstatus != EX_OK)){
1311
/* Fallback if all plugins failed, none are found or an error
1312
occured */
1313
bool bret;
1314
fprintf(stderr, "Going to fallback mode using getpass(3)\n");
1315
char *passwordbuffer = getpass("Password: ");
1316
size_t len = strlen(passwordbuffer);
1317
/* Strip trailing newline */
1318
if(len > 0 and passwordbuffer[len-1] == '\n'){
1319
passwordbuffer[len-1] = '\0'; /* not strictly necessary */
1320
len--;
1321
}
1322
bret = print_out_password(passwordbuffer, len);
1323
if(not bret){
1324
error(0, errno, "print_out_password");
1325
exitstatus = EX_IOERR;
1326
}
702
1327
}
703
1328
704
end:
705
1329
/* Restore old signal handler */
706
sigaction(SIGCHLD, &old_sigchld_action, NULL);
707
708
free(plus_argv);
709
710
/* Free the plugin list */
711
for(plugin *next; plugin_list != NULL; plugin_list = next){
712
next = plugin_list->next;
713
free(plugin_list->argv);
714
free(plugin_list);
715
}
716
717
if(dir != NULL){
718
closedir(dir);
719
}
720
721
/* Free the process list and kill the processes */
722
for(process *next; process_list != NULL; process_list = next){
723
next = process_list->next;
724
close(process_list->fd);
725
ret = kill(process_list->pid, SIGTERM);
726
if(ret == -1 and errno != ESRCH){
727
/* set-uid proccesses migth not get closed */
728
perror("kill");
729
}
730
free(process_list->buffer);
731
free(process_list);
1330
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1331
if(ret == -1){
1332
error(0, errno, "sigaction");
1333
exitstatus = EX_OSERR;
1334
}
1335
1336
if(custom_argv != NULL){
1337
for(char **arg = custom_argv+1; *arg != NULL; arg++){
1338
free(*arg);
1339
}
1340
free(custom_argv);
1341
}
1342
1343
free(direntries);
1344
1345
if(dir_fd != -1){
1346
close(dir_fd);
1347
}
1348
1349
/* Kill the processes */
1350
for(plugin *p = plugin_list; p != NULL; p = p->next){
1351
if(p->pid != 0){
1352
close(p->fd);
1353
ret = kill(p->pid, SIGTERM);
1354
if(ret == -1 and errno != ESRCH){
1355
/* Set-uid proccesses might not get closed */
1356
error(0, errno, "kill");
1357
}
1358
}
732
1359
}
733
1360
734
1361
/* Wait for any remaining child processes to terminate */
735
do{
1362
do {
736
1363
ret = wait(NULL);
737
1364
} while(ret >= 0);
738
1365
if(errno != ECHILD){
739
perror("wait");
1366
error(0, errno, "wait");
740
1367
}
741
1368
1369
free_plugin_list();
1370
1371
free(plugindir);
1372
free(pluginhelperdir);
1373
free(argfile);
1374
742
1375
return exitstatus;
743
1376
}
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0