1
/* -*- coding: utf-8 -*- */
1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
3
3
* Mandos plugin runner - Run Mandos plugins
5
* Copyright © 2008,2009 Teddy Hogeborn
6
* Copyright © 2008,2009 Björn Påhlsson
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
13
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2020 Teddy Hogeborn
6
* Copyright © 2008-2020 Björn Påhlsson
8
* This file is part of Mandos.
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
15
* Mandos is distributed in the hope that it will be useful, but
14
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
15
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16
18
* General Public License for more details.
18
20
* You should have received a copy of the GNU General Public License
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
23
* Contact the authors at <mandos@recompile.se>.
25
26
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
27
28
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
29
#include <stdlib.h> /* malloc(), reallocarray(), realloc(),
30
EXIT_SUCCESS, exit() */
30
31
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
32
#include <stdio.h> /* fileno(), fprintf(),
33
stderr, STDOUT_FILENO, fclose() */
34
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
35
WIFEXITED(), WEXITSTATUS(), wait(),
36
pid_t, uid_t, gid_t, getuid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
41
WEXITSTATUS(), WTERMSIG() */
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
43
43
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read(),
53
52
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
#include <string.h> /* strsep, strlen(), asprintf() */
53
FD_CLOEXEC, openat(), scandirat(),
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
56
57
#include <errno.h> /* errno */
57
58
#include <argp.h> /* struct argp_option, struct
58
59
argp_state, struct argp,
369
428
.doc = "Group ID the plugins will run as", .group = 3 },
370
429
{ .name = "debug", .key = 132,
371
430
.doc = "Debug mode", .group = 4 },
431
{ .name = "plugin-helper-dir", .key = 133,
433
.doc = "Specify a different plugin helper directory",
436
* These reproduce what we would get without ARGP_NO_HELP
438
{ .name = "help", .key = '?',
439
.doc = "Give this help list", .group = -1 },
440
{ .name = "usage", .key = -3,
441
.doc = "Give a short usage message", .group = -1 },
442
{ .name = "version", .key = 'V',
443
.doc = "Print program version", .group = -1 },
375
error_t parse_opt (int key, char *arg, __attribute__((unused))
376
struct argp_state *state) {
447
__attribute__((nonnull(3)))
448
error_t parse_opt(int key, char *arg, struct argp_state *state){
378
453
case 'g': /* --global-options */
381
while((p = strsep(&arg, ",")) != NULL){
385
if(not add_argument(getplugin(NULL), p)){
386
perror("add_argument");
387
return ARGP_ERR_UNKNOWN;
456
while((plugin_option = strsep(&arg, ",")) != NULL){
457
if(not add_argument(getplugin(NULL), plugin_option)){
392
464
case 'G': /* --global-env */
396
if(not add_environment(getplugin(NULL), arg, true)){
397
perror("add_environment");
465
if(add_environment(getplugin(NULL), arg, true)){
400
469
case 'o': /* --options-for */
402
char *p_name = strsep(&arg, ":");
403
if(p_name[0] == '\0' or arg == NULL){
406
char *opt = strsep(&arg, ":");
407
if(opt[0] == '\0' or opt == NULL){
411
while((p = strsep(&opt, ",")) != NULL){
415
if(not add_argument(getplugin(p_name), p)){
416
perror("add_argument");
417
return ARGP_ERR_UNKNOWN;
471
char *option_list = strchr(arg, ':');
472
if(option_list == NULL){
473
argp_error(state, "No colon in \"%s\"", arg);
480
argp_error(state, "Empty plugin name");
485
while((option = strsep(&option_list, ",")) != NULL){
486
if(not add_argument(getplugin(arg), option)){
422
493
case 'E': /* --env-for */
427
495
char *envdef = strchr(arg, ':');
428
496
if(envdef == NULL){
497
argp_error(state, "No colon in \"%s\"", arg);
432
if(not add_environment(getplugin(arg), envdef+1, true)){
433
perror("add_environment");
504
argp_error(state, "Empty plugin name");
508
if(add_environment(getplugin(arg), envdef, true)){
437
513
case 'd': /* --disable */
439
515
plugin *p = getplugin(arg);
441
return ARGP_ERR_UNKNOWN;
446
522
case 'e': /* --enable */
448
524
plugin *p = getplugin(arg);
450
return ARGP_ERR_UNKNOWN;
455
531
case 128: /* --plugin-dir */
457
533
plugindir = strdup(arg);
458
if(plugindir == NULL){
534
if(plugindir != NULL){
462
538
case 129: /* --config-file */
463
539
/* This is already done by parse_opt_config_file() */
465
541
case 130: /* --userid */
466
/* In the GNU C library, uid_t is always unsigned int */
467
ret = sscanf(arg, "%ud", &uid);
469
fprintf(stderr, "Bad user ID number: \"%s\", using %ud\n",
542
tmp_id = strtoimax(arg, &tmp, 10);
543
if(errno != 0 or tmp == arg or *tmp != '\0'
544
or tmp_id != (uid_t)tmp_id){
545
argp_error(state, "Bad user ID number: \"%s\", using %"
546
PRIdMAX, arg, (intmax_t)uid);
473
552
case 131: /* --groupid */
474
/* In the GNU C library, gid_t is always unsigned int */
475
ret = sscanf(arg, "%ud", &gid);
477
fprintf(stderr, "Bad group ID number: \"%s\", using %ud\n",
553
tmp_id = strtoimax(arg, &tmp, 10);
554
if(errno != 0 or tmp == arg or *tmp != '\0'
555
or tmp_id != (gid_t)tmp_id){
556
argp_error(state, "Bad group ID number: \"%s\", using %"
557
PRIdMAX, arg, (intmax_t)gid);
481
563
case 132: /* --debug */
566
case 133: /* --plugin-helper-dir */
567
free(pluginhelperdir);
568
pluginhelperdir = strdup(arg);
569
if(pluginhelperdir != NULL){
574
* These reproduce what we would get without ARGP_NO_HELP
576
case '?': /* --help */
577
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
578
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
579
__builtin_unreachable();
580
case -3: /* --usage */
581
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
582
argp_state_help(state, state->out_stream,
583
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
584
__builtin_unreachable();
585
case 'V': /* --version */
586
fprintf(state->out_stream, "%s\n", argp_program_version);
485
590
* When adding more options before this line, remember to also add a
486
591
* "case" to the "parse_opt_config_file" function below.
591
712
new_arg = strdup(p);
592
713
if(new_arg == NULL){
594
exitstatus = EXIT_FAILURE;
714
error(0, errno, "strdup");
715
exitstatus = EX_OSERR;
599
720
custom_argc += 1;
600
custom_argv = realloc(custom_argv, sizeof(char *)
601
* ((unsigned int) custom_argc + 1));
602
if(custom_argv == NULL){
604
exitstatus = EXIT_FAILURE;
722
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
723
char **new_argv = reallocarray(custom_argv, (size_t)custom_argc + 1,
726
char **new_argv = NULL;
727
if(((size_t)custom_argc + 1) > (SIZE_MAX / sizeof(char *))){
731
new_argv = realloc(custom_argv, ((size_t)custom_argc + 1)
735
if(new_argv == NULL){
736
error(0, errno, "reallocarray");
737
exitstatus = EX_OSERR;
742
custom_argv = new_argv;
608
745
custom_argv[custom_argc-1] = new_arg;
609
custom_argv[custom_argc] = NULL;
746
custom_argv[custom_argc] = NULL;
750
ret = fclose(conffp);
751
} while(ret == EOF and errno == EINTR);
753
error(0, errno, "fclose");
754
exitstatus = EX_IOERR;
614
759
/* Check for harmful errors and go to fallback. Other errors might
615
760
not affect opening plugins */
616
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
618
exitstatus = EXIT_FAILURE;
761
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
762
error(0, errno, "fopen");
763
exitstatus = EX_OSERR;
622
/* If there was any arguments from configuration file,
623
pass them to parser as command arguments */
767
/* If there were any arguments from the configuration file, pass
768
them to parser as command line arguments */
624
769
if(custom_argv != NULL){
625
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
627
if (ret == ARGP_ERR_UNKNOWN){
628
fprintf(stderr, "Unknown error while parsing arguments\n");
629
exitstatus = EXIT_FAILURE;
770
ret = argp_parse(&argp, custom_argc, custom_argv,
771
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
779
error(0, errno, "argp_parse");
780
exitstatus = EX_OSERR;
783
exitstatus = EX_CONFIG;
634
788
/* Parse actual command line arguments, to let them override the
636
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
637
if (ret == ARGP_ERR_UNKNOWN){
638
fprintf(stderr, "Unknown error while parsing arguments\n");
639
exitstatus = EXIT_FAILURE;
790
ret = argp_parse(&argp, argc, argv,
791
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
799
error(0, errno, "argp_parse");
800
exitstatus = EX_OSERR;
803
exitstatus = EX_USAGE;
808
char *pluginhelperenv;
810
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
811
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
813
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
815
if(ret == -1 or not bret){
816
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
817
" environment variable to \"%s\" for all plugins\n",
818
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
821
free(pluginhelperenv);
644
for(plugin *p = plugin_list; p != NULL; p=p->next){
826
for(plugin *p = plugin_list; p != NULL; p = p->next){
645
827
fprintf(stderr, "Plugin: %s has %d arguments\n",
646
828
p->name ? p->name : "Global", p->argc - 1);
647
829
for(char **a = p->argv; *a != NULL; a++){
648
830
fprintf(stderr, "\tArg: %s\n", *a);
650
fprintf(stderr, "...and %u environment variables\n", p->envc);
832
fprintf(stderr, "...and %d environment variables\n", p->envc);
651
833
for(char **a = p->environ; *a != NULL; a++){
652
834
fprintf(stderr, "\t%s\n", *a);
657
/* Strip permissions down to nobody */
840
/* Work around Debian bug #633582:
841
<https://bugs.debian.org/633582> */
842
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
843
if(plugindir_fd == -1){
845
error(0, errno, "open(\"" PDIR "\")");
848
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
850
error(0, errno, "fstat");
852
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
853
ret = fchown(plugindir_fd, uid, gid);
855
error(0, errno, "fchown");
862
/* Work around Debian bug #981302
863
<https://bugs.debian.org/981302> */
864
if(lstat("/dev/fd", &st) != 0 and errno == ENOENT){
865
ret = symlink("/proc/self/fd", "/dev/fd");
867
error(0, errno, "Failed to create /dev/fd symlink");
872
/* Lower permissions */
875
error(0, errno, "setgid");
658
877
ret = setuid(uid);
667
if (plugindir == NULL){
670
dir = opendir(plugindir);
674
perror("Could not open plugin dir");
675
exitstatus = EXIT_FAILURE;
679
/* Set the FD_CLOEXEC flag on the directory, if possible */
879
error(0, errno, "setuid");
882
/* Open plugin directory with close_on_exec flag */
681
int dir_fd = dirfd(dir);
683
ret = set_cloexec_flag(dir_fd);
685
perror("set_cloexec_flag");
686
exitstatus = EXIT_FAILURE;
884
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
887
#else /* not O_CLOEXEC */
889
#endif /* not O_CLOEXEC */
892
error(0, errno, "Could not open plugin dir");
893
exitstatus = EX_UNAVAILABLE;
898
/* Set the FD_CLOEXEC flag on the directory */
899
ret = set_cloexec_flag(dir_fd);
901
error(0, errno, "set_cloexec_flag");
902
exitstatus = EX_OSERR;
905
#endif /* O_CLOEXEC */
908
int good_name(const struct dirent * const dirent){
909
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
910
"*.dpkg-old", "*.dpkg-bak",
911
"*.dpkg-divert", NULL };
913
#pragma GCC diagnostic push
914
#pragma GCC diagnostic ignored "-Wcast-qual"
916
for(const char **pat = (const char **)patterns;
917
*pat != NULL; pat++){
919
#pragma GCC diagnostic pop
921
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
924
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
925
" matching pattern %s\n", dirent->d_name, *pat);
933
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
935
if(numplugins == -1){
936
error(0, errno, "Could not scan plugin dir");
938
exitstatus = EX_OSERR;
692
942
FD_ZERO(&rfds_all);
694
944
/* Read and execute any executable in the plugin directory*/
696
dirst = readdir(dir);
698
/* All directory entries have been processed */
702
exitstatus = EXIT_FAILURE;
708
d_name_len = strlen(dirst->d_name);
710
/* Ignore dotfiles, backup files and other junk */
712
bool bad_name = false;
714
const char const *bad_prefixes[] = { ".", "#", NULL };
716
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
719
".dpkg-divert", NULL };
720
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
721
size_t pre_len = strlen(*pre);
722
if((d_name_len >= pre_len)
723
and strncmp((dirst->d_name), *pre, pre_len) == 0){
725
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
726
" with bad prefix %s\n", dirst->d_name, *pre);
735
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
736
size_t suf_len = strlen(*suf);
737
if((d_name_len >= suf_len)
738
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
741
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
742
" with bad suffix %s\n", dirst->d_name, *suf);
755
if(plugindir == NULL){
756
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
758
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
765
ret = stat(filename, &st);
945
for(int i = 0; i < numplugins; i++){
947
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
949
error(0, errno, "Could not open plugin");
953
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
955
error(0, errno, "stat");
772
961
/* Ignore non-executable files */
773
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
962
if(not S_ISREG(st.st_mode)
963
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
775
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
776
" with bad type or mode\n", filename);
966
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
967
" with bad type or mode\n",
968
plugindir != NULL ? plugindir : PDIR,
969
direntries[i]->d_name);
782
plugin *p = getplugin(dirst->d_name);
976
plugin *p = getplugin(direntries[i]->d_name);
978
error(0, errno, "getplugin");
790
985
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
986
direntries[i]->d_name);
800
996
for(char **a = g->argv + 1; *a != NULL; a++){
801
997
if(not add_argument(p, *a)){
802
perror("add_argument");
998
error(0, errno, "add_argument");
805
1001
/* Add global environment variables */
806
1002
for(char **e = g->environ; *e != NULL; e++){
807
1003
if(not add_environment(p, *e, false)){
808
perror("add_environment");
1004
error(0, errno, "add_environment");
813
/* If this plugin has any environment variables, we will call
814
using execve and need to duplicate the environment from this
1009
/* If this plugin has any environment variables, we need to
1010
duplicate the environment from this process, too. */
816
1011
if(p->environ[0] != NULL){
817
1012
for(char **e = environ; *e != NULL; e++){
818
1013
if(not add_environment(p, *e, false)){
819
perror("add_environment");
1014
error(0, errno, "add_environment");
828
exitstatus = EXIT_FAILURE;
1021
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1022
#else /* O_CLOEXEC */
1023
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
1024
#endif /* O_CLOEXEC */
1026
error(0, errno, "pipe");
1027
exitstatus = EX_OSERR;
1028
free(direntries[i]);
1031
if(pipefd[0] >= FD_SETSIZE){
1032
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1036
exitstatus = EX_OSERR;
1037
free(direntries[i]);
831
1041
/* Ask OS to automatic close the pipe on exec */
832
1042
ret = set_cloexec_flag(pipefd[0]);
834
perror("set_cloexec_flag");
835
exitstatus = EXIT_FAILURE;
1044
error(0, errno, "set_cloexec_flag");
1047
exitstatus = EX_OSERR;
1048
free(direntries[i]);
838
1051
ret = set_cloexec_flag(pipefd[1]);
840
perror("set_cloexec_flag");
841
exitstatus = EXIT_FAILURE;
1053
error(0, errno, "set_cloexec_flag");
1056
exitstatus = EX_OSERR;
1057
free(direntries[i]);
1060
#endif /* not O_CLOEXEC */
844
1061
/* Block SIGCHLD until process is safely in process list */
845
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1062
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1063
&sigchld_action.sa_mask,
847
perror("sigprocmask");
848
exitstatus = EXIT_FAILURE;
1066
error(0, errno, "sigprocmask");
1067
exitstatus = EX_OSERR;
1068
free(direntries[i]);
851
1071
/* Starting a new process to be watched */
1075
} while(pid == -1 and errno == EINTR);
855
exitstatus = EXIT_FAILURE;
1077
error(0, errno, "fork");
1078
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1079
&sigchld_action.sa_mask, NULL));
1082
exitstatus = EX_OSERR;
1083
free(direntries[i]);
859
1087
/* this is the child process */
860
1088
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1090
error(0, errno, "sigaction");
865
1093
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
867
perror("sigprocmask");
1095
error(0, errno, "sigprocmask");
871
1099
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1101
error(0, errno, "dup2");
878
/* If dir has no file descriptor, we could not set FD_CLOEXEC
879
above and must now close it manually here. */
882
if(p->environ[0] == NULL){
883
if(execv(filename, p->argv) < 0){
888
if(execve(filename, p->argv, p->environ) < 0){
1105
if(fexecve(plugin_fd, p->argv,
1106
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1107
error(0, errno, "fexecve for %s/%s",
1108
plugindir != NULL ? plugindir : PDIR,
1109
direntries[i]->d_name);
895
1114
/* Parent process */
896
1115
close(pipefd[1]); /* Close unused write end of pipe */
898
plugin *new_plugin = getplugin(dirst->d_name);
899
if (new_plugin == NULL){
901
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1117
plugin *new_plugin = getplugin(direntries[i]->d_name);
1118
if(new_plugin == NULL){
1119
error(0, errno, "getplugin");
1120
ret = (int)(TEMP_FAILURE_RETRY
1121
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
903
perror("sigprocmask");
1124
error(0, errno, "sigprocmask");
905
exitstatus = EXIT_FAILURE;
1126
exitstatus = EX_OSERR;
1127
free(direntries[i]);
1130
free(direntries[i]);
909
1132
new_plugin->pid = pid;
910
1133
new_plugin->fd = pipefd[0];
1136
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1137
new_plugin->name, (intmax_t) (new_plugin->pid));
912
1140
/* Unblock SIGCHLD so signal handler can be run if this process
913
1141
has already completed */
914
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1142
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1143
&sigchld_action.sa_mask,
916
perror("sigprocmask");
917
exitstatus = EXIT_FAILURE;
1146
error(0, errno, "sigprocmask");
1147
exitstatus = EX_OSERR;
921
1151
FD_SET(new_plugin->fd, &rfds_all);
923
if (maxfd < new_plugin->fd){
1153
if(maxfd < new_plugin->fd){
924
1154
maxfd = new_plugin->fd;
1162
free_plugin(getplugin(NULL));
931
1164
for(plugin *p = plugin_list; p != NULL; p = p->next){
932
1165
if(p->pid != 0){
943
1176
while(plugin_list){
944
1177
fd_set rfds = rfds_all;
945
1178
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
946
if (select_ret == -1){
948
exitstatus = EXIT_FAILURE;
1179
if(select_ret == -1 and errno != EINTR){
1180
error(0, errno, "select");
1181
exitstatus = EX_OSERR;
951
1184
/* OK, now either a process completed, or something can be read
952
1185
from one of them */
953
1186
for(plugin *proc = plugin_list; proc != NULL;){
954
1187
/* Is this process completely done? */
955
if(proc->eof and proc->completed){
1188
if(proc->completed and proc->eof){
956
1189
/* Only accept the plugin output if it exited cleanly */
957
1190
if(not WIFEXITED(proc->status)
958
1191
or WEXITSTATUS(proc->status) != 0){
959
1192
/* Bad exit by plugin */
962
1195
if(WIFEXITED(proc->status)){
963
fprintf(stderr, "Plugin %u exited with status %d\n",
964
(unsigned int) (proc->pid),
1196
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1197
" status %d\n", proc->name,
1198
(intmax_t) (proc->pid),
965
1199
WEXITSTATUS(proc->status));
966
} else if(WIFSIGNALED(proc->status)) {
967
fprintf(stderr, "Plugin %u killed by signal %d\n",
968
(unsigned int) (proc->pid),
969
WTERMSIG(proc->status));
970
} else if(WCOREDUMP(proc->status)){
971
fprintf(stderr, "Plugin %d dumped core\n",
972
(unsigned int) (proc->pid));
1200
} else if(WIFSIGNALED(proc->status)){
1201
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1202
" signal %d: %s\n", proc->name,
1203
(intmax_t) (proc->pid),
1204
WTERMSIG(proc->status),
1205
strsignal(WTERMSIG(proc->status)));
976
1209
/* Remove the plugin */
977
1210
FD_CLR(proc->fd, &rfds_all);
979
1212
/* Block signal while modifying process_list */
980
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1213
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1215
&sigchld_action.sa_mask,
982
perror("sigprocmask");
983
exitstatus = EXIT_FAILURE;
1218
error(0, errno, "sigprocmask");
1219
exitstatus = EX_OSERR;