1
/* -*- coding: utf-8 -*- */
1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
3
3
* Mandos plugin runner - Run Mandos plugins
5
* Copyright © 2008,2009 Teddy Hogeborn
6
* Copyright © 2008,2009 Björn Påhlsson
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
13
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2018 Teddy Hogeborn
6
* Copyright © 2008-2018 Björn Påhlsson
8
* This file is part of Mandos.
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
15
* Mandos is distributed in the hope that it will be useful, but
14
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
15
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16
18
* General Public License for more details.
18
20
* You should have received a copy of the GNU General Public License
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
23
* Contact the authors at <mandos@recompile.se>.
25
26
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
27
28
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
29
#include <stdlib.h> /* malloc(), reallocarray(), realloc(),
30
EXIT_SUCCESS, exit() */
30
31
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
32
#include <stdio.h> /* fileno(), fprintf(),
33
stderr, STDOUT_FILENO, fclose() */
34
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
35
WIFEXITED(), WEXITSTATUS(), wait(),
36
pid_t, uid_t, gid_t, getuid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
41
WEXITSTATUS(), WTERMSIG() */
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
43
43
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
53
52
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
#include <string.h> /* strsep, strlen(), asprintf() */
53
FD_CLOEXEC, openat(), scandirat(),
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
56
57
#include <errno.h> /* errno */
57
58
#include <argp.h> /* struct argp_option, struct
58
59
argp_state, struct argp,
62
63
#include <signal.h> /* struct sigaction, sigemptyset(),
63
64
sigaddset(), sigaction(),
64
65
sigprocmask(), SIG_BLOCK, SIGCHLD,
65
SIG_UNBLOCK, kill() */
66
SIG_UNBLOCK, kill(), sig_atomic_t
66
68
#include <errno.h> /* errno, EBADF */
67
#include <inttypes.h> /* intmax_t, SCNdMAX, PRIdMAX, */
69
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
70
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
71
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
72
#include <errno.h> /* errno */
73
#include <error.h> /* error() */
74
#include <fnmatch.h> /* fnmatch() */
69
76
#define BUFFER_SIZE 256
71
78
#define PDIR "/lib/mandos/plugins.d"
79
#define PHDIR "/lib/mandos/plugin-helpers"
72
80
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
74
82
const char *argp_program_version = "plugin-runner " VERSION;
75
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
83
const char *argp_program_bug_address = "<mandos@recompile.se>";
77
85
typedef struct plugin{
78
86
char *name; /* can be NULL or any plugin name */
109
118
/* Create a new plugin */
110
plugin *new_plugin = malloc(sizeof(plugin));
119
plugin *new_plugin = NULL;
121
new_plugin = malloc(sizeof(plugin));
122
} while(new_plugin == NULL and errno == EINTR);
111
123
if(new_plugin == NULL){
114
126
char *copy_name = NULL;
115
127
if(name != NULL){
116
copy_name = strdup(name);
129
copy_name = strdup(name);
130
} while(copy_name == NULL and errno == EINTR);
117
131
if(copy_name == NULL){
118
133
free(new_plugin);
123
*new_plugin = (plugin) { .name = copy_name,
126
.next = plugin_list };
139
*new_plugin = (plugin){ .name = copy_name,
142
.next = plugin_list };
128
new_plugin->argv = malloc(sizeof(char *) * 2);
145
new_plugin->argv = malloc(sizeof(char *) * 2);
146
} while(new_plugin->argv == NULL and errno == EINTR);
129
147
if(new_plugin->argv == NULL){
131
150
free(new_plugin);
134
154
new_plugin->argv[0] = copy_name;
135
155
new_plugin->argv[1] = NULL;
137
new_plugin->environ = malloc(sizeof(char *));
158
new_plugin->environ = malloc(sizeof(char *));
159
} while(new_plugin->environ == NULL and errno == EINTR);
138
160
if(new_plugin->environ == NULL){
140
163
free(new_plugin->argv);
141
164
free(new_plugin);
144
168
new_plugin->environ[0] = NULL;
204
252
return add_to_char_array(def, &(p->environ), &(p->envc));
208
257
* Based on the example in the GNU LibC manual chapter 13.13 "File
209
258
* Descriptor Flags".
210
* *Note File Descriptor Flags:(libc)Descriptor Flags.
259
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
261
__attribute__((warn_unused_result))
212
262
static int set_cloexec_flag(int fd){
213
int ret = fcntl(fd, F_GETFD, 0);
263
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
214
264
/* If reading the flags failed, return error indication now. */
218
268
/* Store modified flag word in the descriptor. */
219
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
269
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
272
#endif /* not O_CLOEXEC */
223
275
/* Mark processes as completed when they exit, and save their exit
225
277
static void handle_sigchld(__attribute__((unused)) int sig){
278
int old_errno = errno;
227
280
plugin *proc = plugin_list;
372
428
.doc = "Group ID the plugins will run as", .group = 3 },
373
429
{ .name = "debug", .key = 132,
374
430
.doc = "Debug mode", .group = 4 },
431
{ .name = "plugin-helper-dir", .key = 133,
433
.doc = "Specify a different plugin helper directory",
436
* These reproduce what we would get without ARGP_NO_HELP
438
{ .name = "help", .key = '?',
439
.doc = "Give this help list", .group = -1 },
440
{ .name = "usage", .key = -3,
441
.doc = "Give a short usage message", .group = -1 },
442
{ .name = "version", .key = 'V',
443
.doc = "Print program version", .group = -1 },
378
error_t parse_opt(int key, char *arg, __attribute__((unused))
379
struct argp_state *state) {
447
__attribute__((nonnull(3)))
448
error_t parse_opt(int key, char *arg, struct argp_state *state){
381
453
case 'g': /* --global-options */
384
while((p = strsep(&arg, ",")) != NULL){
388
if(not add_argument(getplugin(NULL), p)){
389
perror("add_argument");
390
return ARGP_ERR_UNKNOWN;
456
while((plugin_option = strsep(&arg, ",")) != NULL){
457
if(not add_argument(getplugin(NULL), plugin_option)){
395
464
case 'G': /* --global-env */
399
if(not add_environment(getplugin(NULL), arg, true)){
400
perror("add_environment");
465
if(add_environment(getplugin(NULL), arg, true)){
403
469
case 'o': /* --options-for */
405
char *p_name = strsep(&arg, ":");
406
if(p_name[0] == '\0' or arg == NULL){
409
char *opt = strsep(&arg, ":");
410
if(opt[0] == '\0' or opt == NULL){
414
while((p = strsep(&opt, ",")) != NULL){
418
if(not add_argument(getplugin(p_name), p)){
419
perror("add_argument");
420
return ARGP_ERR_UNKNOWN;
471
char *option_list = strchr(arg, ':');
472
if(option_list == NULL){
473
argp_error(state, "No colon in \"%s\"", arg);
480
argp_error(state, "Empty plugin name");
485
while((option = strsep(&option_list, ",")) != NULL){
486
if(not add_argument(getplugin(arg), option)){
425
493
case 'E': /* --env-for */
430
495
char *envdef = strchr(arg, ':');
431
496
if(envdef == NULL){
497
argp_error(state, "No colon in \"%s\"", arg);
435
if(not add_environment(getplugin(arg), envdef+1, true)){
436
perror("add_environment");
504
argp_error(state, "Empty plugin name");
508
if(add_environment(getplugin(arg), envdef, true)){
440
513
case 'd': /* --disable */
442
515
plugin *p = getplugin(arg);
444
return ARGP_ERR_UNKNOWN;
449
522
case 'e': /* --enable */
451
524
plugin *p = getplugin(arg);
453
return ARGP_ERR_UNKNOWN;
458
531
case 128: /* --plugin-dir */
460
533
plugindir = strdup(arg);
461
if(plugindir == NULL){
534
if(plugindir != NULL){
465
538
case 129: /* --config-file */
466
539
/* This is already done by parse_opt_config_file() */
468
541
case 130: /* --userid */
469
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
470
if(ret < 1 or tmpmax != (uid_t)tmpmax
471
or arg[numchars] != '\0'){
472
fprintf(stderr, "Bad user ID number: \"%s\", using %"
473
PRIdMAX "\n", arg, (intmax_t)uid);
542
tmp_id = strtoimax(arg, &tmp, 10);
543
if(errno != 0 or tmp == arg or *tmp != '\0'
544
or tmp_id != (uid_t)tmp_id){
545
argp_error(state, "Bad user ID number: \"%s\", using %"
546
PRIdMAX, arg, (intmax_t)uid);
478
552
case 131: /* --groupid */
479
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
480
if(ret < 1 or tmpmax != (gid_t)tmpmax
481
or arg[numchars] != '\0'){
482
fprintf(stderr, "Bad group ID number: \"%s\", using %"
483
PRIdMAX "\n", arg, (intmax_t)gid);
553
tmp_id = strtoimax(arg, &tmp, 10);
554
if(errno != 0 or tmp == arg or *tmp != '\0'
555
or tmp_id != (gid_t)tmp_id){
556
argp_error(state, "Bad group ID number: \"%s\", using %"
557
PRIdMAX, arg, (intmax_t)gid);
488
563
case 132: /* --debug */
566
case 133: /* --plugin-helper-dir */
567
free(pluginhelperdir);
568
pluginhelperdir = strdup(arg);
569
if(pluginhelperdir != NULL){
574
* These reproduce what we would get without ARGP_NO_HELP
576
case '?': /* --help */
577
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
578
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
579
__builtin_unreachable();
580
case -3: /* --usage */
581
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
582
argp_state_help(state, state->out_stream,
583
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
584
__builtin_unreachable();
585
case 'V': /* --version */
586
fprintf(state->out_stream, "%s\n", argp_program_version);
492
590
* When adding more options before this line, remember to also add a
493
591
* "case" to the "parse_opt_config_file" function below.
598
712
new_arg = strdup(p);
599
713
if(new_arg == NULL){
601
exitstatus = EXIT_FAILURE;
714
error(0, errno, "strdup");
715
exitstatus = EX_OSERR;
606
720
custom_argc += 1;
607
custom_argv = realloc(custom_argv, sizeof(char *)
608
* ((unsigned int) custom_argc + 1));
609
if(custom_argv == NULL){
611
exitstatus = EXIT_FAILURE;
722
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
723
char **new_argv = reallocarray(custom_argv, (size_t)custom_argc + 1,
726
char **new_argv = NULL;
727
if(((size_t)custom_argc + 1) > (SIZE_MAX / sizeof(char *))){
731
new_argv = realloc(custom_argv, ((size_t)custom_argc + 1)
735
if(new_argv == NULL){
736
error(0, errno, "reallocarray");
737
exitstatus = EX_OSERR;
742
custom_argv = new_argv;
615
745
custom_argv[custom_argc-1] = new_arg;
616
custom_argv[custom_argc] = NULL;
746
custom_argv[custom_argc] = NULL;
750
ret = fclose(conffp);
751
} while(ret == EOF and errno == EINTR);
753
error(0, errno, "fclose");
754
exitstatus = EX_IOERR;
621
759
/* Check for harmful errors and go to fallback. Other errors might
622
760
not affect opening plugins */
623
761
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
625
exitstatus = EXIT_FAILURE;
762
error(0, errno, "fopen");
763
exitstatus = EX_OSERR;
629
/* If there was any arguments from configuration file,
630
pass them to parser as command arguments */
767
/* If there were any arguments from the configuration file, pass
768
them to parser as command line arguments */
631
769
if(custom_argv != NULL){
632
ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
634
if(ret == ARGP_ERR_UNKNOWN){
635
fprintf(stderr, "Unknown error while parsing arguments\n");
636
exitstatus = EXIT_FAILURE;
770
ret = argp_parse(&argp, custom_argc, custom_argv,
771
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
779
error(0, errno, "argp_parse");
780
exitstatus = EX_OSERR;
783
exitstatus = EX_CONFIG;
641
788
/* Parse actual command line arguments, to let them override the
643
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
644
if(ret == ARGP_ERR_UNKNOWN){
645
fprintf(stderr, "Unknown error while parsing arguments\n");
646
exitstatus = EXIT_FAILURE;
790
ret = argp_parse(&argp, argc, argv,
791
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
799
error(0, errno, "argp_parse");
800
exitstatus = EX_OSERR;
803
exitstatus = EX_USAGE;
808
char *pluginhelperenv;
810
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
811
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
813
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
815
if(ret == -1 or not bret){
816
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
817
" environment variable to \"%s\" for all plugins\n",
818
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
821
free(pluginhelperenv);
651
for(plugin *p = plugin_list; p != NULL; p=p->next){
826
for(plugin *p = plugin_list; p != NULL; p = p->next){
652
827
fprintf(stderr, "Plugin: %s has %d arguments\n",
653
828
p->name ? p->name : "Global", p->argc - 1);
654
829
for(char **a = p->argv; *a != NULL; a++){
664
/* Strip permissions down to nobody */
840
/* Work around Debian bug #633582:
841
<https://bugs.debian.org/633582> */
842
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
843
if(plugindir_fd == -1){
845
error(0, errno, "open(\"" PDIR "\")");
848
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
850
error(0, errno, "fstat");
852
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
853
ret = fchown(plugindir_fd, uid, gid);
855
error(0, errno, "fchown");
863
/* Lower permissions */
866
error(0, errno, "setgid");
665
868
ret = setuid(uid);
674
if(plugindir == NULL){
677
dir = opendir(plugindir);
681
perror("Could not open plugin dir");
682
exitstatus = EXIT_FAILURE;
686
/* Set the FD_CLOEXEC flag on the directory, if possible */
870
error(0, errno, "setuid");
873
/* Open plugin directory with close_on_exec flag */
688
int dir_fd = dirfd(dir);
690
ret = set_cloexec_flag(dir_fd);
692
perror("set_cloexec_flag");
693
exitstatus = EXIT_FAILURE;
875
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
878
#else /* not O_CLOEXEC */
880
#endif /* not O_CLOEXEC */
883
error(0, errno, "Could not open plugin dir");
884
exitstatus = EX_UNAVAILABLE;
889
/* Set the FD_CLOEXEC flag on the directory */
890
ret = set_cloexec_flag(dir_fd);
892
error(0, errno, "set_cloexec_flag");
893
exitstatus = EX_OSERR;
896
#endif /* O_CLOEXEC */
899
int good_name(const struct dirent * const dirent){
900
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
901
"*.dpkg-old", "*.dpkg-bak",
902
"*.dpkg-divert", NULL };
904
#pragma GCC diagnostic push
905
#pragma GCC diagnostic ignored "-Wcast-qual"
907
for(const char **pat = (const char **)patterns;
908
*pat != NULL; pat++){
910
#pragma GCC diagnostic pop
912
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
915
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
916
" matching pattern %s\n", dirent->d_name, *pat);
924
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
926
if(numplugins == -1){
927
error(0, errno, "Could not scan plugin dir");
929
exitstatus = EX_OSERR;
699
933
FD_ZERO(&rfds_all);
701
935
/* Read and execute any executable in the plugin directory*/
703
dirst = readdir(dir);
705
/* All directory entries have been processed */
709
exitstatus = EXIT_FAILURE;
715
d_name_len = strlen(dirst->d_name);
717
/* Ignore dotfiles, backup files and other junk */
719
bool bad_name = false;
721
const char const *bad_prefixes[] = { ".", "#", NULL };
723
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
726
".dpkg-divert", NULL };
727
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
728
size_t pre_len = strlen(*pre);
729
if((d_name_len >= pre_len)
730
and strncmp((dirst->d_name), *pre, pre_len) == 0){
732
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
733
" with bad prefix %s\n", dirst->d_name, *pre);
742
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
743
size_t suf_len = strlen(*suf);
744
if((d_name_len >= suf_len)
745
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
748
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
749
" with bad suffix %s\n", dirst->d_name, *suf);
762
if(plugindir == NULL){
763
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
765
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
936
for(int i = 0; i < numplugins; i++){
938
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
940
error(0, errno, "Could not open plugin");
772
ret = stat(filename, &st);
944
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
946
error(0, errno, "stat");
779
952
/* Ignore non-executable files */
780
if(not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
953
if(not S_ISREG(st.st_mode)
954
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
782
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
783
" with bad type or mode\n", filename);
957
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
958
" with bad type or mode\n",
959
plugindir != NULL ? plugindir : PDIR,
960
direntries[i]->d_name);
789
plugin *p = getplugin(dirst->d_name);
967
plugin *p = getplugin(direntries[i]->d_name);
969
error(0, errno, "getplugin");
797
976
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
977
direntries[i]->d_name);
807
987
for(char **a = g->argv + 1; *a != NULL; a++){
808
988
if(not add_argument(p, *a)){
809
perror("add_argument");
989
error(0, errno, "add_argument");
812
992
/* Add global environment variables */
813
993
for(char **e = g->environ; *e != NULL; e++){
814
994
if(not add_environment(p, *e, false)){
815
perror("add_environment");
995
error(0, errno, "add_environment");
820
/* If this plugin has any environment variables, we will call
821
using execve and need to duplicate the environment from this
1000
/* If this plugin has any environment variables, we need to
1001
duplicate the environment from this process, too. */
823
1002
if(p->environ[0] != NULL){
824
1003
for(char **e = environ; *e != NULL; e++){
825
1004
if(not add_environment(p, *e, false)){
826
perror("add_environment");
1005
error(0, errno, "add_environment");
1012
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1013
#else /* O_CLOEXEC */
1014
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
1015
#endif /* O_CLOEXEC */
835
exitstatus = EXIT_FAILURE;
1017
error(0, errno, "pipe");
1018
exitstatus = EX_OSERR;
1019
free(direntries[i]);
1022
if(pipefd[0] >= FD_SETSIZE){
1023
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1027
exitstatus = EX_OSERR;
1028
free(direntries[i]);
838
1032
/* Ask OS to automatic close the pipe on exec */
839
1033
ret = set_cloexec_flag(pipefd[0]);
841
perror("set_cloexec_flag");
842
exitstatus = EXIT_FAILURE;
1035
error(0, errno, "set_cloexec_flag");
1038
exitstatus = EX_OSERR;
1039
free(direntries[i]);
845
1042
ret = set_cloexec_flag(pipefd[1]);
847
perror("set_cloexec_flag");
848
exitstatus = EXIT_FAILURE;
1044
error(0, errno, "set_cloexec_flag");
1047
exitstatus = EX_OSERR;
1048
free(direntries[i]);
1051
#endif /* not O_CLOEXEC */
851
1052
/* Block SIGCHLD until process is safely in process list */
852
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1053
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1054
&sigchld_action.sa_mask,
854
perror("sigprocmask");
855
exitstatus = EXIT_FAILURE;
1057
error(0, errno, "sigprocmask");
1058
exitstatus = EX_OSERR;
1059
free(direntries[i]);
858
1062
/* Starting a new process to be watched */
1066
} while(pid == -1 and errno == EINTR);
862
exitstatus = EXIT_FAILURE;
1068
error(0, errno, "fork");
1069
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1070
&sigchld_action.sa_mask, NULL));
1073
exitstatus = EX_OSERR;
1074
free(direntries[i]);
866
1078
/* this is the child process */
867
1079
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1081
error(0, errno, "sigaction");
872
1084
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
874
perror("sigprocmask");
1086
error(0, errno, "sigprocmask");
878
1090
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1092
error(0, errno, "dup2");
885
/* If dir has no file descriptor, we could not set FD_CLOEXEC
886
above and must now close it manually here. */
889
if(p->environ[0] == NULL){
890
if(execv(filename, p->argv) < 0){
895
if(execve(filename, p->argv, p->environ) < 0){
1096
if(fexecve(plugin_fd, p->argv,
1097
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1098
error(0, errno, "fexecve for %s/%s",
1099
plugindir != NULL ? plugindir : PDIR,
1100
direntries[i]->d_name);
902
1105
/* Parent process */
903
1106
close(pipefd[1]); /* Close unused write end of pipe */
905
plugin *new_plugin = getplugin(dirst->d_name);
1108
plugin *new_plugin = getplugin(direntries[i]->d_name);
906
1109
if(new_plugin == NULL){
908
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1110
error(0, errno, "getplugin");
1111
ret = (int)(TEMP_FAILURE_RETRY
1112
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
910
perror("sigprocmask");
1115
error(0, errno, "sigprocmask");
912
exitstatus = EXIT_FAILURE;
1117
exitstatus = EX_OSERR;
1118
free(direntries[i]);
1121
free(direntries[i]);
916
1123
new_plugin->pid = pid;
917
1124
new_plugin->fd = pipefd[0];
1127
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1128
new_plugin->name, (intmax_t) (new_plugin->pid));
919
1131
/* Unblock SIGCHLD so signal handler can be run if this process
920
1132
has already completed */
921
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1133
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1134
&sigchld_action.sa_mask,
923
perror("sigprocmask");
924
exitstatus = EXIT_FAILURE;
1137
error(0, errno, "sigprocmask");
1138
exitstatus = EX_OSERR;
950
1167
while(plugin_list){
951
1168
fd_set rfds = rfds_all;
952
1169
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
953
if(select_ret == -1){
955
exitstatus = EXIT_FAILURE;
1170
if(select_ret == -1 and errno != EINTR){
1171
error(0, errno, "select");
1172
exitstatus = EX_OSERR;
958
1175
/* OK, now either a process completed, or something can be read
959
1176
from one of them */
960
1177
for(plugin *proc = plugin_list; proc != NULL;){
961
1178
/* Is this process completely done? */
962
if(proc->eof and proc->completed){
1179
if(proc->completed and proc->eof){
963
1180
/* Only accept the plugin output if it exited cleanly */
964
1181
if(not WIFEXITED(proc->status)
965
1182
or WEXITSTATUS(proc->status) != 0){
966
1183
/* Bad exit by plugin */
969
1186
if(WIFEXITED(proc->status)){
970
fprintf(stderr, "Plugin %" PRIdMAX " exited with status"
971
" %d\n", (intmax_t) (proc->pid),
1187
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1188
" status %d\n", proc->name,
1189
(intmax_t) (proc->pid),
972
1190
WEXITSTATUS(proc->status));
973
} else if(WIFSIGNALED(proc->status)) {
974
fprintf(stderr, "Plugin %" PRIdMAX " killed by signal"
975
" %d\n", (intmax_t) (proc->pid),
976
WTERMSIG(proc->status));
977
} else if(WCOREDUMP(proc->status)){
978
fprintf(stderr, "Plugin %" PRIdMAX " dumped core\n",
979
(intmax_t) (proc->pid));
1191
} else if(WIFSIGNALED(proc->status)){
1192
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1193
" signal %d: %s\n", proc->name,
1194
(intmax_t) (proc->pid),
1195
WTERMSIG(proc->status),
1196
strsignal(WTERMSIG(proc->status)));
983
1200
/* Remove the plugin */
984
1201
FD_CLR(proc->fd, &rfds_all);
986
1203
/* Block signal while modifying process_list */
987
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1204
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1206
&sigchld_action.sa_mask,
989
perror("sigprocmask");
990
exitstatus = EXIT_FAILURE;
1209
error(0, errno, "sigprocmask");
1210
exitstatus = EX_OSERR;