To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 1213
- compare with another revision
- download diff
- download tarball
- view history from revision 1213
- Committer: teddy at recompile
- Date: 2020-04-05 21:30:59 UTC
- Revision ID: teddy@recompile.se-20200405213059-fb2a61ckqynrmatk
Fix file descriptor leak in mandos-client
When the local network has Mandos servers announcing themselves using
real, globally reachable, IPv6 addresses (i.e. not link-local
addresses), but there is no router on the local network providing IPv6
RA (Router Advertisement) packets, the client cannot reach the server
by normal means, since the client only has a link-local IPv6 address,
and has no usable route to reach the server's global IPv6 address.
(This is not a common situation, and usually only happens when the
router itself reboots and runs a Mandos client, since it cannot then
give RA packets to itself.) The client code has a solution for
this, which consists of adding a temporary local route to reach the
address of the server during communication, and removing this
temporary route afterwards.
This solution with a temporary route works, but has a file descriptor
leak; it leaks one file descriptor for each addition and for each
removal of a route. If one server requiring an added route is present
on the network, but no servers gives a password, making the client
retry after the default ten seconds, and we furthermore assume a
default 1024 open files limit, the client runs out of file descriptors
after about 90 minutes, after which time the client process will be
useless and fail to retrieve any passwords, necessitating manual
password entry via the keyboard.
Fix this by eliminating the file descriptor leak in the client.
* plugins.d/mandos-client.c (add_delete_local_route): Do
close(devnull) also in parent process, also if fork() fails, and on
any failure in child process.
When the local network has Mandos servers announcing themselves using
real, globally reachable, IPv6 addresses (i.e. not link-local
addresses), but there is no router on the local network providing IPv6
RA (Router Advertisement) packets, the client cannot reach the server
by normal means, since the client only has a link-local IPv6 address,
and has no usable route to reach the server's global IPv6 address.
(This is not a common situation, and usually only happens when the
router itself reboots and runs a Mandos client, since it cannot then
give RA packets to itself.) The client code has a solution for
this, which consists of adding a temporary local route to reach the
address of the server during communication, and removing this
temporary route afterwards.
This solution with a temporary route works, but has a file descriptor
leak; it leaks one file descriptor for each addition and for each
removal of a route. If one server requiring an added route is present
on the network, but no servers gives a password, making the client
retry after the default ten seconds, and we furthermore assume a
default 1024 open files limit, the client runs out of file descriptors
after about 90 minutes, after which time the client process will be
useless and fail to retrieve any passwords, necessitating manual
password entry via the keyboard.
Fix this by eliminating the file descriptor leak in the client.
* plugins.d/mandos-client.c (add_delete_local_route): Do
close(devnull) also in parent process, also if fork() fails, and on
any failure in child process.
- files added:
- .bzr-builddeb
- debian
- debian/po
- debian/source
- debian/tests
- debian/upstream
- dracut-module
- network-hooks.d
- plugin-helpers
- files removed:
- initramfs-tools-hook-conf
- files renamed:
- mandos-client.c => plugin-runner.c
- mandos-client.xml => plugin-runner.xml
- plugins.d/password-request.c => plugins.d/mandos-client.c
- plugins.d/password-request.xml => plugins.d/mandos-client.xml
- files modified:
- Makefile
added
removed
plugin-runner.c
1
/* -*- coding: utf-8 -*- */
1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2007-2008 Teddy Hogeborn & Björn Påhlsson
6
*
7
* This program is free software: you can redistribute it and/or
8
* modify it under the terms of the GNU General Public License as
9
* published by the Free Software Foundation, either version 3 of the
10
* License, or (at your option) any later version.
11
*
12
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2018 Teddy Hogeborn
6
* Copyright © 2008-2018 Björn Påhlsson
7
*
8
* This file is part of Mandos.
9
*
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
14
*
15
* Mandos is distributed in the hope that it will be useful, but
13
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
14
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15
18
* General Public License for more details.
16
19
*
17
20
* You should have received a copy of the GNU General Public License
18
* along with this program. If not, see
19
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
20
22
*
21
* Contact the authors at <mandos@fukt.bsnet.se>.
23
* Contact the authors at <mandos@recompile.se>.
22
24
*/
23
25
24
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY() */
25
26
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
27
O_CLOEXEC, pipe2() */
26
28
#include <stddef.h> /* size_t, NULL */
27
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
28
EXIT_SUCCESS, realloc() */
29
#include <stdlib.h> /* malloc(), reallocarray(), realloc(),
30
EXIT_SUCCESS, exit() */
29
31
#include <stdbool.h> /* bool, true, false */
30
#include <stdio.h> /* perror, popen(), fileno(),
31
fprintf(), stderr, STDOUT_FILENO */
32
#include <sys/types.h> /* DIR, opendir(), stat(), struct
33
stat, waitpid(), WIFEXITED(),
34
WEXITSTATUS(), wait(), pid_t,
35
uid_t, gid_t, getuid(), getgid(),
36
dirfd() */
32
#include <stdio.h> /* fileno(), fprintf(),
33
stderr, STDOUT_FILENO, fclose() */
34
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
35
WIFEXITED(), WEXITSTATUS(), wait(),
36
pid_t, uid_t, gid_t, getuid(),
37
getgid() */
37
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
38
39
FD_SET(), FD_ISSET(), FD_CLR */
39
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
40
WEXITSTATUS() */
41
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
41
WEXITSTATUS(), WTERMSIG() */
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
42
43
#include <iso646.h> /* and, or, not */
43
#include <dirent.h> /* DIR, struct dirent, opendir(),
44
readdir(), closedir(), dirfd() */
45
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
46
fcntl(), setuid(), setgid(),
47
F_GETFD, F_SETFD, FD_CLOEXEC,
48
access(), pipe(), fork(), close()
49
dup2, STDOUT_FILENO, _exit(),
50
execv(), write(), read(),
51
close() */
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
51
*/
52
52
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
53
FD_CLOEXEC */
54
#include <string.h> /* strsep, strlen(), strcpy(),
55
strcat() */
53
FD_CLOEXEC, openat(), scandirat(),
54
pipe2() */
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
56
57
#include <errno.h> /* errno */
57
58
#include <argp.h> /* struct argp_option, struct
58
59
argp_state, struct argp,
59
60
argp_parse(), ARGP_ERR_UNKNOWN,
60
ARGP_KEY_END, ARGP_KEY_ARG, error_t */
61
ARGP_KEY_END, ARGP_KEY_ARG,
62
error_t */
61
63
#include <signal.h> /* struct sigaction, sigemptyset(),
62
64
sigaddset(), sigaction(),
63
65
sigprocmask(), SIG_BLOCK, SIGCHLD,
64
SIG_UNBLOCK, kill() */
66
SIG_UNBLOCK, kill(), sig_atomic_t
67
*/
65
68
#include <errno.h> /* errno, EBADF */
69
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
70
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
71
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
72
#include <errno.h> /* errno */
73
#include <error.h> /* error() */
74
#include <fnmatch.h> /* fnmatch() */
66
75
67
76
#define BUFFER_SIZE 256
68
#define CONFFILE "/conf/conf.d/mandos/client.conf"
69
70
const char *argp_program_version = "mandos-client 1.0";
71
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
72
73
struct process;
74
75
typedef struct process{
77
78
#define PDIR "/lib/mandos/plugins.d"
79
#define PHDIR "/lib/mandos/plugin-helpers"
80
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
81
82
const char *argp_program_version = "plugin-runner " VERSION;
83
const char *argp_program_bug_address = "<mandos@recompile.se>";
84
85
typedef struct plugin{
86
char *name; /* can be NULL or any plugin name */
87
char **argv;
88
int argc;
89
char **environ;
90
int envc;
91
bool disabled;
92
93
/* Variables used for running processes*/
76
94
pid_t pid;
77
95
int fd;
78
96
char *buffer;
79
97
size_t buffer_size;
80
98
size_t buffer_length;
81
99
bool eof;
82
bool completed;
100
volatile sig_atomic_t completed;
83
101
int status;
84
struct process *next;
85
} process;
86
87
typedef struct plugin{
88
char *name; /* can be NULL or any plugin name */
89
char **argv;
90
int argc;
91
bool disabled;
92
102
struct plugin *next;
93
103
} plugin;
94
104
95
static plugin *getplugin(char *name, plugin **plugin_list){
96
for (plugin *p = *plugin_list; p != NULL; p = p->next){
97
if ((p->name == name)
98
or (p->name and name and (strcmp(p->name, name) == 0))){
105
static plugin *plugin_list = NULL;
106
107
/* Gets an existing plugin based on name,
108
or if none is found, creates a new one */
109
__attribute__((warn_unused_result))
110
static plugin *getplugin(char *name){
111
/* Check for existing plugin with that name */
112
for(plugin *p = plugin_list; p != NULL; p = p->next){
113
if((p->name == name)
114
or (p->name and name and (strcmp(p->name, name) == 0))){
99
115
return p;
100
116
}
101
117
}
102
118
/* Create a new plugin */
103
plugin *new_plugin = malloc(sizeof(plugin));
104
if (new_plugin == NULL){
105
perror("malloc");
106
exit(EXIT_FAILURE);
107
}
108
new_plugin->name = name;
109
new_plugin->argv = malloc(sizeof(char *) * 2);
110
if (new_plugin->argv == NULL){
111
perror("malloc");
112
exit(EXIT_FAILURE);
113
}
114
new_plugin->argv[0] = name;
119
plugin *new_plugin = NULL;
120
do {
121
new_plugin = malloc(sizeof(plugin));
122
} while(new_plugin == NULL and errno == EINTR);
123
if(new_plugin == NULL){
124
return NULL;
125
}
126
char *copy_name = NULL;
127
if(name != NULL){
128
do {
129
copy_name = strdup(name);
130
} while(copy_name == NULL and errno == EINTR);
131
if(copy_name == NULL){
132
int e = errno;
133
free(new_plugin);
134
errno = e;
135
return NULL;
136
}
137
}
138
139
*new_plugin = (plugin){ .name = copy_name,
140
.argc = 1,
141
.disabled = false,
142
.next = plugin_list };
143
144
do {
145
new_plugin->argv = malloc(sizeof(char *) * 2);
146
} while(new_plugin->argv == NULL and errno == EINTR);
147
if(new_plugin->argv == NULL){
148
int e = errno;
149
free(copy_name);
150
free(new_plugin);
151
errno = e;
152
return NULL;
153
}
154
new_plugin->argv[0] = copy_name;
115
155
new_plugin->argv[1] = NULL;
116
new_plugin->argc = 1;
117
new_plugin->disabled = false;
118
new_plugin->next = *plugin_list;
156
157
do {
158
new_plugin->environ = malloc(sizeof(char *));
159
} while(new_plugin->environ == NULL and errno == EINTR);
160
if(new_plugin->environ == NULL){
161
int e = errno;
162
free(copy_name);
163
free(new_plugin->argv);
164
free(new_plugin);
165
errno = e;
166
return NULL;
167
}
168
new_plugin->environ[0] = NULL;
169
119
170
/* Append the new plugin to the list */
120
*plugin_list = new_plugin;
171
plugin_list = new_plugin;
121
172
return new_plugin;
122
173
}
123
174
124
static void addargument(plugin *p, char *arg){
125
p->argv[p->argc] = arg;
126
p->argv = realloc(p->argv, sizeof(char *) * (size_t)(p->argc + 2));
127
if (p->argv == NULL){
128
perror("malloc");
129
exit(EXIT_FAILURE);
130
}
131
p->argc++;
132
p->argv[p->argc] = NULL;
133
}
134
175
/* Helper function for add_argument and add_environment */
176
__attribute__((nonnull, warn_unused_result))
177
static bool add_to_char_array(const char *new, char ***array,
178
int *len){
179
/* Resize the pointed-to array to hold one more pointer */
180
char **new_array = NULL;
181
do {
182
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
183
new_array = reallocarray(*array, (size_t)((*len) + 2),
184
sizeof(char *));
185
#else
186
if(((size_t)((*len) + 2)) > (SIZE_MAX / sizeof(char *))){
187
/* overflow */
188
new_array = NULL;
189
errno = ENOMEM;
190
} else {
191
new_array = realloc(*array, (size_t)((*len) + 2)
192
* sizeof(char *));
193
}
194
#endif
195
} while(new_array == NULL and errno == EINTR);
196
/* Malloc check */
197
if(new_array == NULL){
198
return false;
199
}
200
*array = new_array;
201
/* Make a copy of the new string */
202
char *copy;
203
do {
204
copy = strdup(new);
205
} while(copy == NULL and errno == EINTR);
206
if(copy == NULL){
207
return false;
208
}
209
/* Insert the copy */
210
(*array)[*len] = copy;
211
(*len)++;
212
/* Add a new terminating NULL pointer to the last element */
213
(*array)[*len] = NULL;
214
return true;
215
}
216
217
/* Add to a plugin's argument vector */
218
__attribute__((nonnull(2), warn_unused_result))
219
static bool add_argument(plugin *p, const char *arg){
220
if(p == NULL){
221
return false;
222
}
223
return add_to_char_array(arg, &(p->argv), &(p->argc));
224
}
225
226
/* Add to a plugin's environment */
227
__attribute__((nonnull(2), warn_unused_result))
228
static bool add_environment(plugin *p, const char *def, bool replace){
229
if(p == NULL){
230
return false;
231
}
232
/* namelen = length of name of environment variable */
233
size_t namelen = (size_t)(strchrnul(def, '=') - def);
234
/* Search for this environment variable */
235
for(char **envdef = p->environ; *envdef != NULL; envdef++){
236
if(strncmp(*envdef, def, namelen + 1) == 0){
237
/* It already exists */
238
if(replace){
239
char *new_envdef;
240
do {
241
new_envdef = realloc(*envdef, strlen(def) + 1);
242
} while(new_envdef == NULL and errno == EINTR);
243
if(new_envdef == NULL){
244
return false;
245
}
246
*envdef = new_envdef;
247
strcpy(*envdef, def);
248
}
249
return true;
250
}
251
}
252
return add_to_char_array(def, &(p->environ), &(p->envc));
253
}
254
255
#ifndef O_CLOEXEC
135
256
/*
136
257
* Based on the example in the GNU LibC manual chapter 13.13 "File
137
258
* Descriptor Flags".
138
* *Note File Descriptor Flags:(libc)Descriptor Flags.
259
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
139
260
*/
140
static int set_cloexec_flag(int fd)
141
{
142
int ret = fcntl(fd, F_GETFD, 0);
261
__attribute__((warn_unused_result))
262
static int set_cloexec_flag(int fd){
263
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
143
264
/* If reading the flags failed, return error indication now. */
144
265
if(ret < 0){
145
266
return ret;
146
267
}
147
268
/* Store modified flag word in the descriptor. */
148
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
269
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
270
ret | FD_CLOEXEC));
149
271
}
150
151
process *process_list = NULL;
152
153
/* Mark a process as completed when it exits, and save its exit
272
#endif /* not O_CLOEXEC */
273
274
275
/* Mark processes as completed when they exit, and save their exit
154
276
status. */
155
void handle_sigchld(__attribute__((unused)) int sig){
156
process *proc = process_list;
157
int status;
158
pid_t pid = wait(&status);
159
if(pid == -1){
160
perror("wait");
161
return;
162
}
163
while(proc != NULL and proc->pid != pid){
164
proc = proc->next;
165
}
166
if(proc == NULL){
167
/* Process not found in process list */
168
return;
169
}
170
proc->status = status;
171
proc->completed = true;
277
static void handle_sigchld(__attribute__((unused)) int sig){
278
int old_errno = errno;
279
while(true){
280
plugin *proc = plugin_list;
281
int status;
282
pid_t pid = waitpid(-1, &status, WNOHANG);
283
if(pid == 0){
284
/* Only still running child processes */
285
break;
286
}
287
if(pid == -1){
288
if(errno == ECHILD){
289
/* No child processes */
290
break;
291
}
292
error(0, errno, "waitpid");
293
}
294
295
/* A child exited, find it in process_list */
296
while(proc != NULL and proc->pid != pid){
297
proc = proc->next;
298
}
299
if(proc == NULL){
300
/* Process not found in process list */
301
continue;
302
}
303
proc->status = status;
304
proc->completed = 1;
305
}
306
errno = old_errno;
172
307
}
173
308
174
bool print_out_password(const char *buffer, size_t length){
309
/* Prints out a password to stdout */
310
__attribute__((nonnull, warn_unused_result))
311
static bool print_out_password(const char *buffer, size_t length){
175
312
ssize_t ret;
176
if(length>0 and buffer[length-1] == '\n'){
177
length--;
178
}
179
313
for(size_t written = 0; written < length; written += (size_t)ret){
180
314
ret = TEMP_FAILURE_RETRY(write(STDOUT_FILENO, buffer + written,
181
315
length - written));
186
320
return true;
187
321
}
188
322
189
char ** addcustomargument(char **argv, int *argc, char *arg){
190
191
if (argv == NULL){
192
*argc = 1;
193
argv = malloc(sizeof(char*) * 2);
194
if(argv == NULL){
195
return NULL;
323
/* Removes and free a plugin from the plugin list */
324
__attribute__((nonnull))
325
static void free_plugin(plugin *plugin_node){
326
327
for(char **arg = (plugin_node->argv)+1; *arg != NULL; arg++){
328
free(*arg);
329
}
330
free(plugin_node->name);
331
free(plugin_node->argv);
332
for(char **env = plugin_node->environ; *env != NULL; env++){
333
free(*env);
334
}
335
free(plugin_node->environ);
336
free(plugin_node->buffer);
337
338
/* Removes the plugin from the singly-linked list */
339
if(plugin_node == plugin_list){
340
/* First one - simple */
341
plugin_list = plugin_list->next;
342
} else {
343
/* Second one or later */
344
for(plugin *p = plugin_list; p != NULL; p = p->next){
345
if(p->next == plugin_node){
346
p->next = plugin_node->next;
347
break;
348
}
196
349
}
197
argv[0] = NULL; /* Will be set to argv[0] in main before parsing */
198
argv[1] = NULL;
199
}
200
*argc += 1;
201
argv = realloc(argv, sizeof(char *)
202
* ((unsigned int) *argc + 1));
203
if(argv == NULL){
204
return NULL;
205
}
206
argv[*argc-1] = arg;
207
argv[*argc] = NULL;
208
return argv;
350
}
351
352
free(plugin_node);
353
}
354
355
static void free_plugin_list(void){
356
while(plugin_list != NULL){
357
free_plugin(plugin_list);
358
}
209
359
}
210
360
211
361
int main(int argc, char *argv[]){
212
const char *plugindir = "/conf/conf.d/mandos/plugins.d";
213
const char *conffile = CONFFILE;
362
char *plugindir = NULL;
363
char *pluginhelperdir = NULL;
364
char *argfile = NULL;
214
365
FILE *conffp;
215
size_t d_name_len;
216
DIR *dir = NULL;
217
struct dirent *dirst;
366
struct dirent **direntries = NULL;
218
367
struct stat st;
219
368
fd_set rfds_all;
220
369
int ret, maxfd = 0;
370
ssize_t sret;
221
371
uid_t uid = 65534;
222
372
gid_t gid = 65534;
223
373
bool debug = false;
227
377
.sa_flags = SA_NOCLDSTOP };
228
378
char **custom_argv = NULL;
229
379
int custom_argc = 0;
380
int dir_fd = -1;
230
381
231
382
/* Establish a signal handler */
232
383
sigemptyset(&sigchld_action.sa_mask);
233
384
ret = sigaddset(&sigchld_action.sa_mask, SIGCHLD);
234
if(ret < 0){
235
perror("sigaddset");
236
exit(EXIT_FAILURE);
385
if(ret == -1){
386
error(0, errno, "sigaddset");
387
exitstatus = EX_OSERR;
388
goto fallback;
237
389
}
238
390
ret = sigaction(SIGCHLD, &sigchld_action, &old_sigchld_action);
239
if(ret < 0){
240
perror("sigaction");
241
exit(EXIT_FAILURE);
391
if(ret == -1){
392
error(0, errno, "sigaction");
393
exitstatus = EX_OSERR;
394
goto fallback;
242
395
}
243
396
244
397
/* The options we understand. */
246
399
{ .name = "global-options", .key = 'g',
247
400
.arg = "OPTION[,OPTION[,...]]",
248
401
.doc = "Options passed to all plugins" },
402
{ .name = "global-env", .key = 'G',
403
.arg = "VAR=value",
404
.doc = "Environment variable passed to all plugins" },
249
405
{ .name = "options-for", .key = 'o',
250
406
.arg = "PLUGIN:OPTION[,OPTION[,...]]",
251
407
.doc = "Options passed only to specified plugin" },
408
{ .name = "env-for", .key = 'E',
409
.arg = "PLUGIN:ENV=value",
410
.doc = "Environment variable passed to specified plugin" },
252
411
{ .name = "disable", .key = 'd',
253
412
.arg = "PLUGIN",
254
413
.doc = "Disable a specific plugin", .group = 1 },
414
{ .name = "enable", .key = 'e',
415
.arg = "PLUGIN",
416
.doc = "Enable a specific plugin", .group = 1 },
255
417
{ .name = "plugin-dir", .key = 128,
256
418
.arg = "DIRECTORY",
257
419
.doc = "Specify a different plugin directory", .group = 2 },
258
{ .name = "userid", .key = 129,
259
.arg = "ID", .flags = 0,
260
.doc = "User ID the plugins will run as", .group = 2 },
261
{ .name = "groupid", .key = 130,
262
.arg = "ID", .flags = 0,
263
.doc = "Group ID the plugins will run as", .group = 2 },
264
{ .name = "debug", .key = 131,
265
.doc = "Debug mode", .group = 3 },
420
{ .name = "config-file", .key = 129,
421
.arg = "FILE",
422
.doc = "Specify a different configuration file", .group = 2 },
423
{ .name = "userid", .key = 130,
424
.arg = "ID", .flags = 0,
425
.doc = "User ID the plugins will run as", .group = 3 },
426
{ .name = "groupid", .key = 131,
427
.arg = "ID", .flags = 0,
428
.doc = "Group ID the plugins will run as", .group = 3 },
429
{ .name = "debug", .key = 132,
430
.doc = "Debug mode", .group = 4 },
431
{ .name = "plugin-helper-dir", .key = 133,
432
.arg = "DIRECTORY",
433
.doc = "Specify a different plugin helper directory",
434
.group = 2 },
435
/*
436
* These reproduce what we would get without ARGP_NO_HELP
437
*/
438
{ .name = "help", .key = '?',
439
.doc = "Give this help list", .group = -1 },
440
{ .name = "usage", .key = -3,
441
.doc = "Give a short usage message", .group = -1 },
442
{ .name = "version", .key = 'V',
443
.doc = "Print program version", .group = -1 },
266
444
{ .name = NULL }
267
445
};
268
446
269
error_t parse_opt (int key, char *arg, struct argp_state *state) {
270
/* Get the INPUT argument from `argp_parse', which we know is a
271
pointer to our plugin list pointer. */
272
plugin **plugins = state->input;
273
switch (key) {
274
case 'g':
275
if (arg != NULL){
276
char *p;
277
while((p = strsep(&arg, ",")) != NULL){
278
if(p[0] == '\0'){
279
continue;
280
}
281
addargument(getplugin(NULL, plugins), p);
282
}
283
}
284
break;
285
case 'o':
286
if (arg != NULL){
287
char *name = strsep(&arg, ":");
288
if(name[0] == '\0'){
289
break;
290
}
291
char *opt = strsep(&arg, ":");
292
if(opt[0] == '\0'){
293
break;
294
}
295
if(opt != NULL){
296
char *p;
297
while((p = strsep(&opt, ",")) != NULL){
298
if(p[0] == '\0'){
299
continue;
300
}
301
addargument(getplugin(name, plugins), p);
302
}
303
}
304
}
305
break;
306
case 'd':
307
if (arg != NULL){
308
getplugin(arg, plugins)->disabled = true;
309
}
310
break;
311
case 128:
312
plugindir = arg;
313
break;
314
case 129:
315
uid = (uid_t)strtol(arg, NULL, 10);
316
break;
317
case 130:
318
gid = (gid_t)strtol(arg, NULL, 10);
319
break;
320
case 131:
447
__attribute__((nonnull(3)))
448
error_t parse_opt(int key, char *arg, struct argp_state *state){
449
errno = 0;
450
switch(key){
451
char *tmp;
452
intmax_t tmp_id;
453
case 'g': /* --global-options */
454
{
455
char *plugin_option;
456
while((plugin_option = strsep(&arg, ",")) != NULL){
457
if(not add_argument(getplugin(NULL), plugin_option)){
458
break;
459
}
460
}
461
errno = 0;
462
}
463
break;
464
case 'G': /* --global-env */
465
if(add_environment(getplugin(NULL), arg, true)){
466
errno = 0;
467
}
468
break;
469
case 'o': /* --options-for */
470
{
471
char *option_list = strchr(arg, ':');
472
if(option_list == NULL){
473
argp_error(state, "No colon in \"%s\"", arg);
474
errno = EINVAL;
475
break;
476
}
477
*option_list = '\0';
478
option_list++;
479
if(arg[0] == '\0'){
480
argp_error(state, "Empty plugin name");
481
errno = EINVAL;
482
break;
483
}
484
char *option;
485
while((option = strsep(&option_list, ",")) != NULL){
486
if(not add_argument(getplugin(arg), option)){
487
break;
488
}
489
}
490
errno = 0;
491
}
492
break;
493
case 'E': /* --env-for */
494
{
495
char *envdef = strchr(arg, ':');
496
if(envdef == NULL){
497
argp_error(state, "No colon in \"%s\"", arg);
498
errno = EINVAL;
499
break;
500
}
501
*envdef = '\0';
502
envdef++;
503
if(arg[0] == '\0'){
504
argp_error(state, "Empty plugin name");
505
errno = EINVAL;
506
break;
507
}
508
if(add_environment(getplugin(arg), envdef, true)){
509
errno = 0;
510
}
511
}
512
break;
513
case 'd': /* --disable */
514
{
515
plugin *p = getplugin(arg);
516
if(p != NULL){
517
p->disabled = true;
518
errno = 0;
519
}
520
}
521
break;
522
case 'e': /* --enable */
523
{
524
plugin *p = getplugin(arg);
525
if(p != NULL){
526
p->disabled = false;
527
errno = 0;
528
}
529
}
530
break;
531
case 128: /* --plugin-dir */
532
free(plugindir);
533
plugindir = strdup(arg);
534
if(plugindir != NULL){
535
errno = 0;
536
}
537
break;
538
case 129: /* --config-file */
539
/* This is already done by parse_opt_config_file() */
540
break;
541
case 130: /* --userid */
542
tmp_id = strtoimax(arg, &tmp, 10);
543
if(errno != 0 or tmp == arg or *tmp != '\0'
544
or tmp_id != (uid_t)tmp_id){
545
argp_error(state, "Bad user ID number: \"%s\", using %"
546
PRIdMAX, arg, (intmax_t)uid);
547
break;
548
}
549
uid = (uid_t)tmp_id;
550
errno = 0;
551
break;
552
case 131: /* --groupid */
553
tmp_id = strtoimax(arg, &tmp, 10);
554
if(errno != 0 or tmp == arg or *tmp != '\0'
555
or tmp_id != (gid_t)tmp_id){
556
argp_error(state, "Bad group ID number: \"%s\", using %"
557
PRIdMAX, arg, (intmax_t)gid);
558
break;
559
}
560
gid = (gid_t)tmp_id;
561
errno = 0;
562
break;
563
case 132: /* --debug */
321
564
debug = true;
322
565
break;
323
case ARGP_KEY_ARG:
324
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
325
break;
326
case ARGP_KEY_END:
327
break;
328
default:
329
return ARGP_ERR_UNKNOWN;
330
}
331
return 0;
332
}
333
334
plugin *plugin_list = NULL;
335
336
struct argp argp = { .options = options, .parser = parse_opt,
337
.args_doc = "[+PLUS_SEPARATED_OPTIONS]",
566
case 133: /* --plugin-helper-dir */
567
free(pluginhelperdir);
568
pluginhelperdir = strdup(arg);
569
if(pluginhelperdir != NULL){
570
errno = 0;
571
}
572
break;
573
/*
574
* These reproduce what we would get without ARGP_NO_HELP
575
*/
576
case '?': /* --help */
577
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
578
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
579
__builtin_unreachable();
580
case -3: /* --usage */
581
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
582
argp_state_help(state, state->out_stream,
583
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
584
__builtin_unreachable();
585
case 'V': /* --version */
586
fprintf(state->out_stream, "%s\n", argp_program_version);
587
exit(EXIT_SUCCESS);
588
break;
589
/*
590
* When adding more options before this line, remember to also add a
591
* "case" to the "parse_opt_config_file" function below.
592
*/
593
case ARGP_KEY_ARG:
594
/* Cryptsetup always passes an argument, which is an empty
595
string if "none" was specified in /etc/crypttab. So if
596
argument was empty, we ignore it silently. */
597
if(arg[0] == '\0'){
598
break;
599
}
600
#if __GNUC__ >= 7
601
__attribute__((fallthrough));
602
#else
603
/* FALLTHROUGH */
604
#endif
605
default:
606
return ARGP_ERR_UNKNOWN;
607
}
608
return errno; /* Set to 0 at start */
609
}
610
611
/* This option parser is the same as parse_opt() above, except it
612
ignores everything but the --config-file option. */
613
error_t parse_opt_config_file(int key, char *arg,
614
__attribute__((unused))
615
struct argp_state *state){
616
errno = 0;
617
switch(key){
618
case 'g': /* --global-options */
619
case 'G': /* --global-env */
620
case 'o': /* --options-for */
621
case 'E': /* --env-for */
622
case 'd': /* --disable */
623
case 'e': /* --enable */
624
case 128: /* --plugin-dir */
625
break;
626
case 129: /* --config-file */
627
free(argfile);
628
argfile = strdup(arg);
629
if(argfile != NULL){
630
errno = 0;
631
}
632
break;
633
case 130: /* --userid */
634
case 131: /* --groupid */
635
case 132: /* --debug */
636
case 133: /* --plugin-helper-dir */
637
case '?': /* --help */
638
case -3: /* --usage */
639
case 'V': /* --version */
640
case ARGP_KEY_ARG:
641
break;
642
default:
643
return ARGP_ERR_UNKNOWN;
644
}
645
return errno;
646
}
647
648
struct argp argp = { .options = options,
649
.parser = parse_opt_config_file,
650
.args_doc = "",
338
651
.doc = "Mandos plugin runner -- Run plugins" };
339
652
340
ret = argp_parse (&argp, argc, argv, 0, 0, &plugin_list);
341
if (ret == ARGP_ERR_UNKNOWN){
342
fprintf(stderr, "Unknown error while parsing arguments\n");
343
exitstatus = EXIT_FAILURE;
344
goto end;
345
}
346
347
conffp = fopen(conffile, "r");
653
/* Parse using parse_opt_config_file() in order to get the custom
654
config file location, if any. */
655
ret = argp_parse(&argp, argc, argv,
656
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
657
NULL, NULL);
658
switch(ret){
659
case 0:
660
break;
661
case ENOMEM:
662
default:
663
errno = ret;
664
error(0, errno, "argp_parse");
665
exitstatus = EX_OSERR;
666
goto fallback;
667
case EINVAL:
668
exitstatus = EX_USAGE;
669
goto fallback;
670
}
671
672
/* Reset to the normal argument parser */
673
argp.parser = parse_opt;
674
675
/* Open the configfile if available */
676
if(argfile == NULL){
677
conffp = fopen(AFILE, "r");
678
} else {
679
conffp = fopen(argfile, "r");
680
}
348
681
if(conffp != NULL){
349
682
char *org_line = NULL;
683
char *p, *arg, *new_arg, *line;
350
684
size_t size = 0;
351
ssize_t sret;
352
char *p, *arg, *new_arg, *line;
353
685
const char whitespace_delims[] = " \r\t\f\v\n";
354
686
const char comment_delim[] = "#";
355
687
688
custom_argc = 1;
689
custom_argv = malloc(sizeof(char*) * 2);
690
if(custom_argv == NULL){
691
error(0, errno, "malloc");
692
exitstatus = EX_OSERR;
693
goto fallback;
694
}
695
custom_argv[0] = argv[0];
696
custom_argv[1] = NULL;
697
698
/* for each line in the config file, strip whitespace and ignore
699
commented text */
356
700
while(true){
357
701
sret = getline(&org_line, &size, conffp);
358
702
if(sret == -1){
359
703
break;
360
704
}
361
705
362
706
line = org_line;
363
707
arg = strsep(&line, comment_delim);
364
708
while((p = strsep(&arg, whitespace_delims)) != NULL){
366
710
continue;
367
711
}
368
712
new_arg = strdup(p);
369
custom_argv = addcustomargument(custom_argv, &custom_argc, new_arg);
370
if (custom_argv == NULL){
371
perror("addcustomargument");
372
exitstatus = EXIT_FAILURE;
373
goto end;
374
}
713
if(new_arg == NULL){
714
error(0, errno, "strdup");
715
exitstatus = EX_OSERR;
716
free(org_line);
717
goto fallback;
718
}
719
720
custom_argc += 1;
721
{
722
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
723
char **new_argv = reallocarray(custom_argv, (size_t)custom_argc + 1,
724
sizeof(char *));
725
#else
726
char **new_argv = NULL;
727
if(((size_t)custom_argc + 1) > (SIZE_MAX / sizeof(char *))){
728
/* overflow */
729
errno = ENOMEM;
730
} else {
731
new_argv = realloc(custom_argv, ((size_t)custom_argc + 1)
732
* sizeof(char *));
733
}
734
#endif
735
if(new_argv == NULL){
736
error(0, errno, "reallocarray");
737
exitstatus = EX_OSERR;
738
free(new_arg);
739
free(org_line);
740
goto fallback;
741
} else {
742
custom_argv = new_argv;
743
}
744
}
745
custom_argv[custom_argc-1] = new_arg;
746
custom_argv[custom_argc] = NULL;
375
747
}
376
748
}
749
do {
750
ret = fclose(conffp);
751
} while(ret == EOF and errno == EINTR);
752
if(ret == EOF){
753
error(0, errno, "fclose");
754
exitstatus = EX_IOERR;
755
goto fallback;
756
}
377
757
free(org_line);
378
} else{
379
/* check for harmfull errors */
380
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
381
perror("fopen");
382
exitstatus = EXIT_FAILURE;
383
goto end;
758
} else {
759
/* Check for harmful errors and go to fallback. Other errors might
760
not affect opening plugins */
761
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
762
error(0, errno, "fopen");
763
exitstatus = EX_OSERR;
764
goto fallback;
384
765
}
385
766
}
386
767
/* If there were any arguments from the configuration file, pass
768
them to parser as command line arguments */
387
769
if(custom_argv != NULL){
388
custom_argv[0] = argv[0];
389
ret = argp_parse (&argp, custom_argc, custom_argv, 0, 0, &plugin_list);
390
if (ret == ARGP_ERR_UNKNOWN){
391
fprintf(stderr, "Unknown error while parsing arguments\n");
392
exitstatus = EXIT_FAILURE;
393
goto end;
770
ret = argp_parse(&argp, custom_argc, custom_argv,
771
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
772
NULL, NULL);
773
switch(ret){
774
case 0:
775
break;
776
case ENOMEM:
777
default:
778
errno = ret;
779
error(0, errno, "argp_parse");
780
exitstatus = EX_OSERR;
781
goto fallback;
782
case EINVAL:
783
exitstatus = EX_CONFIG;
784
goto fallback;
785
}
786
}
787
788
/* Parse actual command line arguments, to let them override the
789
config file */
790
ret = argp_parse(&argp, argc, argv,
791
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
792
NULL, NULL);
793
switch(ret){
794
case 0:
795
break;
796
case ENOMEM:
797
default:
798
errno = ret;
799
error(0, errno, "argp_parse");
800
exitstatus = EX_OSERR;
801
goto fallback;
802
case EINVAL:
803
exitstatus = EX_USAGE;
804
goto fallback;
805
}
806
807
{
808
char *pluginhelperenv;
809
bool bret = true;
810
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
811
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
812
if(ret != -1){
813
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
814
}
815
if(ret == -1 or not bret){
816
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
817
" environment variable to \"%s\" for all plugins\n",
818
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
819
}
820
if(ret != -1){
821
free(pluginhelperenv);
394
822
}
395
823
}
396
824
397
825
if(debug){
398
for(plugin *p = plugin_list; p != NULL; p=p->next){
826
for(plugin *p = plugin_list; p != NULL; p = p->next){
399
827
fprintf(stderr, "Plugin: %s has %d arguments\n",
400
828
p->name ? p->name : "Global", p->argc - 1);
401
829
for(char **a = p->argv; *a != NULL; a++){
402
830
fprintf(stderr, "\tArg: %s\n", *a);
403
831
}
404
}
405
}
406
832
fprintf(stderr, "...and %d environment variables\n", p->envc);
833
for(char **a = p->environ; *a != NULL; a++){
834
fprintf(stderr, "\t%s\n", *a);
835
}
836
}
837
}
838
839
if(getuid() == 0){
840
/* Work around Debian bug #633582:
841
<https://bugs.debian.org/633582> */
842
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
843
if(plugindir_fd == -1){
844
if(errno != ENOENT){
845
error(0, errno, "open(\"" PDIR "\")");
846
}
847
} else {
848
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
849
if(ret == -1){
850
error(0, errno, "fstat");
851
} else {
852
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
853
ret = fchown(plugindir_fd, uid, gid);
854
if(ret == -1){
855
error(0, errno, "fchown");
856
}
857
}
858
}
859
close(plugindir_fd);
860
}
861
}
862
863
/* Lower permissions */
864
ret = setgid(gid);
865
if(ret == -1){
866
error(0, errno, "setgid");
867
}
407
868
ret = setuid(uid);
408
if (ret == -1){
409
perror("setuid");
410
}
411
412
setgid(gid);
413
if (ret == -1){
414
perror("setgid");
415
}
416
417
dir = opendir(plugindir);
418
if(dir == NULL){
419
perror("Could not open plugin dir");
420
exitstatus = EXIT_FAILURE;
421
goto end;
422
}
423
424
/* Set the FD_CLOEXEC flag on the directory, if possible */
869
if(ret == -1){
870
error(0, errno, "setuid");
871
}
872
873
/* Open plugin directory with close_on_exec flag */
425
874
{
426
int dir_fd = dirfd(dir);
427
if(dir_fd >= 0){
428
ret = set_cloexec_flag(dir_fd);
429
if(ret < 0){
430
perror("set_cloexec_flag");
431
exitstatus = EXIT_FAILURE;
432
goto end;
875
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
876
#ifdef O_CLOEXEC
877
O_CLOEXEC
878
#else /* not O_CLOEXEC */
879
0
880
#endif /* not O_CLOEXEC */
881
);
882
if(dir_fd == -1){
883
error(0, errno, "Could not open plugin dir");
884
exitstatus = EX_UNAVAILABLE;
885
goto fallback;
886
}
887
888
#ifndef O_CLOEXEC
889
/* Set the FD_CLOEXEC flag on the directory */
890
ret = set_cloexec_flag(dir_fd);
891
if(ret < 0){
892
error(0, errno, "set_cloexec_flag");
893
exitstatus = EX_OSERR;
894
goto fallback;
895
}
896
#endif /* O_CLOEXEC */
897
}
898
899
int good_name(const struct dirent * const dirent){
900
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
901
"*.dpkg-old", "*.dpkg-bak",
902
"*.dpkg-divert", NULL };
903
#ifdef __GNUC__
904
#pragma GCC diagnostic push
905
#pragma GCC diagnostic ignored "-Wcast-qual"
906
#endif
907
for(const char **pat = (const char **)patterns;
908
*pat != NULL; pat++){
909
#ifdef __GNUC__
910
#pragma GCC diagnostic pop
911
#endif
912
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
913
!= FNM_NOMATCH){
914
if(debug){
915
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
916
" matching pattern %s\n", dirent->d_name, *pat);
917
}
918
return 0;
433
919
}
434
920
}
921
return 1;
922
}
923
924
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
925
alphasort);
926
if(numplugins == -1){
927
error(0, errno, "Could not scan plugin dir");
928
direntries = NULL;
929
exitstatus = EX_OSERR;
930
goto fallback;
435
931
}
436
932
437
933
FD_ZERO(&rfds_all);
438
934
439
while(true){
440
dirst = readdir(dir);
441
442
// All directory entries have been processed
443
if(dirst == NULL){
444
if (errno == EBADF){
445
perror("readdir");
446
exitstatus = EXIT_FAILURE;
447
goto end;
448
}
449
break;
450
}
451
452
d_name_len = strlen(dirst->d_name);
453
454
// Ignore dotfiles, backup files and other junk
455
{
456
bool bad_name = false;
457
458
const char const *bad_prefixes[] = { ".", "#", NULL };
459
460
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
461
".dpkg-old",
462
".dpkg-divert", NULL };
463
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
464
size_t pre_len = strlen(*pre);
465
if((d_name_len >= pre_len)
466
and strncmp((dirst->d_name), *pre, pre_len) == 0){
467
if(debug){
468
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
469
" with bad prefix %s\n", dirst->d_name, *pre);
470
}
471
bad_name = true;
472
break;
473
}
474
}
475
476
if(bad_name){
477
continue;
478
}
479
480
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
481
size_t suf_len = strlen(*suf);
482
if((d_name_len >= suf_len)
483
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
484
== 0)){
485
if(debug){
486
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
487
" with bad suffix %s\n", dirst->d_name, *suf);
488
}
489
bad_name = true;
490
break;
491
}
492
}
493
494
if(bad_name){
495
continue;
496
}
497
}
498
499
char *filename = malloc(d_name_len + strlen(plugindir) + 2);
500
if (filename == NULL){
501
perror("malloc");
502
continue;
503
}
504
strcpy(filename, plugindir); /* Spurious warning */
505
strcat(filename, "/"); /* Spurious warning */
506
strcat(filename, dirst->d_name); /* Spurious warning */
507
508
ret = stat(filename, &st);
509
if (ret == -1){
510
perror("stat");
511
free(filename);
512
continue;
513
}
514
515
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
935
/* Read and execute any executable in the plugin directory*/
936
for(int i = 0; i < numplugins; i++){
937
938
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
939
if(plugin_fd == -1){
940
error(0, errno, "Could not open plugin");
941
free(direntries[i]);
942
continue;
943
}
944
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
945
if(ret == -1){
946
error(0, errno, "stat");
947
close(plugin_fd);
948
free(direntries[i]);
949
continue;
950
}
951
952
/* Ignore non-executable files */
953
if(not S_ISREG(st.st_mode)
954
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
955
X_OK, 0)) != 0)){
516
956
if(debug){
517
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
518
" with bad type or mode\n", filename);
957
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
958
" with bad type or mode\n",
959
plugindir != NULL ? plugindir : PDIR,
960
direntries[i]->d_name);
519
961
}
520
free(filename);
521
continue;
522
}
523
if(getplugin(dirst->d_name, &plugin_list)->disabled){
962
close(plugin_fd);
963
free(direntries[i]);
964
continue;
965
}
966
967
plugin *p = getplugin(direntries[i]->d_name);
968
if(p == NULL){
969
error(0, errno, "getplugin");
970
close(plugin_fd);
971
free(direntries[i]);
972
continue;
973
}
974
if(p->disabled){
524
975
if(debug){
525
976
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
526
dirst->d_name);
977
direntries[i]->d_name);
527
978
}
528
free(filename);
979
close(plugin_fd);
980
free(direntries[i]);
529
981
continue;
530
982
}
531
plugin *p = getplugin(dirst->d_name, &plugin_list);
532
983
{
533
984
/* Add global arguments to argument list for this plugin */
534
plugin *g = getplugin(NULL, &plugin_list);
535
for(char **a = g->argv + 1; *a != NULL; a++){
536
addargument(p, *a);
537
}
538
}
539
int pipefd[2];
540
ret = pipe(pipefd);
541
if (ret == -1){
542
perror("pipe");
543
exitstatus = EXIT_FAILURE;
544
goto end;
545
}
985
plugin *g = getplugin(NULL);
986
if(g != NULL){
987
for(char **a = g->argv + 1; *a != NULL; a++){
988
if(not add_argument(p, *a)){
989
error(0, errno, "add_argument");
990
}
991
}
992
/* Add global environment variables */
993
for(char **e = g->environ; *e != NULL; e++){
994
if(not add_environment(p, *e, false)){
995
error(0, errno, "add_environment");
996
}
997
}
998
}
999
}
1000
/* If this plugin has any environment variables, we need to
1001
duplicate the environment from this process, too. */
1002
if(p->environ[0] != NULL){
1003
for(char **e = environ; *e != NULL; e++){
1004
if(not add_environment(p, *e, false)){
1005
error(0, errno, "add_environment");
1006
}
1007
}
1008
}
1009
1010
int pipefd[2];
1011
#ifndef O_CLOEXEC
1012
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1013
#else /* O_CLOEXEC */
1014
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
1015
#endif /* O_CLOEXEC */
1016
if(ret == -1){
1017
error(0, errno, "pipe");
1018
exitstatus = EX_OSERR;
1019
free(direntries[i]);
1020
goto fallback;
1021
}
1022
if(pipefd[0] >= FD_SETSIZE){
1023
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1024
FD_SETSIZE);
1025
close(pipefd[0]);
1026
close(pipefd[1]);
1027
exitstatus = EX_OSERR;
1028
free(direntries[i]);
1029
goto fallback;
1030
}
1031
#ifndef O_CLOEXEC
1032
/* Ask OS to automatic close the pipe on exec */
546
1033
ret = set_cloexec_flag(pipefd[0]);
547
1034
if(ret < 0){
548
perror("set_cloexec_flag");
549
exitstatus = EXIT_FAILURE;
550
goto end;
1035
error(0, errno, "set_cloexec_flag");
1036
close(pipefd[0]);
1037
close(pipefd[1]);
1038
exitstatus = EX_OSERR;
1039
free(direntries[i]);
1040
goto fallback;
551
1041
}
552
1042
ret = set_cloexec_flag(pipefd[1]);
553
1043
if(ret < 0){
554
perror("set_cloexec_flag");
555
exitstatus = EXIT_FAILURE;
556
goto end;
1044
error(0, errno, "set_cloexec_flag");
1045
close(pipefd[0]);
1046
close(pipefd[1]);
1047
exitstatus = EX_OSERR;
1048
free(direntries[i]);
1049
goto fallback;
557
1050
}
1051
#endif /* not O_CLOEXEC */
558
1052
/* Block SIGCHLD until process is safely in process list */
559
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1053
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1054
&sigchld_action.sa_mask,
1055
NULL));
560
1056
if(ret < 0){
561
perror("sigprocmask");
562
exitstatus = EXIT_FAILURE;
563
goto end;
1057
error(0, errno, "sigprocmask");
1058
exitstatus = EX_OSERR;
1059
free(direntries[i]);
1060
goto fallback;
564
1061
}
565
// Starting a new process to be watched
566
pid_t pid = fork();
1062
/* Starting a new process to be watched */
1063
pid_t pid;
1064
do {
1065
pid = fork();
1066
} while(pid == -1 and errno == EINTR);
567
1067
if(pid == -1){
568
perror("fork");
569
exitstatus = EXIT_FAILURE;
570
goto end;
1068
error(0, errno, "fork");
1069
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1070
&sigchld_action.sa_mask, NULL));
1071
close(pipefd[0]);
1072
close(pipefd[1]);
1073
exitstatus = EX_OSERR;
1074
free(direntries[i]);
1075
goto fallback;
571
1076
}
572
1077
if(pid == 0){
573
1078
/* this is the child process */
574
1079
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
575
1080
if(ret < 0){
576
perror("sigaction");
577
_exit(EXIT_FAILURE);
1081
error(0, errno, "sigaction");
1082
_exit(EX_OSERR);
578
1083
}
579
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1084
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
580
1085
if(ret < 0){
581
perror("sigprocmask");
582
_exit(EXIT_FAILURE);
1086
error(0, errno, "sigprocmask");
1087
_exit(EX_OSERR);
583
1088
}
584
1089
585
1090
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
586
1091
if(ret == -1){
587
perror("dup2");
588
_exit(EXIT_FAILURE);
1092
error(0, errno, "dup2");
1093
_exit(EX_OSERR);
589
1094
}
590
1095
591
if(dirfd(dir) < 0){
592
/* If dir has no file descriptor, we could not set FD_CLOEXEC
593
above and must now close it manually here. */
594
closedir(dir);
595
}
596
if(execv(filename, p->argv) < 0){
597
perror("execv");
598
_exit(EXIT_FAILURE);
1096
if(fexecve(plugin_fd, p->argv,
1097
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1098
error(0, errno, "fexecve for %s/%s",
1099
plugindir != NULL ? plugindir : PDIR,
1100
direntries[i]->d_name);
1101
_exit(EX_OSERR);
599
1102
}
600
1103
/* no return */
601
1104
}
602
/* parent process */
603
free(filename);
604
close(pipefd[1]); /* close unused write end of pipe */
605
process *new_process = malloc(sizeof(process));
606
if (new_process == NULL){
607
perror("malloc");
608
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1105
/* Parent process */
1106
close(pipefd[1]); /* Close unused write end of pipe */
1107
close(plugin_fd);
1108
plugin *new_plugin = getplugin(direntries[i]->d_name);
1109
if(new_plugin == NULL){
1110
error(0, errno, "getplugin");
1111
ret = (int)(TEMP_FAILURE_RETRY
1112
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
1113
NULL)));
609
1114
if(ret < 0){
610
perror("sigprocmask");
1115
error(0, errno, "sigprocmask");
611
1116
}
612
exitstatus = EXIT_FAILURE;
613
goto end;
1117
exitstatus = EX_OSERR;
1118
free(direntries[i]);
1119
goto fallback;
614
1120
}
1121
free(direntries[i]);
615
1122
616
*new_process = (struct process){ .pid = pid,
617
.fd = pipefd[0],
618
.next = process_list };
619
// List handling
620
process_list = new_process;
1123
new_plugin->pid = pid;
1124
new_plugin->fd = pipefd[0];
1125
1126
if(debug){
1127
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1128
new_plugin->name, (intmax_t) (new_plugin->pid));
1129
}
1130
621
1131
/* Unblock SIGCHLD so signal handler can be run if this process
622
1132
has already completed */
623
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1133
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1134
&sigchld_action.sa_mask,
1135
NULL));
624
1136
if(ret < 0){
625
perror("sigprocmask");
626
exitstatus = EXIT_FAILURE;
627
goto end;
628
}
629
630
FD_SET(new_process->fd, &rfds_all);
631
632
if (maxfd < new_process->fd){
633
maxfd = new_process->fd;
634
}
635
636
}
637
638
/* Free the plugin list */
639
for(plugin *next; plugin_list != NULL; plugin_list = next){
640
next = plugin_list->next;
641
free(plugin_list->argv);
642
free(plugin_list);
643
}
644
645
closedir(dir);
646
dir = NULL;
647
648
if (process_list == NULL){
649
fprintf(stderr, "No plugin processes started. Incorrect plugin"
650
" directory?\n");
651
process_list = NULL;
652
}
653
while(process_list){
1137
error(0, errno, "sigprocmask");
1138
exitstatus = EX_OSERR;
1139
goto fallback;
1140
}
1141
1142
FD_SET(new_plugin->fd, &rfds_all);
1143
1144
if(maxfd < new_plugin->fd){
1145
maxfd = new_plugin->fd;
1146
}
1147
}
1148
1149
free(direntries);
1150
direntries = NULL;
1151
close(dir_fd);
1152
dir_fd = -1;
1153
free_plugin(getplugin(NULL));
1154
1155
for(plugin *p = plugin_list; p != NULL; p = p->next){
1156
if(p->pid != 0){
1157
break;
1158
}
1159
if(p->next == NULL){
1160
fprintf(stderr, "No plugin processes started. Incorrect plugin"
1161
" directory?\n");
1162
free_plugin_list();
1163
}
1164
}
1165
1166
/* Main loop while running plugins exist */
1167
while(plugin_list){
654
1168
fd_set rfds = rfds_all;
655
1169
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
656
if (select_ret == -1){
657
perror("select");
658
exitstatus = EXIT_FAILURE;
659
goto end;
1170
if(select_ret == -1 and errno != EINTR){
1171
error(0, errno, "select");
1172
exitstatus = EX_OSERR;
1173
goto fallback;
660
1174
}
661
1175
/* OK, now either a process completed, or something can be read
662
1176
from one of them */
663
for(process *proc = process_list; proc ; proc = proc->next){
1177
for(plugin *proc = plugin_list; proc != NULL;){
664
1178
/* Is this process completely done? */
665
if(proc->eof and proc->completed){
1179
if(proc->completed and proc->eof){
666
1180
/* Only accept the plugin output if it exited cleanly */
667
1181
if(not WIFEXITED(proc->status)
668
1182
or WEXITSTATUS(proc->status) != 0){
669
1183
/* Bad exit by plugin */
1184
670
1185
if(debug){
671
1186
if(WIFEXITED(proc->status)){
672
fprintf(stderr, "Plugin %u exited with status %d\n",
673
(unsigned int) (proc->pid),
1187
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1188
" status %d\n", proc->name,
1189
(intmax_t) (proc->pid),
674
1190
WEXITSTATUS(proc->status));
675
} else if(WIFSIGNALED(proc->status)) {
676
fprintf(stderr, "Plugin %u killed by signal %d\n",
677
(unsigned int) (proc->pid),
678
WTERMSIG(proc->status));
679
} else if(WCOREDUMP(proc->status)){
680
fprintf(stderr, "Plugin %d dumped core\n",
681
(unsigned int) (proc->pid));
1191
} else if(WIFSIGNALED(proc->status)){
1192
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1193
" signal %d: %s\n", proc->name,
1194
(intmax_t) (proc->pid),
1195
WTERMSIG(proc->status),
1196
strsignal(WTERMSIG(proc->status)));
682
1197
}
683
1198
}
1199
684
1200
/* Remove the plugin */
685
1201
FD_CLR(proc->fd, &rfds_all);
1202
686
1203
/* Block signal while modifying process_list */
687
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1204
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1205
(SIG_BLOCK,
1206
&sigchld_action.sa_mask,
1207
NULL));
688
1208
if(ret < 0){
689
perror("sigprocmask");
690
exitstatus = EXIT_FAILURE;
691
goto end;
692
}
693
/* Delete this process entry from the list */
694
if(process_list == proc){
695
/* First one - simple */
696
process_list = proc->next;
697
} else {
698
/* Second one or later */
699
for(process *p = process_list; p != NULL; p = p->next){
700
if(p->next == proc){
701
p->next = proc->next;
702
break;
703
}
704
}
705
}
1209
error(0, errno, "sigprocmask");
1210
exitstatus = EX_OSERR;
1211
goto fallback;
1212
}
1213
1214
plugin *next_plugin = proc->next;
1215
free_plugin(proc);
1216
proc = next_plugin;
1217
706
1218
/* We are done modifying process list, so unblock signal */
707
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,
708
NULL);
1219
ret = (int)(TEMP_FAILURE_RETRY
1220
(sigprocmask(SIG_UNBLOCK,
1221
&sigchld_action.sa_mask, NULL)));
709
1222
if(ret < 0){
710
perror("sigprocmask");
711
}
712
free(proc->buffer);
713
free(proc);
714
/* We deleted this process from the list, so we can't go
715
proc->next. Therefore, start over from the beginning of
716
the process list */
717
break;
1223
error(0, errno, "sigprocmask");
1224
exitstatus = EX_OSERR;
1225
goto fallback;
1226
}
1227
1228
if(plugin_list == NULL){
1229
break;
1230
}
1231
1232
continue;
718
1233
}
1234
719
1235
/* This process exited nicely, so print its buffer */
720
721
bool bret = print_out_password(proc->buffer, proc->buffer_length);
1236
1237
bool bret = print_out_password(proc->buffer,
1238
proc->buffer_length);
722
1239
if(not bret){
723
perror("print_out_password");
724
exitstatus = EXIT_FAILURE;
1240
error(0, errno, "print_out_password");
1241
exitstatus = EX_IOERR;
725
1242
}
726
goto end;
1243
goto fallback;
727
1244
}
1245
728
1246
/* This process has not completed. Does it have any output? */
729
1247
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
730
1248
/* This process had nothing to say at this time */
1249
proc = proc->next;
731
1250
continue;
732
1251
}
733
1252
/* Before reading, make the process' data buffer large enough */
734
1253
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
735
proc->buffer = realloc(proc->buffer, proc->buffer_size
736
+ (size_t) BUFFER_SIZE);
737
if (proc->buffer == NULL){
738
perror("malloc");
739
exitstatus = EXIT_FAILURE;
740
goto end;
1254
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1255
+ (size_t) BUFFER_SIZE);
1256
if(new_buffer == NULL){
1257
error(0, errno, "malloc");
1258
exitstatus = EX_OSERR;
1259
goto fallback;
741
1260
}
1261
proc->buffer = new_buffer;
742
1262
proc->buffer_size += BUFFER_SIZE;
743
1263
}
744
1264
/* Read from the process */
745
ret = read(proc->fd, proc->buffer + proc->buffer_length,
746
BUFFER_SIZE);
747
if(ret < 0){
1265
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1266
proc->buffer
1267
+ proc->buffer_length,
1268
BUFFER_SIZE));
1269
if(sret < 0){
748
1270
/* Read error from this process; ignore the error */
1271
proc = proc->next;
749
1272
continue;
750
1273
}
751
if(ret == 0){
1274
if(sret == 0){
752
1275
/* got EOF */
753
1276
proc->eof = true;
754
1277
} else {
755
proc->buffer_length += (size_t) ret;
1278
proc->buffer_length += (size_t) sret;
756
1279
}
757
1280
}
758
1281
}
759
760
761
end:
762
763
if(process_list == NULL or exitstatus != EXIT_SUCCESS){
764
/* Fallback if all plugins failed, none are found or an error occured */
1282
1283
1284
fallback:
1285
1286
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1287
and exitstatus != EX_OK)){
1288
/* Fallback if all plugins failed, none are found or an error
1289
occured */
765
1290
bool bret;
766
1291
fprintf(stderr, "Going to fallback mode using getpass(3)\n");
767
1292
char *passwordbuffer = getpass("Password: ");
768
bret = print_out_password(passwordbuffer, strlen(passwordbuffer));
1293
size_t len = strlen(passwordbuffer);
1294
/* Strip trailing newline */
1295
if(len > 0 and passwordbuffer[len-1] == '\n'){
1296
passwordbuffer[len-1] = '\0'; /* not strictly necessary */
1297
len--;
1298
}
1299
bret = print_out_password(passwordbuffer, len);
769
1300
if(not bret){
770
perror("print_out_password");
771
exitstatus = EXIT_FAILURE;
772
goto end;
1301
error(0, errno, "print_out_password");
1302
exitstatus = EX_IOERR;
773
1303
}
774
1304
}
775
1305
776
1306
/* Restore old signal handler */
777
sigaction(SIGCHLD, &old_sigchld_action, NULL);
778
779
free(custom_argv);
780
781
/* Free the plugin list */
782
for(plugin *next; plugin_list != NULL; plugin_list = next){
783
next = plugin_list->next;
784
free(plugin_list->argv);
785
free(plugin_list);
786
}
787
788
if(dir != NULL){
789
closedir(dir);
790
}
791
792
/* Free the process list and kill the processes */
793
for(process *next; process_list != NULL; process_list = next){
794
next = process_list->next;
795
close(process_list->fd);
796
ret = kill(process_list->pid, SIGTERM);
797
if(ret == -1 and errno != ESRCH){
798
/* set-uid proccesses migth not get closed */
799
perror("kill");
800
}
801
free(process_list->buffer);
802
free(process_list);
1307
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1308
if(ret == -1){
1309
error(0, errno, "sigaction");
1310
exitstatus = EX_OSERR;
1311
}
1312
1313
if(custom_argv != NULL){
1314
for(char **arg = custom_argv+1; *arg != NULL; arg++){
1315
free(*arg);
1316
}
1317
free(custom_argv);
1318
}
1319
1320
free(direntries);
1321
1322
if(dir_fd != -1){
1323
close(dir_fd);
1324
}
1325
1326
/* Kill the processes */
1327
for(plugin *p = plugin_list; p != NULL; p = p->next){
1328
if(p->pid != 0){
1329
close(p->fd);
1330
ret = kill(p->pid, SIGTERM);
1331
if(ret == -1 and errno != ESRCH){
1332
/* Set-uid proccesses might not get closed */
1333
error(0, errno, "kill");
1334
}
1335
}
803
1336
}
804
1337
805
1338
/* Wait for any remaining child processes to terminate */
806
do{
1339
do {
807
1340
ret = wait(NULL);
808
1341
} while(ret >= 0);
809
1342
if(errno != ECHILD){
810
perror("wait");
1343
error(0, errno, "wait");
811
1344
}
812
1345
1346
free_plugin_list();
1347
1348
free(plugindir);
1349
free(pluginhelperdir);
1350
free(argfile);
1351
813
1352
return exitstatus;
814
1353
}
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0