To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 1213
- compare with another revision
- download diff
- download tarball
- view history from revision 1213
- Committer: teddy at recompile
- Date: 2020-04-05 21:30:59 UTC
- Revision ID: teddy@recompile.se-20200405213059-fb2a61ckqynrmatk
Fix file descriptor leak in mandos-client
When the local network has Mandos servers announcing themselves using
real, globally reachable, IPv6 addresses (i.e. not link-local
addresses), but there is no router on the local network providing IPv6
RA (Router Advertisement) packets, the client cannot reach the server
by normal means, since the client only has a link-local IPv6 address,
and has no usable route to reach the server's global IPv6 address.
(This is not a common situation, and usually only happens when the
router itself reboots and runs a Mandos client, since it cannot then
give RA packets to itself.) The client code has a solution for
this, which consists of adding a temporary local route to reach the
address of the server during communication, and removing this
temporary route afterwards.
This solution with a temporary route works, but has a file descriptor
leak; it leaks one file descriptor for each addition and for each
removal of a route. If one server requiring an added route is present
on the network, but no servers gives a password, making the client
retry after the default ten seconds, and we furthermore assume a
default 1024 open files limit, the client runs out of file descriptors
after about 90 minutes, after which time the client process will be
useless and fail to retrieve any passwords, necessitating manual
password entry via the keyboard.
Fix this by eliminating the file descriptor leak in the client.
* plugins.d/mandos-client.c (add_delete_local_route): Do
close(devnull) also in parent process, also if fork() fails, and on
any failure in child process.
When the local network has Mandos servers announcing themselves using
real, globally reachable, IPv6 addresses (i.e. not link-local
addresses), but there is no router on the local network providing IPv6
RA (Router Advertisement) packets, the client cannot reach the server
by normal means, since the client only has a link-local IPv6 address,
and has no usable route to reach the server's global IPv6 address.
(This is not a common situation, and usually only happens when the
router itself reboots and runs a Mandos client, since it cannot then
give RA packets to itself.) The client code has a solution for
this, which consists of adding a temporary local route to reach the
address of the server during communication, and removing this
temporary route afterwards.
This solution with a temporary route works, but has a file descriptor
leak; it leaks one file descriptor for each addition and for each
removal of a route. If one server requiring an added route is present
on the network, but no servers gives a password, making the client
retry after the default ten seconds, and we furthermore assume a
default 1024 open files limit, the client runs out of file descriptors
after about 90 minutes, after which time the client process will be
useless and fail to retrieve any passwords, necessitating manual
password entry via the keyboard.
Fix this by eliminating the file descriptor leak in the client.
* plugins.d/mandos-client.c (add_delete_local_route): Do
close(devnull) also in parent process, also if fork() fails, and on
any failure in child process.
- files added:
- .bzr-builddeb
- debian
- debian/po
- debian/source
- debian/tests
- debian/upstream
- dracut-module
- network-hooks.d
- plugin-helpers
- files removed:
- initramfs-tools-hook-conf
- files renamed:
- plugins.d/password-request.c => plugins.d/mandos-client.c
- plugins.d/password-request.xml => plugins.d/mandos-client.xml
- files modified:
- .bzrignore
added
removed
plugin-runner.c
1
/* -*- coding: utf-8 -*- */
1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2007-2008 Teddy Hogeborn & Björn Påhlsson
6
*
7
* This program is free software: you can redistribute it and/or
8
* modify it under the terms of the GNU General Public License as
9
* published by the Free Software Foundation, either version 3 of the
10
* License, or (at your option) any later version.
11
*
12
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2018 Teddy Hogeborn
6
* Copyright © 2008-2018 Björn Påhlsson
7
*
8
* This file is part of Mandos.
9
*
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
14
*
15
* Mandos is distributed in the hope that it will be useful, but
13
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
14
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15
18
* General Public License for more details.
16
19
*
17
20
* You should have received a copy of the GNU General Public License
18
* along with this program. If not, see
19
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
20
22
*
21
* Contact the authors at <mandos@fukt.bsnet.se>.
23
* Contact the authors at <mandos@recompile.se>.
22
24
*/
23
25
24
26
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
25
asprintf() */
27
O_CLOEXEC, pipe2() */
26
28
#include <stddef.h> /* size_t, NULL */
27
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
28
EXIT_SUCCESS, realloc() */
29
#include <stdlib.h> /* malloc(), reallocarray(), realloc(),
30
EXIT_SUCCESS, exit() */
29
31
#include <stdbool.h> /* bool, true, false */
30
#include <stdio.h> /* perror, popen(), fileno(),
31
fprintf(), stderr, STDOUT_FILENO */
32
#include <sys/types.h> /* DIR, opendir(), stat(), struct
33
stat, waitpid(), WIFEXITED(),
34
WEXITSTATUS(), wait(), pid_t,
35
uid_t, gid_t, getuid(), getgid(),
36
dirfd() */
32
#include <stdio.h> /* fileno(), fprintf(),
33
stderr, STDOUT_FILENO, fclose() */
34
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
35
WIFEXITED(), WEXITSTATUS(), wait(),
36
pid_t, uid_t, gid_t, getuid(),
37
getgid() */
37
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
38
39
FD_SET(), FD_ISSET(), FD_CLR */
39
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
40
WEXITSTATUS() */
41
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
41
WEXITSTATUS(), WTERMSIG() */
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
42
43
#include <iso646.h> /* and, or, not */
43
#include <dirent.h> /* DIR, struct dirent, opendir(),
44
readdir(), closedir(), dirfd() */
45
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
46
fcntl(), setuid(), setgid(),
47
F_GETFD, F_SETFD, FD_CLOEXEC,
48
access(), pipe(), fork(), close()
49
dup2, STDOUT_FILENO, _exit(),
50
execv(), write(), read(),
51
close() */
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
51
*/
52
52
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
53
FD_CLOEXEC */
54
#include <string.h> /* strsep, strlen(), asprintf() */
53
FD_CLOEXEC, openat(), scandirat(),
54
pipe2() */
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
55
57
#include <errno.h> /* errno */
56
58
#include <argp.h> /* struct argp_option, struct
57
59
argp_state, struct argp,
61
63
#include <signal.h> /* struct sigaction, sigemptyset(),
62
64
sigaddset(), sigaction(),
63
65
sigprocmask(), SIG_BLOCK, SIGCHLD,
64
SIG_UNBLOCK, kill() */
66
SIG_UNBLOCK, kill(), sig_atomic_t
67
*/
65
68
#include <errno.h> /* errno, EBADF */
69
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
70
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
71
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
72
#include <errno.h> /* errno */
73
#include <error.h> /* error() */
74
#include <fnmatch.h> /* fnmatch() */
66
75
67
76
#define BUFFER_SIZE 256
68
77
69
78
#define PDIR "/lib/mandos/plugins.d"
79
#define PHDIR "/lib/mandos/plugin-helpers"
70
80
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
71
81
72
const char *argp_program_version = "plugin-runner 1.0";
73
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
74
75
struct process;
76
77
typedef struct process{
78
pid_t pid;
79
int fd;
80
char *buffer;
81
size_t buffer_size;
82
size_t buffer_length;
83
bool eof;
84
volatile bool completed;
85
volatile int status;
86
struct process *next;
87
} process;
82
const char *argp_program_version = "plugin-runner " VERSION;
83
const char *argp_program_bug_address = "<mandos@recompile.se>";
88
84
89
85
typedef struct plugin{
90
86
char *name; /* can be NULL or any plugin name */
93
89
char **environ;
94
90
int envc;
95
91
bool disabled;
92
93
/* Variables used for running processes*/
94
pid_t pid;
95
int fd;
96
char *buffer;
97
size_t buffer_size;
98
size_t buffer_length;
99
bool eof;
100
volatile sig_atomic_t completed;
101
int status;
96
102
struct plugin *next;
97
103
} plugin;
98
104
99
static plugin *getplugin(char *name, plugin **plugin_list){
100
for (plugin *p = *plugin_list; p != NULL; p = p->next){
101
if ((p->name == name)
102
or (p->name and name and (strcmp(p->name, name) == 0))){
105
static plugin *plugin_list = NULL;
106
107
/* Gets an existing plugin based on name,
108
or if none is found, creates a new one */
109
__attribute__((warn_unused_result))
110
static plugin *getplugin(char *name){
111
/* Check for existing plugin with that name */
112
for(plugin *p = plugin_list; p != NULL; p = p->next){
113
if((p->name == name)
114
or (p->name and name and (strcmp(p->name, name) == 0))){
103
115
return p;
104
116
}
105
117
}
106
118
/* Create a new plugin */
107
plugin *new_plugin = malloc(sizeof(plugin));
108
if (new_plugin == NULL){
119
plugin *new_plugin = NULL;
120
do {
121
new_plugin = malloc(sizeof(plugin));
122
} while(new_plugin == NULL and errno == EINTR);
123
if(new_plugin == NULL){
109
124
return NULL;
110
125
}
111
126
char *copy_name = NULL;
112
127
if(name != NULL){
113
copy_name = strdup(name);
128
do {
129
copy_name = strdup(name);
130
} while(copy_name == NULL and errno == EINTR);
114
131
if(copy_name == NULL){
132
int e = errno;
133
free(new_plugin);
134
errno = e;
115
135
return NULL;
116
136
}
117
137
}
118
138
119
*new_plugin = (plugin) { .name = copy_name,
120
.argc = 1,
121
.envc = 0,
122
.disabled = false,
123
.next = *plugin_list };
139
*new_plugin = (plugin){ .name = copy_name,
140
.argc = 1,
141
.disabled = false,
142
.next = plugin_list };
124
143
125
new_plugin->argv = malloc(sizeof(char *) * 2);
126
if (new_plugin->argv == NULL){
144
do {
145
new_plugin->argv = malloc(sizeof(char *) * 2);
146
} while(new_plugin->argv == NULL and errno == EINTR);
147
if(new_plugin->argv == NULL){
148
int e = errno;
127
149
free(copy_name);
128
150
free(new_plugin);
151
errno = e;
129
152
return NULL;
130
153
}
131
154
new_plugin->argv[0] = copy_name;
132
155
new_plugin->argv[1] = NULL;
133
134
new_plugin->environ = malloc(sizeof(char *));
156
157
do {
158
new_plugin->environ = malloc(sizeof(char *));
159
} while(new_plugin->environ == NULL and errno == EINTR);
135
160
if(new_plugin->environ == NULL){
161
int e = errno;
136
162
free(copy_name);
137
163
free(new_plugin->argv);
138
164
free(new_plugin);
165
errno = e;
139
166
return NULL;
140
167
}
141
168
new_plugin->environ[0] = NULL;
169
142
170
/* Append the new plugin to the list */
143
*plugin_list = new_plugin;
171
plugin_list = new_plugin;
144
172
return new_plugin;
145
173
}
146
174
147
175
/* Helper function for add_argument and add_environment */
176
__attribute__((nonnull, warn_unused_result))
148
177
static bool add_to_char_array(const char *new, char ***array,
149
178
int *len){
150
179
/* Resize the pointed-to array to hold one more pointer */
151
*array = realloc(*array, sizeof(char *)
152
* (size_t) ((*len) + 2));
180
char **new_array = NULL;
181
do {
182
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
183
new_array = reallocarray(*array, (size_t)((*len) + 2),
184
sizeof(char *));
185
#else
186
if(((size_t)((*len) + 2)) > (SIZE_MAX / sizeof(char *))){
187
/* overflow */
188
new_array = NULL;
189
errno = ENOMEM;
190
} else {
191
new_array = realloc(*array, (size_t)((*len) + 2)
192
* sizeof(char *));
193
}
194
#endif
195
} while(new_array == NULL and errno == EINTR);
153
196
/* Malloc check */
154
if(*array == NULL){
197
if(new_array == NULL){
155
198
return false;
156
199
}
200
*array = new_array;
157
201
/* Make a copy of the new string */
158
char *copy = strdup(new);
202
char *copy;
203
do {
204
copy = strdup(new);
205
} while(copy == NULL and errno == EINTR);
159
206
if(copy == NULL){
160
207
return false;
161
208
}
168
215
}
169
216
170
217
/* Add to a plugin's argument vector */
218
__attribute__((nonnull(2), warn_unused_result))
171
219
static bool add_argument(plugin *p, const char *arg){
172
220
if(p == NULL){
173
221
return false;
176
224
}
177
225
178
226
/* Add to a plugin's environment */
179
static bool add_environment(plugin *p, const char *def){
227
__attribute__((nonnull(2), warn_unused_result))
228
static bool add_environment(plugin *p, const char *def, bool replace){
180
229
if(p == NULL){
181
230
return false;
182
231
}
232
/* namelen = length of name of environment variable */
233
size_t namelen = (size_t)(strchrnul(def, '=') - def);
234
/* Search for this environment variable */
235
for(char **envdef = p->environ; *envdef != NULL; envdef++){
236
if(strncmp(*envdef, def, namelen + 1) == 0){
237
/* It already exists */
238
if(replace){
239
char *new_envdef;
240
do {
241
new_envdef = realloc(*envdef, strlen(def) + 1);
242
} while(new_envdef == NULL and errno == EINTR);
243
if(new_envdef == NULL){
244
return false;
245
}
246
*envdef = new_envdef;
247
strcpy(*envdef, def);
248
}
249
return true;
250
}
251
}
183
252
return add_to_char_array(def, &(p->environ), &(p->envc));
184
253
}
185
254
186
255
#ifndef O_CLOEXEC
187
256
/*
188
257
* Based on the example in the GNU LibC manual chapter 13.13 "File
189
258
* Descriptor Flags".
190
* *Note File Descriptor Flags:(libc)Descriptor Flags.
259
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
191
260
*/
192
static int set_cloexec_flag(int fd)
193
{
194
int ret = fcntl(fd, F_GETFD, 0);
261
__attribute__((warn_unused_result))
262
static int set_cloexec_flag(int fd){
263
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
195
264
/* If reading the flags failed, return error indication now. */
196
265
if(ret < 0){
197
266
return ret;
198
267
}
199
268
/* Store modified flag word in the descriptor. */
200
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
269
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
270
ret | FD_CLOEXEC));
201
271
}
272
#endif /* not O_CLOEXEC */
202
273
203
process *process_list = NULL;
204
274
205
275
/* Mark processes as completed when they exit, and save their exit
206
276
status. */
207
void handle_sigchld(__attribute__((unused)) int sig){
277
static void handle_sigchld(__attribute__((unused)) int sig){
278
int old_errno = errno;
208
279
while(true){
209
process *proc = process_list;
280
plugin *proc = plugin_list;
210
281
int status;
211
282
pid_t pid = waitpid(-1, &status, WNOHANG);
212
283
if(pid == 0){
214
285
break;
215
286
}
216
287
if(pid == -1){
217
if (errno != ECHILD){
218
perror("waitpid");
288
if(errno == ECHILD){
289
/* No child processes */
290
break;
219
291
}
220
/* No child processes */
221
break;
292
error(0, errno, "waitpid");
222
293
}
223
294
224
295
/* A child exited, find it in process_list */
225
296
while(proc != NULL and proc->pid != pid){
226
297
proc = proc->next;
230
301
continue;
231
302
}
232
303
proc->status = status;
233
proc->completed = true;
304
proc->completed = 1;
234
305
}
306
errno = old_errno;
235
307
}
236
308
237
bool print_out_password(const char *buffer, size_t length){
309
/* Prints out a password to stdout */
310
__attribute__((nonnull, warn_unused_result))
311
static bool print_out_password(const char *buffer, size_t length){
238
312
ssize_t ret;
239
if(length>0 and buffer[length-1] == '\n'){
240
length--;
241
}
242
313
for(size_t written = 0; written < length; written += (size_t)ret){
243
314
ret = TEMP_FAILURE_RETRY(write(STDOUT_FILENO, buffer + written,
244
315
length - written));
249
320
return true;
250
321
}
251
322
252
static void free_plugin_list(plugin *plugin_list){
253
for(plugin *next; plugin_list != NULL; plugin_list = next){
254
next = plugin_list->next;
255
for(char **arg = plugin_list->argv; *arg != NULL; arg++){
256
free(*arg);
257
}
258
free(plugin_list->argv);
259
for(char **env = plugin_list->environ; *env != NULL; env++){
260
free(*env);
261
}
262
free(plugin_list->environ);
263
free(plugin_list);
323
/* Removes and free a plugin from the plugin list */
324
__attribute__((nonnull))
325
static void free_plugin(plugin *plugin_node){
326
327
for(char **arg = (plugin_node->argv)+1; *arg != NULL; arg++){
328
free(*arg);
329
}
330
free(plugin_node->name);
331
free(plugin_node->argv);
332
for(char **env = plugin_node->environ; *env != NULL; env++){
333
free(*env);
334
}
335
free(plugin_node->environ);
336
free(plugin_node->buffer);
337
338
/* Removes the plugin from the singly-linked list */
339
if(plugin_node == plugin_list){
340
/* First one - simple */
341
plugin_list = plugin_list->next;
342
} else {
343
/* Second one or later */
344
for(plugin *p = plugin_list; p != NULL; p = p->next){
345
if(p->next == plugin_node){
346
p->next = plugin_node->next;
347
break;
348
}
349
}
350
}
351
352
free(plugin_node);
353
}
354
355
static void free_plugin_list(void){
356
while(plugin_list != NULL){
357
free_plugin(plugin_list);
264
358
}
265
359
}
266
360
267
361
int main(int argc, char *argv[]){
268
362
char *plugindir = NULL;
363
char *pluginhelperdir = NULL;
269
364
char *argfile = NULL;
270
365
FILE *conffp;
271
size_t d_name_len;
272
DIR *dir = NULL;
273
struct dirent *dirst;
366
struct dirent **direntries = NULL;
274
367
struct stat st;
275
368
fd_set rfds_all;
276
369
int ret, maxfd = 0;
370
ssize_t sret;
277
371
uid_t uid = 65534;
278
372
gid_t gid = 65534;
279
373
bool debug = false;
283
377
.sa_flags = SA_NOCLDSTOP };
284
378
char **custom_argv = NULL;
285
379
int custom_argc = 0;
380
int dir_fd = -1;
286
381
287
382
/* Establish a signal handler */
288
383
sigemptyset(&sigchld_action.sa_mask);
289
384
ret = sigaddset(&sigchld_action.sa_mask, SIGCHLD);
290
385
if(ret == -1){
291
perror("sigaddset");
292
exitstatus = EXIT_FAILURE;
386
error(0, errno, "sigaddset");
387
exitstatus = EX_OSERR;
293
388
goto fallback;
294
389
}
295
390
ret = sigaction(SIGCHLD, &sigchld_action, &old_sigchld_action);
296
391
if(ret == -1){
297
perror("sigaction");
298
exitstatus = EXIT_FAILURE;
392
error(0, errno, "sigaction");
393
exitstatus = EX_OSERR;
299
394
goto fallback;
300
395
}
301
396
304
399
{ .name = "global-options", .key = 'g',
305
400
.arg = "OPTION[,OPTION[,...]]",
306
401
.doc = "Options passed to all plugins" },
307
{ .name = "global-envs", .key = 'e',
402
{ .name = "global-env", .key = 'G',
308
403
.arg = "VAR=value",
309
404
.doc = "Environment variable passed to all plugins" },
310
405
{ .name = "options-for", .key = 'o',
311
406
.arg = "PLUGIN:OPTION[,OPTION[,...]]",
312
407
.doc = "Options passed only to specified plugin" },
313
{ .name = "envs-for", .key = 'f',
408
{ .name = "env-for", .key = 'E',
314
409
.arg = "PLUGIN:ENV=value",
315
410
.doc = "Environment variable passed to specified plugin" },
316
411
{ .name = "disable", .key = 'd',
317
412
.arg = "PLUGIN",
318
413
.doc = "Disable a specific plugin", .group = 1 },
414
{ .name = "enable", .key = 'e',
415
.arg = "PLUGIN",
416
.doc = "Enable a specific plugin", .group = 1 },
319
417
{ .name = "plugin-dir", .key = 128,
320
418
.arg = "DIRECTORY",
321
419
.doc = "Specify a different plugin directory", .group = 2 },
330
428
.doc = "Group ID the plugins will run as", .group = 3 },
331
429
{ .name = "debug", .key = 132,
332
430
.doc = "Debug mode", .group = 4 },
431
{ .name = "plugin-helper-dir", .key = 133,
432
.arg = "DIRECTORY",
433
.doc = "Specify a different plugin helper directory",
434
.group = 2 },
435
/*
436
* These reproduce what we would get without ARGP_NO_HELP
437
*/
438
{ .name = "help", .key = '?',
439
.doc = "Give this help list", .group = -1 },
440
{ .name = "usage", .key = -3,
441
.doc = "Give a short usage message", .group = -1 },
442
{ .name = "version", .key = 'V',
443
.doc = "Print program version", .group = -1 },
333
444
{ .name = NULL }
334
445
};
335
446
336
error_t parse_opt (int key, char *arg, struct argp_state *state) {
337
/* Get the INPUT argument from `argp_parse', which we know is a
338
pointer to our plugin list pointer. */
339
plugin **plugins = state->input;
340
switch (key) {
341
case 'g':
342
if (arg != NULL){
343
char *p;
344
while((p = strsep(&arg, ",")) != NULL){
345
if(p[0] == '\0'){
346
continue;
347
}
348
if(not add_argument(getplugin(NULL, plugins), p)){
349
perror("add_argument");
350
return ARGP_ERR_UNKNOWN;
351
}
352
}
353
}
354
break;
355
case 'e':
356
if(arg == NULL){
357
break;
358
}
359
{
360
char *envdef = strdup(arg);
361
if(envdef == NULL){
362
break;
363
}
364
if(not add_environment(getplugin(NULL, plugins), envdef)){
365
perror("add_environment");
366
}
367
}
368
break;
369
case 'o':
370
if (arg != NULL){
371
char *p_name = strsep(&arg, ":");
372
if(p_name[0] == '\0'){
373
break;
374
}
375
char *opt = strsep(&arg, ":");
376
if(opt[0] == '\0'){
377
break;
378
}
379
if(opt != NULL){
380
char *p;
381
while((p = strsep(&opt, ",")) != NULL){
382
if(p[0] == '\0'){
383
continue;
384
}
385
if(not add_argument(getplugin(p_name, plugins), p)){
386
perror("add_argument");
387
return ARGP_ERR_UNKNOWN;
388
}
389
}
390
}
391
}
392
break;
393
case 'f':
394
if(arg == NULL){
395
break;
396
}
447
__attribute__((nonnull(3)))
448
error_t parse_opt(int key, char *arg, struct argp_state *state){
449
errno = 0;
450
switch(key){
451
char *tmp;
452
intmax_t tmp_id;
453
case 'g': /* --global-options */
454
{
455
char *plugin_option;
456
while((plugin_option = strsep(&arg, ",")) != NULL){
457
if(not add_argument(getplugin(NULL), plugin_option)){
458
break;
459
}
460
}
461
errno = 0;
462
}
463
break;
464
case 'G': /* --global-env */
465
if(add_environment(getplugin(NULL), arg, true)){
466
errno = 0;
467
}
468
break;
469
case 'o': /* --options-for */
470
{
471
char *option_list = strchr(arg, ':');
472
if(option_list == NULL){
473
argp_error(state, "No colon in \"%s\"", arg);
474
errno = EINVAL;
475
break;
476
}
477
*option_list = '\0';
478
option_list++;
479
if(arg[0] == '\0'){
480
argp_error(state, "Empty plugin name");
481
errno = EINVAL;
482
break;
483
}
484
char *option;
485
while((option = strsep(&option_list, ",")) != NULL){
486
if(not add_argument(getplugin(arg), option)){
487
break;
488
}
489
}
490
errno = 0;
491
}
492
break;
493
case 'E': /* --env-for */
397
494
{
398
495
char *envdef = strchr(arg, ':');
399
496
if(envdef == NULL){
400
break;
401
}
402
char *p_name = strndup(arg, (size_t) (envdef-arg));
403
if(p_name == NULL){
404
break;
405
}
497
argp_error(state, "No colon in \"%s\"", arg);
498
errno = EINVAL;
499
break;
500
}
501
*envdef = '\0';
406
502
envdef++;
407
if(not add_environment(getplugin(p_name, plugins), envdef)){
408
perror("add_environment");
409
}
410
}
411
break;
412
case 'd':
413
if (arg != NULL){
414
plugin *p = getplugin(arg, plugins);
415
if(p == NULL){
416
return ARGP_ERR_UNKNOWN;
417
}
418
p->disabled = true;
419
}
420
break;
421
case 128:
503
if(arg[0] == '\0'){
504
argp_error(state, "Empty plugin name");
505
errno = EINVAL;
506
break;
507
}
508
if(add_environment(getplugin(arg), envdef, true)){
509
errno = 0;
510
}
511
}
512
break;
513
case 'd': /* --disable */
514
{
515
plugin *p = getplugin(arg);
516
if(p != NULL){
517
p->disabled = true;
518
errno = 0;
519
}
520
}
521
break;
522
case 'e': /* --enable */
523
{
524
plugin *p = getplugin(arg);
525
if(p != NULL){
526
p->disabled = false;
527
errno = 0;
528
}
529
}
530
break;
531
case 128: /* --plugin-dir */
532
free(plugindir);
422
533
plugindir = strdup(arg);
423
if(plugindir == NULL){
424
perror("strdup");
425
}
426
break;
427
case 129:
534
if(plugindir != NULL){
535
errno = 0;
536
}
537
break;
538
case 129: /* --config-file */
539
/* This is already done by parse_opt_config_file() */
540
break;
541
case 130: /* --userid */
542
tmp_id = strtoimax(arg, &tmp, 10);
543
if(errno != 0 or tmp == arg or *tmp != '\0'
544
or tmp_id != (uid_t)tmp_id){
545
argp_error(state, "Bad user ID number: \"%s\", using %"
546
PRIdMAX, arg, (intmax_t)uid);
547
break;
548
}
549
uid = (uid_t)tmp_id;
550
errno = 0;
551
break;
552
case 131: /* --groupid */
553
tmp_id = strtoimax(arg, &tmp, 10);
554
if(errno != 0 or tmp == arg or *tmp != '\0'
555
or tmp_id != (gid_t)tmp_id){
556
argp_error(state, "Bad group ID number: \"%s\", using %"
557
PRIdMAX, arg, (intmax_t)gid);
558
break;
559
}
560
gid = (gid_t)tmp_id;
561
errno = 0;
562
break;
563
case 132: /* --debug */
564
debug = true;
565
break;
566
case 133: /* --plugin-helper-dir */
567
free(pluginhelperdir);
568
pluginhelperdir = strdup(arg);
569
if(pluginhelperdir != NULL){
570
errno = 0;
571
}
572
break;
573
/*
574
* These reproduce what we would get without ARGP_NO_HELP
575
*/
576
case '?': /* --help */
577
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
578
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
579
__builtin_unreachable();
580
case -3: /* --usage */
581
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
582
argp_state_help(state, state->out_stream,
583
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
584
__builtin_unreachable();
585
case 'V': /* --version */
586
fprintf(state->out_stream, "%s\n", argp_program_version);
587
exit(EXIT_SUCCESS);
588
break;
589
/*
590
* When adding more options before this line, remember to also add a
591
* "case" to the "parse_opt_config_file" function below.
592
*/
593
case ARGP_KEY_ARG:
594
/* Cryptsetup always passes an argument, which is an empty
595
string if "none" was specified in /etc/crypttab. So if
596
argument was empty, we ignore it silently. */
597
if(arg[0] == '\0'){
598
break;
599
}
600
#if __GNUC__ >= 7
601
__attribute__((fallthrough));
602
#else
603
/* FALLTHROUGH */
604
#endif
605
default:
606
return ARGP_ERR_UNKNOWN;
607
}
608
return errno; /* Set to 0 at start */
609
}
610
611
/* This option parser is the same as parse_opt() above, except it
612
ignores everything but the --config-file option. */
613
error_t parse_opt_config_file(int key, char *arg,
614
__attribute__((unused))
615
struct argp_state *state){
616
errno = 0;
617
switch(key){
618
case 'g': /* --global-options */
619
case 'G': /* --global-env */
620
case 'o': /* --options-for */
621
case 'E': /* --env-for */
622
case 'd': /* --disable */
623
case 'e': /* --enable */
624
case 128: /* --plugin-dir */
625
break;
626
case 129: /* --config-file */
627
free(argfile);
428
628
argfile = strdup(arg);
429
if(argfile == NULL){
430
perror("strdup");
629
if(argfile != NULL){
630
errno = 0;
431
631
}
432
break;
433
case 130:
434
uid = (uid_t)strtol(arg, NULL, 10);
435
break;
436
case 131:
437
gid = (gid_t)strtol(arg, NULL, 10);
438
break;
439
case 132:
440
debug = true;
441
break;
632
break;
633
case 130: /* --userid */
634
case 131: /* --groupid */
635
case 132: /* --debug */
636
case 133: /* --plugin-helper-dir */
637
case '?': /* --help */
638
case -3: /* --usage */
639
case 'V': /* --version */
442
640
case ARGP_KEY_ARG:
443
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
444
break;
445
case ARGP_KEY_END:
446
641
break;
447
642
default:
448
643
return ARGP_ERR_UNKNOWN;
449
644
}
450
return 0;
645
return errno;
451
646
}
452
647
453
plugin *plugin_list = NULL;
454
455
struct argp argp = { .options = options, .parser = parse_opt,
456
.args_doc = "[+PLUS_SEPARATED_OPTIONS]",
648
struct argp argp = { .options = options,
649
.parser = parse_opt_config_file,
650
.args_doc = "",
457
651
.doc = "Mandos plugin runner -- Run plugins" };
458
652
459
ret = argp_parse (&argp, argc, argv, 0, 0, &plugin_list);
460
if (ret == ARGP_ERR_UNKNOWN){
461
fprintf(stderr, "Unknown error while parsing arguments\n");
462
exitstatus = EXIT_FAILURE;
653
/* Parse using parse_opt_config_file() in order to get the custom
654
config file location, if any. */
655
ret = argp_parse(&argp, argc, argv,
656
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
657
NULL, NULL);
658
switch(ret){
659
case 0:
660
break;
661
case ENOMEM:
662
default:
663
errno = ret;
664
error(0, errno, "argp_parse");
665
exitstatus = EX_OSERR;
666
goto fallback;
667
case EINVAL:
668
exitstatus = EX_USAGE;
463
669
goto fallback;
464
670
}
465
466
if (argfile == NULL){
671
672
/* Reset to the normal argument parser */
673
argp.parser = parse_opt;
674
675
/* Open the configfile if available */
676
if(argfile == NULL){
467
677
conffp = fopen(AFILE, "r");
468
678
} else {
469
679
conffp = fopen(argfile, "r");
470
680
}
471
472
681
if(conffp != NULL){
473
682
char *org_line = NULL;
474
683
char *p, *arg, *new_arg, *line;
475
684
size_t size = 0;
476
ssize_t sret;
477
685
const char whitespace_delims[] = " \r\t\f\v\n";
478
686
const char comment_delim[] = "#";
479
687
480
688
custom_argc = 1;
481
689
custom_argv = malloc(sizeof(char*) * 2);
482
690
if(custom_argv == NULL){
483
perror("malloc");
484
exitstatus = EXIT_FAILURE;
691
error(0, errno, "malloc");
692
exitstatus = EX_OSERR;
485
693
goto fallback;
486
694
}
487
695
custom_argv[0] = argv[0];
488
696
custom_argv[1] = NULL;
489
697
698
/* for each line in the config file, strip whitespace and ignore
699
commented text */
490
700
while(true){
491
701
sret = getline(&org_line, &size, conffp);
492
702
if(sret == -1){
493
703
break;
494
704
}
495
705
496
706
line = org_line;
497
707
arg = strsep(&line, comment_delim);
498
708
while((p = strsep(&arg, whitespace_delims)) != NULL){
501
711
}
502
712
new_arg = strdup(p);
503
713
if(new_arg == NULL){
504
perror("strdup");
505
exitstatus = EXIT_FAILURE;
714
error(0, errno, "strdup");
715
exitstatus = EX_OSERR;
506
716
free(org_line);
507
717
goto fallback;
508
718
}
509
719
510
720
custom_argc += 1;
511
custom_argv = realloc(custom_argv, sizeof(char *)
512
* ((unsigned int) custom_argc + 1));
513
if(custom_argv == NULL){
514
perror("realloc");
515
exitstatus = EXIT_FAILURE;
516
free(org_line);
517
goto fallback;
721
{
722
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
723
char **new_argv = reallocarray(custom_argv, (size_t)custom_argc + 1,
724
sizeof(char *));
725
#else
726
char **new_argv = NULL;
727
if(((size_t)custom_argc + 1) > (SIZE_MAX / sizeof(char *))){
728
/* overflow */
729
errno = ENOMEM;
730
} else {
731
new_argv = realloc(custom_argv, ((size_t)custom_argc + 1)
732
* sizeof(char *));
733
}
734
#endif
735
if(new_argv == NULL){
736
error(0, errno, "reallocarray");
737
exitstatus = EX_OSERR;
738
free(new_arg);
739
free(org_line);
740
goto fallback;
741
} else {
742
custom_argv = new_argv;
743
}
518
744
}
519
745
custom_argv[custom_argc-1] = new_arg;
520
custom_argv[custom_argc] = NULL;
746
custom_argv[custom_argc] = NULL;
521
747
}
522
748
}
749
do {
750
ret = fclose(conffp);
751
} while(ret == EOF and errno == EINTR);
752
if(ret == EOF){
753
error(0, errno, "fclose");
754
exitstatus = EX_IOERR;
755
goto fallback;
756
}
523
757
free(org_line);
524
} else{
758
} else {
525
759
/* Check for harmful errors and go to fallback. Other errors might
526
760
not affect opening plugins */
527
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
528
perror("fopen");
529
exitstatus = EXIT_FAILURE;
761
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
762
error(0, errno, "fopen");
763
exitstatus = EX_OSERR;
530
764
goto fallback;
531
765
}
532
766
}
533
767
/* If there were any arguments from the configuration file, pass
768
them to parser as command line arguments */
534
769
if(custom_argv != NULL){
535
ret = argp_parse (&argp, custom_argc, custom_argv, 0, 0, &plugin_list);
536
if (ret == ARGP_ERR_UNKNOWN){
537
fprintf(stderr, "Unknown error while parsing arguments\n");
538
exitstatus = EXIT_FAILURE;
539
goto fallback;
770
ret = argp_parse(&argp, custom_argc, custom_argv,
771
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
772
NULL, NULL);
773
switch(ret){
774
case 0:
775
break;
776
case ENOMEM:
777
default:
778
errno = ret;
779
error(0, errno, "argp_parse");
780
exitstatus = EX_OSERR;
781
goto fallback;
782
case EINVAL:
783
exitstatus = EX_CONFIG;
784
goto fallback;
785
}
786
}
787
788
/* Parse actual command line arguments, to let them override the
789
config file */
790
ret = argp_parse(&argp, argc, argv,
791
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
792
NULL, NULL);
793
switch(ret){
794
case 0:
795
break;
796
case ENOMEM:
797
default:
798
errno = ret;
799
error(0, errno, "argp_parse");
800
exitstatus = EX_OSERR;
801
goto fallback;
802
case EINVAL:
803
exitstatus = EX_USAGE;
804
goto fallback;
805
}
806
807
{
808
char *pluginhelperenv;
809
bool bret = true;
810
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
811
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
812
if(ret != -1){
813
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
814
}
815
if(ret == -1 or not bret){
816
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
817
" environment variable to \"%s\" for all plugins\n",
818
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
819
}
820
if(ret != -1){
821
free(pluginhelperenv);
540
822
}
541
823
}
542
824
543
825
if(debug){
544
for(plugin *p = plugin_list; p != NULL; p=p->next){
826
for(plugin *p = plugin_list; p != NULL; p = p->next){
545
827
fprintf(stderr, "Plugin: %s has %d arguments\n",
546
828
p->name ? p->name : "Global", p->argc - 1);
547
829
for(char **a = p->argv; *a != NULL; a++){
548
830
fprintf(stderr, "\tArg: %s\n", *a);
549
831
}
550
fprintf(stderr, "...and %u environment variables\n", p->envc);
832
fprintf(stderr, "...and %d environment variables\n", p->envc);
551
833
for(char **a = p->environ; *a != NULL; a++){
552
834
fprintf(stderr, "\t%s\n", *a);
553
835
}
554
836
}
555
837
}
556
838
839
if(getuid() == 0){
840
/* Work around Debian bug #633582:
841
<https://bugs.debian.org/633582> */
842
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
843
if(plugindir_fd == -1){
844
if(errno != ENOENT){
845
error(0, errno, "open(\"" PDIR "\")");
846
}
847
} else {
848
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
849
if(ret == -1){
850
error(0, errno, "fstat");
851
} else {
852
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
853
ret = fchown(plugindir_fd, uid, gid);
854
if(ret == -1){
855
error(0, errno, "fchown");
856
}
857
}
858
}
859
close(plugindir_fd);
860
}
861
}
862
863
/* Lower permissions */
864
ret = setgid(gid);
865
if(ret == -1){
866
error(0, errno, "setgid");
867
}
557
868
ret = setuid(uid);
558
if (ret == -1){
559
perror("setuid");
560
}
561
562
setgid(gid);
563
if (ret == -1){
564
perror("setgid");
565
}
566
567
if (plugindir == NULL){
568
dir = opendir(PDIR);
569
} else {
570
dir = opendir(plugindir);
571
}
572
573
if(dir == NULL){
574
perror("Could not open plugin dir");
575
exitstatus = EXIT_FAILURE;
576
goto fallback;
577
}
578
579
/* Set the FD_CLOEXEC flag on the directory, if possible */
869
if(ret == -1){
870
error(0, errno, "setuid");
871
}
872
873
/* Open plugin directory with close_on_exec flag */
580
874
{
581
int dir_fd = dirfd(dir);
582
if(dir_fd >= 0){
583
ret = set_cloexec_flag(dir_fd);
584
if(ret < 0){
585
perror("set_cloexec_flag");
586
exitstatus = EXIT_FAILURE;
587
goto fallback;
875
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
876
#ifdef O_CLOEXEC
877
O_CLOEXEC
878
#else /* not O_CLOEXEC */
879
0
880
#endif /* not O_CLOEXEC */
881
);
882
if(dir_fd == -1){
883
error(0, errno, "Could not open plugin dir");
884
exitstatus = EX_UNAVAILABLE;
885
goto fallback;
886
}
887
888
#ifndef O_CLOEXEC
889
/* Set the FD_CLOEXEC flag on the directory */
890
ret = set_cloexec_flag(dir_fd);
891
if(ret < 0){
892
error(0, errno, "set_cloexec_flag");
893
exitstatus = EX_OSERR;
894
goto fallback;
895
}
896
#endif /* O_CLOEXEC */
897
}
898
899
int good_name(const struct dirent * const dirent){
900
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
901
"*.dpkg-old", "*.dpkg-bak",
902
"*.dpkg-divert", NULL };
903
#ifdef __GNUC__
904
#pragma GCC diagnostic push
905
#pragma GCC diagnostic ignored "-Wcast-qual"
906
#endif
907
for(const char **pat = (const char **)patterns;
908
*pat != NULL; pat++){
909
#ifdef __GNUC__
910
#pragma GCC diagnostic pop
911
#endif
912
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
913
!= FNM_NOMATCH){
914
if(debug){
915
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
916
" matching pattern %s\n", dirent->d_name, *pat);
917
}
918
return 0;
588
919
}
589
920
}
921
return 1;
922
}
923
924
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
925
alphasort);
926
if(numplugins == -1){
927
error(0, errno, "Could not scan plugin dir");
928
direntries = NULL;
929
exitstatus = EX_OSERR;
930
goto fallback;
590
931
}
591
932
592
933
FD_ZERO(&rfds_all);
593
934
594
while(true){
595
dirst = readdir(dir);
596
597
// All directory entries have been processed
598
if(dirst == NULL){
599
if (errno == EBADF){
600
perror("readdir");
601
exitstatus = EXIT_FAILURE;
602
goto fallback;
603
}
604
break;
605
}
606
607
d_name_len = strlen(dirst->d_name);
608
609
// Ignore dotfiles, backup files and other junk
610
{
611
bool bad_name = false;
612
613
const char const *bad_prefixes[] = { ".", "#", NULL };
614
615
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
616
".dpkg-old",
617
".dpkg-divert", NULL };
618
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
619
size_t pre_len = strlen(*pre);
620
if((d_name_len >= pre_len)
621
and strncmp((dirst->d_name), *pre, pre_len) == 0){
622
if(debug){
623
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
624
" with bad prefix %s\n", dirst->d_name, *pre);
625
}
626
bad_name = true;
627
break;
628
}
629
}
630
631
if(bad_name){
632
continue;
633
}
634
635
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
636
size_t suf_len = strlen(*suf);
637
if((d_name_len >= suf_len)
638
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
639
== 0)){
640
if(debug){
641
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
642
" with bad suffix %s\n", dirst->d_name, *suf);
643
}
644
bad_name = true;
645
break;
646
}
647
}
648
649
if(bad_name){
650
continue;
651
}
652
}
653
654
char *filename;
655
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
656
if(ret < 0){
657
perror("asprintf");
658
continue;
659
}
660
661
ret = stat(filename, &st);
662
if (ret == -1){
663
perror("stat");
664
free(filename);
665
continue;
666
}
667
668
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
935
/* Read and execute any executable in the plugin directory*/
936
for(int i = 0; i < numplugins; i++){
937
938
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
939
if(plugin_fd == -1){
940
error(0, errno, "Could not open plugin");
941
free(direntries[i]);
942
continue;
943
}
944
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
945
if(ret == -1){
946
error(0, errno, "stat");
947
close(plugin_fd);
948
free(direntries[i]);
949
continue;
950
}
951
952
/* Ignore non-executable files */
953
if(not S_ISREG(st.st_mode)
954
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
955
X_OK, 0)) != 0)){
669
956
if(debug){
670
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
671
" with bad type or mode\n", filename);
957
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
958
" with bad type or mode\n",
959
plugindir != NULL ? plugindir : PDIR,
960
direntries[i]->d_name);
672
961
}
673
free(filename);
962
close(plugin_fd);
963
free(direntries[i]);
674
964
continue;
675
965
}
676
plugin *p = getplugin(dirst->d_name, &plugin_list);
966
967
plugin *p = getplugin(direntries[i]->d_name);
677
968
if(p == NULL){
678
perror("getplugin");
679
free(filename);
969
error(0, errno, "getplugin");
970
close(plugin_fd);
971
free(direntries[i]);
680
972
continue;
681
973
}
682
974
if(p->disabled){
683
975
if(debug){
684
976
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
685
dirst->d_name);
977
direntries[i]->d_name);
686
978
}
687
free(filename);
979
close(plugin_fd);
980
free(direntries[i]);
688
981
continue;
689
982
}
690
983
{
691
984
/* Add global arguments to argument list for this plugin */
692
plugin *g = getplugin(NULL, &plugin_list);
985
plugin *g = getplugin(NULL);
693
986
if(g != NULL){
694
987
for(char **a = g->argv + 1; *a != NULL; a++){
695
988
if(not add_argument(p, *a)){
696
perror("add_argument");
989
error(0, errno, "add_argument");
697
990
}
698
991
}
699
992
/* Add global environment variables */
700
993
for(char **e = g->environ; *e != NULL; e++){
701
if(not add_environment(p, *e)){
702
perror("add_environment");
994
if(not add_environment(p, *e, false)){
995
error(0, errno, "add_environment");
703
996
}
704
997
}
705
998
}
706
999
}
707
/* If this plugin has any environment variables, we will call
708
using execve and need to duplicate the environment from this
709
process, too. */
1000
/* If this plugin has any environment variables, we need to
1001
duplicate the environment from this process, too. */
710
1002
if(p->environ[0] != NULL){
711
1003
for(char **e = environ; *e != NULL; e++){
712
char *copy = strdup(*e);
713
if(copy == NULL){
714
perror("strdup");
715
continue;
716
}
717
if(not add_environment(p, copy)){
718
perror("add_environment");
1004
if(not add_environment(p, *e, false)){
1005
error(0, errno, "add_environment");
719
1006
}
720
1007
}
721
1008
}
722
1009
723
1010
int pipefd[2];
724
ret = pipe(pipefd);
725
if (ret == -1){
726
perror("pipe");
727
exitstatus = EXIT_FAILURE;
728
goto fallback;
729
}
1011
#ifndef O_CLOEXEC
1012
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1013
#else /* O_CLOEXEC */
1014
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
1015
#endif /* O_CLOEXEC */
1016
if(ret == -1){
1017
error(0, errno, "pipe");
1018
exitstatus = EX_OSERR;
1019
free(direntries[i]);
1020
goto fallback;
1021
}
1022
if(pipefd[0] >= FD_SETSIZE){
1023
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1024
FD_SETSIZE);
1025
close(pipefd[0]);
1026
close(pipefd[1]);
1027
exitstatus = EX_OSERR;
1028
free(direntries[i]);
1029
goto fallback;
1030
}
1031
#ifndef O_CLOEXEC
1032
/* Ask OS to automatic close the pipe on exec */
730
1033
ret = set_cloexec_flag(pipefd[0]);
731
1034
if(ret < 0){
732
perror("set_cloexec_flag");
733
exitstatus = EXIT_FAILURE;
1035
error(0, errno, "set_cloexec_flag");
1036
close(pipefd[0]);
1037
close(pipefd[1]);
1038
exitstatus = EX_OSERR;
1039
free(direntries[i]);
734
1040
goto fallback;
735
1041
}
736
1042
ret = set_cloexec_flag(pipefd[1]);
737
1043
if(ret < 0){
738
perror("set_cloexec_flag");
739
exitstatus = EXIT_FAILURE;
1044
error(0, errno, "set_cloexec_flag");
1045
close(pipefd[0]);
1046
close(pipefd[1]);
1047
exitstatus = EX_OSERR;
1048
free(direntries[i]);
740
1049
goto fallback;
741
1050
}
1051
#endif /* not O_CLOEXEC */
742
1052
/* Block SIGCHLD until process is safely in process list */
743
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1053
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1054
&sigchld_action.sa_mask,
1055
NULL));
744
1056
if(ret < 0){
745
perror("sigprocmask");
746
exitstatus = EXIT_FAILURE;
1057
error(0, errno, "sigprocmask");
1058
exitstatus = EX_OSERR;
1059
free(direntries[i]);
747
1060
goto fallback;
748
1061
}
749
// Starting a new process to be watched
750
pid_t pid = fork();
1062
/* Starting a new process to be watched */
1063
pid_t pid;
1064
do {
1065
pid = fork();
1066
} while(pid == -1 and errno == EINTR);
751
1067
if(pid == -1){
752
perror("fork");
753
exitstatus = EXIT_FAILURE;
1068
error(0, errno, "fork");
1069
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1070
&sigchld_action.sa_mask, NULL));
1071
close(pipefd[0]);
1072
close(pipefd[1]);
1073
exitstatus = EX_OSERR;
1074
free(direntries[i]);
754
1075
goto fallback;
755
1076
}
756
1077
if(pid == 0){
757
1078
/* this is the child process */
758
1079
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
759
1080
if(ret < 0){
760
perror("sigaction");
761
_exit(EXIT_FAILURE);
1081
error(0, errno, "sigaction");
1082
_exit(EX_OSERR);
762
1083
}
763
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1084
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
764
1085
if(ret < 0){
765
perror("sigprocmask");
766
_exit(EXIT_FAILURE);
1086
error(0, errno, "sigprocmask");
1087
_exit(EX_OSERR);
767
1088
}
768
1089
769
1090
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
770
1091
if(ret == -1){
771
perror("dup2");
772
_exit(EXIT_FAILURE);
1092
error(0, errno, "dup2");
1093
_exit(EX_OSERR);
773
1094
}
774
1095
775
if(dirfd(dir) < 0){
776
/* If dir has no file descriptor, we could not set FD_CLOEXEC
777
above and must now close it manually here. */
778
closedir(dir);
779
}
780
if(p->environ[0] == NULL){
781
if(execv(filename, p->argv) < 0){
782
perror("execv");
783
_exit(EXIT_FAILURE);
784
}
785
} else {
786
if(execve(filename, p->argv, p->environ) < 0){
787
perror("execve");
788
_exit(EXIT_FAILURE);
789
}
1096
if(fexecve(plugin_fd, p->argv,
1097
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1098
error(0, errno, "fexecve for %s/%s",
1099
plugindir != NULL ? plugindir : PDIR,
1100
direntries[i]->d_name);
1101
_exit(EX_OSERR);
790
1102
}
791
1103
/* no return */
792
1104
}
793
/* parent process */
794
free(filename);
795
close(pipefd[1]); /* close unused write end of pipe */
796
process *new_process = malloc(sizeof(process));
797
if (new_process == NULL){
798
perror("malloc");
799
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1105
/* Parent process */
1106
close(pipefd[1]); /* Close unused write end of pipe */
1107
close(plugin_fd);
1108
plugin *new_plugin = getplugin(direntries[i]->d_name);
1109
if(new_plugin == NULL){
1110
error(0, errno, "getplugin");
1111
ret = (int)(TEMP_FAILURE_RETRY
1112
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
1113
NULL)));
800
1114
if(ret < 0){
801
perror("sigprocmask");
1115
error(0, errno, "sigprocmask");
802
1116
}
803
exitstatus = EXIT_FAILURE;
1117
exitstatus = EX_OSERR;
1118
free(direntries[i]);
804
1119
goto fallback;
805
1120
}
1121
free(direntries[i]);
806
1122
807
*new_process = (struct process){ .pid = pid,
808
.fd = pipefd[0],
809
.next = process_list };
810
// List handling
811
process_list = new_process;
1123
new_plugin->pid = pid;
1124
new_plugin->fd = pipefd[0];
1125
1126
if(debug){
1127
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1128
new_plugin->name, (intmax_t) (new_plugin->pid));
1129
}
1130
812
1131
/* Unblock SIGCHLD so signal handler can be run if this process
813
1132
has already completed */
814
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1133
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1134
&sigchld_action.sa_mask,
1135
NULL));
815
1136
if(ret < 0){
816
perror("sigprocmask");
817
exitstatus = EXIT_FAILURE;
1137
error(0, errno, "sigprocmask");
1138
exitstatus = EX_OSERR;
818
1139
goto fallback;
819
1140
}
820
1141
821
FD_SET(new_process->fd, &rfds_all);
822
823
if (maxfd < new_process->fd){
824
maxfd = new_process->fd;
825
}
826
827
}
828
829
free_plugin_list(plugin_list);
830
plugin_list = NULL;
831
832
closedir(dir);
833
dir = NULL;
834
835
if (process_list == NULL){
836
fprintf(stderr, "No plugin processes started. Incorrect plugin"
837
" directory?\n");
838
process_list = NULL;
839
}
840
while(process_list){
1142
FD_SET(new_plugin->fd, &rfds_all);
1143
1144
if(maxfd < new_plugin->fd){
1145
maxfd = new_plugin->fd;
1146
}
1147
}
1148
1149
free(direntries);
1150
direntries = NULL;
1151
close(dir_fd);
1152
dir_fd = -1;
1153
free_plugin(getplugin(NULL));
1154
1155
for(plugin *p = plugin_list; p != NULL; p = p->next){
1156
if(p->pid != 0){
1157
break;
1158
}
1159
if(p->next == NULL){
1160
fprintf(stderr, "No plugin processes started. Incorrect plugin"
1161
" directory?\n");
1162
free_plugin_list();
1163
}
1164
}
1165
1166
/* Main loop while running plugins exist */
1167
while(plugin_list){
841
1168
fd_set rfds = rfds_all;
842
1169
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
843
if (select_ret == -1){
844
perror("select");
845
exitstatus = EXIT_FAILURE;
1170
if(select_ret == -1 and errno != EINTR){
1171
error(0, errno, "select");
1172
exitstatus = EX_OSERR;
846
1173
goto fallback;
847
1174
}
848
1175
/* OK, now either a process completed, or something can be read
849
1176
from one of them */
850
for(process *proc = process_list; proc ; proc = proc->next){
1177
for(plugin *proc = plugin_list; proc != NULL;){
851
1178
/* Is this process completely done? */
852
if(proc->eof and proc->completed){
1179
if(proc->completed and proc->eof){
853
1180
/* Only accept the plugin output if it exited cleanly */
854
1181
if(not WIFEXITED(proc->status)
855
1182
or WEXITSTATUS(proc->status) != 0){
856
1183
/* Bad exit by plugin */
1184
857
1185
if(debug){
858
1186
if(WIFEXITED(proc->status)){
859
fprintf(stderr, "Plugin %u exited with status %d\n",
860
(unsigned int) (proc->pid),
1187
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1188
" status %d\n", proc->name,
1189
(intmax_t) (proc->pid),
861
1190
WEXITSTATUS(proc->status));
862
} else if(WIFSIGNALED(proc->status)) {
863
fprintf(stderr, "Plugin %u killed by signal %d\n",
864
(unsigned int) (proc->pid),
865
WTERMSIG(proc->status));
866
} else if(WCOREDUMP(proc->status)){
867
fprintf(stderr, "Plugin %d dumped core\n",
868
(unsigned int) (proc->pid));
1191
} else if(WIFSIGNALED(proc->status)){
1192
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1193
" signal %d: %s\n", proc->name,
1194
(intmax_t) (proc->pid),
1195
WTERMSIG(proc->status),
1196
strsignal(WTERMSIG(proc->status)));
869
1197
}
870
1198
}
1199
871
1200
/* Remove the plugin */
872
1201
FD_CLR(proc->fd, &rfds_all);
1202
873
1203
/* Block signal while modifying process_list */
874
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1204
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1205
(SIG_BLOCK,
1206
&sigchld_action.sa_mask,
1207
NULL));
875
1208
if(ret < 0){
876
perror("sigprocmask");
877
exitstatus = EXIT_FAILURE;
1209
error(0, errno, "sigprocmask");
1210
exitstatus = EX_OSERR;
878
1211
goto fallback;
879
1212
}
880
/* Delete this process entry from the list */
881
if(process_list == proc){
882
/* First one - simple */
883
process_list = proc->next;
884
} else {
885
/* Second one or later */
886
for(process *p = process_list; p != NULL; p = p->next){
887
if(p->next == proc){
888
p->next = proc->next;
889
break;
890
}
891
}
892
}
1213
1214
plugin *next_plugin = proc->next;
1215
free_plugin(proc);
1216
proc = next_plugin;
1217
893
1218
/* We are done modifying process list, so unblock signal */
894
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,
895
NULL);
1219
ret = (int)(TEMP_FAILURE_RETRY
1220
(sigprocmask(SIG_UNBLOCK,
1221
&sigchld_action.sa_mask, NULL)));
896
1222
if(ret < 0){
897
perror("sigprocmask");
898
}
899
free(proc->buffer);
900
free(proc);
901
/* We deleted this process from the list, so we can't go
902
proc->next. Therefore, start over from the beginning of
903
the process list */
904
break;
1223
error(0, errno, "sigprocmask");
1224
exitstatus = EX_OSERR;
1225
goto fallback;
1226
}
1227
1228
if(plugin_list == NULL){
1229
break;
1230
}
1231
1232
continue;
905
1233
}
1234
906
1235
/* This process exited nicely, so print its buffer */
907
1236
908
1237
bool bret = print_out_password(proc->buffer,
909
1238
proc->buffer_length);
910
1239
if(not bret){
911
perror("print_out_password");
912
exitstatus = EXIT_FAILURE;
1240
error(0, errno, "print_out_password");
1241
exitstatus = EX_IOERR;
913
1242
}
914
1243
goto fallback;
915
1244
}
1245
916
1246
/* This process has not completed. Does it have any output? */
917
1247
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
918
1248
/* This process had nothing to say at this time */
1249
proc = proc->next;
919
1250
continue;
920
1251
}
921
1252
/* Before reading, make the process' data buffer large enough */
922
1253
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
923
proc->buffer = realloc(proc->buffer, proc->buffer_size
924
+ (size_t) BUFFER_SIZE);
925
if (proc->buffer == NULL){
926
perror("malloc");
927
exitstatus = EXIT_FAILURE;
1254
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1255
+ (size_t) BUFFER_SIZE);
1256
if(new_buffer == NULL){
1257
error(0, errno, "malloc");
1258
exitstatus = EX_OSERR;
928
1259
goto fallback;
929
1260
}
1261
proc->buffer = new_buffer;
930
1262
proc->buffer_size += BUFFER_SIZE;
931
1263
}
932
1264
/* Read from the process */
933
ret = read(proc->fd, proc->buffer + proc->buffer_length,
934
BUFFER_SIZE);
935
if(ret < 0){
1265
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1266
proc->buffer
1267
+ proc->buffer_length,
1268
BUFFER_SIZE));
1269
if(sret < 0){
936
1270
/* Read error from this process; ignore the error */
1271
proc = proc->next;
937
1272
continue;
938
1273
}
939
if(ret == 0){
1274
if(sret == 0){
940
1275
/* got EOF */
941
1276
proc->eof = true;
942
1277
} else {
943
proc->buffer_length += (size_t) ret;
1278
proc->buffer_length += (size_t) sret;
944
1279
}
945
1280
}
946
1281
}
947
948
1282
1283
949
1284
fallback:
950
1285
951
if(process_list == NULL or exitstatus != EXIT_SUCCESS){
1286
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1287
and exitstatus != EX_OK)){
952
1288
/* Fallback if all plugins failed, none are found or an error
953
1289
occured */
954
1290
bool bret;
955
1291
fprintf(stderr, "Going to fallback mode using getpass(3)\n");
956
1292
char *passwordbuffer = getpass("Password: ");
957
bret = print_out_password(passwordbuffer, strlen(passwordbuffer));
1293
size_t len = strlen(passwordbuffer);
1294
/* Strip trailing newline */
1295
if(len > 0 and passwordbuffer[len-1] == '\n'){
1296
passwordbuffer[len-1] = '\0'; /* not strictly necessary */
1297
len--;
1298
}
1299
bret = print_out_password(passwordbuffer, len);
958
1300
if(not bret){
959
perror("print_out_password");
960
exitstatus = EXIT_FAILURE;
1301
error(0, errno, "print_out_password");
1302
exitstatus = EX_IOERR;
961
1303
}
962
1304
}
963
1305
964
1306
/* Restore old signal handler */
965
1307
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
966
1308
if(ret == -1){
967
perror("sigaction");
968
exitstatus = EXIT_FAILURE;
1309
error(0, errno, "sigaction");
1310
exitstatus = EX_OSERR;
969
1311
}
970
1312
971
1313
if(custom_argv != NULL){
972
1314
for(char **arg = custom_argv+1; *arg != NULL; arg++){
973
1315
free(*arg);
974
1316
}
975
1317
free(custom_argv);
976
1318
}
977
free_plugin_list(plugin_list);
978
979
if(dir != NULL){
980
closedir(dir);
1319
1320
free(direntries);
1321
1322
if(dir_fd != -1){
1323
close(dir_fd);
981
1324
}
982
1325
983
/* Free the process list and kill the processes */
984
for(process *next; process_list != NULL; process_list = next){
985
next = process_list->next;
986
close(process_list->fd);
987
ret = kill(process_list->pid, SIGTERM);
988
if(ret == -1 and errno != ESRCH){
989
/* set-uid proccesses migth not get closed */
990
perror("kill");
1326
/* Kill the processes */
1327
for(plugin *p = plugin_list; p != NULL; p = p->next){
1328
if(p->pid != 0){
1329
close(p->fd);
1330
ret = kill(p->pid, SIGTERM);
1331
if(ret == -1 and errno != ESRCH){
1332
/* Set-uid proccesses might not get closed */
1333
error(0, errno, "kill");
1334
}
991
1335
}
992
free(process_list->buffer);
993
free(process_list);
994
1336
}
995
1337
996
1338
/* Wait for any remaining child processes to terminate */
997
do{
1339
do {
998
1340
ret = wait(NULL);
999
1341
} while(ret >= 0);
1000
1342
if(errno != ECHILD){
1001
perror("wait");
1343
error(0, errno, "wait");
1002
1344
}
1003
1345
1346
free_plugin_list();
1347
1004
1348
free(plugindir);
1349
free(pluginhelperdir);
1005
1350
free(argfile);
1006
1351
1007
1352
return exitstatus;
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0