/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to Makefile

  • Committer: Teddy Hogeborn
  • Date: 2019-08-03 12:27:14 UTC
  • Revision ID: teddy@recompile.se-20190803122714-efudxsyomr1k0zbt
dracut-module/password-agent.c: Use O_NOCTTY

Whenever a file is opened using open(), use the O_NOCTTY flag, just to
be safe.

* dracut-module/password-agent.c (test_start_mandos_client_execv): Use
  O_NOCTTY.
  (test_wait_for_mandos_client_exit_failure): - '' -
  (test_wait_for_mandos_client_exit_killed): - '' -
  (test_read_mandos_client_output_readerror): - '' -
  (test_read_inotify_event_readerror): - '' -
  (test_connect_question_socket_bad_epoll): - '' -
  (test_send_password_to_socket_bad_epoll): - '' -
  (assert_add_existing_questions_to_devnull): - '' -

Show diffs side-by-side

added added

removed removed

Lines of Context:
Makefile
29
29
 
30
30
# For info about _FORTIFY_SOURCE, see feature_test_macros(7)
31
31
# and <https://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>.
32
 
FORTIFY:=-fstack-protector-all -fPIC
33
 
CPPFLAGS+=-D_FORTIFY_SOURCE=3
 
32
FORTIFY:=-D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIC
34
33
LINK_FORTIFY_LD:=-z relro -z now
35
34
LINK_FORTIFY:=
36
35
 
42
41
#COVERAGE=--coverage
43
42
OPTIMIZE:=-Os -fno-strict-aliasing
44
43
LANGUAGE:=-std=gnu11
45
 
CPPFLAGS+=-D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64
46
44
htmldir:=man
47
 
version:=1.8.16
 
45
version:=1.8.5
48
46
SED:=sed
49
47
PKG_CONFIG?=pkg-config
50
48
 
64
62
# DRACUTMODULE:=$(DESTDIR)/usr/lib/dracut/modules.d/90mandos
65
63
# STATEDIR:=$(DESTDIR)/var/lib/mandos
66
64
# LIBDIR:=$(PREFIX)/lib
67
 
# DBUSPOLICYDIR:=$(DESTDIR)/etc/dbus-1/system.d
68
65
##
69
66
 
70
67
## These settings are for a package-type install
85
82
                        break; \
86
83
                fi; \
87
84
        done)
88
 
DBUSPOLICYDIR:=$(DESTDIR)/usr/share/dbus-1/system.d
89
85
##
90
86
 
91
87
SYSTEMD:=$(DESTDIR)$(shell $(PKG_CONFIG) systemd \
92
88
                        --variable=systemdsystemunitdir)
93
89
TMPFILES:=$(DESTDIR)$(shell $(PKG_CONFIG) systemd \
94
90
                        --variable=tmpfilesdir)
95
 
SYSUSERS:=$(DESTDIR)$(shell $(PKG_CONFIG) systemd \
96
 
                        --variable=sysusersdir)
97
91
 
98
92
GNUTLS_CFLAGS:=$(shell $(PKG_CONFIG) --cflags-only-I gnutls)
99
93
GNUTLS_LIBS:=$(shell $(PKG_CONFIG) --libs gnutls)
100
94
AVAHI_CFLAGS:=$(shell $(PKG_CONFIG) --cflags-only-I avahi-core)
101
95
AVAHI_LIBS:=$(shell $(PKG_CONFIG) --libs avahi-core)
102
 
GPGME_CFLAGS:=$(shell $(PKG_CONFIG) --cflags-only-I gpgme 2>/dev/null \
103
 
        || gpgme-config --cflags; getconf LFS_CFLAGS)
104
 
GPGME_LIBS:=$(shell $(PKG_CONFIG) --libs gpgme 2>/dev/null \
105
 
        || gpgme-config --libs; getconf LFS_LIBS; \
 
96
GPGME_CFLAGS:=$(shell gpgme-config --cflags; getconf LFS_CFLAGS)
 
97
GPGME_LIBS:=$(shell gpgme-config --libs; getconf LFS_LIBS; \
106
98
        getconf LFS_LDFLAGS)
107
99
LIBNL3_CFLAGS:=$(shell $(PKG_CONFIG) --cflags-only-I libnl-route-3.0)
108
100
LIBNL3_LIBS:=$(shell $(PKG_CONFIG) --libs libnl-route-3.0)
110
102
GLIB_LIBS:=$(shell $(PKG_CONFIG) --libs glib-2.0)
111
103
 
112
104
# Do not change these two
113
 
CFLAGS+=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) $(OPTIMIZE) \
114
 
        $(LANGUAGE) -DVERSION='"$(version)"'
 
105
CFLAGS+=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) \
 
106
        $(OPTIMIZE) $(LANGUAGE) -DVERSION='"$(version)"'
115
107
LDFLAGS+=-Xlinker --as-needed $(COVERAGE) $(LINK_FORTIFY) $(strip \
116
108
        ) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
117
109
 
161
153
 
162
154
objects:=$(addsuffix .o,$(CPROGS))
163
155
 
164
 
.PHONY: all
165
156
all: $(PROGS) mandos.lsm
166
157
 
167
 
.PHONY: doc
168
158
doc: $(DOCS)
169
159
 
170
 
.PHONY: html
171
160
html: $(htmldocs)
172
161
 
173
162
%.5: %.xml common.ent legalnotice.xml
290
279
                $@)
291
280
 
292
281
# Need to add the GnuTLS, Avahi and GPGME libraries
293
 
plugins.d/mandos-client: CFLAGS += $(GNUTLS_CFLAGS) $(strip \
294
 
        ) $(AVAHI_CFLAGS) $(GPGME_CFLAGS)
295
 
plugins.d/mandos-client: LDLIBS += $(GNUTLS_LIBS) $(strip \
296
 
        ) $(AVAHI_LIBS) $(GPGME_LIBS)
 
282
plugins.d/mandos-client: plugins.d/mandos-client.c
 
283
        $(LINK.c) $^ $(GNUTLS_CFLAGS) $(AVAHI_CFLAGS) $(strip\
 
284
                ) $(GPGME_CFLAGS) $(GNUTLS_LIBS) $(strip\
 
285
                ) $(AVAHI_LIBS) $(GPGME_LIBS) $(LOADLIBES) $(strip\
 
286
                ) $(LDLIBS) -o $@
297
287
 
298
288
# Need to add the libnl-route library
299
 
plugin-helpers/mandos-client-iprouteadddel: CFLAGS += $(LIBNL3_CFLAGS)
300
 
plugin-helpers/mandos-client-iprouteadddel: LDLIBS += $(LIBNL3_LIBS)
 
289
plugin-helpers/mandos-client-iprouteadddel: plugin-helpers/mandos-client-iprouteadddel.c
 
290
        $(LINK.c) $(LIBNL3_CFLAGS) $^ $(LIBNL3_LIBS) $(strip\
 
291
                ) $(LOADLIBES) $(LDLIBS) -o $@
301
292
 
302
293
# Need to add the GLib and pthread libraries
303
 
dracut-module/password-agent: CFLAGS += $(GLIB_CFLAGS)
304
 
# Note: -lpthread is unnecessary with the GNU C library 2.34 or later
305
 
dracut-module/password-agent: LDLIBS += $(GLIB_LIBS) -lpthread
306
 
 
307
 
.PHONY: clean
 
294
dracut-module/password-agent: dracut-module/password-agent.c
 
295
        $(LINK.c) $(GLIB_CFLAGS) $^ $(GLIB_LIBS) -lpthread $(strip\
 
296
                ) $(LOADLIBES) $(LDLIBS) -o $@
 
297
 
 
298
.PHONY : all doc html clean distclean mostlyclean maintainer-clean \
 
299
        check run-client run-server install install-html \
 
300
        install-server install-client-nokey install-client uninstall \
 
301
        uninstall-server uninstall-client purge purge-server \
 
302
        purge-client
 
303
 
308
304
clean:
309
305
        -rm --force $(CPROGS) $(objects) $(htmldocs) $(DOCS) core
310
306
 
311
 
.PHONY: distclean
312
307
distclean: clean
313
 
.PHONY: mostlyclean
314
308
mostlyclean: clean
315
 
.PHONY: maintainer-clean
316
309
maintainer-clean: clean
317
310
        -rm --force --recursive keydir confdir statedir
318
311
 
319
 
.PHONY: check
320
312
check: all
321
313
        ./mandos --check
322
314
        ./mandos-ctl --check
326
318
        ./dracut-module/password-agent --test
327
319
 
328
320
# Run the client with a local config and key
329
 
.PHONY: run-client
330
321
run-client: all keydir/seckey.txt keydir/pubkey.txt \
331
322
                        keydir/tls-privkey.pem keydir/tls-pubkey.pem
332
323
        @echo '######################################################'
360
351
keydir/seckey.txt keydir/pubkey.txt keydir/tls-privkey.pem keydir/tls-pubkey.pem: mandos-keygen
361
352
        install --directory keydir
362
353
        ./mandos-keygen --dir keydir --force
363
 
        if ! [ -e keydir/tls-privkey.pem ]; then \
364
 
                install --mode=u=rw /dev/null keydir/tls-privkey.pem; \
365
 
        fi
366
 
        if ! [ -e keydir/tls-pubkey.pem ]; then \
367
 
                install --mode=u=rw /dev/null keydir/tls-pubkey.pem; \
368
 
        fi
369
354
 
370
355
# Run the server with a local config
371
 
.PHONY: run-server
372
356
run-server: confdir/mandos.conf confdir/clients.conf statedir
373
357
        ./mandos --debug --no-dbus --configdir=confdir \
374
358
                --statedir=statedir $(SERVERARGS)
375
359
 
376
360
# Used by run-server
377
361
confdir/mandos.conf: mandos.conf
378
 
        install -D --mode=u=rw,go=r $^ $@
 
362
        install --directory confdir
 
363
        install --mode=u=rw,go=r $^ $@
379
364
confdir/clients.conf: clients.conf keydir/seckey.txt keydir/tls-pubkey.pem
380
 
        install -D --mode=u=rw $< $@
 
365
        install --directory confdir
 
366
        install --mode=u=rw $< $@
381
367
# Add a client password
382
368
        ./mandos-keygen --dir keydir --password --no-ssh >> $@
383
369
statedir:
384
370
        install --directory statedir
385
371
 
386
 
.PHONY: install
387
372
install: install-server install-client-nokey
388
373
 
389
 
.PHONY: install-html
390
374
install-html: html
391
 
        install -D --mode=u=rw,go=r --target-directory=$(htmldir) \
 
375
        install --directory $(htmldir)
 
376
        install --mode=u=rw,go=r --target-directory=$(htmldir) \
392
377
                $(htmldocs)
393
378
 
394
 
.PHONY: install-server
395
379
install-server: doc
 
380
        install --directory $(CONFDIR)
396
381
        if install --directory --mode=u=rwx --owner=$(USER) \
397
382
                --group=$(GROUP) $(STATEDIR); then \
398
383
                :; \
399
384
        elif install --directory --mode=u=rwx $(STATEDIR); then \
400
385
                chown -- $(USER):$(GROUP) $(STATEDIR) || :; \
401
386
        fi
402
 
        if [ "$(TMPFILES)" != "$(DESTDIR)" ]; then \
403
 
                install -D --mode=u=rw,go=r tmpfiles.d-mandos.conf \
 
387
        if [ "$(TMPFILES)" != "$(DESTDIR)" \
 
388
                        -a -d "$(TMPFILES)" ]; then \
 
389
                install --mode=u=rw,go=r tmpfiles.d-mandos.conf \
404
390
                        $(TMPFILES)/mandos.conf; \
405
391
        fi
406
 
        if [ "$(SYSUSERS)" != "$(DESTDIR)" ]; then \
407
 
                install -D --mode=u=rw,go=r sysusers.d-mandos.conf \
408
 
                        $(SYSUSERS)/mandos.conf; \
409
 
        fi
410
 
        install --directory $(PREFIX)/sbin
411
 
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
412
 
                mandos
 
392
        install --mode=u=rwx,go=rx mandos $(PREFIX)/sbin/mandos
413
393
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
414
394
                mandos-ctl
415
395
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
416
396
                mandos-monitor
417
 
        install --directory $(CONFDIR)
418
397
        install --mode=u=rw,go=r --target-directory=$(CONFDIR) \
419
398
                mandos.conf
420
399
        install --mode=u=rw --target-directory=$(CONFDIR) \
421
400
                clients.conf
422
 
        install -D --mode=u=rw,go=r dbus-mandos.conf \
423
 
                $(DBUSPOLICYDIR)/mandos.conf
424
 
        install -D --mode=u=rwx,go=rx init.d-mandos \
 
401
        install --mode=u=rw,go=r dbus-mandos.conf \
 
402
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
 
403
        install --mode=u=rwx,go=rx init.d-mandos \
425
404
                $(DESTDIR)/etc/init.d/mandos
426
 
        if [ "$(SYSTEMD)" != "$(DESTDIR)" ]; then \
427
 
                install -D --mode=u=rw,go=r mandos.service \
428
 
                        $(SYSTEMD); \
 
405
        if [ "$(SYSTEMD)" != "$(DESTDIR)" -a -d "$(SYSTEMD)" ]; then \
 
406
                install --mode=u=rw,go=r mandos.service $(SYSTEMD); \
429
407
        fi
430
 
        install -D --mode=u=rw,go=r default-mandos \
 
408
        install --mode=u=rw,go=r default-mandos \
431
409
                $(DESTDIR)/etc/default/mandos
432
410
        if [ -z $(DESTDIR) ]; then \
433
411
                update-rc.d mandos defaults 25 15;\
434
412
        fi
435
 
        install --directory $(MANDIR)/man8 $(MANDIR)/man5
436
413
        gzip --best --to-stdout mandos.8 \
437
414
                > $(MANDIR)/man8/mandos.8.gz
438
415
        gzip --best --to-stdout mandos-monitor.8 \
446
423
        gzip --best --to-stdout intro.8mandos \
447
424
                > $(MANDIR)/man8/intro.8mandos.gz
448
425
 
449
 
.PHONY: install-client-nokey
450
426
install-client-nokey: all doc
 
427
        install --directory $(LIBDIR)/mandos $(CONFDIR)
451
428
        install --directory --mode=u=rwx $(KEYDIR) \
452
429
                $(LIBDIR)/mandos/plugins.d \
453
430
                $(LIBDIR)/mandos/plugin-helpers
454
 
        if [ "$(SYSUSERS)" != "$(DESTDIR)" ]; then \
455
 
                install -D --mode=u=rw,go=r sysusers.d-mandos.conf \
456
 
                        $(SYSUSERS)/mandos-client.conf; \
457
 
        fi
458
431
        if [ "$(CONFDIR)" != "$(LIBDIR)/mandos" ]; then \
459
 
                install --directory \
460
 
                        --mode=u=rwx "$(CONFDIR)/plugins.d" \
 
432
                install --mode=u=rwx \
 
433
                        --directory "$(CONFDIR)/plugins.d" \
461
434
                        "$(CONFDIR)/plugin-helpers"; \
462
435
        fi
463
 
        install --directory --mode=u=rwx,go=rx \
 
436
        install --mode=u=rwx,go=rx --directory \
464
437
                "$(CONFDIR)/network-hooks.d"
465
438
        install --mode=u=rwx,go=rx \
466
439
                --target-directory=$(LIBDIR)/mandos plugin-runner
467
440
        install --mode=u=rwx,go=rx \
468
441
                --target-directory=$(LIBDIR)/mandos \
469
442
                mandos-to-cryptroot-unlock
470
 
        install --directory $(PREFIX)/sbin
471
443
        install --mode=u=rwx,go=rx --target-directory=$(PREFIX)/sbin \
472
444
                mandos-keygen
473
445
        install --mode=u=rwx,go=rx \
491
463
        install --mode=u=rwx,go=rx \
492
464
                --target-directory=$(LIBDIR)/mandos/plugin-helpers \
493
465
                plugin-helpers/mandos-client-iprouteadddel
494
 
        install -D initramfs-tools-hook \
 
466
        install initramfs-tools-hook \
495
467
                $(INITRAMFSTOOLS)/hooks/mandos
496
 
        install -D --mode=u=rw,go=r initramfs-tools-conf \
 
468
        install --mode=u=rw,go=r initramfs-tools-conf \
497
469
                $(INITRAMFSTOOLS)/conf.d/mandos-conf
498
 
        install -D --mode=u=rw,go=r initramfs-tools-conf-hook \
 
470
        install --mode=u=rw,go=r initramfs-tools-conf-hook \
499
471
                $(INITRAMFSTOOLS)/conf-hooks.d/zz-mandos
500
 
        install -D initramfs-tools-script \
 
472
        install initramfs-tools-script \
501
473
                $(INITRAMFSTOOLS)/scripts/init-premount/mandos
502
 
        install -D initramfs-tools-script-stop \
 
474
        install initramfs-tools-script-stop \
503
475
                $(INITRAMFSTOOLS)/scripts/local-premount/mandos
504
 
        install -D --mode=u=rw,go=r \
505
 
                --target-directory=$(DRACUTMODULE) \
 
476
        install --directory $(DRACUTMODULE)
 
477
        install --mode=u=rw,go=r --target-directory=$(DRACUTMODULE) \
506
478
                dracut-module/ask-password-mandos.path \
507
479
                dracut-module/ask-password-mandos.service
508
480
        install --mode=u=rwxs,go=rx \
511
483
                dracut-module/cmdline-mandos.sh \
512
484
                dracut-module/password-agent
513
485
        install --mode=u=rw,go=r plugin-runner.conf $(CONFDIR)
514
 
        install --directory $(MANDIR)/man8
515
486
        gzip --best --to-stdout mandos-keygen.8 \
516
487
                > $(MANDIR)/man8/mandos-keygen.8.gz
517
488
        gzip --best --to-stdout plugin-runner.8mandos \
531
502
        gzip --best --to-stdout dracut-module/password-agent.8mandos \
532
503
                > $(MANDIR)/man8/password-agent.8mandos.gz
533
504
 
534
 
.PHONY: install-client
535
505
install-client: install-client-nokey
536
506
# Post-installation stuff
537
507
        -$(PREFIX)/sbin/mandos-keygen --dir "$(KEYDIR)"
547
517
        fi
548
518
        echo "Now run mandos-keygen --password --dir $(KEYDIR)"
549
519
 
550
 
.PHONY: uninstall
551
520
uninstall: uninstall-server uninstall-client
552
521
 
553
 
.PHONY: uninstall-server
554
522
uninstall-server:
555
523
        -rm --force $(PREFIX)/sbin/mandos \
556
524
                $(PREFIX)/sbin/mandos-ctl \
563
531
        update-rc.d -f mandos remove
564
532
        -rmdir $(CONFDIR)
565
533
 
566
 
.PHONY: uninstall-client
567
534
uninstall-client:
568
535
# Refuse to uninstall client if /etc/crypttab is explicitly configured
569
536
# to use it.
605
572
            done; \
606
573
        fi
607
574
 
608
 
.PHONY: purge
609
575
purge: purge-server purge-client
610
576
 
611
 
.PHONY: purge-server
612
577
purge-server: uninstall-server
613
578
        -rm --force $(CONFDIR)/mandos.conf $(CONFDIR)/clients.conf \
614
579
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
615
580
                $(DESTDIR)/etc/default/mandos \
616
581
                $(DESTDIR)/etc/init.d/mandos \
 
582
                $(SYSTEMD)/mandos.service \
617
583
                $(DESTDIR)/run/mandos.pid \
618
584
                $(DESTDIR)/var/run/mandos.pid
619
 
        if [ "$(SYSTEMD)" != "$(DESTDIR)" -a -d "$(SYSTEMD)" ]; then \
620
 
                -rm --force -- $(SYSTEMD)/mandos.service; \
621
 
        fi
622
585
        -rmdir $(CONFDIR)
623
586
 
624
 
.PHONY: purge-client
625
587
purge-client: uninstall-client
626
588
        -shred --remove $(KEYDIR)/seckey.txt $(KEYDIR)/tls-privkey.pem
627
589
        -rm --force $(CONFDIR)/plugin-runner.conf \