/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to plugins.d/password-prompt.c

  • Committer: Teddy Hogeborn
  • Date: 2019-04-08 21:53:22 UTC
  • Revision ID: teddy@recompile.se-20190408215322-y3hmfxzdgs9t84l1
plugin-runner: Fix minor memory leak

* plugin-runner.c (free_plugin): Even if argv[0] is NULL, as for the
                                 pseudo-plugin for global options,
                                 free all other arguments by simply
                                 starting at argv[1] and freeing
                                 plugin_node->name (which is always
                                 argv[0]) separately.

Show diffs side-by-side

added added

removed removed

Lines of Context:
plugins.d/password-prompt.c
508
508
    }
509
509
    if(sret < 0){
510
510
      int e = errno;
511
 
      if(errno != EINTR){
512
 
        if(not feof(stdin)){
513
 
          error_plus(0, errno, "getline");
514
 
          switch(e){
515
 
          case EBADF:
516
 
            status = EX_UNAVAILABLE;
517
 
            break;
518
 
          case EIO:
519
 
          case EINVAL:
520
 
          default:
521
 
            status = EX_IOERR;
522
 
            break;
523
 
          }
524
 
          break;
525
 
        } else {
526
 
          clearerr(stdin);
 
511
      if(errno != EINTR and not feof(stdin)){
 
512
        error_plus(0, errno, "getline");
 
513
        switch(e){
 
514
        case EBADF:
 
515
          status = EX_UNAVAILABLE;
 
516
          break;
 
517
        case EIO:
 
518
        case EINVAL:
 
519
        default:
 
520
          status = EX_IOERR;
 
521
          break;
527
522
        }
 
523
        break;
528
524
      }
529
525
    }
530
526
    /* if(sret == 0), then the only sensible thing to do is to retry