/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to mandos-ctl

  • Committer: Teddy Hogeborn
  • Date: 2019-03-21 18:37:29 UTC
  • Revision ID: teddy@recompile.se-20190321183729-6okcpelqgalk1p6k
mandos-ctl: Refactor

* mandos-ctl (main): Remove a couple of blank lines.
  (SilenceLogger.__enter__): Remove unnecessary return statement.
  (commands.Property): Rename to "PropertySetter".
  (commands.PropertyValue): Rename to "PropertySetterValue".
  (commands.MillisecondsPropertyValueArgument): Rename to
                                    "PropertySetterValueMilliseconds".
  (TestPropertyCmd): Rename to "TestPropertySetterCmd".
  (TestPropertyValueCmd): Rename to "TestPropertySetterValueCmd".

Show diffs side-by-side

added added

removed removed

Lines of Context:
61
61
 
62
62
if sys.version_info.major == 2:
63
63
    str = unicode
 
64
    import StringIO
 
65
    io.StringIO = StringIO.StringIO
64
66
 
65
67
locale.setlocale(locale.LC_ALL, "")
66
68
 
67
 
domain = "se.recompile"
68
 
busname = domain + ".Mandos"
69
 
server_path = "/"
70
 
server_interface = domain + ".Mandos"
71
 
client_interface = domain + ".Mandos.Client"
 
69
dbus_busname_domain = "se.recompile"
 
70
dbus_busname = dbus_busname_domain + ".Mandos"
 
71
server_dbus_path = "/"
 
72
server_dbus_interface = dbus_busname_domain + ".Mandos"
 
73
client_dbus_interface = dbus_busname_domain + ".Mandos.Client"
 
74
del dbus_busname_domain
72
75
version = "1.8.3"
73
76
 
74
77
 
78
81
    dbus.OBJECT_MANAGER_IFACE = "org.freedesktop.DBus.ObjectManager"
79
82
 
80
83
 
81
 
def milliseconds_to_string(ms):
82
 
    td = datetime.timedelta(0, 0, 0, ms)
83
 
    return ("{days}{hours:02}:{minutes:02}:{seconds:02}"
84
 
            .format(days="{}T".format(td.days) if td.days else "",
85
 
                    hours=td.seconds // 3600,
86
 
                    minutes=(td.seconds % 3600) // 60,
87
 
                    seconds=td.seconds % 60))
 
84
def main():
 
85
    parser = argparse.ArgumentParser()
 
86
    add_command_line_options(parser)
 
87
 
 
88
    options = parser.parse_args()
 
89
    check_option_syntax(parser, options)
 
90
 
 
91
    clientnames = options.client
 
92
 
 
93
    if options.debug:
 
94
        log.setLevel(logging.DEBUG)
 
95
 
 
96
    bus = dbus.SystemBus()
 
97
 
 
98
    mandos_dbus_object = get_mandos_dbus_object(bus)
 
99
 
 
100
    mandos_serv = dbus.Interface(
 
101
        mandos_dbus_object, dbus_interface=server_dbus_interface)
 
102
    mandos_serv_object_manager = dbus.Interface(
 
103
        mandos_dbus_object, dbus_interface=dbus.OBJECT_MANAGER_IFACE)
 
104
 
 
105
    managed_objects = get_managed_objects(mandos_serv_object_manager)
 
106
 
 
107
    all_clients = {}
 
108
    for path, ifs_and_props in managed_objects.items():
 
109
        try:
 
110
            all_clients[path] = ifs_and_props[client_dbus_interface]
 
111
        except KeyError:
 
112
            pass
 
113
 
 
114
    # Compile dict of (clientpath: properties) to process
 
115
    if not clientnames:
 
116
        clients = all_clients
 
117
    else:
 
118
        clients = {}
 
119
        for name in clientnames:
 
120
            for objpath, properties in all_clients.items():
 
121
                if properties["Name"] == name:
 
122
                    clients[objpath] = properties
 
123
                    break
 
124
            else:
 
125
                log.critical("Client not found on server: %r", name)
 
126
                sys.exit(1)
 
127
 
 
128
    commands = commands_from_options(options)
 
129
 
 
130
    for command in commands:
 
131
        command.run(clients, bus, mandos_serv)
 
132
 
 
133
 
 
134
def add_command_line_options(parser):
 
135
    parser.add_argument("--version", action="version",
 
136
                        version="%(prog)s {}".format(version),
 
137
                        help="show version number and exit")
 
138
    parser.add_argument("-a", "--all", action="store_true",
 
139
                        help="Select all clients")
 
140
    parser.add_argument("-v", "--verbose", action="store_true",
 
141
                        help="Print all fields")
 
142
    parser.add_argument("-j", "--dump-json", action="store_true",
 
143
                        help="Dump client data in JSON format")
 
144
    enable_disable = parser.add_mutually_exclusive_group()
 
145
    enable_disable.add_argument("-e", "--enable", action="store_true",
 
146
                                help="Enable client")
 
147
    enable_disable.add_argument("-d", "--disable",
 
148
                                action="store_true",
 
149
                                help="disable client")
 
150
    parser.add_argument("-b", "--bump-timeout", action="store_true",
 
151
                        help="Bump timeout for client")
 
152
    start_stop_checker = parser.add_mutually_exclusive_group()
 
153
    start_stop_checker.add_argument("--start-checker",
 
154
                                    action="store_true",
 
155
                                    help="Start checker for client")
 
156
    start_stop_checker.add_argument("--stop-checker",
 
157
                                    action="store_true",
 
158
                                    help="Stop checker for client")
 
159
    parser.add_argument("-V", "--is-enabled", action="store_true",
 
160
                        help="Check if client is enabled")
 
161
    parser.add_argument("-r", "--remove", action="store_true",
 
162
                        help="Remove client")
 
163
    parser.add_argument("-c", "--checker",
 
164
                        help="Set checker command for client")
 
165
    parser.add_argument("-t", "--timeout", type=string_to_delta,
 
166
                        help="Set timeout for client")
 
167
    parser.add_argument("--extended-timeout", type=string_to_delta,
 
168
                        help="Set extended timeout for client")
 
169
    parser.add_argument("-i", "--interval", type=string_to_delta,
 
170
                        help="Set checker interval for client")
 
171
    approve_deny_default = parser.add_mutually_exclusive_group()
 
172
    approve_deny_default.add_argument(
 
173
        "--approve-by-default", action="store_true",
 
174
        default=None, dest="approved_by_default",
 
175
        help="Set client to be approved by default")
 
176
    approve_deny_default.add_argument(
 
177
        "--deny-by-default", action="store_false",
 
178
        dest="approved_by_default",
 
179
        help="Set client to be denied by default")
 
180
    parser.add_argument("--approval-delay", type=string_to_delta,
 
181
                        help="Set delay before client approve/deny")
 
182
    parser.add_argument("--approval-duration", type=string_to_delta,
 
183
                        help="Set duration of one client approval")
 
184
    parser.add_argument("-H", "--host", help="Set host for client")
 
185
    parser.add_argument("-s", "--secret",
 
186
                        type=argparse.FileType(mode="rb"),
 
187
                        help="Set password blob (file) for client")
 
188
    approve_deny = parser.add_mutually_exclusive_group()
 
189
    approve_deny.add_argument(
 
190
        "-A", "--approve", action="store_true",
 
191
        help="Approve any current client request")
 
192
    approve_deny.add_argument("-D", "--deny", action="store_true",
 
193
                              help="Deny any current client request")
 
194
    parser.add_argument("--debug", action="store_true",
 
195
                        help="Debug mode (show D-Bus commands)")
 
196
    parser.add_argument("--check", action="store_true",
 
197
                        help="Run self-test")
 
198
    parser.add_argument("client", nargs="*", help="Client name")
 
199
 
 
200
 
 
201
def string_to_delta(interval):
 
202
    """Parse a string and return a datetime.timedelta"""
 
203
 
 
204
    try:
 
205
        return rfc3339_duration_to_delta(interval)
 
206
    except ValueError as e:
 
207
        log.warning("%s - Parsing as pre-1.6.1 interval instead",
 
208
                    ' '.join(e.args))
 
209
    return parse_pre_1_6_1_interval(interval)
88
210
 
89
211
 
90
212
def rfc3339_duration_to_delta(duration):
110
232
    >>> rfc3339_duration_to_delta("")
111
233
    Traceback (most recent call last):
112
234
    ...
113
 
    ValueError: Invalid RFC 3339 duration: u''
 
235
    ValueError: Invalid RFC 3339 duration: ""
114
236
    >>> # Must start with "P":
115
237
    >>> rfc3339_duration_to_delta("1D")
116
238
    Traceback (most recent call last):
117
239
    ...
118
 
    ValueError: Invalid RFC 3339 duration: u'1D'
 
240
    ValueError: Invalid RFC 3339 duration: "1D"
119
241
    >>> # Must use correct order
120
242
    >>> rfc3339_duration_to_delta("PT1S2M")
121
243
    Traceback (most recent call last):
122
244
    ...
123
 
    ValueError: Invalid RFC 3339 duration: u'PT1S2M'
 
245
    ValueError: Invalid RFC 3339 duration: "PT1S2M"
124
246
    >>> # Time needs time marker
125
247
    >>> rfc3339_duration_to_delta("P1H2S")
126
248
    Traceback (most recent call last):
127
249
    ...
128
 
    ValueError: Invalid RFC 3339 duration: u'P1H2S'
 
250
    ValueError: Invalid RFC 3339 duration: "P1H2S"
129
251
    >>> # Weeks can not be combined with anything else
130
252
    >>> rfc3339_duration_to_delta("P1D2W")
131
253
    Traceback (most recent call last):
132
254
    ...
133
 
    ValueError: Invalid RFC 3339 duration: u'P1D2W'
 
255
    ValueError: Invalid RFC 3339 duration: "P1D2W"
134
256
    >>> rfc3339_duration_to_delta("P2W2H")
135
257
    Traceback (most recent call last):
136
258
    ...
137
 
    ValueError: Invalid RFC 3339 duration: u'P2W2H'
 
259
    ValueError: Invalid RFC 3339 duration: "P2W2H"
138
260
    """
139
261
 
140
262
    # Parsing an RFC 3339 duration with regular expressions is not
211
333
                break
212
334
        else:
213
335
            # No currently valid tokens were found
214
 
            raise ValueError("Invalid RFC 3339 duration: {!r}"
 
336
            raise ValueError("Invalid RFC 3339 duration: \"{}\""
215
337
                             .format(duration))
216
338
    # End token found
217
339
    return value
218
340
 
219
341
 
220
 
def string_to_delta(interval):
221
 
    """Parse a string and return a datetime.timedelta"""
222
 
 
223
 
    try:
224
 
        return rfc3339_duration_to_delta(interval)
225
 
    except ValueError as e:
226
 
        log.warning("%s - Parsing as pre-1.6.1 interval instead",
227
 
                    ' '.join(e.args))
228
 
    return parse_pre_1_6_1_interval(interval)
229
 
 
230
 
 
231
342
def parse_pre_1_6_1_interval(interval):
232
343
    """Parse an interval string as documented by Mandos before 1.6.1,
233
344
    and return a datetime.timedelta
271
382
    return value
272
383
 
273
384
 
274
 
## Classes for commands.
275
 
 
276
 
# Abstract classes first
277
 
class Command(object):
278
 
    """Abstract class for commands"""
279
 
    def run(self, mandos, clients):
280
 
        """Normal commands should implement run_on_one_client(), but
281
 
        commands which want to operate on all clients at the same time
282
 
        can override this run() method instead."""
283
 
        self.mandos = mandos
284
 
        for client, properties in clients.items():
285
 
            self.run_on_one_client(client, properties)
286
 
 
287
 
class PrintCmd(Command):
288
 
    """Abstract class for commands printing client details"""
289
 
    all_keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK",
290
 
                    "Created", "Interval", "Host", "KeyID",
291
 
                    "Fingerprint", "CheckerRunning", "LastEnabled",
292
 
                    "ApprovalPending", "ApprovedByDefault",
293
 
                    "LastApprovalRequest", "ApprovalDelay",
294
 
                    "ApprovalDuration", "Checker", "ExtendedTimeout",
295
 
                    "Expires", "LastCheckerStatus")
296
 
    def run(self, mandos, clients):
297
 
        print(self.output(clients))
298
 
 
299
 
class PropertyCmd(Command):
300
 
    """Abstract class for Actions for setting one client property"""
301
 
    def run_on_one_client(self, client, properties):
302
 
        """Set the Client's D-Bus property"""
303
 
        log.debug("D-Bus: %s:%s:%s.Set(%r, %r, %r)", busname,
304
 
                  client.__dbus_object_path__,
305
 
                  dbus.PROPERTIES_IFACE, client_interface,
306
 
                  self.property, self.value_to_set
307
 
                  if not isinstance(self.value_to_set, dbus.Boolean)
308
 
                  else bool(self.value_to_set))
309
 
        client.Set(client_interface, self.property, self.value_to_set,
310
 
                   dbus_interface=dbus.PROPERTIES_IFACE)
311
 
 
312
 
class ValueArgumentMixIn(object):
313
 
    """Mixin class for commands taking a value as argument"""
314
 
    def __init__(self, value):
315
 
        self.value_to_set = value
316
 
 
317
 
class MillisecondsValueArgumentMixIn(ValueArgumentMixIn):
318
 
    """Mixin class for commands taking a value argument as
319
 
    milliseconds."""
320
 
    @property
321
 
    def value_to_set(self):
322
 
        return self._vts
323
 
    @value_to_set.setter
324
 
    def value_to_set(self, value):
325
 
        """When setting, convert value to a datetime.timedelta"""
326
 
        self._vts = int(round(value.total_seconds() * 1000))
327
 
 
328
 
# Actual (non-abstract) command classes
329
 
 
330
 
class PrintTableCmd(PrintCmd):
331
 
    def __init__(self, verbose=False):
332
 
        self.verbose = verbose
333
 
 
334
 
    def output(self, clients):
335
 
        default_keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
336
 
        keywords = default_keywords
337
 
        if self.verbose:
338
 
            keywords = self.all_keywords
339
 
        return str(self.TableOfClients(clients.values(), keywords))
340
 
 
341
 
    class TableOfClients(object):
342
 
        tableheaders = {
343
 
            "Name": "Name",
344
 
            "Enabled": "Enabled",
345
 
            "Timeout": "Timeout",
346
 
            "LastCheckedOK": "Last Successful Check",
347
 
            "LastApprovalRequest": "Last Approval Request",
348
 
            "Created": "Created",
349
 
            "Interval": "Interval",
350
 
            "Host": "Host",
351
 
            "Fingerprint": "Fingerprint",
352
 
            "KeyID": "Key ID",
353
 
            "CheckerRunning": "Check Is Running",
354
 
            "LastEnabled": "Last Enabled",
355
 
            "ApprovalPending": "Approval Is Pending",
356
 
            "ApprovedByDefault": "Approved By Default",
357
 
            "ApprovalDelay": "Approval Delay",
358
 
            "ApprovalDuration": "Approval Duration",
359
 
            "Checker": "Checker",
360
 
            "ExtendedTimeout": "Extended Timeout",
361
 
            "Expires": "Expires",
362
 
            "LastCheckerStatus": "Last Checker Status",
363
 
        }
364
 
 
365
 
        def __init__(self, clients, keywords, tableheaders=None):
366
 
            self.clients = clients
367
 
            self.keywords = keywords
368
 
            if tableheaders is not None:
369
 
                self.tableheaders = tableheaders
370
 
 
371
 
        def __str__(self):
372
 
            return "\n".join(self.rows())
373
 
 
374
 
        if sys.version_info.major == 2:
375
 
            __unicode__ = __str__
376
 
            def __str__(self):
377
 
                return str(self).encode(locale.getpreferredencoding())
378
 
 
379
 
        def rows(self):
380
 
            format_string = self.row_formatting_string()
381
 
            rows = [self.header_line(format_string)]
382
 
            rows.extend(self.client_line(client, format_string)
383
 
                        for client in self.clients)
384
 
            return rows
385
 
 
386
 
        def row_formatting_string(self):
387
 
            "Format string used to format table rows"
388
 
            return " ".join("{{{key}:{width}}}".format(
389
 
                width=max(len(self.tableheaders[key]),
390
 
                          *(len(self.string_from_client(client, key))
391
 
                            for client in self.clients)),
392
 
                key=key)
393
 
                            for key in self.keywords)
394
 
 
395
 
        def string_from_client(self, client, key):
396
 
            return self.valuetostring(client[key], key)
397
 
 
398
 
        @staticmethod
399
 
        def valuetostring(value, keyword):
400
 
            if isinstance(value, dbus.Boolean):
401
 
                return "Yes" if value else "No"
402
 
            if keyword in ("Timeout", "Interval", "ApprovalDelay",
403
 
                           "ApprovalDuration", "ExtendedTimeout"):
404
 
                return milliseconds_to_string(value)
405
 
            return str(value)
406
 
 
407
 
        def header_line(self, format_string):
408
 
            return format_string.format(**self.tableheaders)
409
 
 
410
 
        def client_line(self, client, format_string):
411
 
            return format_string.format(
412
 
                **{key: self.string_from_client(client, key)
413
 
                   for key in self.keywords})
414
 
 
415
 
 
416
 
 
417
 
class DumpJSONCmd(PrintCmd):
418
 
    def output(self, clients):
419
 
        data = {client["Name"]:
420
 
                {key: self.dbus_boolean_to_bool(client[key])
421
 
                 for key in self.all_keywords}
422
 
                for client in clients.values()}
423
 
        return json.dumps(data, indent=4, separators=(',', ': '))
424
 
    @staticmethod
425
 
    def dbus_boolean_to_bool(value):
426
 
        if isinstance(value, dbus.Boolean):
427
 
            value = bool(value)
428
 
        return value
429
 
 
430
 
class IsEnabledCmd(Command):
431
 
    def run_on_one_client(self, client, properties):
432
 
        if self.is_enabled(client, properties):
433
 
            sys.exit(0)
434
 
        sys.exit(1)
435
 
    def is_enabled(self, client, properties):
436
 
        return bool(properties["Enabled"])
437
 
 
438
 
class RemoveCmd(Command):
439
 
    def run_on_one_client(self, client, properties):
440
 
        log.debug("D-Bus: %s:%s:%s.RemoveClient(%r)", busname,
441
 
                  server_path, server_interface,
442
 
                  str(client.__dbus_object_path__))
443
 
        self.mandos.RemoveClient(client.__dbus_object_path__)
444
 
 
445
 
class ApproveCmd(Command):
446
 
    def run_on_one_client(self, client, properties):
447
 
        log.debug("D-Bus: %s:%s.Approve(True)",
448
 
                  client.__dbus_object_path__, client_interface)
449
 
        client.Approve(dbus.Boolean(True),
450
 
                       dbus_interface=client_interface)
451
 
 
452
 
class DenyCmd(Command):
453
 
    def run_on_one_client(self, client, properties):
454
 
        log.debug("D-Bus: %s:%s.Approve(False)",
455
 
                  client.__dbus_object_path__, client_interface)
456
 
        client.Approve(dbus.Boolean(False),
457
 
                       dbus_interface=client_interface)
458
 
 
459
 
class EnableCmd(PropertyCmd):
460
 
    property = "Enabled"
461
 
    value_to_set = dbus.Boolean(True)
462
 
 
463
 
class DisableCmd(PropertyCmd):
464
 
    property = "Enabled"
465
 
    value_to_set = dbus.Boolean(False)
466
 
 
467
 
class BumpTimeoutCmd(PropertyCmd):
468
 
    property = "LastCheckedOK"
469
 
    value_to_set = ""
470
 
 
471
 
class StartCheckerCmd(PropertyCmd):
472
 
    property = "CheckerRunning"
473
 
    value_to_set = dbus.Boolean(True)
474
 
 
475
 
class StopCheckerCmd(PropertyCmd):
476
 
    property = "CheckerRunning"
477
 
    value_to_set = dbus.Boolean(False)
478
 
 
479
 
class ApproveByDefaultCmd(PropertyCmd):
480
 
    property = "ApprovedByDefault"
481
 
    value_to_set = dbus.Boolean(True)
482
 
 
483
 
class DenyByDefaultCmd(PropertyCmd):
484
 
    property = "ApprovedByDefault"
485
 
    value_to_set = dbus.Boolean(False)
486
 
 
487
 
class SetCheckerCmd(PropertyCmd, ValueArgumentMixIn):
488
 
    property = "Checker"
489
 
 
490
 
class SetHostCmd(PropertyCmd, ValueArgumentMixIn):
491
 
    property = "Host"
492
 
 
493
 
class SetSecretCmd(PropertyCmd, ValueArgumentMixIn):
494
 
    @property
495
 
    def value_to_set(self):
496
 
        return self._vts
497
 
    @value_to_set.setter
498
 
    def value_to_set(self, value):
499
 
        """When setting, read data from supplied file object"""
500
 
        self._vts = value.read()
501
 
        value.close()
502
 
    property = "Secret"
503
 
 
504
 
class SetTimeoutCmd(PropertyCmd, MillisecondsValueArgumentMixIn):
505
 
    property = "Timeout"
506
 
 
507
 
class SetExtendedTimeoutCmd(PropertyCmd,
508
 
                            MillisecondsValueArgumentMixIn):
509
 
    property = "ExtendedTimeout"
510
 
 
511
 
class SetIntervalCmd(PropertyCmd, MillisecondsValueArgumentMixIn):
512
 
    property = "Interval"
513
 
 
514
 
class SetApprovalDelayCmd(PropertyCmd,
515
 
                          MillisecondsValueArgumentMixIn):
516
 
    property = "ApprovalDelay"
517
 
 
518
 
class SetApprovalDurationCmd(PropertyCmd,
519
 
                             MillisecondsValueArgumentMixIn):
520
 
    property = "ApprovalDuration"
521
 
 
522
 
def add_command_line_options(parser):
523
 
    parser.add_argument("--version", action="version",
524
 
                        version="%(prog)s {}".format(version),
525
 
                        help="show version number and exit")
526
 
    parser.add_argument("-a", "--all", action="store_true",
527
 
                        help="Select all clients")
528
 
    parser.add_argument("-v", "--verbose", action="store_true",
529
 
                        help="Print all fields")
530
 
    parser.add_argument("-j", "--dump-json", action="store_true",
531
 
                        help="Dump client data in JSON format")
532
 
    enable_disable = parser.add_mutually_exclusive_group()
533
 
    enable_disable.add_argument("-e", "--enable", action="store_true",
534
 
                                help="Enable client")
535
 
    enable_disable.add_argument("-d", "--disable",
536
 
                                action="store_true",
537
 
                                help="disable client")
538
 
    parser.add_argument("-b", "--bump-timeout", action="store_true",
539
 
                        help="Bump timeout for client")
540
 
    start_stop_checker = parser.add_mutually_exclusive_group()
541
 
    start_stop_checker.add_argument("--start-checker",
542
 
                                    action="store_true",
543
 
                                    help="Start checker for client")
544
 
    start_stop_checker.add_argument("--stop-checker",
545
 
                                    action="store_true",
546
 
                                    help="Stop checker for client")
547
 
    parser.add_argument("-V", "--is-enabled", action="store_true",
548
 
                        help="Check if client is enabled")
549
 
    parser.add_argument("-r", "--remove", action="store_true",
550
 
                        help="Remove client")
551
 
    parser.add_argument("-c", "--checker",
552
 
                        help="Set checker command for client")
553
 
    parser.add_argument("-t", "--timeout", type=string_to_delta,
554
 
                        help="Set timeout for client")
555
 
    parser.add_argument("--extended-timeout", type=string_to_delta,
556
 
                        help="Set extended timeout for client")
557
 
    parser.add_argument("-i", "--interval", type=string_to_delta,
558
 
                        help="Set checker interval for client")
559
 
    approve_deny_default = parser.add_mutually_exclusive_group()
560
 
    approve_deny_default.add_argument(
561
 
        "--approve-by-default", action="store_true",
562
 
        default=None, dest="approved_by_default",
563
 
        help="Set client to be approved by default")
564
 
    approve_deny_default.add_argument(
565
 
        "--deny-by-default", action="store_false",
566
 
        dest="approved_by_default",
567
 
        help="Set client to be denied by default")
568
 
    parser.add_argument("--approval-delay", type=string_to_delta,
569
 
                        help="Set delay before client approve/deny")
570
 
    parser.add_argument("--approval-duration", type=string_to_delta,
571
 
                        help="Set duration of one client approval")
572
 
    parser.add_argument("-H", "--host", help="Set host for client")
573
 
    parser.add_argument("-s", "--secret",
574
 
                        type=argparse.FileType(mode="rb"),
575
 
                        help="Set password blob (file) for client")
576
 
    approve_deny = parser.add_mutually_exclusive_group()
577
 
    approve_deny.add_argument(
578
 
        "-A", "--approve", action="store_true",
579
 
        help="Approve any current client request")
580
 
    approve_deny.add_argument("-D", "--deny", action="store_true",
581
 
                              help="Deny any current client request")
582
 
    parser.add_argument("--debug", action="store_true",
583
 
                        help="Debug mode (show D-Bus commands)")
584
 
    parser.add_argument("--check", action="store_true",
585
 
                        help="Run self-test")
586
 
    parser.add_argument("client", nargs="*", help="Client name")
587
 
 
588
 
 
589
 
def commands_from_options(options):
590
 
 
591
 
    commands = []
592
 
 
593
 
    if options.dump_json:
594
 
        commands.append(DumpJSONCmd())
595
 
 
596
 
    if options.enable:
597
 
        commands.append(EnableCmd())
598
 
 
599
 
    if options.disable:
600
 
        commands.append(DisableCmd())
601
 
 
602
 
    if options.bump_timeout:
603
 
        commands.append(BumpTimeoutCmd())
604
 
 
605
 
    if options.start_checker:
606
 
        commands.append(StartCheckerCmd())
607
 
 
608
 
    if options.stop_checker:
609
 
        commands.append(StopCheckerCmd())
610
 
 
611
 
    if options.is_enabled:
612
 
        commands.append(IsEnabledCmd())
613
 
 
614
 
    if options.checker is not None:
615
 
        commands.append(SetCheckerCmd(options.checker))
616
 
 
617
 
    if options.timeout is not None:
618
 
        commands.append(SetTimeoutCmd(options.timeout))
619
 
 
620
 
    if options.extended_timeout:
621
 
        commands.append(
622
 
            SetExtendedTimeoutCmd(options.extended_timeout))
623
 
 
624
 
    if options.interval is not None:
625
 
        commands.append(SetIntervalCmd(options.interval))
626
 
 
627
 
    if options.approved_by_default is not None:
628
 
        if options.approved_by_default:
629
 
            commands.append(ApproveByDefaultCmd())
630
 
        else:
631
 
            commands.append(DenyByDefaultCmd())
632
 
 
633
 
    if options.approval_delay is not None:
634
 
        commands.append(SetApprovalDelayCmd(options.approval_delay))
635
 
 
636
 
    if options.approval_duration is not None:
637
 
        commands.append(
638
 
            SetApprovalDurationCmd(options.approval_duration))
639
 
 
640
 
    if options.host is not None:
641
 
        commands.append(SetHostCmd(options.host))
642
 
 
643
 
    if options.secret is not None:
644
 
        commands.append(SetSecretCmd(options.secret))
645
 
 
646
 
    if options.approve:
647
 
        commands.append(ApproveCmd())
648
 
 
649
 
    if options.deny:
650
 
        commands.append(DenyCmd())
651
 
 
652
 
    if options.remove:
653
 
        commands.append(RemoveCmd())
654
 
 
655
 
    # If no command option has been given, show table of clients,
656
 
    # optionally verbosely
657
 
    if not commands:
658
 
        commands.append(PrintTableCmd(verbose=options.verbose))
659
 
 
660
 
    return commands
661
 
 
662
 
 
663
385
def check_option_syntax(parser, options):
664
386
    """Apply additional restrictions on options, not expressible in
665
387
argparse"""
695
417
        parser.error("--all requires an action.")
696
418
    if options.is_enabled and len(options.client) > 1:
697
419
        parser.error("--is-enabled requires exactly one client")
698
 
 
699
 
 
700
 
def main():
701
 
    parser = argparse.ArgumentParser()
702
 
 
703
 
    add_command_line_options(parser)
704
 
 
705
 
    options = parser.parse_args()
706
 
 
707
 
    check_option_syntax(parser, options)
708
 
 
709
 
    clientnames = options.client
710
 
 
711
 
    if options.debug:
712
 
        log.setLevel(logging.DEBUG)
713
 
 
 
420
    if options.remove:
 
421
        options.remove = False
 
422
        if has_actions(options) and not options.deny:
 
423
            parser.error("--remove can only be combined with --deny")
 
424
        options.remove = True
 
425
 
 
426
 
 
427
def get_mandos_dbus_object(bus):
 
428
    log.debug("D-Bus: Connect to: (busname=%r, path=%r)",
 
429
              dbus_busname, server_dbus_path)
 
430
    with if_dbus_exception_log_with_exception_and_exit(
 
431
            "Could not connect to Mandos server: %s"):
 
432
        mandos_dbus_object = bus.get_object(dbus_busname,
 
433
                                            server_dbus_path)
 
434
    return mandos_dbus_object
 
435
 
 
436
 
 
437
@contextlib.contextmanager
 
438
def if_dbus_exception_log_with_exception_and_exit(*args, **kwargs):
714
439
    try:
715
 
        bus = dbus.SystemBus()
716
 
        log.debug("D-Bus: Connect to: (name=%r, path=%r)", busname,
717
 
                  server_path)
718
 
        mandos_dbus_objc = bus.get_object(busname, server_path)
719
 
    except dbus.exceptions.DBusException:
720
 
        log.critical("Could not connect to Mandos server")
 
440
        yield
 
441
    except dbus.exceptions.DBusException as e:
 
442
        log.critical(*(args + (e,)), **kwargs)
721
443
        sys.exit(1)
722
444
 
723
 
    mandos_serv = dbus.Interface(mandos_dbus_objc,
724
 
                                 dbus_interface=server_interface)
725
 
    mandos_serv_object_manager = dbus.Interface(
726
 
        mandos_dbus_objc, dbus_interface=dbus.OBJECT_MANAGER_IFACE)
727
 
 
728
 
    # Filter out log message from dbus module
729
 
    dbus_logger = logging.getLogger("dbus.proxies")
 
445
 
 
446
def get_managed_objects(object_manager):
 
447
    log.debug("D-Bus: %s:%s:%s.GetManagedObjects()", dbus_busname,
 
448
              server_dbus_path, dbus.OBJECT_MANAGER_IFACE)
 
449
    with if_dbus_exception_log_with_exception_and_exit(
 
450
            "Failed to access Mandos server through D-Bus:\n%s"):
 
451
        with SilenceLogger("dbus.proxies"):
 
452
            managed_objects = object_manager.GetManagedObjects()
 
453
    return managed_objects
 
454
 
 
455
 
 
456
class SilenceLogger(object):
 
457
    "Simple context manager to silence a particular logger"
 
458
    def __init__(self, loggername):
 
459
        self.logger = logging.getLogger(loggername)
 
460
 
 
461
    def __enter__(self):
 
462
        self.logger.addFilter(self.nullfilter)
 
463
 
730
464
    class NullFilter(logging.Filter):
731
465
        def filter(self, record):
732
466
            return False
733
 
    dbus_filter = NullFilter()
734
 
    try:
735
 
        dbus_logger.addFilter(dbus_filter)
736
 
        log.debug("D-Bus: %s:%s:%s.GetManagedObjects()", busname,
737
 
                  server_path, dbus.OBJECT_MANAGER_IFACE)
738
 
        mandos_clients = {path: ifs_and_props[client_interface]
739
 
                          for path, ifs_and_props in
740
 
                          mandos_serv_object_manager
741
 
                          .GetManagedObjects().items()
742
 
                          if client_interface in ifs_and_props}
743
 
    except dbus.exceptions.DBusException as e:
744
 
        log.critical("Failed to access Mandos server through D-Bus:"
745
 
                     "\n%s", e)
746
 
        sys.exit(1)
747
 
    finally:
748
 
        # restore dbus logger
749
 
        dbus_logger.removeFilter(dbus_filter)
750
 
 
751
 
    # Compile dict of (clients: properties) to process
752
 
    clients = {}
753
 
 
754
 
    if not clientnames:
755
 
        clients = {bus.get_object(busname, path): properties
756
 
                   for path, properties in mandos_clients.items()}
757
 
    else:
758
 
        for name in clientnames:
759
 
            for path, client in mandos_clients.items():
760
 
                if client["Name"] == name:
761
 
                    client_objc = bus.get_object(busname, path)
762
 
                    clients[client_objc] = client
763
 
                    break
764
 
            else:
765
 
                log.critical("Client not found on server: %r", name)
766
 
                sys.exit(1)
767
 
 
768
 
    # Run all commands on clients
769
 
    commands = commands_from_options(options)
770
 
    for command in commands:
771
 
        command.run(mandos_serv, clients)
 
467
 
 
468
    nullfilter = NullFilter()
 
469
 
 
470
    def __exit__(self, exc_type, exc_val, exc_tb):
 
471
        self.logger.removeFilter(self.nullfilter)
 
472
 
 
473
 
 
474
def commands_from_options(options):
 
475
 
 
476
    commands = []
 
477
 
 
478
    if options.is_enabled:
 
479
        commands.append(command.IsEnabled())
 
480
 
 
481
    if options.approve:
 
482
        commands.append(command.Approve())
 
483
 
 
484
    if options.deny:
 
485
        commands.append(command.Deny())
 
486
 
 
487
    if options.remove:
 
488
        commands.append(command.Remove())
 
489
 
 
490
    if options.dump_json:
 
491
        commands.append(command.DumpJSON())
 
492
 
 
493
    if options.enable:
 
494
        commands.append(command.Enable())
 
495
 
 
496
    if options.disable:
 
497
        commands.append(command.Disable())
 
498
 
 
499
    if options.bump_timeout:
 
500
        commands.append(command.BumpTimeout())
 
501
 
 
502
    if options.start_checker:
 
503
        commands.append(command.StartChecker())
 
504
 
 
505
    if options.stop_checker:
 
506
        commands.append(command.StopChecker())
 
507
 
 
508
    if options.approved_by_default is not None:
 
509
        if options.approved_by_default:
 
510
            commands.append(command.ApproveByDefault())
 
511
        else:
 
512
            commands.append(command.DenyByDefault())
 
513
 
 
514
    if options.checker is not None:
 
515
        commands.append(command.SetChecker(options.checker))
 
516
 
 
517
    if options.host is not None:
 
518
        commands.append(command.SetHost(options.host))
 
519
 
 
520
    if options.secret is not None:
 
521
        commands.append(command.SetSecret(options.secret))
 
522
 
 
523
    if options.timeout is not None:
 
524
        commands.append(command.SetTimeout(options.timeout))
 
525
 
 
526
    if options.extended_timeout:
 
527
        commands.append(
 
528
            command.SetExtendedTimeout(options.extended_timeout))
 
529
 
 
530
    if options.interval is not None:
 
531
        commands.append(command.SetInterval(options.interval))
 
532
 
 
533
    if options.approval_delay is not None:
 
534
        commands.append(
 
535
            command.SetApprovalDelay(options.approval_delay))
 
536
 
 
537
    if options.approval_duration is not None:
 
538
        commands.append(
 
539
            command.SetApprovalDuration(options.approval_duration))
 
540
 
 
541
    # If no command option has been given, show table of clients,
 
542
    # optionally verbosely
 
543
    if not commands:
 
544
        commands.append(command.PrintTable(verbose=options.verbose))
 
545
 
 
546
    return commands
 
547
 
 
548
 
 
549
class command(object):
 
550
    """A namespace for command classes"""
 
551
 
 
552
    class Base(object):
 
553
        """Abstract base class for commands"""
 
554
        def run(self, clients, bus=None, mandos=None):
 
555
            """Normal commands should implement run_on_one_client(),
 
556
but commands which want to operate on all clients at the same time can
 
557
override this run() method instead.
 
558
"""
 
559
            self.mandos = mandos
 
560
            for clientpath, properties in clients.items():
 
561
                log.debug("D-Bus: Connect to: (busname=%r, path=%r)",
 
562
                          dbus_busname, str(clientpath))
 
563
                client = bus.get_object(dbus_busname, clientpath)
 
564
                self.run_on_one_client(client, properties)
 
565
 
 
566
 
 
567
    class IsEnabled(Base):
 
568
        def run(self, clients, bus=None, mandos=None):
 
569
            client, properties = next(iter(clients.items()))
 
570
            if self.is_enabled(client, properties):
 
571
                sys.exit(0)
 
572
            sys.exit(1)
 
573
        def is_enabled(self, client, properties):
 
574
            return properties["Enabled"]
 
575
 
 
576
 
 
577
    class Approve(Base):
 
578
        def run_on_one_client(self, client, properties):
 
579
            log.debug("D-Bus: %s:%s:%s.Approve(True)", dbus_busname,
 
580
                      client.__dbus_object_path__,
 
581
                      client_dbus_interface)
 
582
            client.Approve(dbus.Boolean(True),
 
583
                           dbus_interface=client_dbus_interface)
 
584
 
 
585
 
 
586
    class Deny(Base):
 
587
        def run_on_one_client(self, client, properties):
 
588
            log.debug("D-Bus: %s:%s:%s.Approve(False)", dbus_busname,
 
589
                      client.__dbus_object_path__,
 
590
                      client_dbus_interface)
 
591
            client.Approve(dbus.Boolean(False),
 
592
                           dbus_interface=client_dbus_interface)
 
593
 
 
594
 
 
595
    class Remove(Base):
 
596
        def run_on_one_client(self, client, properties):
 
597
            log.debug("D-Bus: %s:%s:%s.RemoveClient(%r)",
 
598
                      dbus_busname, server_dbus_path,
 
599
                      server_dbus_interface,
 
600
                      str(client.__dbus_object_path__))
 
601
            self.mandos.RemoveClient(client.__dbus_object_path__)
 
602
 
 
603
 
 
604
    class Output(Base):
 
605
        """Abstract class for commands outputting client details"""
 
606
        all_keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK",
 
607
                        "Created", "Interval", "Host", "KeyID",
 
608
                        "Fingerprint", "CheckerRunning",
 
609
                        "LastEnabled", "ApprovalPending",
 
610
                        "ApprovedByDefault", "LastApprovalRequest",
 
611
                        "ApprovalDelay", "ApprovalDuration",
 
612
                        "Checker", "ExtendedTimeout", "Expires",
 
613
                        "LastCheckerStatus")
 
614
 
 
615
 
 
616
    class DumpJSON(Output):
 
617
        def run(self, clients, bus=None, mandos=None):
 
618
            data = {client["Name"]:
 
619
                    {key: self.dbus_boolean_to_bool(client[key])
 
620
                     for key in self.all_keywords}
 
621
                    for client in clients.values()}
 
622
            print(json.dumps(data, indent=4, separators=(',', ': ')))
 
623
 
 
624
        @staticmethod
 
625
        def dbus_boolean_to_bool(value):
 
626
            if isinstance(value, dbus.Boolean):
 
627
                value = bool(value)
 
628
            return value
 
629
 
 
630
 
 
631
    class PrintTable(Output):
 
632
        def __init__(self, verbose=False):
 
633
            self.verbose = verbose
 
634
 
 
635
        def run(self, clients, bus=None, mandos=None):
 
636
            default_keywords = ("Name", "Enabled", "Timeout",
 
637
                                "LastCheckedOK")
 
638
            keywords = default_keywords
 
639
            if self.verbose:
 
640
                keywords = self.all_keywords
 
641
            print(self.TableOfClients(clients.values(), keywords))
 
642
 
 
643
        class TableOfClients(object):
 
644
            tableheaders = {
 
645
                "Name": "Name",
 
646
                "Enabled": "Enabled",
 
647
                "Timeout": "Timeout",
 
648
                "LastCheckedOK": "Last Successful Check",
 
649
                "LastApprovalRequest": "Last Approval Request",
 
650
                "Created": "Created",
 
651
                "Interval": "Interval",
 
652
                "Host": "Host",
 
653
                "Fingerprint": "Fingerprint",
 
654
                "KeyID": "Key ID",
 
655
                "CheckerRunning": "Check Is Running",
 
656
                "LastEnabled": "Last Enabled",
 
657
                "ApprovalPending": "Approval Is Pending",
 
658
                "ApprovedByDefault": "Approved By Default",
 
659
                "ApprovalDelay": "Approval Delay",
 
660
                "ApprovalDuration": "Approval Duration",
 
661
                "Checker": "Checker",
 
662
                "ExtendedTimeout": "Extended Timeout",
 
663
                "Expires": "Expires",
 
664
                "LastCheckerStatus": "Last Checker Status",
 
665
            }
 
666
 
 
667
            def __init__(self, clients, keywords):
 
668
                self.clients = clients
 
669
                self.keywords = keywords
 
670
 
 
671
            def __str__(self):
 
672
                return "\n".join(self.rows())
 
673
 
 
674
            if sys.version_info.major == 2:
 
675
                __unicode__ = __str__
 
676
                def __str__(self):
 
677
                    return str(self).encode(
 
678
                        locale.getpreferredencoding())
 
679
 
 
680
            def rows(self):
 
681
                format_string = self.row_formatting_string()
 
682
                rows = [self.header_line(format_string)]
 
683
                rows.extend(self.client_line(client, format_string)
 
684
                            for client in self.clients)
 
685
                return rows
 
686
 
 
687
            def row_formatting_string(self):
 
688
                "Format string used to format table rows"
 
689
                return " ".join("{{{key}:{width}}}".format(
 
690
                    width=max(len(self.tableheaders[key]),
 
691
                              *(len(self.string_from_client(client,
 
692
                                                            key))
 
693
                                for client in self.clients)),
 
694
                    key=key)
 
695
                                for key in self.keywords)
 
696
 
 
697
            def string_from_client(self, client, key):
 
698
                return self.valuetostring(client[key], key)
 
699
 
 
700
            @classmethod
 
701
            def valuetostring(cls, value, keyword):
 
702
                if isinstance(value, dbus.Boolean):
 
703
                    return "Yes" if value else "No"
 
704
                if keyword in ("Timeout", "Interval", "ApprovalDelay",
 
705
                               "ApprovalDuration", "ExtendedTimeout"):
 
706
                    return cls.milliseconds_to_string(value)
 
707
                return str(value)
 
708
 
 
709
            def header_line(self, format_string):
 
710
                return format_string.format(**self.tableheaders)
 
711
 
 
712
            def client_line(self, client, format_string):
 
713
                return format_string.format(
 
714
                    **{key: self.string_from_client(client, key)
 
715
                       for key in self.keywords})
 
716
 
 
717
            @staticmethod
 
718
            def milliseconds_to_string(ms):
 
719
                td = datetime.timedelta(0, 0, 0, ms)
 
720
                return ("{days}{hours:02}:{minutes:02}:{seconds:02}"
 
721
                        .format(days="{}T".format(td.days)
 
722
                                if td.days else "",
 
723
                                hours=td.seconds // 3600,
 
724
                                minutes=(td.seconds % 3600) // 60,
 
725
                                seconds=td.seconds % 60))
 
726
 
 
727
 
 
728
    class PropertySetter(Base):
 
729
        "Abstract class for Actions for setting one client property"
 
730
 
 
731
        def run_on_one_client(self, client, properties):
 
732
            """Set the Client's D-Bus property"""
 
733
            log.debug("D-Bus: %s:%s:%s.Set(%r, %r, %r)", dbus_busname,
 
734
                      client.__dbus_object_path__,
 
735
                      dbus.PROPERTIES_IFACE, client_dbus_interface,
 
736
                      self.propname, self.value_to_set
 
737
                      if not isinstance(self.value_to_set,
 
738
                                        dbus.Boolean)
 
739
                      else bool(self.value_to_set))
 
740
            client.Set(client_dbus_interface, self.propname,
 
741
                       self.value_to_set,
 
742
                       dbus_interface=dbus.PROPERTIES_IFACE)
 
743
 
 
744
        @property
 
745
        def propname(self):
 
746
            raise NotImplementedError()
 
747
 
 
748
 
 
749
    class Enable(PropertySetter):
 
750
        propname = "Enabled"
 
751
        value_to_set = dbus.Boolean(True)
 
752
 
 
753
 
 
754
    class Disable(PropertySetter):
 
755
        propname = "Enabled"
 
756
        value_to_set = dbus.Boolean(False)
 
757
 
 
758
 
 
759
    class BumpTimeout(PropertySetter):
 
760
        propname = "LastCheckedOK"
 
761
        value_to_set = ""
 
762
 
 
763
 
 
764
    class StartChecker(PropertySetter):
 
765
        propname = "CheckerRunning"
 
766
        value_to_set = dbus.Boolean(True)
 
767
 
 
768
 
 
769
    class StopChecker(PropertySetter):
 
770
        propname = "CheckerRunning"
 
771
        value_to_set = dbus.Boolean(False)
 
772
 
 
773
 
 
774
    class ApproveByDefault(PropertySetter):
 
775
        propname = "ApprovedByDefault"
 
776
        value_to_set = dbus.Boolean(True)
 
777
 
 
778
 
 
779
    class DenyByDefault(PropertySetter):
 
780
        propname = "ApprovedByDefault"
 
781
        value_to_set = dbus.Boolean(False)
 
782
 
 
783
 
 
784
    class PropertySetterValue(PropertySetter):
 
785
        """Abstract class for PropertySetter recieving a value as
 
786
constructor argument instead of a class attribute."""
 
787
        def __init__(self, value):
 
788
            self.value_to_set = value
 
789
 
 
790
 
 
791
    class SetChecker(PropertySetterValue):
 
792
        propname = "Checker"
 
793
 
 
794
 
 
795
    class SetHost(PropertySetterValue):
 
796
        propname = "Host"
 
797
 
 
798
 
 
799
    class SetSecret(PropertySetterValue):
 
800
        propname = "Secret"
 
801
 
 
802
        @property
 
803
        def value_to_set(self):
 
804
            return self._vts
 
805
 
 
806
        @value_to_set.setter
 
807
        def value_to_set(self, value):
 
808
            """When setting, read data from supplied file object"""
 
809
            self._vts = value.read()
 
810
            value.close()
 
811
 
 
812
 
 
813
    class PropertySetterValueMilliseconds(PropertySetterValue):
 
814
        """Abstract class for PropertySetterValue taking a value
 
815
argument as a datetime.timedelta() but should store it as
 
816
milliseconds."""
 
817
 
 
818
        @property
 
819
        def value_to_set(self):
 
820
            return self._vts
 
821
 
 
822
        @value_to_set.setter
 
823
        def value_to_set(self, value):
 
824
            "When setting, convert value from a datetime.timedelta"
 
825
            self._vts = int(round(value.total_seconds() * 1000))
 
826
 
 
827
 
 
828
    class SetTimeout(PropertySetterValueMilliseconds):
 
829
        propname = "Timeout"
 
830
 
 
831
 
 
832
    class SetExtendedTimeout(PropertySetterValueMilliseconds):
 
833
        propname = "ExtendedTimeout"
 
834
 
 
835
 
 
836
    class SetInterval(PropertySetterValueMilliseconds):
 
837
        propname = "Interval"
 
838
 
 
839
 
 
840
    class SetApprovalDelay(PropertySetterValueMilliseconds):
 
841
        propname = "ApprovalDelay"
 
842
 
 
843
 
 
844
    class SetApprovalDuration(PropertySetterValueMilliseconds):
 
845
        propname = "ApprovalDuration"
 
846
 
772
847
 
773
848
 
774
 
class Test_milliseconds_to_string(unittest.TestCase):
775
 
    def test_all(self):
776
 
        self.assertEqual(milliseconds_to_string(93785000),
777
 
                         "1T02:03:05")
778
 
    def test_no_days(self):
779
 
        self.assertEqual(milliseconds_to_string(7385000), "02:03:05")
780
 
    def test_all_zero(self):
781
 
        self.assertEqual(milliseconds_to_string(0), "00:00:00")
782
 
    def test_no_fractional_seconds(self):
783
 
        self.assertEqual(milliseconds_to_string(400), "00:00:00")
784
 
        self.assertEqual(milliseconds_to_string(900), "00:00:00")
785
 
        self.assertEqual(milliseconds_to_string(1900), "00:00:01")
786
 
 
787
 
class Test_string_to_delta(unittest.TestCase):
788
 
    def test_handles_basic_rfc3339(self):
789
 
        self.assertEqual(string_to_delta("PT0S"),
790
 
                         datetime.timedelta())
791
 
        self.assertEqual(string_to_delta("P0D"),
792
 
                         datetime.timedelta())
793
 
        self.assertEqual(string_to_delta("PT1S"),
794
 
                         datetime.timedelta(0, 1))
795
 
        self.assertEqual(string_to_delta("PT2H"),
796
 
                         datetime.timedelta(0, 7200))
 
849
class TestCaseWithAssertLogs(unittest.TestCase):
 
850
    """unittest.TestCase.assertLogs only exists in Python 3.4"""
 
851
 
 
852
    if not hasattr(unittest.TestCase, "assertLogs"):
 
853
        @contextlib.contextmanager
 
854
        def assertLogs(self, logger, level=logging.INFO):
 
855
            capturing_handler = self.CapturingLevelHandler(level)
 
856
            old_level = logger.level
 
857
            old_propagate = logger.propagate
 
858
            logger.addHandler(capturing_handler)
 
859
            logger.setLevel(level)
 
860
            logger.propagate = False
 
861
            try:
 
862
                yield capturing_handler.watcher
 
863
            finally:
 
864
                logger.propagate = old_propagate
 
865
                logger.removeHandler(capturing_handler)
 
866
                logger.setLevel(old_level)
 
867
            self.assertGreater(len(capturing_handler.watcher.records),
 
868
                               0)
 
869
 
 
870
        class CapturingLevelHandler(logging.Handler):
 
871
            def __init__(self, level, *args, **kwargs):
 
872
                logging.Handler.__init__(self, *args, **kwargs)
 
873
                self.watcher = self.LoggingWatcher([], [])
 
874
            def emit(self, record):
 
875
                self.watcher.records.append(record)
 
876
                self.watcher.output.append(self.format(record))
 
877
 
 
878
            LoggingWatcher = collections.namedtuple("LoggingWatcher",
 
879
                                                    ("records",
 
880
                                                     "output"))
 
881
 
 
882
 
 
883
class Test_string_to_delta(TestCaseWithAssertLogs):
 
884
    # Just test basic RFC 3339 functionality here, the doc string for
 
885
    # rfc3339_duration_to_delta() already has more comprehensive
 
886
    # tests, which is run by doctest.
 
887
 
 
888
    def test_rfc3339_zero_seconds(self):
 
889
        self.assertEqual(datetime.timedelta(),
 
890
                         string_to_delta("PT0S"))
 
891
 
 
892
    def test_rfc3339_zero_days(self):
 
893
        self.assertEqual(datetime.timedelta(), string_to_delta("P0D"))
 
894
 
 
895
    def test_rfc3339_one_second(self):
 
896
        self.assertEqual(datetime.timedelta(0, 1),
 
897
                         string_to_delta("PT1S"))
 
898
 
 
899
    def test_rfc3339_two_hours(self):
 
900
        self.assertEqual(datetime.timedelta(0, 7200),
 
901
                         string_to_delta("PT2H"))
 
902
 
797
903
    def test_falls_back_to_pre_1_6_1_with_warning(self):
798
 
        # assertLogs only exists in Python 3.4
799
 
        if hasattr(self, "assertLogs"):
800
 
            with self.assertLogs(log, logging.WARNING):
801
 
                value = string_to_delta("2h")
802
 
        else:
803
 
            class WarningFilter(logging.Filter):
804
 
                """Don't show, but record the presence of, warnings"""
805
 
                def filter(self, record):
806
 
                    is_warning = record.levelno >= logging.WARNING
807
 
                    self.found = is_warning or getattr(self, "found",
808
 
                                                       False)
809
 
                    return not is_warning
810
 
            warning_filter = WarningFilter()
811
 
            log.addFilter(warning_filter)
 
904
        with self.assertLogs(log, logging.WARNING):
 
905
            value = string_to_delta("2h")
 
906
        self.assertEqual(datetime.timedelta(0, 7200), value)
 
907
 
 
908
 
 
909
class Test_check_option_syntax(unittest.TestCase):
 
910
    def setUp(self):
 
911
        self.parser = argparse.ArgumentParser()
 
912
        add_command_line_options(self.parser)
 
913
 
 
914
    def test_actions_requires_client_or_all(self):
 
915
        for action, value in self.actions.items():
 
916
            options = self.parser.parse_args()
 
917
            setattr(options, action, value)
 
918
            with self.assertParseError():
 
919
                self.check_option_syntax(options)
 
920
 
 
921
    # This mostly corresponds to the definition from has_actions() in
 
922
    # check_option_syntax()
 
923
    actions = {
 
924
        # The actual values set here are not that important, but we do
 
925
        # at least stick to the correct types, even though they are
 
926
        # never used
 
927
        "enable": True,
 
928
        "disable": True,
 
929
        "bump_timeout": True,
 
930
        "start_checker": True,
 
931
        "stop_checker": True,
 
932
        "is_enabled": True,
 
933
        "remove": True,
 
934
        "checker": "x",
 
935
        "timeout": datetime.timedelta(),
 
936
        "extended_timeout": datetime.timedelta(),
 
937
        "interval": datetime.timedelta(),
 
938
        "approved_by_default": True,
 
939
        "approval_delay": datetime.timedelta(),
 
940
        "approval_duration": datetime.timedelta(),
 
941
        "host": "x",
 
942
        "secret": io.BytesIO(b"x"),
 
943
        "approve": True,
 
944
        "deny": True,
 
945
    }
 
946
 
 
947
    @contextlib.contextmanager
 
948
    def assertParseError(self):
 
949
        with self.assertRaises(SystemExit) as e:
 
950
            with self.redirect_stderr_to_devnull():
 
951
                yield
 
952
        # Exit code from argparse is guaranteed to be "2".  Reference:
 
953
        # https://docs.python.org/3/library
 
954
        # /argparse.html#exiting-methods
 
955
        self.assertEqual(2, e.exception.code)
 
956
 
 
957
    @staticmethod
 
958
    @contextlib.contextmanager
 
959
    def redirect_stderr_to_devnull():
 
960
        old_stderr = sys.stderr
 
961
        with contextlib.closing(open(os.devnull, "w")) as null:
 
962
            sys.stderr = null
812
963
            try:
813
 
                value = string_to_delta("2h")
 
964
                yield
814
965
            finally:
815
 
                log.removeFilter(warning_filter)
816
 
            self.assertTrue(getattr(warning_filter, "found", False))
817
 
        self.assertEqual(value, datetime.timedelta(0, 7200))
818
 
 
819
 
 
820
 
class TestCmd(unittest.TestCase):
 
966
                sys.stderr = old_stderr
 
967
 
 
968
    def check_option_syntax(self, options):
 
969
        check_option_syntax(self.parser, options)
 
970
 
 
971
    def test_actions_all_conflicts_with_verbose(self):
 
972
        for action, value in self.actions.items():
 
973
            options = self.parser.parse_args()
 
974
            setattr(options, action, value)
 
975
            options.all = True
 
976
            options.verbose = True
 
977
            with self.assertParseError():
 
978
                self.check_option_syntax(options)
 
979
 
 
980
    def test_actions_with_client_conflicts_with_verbose(self):
 
981
        for action, value in self.actions.items():
 
982
            options = self.parser.parse_args()
 
983
            setattr(options, action, value)
 
984
            options.verbose = True
 
985
            options.client = ["client"]
 
986
            with self.assertParseError():
 
987
                self.check_option_syntax(options)
 
988
 
 
989
    def test_dump_json_conflicts_with_verbose(self):
 
990
        options = self.parser.parse_args()
 
991
        options.dump_json = True
 
992
        options.verbose = True
 
993
        with self.assertParseError():
 
994
            self.check_option_syntax(options)
 
995
 
 
996
    def test_dump_json_conflicts_with_action(self):
 
997
        for action, value in self.actions.items():
 
998
            options = self.parser.parse_args()
 
999
            setattr(options, action, value)
 
1000
            options.dump_json = True
 
1001
            with self.assertParseError():
 
1002
                self.check_option_syntax(options)
 
1003
 
 
1004
    def test_all_can_not_be_alone(self):
 
1005
        options = self.parser.parse_args()
 
1006
        options.all = True
 
1007
        with self.assertParseError():
 
1008
            self.check_option_syntax(options)
 
1009
 
 
1010
    def test_all_is_ok_with_any_action(self):
 
1011
        for action, value in self.actions.items():
 
1012
            options = self.parser.parse_args()
 
1013
            setattr(options, action, value)
 
1014
            options.all = True
 
1015
            self.check_option_syntax(options)
 
1016
 
 
1017
    def test_any_action_is_ok_with_one_client(self):
 
1018
        for action, value in self.actions.items():
 
1019
            options = self.parser.parse_args()
 
1020
            setattr(options, action, value)
 
1021
            options.client = ["client"]
 
1022
            self.check_option_syntax(options)
 
1023
 
 
1024
    def test_one_client_with_all_actions_except_is_enabled(self):
 
1025
        options = self.parser.parse_args()
 
1026
        for action, value in self.actions.items():
 
1027
            if action == "is_enabled":
 
1028
                continue
 
1029
            setattr(options, action, value)
 
1030
        options.client = ["client"]
 
1031
        self.check_option_syntax(options)
 
1032
 
 
1033
    def test_two_clients_with_all_actions_except_is_enabled(self):
 
1034
        options = self.parser.parse_args()
 
1035
        for action, value in self.actions.items():
 
1036
            if action == "is_enabled":
 
1037
                continue
 
1038
            setattr(options, action, value)
 
1039
        options.client = ["client1", "client2"]
 
1040
        self.check_option_syntax(options)
 
1041
 
 
1042
    def test_two_clients_are_ok_with_actions_except_is_enabled(self):
 
1043
        for action, value in self.actions.items():
 
1044
            if action == "is_enabled":
 
1045
                continue
 
1046
            options = self.parser.parse_args()
 
1047
            setattr(options, action, value)
 
1048
            options.client = ["client1", "client2"]
 
1049
            self.check_option_syntax(options)
 
1050
 
 
1051
    def test_is_enabled_fails_without_client(self):
 
1052
        options = self.parser.parse_args()
 
1053
        options.is_enabled = True
 
1054
        with self.assertParseError():
 
1055
            self.check_option_syntax(options)
 
1056
 
 
1057
    def test_is_enabled_fails_with_two_clients(self):
 
1058
        options = self.parser.parse_args()
 
1059
        options.is_enabled = True
 
1060
        options.client = ["client1", "client2"]
 
1061
        with self.assertParseError():
 
1062
            self.check_option_syntax(options)
 
1063
 
 
1064
    def test_remove_can_only_be_combined_with_action_deny(self):
 
1065
        for action, value in self.actions.items():
 
1066
            if action in {"remove", "deny"}:
 
1067
                continue
 
1068
            options = self.parser.parse_args()
 
1069
            setattr(options, action, value)
 
1070
            options.all = True
 
1071
            options.remove = True
 
1072
            with self.assertParseError():
 
1073
                self.check_option_syntax(options)
 
1074
 
 
1075
 
 
1076
class Test_get_mandos_dbus_object(TestCaseWithAssertLogs):
 
1077
    def test_calls_and_returns_get_object_on_bus(self):
 
1078
        class MockBus(object):
 
1079
            called = False
 
1080
            def get_object(mockbus_self, busname, dbus_path):
 
1081
                # Note that "self" is still the testcase instance,
 
1082
                # this MockBus instance is in "mockbus_self".
 
1083
                self.assertEqual(dbus_busname, busname)
 
1084
                self.assertEqual(server_dbus_path, dbus_path)
 
1085
                mockbus_self.called = True
 
1086
                return mockbus_self
 
1087
 
 
1088
        mockbus = get_mandos_dbus_object(bus=MockBus())
 
1089
        self.assertIsInstance(mockbus, MockBus)
 
1090
        self.assertTrue(mockbus.called)
 
1091
 
 
1092
    def test_logs_and_exits_on_dbus_error(self):
 
1093
        class FailingBusStub(object):
 
1094
            def get_object(self, busname, dbus_path):
 
1095
                raise dbus.exceptions.DBusException("Test")
 
1096
 
 
1097
        with self.assertLogs(log, logging.CRITICAL):
 
1098
            with self.assertRaises(SystemExit) as e:
 
1099
                bus = get_mandos_dbus_object(bus=FailingBusStub())
 
1100
 
 
1101
        if isinstance(e.exception.code, int):
 
1102
            self.assertNotEqual(0, e.exception.code)
 
1103
        else:
 
1104
            self.assertIsNotNone(e.exception.code)
 
1105
 
 
1106
 
 
1107
class Test_get_managed_objects(TestCaseWithAssertLogs):
 
1108
    def test_calls_and_returns_GetManagedObjects(self):
 
1109
        managed_objects = {"/clients/client": { "Name": "client"}}
 
1110
        class ObjectManagerStub(object):
 
1111
            def GetManagedObjects(self):
 
1112
                return managed_objects
 
1113
        retval = get_managed_objects(ObjectManagerStub())
 
1114
        self.assertDictEqual(managed_objects, retval)
 
1115
 
 
1116
    def test_logs_and_exits_on_dbus_error(self):
 
1117
        dbus_logger = logging.getLogger("dbus.proxies")
 
1118
 
 
1119
        class ObjectManagerFailingStub(object):
 
1120
            def GetManagedObjects(self):
 
1121
                dbus_logger.error("Test")
 
1122
                raise dbus.exceptions.DBusException("Test")
 
1123
 
 
1124
        class CountingHandler(logging.Handler):
 
1125
            count = 0
 
1126
            def emit(self, record):
 
1127
                self.count += 1
 
1128
 
 
1129
        counting_handler = CountingHandler()
 
1130
 
 
1131
        dbus_logger.addHandler(counting_handler)
 
1132
 
 
1133
        try:
 
1134
            with self.assertLogs(log, logging.CRITICAL) as watcher:
 
1135
                with self.assertRaises(SystemExit) as e:
 
1136
                    get_managed_objects(ObjectManagerFailingStub())
 
1137
        finally:
 
1138
            dbus_logger.removeFilter(counting_handler)
 
1139
 
 
1140
        # Make sure the dbus logger was suppressed
 
1141
        self.assertEqual(0, counting_handler.count)
 
1142
 
 
1143
        # Test that the dbus_logger still works
 
1144
        with self.assertLogs(dbus_logger, logging.ERROR):
 
1145
            dbus_logger.error("Test")
 
1146
 
 
1147
        if isinstance(e.exception.code, int):
 
1148
            self.assertNotEqual(0, e.exception.code)
 
1149
        else:
 
1150
            self.assertIsNotNone(e.exception.code)
 
1151
 
 
1152
 
 
1153
class Test_commands_from_options(unittest.TestCase):
 
1154
    def setUp(self):
 
1155
        self.parser = argparse.ArgumentParser()
 
1156
        add_command_line_options(self.parser)
 
1157
 
 
1158
    def test_is_enabled(self):
 
1159
        self.assert_command_from_args(["--is-enabled", "client"],
 
1160
                                      command.IsEnabled)
 
1161
 
 
1162
    def assert_command_from_args(self, args, command_cls,
 
1163
                                 **cmd_attrs):
 
1164
        """Assert that parsing ARGS should result in an instance of
 
1165
COMMAND_CLS with (optionally) all supplied attributes (CMD_ATTRS)."""
 
1166
        options = self.parser.parse_args(args)
 
1167
        check_option_syntax(self.parser, options)
 
1168
        commands = commands_from_options(options)
 
1169
        self.assertEqual(1, len(commands))
 
1170
        command = commands[0]
 
1171
        self.assertIsInstance(command, command_cls)
 
1172
        for key, value in cmd_attrs.items():
 
1173
            self.assertEqual(value, getattr(command, key))
 
1174
 
 
1175
    def test_is_enabled_short(self):
 
1176
        self.assert_command_from_args(["-V", "client"],
 
1177
                                      command.IsEnabled)
 
1178
 
 
1179
    def test_approve(self):
 
1180
        self.assert_command_from_args(["--approve", "client"],
 
1181
                                      command.Approve)
 
1182
 
 
1183
    def test_approve_short(self):
 
1184
        self.assert_command_from_args(["-A", "client"],
 
1185
                                      command.Approve)
 
1186
 
 
1187
    def test_deny(self):
 
1188
        self.assert_command_from_args(["--deny", "client"],
 
1189
                                      command.Deny)
 
1190
 
 
1191
    def test_deny_short(self):
 
1192
        self.assert_command_from_args(["-D", "client"], command.Deny)
 
1193
 
 
1194
    def test_remove(self):
 
1195
        self.assert_command_from_args(["--remove", "client"],
 
1196
                                      command.Remove)
 
1197
 
 
1198
    def test_deny_before_remove(self):
 
1199
        options = self.parser.parse_args(["--deny", "--remove",
 
1200
                                          "client"])
 
1201
        check_option_syntax(self.parser, options)
 
1202
        commands = commands_from_options(options)
 
1203
        self.assertEqual(2, len(commands))
 
1204
        self.assertIsInstance(commands[0], command.Deny)
 
1205
        self.assertIsInstance(commands[1], command.Remove)
 
1206
 
 
1207
    def test_deny_before_remove_reversed(self):
 
1208
        options = self.parser.parse_args(["--remove", "--deny",
 
1209
                                          "--all"])
 
1210
        check_option_syntax(self.parser, options)
 
1211
        commands = commands_from_options(options)
 
1212
        self.assertEqual(2, len(commands))
 
1213
        self.assertIsInstance(commands[0], command.Deny)
 
1214
        self.assertIsInstance(commands[1], command.Remove)
 
1215
 
 
1216
    def test_remove_short(self):
 
1217
        self.assert_command_from_args(["-r", "client"],
 
1218
                                      command.Remove)
 
1219
 
 
1220
    def test_dump_json(self):
 
1221
        self.assert_command_from_args(["--dump-json"],
 
1222
                                      command.DumpJSON)
 
1223
 
 
1224
    def test_enable(self):
 
1225
        self.assert_command_from_args(["--enable", "client"],
 
1226
                                      command.Enable)
 
1227
 
 
1228
    def test_enable_short(self):
 
1229
        self.assert_command_from_args(["-e", "client"],
 
1230
                                      command.Enable)
 
1231
 
 
1232
    def test_disable(self):
 
1233
        self.assert_command_from_args(["--disable", "client"],
 
1234
                                      command.Disable)
 
1235
 
 
1236
    def test_disable_short(self):
 
1237
        self.assert_command_from_args(["-d", "client"],
 
1238
                                      command.Disable)
 
1239
 
 
1240
    def test_bump_timeout(self):
 
1241
        self.assert_command_from_args(["--bump-timeout", "client"],
 
1242
                                      command.BumpTimeout)
 
1243
 
 
1244
    def test_bump_timeout_short(self):
 
1245
        self.assert_command_from_args(["-b", "client"],
 
1246
                                      command.BumpTimeout)
 
1247
 
 
1248
    def test_start_checker(self):
 
1249
        self.assert_command_from_args(["--start-checker", "client"],
 
1250
                                      command.StartChecker)
 
1251
 
 
1252
    def test_stop_checker(self):
 
1253
        self.assert_command_from_args(["--stop-checker", "client"],
 
1254
                                      command.StopChecker)
 
1255
 
 
1256
    def test_approve_by_default(self):
 
1257
        self.assert_command_from_args(["--approve-by-default",
 
1258
                                       "client"],
 
1259
                                      command.ApproveByDefault)
 
1260
 
 
1261
    def test_deny_by_default(self):
 
1262
        self.assert_command_from_args(["--deny-by-default", "client"],
 
1263
                                      command.DenyByDefault)
 
1264
 
 
1265
    def test_checker(self):
 
1266
        self.assert_command_from_args(["--checker", ":", "client"],
 
1267
                                      command.SetChecker,
 
1268
                                      value_to_set=":")
 
1269
 
 
1270
    def test_checker_empty(self):
 
1271
        self.assert_command_from_args(["--checker", "", "client"],
 
1272
                                      command.SetChecker,
 
1273
                                      value_to_set="")
 
1274
 
 
1275
    def test_checker_short(self):
 
1276
        self.assert_command_from_args(["-c", ":", "client"],
 
1277
                                      command.SetChecker,
 
1278
                                      value_to_set=":")
 
1279
 
 
1280
    def test_host(self):
 
1281
        self.assert_command_from_args(
 
1282
            ["--host", "client.example.org", "client"],
 
1283
            command.SetHost, value_to_set="client.example.org")
 
1284
 
 
1285
    def test_host_short(self):
 
1286
        self.assert_command_from_args(
 
1287
            ["-H", "client.example.org", "client"], command.SetHost,
 
1288
            value_to_set="client.example.org")
 
1289
 
 
1290
    def test_secret_devnull(self):
 
1291
        self.assert_command_from_args(["--secret", os.path.devnull,
 
1292
                                       "client"], command.SetSecret,
 
1293
                                      value_to_set=b"")
 
1294
 
 
1295
    def test_secret_tempfile(self):
 
1296
        with tempfile.NamedTemporaryFile(mode="r+b") as f:
 
1297
            value = b"secret\0xyzzy\nbar"
 
1298
            f.write(value)
 
1299
            f.seek(0)
 
1300
            self.assert_command_from_args(["--secret", f.name,
 
1301
                                           "client"],
 
1302
                                          command.SetSecret,
 
1303
                                          value_to_set=value)
 
1304
 
 
1305
    def test_secret_devnull_short(self):
 
1306
        self.assert_command_from_args(["-s", os.path.devnull,
 
1307
                                       "client"], command.SetSecret,
 
1308
                                      value_to_set=b"")
 
1309
 
 
1310
    def test_secret_tempfile_short(self):
 
1311
        with tempfile.NamedTemporaryFile(mode="r+b") as f:
 
1312
            value = b"secret\0xyzzy\nbar"
 
1313
            f.write(value)
 
1314
            f.seek(0)
 
1315
            self.assert_command_from_args(["-s", f.name, "client"],
 
1316
                                          command.SetSecret,
 
1317
                                          value_to_set=value)
 
1318
 
 
1319
    def test_timeout(self):
 
1320
        self.assert_command_from_args(["--timeout", "PT5M", "client"],
 
1321
                                      command.SetTimeout,
 
1322
                                      value_to_set=300000)
 
1323
 
 
1324
    def test_timeout_short(self):
 
1325
        self.assert_command_from_args(["-t", "PT5M", "client"],
 
1326
                                      command.SetTimeout,
 
1327
                                      value_to_set=300000)
 
1328
 
 
1329
    def test_extended_timeout(self):
 
1330
        self.assert_command_from_args(["--extended-timeout", "PT15M",
 
1331
                                       "client"],
 
1332
                                      command.SetExtendedTimeout,
 
1333
                                      value_to_set=900000)
 
1334
 
 
1335
    def test_interval(self):
 
1336
        self.assert_command_from_args(["--interval", "PT2M",
 
1337
                                       "client"], command.SetInterval,
 
1338
                                      value_to_set=120000)
 
1339
 
 
1340
    def test_interval_short(self):
 
1341
        self.assert_command_from_args(["-i", "PT2M", "client"],
 
1342
                                      command.SetInterval,
 
1343
                                      value_to_set=120000)
 
1344
 
 
1345
    def test_approval_delay(self):
 
1346
        self.assert_command_from_args(["--approval-delay", "PT30S",
 
1347
                                       "client"],
 
1348
                                      command.SetApprovalDelay,
 
1349
                                      value_to_set=30000)
 
1350
 
 
1351
    def test_approval_duration(self):
 
1352
        self.assert_command_from_args(["--approval-duration", "PT1S",
 
1353
                                       "client"],
 
1354
                                      command.SetApprovalDuration,
 
1355
                                      value_to_set=1000)
 
1356
 
 
1357
    def test_print_table(self):
 
1358
        self.assert_command_from_args([], command.PrintTable,
 
1359
                                      verbose=False)
 
1360
 
 
1361
    def test_print_table_verbose(self):
 
1362
        self.assert_command_from_args(["--verbose"],
 
1363
                                      command.PrintTable,
 
1364
                                      verbose=True)
 
1365
 
 
1366
    def test_print_table_verbose_short(self):
 
1367
        self.assert_command_from_args(["-v"], command.PrintTable,
 
1368
                                      verbose=True)
 
1369
 
 
1370
 
 
1371
class TestCommand(unittest.TestCase):
821
1372
    """Abstract class for tests of command classes"""
 
1373
 
822
1374
    def setUp(self):
823
1375
        testcase = self
824
1376
        class MockClient(object):
825
1377
            def __init__(self, name, **attributes):
826
 
                self.__dbus_object_path__ = "objpath_{}".format(name)
 
1378
                self.__dbus_object_path__ = "/clients/{}".format(name)
827
1379
                self.attributes = attributes
828
1380
                self.attributes["Name"] = name
829
1381
                self.calls = []
830
 
            def Set(self, interface, property, value, dbus_interface):
831
 
                testcase.assertEqual(interface, client_interface)
832
 
                testcase.assertEqual(dbus_interface,
833
 
                                     dbus.PROPERTIES_IFACE)
834
 
                self.attributes[property] = value
835
 
            def Get(self, interface, property, dbus_interface):
836
 
                testcase.assertEqual(interface, client_interface)
837
 
                testcase.assertEqual(dbus_interface,
838
 
                                     dbus.PROPERTIES_IFACE)
839
 
                return self.attributes[property]
 
1382
            def Set(self, interface, propname, value, dbus_interface):
 
1383
                testcase.assertEqual(client_dbus_interface, interface)
 
1384
                testcase.assertEqual(dbus.PROPERTIES_IFACE,
 
1385
                                     dbus_interface)
 
1386
                self.attributes[propname] = value
840
1387
            def Approve(self, approve, dbus_interface):
841
 
                testcase.assertEqual(dbus_interface, client_interface)
 
1388
                testcase.assertEqual(client_dbus_interface,
 
1389
                                     dbus_interface)
842
1390
                self.calls.append(("Approve", (approve,
843
1391
                                               dbus_interface)))
844
1392
        self.client = MockClient(
884
1432
            ApprovedByDefault=dbus.Boolean(False),
885
1433
            LastApprovalRequest="2019-01-03T00:00:00",
886
1434
            ApprovalDelay=30000,
887
 
            ApprovalDuration=1000,
 
1435
            ApprovalDuration=93785000,
888
1436
            Checker=":",
889
1437
            ExtendedTimeout=900000,
890
1438
            Expires="2019-02-05T00:00:00",
891
1439
            LastCheckerStatus=-2)
892
1440
        self.clients =  collections.OrderedDict(
893
1441
            [
894
 
                (self.client, self.client.attributes),
895
 
                (self.other_client, self.other_client.attributes),
 
1442
                (self.client.__dbus_object_path__,
 
1443
                 self.client.attributes),
 
1444
                (self.other_client.__dbus_object_path__,
 
1445
                 self.other_client.attributes),
896
1446
            ])
897
 
        self.one_client = {self.client: self.client.attributes}
898
 
 
899
 
class TestPrintTableCmd(TestCmd):
900
 
    def test_normal(self):
901
 
        output = PrintTableCmd().output(self.clients)
902
 
        expected_output = """
903
 
Name   Enabled Timeout  Last Successful Check
904
 
foo    Yes     00:05:00 2019-02-03T00:00:00  
905
 
barbar Yes     00:05:00 2019-02-04T00:00:00  
906
 
"""[1:-1]
907
 
        self.assertEqual(output, expected_output)
908
 
    def test_verbose(self):
909
 
        output = PrintTableCmd(verbose=True).output(self.clients)
910
 
        expected_output = """
911
 
Name   Enabled Timeout  Last Successful Check Created             Interval Host            Key ID                                                           Fingerprint                              Check Is Running Last Enabled        Approval Is Pending Approved By Default Last Approval Request Approval Delay Approval Duration Checker              Extended Timeout Expires             Last Checker Status
912
 
foo    Yes     00:05:00 2019-02-03T00:00:00   2019-01-02T00:00:00 00:02:00 foo.example.org 92ed150794387c03ce684574b1139a6594a34f895daaaf09fd8ea90a27cddb12 778827225BA7DE539C5A7CFA59CFF7CDBD9A5920 No               2019-01-03T00:00:00 No                  Yes                                       00:00:00       00:00:01          fping -q -- %(host)s 00:15:00         2019-02-04T00:00:00 0                  
913
 
barbar Yes     00:05:00 2019-02-04T00:00:00   2019-01-03T00:00:00 00:02:00 192.0.2.3       0558568eedd67d622f5c83b35a115f796ab612cff5ad227247e46c2b020f441c 3E393AEAEFB84C7E89E2F547B3A107558FCA3A27 Yes              2019-01-04T00:00:00 No                  No                  2019-01-03T00:00:00   00:00:30       00:00:01          :                    00:15:00         2019-02-05T00:00:00 -2                 
914
 
"""[1:-1]
915
 
        self.assertEqual(output, expected_output)
916
 
    def test_one_client(self):
917
 
        output = PrintTableCmd().output(self.one_client)
918
 
        expected_output = """
919
 
Name Enabled Timeout  Last Successful Check
920
 
foo  Yes     00:05:00 2019-02-03T00:00:00  
921
 
"""[1:-1]
922
 
        self.assertEqual(output, expected_output)
923
 
 
924
 
class TestDumpJSONCmd(TestCmd):
925
 
    def setUp(self):
926
 
        self.expected_json = {
927
 
            "foo": {
928
 
                "Name": "foo",
929
 
                "KeyID": ("92ed150794387c03ce684574b1139a65"
930
 
                          "94a34f895daaaf09fd8ea90a27cddb12"),
931
 
                "Host": "foo.example.org",
932
 
                "Enabled": True,
933
 
                "Timeout": 300000,
934
 
                "LastCheckedOK": "2019-02-03T00:00:00",
935
 
                "Created": "2019-01-02T00:00:00",
936
 
                "Interval": 120000,
937
 
                "Fingerprint": ("778827225BA7DE539C5A"
938
 
                                "7CFA59CFF7CDBD9A5920"),
939
 
                "CheckerRunning": False,
940
 
                "LastEnabled": "2019-01-03T00:00:00",
941
 
                "ApprovalPending": False,
942
 
                "ApprovedByDefault": True,
943
 
                "LastApprovalRequest": "",
944
 
                "ApprovalDelay": 0,
945
 
                "ApprovalDuration": 1000,
946
 
                "Checker": "fping -q -- %(host)s",
947
 
                "ExtendedTimeout": 900000,
948
 
                "Expires": "2019-02-04T00:00:00",
949
 
                "LastCheckerStatus": 0,
950
 
            },
951
 
            "barbar": {
952
 
                "Name": "barbar",
953
 
                "KeyID": ("0558568eedd67d622f5c83b35a115f79"
954
 
                          "6ab612cff5ad227247e46c2b020f441c"),
955
 
                "Host": "192.0.2.3",
956
 
                "Enabled": True,
957
 
                "Timeout": 300000,
958
 
                "LastCheckedOK": "2019-02-04T00:00:00",
959
 
                "Created": "2019-01-03T00:00:00",
960
 
                "Interval": 120000,
961
 
                "Fingerprint": ("3E393AEAEFB84C7E89E2"
962
 
                                "F547B3A107558FCA3A27"),
963
 
                "CheckerRunning": True,
964
 
                "LastEnabled": "2019-01-04T00:00:00",
965
 
                "ApprovalPending": False,
966
 
                "ApprovedByDefault": False,
967
 
                "LastApprovalRequest": "2019-01-03T00:00:00",
968
 
                "ApprovalDelay": 30000,
969
 
                "ApprovalDuration": 1000,
970
 
                "Checker": ":",
971
 
                "ExtendedTimeout": 900000,
972
 
                "Expires": "2019-02-05T00:00:00",
973
 
                "LastCheckerStatus": -2,
974
 
            },
975
 
        }
976
 
        return super(TestDumpJSONCmd, self).setUp()
977
 
    def test_normal(self):
978
 
        json_data = json.loads(DumpJSONCmd().output(self.clients))
979
 
        self.assertDictEqual(json_data, self.expected_json)
980
 
    def test_one_client(self):
981
 
        clients = self.one_client
982
 
        json_data = json.loads(DumpJSONCmd().output(clients))
983
 
        expected_json = {"foo": self.expected_json["foo"]}
984
 
        self.assertDictEqual(json_data, expected_json)
985
 
 
986
 
class TestIsEnabledCmd(TestCmd):
987
 
    def test_is_enabled(self):
988
 
        self.assertTrue(all(IsEnabledCmd().is_enabled(client, properties)
989
 
                            for client, properties in self.clients.items()))
990
 
    def test_is_enabled_run_exits_successfully(self):
 
1447
        self.one_client = {self.client.__dbus_object_path__:
 
1448
                           self.client.attributes}
 
1449
 
 
1450
    @property
 
1451
    def bus(self):
 
1452
        class MockBus(object):
 
1453
            @staticmethod
 
1454
            def get_object(client_bus_name, path):
 
1455
                self.assertEqual(dbus_busname, client_bus_name)
 
1456
                # Note: "self" here is the TestCmd instance, not the
 
1457
                # MockBus instance, since this is a static method!
 
1458
                if path == self.client.__dbus_object_path__:
 
1459
                    return self.client
 
1460
                elif path == self.other_client.__dbus_object_path__:
 
1461
                    return self.other_client
 
1462
        return MockBus()
 
1463
 
 
1464
 
 
1465
class TestBaseCommands(TestCommand):
 
1466
 
 
1467
    def test_IsEnabled_exits_successfully(self):
991
1468
        with self.assertRaises(SystemExit) as e:
992
 
            IsEnabledCmd().run(None, self.one_client)
 
1469
            command.IsEnabled().run(self.one_client)
993
1470
        if e.exception.code is not None:
994
 
            self.assertEqual(e.exception.code, 0)
 
1471
            self.assertEqual(0, e.exception.code)
995
1472
        else:
996
1473
            self.assertIsNone(e.exception.code)
997
 
    def test_is_enabled_run_exits_with_failure(self):
 
1474
 
 
1475
    def test_IsEnabled_exits_with_failure(self):
998
1476
        self.client.attributes["Enabled"] = dbus.Boolean(False)
999
1477
        with self.assertRaises(SystemExit) as e:
1000
 
            IsEnabledCmd().run(None, self.one_client)
 
1478
            command.IsEnabled().run(self.one_client)
1001
1479
        if isinstance(e.exception.code, int):
1002
 
            self.assertNotEqual(e.exception.code, 0)
 
1480
            self.assertNotEqual(0, e.exception.code)
1003
1481
        else:
1004
1482
            self.assertIsNotNone(e.exception.code)
1005
1483
 
1006
 
class TestRemoveCmd(TestCmd):
1007
 
    def test_remove(self):
1008
 
        class MockMandos(object):
 
1484
    def test_Approve(self):
 
1485
        command.Approve().run(self.clients, self.bus)
 
1486
        for clientpath in self.clients:
 
1487
            client = self.bus.get_object(dbus_busname, clientpath)
 
1488
            self.assertIn(("Approve", (True, client_dbus_interface)),
 
1489
                          client.calls)
 
1490
 
 
1491
    def test_Deny(self):
 
1492
        command.Deny().run(self.clients, self.bus)
 
1493
        for clientpath in self.clients:
 
1494
            client = self.bus.get_object(dbus_busname, clientpath)
 
1495
            self.assertIn(("Approve", (False, client_dbus_interface)),
 
1496
                          client.calls)
 
1497
 
 
1498
    def test_Remove(self):
 
1499
        class MandosSpy(object):
1009
1500
            def __init__(self):
1010
1501
                self.calls = []
1011
1502
            def RemoveClient(self, dbus_path):
1012
1503
                self.calls.append(("RemoveClient", (dbus_path,)))
1013
 
        mandos = MockMandos()
1014
 
        super(TestRemoveCmd, self).setUp()
1015
 
        RemoveCmd().run(mandos, self.clients)
1016
 
        self.assertEqual(len(mandos.calls), 2)
1017
 
        for client in self.clients:
1018
 
            self.assertIn(("RemoveClient",
1019
 
                           (client.__dbus_object_path__,)),
 
1504
        mandos = MandosSpy()
 
1505
        command.Remove().run(self.clients, self.bus, mandos)
 
1506
        for clientpath in self.clients:
 
1507
            self.assertIn(("RemoveClient", (clientpath,)),
1020
1508
                          mandos.calls)
1021
1509
 
1022
 
class TestApproveCmd(TestCmd):
1023
 
    def test_approve(self):
1024
 
        ApproveCmd().run(None, self.clients)
1025
 
        for client in self.clients:
1026
 
            self.assertIn(("Approve", (True, client_interface)),
1027
 
                          client.calls)
1028
 
 
1029
 
class TestDenyCmd(TestCmd):
1030
 
    def test_deny(self):
1031
 
        DenyCmd().run(None, self.clients)
1032
 
        for client in self.clients:
1033
 
            self.assertIn(("Approve", (False, client_interface)),
1034
 
                          client.calls)
1035
 
 
1036
 
class TestEnableCmd(TestCmd):
1037
 
    def test_enable(self):
1038
 
        for client in self.clients:
1039
 
            client.attributes["Enabled"] = False
1040
 
 
1041
 
        EnableCmd().run(None, self.clients)
1042
 
 
1043
 
        for client in self.clients:
1044
 
            self.assertTrue(client.attributes["Enabled"])
1045
 
 
1046
 
class TestDisableCmd(TestCmd):
1047
 
    def test_disable(self):
1048
 
        DisableCmd().run(None, self.clients)
1049
 
 
1050
 
        for client in self.clients:
1051
 
            self.assertFalse(client.attributes["Enabled"])
1052
 
 
1053
 
class Unique(object):
1054
 
    """Class for objects which exist only to be unique objects, since
1055
 
unittest.mock.sentinel only exists in Python 3.3"""
1056
 
 
1057
 
class TestPropertyCmd(TestCmd):
1058
 
    """Abstract class for tests of PropertyCmd classes"""
 
1510
    expected_json = {
 
1511
        "foo": {
 
1512
            "Name": "foo",
 
1513
            "KeyID": ("92ed150794387c03ce684574b1139a65"
 
1514
                      "94a34f895daaaf09fd8ea90a27cddb12"),
 
1515
            "Host": "foo.example.org",
 
1516
            "Enabled": True,
 
1517
            "Timeout": 300000,
 
1518
            "LastCheckedOK": "2019-02-03T00:00:00",
 
1519
            "Created": "2019-01-02T00:00:00",
 
1520
            "Interval": 120000,
 
1521
            "Fingerprint": ("778827225BA7DE539C5A"
 
1522
                            "7CFA59CFF7CDBD9A5920"),
 
1523
            "CheckerRunning": False,
 
1524
            "LastEnabled": "2019-01-03T00:00:00",
 
1525
            "ApprovalPending": False,
 
1526
            "ApprovedByDefault": True,
 
1527
            "LastApprovalRequest": "",
 
1528
            "ApprovalDelay": 0,
 
1529
            "ApprovalDuration": 1000,
 
1530
            "Checker": "fping -q -- %(host)s",
 
1531
            "ExtendedTimeout": 900000,
 
1532
            "Expires": "2019-02-04T00:00:00",
 
1533
            "LastCheckerStatus": 0,
 
1534
        },
 
1535
        "barbar": {
 
1536
            "Name": "barbar",
 
1537
            "KeyID": ("0558568eedd67d622f5c83b35a115f79"
 
1538
                      "6ab612cff5ad227247e46c2b020f441c"),
 
1539
            "Host": "192.0.2.3",
 
1540
            "Enabled": True,
 
1541
            "Timeout": 300000,
 
1542
            "LastCheckedOK": "2019-02-04T00:00:00",
 
1543
            "Created": "2019-01-03T00:00:00",
 
1544
            "Interval": 120000,
 
1545
            "Fingerprint": ("3E393AEAEFB84C7E89E2"
 
1546
                            "F547B3A107558FCA3A27"),
 
1547
            "CheckerRunning": True,
 
1548
            "LastEnabled": "2019-01-04T00:00:00",
 
1549
            "ApprovalPending": False,
 
1550
            "ApprovedByDefault": False,
 
1551
            "LastApprovalRequest": "2019-01-03T00:00:00",
 
1552
            "ApprovalDelay": 30000,
 
1553
            "ApprovalDuration": 93785000,
 
1554
            "Checker": ":",
 
1555
            "ExtendedTimeout": 900000,
 
1556
            "Expires": "2019-02-05T00:00:00",
 
1557
            "LastCheckerStatus": -2,
 
1558
        },
 
1559
    }
 
1560
 
 
1561
    def test_DumpJSON_normal(self):
 
1562
        with self.capture_stdout_to_buffer() as buffer:
 
1563
            command.DumpJSON().run(self.clients)
 
1564
        json_data = json.loads(buffer.getvalue())
 
1565
        self.assertDictEqual(self.expected_json, json_data)
 
1566
 
 
1567
    @staticmethod
 
1568
    @contextlib.contextmanager
 
1569
    def capture_stdout_to_buffer():
 
1570
        capture_buffer = io.StringIO()
 
1571
        old_stdout = sys.stdout
 
1572
        sys.stdout = capture_buffer
 
1573
        try:
 
1574
            yield capture_buffer
 
1575
        finally:
 
1576
            sys.stdout = old_stdout
 
1577
 
 
1578
    def test_DumpJSON_one_client(self):
 
1579
        with self.capture_stdout_to_buffer() as buffer:
 
1580
            command.DumpJSON().run(self.one_client)
 
1581
        json_data = json.loads(buffer.getvalue())
 
1582
        expected_json = {"foo": self.expected_json["foo"]}
 
1583
        self.assertDictEqual(expected_json, json_data)
 
1584
 
 
1585
    def test_PrintTable_normal(self):
 
1586
        with self.capture_stdout_to_buffer() as buffer:
 
1587
            command.PrintTable().run(self.clients)
 
1588
        expected_output = "\n".join((
 
1589
            "Name   Enabled Timeout  Last Successful Check",
 
1590
            "foo    Yes     00:05:00 2019-02-03T00:00:00  ",
 
1591
            "barbar Yes     00:05:00 2019-02-04T00:00:00  ",
 
1592
        )) + "\n"
 
1593
        self.assertEqual(expected_output, buffer.getvalue())
 
1594
 
 
1595
    def test_PrintTable_verbose(self):
 
1596
        with self.capture_stdout_to_buffer() as buffer:
 
1597
            command.PrintTable(verbose=True).run(self.clients)
 
1598
        columns = (
 
1599
            (
 
1600
                "Name   ",
 
1601
                "foo    ",
 
1602
                "barbar ",
 
1603
            ),(
 
1604
                "Enabled ",
 
1605
                "Yes     ",
 
1606
                "Yes     ",
 
1607
            ),(
 
1608
                "Timeout  ",
 
1609
                "00:05:00 ",
 
1610
                "00:05:00 ",
 
1611
            ),(
 
1612
                "Last Successful Check ",
 
1613
                "2019-02-03T00:00:00   ",
 
1614
                "2019-02-04T00:00:00   ",
 
1615
            ),(
 
1616
                "Created             ",
 
1617
                "2019-01-02T00:00:00 ",
 
1618
                "2019-01-03T00:00:00 ",
 
1619
            ),(
 
1620
                "Interval ",
 
1621
                "00:02:00 ",
 
1622
                "00:02:00 ",
 
1623
            ),(
 
1624
                "Host            ",
 
1625
                "foo.example.org ",
 
1626
                "192.0.2.3       ",
 
1627
            ),(
 
1628
                ("Key ID                                             "
 
1629
                 "              "),
 
1630
                ("92ed150794387c03ce684574b1139a6594a34f895daaaf09fd8"
 
1631
                 "ea90a27cddb12 "),
 
1632
                ("0558568eedd67d622f5c83b35a115f796ab612cff5ad227247e"
 
1633
                 "46c2b020f441c "),
 
1634
            ),(
 
1635
                "Fingerprint                              ",
 
1636
                "778827225BA7DE539C5A7CFA59CFF7CDBD9A5920 ",
 
1637
                "3E393AEAEFB84C7E89E2F547B3A107558FCA3A27 ",
 
1638
            ),(
 
1639
                "Check Is Running ",
 
1640
                "No               ",
 
1641
                "Yes              ",
 
1642
            ),(
 
1643
                "Last Enabled        ",
 
1644
                "2019-01-03T00:00:00 ",
 
1645
                "2019-01-04T00:00:00 ",
 
1646
            ),(
 
1647
                "Approval Is Pending ",
 
1648
                "No                  ",
 
1649
                "No                  ",
 
1650
            ),(
 
1651
                "Approved By Default ",
 
1652
                "Yes                 ",
 
1653
                "No                  ",
 
1654
            ),(
 
1655
                "Last Approval Request ",
 
1656
                "                      ",
 
1657
                "2019-01-03T00:00:00   ",
 
1658
            ),(
 
1659
                "Approval Delay ",
 
1660
                "00:00:00       ",
 
1661
                "00:00:30       ",
 
1662
            ),(
 
1663
                "Approval Duration ",
 
1664
                "00:00:01          ",
 
1665
                "1T02:03:05        ",
 
1666
            ),(
 
1667
                "Checker              ",
 
1668
                "fping -q -- %(host)s ",
 
1669
                ":                    ",
 
1670
            ),(
 
1671
                "Extended Timeout ",
 
1672
                "00:15:00         ",
 
1673
                "00:15:00         ",
 
1674
            ),(
 
1675
                "Expires             ",
 
1676
                "2019-02-04T00:00:00 ",
 
1677
                "2019-02-05T00:00:00 ",
 
1678
            ),(
 
1679
                "Last Checker Status",
 
1680
                "0                  ",
 
1681
                "-2                 ",
 
1682
            )
 
1683
        )
 
1684
        num_lines = max(len(rows) for rows in columns)
 
1685
        expected_output = ("\n".join("".join(rows[line]
 
1686
                                             for rows in columns)
 
1687
                                     for line in range(num_lines))
 
1688
                           + "\n")
 
1689
        self.assertEqual(expected_output, buffer.getvalue())
 
1690
 
 
1691
    def test_PrintTable_one_client(self):
 
1692
        with self.capture_stdout_to_buffer() as buffer:
 
1693
            command.PrintTable().run(self.one_client)
 
1694
        expected_output = "\n".join((
 
1695
            "Name Enabled Timeout  Last Successful Check",
 
1696
            "foo  Yes     00:05:00 2019-02-03T00:00:00  ",
 
1697
        )) + "\n"
 
1698
        self.assertEqual(expected_output, buffer.getvalue())
 
1699
 
 
1700
 
 
1701
class TestPropertySetterCmd(TestCommand):
 
1702
    """Abstract class for tests of command.PropertySetter classes"""
1059
1703
    def runTest(self):
1060
1704
        if not hasattr(self, "command"):
1061
1705
            return
1063
1707
                                self.values_to_set)
1064
1708
        for value_to_set, value_to_get in zip(self.values_to_set,
1065
1709
                                              values_to_get):
1066
 
            for client in self.clients:
1067
 
                old_value = client.attributes[self.property]
1068
 
                self.assertNotIsInstance(old_value, Unique)
1069
 
                client.attributes[self.property] = Unique()
 
1710
            for clientpath in self.clients:
 
1711
                client = self.bus.get_object(dbus_busname, clientpath)
 
1712
                old_value = client.attributes[self.propname]
 
1713
                client.attributes[self.propname] = self.Unique()
1070
1714
            self.run_command(value_to_set, self.clients)
1071
 
            for client in self.clients:
1072
 
                value = client.attributes[self.property]
1073
 
                self.assertNotIsInstance(value, Unique)
1074
 
                self.assertEqual(value, value_to_get)
 
1715
            for clientpath in self.clients:
 
1716
                client = self.bus.get_object(dbus_busname, clientpath)
 
1717
                value = client.attributes[self.propname]
 
1718
                self.assertNotIsInstance(value, self.Unique)
 
1719
                self.assertEqual(value_to_get, value)
 
1720
 
 
1721
    class Unique(object):
 
1722
        """Class for objects which exist only to be unique objects,
 
1723
since unittest.mock.sentinel only exists in Python 3.3"""
 
1724
 
1075
1725
    def run_command(self, value, clients):
1076
 
        self.command().run(None, clients)
1077
 
 
1078
 
class TestBumpTimeoutCmd(TestPropertyCmd):
1079
 
    command = BumpTimeoutCmd
1080
 
    property = "LastCheckedOK"
 
1726
        self.command().run(clients, self.bus)
 
1727
 
 
1728
 
 
1729
class TestEnableCmd(TestPropertySetterCmd):
 
1730
    command = command.Enable
 
1731
    propname = "Enabled"
 
1732
    values_to_set = [dbus.Boolean(True)]
 
1733
 
 
1734
 
 
1735
class TestDisableCmd(TestPropertySetterCmd):
 
1736
    command = command.Disable
 
1737
    propname = "Enabled"
 
1738
    values_to_set = [dbus.Boolean(False)]
 
1739
 
 
1740
 
 
1741
class TestBumpTimeoutCmd(TestPropertySetterCmd):
 
1742
    command = command.BumpTimeout
 
1743
    propname = "LastCheckedOK"
1081
1744
    values_to_set = [""]
1082
1745
 
1083
 
class TestStartCheckerCmd(TestPropertyCmd):
1084
 
    command = StartCheckerCmd
1085
 
    property = "CheckerRunning"
1086
 
    values_to_set = [dbus.Boolean(True)]
1087
 
 
1088
 
class TestStopCheckerCmd(TestPropertyCmd):
1089
 
    command = StopCheckerCmd
1090
 
    property = "CheckerRunning"
1091
 
    values_to_set = [dbus.Boolean(False)]
1092
 
 
1093
 
class TestApproveByDefaultCmd(TestPropertyCmd):
1094
 
    command = ApproveByDefaultCmd
1095
 
    property = "ApprovedByDefault"
1096
 
    values_to_set = [dbus.Boolean(True)]
1097
 
 
1098
 
class TestDenyByDefaultCmd(TestPropertyCmd):
1099
 
    command = DenyByDefaultCmd
1100
 
    property = "ApprovedByDefault"
1101
 
    values_to_set = [dbus.Boolean(False)]
1102
 
 
1103
 
class TestValueArgumentPropertyCmd(TestPropertyCmd):
1104
 
    """Abstract class for tests of PropertyCmd classes using the
1105
 
ValueArgumentMixIn"""
 
1746
 
 
1747
class TestStartCheckerCmd(TestPropertySetterCmd):
 
1748
    command = command.StartChecker
 
1749
    propname = "CheckerRunning"
 
1750
    values_to_set = [dbus.Boolean(True)]
 
1751
 
 
1752
 
 
1753
class TestStopCheckerCmd(TestPropertySetterCmd):
 
1754
    command = command.StopChecker
 
1755
    propname = "CheckerRunning"
 
1756
    values_to_set = [dbus.Boolean(False)]
 
1757
 
 
1758
 
 
1759
class TestApproveByDefaultCmd(TestPropertySetterCmd):
 
1760
    command = command.ApproveByDefault
 
1761
    propname = "ApprovedByDefault"
 
1762
    values_to_set = [dbus.Boolean(True)]
 
1763
 
 
1764
 
 
1765
class TestDenyByDefaultCmd(TestPropertySetterCmd):
 
1766
    command = command.DenyByDefault
 
1767
    propname = "ApprovedByDefault"
 
1768
    values_to_set = [dbus.Boolean(False)]
 
1769
 
 
1770
 
 
1771
class TestPropertySetterValueCmd(TestPropertySetterCmd):
 
1772
    """Abstract class for tests of PropertySetterValueCmd classes"""
 
1773
 
1106
1774
    def runTest(self):
1107
 
        if type(self) is TestValueArgumentPropertyCmd:
 
1775
        if type(self) is TestPropertySetterValueCmd:
1108
1776
            return
1109
 
        return super(TestValueArgumentPropertyCmd, self).runTest()
 
1777
        return super(TestPropertySetterValueCmd, self).runTest()
 
1778
 
1110
1779
    def run_command(self, value, clients):
1111
 
        self.command(value).run(None, clients)
1112
 
 
1113
 
class TestSetCheckerCmd(TestValueArgumentPropertyCmd):
1114
 
    command = SetCheckerCmd
1115
 
    property = "Checker"
 
1780
        self.command(value).run(clients, self.bus)
 
1781
 
 
1782
 
 
1783
class TestSetCheckerCmd(TestPropertySetterValueCmd):
 
1784
    command = command.SetChecker
 
1785
    propname = "Checker"
1116
1786
    values_to_set = ["", ":", "fping -q -- %s"]
1117
1787
 
1118
 
class TestSetHostCmd(TestValueArgumentPropertyCmd):
1119
 
    command = SetHostCmd
1120
 
    property = "Host"
1121
 
    values_to_set = ["192.0.2.3", "foo.example.org"]
1122
 
 
1123
 
class TestSetSecretCmd(TestValueArgumentPropertyCmd):
1124
 
    command = SetSecretCmd
1125
 
    property = "Secret"
 
1788
 
 
1789
class TestSetHostCmd(TestPropertySetterValueCmd):
 
1790
    command = command.SetHost
 
1791
    propname = "Host"
 
1792
    values_to_set = ["192.0.2.3", "client.example.org"]
 
1793
 
 
1794
 
 
1795
class TestSetSecretCmd(TestPropertySetterValueCmd):
 
1796
    command = command.SetSecret
 
1797
    propname = "Secret"
1126
1798
    values_to_set = [io.BytesIO(b""),
1127
1799
                     io.BytesIO(b"secret\0xyzzy\nbar")]
1128
 
    values_to_get = [b"", b"secret\0xyzzy\nbar"]
1129
 
 
1130
 
class TestSetTimeoutCmd(TestValueArgumentPropertyCmd):
1131
 
    command = SetTimeoutCmd
1132
 
    property = "Timeout"
1133
 
    values_to_set = [datetime.timedelta(),
1134
 
                     datetime.timedelta(minutes=5),
1135
 
                     datetime.timedelta(seconds=1),
1136
 
                     datetime.timedelta(weeks=1),
1137
 
                     datetime.timedelta(weeks=52)]
1138
 
    values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1139
 
 
1140
 
class TestSetExtendedTimeoutCmd(TestValueArgumentPropertyCmd):
1141
 
    command = SetExtendedTimeoutCmd
1142
 
    property = "ExtendedTimeout"
1143
 
    values_to_set = [datetime.timedelta(),
1144
 
                     datetime.timedelta(minutes=5),
1145
 
                     datetime.timedelta(seconds=1),
1146
 
                     datetime.timedelta(weeks=1),
1147
 
                     datetime.timedelta(weeks=52)]
1148
 
    values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1149
 
 
1150
 
class TestSetIntervalCmd(TestValueArgumentPropertyCmd):
1151
 
    command = SetIntervalCmd
1152
 
    property = "Interval"
1153
 
    values_to_set = [datetime.timedelta(),
1154
 
                     datetime.timedelta(minutes=5),
1155
 
                     datetime.timedelta(seconds=1),
1156
 
                     datetime.timedelta(weeks=1),
1157
 
                     datetime.timedelta(weeks=52)]
1158
 
    values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1159
 
 
1160
 
class TestSetApprovalDelayCmd(TestValueArgumentPropertyCmd):
1161
 
    command = SetApprovalDelayCmd
1162
 
    property = "ApprovalDelay"
1163
 
    values_to_set = [datetime.timedelta(),
1164
 
                     datetime.timedelta(minutes=5),
1165
 
                     datetime.timedelta(seconds=1),
1166
 
                     datetime.timedelta(weeks=1),
1167
 
                     datetime.timedelta(weeks=52)]
1168
 
    values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1169
 
 
1170
 
class TestSetApprovalDurationCmd(TestValueArgumentPropertyCmd):
1171
 
    command = SetApprovalDurationCmd
1172
 
    property = "ApprovalDuration"
1173
 
    values_to_set = [datetime.timedelta(),
1174
 
                     datetime.timedelta(minutes=5),
1175
 
                     datetime.timedelta(seconds=1),
1176
 
                     datetime.timedelta(weeks=1),
1177
 
                     datetime.timedelta(weeks=52)]
1178
 
    values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1179
 
 
1180
 
class Test_command_from_options(unittest.TestCase):
1181
 
    def setUp(self):
1182
 
        self.parser = argparse.ArgumentParser()
1183
 
        add_command_line_options(self.parser)
1184
 
    def assert_command_from_args(self, args, command_cls, **cmd_attrs):
1185
 
        """Assert that parsing ARGS should result in an instance of
1186
 
COMMAND_CLS with (optionally) all supplied attributes (CMD_ATTRS)."""
1187
 
        options = self.parser.parse_args(args)
1188
 
        check_option_syntax(self.parser, options)
1189
 
        commands = commands_from_options(options)
1190
 
        self.assertEqual(len(commands), 1)
1191
 
        command = commands[0]
1192
 
        self.assertIsInstance(command, command_cls)
1193
 
        for key, value in cmd_attrs.items():
1194
 
            self.assertEqual(getattr(command, key), value)
1195
 
    def test_print_table(self):
1196
 
        self.assert_command_from_args([], PrintTableCmd,
1197
 
                                      verbose=False)
1198
 
 
1199
 
    def test_print_table_verbose(self):
1200
 
        self.assert_command_from_args(["--verbose"], PrintTableCmd,
1201
 
                                      verbose=True)
1202
 
 
1203
 
    def test_print_table_verbose_short(self):
1204
 
        self.assert_command_from_args(["-v"], PrintTableCmd,
1205
 
                                      verbose=True)
1206
 
 
1207
 
    def test_enable(self):
1208
 
        self.assert_command_from_args(["--enable", "foo"], EnableCmd)
1209
 
 
1210
 
    def test_enable_short(self):
1211
 
        self.assert_command_from_args(["-e", "foo"], EnableCmd)
1212
 
 
1213
 
    def test_disable(self):
1214
 
        self.assert_command_from_args(["--disable", "foo"],
1215
 
                                      DisableCmd)
1216
 
 
1217
 
    def test_disable_short(self):
1218
 
        self.assert_command_from_args(["-d", "foo"], DisableCmd)
1219
 
 
1220
 
    def test_bump_timeout(self):
1221
 
        self.assert_command_from_args(["--bump-timeout", "foo"],
1222
 
                                      BumpTimeoutCmd)
1223
 
 
1224
 
    def test_bump_timeout_short(self):
1225
 
        self.assert_command_from_args(["-b", "foo"], BumpTimeoutCmd)
1226
 
 
1227
 
    def test_start_checker(self):
1228
 
        self.assert_command_from_args(["--start-checker", "foo"],
1229
 
                                      StartCheckerCmd)
1230
 
 
1231
 
    def test_stop_checker(self):
1232
 
        self.assert_command_from_args(["--stop-checker", "foo"],
1233
 
                                      StopCheckerCmd)
1234
 
 
1235
 
    def test_remove(self):
1236
 
        self.assert_command_from_args(["--remove", "foo"],
1237
 
                                      RemoveCmd)
1238
 
 
1239
 
    def test_remove_short(self):
1240
 
        self.assert_command_from_args(["-r", "foo"], RemoveCmd)
1241
 
 
1242
 
    def test_checker(self):
1243
 
        self.assert_command_from_args(["--checker", ":", "foo"],
1244
 
                                      SetCheckerCmd, value_to_set=":")
1245
 
 
1246
 
    def test_checker_empty(self):
1247
 
        self.assert_command_from_args(["--checker", "", "foo"],
1248
 
                                      SetCheckerCmd, value_to_set="")
1249
 
 
1250
 
    def test_checker_short(self):
1251
 
        self.assert_command_from_args(["-c", ":", "foo"],
1252
 
                                      SetCheckerCmd, value_to_set=":")
1253
 
 
1254
 
    def test_timeout(self):
1255
 
        self.assert_command_from_args(["--timeout", "PT5M", "foo"],
1256
 
                                      SetTimeoutCmd,
1257
 
                                      value_to_set=300000)
1258
 
 
1259
 
    def test_timeout_short(self):
1260
 
        self.assert_command_from_args(["-t", "PT5M", "foo"],
1261
 
                                      SetTimeoutCmd,
1262
 
                                      value_to_set=300000)
1263
 
 
1264
 
    def test_extended_timeout(self):
1265
 
        self.assert_command_from_args(["--extended-timeout", "PT15M",
1266
 
                                       "foo"],
1267
 
                                      SetExtendedTimeoutCmd,
1268
 
                                      value_to_set=900000)
1269
 
 
1270
 
    def test_interval(self):
1271
 
        self.assert_command_from_args(["--interval", "PT2M", "foo"],
1272
 
                                      SetIntervalCmd,
1273
 
                                      value_to_set=120000)
1274
 
 
1275
 
    def test_interval_short(self):
1276
 
        self.assert_command_from_args(["-i", "PT2M", "foo"],
1277
 
                                      SetIntervalCmd,
1278
 
                                      value_to_set=120000)
1279
 
 
1280
 
    def test_approve_by_default(self):
1281
 
        self.assert_command_from_args(["--approve-by-default", "foo"],
1282
 
                                      ApproveByDefaultCmd)
1283
 
 
1284
 
    def test_deny_by_default(self):
1285
 
        self.assert_command_from_args(["--deny-by-default", "foo"],
1286
 
                                      DenyByDefaultCmd)
1287
 
 
1288
 
    def test_approval_delay(self):
1289
 
        self.assert_command_from_args(["--approval-delay", "PT30S",
1290
 
                                       "foo"], SetApprovalDelayCmd,
1291
 
                                      value_to_set=30000)
1292
 
 
1293
 
    def test_approval_duration(self):
1294
 
        self.assert_command_from_args(["--approval-duration", "PT1S",
1295
 
                                       "foo"], SetApprovalDurationCmd,
1296
 
                                      value_to_set=1000)
1297
 
 
1298
 
    def test_host(self):
1299
 
        self.assert_command_from_args(["--host", "foo.example.org",
1300
 
                                       "foo"], SetHostCmd,
1301
 
                                      value_to_set="foo.example.org")
1302
 
 
1303
 
    def test_host_short(self):
1304
 
        self.assert_command_from_args(["-H", "foo.example.org",
1305
 
                                       "foo"], SetHostCmd,
1306
 
                                      value_to_set="foo.example.org")
1307
 
 
1308
 
    def test_secret_devnull(self):
1309
 
        self.assert_command_from_args(["--secret", os.path.devnull,
1310
 
                                       "foo"], SetSecretCmd,
1311
 
                                      value_to_set=b"")
1312
 
 
1313
 
    def test_secret_tempfile(self):
1314
 
        with tempfile.NamedTemporaryFile(mode="r+b") as f:
1315
 
            value = b"secret\0xyzzy\nbar"
1316
 
            f.write(value)
1317
 
            f.seek(0)
1318
 
            self.assert_command_from_args(["--secret", f.name,
1319
 
                                           "foo"], SetSecretCmd,
1320
 
                                          value_to_set=value)
1321
 
 
1322
 
    def test_secret_devnull_short(self):
1323
 
        self.assert_command_from_args(["-s", os.path.devnull, "foo"],
1324
 
                                      SetSecretCmd, value_to_set=b"")
1325
 
 
1326
 
    def test_secret_tempfile_short(self):
1327
 
        with tempfile.NamedTemporaryFile(mode="r+b") as f:
1328
 
            value = b"secret\0xyzzy\nbar"
1329
 
            f.write(value)
1330
 
            f.seek(0)
1331
 
            self.assert_command_from_args(["-s", f.name, "foo"],
1332
 
                                          SetSecretCmd,
1333
 
                                          value_to_set=value)
1334
 
 
1335
 
    def test_approve(self):
1336
 
        self.assert_command_from_args(["--approve", "foo"],
1337
 
                                      ApproveCmd)
1338
 
 
1339
 
    def test_approve_short(self):
1340
 
        self.assert_command_from_args(["-A", "foo"], ApproveCmd)
1341
 
 
1342
 
    def test_deny(self):
1343
 
        self.assert_command_from_args(["--deny", "foo"], DenyCmd)
1344
 
 
1345
 
    def test_deny_short(self):
1346
 
        self.assert_command_from_args(["-D", "foo"], DenyCmd)
1347
 
 
1348
 
    def test_dump_json(self):
1349
 
        self.assert_command_from_args(["--dump-json"], DumpJSONCmd)
1350
 
 
1351
 
    def test_is_enabled(self):
1352
 
        self.assert_command_from_args(["--is-enabled", "foo"],
1353
 
                                      IsEnabledCmd)
1354
 
 
1355
 
    def test_is_enabled_short(self):
1356
 
        self.assert_command_from_args(["-V", "foo"], IsEnabledCmd)
1357
 
 
1358
 
    def test_deny_before_remove(self):
1359
 
        options = self.parser.parse_args(["--deny", "--remove", "foo"])
1360
 
        check_option_syntax(self.parser, options)
1361
 
        commands = commands_from_options(options)
1362
 
        self.assertEqual(len(commands), 2)
1363
 
        self.assertIsInstance(commands[0], DenyCmd)
1364
 
        self.assertIsInstance(commands[1], RemoveCmd)
1365
 
 
1366
 
    def test_deny_before_remove_reversed(self):
1367
 
        options = self.parser.parse_args(["--remove", "--deny", "--all"])
1368
 
        check_option_syntax(self.parser, options)
1369
 
        commands = commands_from_options(options)
1370
 
        self.assertEqual(len(commands), 2)
1371
 
        self.assertIsInstance(commands[0], DenyCmd)
1372
 
        self.assertIsInstance(commands[1], RemoveCmd)
1373
 
 
1374
 
 
1375
 
class Test_check_option_syntax(unittest.TestCase):
1376
 
    # This mostly corresponds to the definition from has_actions() in
1377
 
    # check_option_syntax()
1378
 
    actions = {
1379
 
        # The actual values set here are not that important, but we do
1380
 
        # at least stick to the correct types, even though they are
1381
 
        # never used
1382
 
        "enable": True,
1383
 
        "disable": True,
1384
 
        "bump_timeout": True,
1385
 
        "start_checker": True,
1386
 
        "stop_checker": True,
1387
 
        "is_enabled": True,
1388
 
        "remove": True,
1389
 
        "checker": "x",
1390
 
        "timeout": datetime.timedelta(),
1391
 
        "extended_timeout": datetime.timedelta(),
1392
 
        "interval": datetime.timedelta(),
1393
 
        "approved_by_default": True,
1394
 
        "approval_delay": datetime.timedelta(),
1395
 
        "approval_duration": datetime.timedelta(),
1396
 
        "host": "x",
1397
 
        "secret": io.BytesIO(b"x"),
1398
 
        "approve": True,
1399
 
        "deny": True,
1400
 
    }
1401
 
 
1402
 
    def setUp(self):
1403
 
        self.parser = argparse.ArgumentParser()
1404
 
        add_command_line_options(self.parser)
1405
 
 
1406
 
    @contextlib.contextmanager
1407
 
    def assertParseError(self):
1408
 
        with self.assertRaises(SystemExit) as e:
1409
 
            with self.temporarily_suppress_stderr():
1410
 
                yield
1411
 
        # Exit code from argparse is guaranteed to be "2".  Reference:
1412
 
        # https://docs.python.org/3/library/argparse.html#exiting-methods
1413
 
        self.assertEqual(e.exception.code, 2)
1414
 
 
1415
 
    @staticmethod
1416
 
    @contextlib.contextmanager
1417
 
    def temporarily_suppress_stderr():
1418
 
        null = os.open(os.path.devnull, os.O_RDWR)
1419
 
        stderrcopy = os.dup(sys.stderr.fileno())
1420
 
        os.dup2(null, sys.stderr.fileno())
1421
 
        os.close(null)
1422
 
        try:
1423
 
            yield
1424
 
        finally:
1425
 
            # restore stderr
1426
 
            os.dup2(stderrcopy, sys.stderr.fileno())
1427
 
            os.close(stderrcopy)
1428
 
 
1429
 
    def check_option_syntax(self, options):
1430
 
        check_option_syntax(self.parser, options)
1431
 
 
1432
 
    def test_actions_requires_client_or_all(self):
1433
 
        for action, value in self.actions.items():
1434
 
            options = self.parser.parse_args()
1435
 
            setattr(options, action, value)
1436
 
            with self.assertParseError():
1437
 
                self.check_option_syntax(options)
1438
 
 
1439
 
    def test_actions_conflicts_with_verbose(self):
1440
 
        for action, value in self.actions.items():
1441
 
            options = self.parser.parse_args()
1442
 
            setattr(options, action, value)
1443
 
            options.verbose = True
1444
 
            with self.assertParseError():
1445
 
                self.check_option_syntax(options)
1446
 
 
1447
 
    def test_dump_json_conflicts_with_verbose(self):
1448
 
        options = self.parser.parse_args()
1449
 
        options.dump_json = True
1450
 
        options.verbose = True
1451
 
        with self.assertParseError():
1452
 
            self.check_option_syntax(options)
1453
 
 
1454
 
    def test_dump_json_conflicts_with_action(self):
1455
 
        for action, value in self.actions.items():
1456
 
            options = self.parser.parse_args()
1457
 
            setattr(options, action, value)
1458
 
            options.dump_json = True
1459
 
            with self.assertParseError():
1460
 
                self.check_option_syntax(options)
1461
 
 
1462
 
    def test_all_can_not_be_alone(self):
1463
 
        options = self.parser.parse_args()
1464
 
        options.all = True
1465
 
        with self.assertParseError():
1466
 
            self.check_option_syntax(options)
1467
 
 
1468
 
    def test_all_is_ok_with_any_action(self):
1469
 
        for action, value in self.actions.items():
1470
 
            options = self.parser.parse_args()
1471
 
            setattr(options, action, value)
1472
 
            options.all = True
1473
 
            self.check_option_syntax(options)
1474
 
 
1475
 
    def test_is_enabled_fails_without_client(self):
1476
 
        options = self.parser.parse_args()
1477
 
        options.is_enabled = True
1478
 
        with self.assertParseError():
1479
 
            self.check_option_syntax(options)
1480
 
 
1481
 
    def test_is_enabled_works_with_one_client(self):
1482
 
        options = self.parser.parse_args()
1483
 
        options.is_enabled = True
1484
 
        options.client = ["foo"]
1485
 
        self.check_option_syntax(options)
1486
 
 
1487
 
    def test_is_enabled_fails_with_two_clients(self):
1488
 
        options = self.parser.parse_args()
1489
 
        options.is_enabled = True
1490
 
        options.client = ["foo", "barbar"]
1491
 
        with self.assertParseError():
1492
 
            self.check_option_syntax(options)
 
1800
    values_to_get = [f.getvalue() for f in values_to_set]
 
1801
 
 
1802
 
 
1803
class TestSetTimeoutCmd(TestPropertySetterValueCmd):
 
1804
    command = command.SetTimeout
 
1805
    propname = "Timeout"
 
1806
    values_to_set = [datetime.timedelta(),
 
1807
                     datetime.timedelta(minutes=5),
 
1808
                     datetime.timedelta(seconds=1),
 
1809
                     datetime.timedelta(weeks=1),
 
1810
                     datetime.timedelta(weeks=52)]
 
1811
    values_to_get = [dt.total_seconds()*1000 for dt in values_to_set]
 
1812
 
 
1813
 
 
1814
class TestSetExtendedTimeoutCmd(TestPropertySetterValueCmd):
 
1815
    command = command.SetExtendedTimeout
 
1816
    propname = "ExtendedTimeout"
 
1817
    values_to_set = [datetime.timedelta(),
 
1818
                     datetime.timedelta(minutes=5),
 
1819
                     datetime.timedelta(seconds=1),
 
1820
                     datetime.timedelta(weeks=1),
 
1821
                     datetime.timedelta(weeks=52)]
 
1822
    values_to_get = [dt.total_seconds()*1000 for dt in values_to_set]
 
1823
 
 
1824
 
 
1825
class TestSetIntervalCmd(TestPropertySetterValueCmd):
 
1826
    command = command.SetInterval
 
1827
    propname = "Interval"
 
1828
    values_to_set = [datetime.timedelta(),
 
1829
                     datetime.timedelta(minutes=5),
 
1830
                     datetime.timedelta(seconds=1),
 
1831
                     datetime.timedelta(weeks=1),
 
1832
                     datetime.timedelta(weeks=52)]
 
1833
    values_to_get = [dt.total_seconds()*1000 for dt in values_to_set]
 
1834
 
 
1835
 
 
1836
class TestSetApprovalDelayCmd(TestPropertySetterValueCmd):
 
1837
    command = command.SetApprovalDelay
 
1838
    propname = "ApprovalDelay"
 
1839
    values_to_set = [datetime.timedelta(),
 
1840
                     datetime.timedelta(minutes=5),
 
1841
                     datetime.timedelta(seconds=1),
 
1842
                     datetime.timedelta(weeks=1),
 
1843
                     datetime.timedelta(weeks=52)]
 
1844
    values_to_get = [dt.total_seconds()*1000 for dt in values_to_set]
 
1845
 
 
1846
 
 
1847
class TestSetApprovalDurationCmd(TestPropertySetterValueCmd):
 
1848
    command = command.SetApprovalDuration
 
1849
    propname = "ApprovalDuration"
 
1850
    values_to_set = [datetime.timedelta(),
 
1851
                     datetime.timedelta(minutes=5),
 
1852
                     datetime.timedelta(seconds=1),
 
1853
                     datetime.timedelta(weeks=1),
 
1854
                     datetime.timedelta(weeks=52)]
 
1855
    values_to_get = [dt.total_seconds()*1000 for dt in values_to_set]
1493
1856
 
1494
1857
 
1495
1858
 
1510
1873
    return tests
1511
1874
 
1512
1875
if __name__ == "__main__":
1513
 
    if should_only_run_tests():
1514
 
        # Call using ./tdd-python-script --check [--verbose]
1515
 
        unittest.main()
1516
 
    else:
1517
 
        main()
 
1876
    try:
 
1877
        if should_only_run_tests():
 
1878
            # Call using ./tdd-python-script --check [--verbose]
 
1879
            unittest.main()
 
1880
        else:
 
1881
            main()
 
1882
    finally:
 
1883
        logging.shutdown()