/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

« back to all changes in this revision

Viewing changes to mandos-ctl

  • Committer: Teddy Hogeborn
  • Date: 2019-03-04 18:43:22 UTC
  • Revision ID: teddy@recompile.se-20190304184322-6tumlykqh57t5nvs
mandos-ctl: Add test for RemoveCmd

* mandos-ctl (TestRemoveCmd): New.

Show diffs side-by-side

added added

removed removed

Lines of Context:
61
61
 
62
62
locale.setlocale(locale.LC_ALL, "")
63
63
 
64
 
defaultkeywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
65
64
domain = "se.recompile"
66
65
busname = domain + ".Mandos"
67
66
server_path = "/"
216
215
 
217
216
 
218
217
def string_to_delta(interval):
219
 
    """Parse a string and return a datetime.timedelta
220
 
    """
 
218
    """Parse a string and return a datetime.timedelta"""
221
219
 
222
220
    try:
223
221
        return rfc3339_duration_to_delta(interval)
228
226
 
229
227
 
230
228
def parse_pre_1_6_1_interval(interval):
231
 
    """Parse an interval string as documented by Mandos before 1.6.1, and
232
 
    return a datetime.timedelta
 
229
    """Parse an interval string as documented by Mandos before 1.6.1,
 
230
    and return a datetime.timedelta
 
231
 
233
232
    >>> parse_pre_1_6_1_interval('7d')
234
233
    datetime.timedelta(7)
235
234
    >>> parse_pre_1_6_1_interval('60s')
269
268
    return value
270
269
 
271
270
 
272
 
class TableOfClients(object):
273
 
    tablewords = {
274
 
        "Name": "Name",
275
 
        "Enabled": "Enabled",
276
 
        "Timeout": "Timeout",
277
 
        "LastCheckedOK": "Last Successful Check",
278
 
        "LastApprovalRequest": "Last Approval Request",
279
 
        "Created": "Created",
280
 
        "Interval": "Interval",
281
 
        "Host": "Host",
282
 
        "Fingerprint": "Fingerprint",
283
 
        "KeyID": "Key ID",
284
 
        "CheckerRunning": "Check Is Running",
285
 
        "LastEnabled": "Last Enabled",
286
 
        "ApprovalPending": "Approval Is Pending",
287
 
        "ApprovedByDefault": "Approved By Default",
288
 
        "ApprovalDelay": "Approval Delay",
289
 
        "ApprovalDuration": "Approval Duration",
290
 
        "Checker": "Checker",
291
 
        "ExtendedTimeout": "Extended Timeout",
292
 
        "Expires": "Expires",
293
 
        "LastCheckerStatus": "Last Checker Status",
294
 
    }
295
 
 
296
 
    def __init__(self, clients, keywords, tablewords=None):
297
 
        self.clients = clients
298
 
        self.keywords = keywords
299
 
        if tablewords is not None:
300
 
            self.tablewords = tablewords
301
 
 
302
 
    def __str__(self):
303
 
        return "\n".join(self.rows())
304
 
 
305
 
    if sys.version_info.major == 2:
306
 
        __unicode__ = __str__
 
271
## Classes for commands.
 
272
 
 
273
# Abstract classes first
 
274
class Command(object):
 
275
    """Abstract class for commands"""
 
276
    def run(self, mandos, clients):
 
277
        """Normal commands should implement run_on_one_client(), but
 
278
        commands which want to operate on all clients at the same time
 
279
        can override this run() method instead."""
 
280
        self.mandos = mandos
 
281
        for client in clients:
 
282
            self.run_on_one_client(client)
 
283
 
 
284
class PrintCmd(Command):
 
285
    """Abstract class for commands printing client details"""
 
286
    all_keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK",
 
287
                    "Created", "Interval", "Host", "KeyID",
 
288
                    "Fingerprint", "CheckerRunning", "LastEnabled",
 
289
                    "ApprovalPending", "ApprovedByDefault",
 
290
                    "LastApprovalRequest", "ApprovalDelay",
 
291
                    "ApprovalDuration", "Checker", "ExtendedTimeout",
 
292
                    "Expires", "LastCheckerStatus")
 
293
    def run(self, mandos, clients):
 
294
        print(self.output(clients))
 
295
 
 
296
class PropertyCmd(Command):
 
297
    """Abstract class for Actions for setting one client property"""
 
298
    def run_on_one_client(self, client):
 
299
        """Set the Client's D-Bus property"""
 
300
        client.Set(client_interface, self.property, self.value_to_set,
 
301
                   dbus_interface=dbus.PROPERTIES_IFACE)
 
302
 
 
303
class ValueArgumentMixIn(object):
 
304
    """Mixin class for commands taking a value as argument"""
 
305
    def __init__(self, value):
 
306
        self.value_to_set = value
 
307
 
 
308
class MillisecondsValueArgumentMixIn(ValueArgumentMixIn):
 
309
    """Mixin class for commands taking a value argument as
 
310
    milliseconds."""
 
311
    @property
 
312
    def value_to_set(self):
 
313
        return self._vts
 
314
    @value_to_set.setter
 
315
    def value_to_set(self, value):
 
316
        """When setting, convert value to a datetime.timedelta"""
 
317
        self._vts = string_to_delta(value).total_seconds() * 1000
 
318
 
 
319
# Actual (non-abstract) command classes
 
320
 
 
321
class PrintTableCmd(PrintCmd):
 
322
    def __init__(self, verbose=False):
 
323
        self.verbose = verbose
 
324
 
 
325
    def output(self, clients):
 
326
        if self.verbose:
 
327
            keywords = self.all_keywords
 
328
        else:
 
329
            keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
 
330
        return str(self.TableOfClients(clients.values(), keywords))
 
331
 
 
332
    class TableOfClients(object):
 
333
        tableheaders = {
 
334
            "Name": "Name",
 
335
            "Enabled": "Enabled",
 
336
            "Timeout": "Timeout",
 
337
            "LastCheckedOK": "Last Successful Check",
 
338
            "LastApprovalRequest": "Last Approval Request",
 
339
            "Created": "Created",
 
340
            "Interval": "Interval",
 
341
            "Host": "Host",
 
342
            "Fingerprint": "Fingerprint",
 
343
            "KeyID": "Key ID",
 
344
            "CheckerRunning": "Check Is Running",
 
345
            "LastEnabled": "Last Enabled",
 
346
            "ApprovalPending": "Approval Is Pending",
 
347
            "ApprovedByDefault": "Approved By Default",
 
348
            "ApprovalDelay": "Approval Delay",
 
349
            "ApprovalDuration": "Approval Duration",
 
350
            "Checker": "Checker",
 
351
            "ExtendedTimeout": "Extended Timeout",
 
352
            "Expires": "Expires",
 
353
            "LastCheckerStatus": "Last Checker Status",
 
354
        }
 
355
 
 
356
        def __init__(self, clients, keywords, tableheaders=None):
 
357
            self.clients = clients
 
358
            self.keywords = keywords
 
359
            if tableheaders is not None:
 
360
                self.tableheaders = tableheaders
 
361
 
307
362
        def __str__(self):
308
 
            return str(self).encode(locale.getpreferredencoding())
309
 
 
310
 
    def rows(self):
311
 
        format_string = self.row_formatting_string()
312
 
        rows = [self.header_line(format_string)]
313
 
        rows.extend(self.client_line(client, format_string)
314
 
                    for client in self.clients)
315
 
        return rows
316
 
 
317
 
    def row_formatting_string(self):
318
 
        "Format string used to format table rows"
319
 
        return " ".join("{{{key}:{width}}}".format(
320
 
            width=max(len(self.tablewords[key]),
321
 
                      max(len(self.string_from_client(client, key))
322
 
                          for client in self.clients)),
323
 
            key=key)
324
 
                                 for key in self.keywords)
325
 
 
326
 
    def string_from_client(self, client, key):
327
 
        return self.valuetostring(client[key], key)
328
 
 
 
363
            return "\n".join(self.rows())
 
364
 
 
365
        if sys.version_info.major == 2:
 
366
            __unicode__ = __str__
 
367
            def __str__(self):
 
368
                return str(self).encode(locale.getpreferredencoding())
 
369
 
 
370
        def rows(self):
 
371
            format_string = self.row_formatting_string()
 
372
            rows = [self.header_line(format_string)]
 
373
            rows.extend(self.client_line(client, format_string)
 
374
                        for client in self.clients)
 
375
            return rows
 
376
 
 
377
        def row_formatting_string(self):
 
378
            "Format string used to format table rows"
 
379
            return " ".join("{{{key}:{width}}}".format(
 
380
                width=max(len(self.tableheaders[key]),
 
381
                          *(len(self.string_from_client(client, key))
 
382
                            for client in self.clients)),
 
383
                key=key)
 
384
                            for key in self.keywords)
 
385
 
 
386
        def string_from_client(self, client, key):
 
387
            return self.valuetostring(client[key], key)
 
388
 
 
389
        @staticmethod
 
390
        def valuetostring(value, keyword):
 
391
            if isinstance(value, dbus.Boolean):
 
392
                return "Yes" if value else "No"
 
393
            if keyword in ("Timeout", "Interval", "ApprovalDelay",
 
394
                           "ApprovalDuration", "ExtendedTimeout"):
 
395
                return milliseconds_to_string(value)
 
396
            return str(value)
 
397
 
 
398
        def header_line(self, format_string):
 
399
            return format_string.format(**self.tableheaders)
 
400
 
 
401
        def client_line(self, client, format_string):
 
402
            return format_string.format(
 
403
                **{key: self.string_from_client(client, key)
 
404
                   for key in self.keywords})
 
405
 
 
406
 
 
407
 
 
408
class DumpJSONCmd(PrintCmd):
 
409
    def output(self, clients):
 
410
        data = {client["Name"]:
 
411
                {key: self.dbus_boolean_to_bool(client[key])
 
412
                 for key in self.all_keywords}
 
413
                for client in clients.values()}
 
414
        return json.dumps(data, indent=4, separators=(',', ': '))
329
415
    @staticmethod
330
 
    def valuetostring(value, keyword):
 
416
    def dbus_boolean_to_bool(value):
331
417
        if isinstance(value, dbus.Boolean):
332
 
            return "Yes" if value else "No"
333
 
        if keyword in ("Timeout", "Interval", "ApprovalDelay",
334
 
                       "ApprovalDuration", "ExtendedTimeout"):
335
 
            return milliseconds_to_string(value)
336
 
        return str(value)
337
 
 
338
 
    def header_line(self, format_string):
339
 
        return format_string.format(**self.tablewords)
340
 
 
341
 
    def client_line(self, client, format_string):
342
 
        return format_string.format(
343
 
            **{key: self.string_from_client(client, key)
344
 
               for key in self.keywords})
345
 
 
 
418
            value = bool(value)
 
419
        return value
 
420
 
 
421
class IsEnabledCmd(Command):
 
422
    def run_on_one_client(self, client):
 
423
        if self.is_enabled(client):
 
424
            sys.exit(0)
 
425
        sys.exit(1)
 
426
    def is_enabled(self, client):
 
427
        return client.Get(client_interface, "Enabled",
 
428
                          dbus_interface=dbus.PROPERTIES_IFACE)
 
429
 
 
430
class RemoveCmd(Command):
 
431
    def run_on_one_client(self, client):
 
432
        self.mandos.RemoveClient(client.__dbus_object_path__)
 
433
 
 
434
class ApproveCmd(Command):
 
435
    def run_on_one_client(self, client):
 
436
        client.Approve(dbus.Boolean(True),
 
437
                       dbus_interface=client_interface)
 
438
 
 
439
class DenyCmd(Command):
 
440
    def run_on_one_client(self, client):
 
441
        client.Approve(dbus.Boolean(False),
 
442
                       dbus_interface=client_interface)
 
443
 
 
444
class EnableCmd(PropertyCmd):
 
445
    property = "Enabled"
 
446
    value_to_set = dbus.Boolean(True)
 
447
 
 
448
class DisableCmd(PropertyCmd):
 
449
    property = "Enabled"
 
450
    value_to_set = dbus.Boolean(False)
 
451
 
 
452
class BumpTimeoutCmd(PropertyCmd):
 
453
    property = "LastCheckedOK"
 
454
    value_to_set = ""
 
455
 
 
456
class StartCheckerCmd(PropertyCmd):
 
457
    property = "CheckerRunning"
 
458
    value_to_set = dbus.Boolean(True)
 
459
 
 
460
class StopCheckerCmd(PropertyCmd):
 
461
    property = "CheckerRunning"
 
462
    value_to_set = dbus.Boolean(False)
 
463
 
 
464
class ApproveByDefaultCmd(PropertyCmd):
 
465
    property = "ApprovedByDefault"
 
466
    value_to_set = dbus.Boolean(True)
 
467
 
 
468
class DenyByDefaultCmd(PropertyCmd):
 
469
    property = "ApprovedByDefault"
 
470
    value_to_set = dbus.Boolean(False)
 
471
 
 
472
class SetCheckerCmd(PropertyCmd, ValueArgumentMixIn):
 
473
    property = "Checker"
 
474
 
 
475
class SetHostCmd(PropertyCmd, ValueArgumentMixIn):
 
476
    property = "Host"
 
477
 
 
478
class SetSecretCmd(PropertyCmd, ValueArgumentMixIn):
 
479
    property = "Secret"
 
480
 
 
481
class SetTimeoutCmd(PropertyCmd, MillisecondsValueArgumentMixIn):
 
482
    property = "Timeout"
 
483
 
 
484
class SetExtendedTimeoutCmd(PropertyCmd,
 
485
                            MillisecondsValueArgumentMixIn):
 
486
    property = "ExtendedTimeout"
 
487
 
 
488
class SetIntervalCmd(PropertyCmd, MillisecondsValueArgumentMixIn):
 
489
    property = "Interval"
 
490
 
 
491
class SetApprovalDelayCmd(PropertyCmd,
 
492
                          MillisecondsValueArgumentMixIn):
 
493
    property = "ApprovalDelay"
 
494
 
 
495
class SetApprovalDurationCmd(PropertyCmd,
 
496
                             MillisecondsValueArgumentMixIn):
 
497
    property = "ApprovalDuration"
346
498
 
347
499
def has_actions(options):
348
500
    return any((options.enable,
364
516
                options.approve,
365
517
                options.deny))
366
518
 
367
 
 
368
 
def main():
369
 
    parser = argparse.ArgumentParser()
 
519
def add_command_line_options(parser):
370
520
    parser.add_argument("--version", action="version",
371
521
                        version="%(prog)s {}".format(version),
372
522
                        help="show version number and exit")
376
526
                        help="Print all fields")
377
527
    parser.add_argument("-j", "--dump-json", action="store_true",
378
528
                        help="Dump client data in JSON format")
379
 
    parser.add_argument("-e", "--enable", action="store_true",
380
 
                        help="Enable client")
381
 
    parser.add_argument("-d", "--disable", action="store_true",
382
 
                        help="disable client")
 
529
    enable_disable = parser.add_mutually_exclusive_group()
 
530
    enable_disable.add_argument("-e", "--enable", action="store_true",
 
531
                                help="Enable client")
 
532
    enable_disable.add_argument("-d", "--disable",
 
533
                                action="store_true",
 
534
                                help="disable client")
383
535
    parser.add_argument("-b", "--bump-timeout", action="store_true",
384
536
                        help="Bump timeout for client")
385
 
    parser.add_argument("--start-checker", action="store_true",
386
 
                        help="Start checker for client")
387
 
    parser.add_argument("--stop-checker", action="store_true",
388
 
                        help="Stop checker for client")
 
537
    start_stop_checker = parser.add_mutually_exclusive_group()
 
538
    start_stop_checker.add_argument("--start-checker",
 
539
                                    action="store_true",
 
540
                                    help="Start checker for client")
 
541
    start_stop_checker.add_argument("--stop-checker",
 
542
                                    action="store_true",
 
543
                                    help="Stop checker for client")
389
544
    parser.add_argument("-V", "--is-enabled", action="store_true",
390
545
                        help="Check if client is enabled")
391
546
    parser.add_argument("-r", "--remove", action="store_true",
398
553
                        help="Set extended timeout for client")
399
554
    parser.add_argument("-i", "--interval",
400
555
                        help="Set checker interval for client")
401
 
    parser.add_argument("--approve-by-default", action="store_true",
402
 
                        default=None, dest="approved_by_default",
403
 
                        help="Set client to be approved by default")
404
 
    parser.add_argument("--deny-by-default", action="store_false",
405
 
                        dest="approved_by_default",
406
 
                        help="Set client to be denied by default")
 
556
    approve_deny_default = parser.add_mutually_exclusive_group()
 
557
    approve_deny_default.add_argument(
 
558
        "--approve-by-default", action="store_true",
 
559
        default=None, dest="approved_by_default",
 
560
        help="Set client to be approved by default")
 
561
    approve_deny_default.add_argument(
 
562
        "--deny-by-default", action="store_false",
 
563
        dest="approved_by_default",
 
564
        help="Set client to be denied by default")
407
565
    parser.add_argument("--approval-delay",
408
566
                        help="Set delay before client approve/deny")
409
567
    parser.add_argument("--approval-duration",
412
570
    parser.add_argument("-s", "--secret",
413
571
                        type=argparse.FileType(mode="rb"),
414
572
                        help="Set password blob (file) for client")
415
 
    parser.add_argument("-A", "--approve", action="store_true",
416
 
                        help="Approve any current client request")
417
 
    parser.add_argument("-D", "--deny", action="store_true",
418
 
                        help="Deny any current client request")
 
573
    approve_deny = parser.add_mutually_exclusive_group()
 
574
    approve_deny.add_argument(
 
575
        "-A", "--approve", action="store_true",
 
576
        help="Approve any current client request")
 
577
    approve_deny.add_argument("-D", "--deny", action="store_true",
 
578
                              help="Deny any current client request")
419
579
    parser.add_argument("--check", action="store_true",
420
580
                        help="Run self-test")
421
581
    parser.add_argument("client", nargs="*", help="Client name")
 
582
 
 
583
 
 
584
def commands_and_clients_from_options(options):
 
585
 
 
586
    commands = []
 
587
 
 
588
    if options.dump_json:
 
589
        commands.append(DumpJSONCmd())
 
590
 
 
591
    if options.enable:
 
592
        commands.append(EnableCmd())
 
593
 
 
594
    if options.disable:
 
595
        commands.append(DisableCmd())
 
596
 
 
597
    if options.bump_timeout:
 
598
        commands.append(BumpTimeoutCmd(options.bump_timeout))
 
599
 
 
600
    if options.start_checker:
 
601
        commands.append(StartCheckerCmd())
 
602
 
 
603
    if options.stop_checker:
 
604
        commands.append(StopCheckerCmd())
 
605
 
 
606
    if options.is_enabled:
 
607
        commands.append(IsEnabledCmd())
 
608
 
 
609
    if options.remove:
 
610
        commands.append(RemoveCmd())
 
611
 
 
612
    if options.checker is not None:
 
613
        commands.append(SetCheckerCmd())
 
614
 
 
615
    if options.timeout is not None:
 
616
        commands.append(SetTimeoutCmd(options.timeout))
 
617
 
 
618
    if options.extended_timeout:
 
619
        commands.append(
 
620
            SetExtendedTimeoutCmd(options.extended_timeout))
 
621
 
 
622
    if options.interval is not None:
 
623
        command.append(SetIntervalCmd(options.interval))
 
624
 
 
625
    if options.approved_by_default is not None:
 
626
        if options.approved_by_default:
 
627
            command.append(ApproveByDefaultCmd())
 
628
        else:
 
629
            command.append(DenyByDefaultCmd())
 
630
 
 
631
    if options.approval_delay is not None:
 
632
        command.append(SetApprovalDelayCmd(options.approval_delay))
 
633
 
 
634
    if options.approval_duration is not None:
 
635
        command.append(
 
636
            SetApprovalDurationCmd(options.approval_duration))
 
637
 
 
638
    if options.host is not None:
 
639
        command.append(SetHostCmd(options.host))
 
640
 
 
641
    if options.secret is not None:
 
642
        command.append(SetSecretCmd(options.secret))
 
643
 
 
644
    if options.approve:
 
645
        commands.append(ApproveCmd())
 
646
 
 
647
    if options.deny:
 
648
        commands.append(DenyCmd())
 
649
 
 
650
    # If no command option has been given, show table of clients,
 
651
    # optionally verbosely
 
652
    if not commands:
 
653
        commands.append(PrintTableCmd(verbose=options.verbose))
 
654
 
 
655
    return commands, options.client
 
656
 
 
657
 
 
658
def main():
 
659
    parser = argparse.ArgumentParser()
 
660
 
 
661
    add_command_line_options(parser)
 
662
 
422
663
    options = parser.parse_args()
423
664
 
424
665
    if has_actions(options) and not (options.client or options.all):
430
671
        parser.error("--dump-json can only be used alone.")
431
672
    if options.all and not has_actions(options):
432
673
        parser.error("--all requires an action.")
 
674
    if options.is_enabled and len(options.client) > 1:
 
675
        parser.error("--is-enabled requires exactly one client")
 
676
 
 
677
    commands, clientnames = commands_and_clients_from_options(options)
433
678
 
434
679
    try:
435
680
        bus = dbus.SystemBus()
443
688
    mandos_serv_object_manager = dbus.Interface(
444
689
        mandos_dbus_objc, dbus_interface=dbus.OBJECT_MANAGER_IFACE)
445
690
 
446
 
    # block stderr since dbus library prints to stderr
447
 
    null = os.open(os.path.devnull, os.O_RDWR)
448
 
    stderrcopy = os.dup(sys.stderr.fileno())
449
 
    os.dup2(null, sys.stderr.fileno())
450
 
    os.close(null)
 
691
    # Filter out log message from dbus module
 
692
    dbus_logger = logging.getLogger("dbus.proxies")
 
693
    class NullFilter(logging.Filter):
 
694
        def filter(self, record):
 
695
            return False
 
696
    dbus_filter = NullFilter()
451
697
    try:
452
 
        try:
453
 
            mandos_clients = {path: ifs_and_props[client_interface]
454
 
                              for path, ifs_and_props in
455
 
                              mandos_serv_object_manager
456
 
                              .GetManagedObjects().items()
457
 
                              if client_interface in ifs_and_props}
458
 
        finally:
459
 
            # restore stderr
460
 
            os.dup2(stderrcopy, sys.stderr.fileno())
461
 
            os.close(stderrcopy)
 
698
        dbus_logger.addFilter(dbus_filter)
 
699
        mandos_clients = {path: ifs_and_props[client_interface]
 
700
                          for path, ifs_and_props in
 
701
                          mandos_serv_object_manager
 
702
                          .GetManagedObjects().items()
 
703
                          if client_interface in ifs_and_props}
462
704
    except dbus.exceptions.DBusException as e:
463
705
        log.critical("Failed to access Mandos server through D-Bus:"
464
706
                     "\n%s", e)
465
707
        sys.exit(1)
 
708
    finally:
 
709
        # restore dbus logger
 
710
        dbus_logger.removeFilter(dbus_filter)
466
711
 
467
712
    # Compile dict of (clients: properties) to process
468
713
    clients = {}
469
714
 
470
 
    if options.all or not options.client:
 
715
    if not clientnames:
471
716
        clients = {bus.get_object(busname, path): properties
472
717
                   for path, properties in mandos_clients.items()}
473
718
    else:
474
 
        for name in options.client:
 
719
        for name in clientnames:
475
720
            for path, client in mandos_clients.items():
476
721
                if client["Name"] == name:
477
722
                    client_objc = bus.get_object(busname, path)
481
726
                log.critical("Client not found on server: %r", name)
482
727
                sys.exit(1)
483
728
 
484
 
    if not has_actions(options) and clients:
485
 
        if options.verbose or options.dump_json:
486
 
            keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK",
487
 
                        "Created", "Interval", "Host", "KeyID",
488
 
                        "Fingerprint", "CheckerRunning",
489
 
                        "LastEnabled", "ApprovalPending",
490
 
                        "ApprovedByDefault", "LastApprovalRequest",
491
 
                        "ApprovalDelay", "ApprovalDuration",
492
 
                        "Checker", "ExtendedTimeout", "Expires",
493
 
                        "LastCheckerStatus")
494
 
        else:
495
 
            keywords = defaultkeywords
496
 
 
497
 
        if options.dump_json:
498
 
            json.dump({client["Name"]: {key:
499
 
                                        bool(client[key])
500
 
                                        if isinstance(client[key],
501
 
                                                      dbus.Boolean)
502
 
                                        else client[key]
503
 
                                        for key in keywords}
504
 
                       for client in clients.values()},
505
 
                      fp=sys.stdout, indent=4,
506
 
                      separators=(',', ': '))
507
 
            print()
508
 
        else:
509
 
            print(TableOfClients(clients.values(), keywords))
510
 
    else:
511
 
        # Process each client in the list by all selected options
512
 
        for client in clients:
513
 
 
514
 
            def set_client_prop(prop, value):
515
 
                """Set a Client D-Bus property"""
516
 
                client.Set(client_interface, prop, value,
517
 
                           dbus_interface=dbus.PROPERTIES_IFACE)
518
 
 
519
 
            def set_client_prop_ms(prop, value):
520
 
                """Set a Client D-Bus property, converted
521
 
                from a string to milliseconds."""
522
 
                set_client_prop(prop,
523
 
                                string_to_delta(value).total_seconds()
524
 
                                * 1000)
525
 
 
526
 
            if options.remove:
527
 
                mandos_serv.RemoveClient(client.__dbus_object_path__)
528
 
            if options.enable:
529
 
                set_client_prop("Enabled", dbus.Boolean(True))
530
 
            if options.disable:
531
 
                set_client_prop("Enabled", dbus.Boolean(False))
532
 
            if options.bump_timeout:
533
 
                set_client_prop("LastCheckedOK", "")
534
 
            if options.start_checker:
535
 
                set_client_prop("CheckerRunning", dbus.Boolean(True))
536
 
            if options.stop_checker:
537
 
                set_client_prop("CheckerRunning", dbus.Boolean(False))
538
 
            if options.is_enabled:
539
 
                if client.Get(client_interface, "Enabled",
540
 
                              dbus_interface=dbus.PROPERTIES_IFACE):
541
 
                    sys.exit(0)
542
 
                else:
543
 
                    sys.exit(1)
544
 
            if options.checker is not None:
545
 
                set_client_prop("Checker", options.checker)
546
 
            if options.host is not None:
547
 
                set_client_prop("Host", options.host)
548
 
            if options.interval is not None:
549
 
                set_client_prop_ms("Interval", options.interval)
550
 
            if options.approval_delay is not None:
551
 
                set_client_prop_ms("ApprovalDelay",
552
 
                                   options.approval_delay)
553
 
            if options.approval_duration is not None:
554
 
                set_client_prop_ms("ApprovalDuration",
555
 
                                   options.approval_duration)
556
 
            if options.timeout is not None:
557
 
                set_client_prop_ms("Timeout", options.timeout)
558
 
            if options.extended_timeout is not None:
559
 
                set_client_prop_ms("ExtendedTimeout",
560
 
                                   options.extended_timeout)
561
 
            if options.secret is not None:
562
 
                set_client_prop("Secret",
563
 
                                dbus.ByteArray(options.secret.read()))
564
 
            if options.approved_by_default is not None:
565
 
                set_client_prop("ApprovedByDefault",
566
 
                                dbus.Boolean(options
567
 
                                             .approved_by_default))
568
 
            if options.approve:
569
 
                client.Approve(dbus.Boolean(True),
570
 
                               dbus_interface=client_interface)
571
 
            elif options.deny:
572
 
                client.Approve(dbus.Boolean(False),
573
 
                               dbus_interface=client_interface)
 
729
    # Run all commands on clients
 
730
    for command in commands:
 
731
        command.run(mandos_serv, clients)
574
732
 
575
733
 
576
734
class Test_milliseconds_to_string(unittest.TestCase):
596
754
            with self.assertLogs(log, logging.WARNING):
597
755
                value = string_to_delta("2h")
598
756
        else:
599
 
            value = string_to_delta("2h")
 
757
            class WarningFilter(logging.Filter):
 
758
                """Don't show, but record the presence of, warnings"""
 
759
                def filter(self, record):
 
760
                    is_warning = record.levelno >= logging.WARNING
 
761
                    self.found = is_warning or getattr(self, "found",
 
762
                                                       False)
 
763
                    return not is_warning
 
764
            warning_filter = WarningFilter()
 
765
            log.addFilter(warning_filter)
 
766
            try:
 
767
                value = string_to_delta("2h")
 
768
            finally:
 
769
                log.removeFilter(warning_filter)
 
770
            self.assertTrue(getattr(warning_filter, "found", False))
600
771
        self.assertEqual(value, datetime.timedelta(0, 7200))
601
772
 
602
 
class Test_TableOfClients(unittest.TestCase):
603
 
    def setUp(self):
604
 
        self.tablewords = {
605
 
            "Attr1": "X",
606
 
            "AttrTwo": "Yy",
607
 
            "AttrThree": "Zzz",
608
 
            "Bool": "A D-BUS Boolean",
609
 
            "NonDbusBoolean": "A Non-D-BUS Boolean",
610
 
            "Integer": "An Integer",
611
 
            "Timeout": "Timedelta 1",
612
 
            "Interval": "Timedelta 2",
613
 
            "ApprovalDelay": "Timedelta 3",
614
 
            "ApprovalDuration": "Timedelta 4",
615
 
            "ExtendedTimeout": "Timedelta 5",
616
 
            "String": "A String",
 
773
 
 
774
class TestCmd(unittest.TestCase):
 
775
    """Abstract class for tests of command classes"""
 
776
    def setUp(self):
 
777
        testcase = self
 
778
        class MockClient(object):
 
779
            def __init__(self, name, **attributes):
 
780
                self.__dbus_object_path__ = "objpath_{}".format(name)
 
781
                self.attributes = attributes
 
782
                self.attributes["Name"] = name
 
783
                self.calls = []
 
784
            def Set(self, interface, property, value, dbus_interface):
 
785
                testcase.assertEqual(interface, client_interface)
 
786
                testcase.assertEqual(dbus_interface,
 
787
                                     dbus.PROPERTIES_IFACE)
 
788
                self.attributes[property] = value
 
789
                self.calls.append(("Set", (interface, property, value,
 
790
                                           dbus_interface)))
 
791
            def Get(self, interface, property, dbus_interface):
 
792
                testcase.assertEqual(interface, client_interface)
 
793
                testcase.assertEqual(dbus_interface,
 
794
                                     dbus.PROPERTIES_IFACE)
 
795
                self.calls.append(("Get", (interface, property,
 
796
                                           dbus_interface)))
 
797
                return self.attributes[property]
 
798
            def __getitem__(self, key):
 
799
                return self.attributes[key]
 
800
            def __setitem__(self, key, value):
 
801
                self.attributes[key] = value
 
802
        self.clients = collections.OrderedDict([
 
803
            ("foo",
 
804
             MockClient(
 
805
                 "foo",
 
806
                 KeyID=("92ed150794387c03ce684574b1139a65"
 
807
                        "94a34f895daaaf09fd8ea90a27cddb12"),
 
808
                 Secret=b"secret",
 
809
                 Host="foo.example.org",
 
810
                 Enabled=dbus.Boolean(True),
 
811
                 Timeout=300000,
 
812
                 LastCheckedOK="2019-02-03T00:00:00",
 
813
                 Created="2019-01-02T00:00:00",
 
814
                 Interval=120000,
 
815
                 Fingerprint=("778827225BA7DE539C5A"
 
816
                              "7CFA59CFF7CDBD9A5920"),
 
817
                 CheckerRunning=dbus.Boolean(False),
 
818
                 LastEnabled="2019-01-03T00:00:00",
 
819
                 ApprovalPending=dbus.Boolean(False),
 
820
                 ApprovedByDefault=dbus.Boolean(True),
 
821
                 LastApprovalRequest="",
 
822
                 ApprovalDelay=0,
 
823
                 ApprovalDuration=1000,
 
824
                 Checker="fping -q -- %(host)s",
 
825
                 ExtendedTimeout=900000,
 
826
                 Expires="2019-02-04T00:00:00",
 
827
                 LastCheckerStatus=0)),
 
828
            ("barbar",
 
829
             MockClient(
 
830
                 "barbar",
 
831
                 KeyID=("0558568eedd67d622f5c83b35a115f79"
 
832
                        "6ab612cff5ad227247e46c2b020f441c"),
 
833
                 Secret=b"secretbar",
 
834
                 Host="192.0.2.3",
 
835
                 Enabled=dbus.Boolean(True),
 
836
                 Timeout=300000,
 
837
                 LastCheckedOK="2019-02-04T00:00:00",
 
838
                 Created="2019-01-03T00:00:00",
 
839
                 Interval=120000,
 
840
                 Fingerprint=("3E393AEAEFB84C7E89E2"
 
841
                              "F547B3A107558FCA3A27"),
 
842
                 CheckerRunning=dbus.Boolean(True),
 
843
                 LastEnabled="2019-01-04T00:00:00",
 
844
                 ApprovalPending=dbus.Boolean(False),
 
845
                 ApprovedByDefault=dbus.Boolean(False),
 
846
                 LastApprovalRequest="2019-01-03T00:00:00",
 
847
                 ApprovalDelay=30000,
 
848
                 ApprovalDuration=1000,
 
849
                 Checker=":",
 
850
                 ExtendedTimeout=900000,
 
851
                 Expires="2019-02-05T00:00:00",
 
852
                 LastCheckerStatus=-2)),
 
853
            ])
 
854
 
 
855
class TestPrintTableCmd(TestCmd):
 
856
    def test_normal(self):
 
857
        output = PrintTableCmd().output(self.clients)
 
858
        expected_output = """
 
859
Name   Enabled Timeout  Last Successful Check
 
860
foo    Yes     00:05:00 2019-02-03T00:00:00  
 
861
barbar Yes     00:05:00 2019-02-04T00:00:00  
 
862
"""[1:-1]
 
863
        self.assertEqual(output, expected_output)
 
864
    def test_verbose(self):
 
865
        output = PrintTableCmd(verbose=True).output(self.clients)
 
866
        expected_output = """
 
867
Name   Enabled Timeout  Last Successful Check Created             Interval Host            Key ID                                                           Fingerprint                              Check Is Running Last Enabled        Approval Is Pending Approved By Default Last Approval Request Approval Delay Approval Duration Checker              Extended Timeout Expires             Last Checker Status
 
868
foo    Yes     00:05:00 2019-02-03T00:00:00   2019-01-02T00:00:00 00:02:00 foo.example.org 92ed150794387c03ce684574b1139a6594a34f895daaaf09fd8ea90a27cddb12 778827225BA7DE539C5A7CFA59CFF7CDBD9A5920 No               2019-01-03T00:00:00 No                  Yes                                       00:00:00       00:00:01          fping -q -- %(host)s 00:15:00         2019-02-04T00:00:00 0                  
 
869
barbar Yes     00:05:00 2019-02-04T00:00:00   2019-01-03T00:00:00 00:02:00 192.0.2.3       0558568eedd67d622f5c83b35a115f796ab612cff5ad227247e46c2b020f441c 3E393AEAEFB84C7E89E2F547B3A107558FCA3A27 Yes              2019-01-04T00:00:00 No                  No                  2019-01-03T00:00:00   00:00:30       00:00:01          :                    00:15:00         2019-02-05T00:00:00 -2                 
 
870
"""[1:-1]
 
871
        self.assertEqual(output, expected_output)
 
872
    def test_one_client(self):
 
873
        output = PrintTableCmd().output({"foo": self.clients["foo"]})
 
874
        expected_output = """
 
875
Name Enabled Timeout  Last Successful Check
 
876
foo  Yes     00:05:00 2019-02-03T00:00:00  
 
877
"""[1:-1]
 
878
        self.assertEqual(output, expected_output)
 
879
 
 
880
class TestDumpJSONCmd(TestCmd):
 
881
    def setUp(self):
 
882
        self.expected_json = {
 
883
            "foo": {
 
884
                "Name": "foo",
 
885
                "KeyID": ("92ed150794387c03ce684574b1139a65"
 
886
                          "94a34f895daaaf09fd8ea90a27cddb12"),
 
887
                "Host": "foo.example.org",
 
888
                "Enabled": True,
 
889
                "Timeout": 300000,
 
890
                "LastCheckedOK": "2019-02-03T00:00:00",
 
891
                "Created": "2019-01-02T00:00:00",
 
892
                "Interval": 120000,
 
893
                "Fingerprint": ("778827225BA7DE539C5A"
 
894
                                "7CFA59CFF7CDBD9A5920"),
 
895
                "CheckerRunning": False,
 
896
                "LastEnabled": "2019-01-03T00:00:00",
 
897
                "ApprovalPending": False,
 
898
                "ApprovedByDefault": True,
 
899
                "LastApprovalRequest": "",
 
900
                "ApprovalDelay": 0,
 
901
                "ApprovalDuration": 1000,
 
902
                "Checker": "fping -q -- %(host)s",
 
903
                "ExtendedTimeout": 900000,
 
904
                "Expires": "2019-02-04T00:00:00",
 
905
                "LastCheckerStatus": 0,
 
906
            },
 
907
            "barbar": {
 
908
                "Name": "barbar",
 
909
                "KeyID": ("0558568eedd67d622f5c83b35a115f79"
 
910
                          "6ab612cff5ad227247e46c2b020f441c"),
 
911
                "Host": "192.0.2.3",
 
912
                "Enabled": True,
 
913
                "Timeout": 300000,
 
914
                "LastCheckedOK": "2019-02-04T00:00:00",
 
915
                "Created": "2019-01-03T00:00:00",
 
916
                "Interval": 120000,
 
917
                "Fingerprint": ("3E393AEAEFB84C7E89E2"
 
918
                                "F547B3A107558FCA3A27"),
 
919
                "CheckerRunning": True,
 
920
                "LastEnabled": "2019-01-04T00:00:00",
 
921
                "ApprovalPending": False,
 
922
                "ApprovedByDefault": False,
 
923
                "LastApprovalRequest": "2019-01-03T00:00:00",
 
924
                "ApprovalDelay": 30000,
 
925
                "ApprovalDuration": 1000,
 
926
                "Checker": ":",
 
927
                "ExtendedTimeout": 900000,
 
928
                "Expires": "2019-02-05T00:00:00",
 
929
                "LastCheckerStatus": -2,
 
930
            },
617
931
        }
618
 
        self.keywords = ["Attr1", "AttrTwo"]
619
 
        self.clients = [
620
 
            {
621
 
                "Attr1": "x1",
622
 
                "AttrTwo": "y1",
623
 
                "AttrThree": "z1",
624
 
                "Bool": dbus.Boolean(False),
625
 
                "NonDbusBoolean": False,
626
 
                "Integer": 0,
627
 
                "Timeout": 0,
628
 
                "Interval": 1000,
629
 
                "ApprovalDelay": 2000,
630
 
                "ApprovalDuration": 3000,
631
 
                "ExtendedTimeout": 4000,
632
 
                "String": "",
633
 
            },
634
 
            {
635
 
                "Attr1": "x2",
636
 
                "AttrTwo": "y2",
637
 
                "AttrThree": "z2",
638
 
                "Bool": dbus.Boolean(True),
639
 
                "NonDbusBoolean": True,
640
 
                "Integer": 1,
641
 
                "Timeout": 93785000,
642
 
                "Interval": 93786000,
643
 
                "ApprovalDelay": 93787000,
644
 
                "ApprovalDuration": 93788000,
645
 
                "ExtendedTimeout": 93789000,
646
 
                "String": "A huge string which will not fit," * 10,
647
 
            },
648
 
        ]
649
 
    def test_short_header(self):
650
 
        rows = TableOfClients(self.clients, self.keywords,
651
 
                              self.tablewords).rows()
652
 
        expected_rows = [
653
 
            "X  Yy",
654
 
            "x1 y1",
655
 
            "x2 y2"]
656
 
        self.assertEqual(rows, expected_rows)
657
 
    def test_booleans(self):
658
 
        keywords = ["Bool", "NonDbusBoolean"]
659
 
        rows = TableOfClients(self.clients, keywords,
660
 
                              self.tablewords).rows()
661
 
        expected_rows = [
662
 
            "A D-BUS Boolean A Non-D-BUS Boolean",
663
 
            "No              False              ",
664
 
            "Yes             True               ",
665
 
        ]
666
 
        self.assertEqual(rows, expected_rows)
667
 
    def test_milliseconds_detection(self):
668
 
        keywords = ["Integer", "Timeout", "Interval", "ApprovalDelay",
669
 
                    "ApprovalDuration", "ExtendedTimeout"]
670
 
        rows = TableOfClients(self.clients, keywords,
671
 
                              self.tablewords).rows()
672
 
        expected_rows = ("""
673
 
An Integer Timedelta 1 Timedelta 2 Timedelta 3 Timedelta 4 Timedelta 5
674
 
0          00:00:00    00:00:01    00:00:02    00:00:03    00:00:04   
675
 
1          1T02:03:05  1T02:03:06  1T02:03:07  1T02:03:08  1T02:03:09 
676
 
"""
677
 
        ).splitlines()[1:]
678
 
        self.assertEqual(rows, expected_rows)
679
 
    def test_empty_and_long_string_values(self):
680
 
        keywords = ["String"]
681
 
        rows = TableOfClients(self.clients, keywords,
682
 
                              self.tablewords).rows()
683
 
        expected_rows = ("""
684
 
A String                                                                                                                                                                                                                                                                                                                                  
685
 
                                                                                                                                                                                                                                                                                                                                          
686
 
A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,A huge string which will not fit,
687
 
"""
688
 
        ).splitlines()[1:]
689
 
        self.assertEqual(rows, expected_rows)
 
932
        return super(TestDumpJSONCmd, self).setUp()
 
933
    def test_normal(self):
 
934
        json_data = json.loads(DumpJSONCmd().output(self.clients))
 
935
        self.assertDictEqual(json_data, self.expected_json)
 
936
    def test_one_client(self):
 
937
        clients = {"foo": self.clients["foo"]}
 
938
        json_data = json.loads(DumpJSONCmd().output(clients))
 
939
        expected_json = {"foo": self.expected_json["foo"]}
 
940
        self.assertDictEqual(json_data, expected_json)
 
941
 
 
942
class TestIsEnabledCmd(TestCmd):
 
943
    def test_is_enabled(self):
 
944
        self.assertTrue(all(IsEnabledCmd().is_enabled(client)
 
945
                            for client in self.clients.values()))
 
946
    def test_is_enabled_does_get_attribute(self):
 
947
        client = self.clients["foo"]
 
948
        self.assertTrue(IsEnabledCmd().is_enabled(client))
 
949
        self.assertListEqual(client.calls,
 
950
                             [("Get",
 
951
                               ("se.recompile.Mandos.Client",
 
952
                                "Enabled",
 
953
                                "org.freedesktop.DBus.Properties"))])
 
954
    def test_is_enabled_run_exits_successfully(self):
 
955
        client = self.clients["foo"]
 
956
        with self.assertRaises(SystemExit) as e:
 
957
            IsEnabledCmd().run(None, [client])
 
958
        if e.exception.code is not None:
 
959
            self.assertEqual(e.exception.code, 0)
 
960
        else:
 
961
            self.assertIsNone(e.exception.code)
 
962
    def test_is_enabled_run_exits_with_failure(self):
 
963
        client = self.clients["foo"]
 
964
        client["Enabled"] = dbus.Boolean(False)
 
965
        with self.assertRaises(SystemExit) as e:
 
966
            IsEnabledCmd().run(None, [client])
 
967
        if isinstance(e.exception.code, int):
 
968
            self.assertNotEqual(e.exception.code, 0)
 
969
        else:
 
970
            self.assertIsNotNone(e.exception.code)
 
971
 
 
972
 
 
973
class TestRemoveCmd(TestCmd):
 
974
    def test_remove(self):
 
975
        client = self.clients["foo"]
 
976
        class MockMandos(object):
 
977
            def __init__(self):
 
978
                self.calls = []
 
979
            def RemoveClient(self, dbus_path):
 
980
                self.calls.append(("RemoveClient", (dbus_path,)))
 
981
        mandos = MockMandos()
 
982
        RemoveCmd().run(mandos, [client])
 
983
        self.assertEqual(len(mandos.calls), 1)
 
984
        self.assertListEqual(mandos.calls,
 
985
                             [("RemoveClient",
 
986
                               (client.__dbus_object_path__,))])
690
987
 
691
988
 
692
989