/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

  • Committer: Teddy Hogeborn
  • Date: 2015-05-23 20:18:34 UTC
  • Revision ID: teddy@recompile.se-20150523201834-e89ex4ito93yni8x
mandos: Use multiprocessing module to run checkers.

For a long time, the Mandos server has occasionally logged the message
"ERROR: Child process vanished".  This was never a fatal error, but it
has been annoying and slightly worrying, since a definite cause was
not found.  One potential cause could be the "multiprocessing" and
"subprocess" modules conflicting w.r.t. SIGCHLD.  To avoid this,
change the running of checkers from using subprocess.Popen
asynchronously to instead first create a multiprocessing.Process()
(which is asynchronous) calling a function, and have that function
then call subprocess.call() (which is synchronous).  In this way, the
only thing using any asynchronous subprocesses is the multiprocessing
module.

This makes it necessary to change one small thing in the D-Bus API,
since the subprocesses.call() function does not expose the raw wait(2)
status value.

DBUS-API (CheckerCompleted): Change the second value provided by this
                             D-Bus signal from the raw wait(2) status
                             to the actual terminating signal number.
mandos (subprocess_call_pipe): New function to be called by
                               multiprocessing.Process (starting a
                               separate process).
(Client.last_checker signal): New attribute for signal which
                              terminated last checker.  Like
                              last_checker_status, only not accessible
                              via D-Bus.
(Client.checker_callback): Take new "connection" argument and use it
                           to get returncode; set last_checker_signal.
                           Return False so gobject does not call this
                           callback again.
(Client.start_checker): Start checker using a multiprocessing.Process
                        instead of a subprocess.Popen.
(ClientDBus.checker_callback): Take new "connection" argument.        Call
                               Client.checker_callback early to have
                               it set last_checker_status and
                               last_checker_signal; use those.  Change
                               second value provided to D-Bus signal
                               CheckerCompleted to use
                               last_checker_signal if checker was
                               terminated by signal.
mandos-monitor: Update to reflect DBus API change.
(MandosClientWidget.checker_completed): Take "signal" instead of
                                        "condition" argument.  Use it
                                        accordingly.  Remove dead code
                                        (os.WCOREDUMP case).
Filename Latest Rev Last Changed Committer Comment Size
..
.bzr-builddeb 185 16 years ago Teddy Hogeborn * .bzr-builddeb/default.conf: New. * Makefile (in Diff
debian 185 16 years ago Teddy Hogeborn * .bzr-builddeb/default.conf: New. * Makefile (in Diff
network-hooks.d 505.3.10 12 years ago Teddy Hogeborn * network-hooks.d: New directory. * network-hooks. Diff
plugins.d 13 16 years ago Björn Påhlsson Added following support: Pluginbased client handle Diff
.bzrignore 585 12 years ago Teddy Hogeborn * .bzrignore (statedir): Added. 188 bytes Diff Download File
clients.conf 609 12 years ago Teddy Hogeborn * clients.conf: Convert all time intervals to new 3.1 KB Diff Download File
common.ent 237.4.55 10 years ago Teddy Hogeborn * Makefile (version): Changed to "1.6.9". * NEWS ( 93 bytes Diff Download File
COPYING 24.1.51 16 years ago Björn Påhlsson Added configuration files support for mandos-clien 34.2 KB Diff Download File
DBUS-API 749.1.1 9 years ago Teddy Hogeborn mandos: Use multiprocessing module to run checkers 6.6 KB Diff Download File
dbus-mandos.conf 24.1.186 13 years ago Björn Påhlsson transitional stuff actually working documented cha 820 bytes Diff Download File
default-mandos 185 16 years ago Teddy Hogeborn * .bzr-builddeb/default.conf: New. * Makefile (in 174 bytes Diff Download File
init.d-mandos 648 10 years ago Teddy Hogeborn Update init script to modern standards. * init.d- 4.3 KB Diff Download File
File initramfs-tools-hook 717 10 years ago Teddy Hogeborn mandos-client: Fix bug with GPGME 1.5.0. * initra 6.2 KB Diff Download File
initramfs-tools-hook-conf 237.2.19 15 years ago Teddy Hogeborn * initramfs-tools-hook-conf: Security bug fix: Add 407 bytes Diff Download File
File initramfs-tools-script 487 13 years ago Teddy Hogeborn * initramfs-tools-script: Abort if plugin-runner i 3.6 KB Diff Download File
File initramfs-unpack 624 11 years ago Teddy Hogeborn * initramfs-unpack: Bug fix: Made executable. 2.2 KB Diff Download File
INSTALL 723.1.1 10 years ago Teddy Hogeborn Require Python 2.7. This is in preparation for th 5.3 KB Diff Download File
intro.xml 742 9 years ago Teddy Hogeborn Add ":!RSA" to GnuTLS priority string, to disallow 15.9 KB Diff Download File
legalnotice.xml 174 16 years ago Teddy Hogeborn * legalnotice.xml: Copy DocBook 4.4-formatted text 1 KB Diff Download File
Makefile 237.4.55 10 years ago Teddy Hogeborn * Makefile (version): Changed to "1.6.9". * NEWS ( 16.1 KB Diff Download File
File mandos 749.1.1 9 years ago Teddy Hogeborn mandos: Use multiprocessing module to run checkers 116 KB Diff Download File
mandos-clients.conf.xml 708 10 years ago Teddy Hogeborn mandos-keygen: Generate "checker" option to use SS 18.5 KB Diff Download File
File mandos-ctl 745 9 years ago Teddy Hogeborn mandos-ctl: Do minor formatting and whitespace adj 18.4 KB Diff Download File
mandos-ctl.xml 608 12 years ago Teddy Hogeborn * Makefile (check): Also check mandos-ctl. * mando 16.3 KB Diff Download File
File mandos-keygen 748 9 years ago Teddy Hogeborn mandos-keygen: Update copyright year. 10.5 KB Diff Download File
mandos-keygen.xml 708 10 years ago Teddy Hogeborn mandos-keygen: Generate "checker" option to use SS 15.2 KB Diff Download File
File mandos-monitor 749.1.1 9 years ago Teddy Hogeborn mandos: Use multiprocessing module to run checkers 29.6 KB Diff Download File
mandos-monitor.xml 713 10 years ago Teddy Hogeborn mandos-monitor: New "verbose" mode to see less imp 6.1 KB Diff Download File
mandos-options.xml 742 9 years ago Teddy Hogeborn Add ":!RSA" to GnuTLS priority string, to disallow 5.4 KB Diff Download File
mandos.conf 744 9 years ago Teddy Hogeborn Add "!RSA" also to examples/documentation. * mand 1.6 KB Diff Download File
mandos.conf.xml 744 9 years ago Teddy Hogeborn Add "!RSA" also to examples/documentation. * mand 8.7 KB Diff Download File
mandos.lsm 237.4.55 10 years ago Teddy Hogeborn * Makefile (version): Changed to "1.6.9". * NEWS ( 906 bytes Diff Download File
mandos.service 734 10 years ago Teddy Hogeborn * mandos.service ([Unit]/Documentation): New. 708 bytes Diff Download File
mandos.xml 741 9 years ago Teddy Hogeborn mandos.xml (SEE ALSO): Update links. Update link 23.7 KB Diff Download File
NEWS 237.4.55 10 years ago Teddy Hogeborn * Makefile (version): Changed to "1.6.9". * NEWS ( 12.5 KB Diff Download File
overview.xml 183 16 years ago Teddy Hogeborn * Makefile (install-client-nokey): Do "&&" instead 926 bytes Diff Download File
plugin-runner.c 716 10 years ago Teddy Hogeborn plugin-runner: Bug Fix: Fix some memory leaks. * 35.6 KB Diff Download File
plugin-runner.conf 342 15 years ago Teddy Hogeborn * initramfs-tools-hook: Bug fix: Add "--userid" an 380 bytes Diff Download File
plugin-runner.xml 544 12 years ago Teddy Hogeborn Updated year in copyright notices. 20.5 KB Diff Download File
README 550 12 years ago Teddy Hogeborn * README: Hint that the intro(8mandos) manual page 409 bytes Diff Download File
TODO 747 9 years ago Teddy Hogeborn mandos-keygen: Bug fix: Only use one SSH key from 5.5 KB Diff Download File