/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

  • Committer: teddy at recompile
  • Date: 2020-12-03 20:30:45 UTC
  • Revision ID: teddy@recompile.se-20201203203045-iqd6nq9y5nwalh1x
Minor fix of a test function

In dracut-module/password-agent, the test function
test_send_password_to_socket_EMSGSIZE() (which tests that the
send_password_to_socket() task function aborts properly when getting
EMSGSIZE when writing to the password socket), part of the test code
is supposed to find a message size which definitely does trigger
EMSGSIZE when send()ing to a socket.  Without a "break" in the proper
place, however, the size given is always exactly 1024 bytes too large.

This is very probably not a problem, since a too large message will
still be too large if it is increased by 1024 bytes, and send(2) in
practice checks the size before reading the buffer.  The biggest issue
would be if some version of send(2) would try to look at the last 1024
bytes of the message buffer before checking the message size; this
would then lead to a buffer over-read when running this test function.
(But even then there would be no security implications since the tests
are not run in the normal operation of the program.)

* dracut-module/password-agent.c
  (test_send_password_to_socket_EMSGSIZE): Break out early when ssret
  < 0 and errno == EMSGSIZE; don't allow loop to increase message_size
  again.
Filename Latest Rev Last Changed Committer Comment Size
..
File bridge 923 6 years ago Teddy Hogeborn Update copyright year to 2018 * DBUS-API: Update 2 KB Diff Download File
bridge.conf 535.1.8 13 years ago teddy at recompile * network-hooks.s/bridge: Don't use interface name 189 bytes Diff Download File
File openvpn 923 6 years ago Teddy Hogeborn Update copyright year to 2018 * DBUS-API: Update 1.4 KB Diff Download File
openvpn.conf 505.3.26 13 years ago teddy at bsnet * network-hooks.d/openvpn: Tolerate relative MANDO 291 bytes Diff Download File
File wireless 923 6 years ago Teddy Hogeborn Update copyright year to 2018 * DBUS-API: Update 4 KB Diff Download File
wireless.conf 535.1.8 13 years ago teddy at recompile * network-hooks.s/bridge: Don't use interface name 611 bytes Diff Download File