/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

  • Committer: teddy at recompile
  • Date: 2020-04-05 21:30:59 UTC
  • Revision ID: teddy@recompile.se-20200405213059-fb2a61ckqynrmatk
Fix file descriptor leak in mandos-client

When the local network has Mandos servers announcing themselves using
real, globally reachable, IPv6 addresses (i.e. not link-local
addresses), but there is no router on the local network providing IPv6
RA (Router Advertisement) packets, the client cannot reach the server
by normal means, since the client only has a link-local IPv6 address,
and has no usable route to reach the server's global IPv6 address.
(This is not a common situation, and usually only happens when the
router itself reboots and runs a Mandos client, since it cannot then
give RA packets to itself.)  The client code has a solution for
this, which consists of adding a temporary local route to reach the
address of the server during communication, and removing this
temporary route afterwards.

This solution with a temporary route works, but has a file descriptor
leak; it leaks one file descriptor for each addition and for each
removal of a route.  If one server requiring an added route is present
on the network, but no servers gives a password, making the client
retry after the default ten seconds, and we furthermore assume a
default 1024 open files limit, the client runs out of file descriptors
after about 90 minutes, after which time the client process will be
useless and fail to retrieve any passwords, necessitating manual
password entry via the keyboard.

Fix this by eliminating the file descriptor leak in the client.

* plugins.d/mandos-client.c (add_delete_local_route): Do
  close(devnull) also in parent process, also if fork() fails, and on
  any failure in child process.
Filename Latest Rev Last Changed Committer Comment Size
..
askpass-fifo.c 979 5 years ago Teddy Hogeborn Update copyright year to 2019 * plugins.d/askpass 5.3 KB Diff Download File
askpass-fifo.xml 969 5 years ago Teddy Hogeborn Update copyright year to 2019 * DBUS-API: Update 5.2 KB Diff Download File
mandos-client.c 1213 4 years ago teddy at recompile Fix file descriptor leak in mandos-client When th 86.2 KB Diff Download File
mandos-client.xml 1127 5 years ago Teddy Hogeborn Add dracut(8) support Add support for the dracut( 32.6 KB Diff Download File
password-prompt.c 1127 5 years ago Teddy Hogeborn Add dracut(8) support Add support for the dracut( 14.4 KB Diff Download File
password-prompt.xml 1127 5 years ago Teddy Hogeborn Add dracut(8) support Add support for the dracut( 10.1 KB Diff Download File
plymouth.c 1205 4 years ago teddy at recompile Use reallocarray() if available, or check for over 16 KB Diff Download File
plymouth.xml 1127 5 years ago Teddy Hogeborn Add dracut(8) support Add support for the dracut( 12.3 KB Diff Download File
splashy.c 923 6 years ago Teddy Hogeborn Update copyright year to 2018 * DBUS-API: Update 11.6 KB Diff Download File
splashy.xml 1127 5 years ago Teddy Hogeborn Add dracut(8) support Add support for the dracut( 9.9 KB Diff Download File
usplash.c 923 6 years ago Teddy Hogeborn Update copyright year to 2018 * DBUS-API: Update 16.1 KB Diff Download File
usplash.xml 1127 5 years ago Teddy Hogeborn Add dracut(8) support Add support for the dracut( 10.4 KB Diff Download File