/mandos/trunk

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/trunk

  • Committer: teddy at recompile
  • Date: 2020-04-05 21:30:59 UTC
  • Revision ID: teddy@recompile.se-20200405213059-fb2a61ckqynrmatk
Fix file descriptor leak in mandos-client

When the local network has Mandos servers announcing themselves using
real, globally reachable, IPv6 addresses (i.e. not link-local
addresses), but there is no router on the local network providing IPv6
RA (Router Advertisement) packets, the client cannot reach the server
by normal means, since the client only has a link-local IPv6 address,
and has no usable route to reach the server's global IPv6 address.
(This is not a common situation, and usually only happens when the
router itself reboots and runs a Mandos client, since it cannot then
give RA packets to itself.)  The client code has a solution for
this, which consists of adding a temporary local route to reach the
address of the server during communication, and removing this
temporary route afterwards.

This solution with a temporary route works, but has a file descriptor
leak; it leaks one file descriptor for each addition and for each
removal of a route.  If one server requiring an added route is present
on the network, but no servers gives a password, making the client
retry after the default ten seconds, and we furthermore assume a
default 1024 open files limit, the client runs out of file descriptors
after about 90 minutes, after which time the client process will be
useless and fail to retrieve any passwords, necessitating manual
password entry via the keyboard.

Fix this by eliminating the file descriptor leak in the client.

* plugins.d/mandos-client.c (add_delete_local_route): Do
  close(devnull) also in parent process, also if fork() fails, and on
  any failure in child process.
Filename Latest Rev Last Changed Committer Comment Size
..
.bzr-builddeb 185 12 years ago Teddy Hogeborn * .bzr-builddeb/default.conf: New. * Makefile (in Diff
debian 185 12 years ago Teddy Hogeborn * .bzr-builddeb/default.conf: New. * Makefile (in Diff
dracut-module 1127 1 year ago Teddy Hogeborn Add dracut(8) support Add support for the dracut( Diff
network-hooks.d 505.3.10 9 years ago Teddy Hogeborn * network-hooks.d: New directory. * network-hooks. Diff
plugin-helpers 738.1.1 5 years ago Teddy Hogeborn Add a plugin helper directory, available to all pl Diff
plugins.d 13 12 years ago Björn Påhlsson Added following support: Pluginbased client handle Diff
.bzrignore 1193 1 year ago teddy at recompile Remove non-project-specific pattern from .bzrignor 260 bytes Diff Download File
bugs.xml 821 4 years ago Teddy Hogeborn Add bug reporting information to manual pages * b 539 bytes Diff Download File
clients.conf 964 1 year ago Teddy Hogeborn Doc fix: Change some "/etc/mandos" to "/etc/keys/m 3.3 KB Diff Download File
common.ent 237.4.128 10 months ago teddy at recompile Version 1.8.10-1 * Makefile (version): Change to 94 bytes Diff Download File
COPYING 24.1.51 12 years ago Björn Påhlsson Added configuration files support for mandos-clien 34.2 KB Diff Download File
DBUS-API 1198 1 year ago teddy at recompile DBUS-API: Order properties alphabetically In the 5.9 KB Diff Download File
dbus-mandos.conf 24.1.186 9 years ago Björn Påhlsson transitional stuff actually working documented cha 820 bytes Diff Download File
default-mandos 185 12 years ago Teddy Hogeborn * .bzr-builddeb/default.conf: New. * Makefile (in 174 bytes Diff Download File
init.d-mandos 927 2 years ago Teddy Hogeborn Remove unnecessary text left from old example init 4.2 KB Diff Download File
initramfs-tools-conf 954 2 years ago Teddy Hogeborn Move UMASK setting to more proper place * Makefil 695 bytes Diff Download File
initramfs-tools-conf-hook 1099 1 year ago Teddy Hogeborn Installation: Fix UMASK even if set by some other 647 bytes Diff Download File
File initramfs-tools-hook 1208 11 months ago teddy at recompile initramfs-tools-hook: Properly quote argument to t 7.6 KB Diff Download File
File initramfs-tools-script 953 2 years ago Teddy Hogeborn Adapt to changes in cryptsetup; use "cryptroot-unl 4.5 KB Diff Download File
File initramfs-tools-script-stop 956 2 years ago Teddy Hogeborn Set executable permissions on new files * initram 1.8 KB Diff Download File
File initramfs-unpack 1127 1 year ago Teddy Hogeborn Add dracut(8) support Add support for the dracut( 2.7 KB Diff Download File
INSTALL 1186 1 year ago Teddy Hogeborn INSTALL: Add "-" argument to "su" invocations. 5.8 KB Diff Download File
intro.xml 1148 1 year ago Teddy Hogeborn Describe role of password-agent(8mandos) in intro( 17.9 KB Diff Download File
legalnotice.xml 907 3 years ago Teddy Hogeborn Alter copyright notices slightly. Actual license 1 KB Diff Download File
Makefile 237.4.128 10 months ago teddy at recompile Version 1.8.10-1 * Makefile (version): Change to 21.8 KB Diff Download File
File mandos 237.4.128 10 months ago teddy at recompile Version 1.8.10-1 * Makefile (version): Change to 144 KB Diff Download File
mandos-clients.conf.xml 969 1 year ago Teddy Hogeborn Update copyright year to 2019 * DBUS-API: Update 19.4 KB Diff Download File
File mandos-ctl 237.4.128 10 months ago teddy at recompile Version 1.8.10-1 * Makefile (version): Change to 107 KB Diff Download File
mandos-ctl.xml 1131 1 year ago Teddy Hogeborn Make tests and man page examples match Make the t 17.8 KB Diff Download File
File mandos-keygen 237.4.128 10 months ago teddy at recompile Version 1.8.10-1 * Makefile (version): Change to 12.6 KB Diff Download File
mandos-keygen.xml 1120 1 year ago Teddy Hogeborn Document bug in mandos-keygen which strips white s 16.8 KB Diff Download File
File mandos-monitor 237.4.128 10 months ago teddy at recompile Version 1.8.10-1 * Makefile (version): Change to 29.3 KB Diff Download File
mandos-monitor.xml 969 1 year ago Teddy Hogeborn Update copyright year to 2019 * DBUS-API: Update 6.3 KB Diff Download File
mandos-options.xml 1123 1 year ago Teddy Hogeborn Use hexadecimal unicode character references, not 5.1 KB Diff Download File
File mandos-to-cryptroot-unlock 1122 1 year ago Teddy Hogeborn Fix bashisms: Use "command -v" instead of "type" 2.5 KB Diff Download File
mandos.conf 777 5 years ago Teddy Hogeborn Bug fix for GnuTLS 3: be compatible with old 2048- 1.6 KB Diff Download File
mandos.conf.xml 1106 1 year ago Teddy Hogeborn Doc fix: Use new style interface names instead of 8.9 KB Diff Download File
mandos.lsm 237.4.128 10 months ago teddy at recompile Version 1.8.10-1 * Makefile (version): Change to 910 bytes Diff Download File
mandos.service 1203 11 months ago teddy at recompile Allow users to more easily alter mandos.service T 1.2 KB Diff Download File
mandos.xml 1121 1 year ago Teddy Hogeborn Change URL for Avahi to use HTTPS * INSTALL (Prer 24.1 KB Diff Download File
NEWS 237.4.128 10 months ago teddy at recompile Version 1.8.10-1 * Makefile (version): Change to 20.9 KB Diff Download File
overview.xml 962 1 year ago Teddy Hogeborn Add support for using raw public keys in TLS (RFC 923 bytes Diff Download File
plugin-runner.c 1205 11 months ago teddy at recompile Use reallocarray() if available, or check for over 35.5 KB Diff Download File
plugin-runner.conf 342 11 years ago Teddy Hogeborn * initramfs-tools-hook: Bug fix: Add "--userid" an 380 bytes Diff Download File
plugin-runner.xml 1124 1 year ago Teddy Hogeborn Allow line breaks on long lines in plugin-runner m 22.6 KB Diff Download File
README 844 4 years ago Teddy Hogeborn Use HTTPS in home page links Since we have a real 410 bytes Diff Download File
sysusers.d-mandos.conf 1160 1 year ago Teddy Hogeborn Client: Use the systemd sysusers.d mechanism, if p 167 bytes Diff Download File
tmpfiles.d-mandos.conf 838 4 years ago Teddy Hogeborn Server: New tmpfiles.d file for persistent state d 38 bytes Diff Download File
TODO 1206 11 months ago teddy at recompile Update formatting in TODO file * TODO: Add markup 4.9 KB Diff Download File