=== modified file 'plugin-runner.c' --- plugin-runner.c 2015-06-28 16:35:27 +0000 +++ plugin-runner.c 2015-07-20 00:06:05 +0000 @@ -827,7 +827,7 @@ } } } - TEMP_FAILURE_RETRY(close(plugindir_fd)); + close(plugindir_fd); } } @@ -925,7 +925,7 @@ ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st)); if(ret == -1){ error(0, errno, "stat"); - TEMP_FAILURE_RETRY(close(plugin_fd)); + close(plugin_fd); free(direntries[i]); continue; } @@ -940,7 +940,7 @@ plugindir != NULL ? plugindir : PDIR, direntries[i]->d_name); } - TEMP_FAILURE_RETRY(close(plugin_fd)); + close(plugin_fd); free(direntries[i]); continue; } @@ -948,7 +948,7 @@ plugin *p = getplugin(direntries[i]->d_name); if(p == NULL){ error(0, errno, "getplugin"); - TEMP_FAILURE_RETRY(close(plugin_fd)); + close(plugin_fd); free(direntries[i]); continue; } @@ -957,7 +957,7 @@ fprintf(stderr, "Ignoring disabled plugin \"%s\"\n", direntries[i]->d_name); } - TEMP_FAILURE_RETRY(close(plugin_fd)); + close(plugin_fd); free(direntries[i]); continue; } @@ -1003,8 +1003,8 @@ if(pipefd[0] >= FD_SETSIZE){ fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0], FD_SETSIZE); - TEMP_FAILURE_RETRY(close(pipefd[0])); - TEMP_FAILURE_RETRY(close(pipefd[1])); + close(pipefd[0]); + close(pipefd[1]); exitstatus = EX_OSERR; free(direntries[i]); goto fallback; @@ -1014,8 +1014,8 @@ ret = set_cloexec_flag(pipefd[0]); if(ret < 0){ error(0, errno, "set_cloexec_flag"); - TEMP_FAILURE_RETRY(close(pipefd[0])); - TEMP_FAILURE_RETRY(close(pipefd[1])); + close(pipefd[0]); + close(pipefd[1]); exitstatus = EX_OSERR; free(direntries[i]); goto fallback; @@ -1023,8 +1023,8 @@ ret = set_cloexec_flag(pipefd[1]); if(ret < 0){ error(0, errno, "set_cloexec_flag"); - TEMP_FAILURE_RETRY(close(pipefd[0])); - TEMP_FAILURE_RETRY(close(pipefd[1])); + close(pipefd[0]); + close(pipefd[1]); exitstatus = EX_OSERR; free(direntries[i]); goto fallback; @@ -1049,8 +1049,8 @@ error(0, errno, "fork"); TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL)); - TEMP_FAILURE_RETRY(close(pipefd[0])); - TEMP_FAILURE_RETRY(close(pipefd[1])); + close(pipefd[0]); + close(pipefd[1]); exitstatus = EX_OSERR; free(direntries[i]); goto fallback; @@ -1084,9 +1084,8 @@ /* no return */ } /* Parent process */ - TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of - pipe */ - TEMP_FAILURE_RETRY(close(plugin_fd)); + close(pipefd[1]); /* Close unused write end of pipe */ + close(plugin_fd); plugin *new_plugin = getplugin(direntries[i]->d_name); if(new_plugin == NULL){ error(0, errno, "getplugin"); @@ -1138,7 +1137,7 @@ free(direntries); direntries = NULL; - TEMP_FAILURE_RETRY(close(dir_fd)); + close(dir_fd); dir_fd = -1; free_plugin(getplugin(NULL)); @@ -1342,7 +1341,7 @@ free(direntries); if(dir_fd != -1){ - TEMP_FAILURE_RETRY(close(dir_fd)); + close(dir_fd); } /* Kill the processes */ === modified file 'plugins.d/mandos-client.c' --- plugins.d/mandos-client.c 2015-07-16 23:01:02 +0000 +++ plugins.d/mandos-client.c 2015-07-20 00:06:05 +0000 @@ -305,7 +305,7 @@ return false; } - ret = (int)TEMP_FAILURE_RETRY(close(fd)); + ret = close(fd); if(ret == -1){ perror_plus("close"); } @@ -931,7 +931,7 @@ perror_plus("dup2(devnull, STDIN_FILENO)"); _exit(EX_OSERR); } - ret = (int)TEMP_FAILURE_RETRY(close(devnull)); + ret = close(devnull); if(ret == -1){ perror_plus("close"); _exit(EX_OSERR); @@ -956,7 +956,7 @@ perror_plus("openat"); _exit(EX_UNAVAILABLE); } - TEMP_FAILURE_RETRY(close(helperdir_fd)); + close(helperdir_fd); #ifdef __GNUC__ #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wcast-qual" @@ -1466,7 +1466,7 @@ free(decrypted_buffer); free(buffer); if(tcp_sd >= 0){ - ret = (int)TEMP_FAILURE_RETRY(close(tcp_sd)); + ret = close(tcp_sd); } if(ret == -1){ if(e == 0){ @@ -2011,7 +2011,7 @@ perror_plus("openat"); _exit(EXIT_FAILURE); } - if((int)TEMP_FAILURE_RETRY(close(hookdir_fd)) == -1){ + if(close(hookdir_fd) == -1){ perror_plus("close"); _exit(EXIT_FAILURE); } @@ -2020,7 +2020,7 @@ perror_plus("dup2(devnull, STDIN_FILENO)"); _exit(EX_OSERR); } - ret = (int)TEMP_FAILURE_RETRY(close(devnull)); + ret = close(devnull); if(ret == -1){ perror_plus("close"); _exit(EX_OSERR); @@ -2075,7 +2075,7 @@ free(direntry); } free(direntries); - if((int)TEMP_FAILURE_RETRY(close(hookdir_fd)) == -1){ + if(close(hookdir_fd) == -1){ perror_plus("close"); } else { hookdir_fd = -1; @@ -2121,7 +2121,7 @@ } if(quit_now){ - ret = (int)TEMP_FAILURE_RETRY(close(sd)); + ret = close(sd); if(ret == -1){ perror_plus("close"); } @@ -2177,7 +2177,7 @@ } /* Close the socket */ - ret = (int)TEMP_FAILURE_RETRY(close(sd)); + ret = close(sd); if(ret == -1){ perror_plus("close"); } @@ -2265,7 +2265,7 @@ } /* Close the socket */ - int ret = (int)TEMP_FAILURE_RETRY(close(sd)); + int ret = close(sd); if(ret == -1){ perror_plus("close"); } @@ -2522,7 +2522,7 @@ } } } - TEMP_FAILURE_RETRY(close(seckey_fd)); + close(seckey_fd); } } @@ -2543,7 +2543,7 @@ } } } - TEMP_FAILURE_RETRY(close(pubkey_fd)); + close(pubkey_fd); } } @@ -2564,7 +2564,7 @@ } } } - TEMP_FAILURE_RETRY(close(dhparams_fd)); + close(dhparams_fd); } } @@ -3083,7 +3083,7 @@ perror_plus("rmdir"); } } - TEMP_FAILURE_RETRY(close(tempdir_fd)); + close(tempdir_fd); } } === modified file 'plugins.d/usplash.c' --- plugins.d/usplash.c 2014-03-29 02:38:15 +0000 +++ plugins.d/usplash.c 2015-07-20 00:06:05 +0000 @@ -117,7 +117,7 @@ ret = asprintf(&cmd_line_alloc, "%s %s", cmd, arg); if(ret == -1){ int e = errno; - TEMP_FAILURE_RETRY(close(*fifo_fd_r)); + close(*fifo_fd_r); errno = e; return false; } @@ -133,7 +133,7 @@ cmd_line_len - written); if(sret == -1){ int e = errno; - TEMP_FAILURE_RETRY(close(*fifo_fd_r)); + close(*fifo_fd_r); free(cmd_line_alloc); errno = e; return false; @@ -491,7 +491,7 @@ error_plus(0, errno, "read"); status = EX_OSERR; } - TEMP_FAILURE_RETRY(close(outfifo_fd)); + close(outfifo_fd); goto failure; } if(interrupted_by_signal){ @@ -578,7 +578,7 @@ /* Close FIFO */ if(fifo_fd != -1){ - ret = (int)TEMP_FAILURE_RETRY(close(fifo_fd)); + ret = close(fifo_fd); if(ret == -1 and errno != EINTR){ error_plus(0, errno, "close"); } @@ -587,7 +587,7 @@ /* Close output FIFO */ if(outfifo_fd != -1){ - ret = (int)TEMP_FAILURE_RETRY(close(outfifo_fd)); + ret = close(outfifo_fd); if(ret == -1){ error_plus(0, errno, "close"); } @@ -655,7 +655,7 @@ /* Close FIFO (again) */ if(fifo_fd != -1){ - ret = (int)TEMP_FAILURE_RETRY(close(fifo_fd)); + ret = close(fifo_fd); if(ret == -1 and errno != EINTR){ error_plus(0, errno, "close"); }