=== modified file 'TODO' --- TODO 2011-12-23 18:59:19 +0000 +++ TODO 2011-12-24 23:07:17 +0000 @@ -1,6 +1,8 @@ -*- org -*- * Use _attribute_((nonnull)) wherever possible. +* Use __attribute__((pure)) or __attribute__((const)) where possible. +* Use __attribute__((signal)) on signal handlers. * [[http://www.undeadly.org/cgi?action=article&sid=20110530221728][OpenBSD]] === modified file 'plugins.d/mandos-client.c' --- plugins.d/mandos-client.c 2011-12-24 19:43:26 +0000 +++ plugins.d/mandos-client.c 2011-12-24 23:07:17 +0000 @@ -175,6 +175,7 @@ perror(print_text); } +__attribute__((format (gnu_printf, 2, 3))) int fprintf_plus(FILE *stream, const char *format, ...){ va_list ap; va_start (ap, format); @@ -1470,8 +1471,10 @@ _exit(EX_OSERR); } free(delaystring); - ret = execl(fullname, direntry->d_name, mode, NULL); - perror_plus("execl"); + if(execl(fullname, direntry->d_name, mode, NULL) == -1){ + perror_plus("execl"); + _exit(EXIT_FAILURE); + } } else { int status; if(TEMP_FAILURE_RETRY(waitpid(hook_pid, &status, 0)) == -1){