=== modified file 'Makefile'
--- Makefile 2011-10-15 16:48:03 +0000
+++ Makefile 2011-10-22 00:46:35 +0000
@@ -260,12 +260,6 @@
# Run the server with a local config
run-server: confdir/mandos.conf confdir/clients.conf
- @echo "#################################################################"
- @echo "# NOTE: Please IGNORE the error about \"Could not open file #"
- @echo "# u'/var/run/mandos.pid'\" - it is harmless and is caused by #"
- @echo "# the server not running as root. Do NOT run \"make run-server\" #"
- @echo "# server as root if you didn't also unpack and compile it thus. #"
- @echo "#################################################################"
./mandos --debug --no-dbus --configdir=confdir $(SERVERARGS)
# Used by run-server
=== modified file 'TODO'
--- TODO 2011-10-14 18:00:50 +0000
+++ TODO 2011-10-22 00:46:35 +0000
@@ -53,8 +53,6 @@
[[info:standards:Option%20Table][Table of Long Options]]
** TODO Implement --socket
[[info:standards:Option%20Table][Table of Long Options]]
-** TODO Date+time on console log messages :BUGS:
- Is this the default?
** TODO [#C] DBusServiceObjectUsingSuper
** TODO [#B] Global enable/disable flag
** TODO [#B] By-client countdown on secrets given
=== modified file 'mandos'
--- mandos 2011-10-15 16:48:03 +0000
+++ mandos 2011-10-22 00:46:35 +0000
@@ -85,8 +85,7 @@
version = "1.4.1"
-#logger = logging.getLogger('mandos')
-logger = logging.Logger('mandos')
+logger = logging.getLogger()
syslogger = (logging.handlers.SysLogHandler
(facility = logging.handlers.SysLogHandler.LOG_DAEMON,
address = str("/dev/log")))
@@ -96,11 +95,13 @@
logger.addHandler(syslogger)
console = logging.StreamHandler()
-console.setFormatter(logging.Formatter('%(name)s [%(process)d]:'
+console.setFormatter(logging.Formatter('%(asctime)s %(name)s'
+ ' [%(process)d]:'
' %(levelname)s:'
' %(message)s'))
logger.addHandler(console)
+
class AvahiError(Exception):
def __init__(self, value, *args, **kwargs):
self.value = value
@@ -164,10 +165,6 @@
.GetAlternativeServiceName(self.name))
logger.info("Changing Zeroconf service name to %r ...",
self.name)
- syslogger.setFormatter(logging.Formatter
- ('Mandos (%s) [%%(process)d]:'
- ' %%(levelname)s: %%(message)s'
- % self.name))
self.remove()
try:
self.add()
@@ -193,7 +190,7 @@
avahi.DBUS_INTERFACE_ENTRY_GROUP)
self.entry_group_state_changed_match = (
self.group.connect_to_signal(
- 'StateChanged', self .entry_group_state_changed))
+ 'StateChanged', self.entry_group_state_changed))
logger.debug("Adding Zeroconf service '%s' of type '%s' ...",
self.name, self.type)
self.group.AddService(
@@ -265,6 +262,15 @@
self.server_state_changed)
self.server_state_changed(self.server.GetState())
+class AvahiServiceToSyslog(AvahiService):
+ def rename(self):
+ """Add the new name to the syslog messages"""
+ ret = AvahiService.rename(self)
+ syslogger.setFormatter(logging.Formatter
+ ('Mandos (%s) [%%(process)d]:'
+ ' %%(levelname)s: %%(message)s'
+ % self.name))
+ return ret
def _timedelta_to_milliseconds(td):
"Convert a datetime.timedelta() to milliseconds"
@@ -1970,14 +1976,13 @@
raise error
if not debug and not debuglevel:
- syslogger.setLevel(logging.WARNING)
- console.setLevel(logging.WARNING)
+ logger.setLevel(logging.WARNING)
if debuglevel:
level = getattr(logging, debuglevel.upper())
- syslogger.setLevel(level)
- console.setLevel(level)
+ logger.setLevel(level)
if debug:
+ logger.setLevel(logging.DEBUG)
# Enable all possible GnuTLS debugging
# "Use a log level over 10 to enable all debugging options."
@@ -2024,9 +2029,10 @@
server_settings["use_dbus"] = False
tcp_server.use_dbus = False
protocol = avahi.PROTO_INET6 if use_ipv6 else avahi.PROTO_INET
- service = AvahiService(name = server_settings["servicename"],
- servicetype = "_mandos._tcp",
- protocol = protocol, bus = bus)
+ service = AvahiServiceToSyslog(name =
+ server_settings["servicename"],
+ servicetype = "_mandos._tcp",
+ protocol = protocol, bus = bus)
if server_settings["interface"]:
service.interface = (if_nametoindex
(str(server_settings["interface"])))
=== modified file 'mandos.xml'
--- mandos.xml 2011-10-05 16:00:56 +0000
+++ mandos.xml 2011-10-22 00:46:35 +0000
@@ -2,7 +2,7 @@
-
+
%common;
]>
@@ -509,9 +509,6 @@
Debug mode is conflated with running in the foreground.
- The console log messages do not show a time stamp.
-
-
This server does not check the expire time of clients’ OpenPGP
keys.