=== modified file 'TODO' --- TODO 2010-09-26 18:32:58 +0000 +++ TODO 2010-11-16 17:58:49 +0000 @@ -2,6 +2,8 @@ * Use _attribute_((nonnull)) wherever possible. +* mandos-applet + * mandos-client ** TODO [#B] use scandir(3) instead of readdir(3) ** TODO [#B] Prefix all debug output with "Mandos plugin " + program_invocation_short_name === modified file 'plugins.d/plymouth.c' --- plugins.d/plymouth.c 2010-09-26 18:32:58 +0000 +++ plugins.d/plymouth.c 2010-11-16 17:58:49 +0000 @@ -1,6 +1,6 @@ /* -*- coding: utf-8 -*- */ /* - * Usplash - Read a password from usplash and output it + * Plymouth - Read a password from Plymouth and output it * * Copyright © 2010 Teddy Hogeborn * Copyright © 2010 Björn Påhlsson @@ -76,21 +76,23 @@ char *prompt; const char *const cryptsource = getenv("cryptsource"); const char *const crypttarget = getenv("crypttarget"); - const char prompt_start[] = "Enter passphrase to unlock the disk"; + const char prompt_start[] = "Unlocking the disk"; + const char prompt_end[] = "Enter passphrase"; if(cryptsource == NULL){ if(crypttarget == NULL){ - ret = asprintf(&prompt, "%s: ", prompt_start); + ret = asprintf(&prompt, "%s\n%s", prompt_start, prompt_end); } else { - ret = asprintf(&prompt, "%s (%s): ", prompt_start, - crypttarget); + ret = asprintf(&prompt, "%s (%s)\n%s", prompt_start, + crypttarget, prompt_end); } } else { if(crypttarget == NULL){ - ret = asprintf(&prompt, "%s %s: ", prompt_start, cryptsource); + ret = asprintf(&prompt, "%s %s\n%s", prompt_start, cryptsource, + prompt_end); } else { - ret = asprintf(&prompt, "%s %s (%s): ", prompt_start, - cryptsource, crypttarget); + ret = asprintf(&prompt, "%s %s (%s)\n%s", prompt_start, + cryptsource, crypttarget, prompt_end); } } if(ret == -1){ @@ -142,21 +144,21 @@ _exit(EX_OSERR); } } - + char **new_argv = NULL; - char *tmp; + char **tmp; int i = 0; - for (; argv[i]!=(char *)NULL; i++){ + for (; argv[i]!=NULL; i++){ tmp = realloc(new_argv, sizeof(const char *) * ((size_t)i + 1)); if (tmp == NULL){ error(0, errno, "realloc"); free(new_argv); _exit(EX_OSERR); } - new_argv = (char **)tmp; + new_argv = tmp; new_argv[i] = strdup(argv[i]); } - new_argv[i] = (char *) NULL; + new_argv[i] = NULL; execv(path, (char *const *)new_argv); error(0, errno, "execv");