/mandos/trunk : changes

» Changes to plugbasedclient.c from revision 1298

To get this branch, use:

bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk

From Revision 1298 to 1279

expand all

Rev	Summary	Authors	Date
1298	Eliminate compiler warnings Eliminate compiler warnings Many programs use nested functions, which now result in a linker warning about executable stack. Hide this warning. Also, rewrite a loop in the plymouth plugin to avoid warning about signed overflow. This change also makes the plugin pick the alphabetically first process entry instead of the last, in case many plymouth processes are found (which should be unlikely). * Makefile (plugin-runner, dracut-module/password-agent, plugins.d/password-prompt, plugins.d/mandos-client, plugins.d/plymouth): New target; set LDFLAGS to add "-Xlinker --no-warn-execstack". * plugins.d/plymouth.c (get_pid): When no pid files are found, and we are looking through the process list, go though it from the start instead of from the end, i.e. in normal alphabetical order and not in reverse order.	Teddy Hogeborn	1 hour ago
1297	Acknowledge NMUs in debian/changelog Acknowledge NMUs in debian/changelog * debian/changelog (1.8.16-1.1, 1.8.16-1.2): New entries.	Teddy Hogeborn	3 hours ago
1296	Update Debian Policy version to 4.7.0; no other changes nece... Update Debian Policy version to 4.7.0; no other changes necessary. * debian/control (Standards-Version): Change to "4.7.0".	Teddy Hogeborn	3 hours ago
1295	Change to new lintian override syntax Change to new lintian override syntax Lintian has changed its output for warnings, and as a result, its syntax for overriding those warnings has also changed. (See Debian bug #1007002 for further information.) Therefore, change the syntax in the lintian override files. * debian/mandos-client.lintian-overrides: Change to new lintian "pointed hints" syntax. * debian/mandos.lintian-overrides: - '' -	Teddy Hogeborn	3 hours ago
1294	Make all required directories when installing Make all required directories when installing When installing into a normal system, one can assume that target directories, such as /usr/bin, already exists. But when installing into a subdirectory for the purpose of creating a package, one cannot assume that all directories already exist. Therefore, when installing, we must not check if any directories exist, and must instead always create any directories we want to install into. * Makefile (confdir/mandos.conf, confdir/clients.conf, install-html): Use the "-D" option to "install" instead of creating the directory separately. (install-server): Move creation of $(CONFDIR) down to before it is needed. Don't check if the $(TMPFILES) or $(SYSUSERS) directories exist; instead create them by using the "-D" option to "install". Create the $(PREFIX)/sbin directory. Always use "--target-directory" if possible; i.e. if the file name is the same. Create the $(DBUSPOLICYDIR) and $(DESTDIR)/etc/init.d directories by using the "-D" option to "install". Don't check if the $(SYSTEMD) directory exists; instead create it by using the "-D" option to "install". Create the $(DESTDIR)/etc/default and $(MANDIR)/man8 directories by using the "-D" option to "install". Create the $(MANDIR)/man5 directories explicitly. (install-client-nokey): Remove unnecessary creation of the $(CONFDIR) directory. Don't check if the $(SYSUSERS) directory exists; instead create it by using the "-D" option to "install". Move the "--directory" argument to be the first argument, for clarity. Create the $(PREFIX)/sbin directory. Use the "-D" argument to "install" when installing $(INITRAMFSTOOLS)/hooks/mandos, $(INITRAMFSTOOLS)/conf.d/mandos-conf, $(INITRAMFSTOOLS)/conf-hooks.d/zz-mandos, $(INITRAMFSTOOLS)/scripts/init-premount/mandos, $(INITRAMFSTOOLS)/scripts/local-premount/mandos, $(DRACUTMODULE)/ask-password-mandos.path, and $(DRACUTMODULE)/dracut-module/ask-password-mandos.service. Create the $(MANDIR)/man8 directory. Reported-By: Erich Eckner <erich@eckner.net> Thanks: Erich Eckner <erich@eckner.net> for analysis	Teddy Hogeborn	4 hours ago
1293	Fix minor deprecated syntax issue in debian/control Fix minor deprecated syntax issue in debian/control The << syntax should be preferred to the deprecated < notation. * debian/control (Source: mandos/Build-Depends): Change from having "systemd (< 256~rc2-1)" to "systemd (<< 256~rc2-1)".	Teddy Hogeborn	12 hours ago
1292	Do not hardcode directory names; get them from pkg-config Do not hardcode directory names; get them from pkg-config Similarly to the directory for systemd unit files (output of "pkg-config systemd --variable=systemdsystemunitdir"), the values of the "tmpfilesdir" and "sysusersdir" variables should not be hardcoded in debian/mandos.dirs and debian/mandos-client.dirs. Fix this the same way as with systemdsystemunitdir; i.e. remove the directories from the .dirs files, and instead create the directories in override rules in debian/rules. * debian/mandos-client.dirs (usr/lib/sysusers.d): Removed. * debian/mandos.dirs (usr/lib/tmpfiles.d, usr/lib/sysusers.d): Removed. * debian/rules (override_dh_installdirs-indep): Also create directories for the "tmpfilesdir" and "sysusersdir" variables from pkg-config. (override_dh_installdirs-arch): New; create directory for the "sysusersdir" variable from pkg-config.	Teddy Hogeborn	13 hours ago
1291	Require correct version of systemd-dev or systemd Require correct version of systemd-dev or systemd The systemd.pc file (for use by pkg-config) was moved from the systemd package to the systemd-dev package in version 256~rc2-1. Therefore, require either systemd-dev or a version of systemd before that version, in order to be guaranteed the presence of the systemd.pc file. * debian/control (Source: mandos/Build-Depends): Add version qualifier "(< 256~rc2-1)" to "systemd".	Teddy Hogeborn	22 hours ago
1290	Minor fix for manual Makefile uninstallations Minor fix for manual Makefile uninstallations If the Mandos systemd unit file was not installed, it was still removed by the "purge-server" target. If systemd is not installed, this could mean removal of "mandos.service" from the root directory. (Note: this was not used by the Debian package as a method of uninstallation; this was only ever done by the Makefile if "make purge-server" was called by hand. And a "mandos.service" file was presumably also unlikely to exist in the root directory.) * Makefile (purge-server): Only remove systemd service file "mandos.service" if the same conditions exist which permitted its initial installation in the "install-server" target.	Teddy Hogeborn	23 hours ago
1289	Fix #1069689 by using pkg-config in debian/rules Fix #1069689 by using pkg-config in debian/rules The directory for systemd unit files (output of "pkg-config systemd --variable=systemdsystemunitdir") has changed. But there was a hardcoded instance of this directory in debian/mandos.dirs. Fix this by removing the directory from debian/mandos.dirs, and instead creating the correct directory explicitly in debian/rules. * debian/mandos.dirs (lib/systemd/system): Removed. * debian/rules (PKG_CONFIG): New; copied from Makefile. (override_dh_installdirs-indep): New; run dh_installdirs twice: first normally, and again for the systemd unit file directory. Closes: #1069689 Reported-By: Helmut Grohne <helmut@subdivi.de> Thanks: Helmut Grohne <helmut@subdivi.de> for report and analysis	Teddy Hogeborn	23 hours ago
1288	Fix #1079588 by not outputting to stdout in maintainer scrip... Fix #1079588 by not outputting to stdout in maintainer scripts From The Debconf Programmer's Tutorial: "Anything your maintainer scripts output to standard output is passed into the frontend as a command". We must make sure to redirect stdout to stderr for every command in the postinst and postrm scripts which might output to stdout. * debian/mandos-client.postinst (update_initramfs): Add "1>&2" to invocations of update-initramfs and /etc/kernel/postinst.d/dracut. (add_mandos_user): Add "1>&2" to invocations of usermod, groupmod, and adduser. (create_keys): Add "1>&2" to invocations of mandos-keygen, gpg-connect-agent, certtool, and openssl. (create_dh_params): Add "1>&2" to invocations of certtool and openssl. Add "--force" option to "rm". * debian/mandos-client.postrm (update_initramfs): Add "1>&2" to invocations of update-initramfs and /etc/kernel/postinst.d/dracut. Closes: #1079588 Reported-By: Ben Hutchings <ben@decadent.org.uk>	Teddy Hogeborn	1 day ago
1287	Use new package name "libgpgme11t64" when available Use new package name "libgpgme11t64" when available * initramfs-tools-hook (libgpgme11_version): Add "libgpgme11t64" as an alternative to libgpgme11. Closes: #1077927 Reported-By: Aaron D. Johnson <debbugreporter@fnord.greeley.co.us> Suggested-by: Aaron D. Johnson <debbugreporter@fnord.greeley.co.us> Closes-Bug: #2068014 Reported-By: Christian Rusa <christian@rusa.at> Suggested-by: Christian Rusa <christian@rusa.at>	Teddy Hogeborn	1 day ago
1286	Use new package name "libgnutls30t64" when available Use new package name "libgnutls30t64" when available * debian/control (Package: mandos/Depends): Add "libgnutls30t64" as an alternative to libgnutls30. Reported-By: Bastian Germann <Bastian.Germann@gmx.de> Suggested-by: Bastian Germann <Bastian.Germann@gmx.de>	Teddy Hogeborn	1 day ago
1285	Prefer the systemd-dev package as a build dependency Prefer the systemd-dev package as a build dependency When building, we only need the systemd.pc pkgconfig file, and systemd-dev is a new package which, if available, contains that file without bringing in the whole of systemd. So prefer using that package as a build dependency. * debian/control (Source: mandos/Build-Depends): Change "systemd" to "systemd-dev \| systemd". Closes: #1060546 Reported-By: Michael Biebl <biebl@debian.org>	Teddy Hogeborn	1 day ago
1284	Be more tolerant when a client is misconfigured in clients.c... Be more tolerant when a client is misconfigured in clients.conf * mandos (Client/config_parser): If a client config section in clients.conf lacks both a fingerprint= and a key_id= setting, show an error and skip that client instead of crashing.	Teddy Hogeborn	1 day ago
1283	Fix file permissions when installing a new kernel, with drac... Fix file permissions when installing a new kernel, with dracut * debian/mandos-client.postinst (update_initramfs): When using dracut, but the initramfs image file does not yet exist (due to the kernel package not having been configured), create a new empty file with the correct permissions, so that dracut will use the correct permissions when creating the initramfs image file.	Teddy Hogeborn	1 day ago
1282	Remove obsolete "gnupg2" dependency (Debian bug #1055402) Remove obsolete "gnupg2" dependency (Debian bug #1055402) * debian/control (Package: mandos/Depends): Remove "gnupg2 \|". Closes: #1055402 Reported-By: Andreas Metzler <ametzler@bebt.de>	Teddy Hogeborn	1 day ago
1281	Fix Y2038 Fix Y2038 * Makefile (CPPFLAGS): Add "-D_TIME_BITS=64".	Teddy Hogeborn	1 day ago
1280	Very minor security improvement when uninstalling package Very minor security improvement when uninstalling package * debian/mandos-client.postrm: Also shred(1) tls-privkkey.pem.	Teddy Hogeborn	1 day ago
1279	Document how to add options to mandos-client when using drac... Document how to add options to mandos-client when using dracut * debian/mandos-client.README.Debian: Remove unnecessary word "simply". Also add instructions on how to add the --connect= options to mandos-client when using dracut. * dracut-module/ask-password-mandos.service ([Service]): Add comments that this file should not be modified, and explicit instructions on how to instead add extra options, like --debug, to mandos-client: using a systemd override unit file to set an environment variable.	Teddy Hogeborn	1 day ago

Older »