/mandos/trunk : changes

» Changes from revision 1291

To get this branch, use:

bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk

From Revision 799 to 780

expand all

Rev	Summary	Authors	Date
799	mandos: Remove unused import and an errant space character. mandos: Remove unused import and an errant space character.	Teddy Hogeborn	9 years ago
798	plugins.d/mandos-client.c (get_flags): Use strncpy(), not st... plugins.d/mandos-client.c (get_flags): Use strncpy(), not strcpy(). * plugins.d/mandos-client.c (get_flags): Use strncpy() instead of strcpy(). Note that as the code works currently, this is never a problem in practice, since only interface names which were valid existing interface names (and therefore had names with lengths below IF_NAMESIZE) is ever passed to the get_flags() function. But it doesn't hurt to check, anyway.	Teddy Hogeborn	9 years ago
797	plugin-runner.c: Use size_t to realloc() for custom plugin a... plugin-runner.c: Use size_t to realloc() for custom plugin args. * plugin-runner.c (main): Cast argument to realloc() to size_t when allocating additional custom plugin command line arguments.	Teddy Hogeborn	9 years ago
796	On cleanup, Signal ClientRemoved only if using D-Bus. On cleanup, Signal ClientRemoved only if using D-Bus. * mandos (main/cleanup): Bug fix: only send D-Bus signal ClientRemoved if actually using D-Bus.	Teddy Hogeborn	9 years ago
795	* mandos.xml (FILES): Removed duplicate entry for “/dev/log”... * mandos.xml (FILES): Removed duplicate entry for “/dev/log”.	Teddy Hogeborn	9 years ago
794	Merge from release branch. Merge from release branch.	Teddy Hogeborn	9 years ago
793	* debian/rules (override_dh_fixperms): Split into * debian/rules (override_dh_fixperms): Split into "override_dh_fixperms-arch" and "override_dh_fixperms-indep". Fixes Debian bug #806073.	Teddy Hogeborn	9 years ago
792	* debian/control (Package: mandos/Depends): Removed "initscr... * debian/control (Package: mandos/Depends): Removed "initscripts"; fixes Debian bug #804967.	Teddy Hogeborn	9 years ago
791	Merge from release branch. Merge from release branch.	Teddy Hogeborn	10 years ago
790	Bug fix: Add local route also when host is unreachable. Bug fix: Add local route also when host is unreachable. * plugins.d/mandos-client.c (start_mandos_communication): Bug fix: Check for EHOSTUNREACH in addition to ENETUNREACH.	Teddy Hogeborn	10 years ago
789	* initramfs-tools-hook: Don't try to chmod symlinks. * initramfs-tools-hook: Don't try to chmod symlinks.	Teddy Hogeborn	10 years ago
788	Merge from release branch. Merge from release branch.	Teddy Hogeborn	10 years ago
787	Depend on Avahi and the network in the server's systemd serv... Depend on Avahi and the network in the server's systemd service file. * mandos.service ([Unit]/After): New; set to "network.target" and "avahi-daemon.service". ([Unit]/RequisiteOverridable): New; set to "avahi-daemon.service".	Teddy Hogeborn	10 years ago
786	Server Bug fix: Make D-Bus introspection work again. Server Bug fix: Make D-Bus introspection work again. * mandos (DBusObjectWithObjectManager.Introspect): Bug fix; call method Introspect, not class DBusObjectWithAnnotations. (alternate_dbus_interfaces/wrapper/fixscope): Make wrapped D-Bus signal function look like a D-Bus signal so Introspect can see it.	Teddy Hogeborn	10 years ago
785	Support the standard org.freedesktop.DBus.ObjectManager inte... Support the standard org.freedesktop.DBus.ObjectManager interface. Now that the D-Bus standard has an interface to keep track of new and removed objects, use that instead of our own methods. This deprecates our D-Bus methods "GetAllClients" and "GetAllClientsWithProperties" and the signals "ClientAdded" and "ClientRemoved", all on the server interface "se.recompile.Mandos". * DBUS-API: Removed references to deprecated methods and signals; insert reference to the org.freedesktop.DBus.ObjectManager interface. * mandos (DBusObjectWithProperties._get_all_interface_names): New. (dbus.OBJECT_MANAGER_IFACE): If not present, monkey patch. (DBusObjectWithObjectManager): New. (main/MandosDBusService): Inherit from DBusObjectWithObjectManager. (main/MandosDBusService.ClientRemoved): Annotate as deprecated. (main/MandosDBusService.GetAllClients): - '' - (main/MandosDBusService.GetAllClientsWithProperties): Annotate as deprecated. Also only return properties on client interface. (main/MandosDBusService.RemoveClient): Call client_removed_signal instead of ClientRemoved. (main/MandosDBusService.GetManagedObjects): New. (main/MandosDBusService.client_added_signal): New. (main/MandosDBusService.client_removed_signal): - '' - (main/cleanup): Call "client_removed_signal" instead of sending "ClientRemoved" signal directly. (main): Call "client_added_signal" instead of sending "ClientAdded" signal directly. * mandos-ctl: Use GetManagedObjects instead of GetAllClientsWithProperties. Also, show better error message in case of failure to connect to the D-Bus * mandos-monitor (MandosClientPropertyCache.properties_changed): Bug fix; only update properties on client interface. (UserInterface.find_and_remove_client): Change to accept arguments from InterfacesRemoved signal. Also, bug fix: working error message when removing unknown client. (UserInterface.add_new_client): Change to accept arguments from InterfacesRemoved signal. Pass properties to MandosClientWidget constructor. (UserInterface.run): Connect find_and_remove_client method to InterfacesRemoved signal and the add_new_client method to the InterfacesAdded signal.	Teddy Hogeborn	10 years ago
784	Refactor D-Bus annotation class out from D-Bus properties cl... Refactor D-Bus annotation class out from D-Bus properties class. * mandos (DBusObjectWithAnnotations): New; factored out D-Bus annotations code from DBusObjectWithProperties class. (DBusObjectWithProperties): Inherit from DBusObjectWithAnnotations. (main/MandosDBusService): - '' - (main/MandosDBusService._foo): Removed interface annotation for "o.f.D.Property.EmitsChangedSignal"; this object has no properties.	Teddy Hogeborn	10 years ago
783	Revert change to D-Bus API. Revert change to D-Bus API. The D-Bus API signal CheckerCompleted is documented to provide a wait(2) status value. Since the server switched to using subprocess to run checkers, it no longer has access to a wait(2) status value. A previous change to work around this made the D-Bus API incompatible. Revert this change by constructing a fake wait(2) status value; this keeps the D-Bus API stable. * DBUS-API (CheckerCompleted): Revert incompatible change. * mandos (ClientDBus.checker_callback): Construct fake wait(2) status. * mandos-monitor (MandosClientWidget.checker_completed): Revert to using original API with wait(2) condition value.	Teddy Hogeborn	10 years ago
782	Deprecate the D-Bus property "se.recompile.Mandos.Client.Obj... Deprecate the D-Bus property "se.recompile.Mandos.Client.ObjectPath". The D-Bus property "se.recompile.Mandos.Client.ObjectPath" is unnecessary - is not used by mandos-monitor or mandos-ctl, and I cannot see it being useful for anyone. * DBUS-API (se.recompile.Mandos.Client.ObjectPath): Remove; deprecated. * mandos (ClientDBus.ObjectPath_dbus_property): Annotate as deprecated.	Teddy Hogeborn	10 years ago
781	Deprecate some D-Bus methods in favor of D-Bus properties. Deprecate some D-Bus methods in favor of D-Bus properties. The following D-Bus methods on the interface "se.recompile.Mandos.Client" are redundant, and are therefore deprecated: "Disable", "Enable", "StartChecker", and "StopChecker". Instead, the D-Bus properties "Enabled" and "CheckerRunning" should be set, as was always also possible. * DBUS-API (se.recompile.Mandos.Client.Disable): Remove; deprecated. (se.recompile.Mandos.Client.Enable): - '' - (se.recompile.Mandos.Client.StartChecker): - '' - (se.recompile.Mandos.Client.StopChecker): - '' - * mandos (ClientDBus.Enable): Annotate as deprecated. (ClientDBus.StartChecker): - '' - (ClientDBus.Disable): - '' - (ClientDBus.StopChecker): - '' - * mandos-monitor (MandosClientWidget.keypress): Set properties instead of calling deprecated methods.	Teddy Hogeborn	10 years ago
780	Add D-Bus annotations on a few properties on the Client obje... Add D-Bus annotations on a few properties on the Client object. The D-Bus property "Secret" on the interface "se.recompile.Mandos.Client" should have the annotation "org.freedesktop.DBus.Property.EmitsChangedSignal" set to "invalidates". Also, the properties "Created", "Fingerprint", "Name", and "ObjectPath" should have the same annotation set to "const". * mandos (ClientDBus.Name_dbus_property): Set annotation "org.freedesktop.DBus.Property.EmitsChangedSignal" to "const". (ClientDBus.Fingerprint_dbus_property): - '' - (ClientDBus.Created_dbus_property): - '' - (ClientDBus.ObjectPath_dbus_property): - '' - (ClientDBus.Secret_dbus_property): Set annotation "org.freedesktop.DBus.Property.EmitsChangedSignal" to "invalidates".	Teddy Hogeborn	10 years ago