/mandos/trunk : changes

» Changes from revision 1190

To get this branch, use:

bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk

From Revision 786 to 767

expand all

Rev	Summary	Authors	Date
786	Server Bug fix: Make D-Bus introspection work again. Server Bug fix: Make D-Bus introspection work again. * mandos (DBusObjectWithObjectManager.Introspect): Bug fix; call method Introspect, not class DBusObjectWithAnnotations. (alternate_dbus_interfaces/wrapper/fixscope): Make wrapped D-Bus signal function look like a D-Bus signal so Introspect can see it.	Teddy Hogeborn	10 years ago
785	Support the standard org.freedesktop.DBus.ObjectManager inte... Support the standard org.freedesktop.DBus.ObjectManager interface. Now that the D-Bus standard has an interface to keep track of new and removed objects, use that instead of our own methods. This deprecates our D-Bus methods "GetAllClients" and "GetAllClientsWithProperties" and the signals "ClientAdded" and "ClientRemoved", all on the server interface "se.recompile.Mandos". * DBUS-API: Removed references to deprecated methods and signals; insert reference to the org.freedesktop.DBus.ObjectManager interface. * mandos (DBusObjectWithProperties._get_all_interface_names): New. (dbus.OBJECT_MANAGER_IFACE): If not present, monkey patch. (DBusObjectWithObjectManager): New. (main/MandosDBusService): Inherit from DBusObjectWithObjectManager. (main/MandosDBusService.ClientRemoved): Annotate as deprecated. (main/MandosDBusService.GetAllClients): - '' - (main/MandosDBusService.GetAllClientsWithProperties): Annotate as deprecated. Also only return properties on client interface. (main/MandosDBusService.RemoveClient): Call client_removed_signal instead of ClientRemoved. (main/MandosDBusService.GetManagedObjects): New. (main/MandosDBusService.client_added_signal): New. (main/MandosDBusService.client_removed_signal): - '' - (main/cleanup): Call "client_removed_signal" instead of sending "ClientRemoved" signal directly. (main): Call "client_added_signal" instead of sending "ClientAdded" signal directly. * mandos-ctl: Use GetManagedObjects instead of GetAllClientsWithProperties. Also, show better error message in case of failure to connect to the D-Bus * mandos-monitor (MandosClientPropertyCache.properties_changed): Bug fix; only update properties on client interface. (UserInterface.find_and_remove_client): Change to accept arguments from InterfacesRemoved signal. Also, bug fix: working error message when removing unknown client. (UserInterface.add_new_client): Change to accept arguments from InterfacesRemoved signal. Pass properties to MandosClientWidget constructor. (UserInterface.run): Connect find_and_remove_client method to InterfacesRemoved signal and the add_new_client method to the InterfacesAdded signal.	Teddy Hogeborn	10 years ago
784	Refactor D-Bus annotation class out from D-Bus properties cl... Refactor D-Bus annotation class out from D-Bus properties class. * mandos (DBusObjectWithAnnotations): New; factored out D-Bus annotations code from DBusObjectWithProperties class. (DBusObjectWithProperties): Inherit from DBusObjectWithAnnotations. (main/MandosDBusService): - '' - (main/MandosDBusService._foo): Removed interface annotation for "o.f.D.Property.EmitsChangedSignal"; this object has no properties.	Teddy Hogeborn	10 years ago
783	Revert change to D-Bus API. Revert change to D-Bus API. The D-Bus API signal CheckerCompleted is documented to provide a wait(2) status value. Since the server switched to using subprocess to run checkers, it no longer has access to a wait(2) status value. A previous change to work around this made the D-Bus API incompatible. Revert this change by constructing a fake wait(2) status value; this keeps the D-Bus API stable. * DBUS-API (CheckerCompleted): Revert incompatible change. * mandos (ClientDBus.checker_callback): Construct fake wait(2) status. * mandos-monitor (MandosClientWidget.checker_completed): Revert to using original API with wait(2) condition value.	Teddy Hogeborn	10 years ago
782	Deprecate the D-Bus property "se.recompile.Mandos.Client.Obj... Deprecate the D-Bus property "se.recompile.Mandos.Client.ObjectPath". The D-Bus property "se.recompile.Mandos.Client.ObjectPath" is unnecessary - is not used by mandos-monitor or mandos-ctl, and I cannot see it being useful for anyone. * DBUS-API (se.recompile.Mandos.Client.ObjectPath): Remove; deprecated. * mandos (ClientDBus.ObjectPath_dbus_property): Annotate as deprecated.	Teddy Hogeborn	10 years ago
781	Deprecate some D-Bus methods in favor of D-Bus properties. Deprecate some D-Bus methods in favor of D-Bus properties. The following D-Bus methods on the interface "se.recompile.Mandos.Client" are redundant, and are therefore deprecated: "Disable", "Enable", "StartChecker", and "StopChecker". Instead, the D-Bus properties "Enabled" and "CheckerRunning" should be set, as was always also possible. * DBUS-API (se.recompile.Mandos.Client.Disable): Remove; deprecated. (se.recompile.Mandos.Client.Enable): - '' - (se.recompile.Mandos.Client.StartChecker): - '' - (se.recompile.Mandos.Client.StopChecker): - '' - * mandos (ClientDBus.Enable): Annotate as deprecated. (ClientDBus.StartChecker): - '' - (ClientDBus.Disable): - '' - (ClientDBus.StopChecker): - '' - * mandos-monitor (MandosClientWidget.keypress): Set properties instead of calling deprecated methods.	Teddy Hogeborn	10 years ago
780	Add D-Bus annotations on a few properties on the Client obje... Add D-Bus annotations on a few properties on the Client object. The D-Bus property "Secret" on the interface "se.recompile.Mandos.Client" should have the annotation "org.freedesktop.DBus.Property.EmitsChangedSignal" set to "invalidates". Also, the properties "Created", "Fingerprint", "Name", and "ObjectPath" should have the same annotation set to "const". * mandos (ClientDBus.Name_dbus_property): Set annotation "org.freedesktop.DBus.Property.EmitsChangedSignal" to "const". (ClientDBus.Fingerprint_dbus_property): - '' - (ClientDBus.Created_dbus_property): - '' - (ClientDBus.ObjectPath_dbus_property): - '' - (ClientDBus.Secret_dbus_property): Set annotation "org.freedesktop.DBus.Property.EmitsChangedSignal" to "invalidates".	Teddy Hogeborn	10 years ago
779	Debian bug fix for mandos-client: Remove dhparams.pem on pur... Debian bug fix for mandos-client: Remove dhparams.pem on purge. * debian/mandos-client.postrm (purge): Bug fix: Remove dhparams.pem.	Teddy Hogeborn	10 years ago
778	Update copyright year. Update copyright year. * debian/copyright (Copyright): Update copyright year. * intro.xml (COPYRIGHT): - '' - * mandos-clients.conf.xml (COPYRIGHT): - '' - * mandos-ctl.xml (COPYRIGHT): - '' - * mandos-keygen.xml (COPYRIGHT): - '' - * mandos-monitor.xml (COPYRIGHT): - '' - * mandos.conf.xml (COPYRIGHT): - '' - * mandos.xml (COPYRIGHT): - '' - * plugin-runner.c: - '' - * plugin-runner.xml (COPYRIGHT): - '' - * plugins.d/askpass-fifo.c: - '' - * plugins.d/askpass-fifo.xml (COPYRIGHT): - '' - * plugins.d/mandos-client.xml (COPYRIGHT): - '' - * plugins.d/password-prompt.c: - '' - * plugins.d/password-prompt.xml (COPYRIGHT): - '' - * plugins.d/plymouth.c: - '' - * plugins.d/plymouth.xml (COPYRIGHT): - '' - * plugins.d/splashy.c: - '' - * plugins.d/splashy.xml (COPYRIGHT): - '' - * plugins.d/usplash.c: - '' - * plugins.d/usplash.xml (COPYRIGHT): - '' -	Teddy Hogeborn	10 years ago
777	Bug fix for GnuTLS 3: be compatible with old 2048-bit DSA ke... Bug fix for GnuTLS 3: be compatible with old 2048-bit DSA keys. The mandos-keygen program in Mandos version 1.6.0 and older generated 2048-bit DSA keys, and when GnuTLS uses these it has trouble connecting using the Mandos default priority string. This was previously fixed in Mandos 1.6.2, but the bug reappeared when using GnuTLS 3, so the default priority string has to change again; this time also the Mandos client has to change its default, so now the server and the client should use the same default priority string: SECURE256:!CTYPE-X.509:+CTYPE-OPENPGP:!RSA:+SIGN-DSA-SHA256 * mandos (main/server_defaults): Changed default priority string. * mandos-options.xml (/section/para[id="priority_compat"]): Removed. (/section/para[id="priority"]): Changed default priority string. * mandos.conf ([DEFAULT]/priority): - '' - * mandos.conf.xml (OPTIONS/priority): Refer to the id "priority" instead of "priority_compat". * mandos.xml (OPTIONS/--priority): - '' - * plugins.d/mandos-client.c (main): Changed default priority string.	Teddy Hogeborn	10 years ago
776	mandos-client: Bug fix: don't crash if --dh-params was not u... mandos-client: Bug fix: don't crash if --dh-params was not used. * plugins.d/mandos-client.c (main): Bug fix: Check if dh_params_file is NULL before using it in the workaround for Debian bug #633582.	Teddy Hogeborn	10 years ago
775	plugin-runner: Minor fix: close helperdir before exiting in ... plugin-runner: Minor fix: close helperdir before exiting in fork. * plugin-runner.c: Minor fix: close helperdir before exiting in fork if helper program could not be opened.	Teddy Hogeborn	10 years ago
774	Don't use TEMP_FAILURE_RETRY around close(). Don't use TEMP_FAILURE_RETRY around close(). * plugin-runner.c: Don't use TEMP_FAILURE_RETRY around close(). * plugins.d/mandos-client.c: - '' - * plugins.d/usplash.c: - '' -	Teddy Hogeborn	10 years ago
773	mandos-client: Don't use memset(). mandos-client: Don't use memset(). * plugins.d/mandos-client.c (start_mandos_communication): Use compound literal struct assignment instead of memset().	Teddy Hogeborn	10 years ago
772	Assume the C11 language (ISO 9899:2011), when compiling C co... Assume the C11 language (ISO 9899:2011), when compiling C code. * Makefile (LANGUAGE): Changed to "-std=gnu11".	Teddy Hogeborn	10 years ago
771	Don't use absolute paths to commands in Debian configuration... Don't use absolute paths to commands in Debian configurations scripts. * debian/mandos-client.postinst: Don't use absolute paths to commands. * debian/mandos-client.postrm: - '' -	Teddy Hogeborn	10 years ago
770	* debian/mandos.prerm: Don't run init script, use only invok... * debian/mandos.prerm: Don't run init script, use only invoke-rc.d.	Teddy Hogeborn	10 years ago
769	Handle local Zeroconf service name collisions on startup, to... Handle local Zeroconf service name collisions on startup, too. * mandos (AvahiService.server_state_changed): Catch name collision error when adding server.	Teddy Hogeborn	10 years ago
768	debian/mandos-client.README.Debian: Document the dhparams.pe... debian/mandos-client.README.Debian: Document the dhparams.pem file.	Teddy Hogeborn	10 years ago
767	plugins.d/mandos-client.c (main): See why it failed to bring... plugins.d/mandos-client.c (main): See why it failed to bring up interface.	Teddy Hogeborn	10 years ago