/mandos/trunk : changes

» Changes from revision 1275

To get this branch, use:

bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk

From Revision 715 to 696

expand all

Rev	Summary	Authors	Date
715	mandos-client: Bug Fix: Fix some memory leaks. mandos-client: Bug Fix: Fix some memory leaks. * plugins.d/mandos-client.c (resolve_callback): Always free resolver. (run_network_hooks): Free the individual direntries. (main): When listing network interfaces and when removing the GPGME temp directory, free the individual direntries.	Teddy Hogeborn	10 years ago
714	mandos-client: Fix mem free bug. mandos-client: Fix mem free bug. * plugins.d/mandos-client.c (add_server): Hide warning. (main): Free server->ip too, not just the server struct.	Teddy Hogeborn	10 years ago
713	mandos-monitor: New "verbose" mode to see less important log... mandos-monitor: New "verbose" mode to see less important log messages. * mandos-monitor (MandosClientWidget.__init__): Log client creation. (MandosClientWidget.checker_completed): Log a successful checker. (MandosClientWidget.checker_started): Log starting of a checker. (UserInterface.__init__): New optional "log_level" argument. (UserInterface.log_message, UserInterface.log_message_raw): Take optional "level" arg. (UserInterface.toggle_log_display): Log visibility change. (UserInterface.change_log_display): Log wrap mode change. (UserInterface.process_input): Show new "v" key in help message and process "v" key if pressed. * mandos-monitor.xml (KEYS): Document new "v" key.	Teddy Hogeborn	10 years ago
712	mandos.lsm: Fix white space. mandos.lsm: Fix white space.	Teddy Hogeborn	10 years ago
711	Merge from release branch. Merge from release branch.	Teddy Hogeborn	10 years ago
710	mandos-client: Fix minor memory leak on memory full or clock... mandos-client: Fix minor memory leak on memory full or clock failure. * plugins.d/mandos-client.c (add_server): On any errors, free new_server and its contents before returning.	Teddy Hogeborn	10 years ago
709	mandos: The Debian package should prefer "ssh-client" over "... mandos: The Debian package should prefer "ssh-client" over "fping". * debian/control (mandos/Recommends): List "ssh-client" before "fping".	Teddy Hogeborn	10 years ago
708	mandos-keygen: Generate "checker" option to use SSH fingerpr... mandos-keygen: Generate "checker" option to use SSH fingerprints. To turn this off, use a new "--no-ssh" option to mandos-keygen. * INSTALL (Mandos Server, Mandos Client): Document new suggested installation of SSH. * Makefile (confdir/clients.conf): Use new "--no-ssh" option to "mandos-keygen". * debian/control (mandos/Depends): Changed to "fping \| ssh-client". (mandos-client/Recommends): New; set to "ssh". * intro.xml (FREQUENTLY ASKED QUESTIONS): Rename and rewrite section called "Faking ping replies?" to address new default behavior. * mandos-clients.conf.xml (OPTIONS/checker): Briefly discuss new behavior of mandos-keygen. * mandos-keygen: Bug fix: Suppress failure output of "shred" to remove "sec", since no such files may exist. (password mode): Scan for SSH key fingerprints and output as new "checker" and "ssh_fingerprint" options, unless new "--no-ssh" option is given. mandos-keygen.xml (SYNOPSIS/--force): Bug fix: Document short form. (OPTIONS/--no-ssh): New. (SEE ALSO): Add reference "ssh-keyscan(1)". * plugins.d/mandos-client.xml (SECURITY): Briefly mention the possibility of using SSH key fingerprints for checking.	Teddy Hogeborn	10 years ago
707	mandos: New "--no-zeroconf" option. Also make "--socket=0" ... mandos: New "--no-zeroconf" option. Also make "--socket=0" work. * mandos (main): New "--no-zeroconf" option. Also do not interpret socket=0 as no socket. * mandos-options.xml (zeroconf): New. * mandos.conf (socket, zeroconf): New. * mandos.xml (SYNOPSIS, OPTIONS): Added "--no-zeroconf".	Teddy Hogeborn	10 years ago
706	mandos-client: Better error messages. mandos-client: Better error messages. * Makefile (run-client): Update message to match current messages. Also set GNOME_KEYRING_CONTROL to empty string to block pam_gnome_keyring. * plugins.d/mandos-client (raise_privileges): Do not print errors. (raise_privileges_permanently): - '' - (lower_privileges): - '' - (lower_privileges_permanently): - '' - (run_network_hooks): Print errors from above functions correctly. (bring_up_interface, take_down_interface, main): - '' -	Teddy Hogeborn	10 years ago
705	plugin-runner: Release memory and close FD's correctly in al... plugin-runner: Release memory and close FD's correctly in all cases. * plugins.d/mandos-client.c (main): Init "direntries" to NULL. Close "dir_fd" at fallback label. Do not free "direntries" if scandirat() or scandir() failed. Do free(direntries) at fallback label.	Teddy Hogeborn	10 years ago
704	mandos-client: Fix some bugs on error conditions. mandos-client: Fix some bugs on error conditions. * plugins.d/mandos-client.c (run_network_hooks): Init "dirent" to NULL and, later, always free() it unless scandirat() or scandir() failed. (main): Fix free() of uninitalized memory in case scandirat() or scandir() of "/sys/class/net" failed. Also, when cleaning up, even if GPGME temp directory is empty, do free(direntries) and remove the directory.	Teddy Hogeborn	10 years ago
703	In plugin-runner, do scandirat() or scandir() instead of rea... In plugin-runner, do scandirat() or scandir() instead of readdir(). * plugin-runner.c (set_cloexec_flag): Only define if O_CLOEXEC is not defined, it is not called otherwise. (main): Remove variables "dir" and "dirst"; new variable "dir_fd". Use scandirat() if available, scandir() otherwise, both using new filter function "good_name". Removed checking of plugin file name patterns; this is now done by "good_name". Do not set FD_CLOEXEC flag on plugin_fd, since fexecve() will not work with it. Use pipe2() to set O_CLOEXEC on pipe FD's (if possible). (main/good_name): New filter function for scandirat() or scandir().	Teddy Hogeborn	10 years ago
702	In plugin-runner, protect against a larger FD_SETSIZE than f... In plugin-runner, protect against a larger FD_SETSIZE than fd_set. * plugin-runner.c (main): Before forking, check that the first FD from pipe() does not exceed FD_SETSIZE.	Teddy Hogeborn	10 years ago
701	plugin-runner: Restore resources correctly if fork() fails. plugin-runner: Restore resources correctly if fork() fails. * plugin-runner.c (main): If fork() fails, close pipe FD's and restore signal mask for SIGCHLD.	Teddy Hogeborn	10 years ago
700	plugin-runner: Do not leak file descriptors on certain error... plugin-runner: Do not leak file descriptors on certain errors. * plugin-runner.c (main): If set_cloexec_flag fails, close pipe FD's.	Teddy Hogeborn	10 years ago
699	Fix free() of possibly uninitialized pointer in mandos-clien... Fix free() of possibly uninitialized pointer in mandos-client. * plugins.d/mandos-client (main): Initialize "direntries" to NULL so it can be free()'d even if scandir() fails.	Teddy Hogeborn	10 years ago
698	Fix mandos server "--servicename" option, broken since 1.6.4... Fix mandos server "--servicename" option, broken since 1.6.4. * mandos (initlogger): Make "syslogger" a global variable again.	Teddy Hogeborn	10 years ago
697	Address a very theoretical possible security issue in mandos... Address a very theoretical possible security issue in mandos-client. If there were to run some sort of "cleaner" process for /run/tmp (or /tmp), and mandos-client were to run for long enough for that cleaner process to remove the temporary directory for GPGME, there was a possibility that another unprivileged process could trick the (also unprivileged) mandos-client process to remove other files or symlinks which the unprivileged mandos-client process was allowed to remove. This is not currently known to have been exploitable, since there are no known initramfs environments running such cleaner processes. * plugins.d/mandos-client.c (main): Use O_NOFOLLOW when opening tempdir for cleaning.	Teddy Hogeborn	10 years ago
696	Bug fix for mandos-client: Run the network hook, not the dir... Bug fix for mandos-client: Run the network hook, not the directory. * plugins.d/mandos-client.d (set_cloexec_flag): Removed. (run_network_hooks): Do not set O_CLOEXEC on "hookdir_fd". Instead, open hook to new "hook_fd" and simply close(hookdir_fd) before fexecve().	Teddy Hogeborn	10 years ago