/mandos/trunk : changes

» Changes from revision 971

To get this branch, use:

bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk

From Revision 40 to 21

expand all

Rev	Summary	Authors	Date
40	* plugins.d/mandosclient.c (initgnutls): Moved "err" variabl... * plugins.d/mandosclient.c (initgnutls): Moved "err" variable into its own code block. (start_mandos_communication): Moved call to "initgnutls" to beginning. Renamed label "exit" to "mandos_end". Bug fix: set return code if failure to realloc buffer. Close TLS session as early as possible. (resolve_callback): Also print interface number when debugging. (main): Moved "debug_int" and "config" into their own respective code blocks.	Teddy Hogeborn	17 years ago
39	* plugins.d/mandosclient.c (pgp_packet_decrypt): Renamed var... * plugins.d/mandosclient.c (pgp_packet_decrypt): Renamed variables. On debug, show decrypted plaintext in hexadecimal. Free the GPGME data buffers even on errors.	Teddy Hogeborn	17 years ago
38	* plugbasedclient.c (main): New "--userid" and "--groupid" o... * plugbasedclient.c (main): New "--userid" and "--groupid" options. Take an additional non-option argument and parse it as a plus-separated and -prefixed list of additional options. * plugins.d/mandosclient.c (DH_BITS): Replaced with "mandos_context.dh_bits". All users changed. (certdir): Renamed to "keydir". All users changed. (certfile): Renamed to "pubkeyfile". All users changed. (certkey): Renamed to "seckeyfile". All users changed. (encrypted_session): Replaced with "mandos_context". All users changed. (initgnutls): Take additional "session" and "dh_params" arguments. All callers changed. (start_mandos_communication): Take additional "mc" argument. All callers changed. Print target IPv6 address if different than supplied string. (simple_poll) Replaced with "mandos_context.simple_poll". All users changed. (server): Replaced with "mandos_context.server". All users changed. (main): Default interface to "eth0". Rename "--certdir" to "--keydir", "--certkey" to "--seckey", and "--certfile" to "--pubkey". New options "--dh-bits" and "--priority". If the interface is not up, bring it up.	Teddy Hogeborn	17 years ago
37	Non-tested commit for merge purposes. Non-tested commit for merge purposes. * plugbasedclient.c (getplugin, addargument, set_cloexec): Made static. * plugins.d/passprompt.c (termination_handler): Made static.	Teddy Hogeborn	17 years ago
36	* TODO: Converted to org-mode style * TODO: Converted to org-mode style * plugins.d/mandosclient.c (certdir): Changed to "/conf/conf.d/mandos/". (certdir, certfile, certkey, pgp_packet_decrypt, debuggnutls, initgnutls, empty_log, combinepath): Made static. (combinepath): Rewritten to only get the argument string lengths once. Do not print error message; leave that to caller. All callers changed.	Teddy Hogeborn	17 years ago
35	* plugbasedclient.c (struct process): New fields "eof", "com... * plugbasedclient.c (struct process): New fields "eof", "completed", and "status". (handle_sigchld): New function. (main): Initialize "dir" to NULL to only closedir() it if necessary. Move "process_list" to be a global variable to be accessible by "handle_sigchld". Make "handle_sigchld" handle SIGCHLD. Remove redundant check for NULL "dir". Free "filename" when no longer used. Block SIGCHLD around fork()/exec(). Restore normal signals in child. Only loop while running processes exist. Print process buffer when the process is done and it has emitted EOF, not when it only emits EOF. Remove processes from list which exit non-cleanly. In cleaning up, closedir() if necessary. Bug fix: set next pointer correctly when freeing process list. * plugins.d/passprompt.c (main): Do not ignore SIGQUIT.	Teddy Hogeborn	17 years ago
34	* plugbasedclient.c (main): Check if plugin dir could be ope... * plugbasedclient.c (main): Check if plugin dir could be opened. Set FD_CLOEXEC on the directory, if possible, and also on both ends of the pipe. Do not allocate buffer for process in advance. Free the plugin list. Bug fix: exit if no plugins found, not if any found. Set "exitstatus" in many places. Simplify and un-indent the loop reading process pipes. Renamed process list iterator to "proc". Bug fix: retry password write on EINTR. Free the process list properly, including the process structs themselves.	Teddy Hogeborn	17 years ago
33	* plugins.d/plugbasedclient.c (main): Close the pipe fd afte... * plugins.d/plugbasedclient.c (main): Close the pipe fd after dup2:ing it onto stdout.	Teddy Hogeborn	17 years ago
32	* plugins.d/plugbasedclient.c (set_cloexec_flag): New functi... * plugins.d/plugbasedclient.c (set_cloexec_flag): New function. (main): Use the set_cloexec_flag function. Move inserting of global arguments to before the fork.	Teddy Hogeborn	17 years ago
31	* plugins.d/plugbasedclient.c: Update include file comments. * plugins.d/plugbasedclient.c: Update include file comments. (struct process.disable): Renamed to "disabled". All users changed. (addarguments): Renamed to "addargument". All callers changed. (doc, args_doc): Removed. (main): Changed default "plugindir" to "/conf/conf.d/mandos/plugins.d". Renamed "rfds_orig" to "rfds_all"; all users changed. New "debug" and "exitstatus" variables. New "--debug" option. Removed unnecessary ".flags = 0" from all options. Changed so that "--disable-plugin" only takes one plugin. Check for non-existence of ":" in argument to "--options-for". Added some debugging outputs. Set the FD_CLOEXEC flag on the directory FD. More capable code for dealing with disallowed plugin file name prefixes and suffixes. Bug fix: check for some malloc failures. Moved allocating the "struct process new_process" to after the fork. Do _exit() instead of exit() in the child. plugins.d/mandosclient.c: Updated contact information.	Teddy Hogeborn	17 years ago
30	Merge. Merge.	Teddy Hogeborn	17 years ago
29	* plugins.d/mandosclient.c (start_mandos_communication): Cha... * plugins.d/mandosclient.c (start_mandos_communication): Changed "if_index" to be of type "AvahiIfIndex". All callers changed. (main): Add default values to "interface" and "if_index". Only change if_index from default if "interface" was given. * server.py (IPv6_TCPServer.server_bind): Bug fix: test if interface is empty, not if equal to avahi.IF_UNSPEC. (if_nametoindex): Bug fix; typo: assign to _func[0], not func[0]. (main): Bug fix: Do not set service.interface unless the interface setting has been given.	Teddy Hogeborn	17 years ago
28	* server.conf: New file. * server.conf: New file. * mandos-clients.conf: Renamed to clients.conf. * Makefile (FORTIFY): New. (CFLAGS): Include $(FORTIFY). * plugins.d/mandosclient.c (main): New "if_index" variable. Bug fix: check if interface exists. New "--connect" option. * server.py (serviceInterface): Removed; replaced by "AvahiService.interface". All users changed. (AvahiError, AvahiServiceError, AvahiGroupError): New exception classes. (AvahiService): New class. (serviceName): Removed; replaced by "AvahiService.name". All users changed. (serviceType): Removed; replaced by "AvahiService.type". All users changed. (servicePort): Removed; replaced by "AvahiService.port". All users changed. (serviceTXT): Removed; replaced by "AvahiService.TXT". All users changed. (domain): Removed; replaced by "AvahiService.domain". All users changed. (host): Removed; replaced by "AvahiService.host". All users changed. (rename_count): Removed; replaced by "AvahiService.rename_count" and "AvahiService.max_renames". All users changed. (Client.__init__): If no secret or secfile, raise TypeError instead of RuntimeError. (Client.last_seen): Renamed to "Client.last_checked_ok". All users changed. (Client.stop, Client.stop_checker): Use "getattr" with default value instead of "hasattr". (Client.still_valid): Removed "now" argument. (Client.handle): Separate the "no client found" and "client invalid" cases for clearer code. (IPv6_TCPServer.__init__): "options" argument replaced by "settings". All callers changed. (IPv6_TCPServer.options): Replaced by "IPv6_TCPServer.settings". All users changed. (IPv6_TCPServer.server_bind): Use getattr instead of hasattr. (add_service): Removed; replaced by "AvahiService.add". All callers changed. (remove_service): Removed; replaced by "AvahiService.remove". All callers changed. (entry_group_state_changed): On entry group collision, call the new AvahiService.rename method. Raise AvahiGroupError on group error. (if_nametoindex): Use ctypes.utils.find_library to locate the C library. Cache the result. Loop on EINTR. (daemon): Use os.path.devnull to locate "/dev/null". (killme): Removed. All callers changed to do "sys.exit()" instead, except where stated otherwise. (main): Removed "exitstatus". Removed all default values from all non-bool options. New option "--configdir". New variables "server_defaults" and "server_settings", read from "%(configdir)s/server.conf". Let any supplied command line options override server settings. Variable "defaults" renamed to "client_defaults", which is read from "clients.conf" instead of "mandos-clients.conf". New global AvahiService object "service" replaces old global variables. Catch AvahiError and exit with error if caught.	Teddy Hogeborn	17 years ago
27	Merge. Merge.	Teddy Hogeborn	17 years ago
26	Merge. Merge.	Teddy Hogeborn	17 years ago
25	* mandos-clients.conf ([DEFAULT]): New section. * mandos-clients.conf ([DEFAULT]): New section. * plugins.d/mandosclient.c (start_mandos_communication): Only print if debugging. Print server name. Bug fix: Loop until suc- cess. * server.py (serverName): Set via option, not globally. (Client.__init__): Removed argument "options". Require "timeout" and "interval" arguments. (tcp_handler.handle): Set "priority" from self.server.options. (main): Removed "--timeout" and "--interval" options. New options "--priority" and "--servicename". Add defaults for "timeout" and "interval". Set "serviceName" from options. Do not pass "options" to "Client()".	Teddy Hogeborn	17 years ago
24	* Makefile (OPTIMIZE): New; optimize for size. * Makefile (OPTIMIZE): New; optimize for size. (CFLAGS): Use $(OPTIMIZE).	Teddy Hogeborn	17 years ago
23	merge merge	Teddy Hogeborn	17 years ago
22	* plugins.d/mandosclient.c (pgp_packet_decrypt): Cast "0" ar... * plugins.d/mandosclient.c (pgp_packet_decrypt): Cast "0" argument to gpgme_data_seek. (start_mandos_communication): Change "ip" arg to "const char *". New variable "written". Remove setsockopt. Bug fix: Do not change decrypted_buffer. (resolve_callback): Removed AVAHI_GCC_UNUSED from "interface".	Teddy Hogeborn	17 years ago
21	* Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COV... * Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and $(LANGUAGE). (WARN, DEBUG, COVERAGE, LANGUAGE): New. (LDFLAGS): New; use $(COVERAGE) * plugbasedclient.c: Added copyright header. (process.buffer_size, process.buffer_length): Changed to "size_t". (main): Cast arguments to malloc and realloc. Detect read errors from processes. * mandosclient.c: Added copyright header. (interface): Moved to inside "main". (gpg_packet_decrypt): Renamed to "pgp_packet_decrypt"; all callers changed. Changed "new_packet_capacity" and "new_packet_length" to be ssize_t. Cast arguments to realloc. (debuggnutls): Attribute "level" argument as unused. (empty_log): Attribute "level" and "txt" arguments as unused. (start_mandos_communication): New argument "if_index". Bug fix: check ret, no tcp_sd, for errors from setsockopt. Use "if_index" directly instead of looking up the index. Loop around fwrite until all data is written. (resolve_callback): Attribute "txt", and "flags" as usused. Added default case to switch. Also show server host name. Call start_mandos_communication with "interface". (browse_callback): Added default case to switch. (main): Variable "interface" moved here. Cast "srand" argument. Bug fix: Call avahi_s_service_browser_new with index of "interface", not "eth0". * passprompt.c: Added copyright header. (termination_handler): Attribute "signum" argument as unused.	Teddy Hogeborn	17 years ago