/mandos/trunk : changes

» Changes from revision 74

To get this branch, use:

bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk

From Revision 34 to 15

expand all

Rev	Summary	Authors	Date
34	* plugbasedclient.c (main): Check if plugin dir could be ope... * plugbasedclient.c (main): Check if plugin dir could be opened. Set FD_CLOEXEC on the directory, if possible, and also on both ends of the pipe. Do not allocate buffer for process in advance. Free the plugin list. Bug fix: exit if no plugins found, not if any found. Set "exitstatus" in many places. Simplify and un-indent the loop reading process pipes. Renamed process list iterator to "proc". Bug fix: retry password write on EINTR. Free the process list properly, including the process structs themselves.	Teddy Hogeborn	16 years ago
33	* plugins.d/plugbasedclient.c (main): Close the pipe fd afte... * plugins.d/plugbasedclient.c (main): Close the pipe fd after dup2:ing it onto stdout.	Teddy Hogeborn	16 years ago
32	* plugins.d/plugbasedclient.c (set_cloexec_flag): New functi... * plugins.d/plugbasedclient.c (set_cloexec_flag): New function. (main): Use the set_cloexec_flag function. Move inserting of global arguments to before the fork.	Teddy Hogeborn	16 years ago
31	* plugins.d/plugbasedclient.c: Update include file comments. * plugins.d/plugbasedclient.c: Update include file comments. (struct process.disable): Renamed to "disabled". All users changed. (addarguments): Renamed to "addargument". All callers changed. (doc, args_doc): Removed. (main): Changed default "plugindir" to "/conf/conf.d/mandos/plugins.d". Renamed "rfds_orig" to "rfds_all"; all users changed. New "debug" and "exitstatus" variables. New "--debug" option. Removed unnecessary ".flags = 0" from all options. Changed so that "--disable-plugin" only takes one plugin. Check for non-existence of ":" in argument to "--options-for". Added some debugging outputs. Set the FD_CLOEXEC flag on the directory FD. More capable code for dealing with disallowed plugin file name prefixes and suffixes. Bug fix: check for some malloc failures. Moved allocating the "struct process new_process" to after the fork. Do _exit() instead of exit() in the child. plugins.d/mandosclient.c: Updated contact information.	Teddy Hogeborn	16 years ago
30	Merge. Merge.	Teddy Hogeborn	16 years ago
29	* plugins.d/mandosclient.c (start_mandos_communication): Cha... * plugins.d/mandosclient.c (start_mandos_communication): Changed "if_index" to be of type "AvahiIfIndex". All callers changed. (main): Add default values to "interface" and "if_index". Only change if_index from default if "interface" was given. * server.py (IPv6_TCPServer.server_bind): Bug fix: test if interface is empty, not if equal to avahi.IF_UNSPEC. (if_nametoindex): Bug fix; typo: assign to _func[0], not func[0]. (main): Bug fix: Do not set service.interface unless the interface setting has been given.	Teddy Hogeborn	16 years ago
28	* server.conf: New file. * server.conf: New file. * mandos-clients.conf: Renamed to clients.conf. * Makefile (FORTIFY): New. (CFLAGS): Include $(FORTIFY). * plugins.d/mandosclient.c (main): New "if_index" variable. Bug fix: check if interface exists. New "--connect" option. * server.py (serviceInterface): Removed; replaced by "AvahiService.interface". All users changed. (AvahiError, AvahiServiceError, AvahiGroupError): New exception classes. (AvahiService): New class. (serviceName): Removed; replaced by "AvahiService.name". All users changed. (serviceType): Removed; replaced by "AvahiService.type". All users changed. (servicePort): Removed; replaced by "AvahiService.port". All users changed. (serviceTXT): Removed; replaced by "AvahiService.TXT". All users changed. (domain): Removed; replaced by "AvahiService.domain". All users changed. (host): Removed; replaced by "AvahiService.host". All users changed. (rename_count): Removed; replaced by "AvahiService.rename_count" and "AvahiService.max_renames". All users changed. (Client.__init__): If no secret or secfile, raise TypeError instead of RuntimeError. (Client.last_seen): Renamed to "Client.last_checked_ok". All users changed. (Client.stop, Client.stop_checker): Use "getattr" with default value instead of "hasattr". (Client.still_valid): Removed "now" argument. (Client.handle): Separate the "no client found" and "client invalid" cases for clearer code. (IPv6_TCPServer.__init__): "options" argument replaced by "settings". All callers changed. (IPv6_TCPServer.options): Replaced by "IPv6_TCPServer.settings". All users changed. (IPv6_TCPServer.server_bind): Use getattr instead of hasattr. (add_service): Removed; replaced by "AvahiService.add". All callers changed. (remove_service): Removed; replaced by "AvahiService.remove". All callers changed. (entry_group_state_changed): On entry group collision, call the new AvahiService.rename method. Raise AvahiGroupError on group error. (if_nametoindex): Use ctypes.utils.find_library to locate the C library. Cache the result. Loop on EINTR. (daemon): Use os.path.devnull to locate "/dev/null". (killme): Removed. All callers changed to do "sys.exit()" instead, except where stated otherwise. (main): Removed "exitstatus". Removed all default values from all non-bool options. New option "--configdir". New variables "server_defaults" and "server_settings", read from "%(configdir)s/server.conf". Let any supplied command line options override server settings. Variable "defaults" renamed to "client_defaults", which is read from "clients.conf" instead of "mandos-clients.conf". New global AvahiService object "service" replaces old global variables. Catch AvahiError and exit with error if caught.	Teddy Hogeborn	16 years ago
27	Merge. Merge.	Teddy Hogeborn	16 years ago
26	Merge. Merge.	Teddy Hogeborn	16 years ago
25	* mandos-clients.conf ([DEFAULT]): New section. * mandos-clients.conf ([DEFAULT]): New section. * plugins.d/mandosclient.c (start_mandos_communication): Only print if debugging. Print server name. Bug fix: Loop until suc- cess. * server.py (serverName): Set via option, not globally. (Client.__init__): Removed argument "options". Require "timeout" and "interval" arguments. (tcp_handler.handle): Set "priority" from self.server.options. (main): Removed "--timeout" and "--interval" options. New options "--priority" and "--servicename". Add defaults for "timeout" and "interval". Set "serviceName" from options. Do not pass "options" to "Client()".	Teddy Hogeborn	16 years ago
24	* Makefile (OPTIMIZE): New; optimize for size. * Makefile (OPTIMIZE): New; optimize for size. (CFLAGS): Use $(OPTIMIZE).	Teddy Hogeborn	16 years ago
23	merge merge	Teddy Hogeborn	16 years ago
22	* plugins.d/mandosclient.c (pgp_packet_decrypt): Cast "0" ar... * plugins.d/mandosclient.c (pgp_packet_decrypt): Cast "0" argument to gpgme_data_seek. (start_mandos_communication): Change "ip" arg to "const char *". New variable "written". Remove setsockopt. Bug fix: Do not change decrypted_buffer. (resolve_callback): Removed AVAHI_GCC_UNUSED from "interface".	Teddy Hogeborn	16 years ago
21	* Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COV... * Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and $(LANGUAGE). (WARN, DEBUG, COVERAGE, LANGUAGE): New. (LDFLAGS): New; use $(COVERAGE) * plugbasedclient.c: Added copyright header. (process.buffer_size, process.buffer_length): Changed to "size_t". (main): Cast arguments to malloc and realloc. Detect read errors from processes. * mandosclient.c: Added copyright header. (interface): Moved to inside "main". (gpg_packet_decrypt): Renamed to "pgp_packet_decrypt"; all callers changed. Changed "new_packet_capacity" and "new_packet_length" to be ssize_t. Cast arguments to realloc. (debuggnutls): Attribute "level" argument as unused. (empty_log): Attribute "level" and "txt" arguments as unused. (start_mandos_communication): New argument "if_index". Bug fix: check ret, no tcp_sd, for errors from setsockopt. Use "if_index" directly instead of looking up the index. Loop around fwrite until all data is written. (resolve_callback): Attribute "txt", and "flags" as usused. Added default case to switch. Also show server host name. Call start_mandos_communication with "interface". (browse_callback): Added default case to switch. (main): Variable "interface" moved here. Cast "srand" argument. Bug fix: Call avahi_s_service_browser_new with index of "interface", not "eth0". * passprompt.c: Added copyright header. (termination_handler): Attribute "signum" argument as unused.	Teddy Hogeborn	16 years ago
20	Merge. Merge.	Teddy Hogeborn	16 years ago
19	* plugins.d/mandosclient.c (start_mandos_communcation): Rena... * plugins.d/mandosclient.c (start_mandos_communcation): Renamed to "start_mandos_communication"	Teddy Hogeborn	16 years ago
18	* plugins.d/Makefile: Removed * plugins.d/Makefile: Removed * plugins.d/mandosclient.c (start_mandos_communcation): Bug fix: write server IP address to "to" struct.	Teddy Hogeborn	16 years ago
17	Merge. Merge.	Teddy Hogeborn	16 years ago
16	* Makefile: Include targets for all binaries. * Makefile: Include targets for all binaries. * plugins.d/Makefile: Do nothing but call the parent Makefile. * server.py: Added copyright statement and information. (Client.__init__): Added doc string. (Client.stop): Bug fix: Only log message if stopping for the first time. Check if the "stop_initiator_tag" and "checker_initiator_tag" attributes exist before using them. (Client.__del__): Call self.stop() instead of doing things here. (Client.checker_callback): Set self.checker_callback_tag and self.checker to None unconditionally and immediately. (Client.stop_checker): Added some checks to handle multiple calls. (tcp_handler.handle): Use "self.server.clients" instead of "clients". (__main__): Moved all code to the "main" function. (main): New. New option "--address". Instantiate IPv6_TCPServer with "options.address". Log before starting main loop. (main.cleanup) Use "clients.pop()" to remove clients from the set as they are stopped.	Teddy Hogeborn	16 years ago
15	* mandos-clients.conf ([foo]): Uncommented. * mandos-clients.conf ([foo]): Uncommented. ([foo]/secret): New. ([foo]/secfile): Commented out. ([foo]/checker): Changed to "fping -q -- %%(fqdn)s". ([foo]/timeout): New. * server.py: New modeline for Python and Emacs. Set a logging format. (Client.__init__): Bug fix: Choose either the value from the options object or pass the argument through string_to_delta for both "timeout" and "interval". (Client.checker_callback): Bug fix: Do not log spurious "Checker for <foo> failed" messages. (Client.start_checker): Moved "Starting checker" log message down to just before actually starting the subprocess. Do not redirect the subprocesses' stdout to a pipe. (peer_certificate, fingerprint): Added docstrings. (entry_group_state_changed): Call "killme()" instead of "main_loop.quit()". (daemon, killme): New functions. (exitstatus, main_loop_started): New global variables. (__main__): Removed the "--cert", "--key", "--ca", and "--crl" options. Removed the sleep command from the default checker. Add a console logger in debug mode. Call "killme()" instead of "main_loop.quit()" when there are no more clients. Call "daemon()" if not in debug mode. Register "cleanup()" to run at exit. Ignore some signals. Catch DBusException to detect another running server and exit cleanly. Exit with "exitstatus". (cleanup): New function.	Teddy Hogeborn	16 years ago