/mandos/trunk : changes

» Changes from revision 1262

To get this branch, use:

bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk

From Revision 1242 to 1223

expand all

Rev	Summary	Authors	Date
1242	Fix theoretical GnuTLS bug Fix theoretical GnuTLS bug Fix "NameError: global name '_error_code' is not defined" error if GNUTLS_E_INTERRUPTED or GNUTLS_E_AGAIN was ever returned from gnutls_record_send(). * mandos (gnutls._retry_on_error): Import "_error_code" from outer class scope to local function scope via a keyword argument.	Teddy Hogeborn	3 years ago
1241	Break long line (white space change only) Break long line (white space change only) * plugin-runner.c (main): Break long line.	Teddy Hogeborn	3 years ago
1240	Use _FORTIFY_SOURCE=3, supported by GNU C Library version 2.... Use _FORTIFY_SOURCE=3, supported by GNU C Library version 2.33 * Makefile (FORTIFY): Changed to use "-D_FORTIFY_SOURCE=3".	Teddy Hogeborn	3 years ago
1239	Fix issue with french translation Fix issue with french translation Initial white space was missing in both msgid and msgstr of the french translation, leading to checking tools reporing an incomplete translation. The string is a raw key id, and therefore did not need translation, so this was never a user-visible issue. * debian/po/fr.po: Add missing whitespace to the id and translation for msgid " ${key_id}".	Teddy Hogeborn	3 years ago
1238	dracut-module/password-agent.c: Add extra diagnostic info dracut-module/password-agent.c: Add extra diagnostic info * dracut-module/password-agent.c (test_send_password_to_socket_EMSGSIZE): If send() fails, also show the message size.	Teddy Hogeborn	3 years ago
1237	mandos-ctl: Fix bad test for command.Remove and related mino... mandos-ctl: Fix bad test for command.Remove and related minor issues The test for command.Remove removes all clients from the spy server, and then loops over all clients, looking for the corresponding Remove command as recorded by the spy server. But since since there aren't any clients left after they were removed, no assertions are made, and the test therefore does nothing. Fix this. In tests for command.Approve and command.Deny, add checks that clients were not somehow removed by the command (in which case, likewise, no assertions are made). Add related checks to TestPropertySetterCmd.runTest; i.e. test that a sequence is not empty before looping over it and making assertions. * mandos-ctl (TestBaseCommands.test_Remove): Save a copy of the original "clients" dict, and loop over those instead. Add assertion that all clients were indeed removed. Also fix the code which looks for the Remove command, which now needs to actually work. (TestBaseCommands.test_Approve, TestBaseCommands.test_Deny): Add assertion that there are still clients before looping over them. (TestPropertySetterCmd.runTest): Add assertion that the list of values to get is not empty before looping over them. Also add check that there are still clients before looping over clients.	Teddy Hogeborn	3 years ago
1236	Merge from release branch Merge from release branch	Teddy Hogeborn	3 years ago
1235	Remove superfluous whitespace Remove superfluous whitespace * plugin-helpers/mandos-client-iprouteadddel.c (fprintf_plus): Remove a stray space character.	Teddy Hogeborn	3 years ago
1234	Update copyright year Update copyright year * debian/copyright: Update copyright year to 2021. * dracut-module/password-agent.c: - '' - * dracut-module/password-agent.xml: Update copyright year to 2020. * intro.xml: - '' - * plugin-helpers/mandos-client-iprouteadddel.c: Update copyright year to 2021. * plugin-runner.c: - '' - * plugins.d/askpass-fifo.c: - '' - * plugins.d/mandos-client.c: - '' - * plugins.d/password-prompt.c: - '' - * plugins.d/plymouth.c: - '' - * plugins.d/splashy.c: - '' - * plugins.d/usplash.c: - '' -	Teddy Hogeborn	3 years ago
1233	Fix #include headers Fix #include headers Update all #include's and comments to reflect order of use in source code. * dracut-module/password-agent.c: Update #include headers. * plugin-helpers/mandos-client-iprouteadddel.c: - '' - * plugin-runner.c: - '' - * plugins.d/askpass-fifo.c: - '' - * plugins.d/mandos-client.c: - '' - * plugins.d/password-prompt.c: - '' - * plugins.d/plymouth.c: - '' - * plugins.d/splashy.c: - '' - * plugins.d/usplash.c: - '' -	Teddy Hogeborn	3 years ago
1232	Fix issue with french translation Fix issue with french translation Initial white space was missing in both msgid and msgstr of the french translation, leading to checking tools reporing an incomplete translation. The string is a raw command line command, and therefore did not need translation, so this was never a user-visible issue. * debian/po/fr.po: Add missing whitespace to the id and translation for msgid " mandos-keygen -F/dev/null\|grep ^key_id".	Teddy Hogeborn	3 years ago
1231	Work around Debian bug #981302 Work around Debian bug #981302 * plugin-runner.c (main): If the /dev/fd symlink is missing, create it. * plugins.d/mandos-client.c (main): - '' - Reported-By: Eero Häkkinen <+debian-bts-2021@eero.xn--hkkinen-5wa.fi> Suggested-by: Eero Häkkinen <+debian-bts-2021@eero.xn--hkkinen-5wa.fi> Thanks: Eero Häkkinen for bug report and analysis	Teddy Hogeborn	3 years ago
1230	Minor code cleanup Minor code cleanup * dracut-module/password-agent.c (test_send_password_to_socket_EMSGSIZE): Replace a free()/malloc() pair with single realloc() call.	Teddy Hogeborn	3 years ago
1229	Minor fix of a test function Minor fix of a test function In dracut-module/password-agent, the test function test_send_password_to_socket_EMSGSIZE() (which tests that the send_password_to_socket() task function aborts properly when getting EMSGSIZE when writing to the password socket), part of the test code is supposed to find a message size which definitely does trigger EMSGSIZE when send()ing to a socket. Without a "break" in the proper place, however, the size given is always exactly 1024 bytes too large. This is very probably not a problem, since a too large message will still be too large if it is increased by 1024 bytes, and send(2) in practice checks the size before reading the buffer. The biggest issue would be if some version of send(2) would try to look at the last 1024 bytes of the message buffer before checking the message size; this would then lead to a buffer over-read when running this test function. (But even then there would be no security implications since the tests are not run in the normal operation of the program.) * dracut-module/password-agent.c (test_send_password_to_socket_EMSGSIZE): Break out early when ssret < 0 and errno == EMSGSIZE; don't allow loop to increase message_size again.	teddy at recompile	3 years ago
1228	Merge from release branch Merge from release branch	Teddy Hogeborn	3 years ago
1227	Update Debian Policy version to 4.5.1; no other changes nece... Update Debian Policy version to 4.5.1; no other changes necessary. * debian/control (Standards-Version): Change to "4.5.1".	teddy at recompile	3 years ago
1226	Fix debconf template syntax Fix debconf template syntax * debian/mandos-client.templates: Rename "_description" header to "_Description".	teddy at recompile	3 years ago
1225	Revert commit 1222 Revert commit 1222	Teddy Hogeborn	3 years ago
1224	Fix flaky test in password-agent Fix flaky test in password-agent The test_send_password_to_socket_EMSGSIZE function should not use a hard-coded constant to trigger an EMSGSIZE error from send(). * dracut-module/password-agent.c (send_password_to_socket): Only save errno from send() if it returned < 0. Show strerror(errno) if send() does return EMSGSIZE. Show number of bytes sent if send() sends less than all bytes. (test_send_password_to_socket_EMSGSIZE): Do not skip this test on non-AMD64 platforms. Try to find a suitable message size to trigger EMSGSIZE before testing send_password_to_socket(), and only skip this test if such a triggering message size is not found. Reported-By: Simon McVittie <smcv@debian.org> Closes: #975457	teddy at recompile	3 years ago
1223	Fix spelling in comments Fix spelling in comments * dracut-module/password-agent.c (test_connect_question_socket_usable, test_send_password_to_socket_EMSGSIZE): Fix spelling from "procotol" to "protocol" in comment.	teddy at recompile	3 years ago