/mandos/trunk : changes

» Changes from revision 1190

To get this branch, use:

bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk

From Revision 1081 to 1062

expand all

Rev	Summary	Authors	Date
1081	mandos-ctl: Refactor tests mandos-ctl: Refactor tests * mandos-ctl (TestBaseCommands.test_IsEnabled): Removed; don't test internal details of command.IsEnabled. (TestBaseCommands.test_IsEnabled_run_exits_successfully): Rename to "test_IsEnabled_exits_successfully". (TestBaseCommands.test_IsEnabled_run_exits_with_failure): Rename to "test_IsEnabled_exits_with_failure".	Teddy Hogeborn	6 years ago
1080	mandos-ctl: Refactor tests mandos-ctl: Refactor tests * mandos-ctl (Test_string_to_delta.test_handles_basic_rfc3339): Split into multiple tests. (Test_string_to_delta.test_rfc3339_zero_seconds): New. (Test_string_to_delta.test_rfc3339_zero_days): - '' - (Test_string_to_delta.test_rfc3339_one_second): - '' - (Test_string_to_delta.test_rfc3339_two_hours): - '' - (TestCommand.setUp.MockClient.Get): Remove; unused. (TestBaseCommands.test_Remove): Remove unnecessary assertion. (TestPropertyCmd.runTest): - '' -	Teddy Hogeborn	6 years ago
1079	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl (TestBaseCommands): Rename test methods to match names of tested command. (TestBaseCommands.test_is_enabled): Rename to "test_IsEnabled". (TestBaseCommands.test_is_enabled_run_exits_successfully): Rename to "test_IsEnabled_run_exits_successfully". (TestBaseCommands.test_is_enabled_run_exits_with_failure): Rename to "test_IsEnabled_run_exits_with_failure". (TestBaseCommands.test_approve): Rename to "test_Approve". (TestBaseCommands.test_deny): Rename to "test_Deny". (TestBaseCommands.test_remove): Rename to "test_Remove".	Teddy Hogeborn	6 years ago
1078	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl (TestBaseCommands.test_remove): Remove superfluous super() call.	Teddy Hogeborn	6 years ago
1077	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl: Move all command classes into a class acting as a namespace. Remove "Cmd" suffix from command class names. All users of commands changed. Also unify all tests of base commands into one test class. (command): New. (TestBaseCommands): New. (TestIsEnableCmd, TestApproveCmd, TestDenyCmd, TestRemoveCmd, TestDumpJSONCmd, TestPrintTableCmd): Remove; move tests into TestBaseCommands.	Teddy Hogeborn	6 years ago
1076	mandos-ctl: Refactor and add a few more tests mandos-ctl: Refactor and add a few more tests * mandos-ctl (main): Remove comment and add empty line. (rfc3339_duration_to_delta): Change ValueError exception message to use \"{}\"" instead of "{!r}" so Python 2 and Python 3 output is the same. (Test_check_option_syntax.temporarily_suppress_stderr): Rename to "redirect_stderr_to_devnull". (Test_check_option_syntax .test_actions_except_is_enabled_are_ok_with_two_clients): Rename to "test_two_clients_are_ok_with_actions_except_is_enabled". (Test_check_option_syntax .test_one_client_with_all_actions_except_is_enabled): New. (Test_check_option_syntax .test_two_clients_with_all_actions_except_is_enabled): - '' -	Teddy Hogeborn	6 years ago
1075	mandos-ctl: Refactor and fix bug in tests. mandos-ctl: Refactor and fix bug in tests. * mandos-ctl (Test_check_option_syntax): Refactor and add more tests.	Teddy Hogeborn	6 years ago
1074	mandos-ctl: Add comment mandos-ctl: Add comment * mandos-ctl (Test_get_managed_objects.test_logs_and_exits_on_dbus_error): Add a comment.	Teddy Hogeborn	6 years ago
1073	mandos-ctl: Refactor tests mandos-ctl: Refactor tests * mandos-ctl (Test_get_managed_objects): Remove some useless "@staticmethod"s.	Teddy Hogeborn	6 years ago
1072	mandos-ctl: Refactor tests mandos-ctl: Refactor tests * mandos-ctl (TestCaseWithAssertLogs): New. (Test_string_to_delta): Inherit from TestCaseWithAssertLogs and simply use self.assertLogs() when needed. (Test_get_mandos_dbus_object): - '' - (Test_get_mandos_dbus_object.CriticalFilter): Remove. (Test_get_managed_objects): - '' - and use a CountingHandler instead of a CountingFilter. (Test_get_managed_objects.CriticalFilter): Remove. (Test_SilenceLogger): Remove.	Teddy Hogeborn	6 years ago
1071	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl (get_mandos_dbus_object, get_managed_objects): Factor out D-Bus exception catching. (if_dbus_exception_log_with_exception_and_exit): New.	Teddy Hogeborn	6 years ago
1070	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl (main): Call get_managed_objects() to get all client paths and properties. (get_managed_objects): New. (Test_get_managed_objects): - '' -	Teddy Hogeborn	6 years ago
1069	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl (main): Do some minor refactoring.	Teddy Hogeborn	6 years ago
1068	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl (main): Call get_mandos_dbus_object() to get "mandos_dbus_objc", and rename it to "mandos_dbus_object". (get_mandos_dbus_object): New. (Test_get_mandos_dbus_object): - '' -	Teddy Hogeborn	6 years ago
1067	mandos-ctl: Bug fix: always shutdown logging. mandos-ctl: Bug fix: always shutdown logging. * mandos-ctl: Shutdown logging at application exit.	Teddy Hogeborn	6 years ago
1066	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl (main): Use SilenceLogger(). (SilenceLogger): New. (Test_SilenceLogger): - '' -	Teddy Hogeborn	6 years ago
1065	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl (main): Rename "mandos_clients" to "all_clients". When no clients are given as options, use all_clients directly instead of constructing a new dict.	Teddy Hogeborn	6 years ago
1064	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl (PrintTableCmd.TableOfClients.__init__): Remove unused parameter "tableheaders".	Teddy Hogeborn	6 years ago
1063	mandos-ctl: Bug fix: Make --dump-json/-j work again. mandos-ctl: Bug fix: Make --dump-json/-j work again. * mandos-ctl (DumpJSONCmd.output): Don't do .values() on "clients". (TestDumpJSONCmd.test_normal, TestDumpJSONCmd.test_one_client): Call .values on clients dict before passing to output() method.	Teddy Hogeborn	6 years ago
1062	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl (TestCmd.bus.Bus.get_object): Add explanatory comment about "self". (Unique): Move to "TestPropertyCmd.Unique". All callers changed.	Teddy Hogeborn	6 years ago