/mandos/trunk : changes

» Changes from revision 1278

To get this branch, use:

bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk

From Revision 1035 to 1016

expand all

Rev	Summary	Authors	Date
1035	mandos-ctl: Refactor; move parsing of intervals into argumen... mandos-ctl: Refactor; move parsing of intervals into argument parsing * mandos-ctl (MillisecondsValueArgumentMixIn.value_to_set): Assume that an incoming value is datetime.timedelta(), not a string. (add_command_line_options): Add "type=string_to_delta" to --timeout, --extended-timeout, --interval, --approval-delay, and --approval-duration. (TestSetTimeoutCmd, TestSetExtendedTimeoutCmd, TestSetIntervalCmd, TestSetApprovalDelayCmd, TestSetApprovalDurationCmd): Change values_to_set to be datetime.timedelta() values, and change to more appropriate values to test. Also adjust values_to_get accordingly.	Teddy Hogeborn	6 years ago
1034	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl (has_action): Move into main(), where is it being used.	Teddy Hogeborn	6 years ago
1033	mandos-ctl: Add test for --checker "" mandos-ctl: Add test for --checker "" * mandos-ctl (Test_command_from_options.test_checker_empty): New.	Teddy Hogeborn	6 years ago
1032	mandos-ctl.xml: Fix documentation bug mandos-ctl.xml: Fix documentation bug * mandos-ctl.xml (SYNOPSIS): Remove duplicate "--interval" option.	Teddy Hogeborn	6 years ago
1031	mandos-ctl: Refactor tests and add more tests mandos-ctl: Refactor tests and add more tests * mandos-ctl (TestOptions): Rename to "Test_command_from_options". (Test_command_from_options.test_default_is_show_table): Rename to "Test_command_from_options.test_print_table". (Test_command_from_options.test_show_table_verbose): Rename to "Test_command_from_options.test_print_table_verbose". (Test_command_from_options.test_bump_timeout): New. (Test_command_from_options.test_start_checker): - '' - (Test_command_from_options.test_stop_checker): - '' - (Test_command_from_options.test_remove): - '' - (Test_command_from_options.test_checker): - '' - (Test_command_from_options.test_timeout): - '' - (Test_command_from_options.test_extended_timeout): - '' - (Test_command_from_options.test_interval): - '' - (Test_command_from_options.test_approve_by_default): - '' - (Test_command_from_options.test_deny_by_default): - '' - (Test_command_from_options.test_approval_delay): - '' - (Test_command_from_options.test_approval_duration): - '' - (Test_command_from_options.test_host): - '' - (Test_command_from_options.test_secret_devnull): - '' - (Test_command_from_options.test_secret_tempfile): - '' - (Test_command_from_options.test_approve): - '' - (Test_command_from_options.test_deny): - '' - (Test_command_from_options.test_dump_json): - '' - (Test_command_from_options.test_is_enabled): - '' -	Teddy Hogeborn	6 years ago
1030	mandos-ctl: Fix bugs mandos-ctl: Fix bugs * mandos-ctl (SetSecretCommand): Argument is file object, not string. (commands_from_options): Fix "command" to "commands" throughout. Add option argument to SetCheckerCmd(). (TestSetSecretCmd): Set file objects, not byte strings.	Teddy Hogeborn	6 years ago
1029	mandos-ctl: Refactor test mandos-ctl: Refactor test * mandos-ctl (TestOptions.assert_command_from_args): Add a client name to all options which need it.	Teddy Hogeborn	6 years ago
1028	mandos-ctl: Refactor test mandos-ctl: Refactor test * mandos-ctl (commands_from_args): Removed. (TestOptions.assert_command_from_args): New.	Teddy Hogeborn	6 years ago
1027	mandos-ctl: Add test for the --disable option mandos-ctl: Add test for the --disable option * mandos-ctl (TestOptions.test_disable): New.	Teddy Hogeborn	6 years ago
1026	mandos-ctl: Add test for the --enable option mandos-ctl: Add test for the --enable option * mandos-ctl (TestOptions.test_enable): New.	Teddy Hogeborn	6 years ago
1025	mandos-ctl: Add more tests, starting with the --verbose opti... mandos-ctl: Add more tests, starting with the --verbose option * mandos-ctl (TestOptions): New.	Teddy Hogeborn	6 years ago
1024	mandos-ctl: Add more tests, including tests for all commands mandos-ctl: Add more tests, including tests for all commands * mandos-ctl (Test_string_to_delta.test_handles_basic_rfc3339): Add a few more test cases. (TestCmd.setUp.MockClient.Set, TestCmd.setUp.MockClient.Get): Don't append to self.calls, since nobody should use it to check for Set() or Get() calls; instead, the return value of Get() should be inspected, and the MockClient.attributes dict should be inspected after (implicitly) calling Set(). (Unique): New; stand-in for unittest.mock.sentinel. (TestPropertyCmd): New; abstract class testing PropertyCmd classes. (TestBumpTimeoutCmd, TestStartCheckerCmd, TestStopCheckerCmd, TestApproveByDefaultCmd, TestDenyByDefaultCmd): New. (TestValueArgumentPropertyCmd): New; abstract class for testing those PropertyCmd classes which also inherit from ValueArgumentMixIn. (TestSetCheckerCmd, TestSetHostCmd, TestSetSecretCmd, TestSetTimeoutCmd, TestSetExtendedTimeoutCmd, TestSetIntervalCmd, TestSetApprovalDelayCmd, TestSetApprovalDurationCmd): New.	Teddy Hogeborn	6 years ago
1023	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl (PrintTableCmd.output): Give name "default_keywords" to default keyword list.	Teddy Hogeborn	6 years ago
1022	mandos-ctl: Refactor mandos-ctl: Refactor * mandos-ctl (commands_and_clients_from_options): Rename to "commands_from_options"; all clients changed. (main): Get "clientnames" directly from "options.client", and move invocation of commands_from_options() to after "clients" is available.	Teddy Hogeborn	6 years ago
1021	mandos-ctl: Add test for EnableCmd and DisableCmd mandos-ctl: Add test for EnableCmd and DisableCmd * mandos-ctl (TestEnableCmd, TestDisableCmd): New.	Teddy Hogeborn	6 years ago
1020	mandos-ctl: Bug fix: fix client/properties confusion mandos-ctl: Bug fix: fix client/properties confusion * mandos-ctl (Command.run_on_one_client): Take an additional "properties" argument. All callers and users changed. (IsEnabledCmd.is_enabled): Don't run client.Get(); just look at the "Enabled" property key. (TestCmd.setUp): Set self.clients to the correct form of dict, and set self.one_client to be a dict with only one client. Also set self.other_client to other client object. All users of these attributes changed. (TestCmd.setUp.MockClient.__getitem__): Removed. (TestCmd.setUp.MockClient.__setitem__): - '' - (TestIsEnabled.test_is_enabled_does_get_attribute): Removed. (TestIsEnabled.test_is_enabled_run_exits_with_failure): Don't use [] to alter client attribute; modify client.attributes dict directly. (TestRemoveCmd.test_remove): Run on full client list. (TestApproveCmd.test_approve): - '' - (TestDenyCmd.test_approve): - '' - and rename to "test_deny".	Teddy Hogeborn	6 years ago
1019	mandos-ctl: New tests for ApproveCmd and DenyCmd mandos-ctl: New tests for ApproveCmd and DenyCmd * mandos-ctl (TestCmd.MockClient.Approve): New method. (TestApproveCmd, TestDenyCmd): New.	Teddy Hogeborn	6 years ago
1018	mandos-ctl: Refactor tests mandos-ctl: Refactor tests * mandos-ctl (TestCmd.client): New; contains one mock client. (TestPrintTableCmd.test_one_client): Use TestCmd.client. (TestDumpJSONCmd.test_one_client): - '' - (TestIsEnabledCmd.test_is_enabled_does_get_attribute): - '' - (TestIsEnabledCmd.test_is_enabled_run_exits_successfully): - '' - (TestIsEnabledCmd.test_is_enabled_run_exits_with_failure): - '' - (TestRemoveCmd.test_remove): - '' -	Teddy Hogeborn	6 years ago
1017	mandos-ctl: Add test for RemoveCmd mandos-ctl: Add test for RemoveCmd * mandos-ctl (TestRemoveCmd): New.	Teddy Hogeborn	6 years ago
1016	mandos-ctl: Improve tests mandos-ctl: Improve tests * mandos-ctl (TestIsEnabledCmd.test_is_enabled_run_exits_successfully, TestIsEnabledCmd.test_is_enabled_run_exits_with_failure): Call run(), not run_on_one_client().	Teddy Hogeborn	6 years ago