1
/* -*- coding: utf-8 -*- */
1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
3
3
* Mandos plugin runner - Run Mandos plugins
5
* Copyright © 2008,2009 Teddy Hogeborn
6
* Copyright © 2008,2009 Björn Påhlsson
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
13
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2018 Teddy Hogeborn
6
* Copyright © 2008-2018 Björn Påhlsson
8
* This file is part of Mandos.
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
15
* Mandos is distributed in the hope that it will be useful, but
14
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
15
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16
18
* General Public License for more details.
18
20
* You should have received a copy of the GNU General Public License
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
23
* Contact the authors at <mandos@recompile.se>.
25
26
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
27
28
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
29
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
30
31
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
32
#include <stdio.h> /* fileno(), fprintf(),
33
stderr, STDOUT_FILENO, fclose() */
34
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
35
WIFEXITED(), WEXITSTATUS(), wait(),
36
pid_t, uid_t, gid_t, getuid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
41
WEXITSTATUS(), WTERMSIG() */
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
43
43
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
53
52
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
#include <string.h> /* strsep, strlen(), asprintf() */
53
FD_CLOEXEC, openat(), scandirat(),
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
56
57
#include <errno.h> /* errno */
57
58
#include <argp.h> /* struct argp_option, struct
58
59
argp_state, struct argp,
65
66
SIG_UNBLOCK, kill(), sig_atomic_t
67
68
#include <errno.h> /* errno, EBADF */
68
#include <inttypes.h> /* intmax_t, SCNdMAX, PRIdMAX, */
69
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
70
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
71
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
72
#include <errno.h> /* errno */
73
#include <error.h> /* error() */
74
#include <fnmatch.h> /* fnmatch() */
70
76
#define BUFFER_SIZE 256
72
78
#define PDIR "/lib/mandos/plugins.d"
79
#define PHDIR "/lib/mandos/plugin-helpers"
73
80
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
75
82
const char *argp_program_version = "plugin-runner " VERSION;
76
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
83
const char *argp_program_bug_address = "<mandos@recompile.se>";
78
85
typedef struct plugin{
79
86
char *name; /* can be NULL or any plugin name */
375
416
.doc = "Group ID the plugins will run as", .group = 3 },
376
417
{ .name = "debug", .key = 132,
377
418
.doc = "Debug mode", .group = 4 },
419
{ .name = "plugin-helper-dir", .key = 133,
421
.doc = "Specify a different plugin helper directory",
424
* These reproduce what we would get without ARGP_NO_HELP
426
{ .name = "help", .key = '?',
427
.doc = "Give this help list", .group = -1 },
428
{ .name = "usage", .key = -3,
429
.doc = "Give a short usage message", .group = -1 },
430
{ .name = "version", .key = 'V',
431
.doc = "Print program version", .group = -1 },
381
error_t parse_opt(int key, char *arg, __attribute__((unused))
382
struct argp_state *state){
435
__attribute__((nonnull(3)))
436
error_t parse_opt(int key, char *arg, struct argp_state *state){
384
441
case 'g': /* --global-options */
386
443
char *plugin_option;
387
444
while((plugin_option = strsep(&arg, ",")) != NULL){
388
if(plugin_option[0] == '\0'){
391
445
if(not add_argument(getplugin(NULL), plugin_option)){
392
perror("add_argument");
393
return ARGP_ERR_UNKNOWN;
398
452
case 'G': /* --global-env */
402
if(not add_environment(getplugin(NULL), arg, true)){
403
perror("add_environment");
453
if(add_environment(getplugin(NULL), arg, true)){
406
457
case 'o': /* --options-for */
408
char *plugin_name = strsep(&arg, ":");
409
if(plugin_name[0] == '\0'){
413
while((plugin_option = strsep(&arg, ",")) != NULL){
414
if(not add_argument(getplugin(plugin_name), plugin_option)){
415
perror("add_argument");
416
return ARGP_ERR_UNKNOWN;
459
char *option_list = strchr(arg, ':');
460
if(option_list == NULL){
461
argp_error(state, "No colon in \"%s\"", arg);
468
argp_error(state, "Empty plugin name");
473
while((option = strsep(&option_list, ",")) != NULL){
474
if(not add_argument(getplugin(arg), option)){
421
481
case 'E': /* --env-for */
426
483
char *envdef = strchr(arg, ':');
427
484
if(envdef == NULL){
485
argp_error(state, "No colon in \"%s\"", arg);
431
if(not add_environment(getplugin(arg), envdef+1, true)){
432
perror("add_environment");
492
argp_error(state, "Empty plugin name");
496
if(add_environment(getplugin(arg), envdef, true)){
436
501
case 'd': /* --disable */
438
503
plugin *p = getplugin(arg);
440
return ARGP_ERR_UNKNOWN;
445
510
case 'e': /* --enable */
447
512
plugin *p = getplugin(arg);
449
return ARGP_ERR_UNKNOWN;
454
519
case 128: /* --plugin-dir */
456
521
plugindir = strdup(arg);
457
if(plugindir == NULL){
522
if(plugindir != NULL){
461
526
case 129: /* --config-file */
462
527
/* This is already done by parse_opt_config_file() */
464
529
case 130: /* --userid */
465
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
466
if(ret < 1 or tmpmax != (uid_t)tmpmax
467
or arg[numchars] != '\0'){
468
fprintf(stderr, "Bad user ID number: \"%s\", using %"
469
PRIdMAX "\n", arg, (intmax_t)uid);
530
tmp_id = strtoimax(arg, &tmp, 10);
531
if(errno != 0 or tmp == arg or *tmp != '\0'
532
or tmp_id != (uid_t)tmp_id){
533
argp_error(state, "Bad user ID number: \"%s\", using %"
534
PRIdMAX, arg, (intmax_t)uid);
474
540
case 131: /* --groupid */
475
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
476
if(ret < 1 or tmpmax != (gid_t)tmpmax
477
or arg[numchars] != '\0'){
478
fprintf(stderr, "Bad group ID number: \"%s\", using %"
479
PRIdMAX "\n", arg, (intmax_t)gid);
541
tmp_id = strtoimax(arg, &tmp, 10);
542
if(errno != 0 or tmp == arg or *tmp != '\0'
543
or tmp_id != (gid_t)tmp_id){
544
argp_error(state, "Bad group ID number: \"%s\", using %"
545
PRIdMAX, arg, (intmax_t)gid);
484
551
case 132: /* --debug */
554
case 133: /* --plugin-helper-dir */
555
free(pluginhelperdir);
556
pluginhelperdir = strdup(arg);
557
if(pluginhelperdir != NULL){
562
* These reproduce what we would get without ARGP_NO_HELP
564
case '?': /* --help */
565
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
566
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
567
__builtin_unreachable();
568
case -3: /* --usage */
569
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
570
argp_state_help(state, state->out_stream,
571
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
572
__builtin_unreachable();
573
case 'V': /* --version */
574
fprintf(state->out_stream, "%s\n", argp_program_version);
488
578
* When adding more options before this line, remember to also add a
489
579
* "case" to the "parse_opt_config_file" function below.
594
696
new_arg = strdup(p);
595
697
if(new_arg == NULL){
597
exitstatus = EXIT_FAILURE;
698
error(0, errno, "strdup");
699
exitstatus = EX_OSERR;
602
704
custom_argc += 1;
603
custom_argv = realloc(custom_argv, sizeof(char *)
604
* ((unsigned int) custom_argc + 1));
605
if(custom_argv == NULL){
607
exitstatus = EXIT_FAILURE;
706
char **new_argv = realloc(custom_argv, sizeof(char *)
707
* ((size_t)custom_argc + 1));
708
if(new_argv == NULL){
709
error(0, errno, "realloc");
710
exitstatus = EX_OSERR;
715
custom_argv = new_argv;
611
718
custom_argv[custom_argc-1] = new_arg;
612
custom_argv[custom_argc] = NULL;
719
custom_argv[custom_argc] = NULL;
723
ret = fclose(conffp);
724
} while(ret == EOF and errno == EINTR);
726
error(0, errno, "fclose");
727
exitstatus = EX_IOERR;
617
732
/* Check for harmful errors and go to fallback. Other errors might
618
733
not affect opening plugins */
619
734
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
621
exitstatus = EXIT_FAILURE;
735
error(0, errno, "fopen");
736
exitstatus = EX_OSERR;
625
/* If there was any arguments from configuration file,
626
pass them to parser as command arguments */
740
/* If there were any arguments from the configuration file, pass
741
them to parser as command line arguments */
627
742
if(custom_argv != NULL){
628
ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
630
if(ret == ARGP_ERR_UNKNOWN){
631
fprintf(stderr, "Unknown error while parsing arguments\n");
632
exitstatus = EXIT_FAILURE;
743
ret = argp_parse(&argp, custom_argc, custom_argv,
744
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
752
error(0, errno, "argp_parse");
753
exitstatus = EX_OSERR;
756
exitstatus = EX_CONFIG;
637
761
/* Parse actual command line arguments, to let them override the
639
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
640
if(ret == ARGP_ERR_UNKNOWN){
641
fprintf(stderr, "Unknown error while parsing arguments\n");
642
exitstatus = EXIT_FAILURE;
763
ret = argp_parse(&argp, argc, argv,
764
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
772
error(0, errno, "argp_parse");
773
exitstatus = EX_OSERR;
776
exitstatus = EX_USAGE;
781
char *pluginhelperenv;
783
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
784
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
786
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
788
if(ret == -1 or not bret){
789
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
790
" environment variable to \"%s\" for all plugins\n",
791
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
794
free(pluginhelperenv);
647
for(plugin *p = plugin_list; p != NULL; p=p->next){
799
for(plugin *p = plugin_list; p != NULL; p = p->next){
648
800
fprintf(stderr, "Plugin: %s has %d arguments\n",
649
801
p->name ? p->name : "Global", p->argc - 1);
650
802
for(char **a = p->argv; *a != NULL; a++){
660
/* Strip permissions down to nobody */
813
/* Work around Debian bug #633582:
814
<https://bugs.debian.org/633582> */
815
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
816
if(plugindir_fd == -1){
818
error(0, errno, "open(\"" PDIR "\")");
821
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
823
error(0, errno, "fstat");
825
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
826
ret = fchown(plugindir_fd, uid, gid);
828
error(0, errno, "fchown");
836
/* Lower permissions */
839
error(0, errno, "setgid");
665
841
ret = setuid(uid);
670
if(plugindir == NULL){
673
dir = opendir(plugindir);
677
perror("Could not open plugin dir");
678
exitstatus = EXIT_FAILURE;
682
/* Set the FD_CLOEXEC flag on the directory, if possible */
843
error(0, errno, "setuid");
846
/* Open plugin directory with close_on_exec flag */
684
int dir_fd = dirfd(dir);
686
ret = set_cloexec_flag(dir_fd);
688
perror("set_cloexec_flag");
689
exitstatus = EXIT_FAILURE;
848
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
851
#else /* not O_CLOEXEC */
853
#endif /* not O_CLOEXEC */
856
error(0, errno, "Could not open plugin dir");
857
exitstatus = EX_UNAVAILABLE;
862
/* Set the FD_CLOEXEC flag on the directory */
863
ret = set_cloexec_flag(dir_fd);
865
error(0, errno, "set_cloexec_flag");
866
exitstatus = EX_OSERR;
869
#endif /* O_CLOEXEC */
872
int good_name(const struct dirent * const dirent){
873
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
874
"*.dpkg-old", "*.dpkg-bak",
875
"*.dpkg-divert", NULL };
877
#pragma GCC diagnostic push
878
#pragma GCC diagnostic ignored "-Wcast-qual"
880
for(const char **pat = (const char **)patterns;
881
*pat != NULL; pat++){
883
#pragma GCC diagnostic pop
885
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
888
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
889
" matching pattern %s\n", dirent->d_name, *pat);
897
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
899
if(numplugins == -1){
900
error(0, errno, "Could not scan plugin dir");
902
exitstatus = EX_OSERR;
695
906
FD_ZERO(&rfds_all);
697
908
/* Read and execute any executable in the plugin directory*/
699
dirst = readdir(dir);
701
/* All directory entries have been processed */
705
exitstatus = EXIT_FAILURE;
711
d_name_len = strlen(dirst->d_name);
713
/* Ignore dotfiles, backup files and other junk */
715
bool bad_name = false;
717
const char const *bad_prefixes[] = { ".", "#", NULL };
719
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
722
".dpkg-divert", NULL };
723
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
724
size_t pre_len = strlen(*pre);
725
if((d_name_len >= pre_len)
726
and strncmp((dirst->d_name), *pre, pre_len) == 0){
728
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
729
" with bad prefix %s\n", dirst->d_name, *pre);
738
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
739
size_t suf_len = strlen(*suf);
740
if((d_name_len >= suf_len)
741
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
744
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
745
" with bad suffix %s\n", dirst->d_name, *suf);
758
if(plugindir == NULL){
759
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
761
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
909
for(int i = 0; i < numplugins; i++){
911
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
913
error(0, errno, "Could not open plugin");
768
ret = stat(filename, &st);
917
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
919
error(0, errno, "stat");
775
925
/* Ignore non-executable files */
776
if(not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
926
if(not S_ISREG(st.st_mode)
927
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
778
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
779
" with bad type or mode\n", filename);
930
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
931
" with bad type or mode\n",
932
plugindir != NULL ? plugindir : PDIR,
933
direntries[i]->d_name);
785
plugin *p = getplugin(dirst->d_name);
940
plugin *p = getplugin(direntries[i]->d_name);
942
error(0, errno, "getplugin");
793
949
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
950
direntries[i]->d_name);
803
960
for(char **a = g->argv + 1; *a != NULL; a++){
804
961
if(not add_argument(p, *a)){
805
perror("add_argument");
962
error(0, errno, "add_argument");
808
965
/* Add global environment variables */
809
966
for(char **e = g->environ; *e != NULL; e++){
810
967
if(not add_environment(p, *e, false)){
811
perror("add_environment");
968
error(0, errno, "add_environment");
816
/* If this plugin has any environment variables, we will call
817
using execve and need to duplicate the environment from this
973
/* If this plugin has any environment variables, we need to
974
duplicate the environment from this process, too. */
819
975
if(p->environ[0] != NULL){
820
976
for(char **e = environ; *e != NULL; e++){
821
977
if(not add_environment(p, *e, false)){
822
perror("add_environment");
978
error(0, errno, "add_environment");
985
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
986
#else /* O_CLOEXEC */
987
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
988
#endif /* O_CLOEXEC */
831
exitstatus = EXIT_FAILURE;
990
error(0, errno, "pipe");
991
exitstatus = EX_OSERR;
995
if(pipefd[0] >= FD_SETSIZE){
996
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1000
exitstatus = EX_OSERR;
1001
free(direntries[i]);
834
1005
/* Ask OS to automatic close the pipe on exec */
835
1006
ret = set_cloexec_flag(pipefd[0]);
837
perror("set_cloexec_flag");
838
exitstatus = EXIT_FAILURE;
1008
error(0, errno, "set_cloexec_flag");
1011
exitstatus = EX_OSERR;
1012
free(direntries[i]);
841
1015
ret = set_cloexec_flag(pipefd[1]);
843
perror("set_cloexec_flag");
844
exitstatus = EXIT_FAILURE;
1017
error(0, errno, "set_cloexec_flag");
1020
exitstatus = EX_OSERR;
1021
free(direntries[i]);
1024
#endif /* not O_CLOEXEC */
847
1025
/* Block SIGCHLD until process is safely in process list */
848
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1026
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1027
&sigchld_action.sa_mask,
850
perror("sigprocmask");
851
exitstatus = EXIT_FAILURE;
1030
error(0, errno, "sigprocmask");
1031
exitstatus = EX_OSERR;
1032
free(direntries[i]);
854
1035
/* Starting a new process to be watched */
1039
} while(pid == -1 and errno == EINTR);
858
exitstatus = EXIT_FAILURE;
1041
error(0, errno, "fork");
1042
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1043
&sigchld_action.sa_mask, NULL));
1046
exitstatus = EX_OSERR;
1047
free(direntries[i]);
862
1051
/* this is the child process */
863
1052
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1054
error(0, errno, "sigaction");
868
1057
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
870
perror("sigprocmask");
1059
error(0, errno, "sigprocmask");
874
1063
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1065
error(0, errno, "dup2");
881
/* If dir has no file descriptor, we could not set FD_CLOEXEC
882
above and must now close it manually here. */
885
if(p->environ[0] == NULL){
886
if(execv(filename, p->argv) < 0){
891
if(execve(filename, p->argv, p->environ) < 0){
1069
if(fexecve(plugin_fd, p->argv,
1070
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1071
error(0, errno, "fexecve for %s/%s",
1072
plugindir != NULL ? plugindir : PDIR,
1073
direntries[i]->d_name);
898
1078
/* Parent process */
899
1079
close(pipefd[1]); /* Close unused write end of pipe */
901
plugin *new_plugin = getplugin(dirst->d_name);
1081
plugin *new_plugin = getplugin(direntries[i]->d_name);
902
1082
if(new_plugin == NULL){
904
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1083
error(0, errno, "getplugin");
1084
ret = (int)(TEMP_FAILURE_RETRY
1085
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
906
perror("sigprocmask");
1088
error(0, errno, "sigprocmask");
908
exitstatus = EXIT_FAILURE;
1090
exitstatus = EX_OSERR;
1091
free(direntries[i]);
1094
free(direntries[i]);
912
1096
new_plugin->pid = pid;
913
1097
new_plugin->fd = pipefd[0];
1100
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1101
new_plugin->name, (intmax_t) (new_plugin->pid));
915
1104
/* Unblock SIGCHLD so signal handler can be run if this process
916
1105
has already completed */
917
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1106
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1107
&sigchld_action.sa_mask,
919
perror("sigprocmask");
920
exitstatus = EXIT_FAILURE;
1110
error(0, errno, "sigprocmask");
1111
exitstatus = EX_OSERR;