19
19
* along with this program. If not, see
20
20
* <http://www.gnu.org/licenses/>.
22
* Contact the authors at <mandos@fukt.bsnet.se>.
22
* Contact the authors at <mandos@recompile.se>.
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
27
27
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
30
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* DIR, fdopendir(), fstat(), struct
34
34
stat, waitpid(), WIFEXITED(),
35
35
WEXITSTATUS(), wait(), pid_t,
36
36
uid_t, gid_t, getuid(), getgid(),
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
41
WEXITSTATUS(), WTERMSIG(),
43
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
43
44
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
#include <dirent.h> /* DIR, struct dirent, fdopendir(),
45
46
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
47
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
48
FD_CLOEXEC, write(), STDOUT_FILENO,
49
struct stat, fstat(), close(),
50
setgid(), setuid(), S_ISREG(),
51
faccessat() pipe(), fork(),
52
_exit(), dup2(), fexecve(), read()
53
54
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
55
#include <string.h> /* strsep, strlen(), asprintf() */
55
FD_CLOEXEC, openat() */
56
#include <string.h> /* strsep, strlen(), strsignal(),
57
strcmp(), strncmp() */
56
58
#include <errno.h> /* errno */
57
59
#include <argp.h> /* struct argp_option, struct
58
60
argp_state, struct argp,
98
107
/* Gets an existing plugin based on name,
99
108
or if none is found, creates a new one */
109
__attribute__((warn_unused_result))
100
110
static plugin *getplugin(char *name){
101
/* Check for exiting plugin with that name */
102
for (plugin *p = plugin_list; p != NULL; p = p->next){
103
if ((p->name == name)
104
or (p->name and name and (strcmp(p->name, name) == 0))){
111
/* Check for existing plugin with that name */
112
for(plugin *p = plugin_list; p != NULL; p = p->next){
114
or (p->name and name and (strcmp(p->name, name) == 0))){
108
118
/* Create a new plugin */
109
plugin *new_plugin = malloc(sizeof(plugin));
110
if (new_plugin == NULL){
119
plugin *new_plugin = NULL;
121
new_plugin = malloc(sizeof(plugin));
122
} while(new_plugin == NULL and errno == EINTR);
123
if(new_plugin == NULL){
113
126
char *copy_name = NULL;
114
127
if(name != NULL){
115
copy_name = strdup(name);
129
copy_name = strdup(name);
130
} while(copy_name == NULL and errno == EINTR);
116
131
if(copy_name == NULL){
121
*new_plugin = (plugin) { .name = copy_name,
124
.next = plugin_list };
139
*new_plugin = (plugin){ .name = copy_name,
142
.next = plugin_list };
126
new_plugin->argv = malloc(sizeof(char *) * 2);
127
if (new_plugin->argv == NULL){
145
new_plugin->argv = malloc(sizeof(char *) * 2);
146
} while(new_plugin->argv == NULL and errno == EINTR);
147
if(new_plugin->argv == NULL){
129
150
free(new_plugin);
132
154
new_plugin->argv[0] = copy_name;
133
155
new_plugin->argv[1] = NULL;
135
new_plugin->environ = malloc(sizeof(char *));
158
new_plugin->environ = malloc(sizeof(char *));
159
} while(new_plugin->environ == NULL and errno == EINTR);
136
160
if(new_plugin->environ == NULL){
138
163
free(new_plugin->argv);
139
164
free(new_plugin);
142
168
new_plugin->environ[0] = NULL;
206
245
* Based on the example in the GNU LibC manual chapter 13.13 "File
207
246
* Descriptor Flags".
208
* *Note File Descriptor Flags:(libc)Descriptor Flags.
247
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
249
__attribute__((warn_unused_result))
210
250
static int set_cloexec_flag(int fd){
211
int ret = fcntl(fd, F_GETFD, 0);
251
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
212
252
/* If reading the flags failed, return error indication now. */
216
256
/* Store modified flag word in the descriptor. */
217
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
257
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
221
262
/* Mark processes as completed when they exit, and save their exit
223
264
static void handle_sigchld(__attribute__((unused)) int sig){
265
int old_errno = errno;
225
267
plugin *proc = plugin_list;
369
414
.doc = "Group ID the plugins will run as", .group = 3 },
370
415
{ .name = "debug", .key = 132,
371
416
.doc = "Debug mode", .group = 4 },
418
* These reproduce what we would get without ARGP_NO_HELP
420
{ .name = "help", .key = '?',
421
.doc = "Give this help list", .group = -1 },
422
{ .name = "usage", .key = -3,
423
.doc = "Give a short usage message", .group = -1 },
424
{ .name = "version", .key = 'V',
425
.doc = "Print program version", .group = -1 },
375
error_t parse_opt (int key, char *arg, __attribute__((unused))
376
struct argp_state *state) {
429
__attribute__((nonnull(3)))
430
error_t parse_opt(int key, char *arg, struct argp_state *state){
378
435
case 'g': /* --global-options */
381
while((p = strsep(&arg, ",")) != NULL){
385
if(not add_argument(getplugin(NULL), p)){
386
perror("add_argument");
387
return ARGP_ERR_UNKNOWN;
438
while((plugin_option = strsep(&arg, ",")) != NULL){
439
if(not add_argument(getplugin(NULL), plugin_option)){
392
446
case 'G': /* --global-env */
396
if(not add_environment(getplugin(NULL), arg, true)){
397
perror("add_environment");
447
if(add_environment(getplugin(NULL), arg, true)){
400
451
case 'o': /* --options-for */
402
char *p_name = strsep(&arg, ":");
403
if(p_name[0] == '\0' or arg == NULL){
406
char *opt = strsep(&arg, ":");
407
if(opt[0] == '\0' or opt == NULL){
411
while((p = strsep(&opt, ",")) != NULL){
415
if(not add_argument(getplugin(p_name), p)){
416
perror("add_argument");
417
return ARGP_ERR_UNKNOWN;
453
char *option_list = strchr(arg, ':');
454
if(option_list == NULL){
455
argp_error(state, "No colon in \"%s\"", arg);
462
argp_error(state, "Empty plugin name");
467
while((option = strsep(&option_list, ",")) != NULL){
468
if(not add_argument(getplugin(arg), option)){
422
475
case 'E': /* --env-for */
427
477
char *envdef = strchr(arg, ':');
428
478
if(envdef == NULL){
479
argp_error(state, "No colon in \"%s\"", arg);
432
if(not add_environment(getplugin(arg), envdef+1, true)){
433
perror("add_environment");
486
argp_error(state, "Empty plugin name");
490
if(add_environment(getplugin(arg), envdef, true)){
437
495
case 'd': /* --disable */
439
497
plugin *p = getplugin(arg);
441
return ARGP_ERR_UNKNOWN;
446
504
case 'e': /* --enable */
448
506
plugin *p = getplugin(arg);
450
return ARGP_ERR_UNKNOWN;
455
513
case 128: /* --plugin-dir */
457
515
plugindir = strdup(arg);
458
if(plugindir == NULL){
516
if(plugindir != NULL){
462
520
case 129: /* --config-file */
463
521
/* This is already done by parse_opt_config_file() */
465
523
case 130: /* --userid */
466
/* In the GNU C library, uid_t is always unsigned int */
467
ret = sscanf(arg, "%ud", &uid);
469
fprintf(stderr, "Bad user ID number: \"%s\", using %ud\n",
524
tmp_id = strtoimax(arg, &tmp, 10);
525
if(errno != 0 or tmp == arg or *tmp != '\0'
526
or tmp_id != (uid_t)tmp_id){
527
argp_error(state, "Bad user ID number: \"%s\", using %"
528
PRIdMAX, arg, (intmax_t)uid);
473
534
case 131: /* --groupid */
474
/* In the GNU C library, gid_t is always unsigned int */
475
ret = sscanf(arg, "%ud", &gid);
477
fprintf(stderr, "Bad group ID number: \"%s\", using %ud\n",
535
tmp_id = strtoimax(arg, &tmp, 10);
536
if(errno != 0 or tmp == arg or *tmp != '\0'
537
or tmp_id != (gid_t)tmp_id){
538
argp_error(state, "Bad group ID number: \"%s\", using %"
539
PRIdMAX, arg, (intmax_t)gid);
481
545
case 132: /* --debug */
549
* These reproduce what we would get without ARGP_NO_HELP
551
case '?': /* --help */
552
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
553
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
554
case -3: /* --usage */
555
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
556
argp_state_help(state, state->out_stream,
557
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
558
case 'V': /* --version */
559
fprintf(state->out_stream, "%s\n", argp_program_version);
485
563
* When adding more options before this line, remember to also add a
486
564
* "case" to the "parse_opt_config_file" function below.
591
679
new_arg = strdup(p);
592
680
if(new_arg == NULL){
594
exitstatus = EXIT_FAILURE;
681
error(0, errno, "strdup");
682
exitstatus = EX_OSERR;
599
687
custom_argc += 1;
600
custom_argv = realloc(custom_argv, sizeof(char *)
601
* ((unsigned int) custom_argc + 1));
602
if(custom_argv == NULL){
604
exitstatus = EXIT_FAILURE;
689
char **new_argv = realloc(custom_argv, sizeof(char *)
692
if(new_argv == NULL){
693
error(0, errno, "realloc");
694
exitstatus = EX_OSERR;
699
custom_argv = new_argv;
608
702
custom_argv[custom_argc-1] = new_arg;
609
custom_argv[custom_argc] = NULL;
703
custom_argv[custom_argc] = NULL;
707
ret = fclose(conffp);
708
} while(ret == EOF and errno == EINTR);
710
error(0, errno, "fclose");
711
exitstatus = EX_IOERR;
614
716
/* Check for harmful errors and go to fallback. Other errors might
615
717
not affect opening plugins */
616
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
618
exitstatus = EXIT_FAILURE;
718
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
719
error(0, errno, "fopen");
720
exitstatus = EX_OSERR;
622
/* If there was any arguments from configuration file,
623
pass them to parser as command arguments */
724
/* If there were any arguments from the configuration file, pass
725
them to parser as command line arguments */
624
726
if(custom_argv != NULL){
625
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
627
if (ret == ARGP_ERR_UNKNOWN){
628
fprintf(stderr, "Unknown error while parsing arguments\n");
629
exitstatus = EXIT_FAILURE;
727
ret = argp_parse(&argp, custom_argc, custom_argv,
728
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
736
error(0, errno, "argp_parse");
737
exitstatus = EX_OSERR;
740
exitstatus = EX_CONFIG;
634
745
/* Parse actual command line arguments, to let them override the
636
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
637
if (ret == ARGP_ERR_UNKNOWN){
638
fprintf(stderr, "Unknown error while parsing arguments\n");
639
exitstatus = EXIT_FAILURE;
747
ret = argp_parse(&argp, argc, argv,
748
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
756
error(0, errno, "argp_parse");
757
exitstatus = EX_OSERR;
760
exitstatus = EX_USAGE;
647
768
for(char **a = p->argv; *a != NULL; a++){
648
769
fprintf(stderr, "\tArg: %s\n", *a);
650
fprintf(stderr, "...and %u environment variables\n", p->envc);
771
fprintf(stderr, "...and %d environment variables\n", p->envc);
651
772
for(char **a = p->environ; *a != NULL; a++){
652
773
fprintf(stderr, "\t%s\n", *a);
657
/* Strip permissions down to nobody */
779
/* Work around Debian bug #633582:
780
<http://bugs.debian.org/633582> */
781
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
782
if(plugindir_fd == -1){
784
error(0, errno, "open(\"" PDIR "\")");
787
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
789
error(0, errno, "fstat");
791
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
792
ret = fchown(plugindir_fd, uid, gid);
794
error(0, errno, "fchown");
798
TEMP_FAILURE_RETRY(close(plugindir_fd));
802
/* Lower permissions */
805
error(0, errno, "setgid");
658
807
ret = setuid(uid);
667
if (plugindir == NULL){
670
dir = opendir(plugindir);
674
perror("Could not open plugin dir");
675
exitstatus = EXIT_FAILURE;
679
/* Set the FD_CLOEXEC flag on the directory, if possible */
809
error(0, errno, "setuid");
812
/* Open plugin directory with close_on_exec flag */
681
int dir_fd = dirfd(dir);
683
ret = set_cloexec_flag(dir_fd);
685
perror("set_cloexec_flag");
686
exitstatus = EXIT_FAILURE;
814
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
817
#else /* not O_CLOEXEC */
819
#endif /* not O_CLOEXEC */
822
error(0, errno, "Could not open plugin dir");
823
exitstatus = EX_UNAVAILABLE;
828
/* Set the FD_CLOEXEC flag on the directory */
829
ret = set_cloexec_flag(dir_fd);
831
error(0, errno, "set_cloexec_flag");
832
TEMP_FAILURE_RETRY(close(dir_fd));
833
exitstatus = EX_OSERR;
836
#endif /* O_CLOEXEC */
838
dir = fdopendir(dir_fd);
840
error(0, errno, "Could not open plugin dir");
841
TEMP_FAILURE_RETRY(close(dir_fd));
842
exitstatus = EX_OSERR;
694
849
/* Read and execute any executable in the plugin directory*/
696
dirst = readdir(dir);
852
dirst = readdir(dir);
853
} while(dirst == NULL and errno == EINTR);
698
855
/* All directory entries have been processed */
699
856
if(dirst == NULL){
702
exitstatus = EXIT_FAILURE;
858
error(0, errno, "readdir");
859
exitstatus = EX_IOERR;
708
d_name_len = strlen(dirst->d_name);
710
865
/* Ignore dotfiles, backup files and other junk */
712
867
bool bad_name = false;
714
const char const *bad_prefixes[] = { ".", "#", NULL };
716
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
719
".dpkg-divert", NULL };
720
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
721
size_t pre_len = strlen(*pre);
722
if((d_name_len >= pre_len)
723
and strncmp((dirst->d_name), *pre, pre_len) == 0){
725
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
726
" with bad prefix %s\n", dirst->d_name, *pre);
735
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
736
size_t suf_len = strlen(*suf);
737
if((d_name_len >= suf_len)
738
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
741
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
742
" with bad suffix %s\n", dirst->d_name, *suf);
755
if(plugindir == NULL){
756
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
758
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
868
const char * const patterns[] = { ".*", "#*#", "*~",
869
"*.dpkg-new", "*.dpkg-old",
870
"*.dpkg-bak", "*.dpkg-divert",
873
#pragma GCC diagnostic push
874
#pragma GCC diagnostic ignored "-Wcast-qual"
876
for(const char **pat = (const char **)patterns;
877
*pat != NULL; pat++){
879
#pragma GCC diagnostic pop
881
if(fnmatch(*pat, dirst->d_name,
882
FNM_FILE_NAME | FNM_PERIOD) != FNM_NOMATCH){
884
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
885
" matching pattern %s\n", dirst->d_name, *pat);
896
int plugin_fd = openat(dir_fd, dirst->d_name, O_RDONLY |
899
#else /* not O_CLOEXEC */
901
#endif /* not O_CLOEXEC */
904
error(0, errno, "Could not open plugin");
908
/* Set the FD_CLOEXEC flag on the plugin FD */
909
ret = set_cloexec_flag(plugin_fd);
911
error(0, errno, "set_cloexec_flag");
912
TEMP_FAILURE_RETRY(close(plugin_fd));
915
#endif /* O_CLOEXEC */
916
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
918
error(0, errno, "stat");
919
TEMP_FAILURE_RETRY(close(plugin_fd));
765
ret = stat(filename, &st);
772
923
/* Ignore non-executable files */
773
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
924
if(not S_ISREG(st.st_mode)
925
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, dirst->d_name, X_OK,
775
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
776
" with bad type or mode\n", filename);
928
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
929
" with bad type or mode\n",
930
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
932
TEMP_FAILURE_RETRY(close(plugin_fd));
782
936
plugin *p = getplugin(dirst->d_name);
938
error(0, errno, "getplugin");
939
TEMP_FAILURE_RETRY(close(plugin_fd));
800
954
for(char **a = g->argv + 1; *a != NULL; a++){
801
955
if(not add_argument(p, *a)){
802
perror("add_argument");
956
error(0, errno, "add_argument");
805
959
/* Add global environment variables */
806
960
for(char **e = g->environ; *e != NULL; e++){
807
961
if(not add_environment(p, *e, false)){
808
perror("add_environment");
962
error(0, errno, "add_environment");
813
/* If this plugin has any environment variables, we will call
814
using execve and need to duplicate the environment from this
967
/* If this plugin has any environment variables, we need to
968
duplicate the environment from this process, too. */
816
969
if(p->environ[0] != NULL){
817
970
for(char **e = environ; *e != NULL; e++){
818
971
if(not add_environment(p, *e, false)){
819
perror("add_environment");
972
error(0, errno, "add_environment");
828
exitstatus = EXIT_FAILURE;
978
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
980
error(0, errno, "pipe");
981
exitstatus = EX_OSERR;
831
984
/* Ask OS to automatic close the pipe on exec */
832
985
ret = set_cloexec_flag(pipefd[0]);
834
perror("set_cloexec_flag");
835
exitstatus = EXIT_FAILURE;
987
error(0, errno, "set_cloexec_flag");
988
exitstatus = EX_OSERR;
838
991
ret = set_cloexec_flag(pipefd[1]);
840
perror("set_cloexec_flag");
841
exitstatus = EXIT_FAILURE;
993
error(0, errno, "set_cloexec_flag");
994
exitstatus = EX_OSERR;
844
997
/* Block SIGCHLD until process is safely in process list */
845
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
998
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
999
&sigchld_action.sa_mask,
847
perror("sigprocmask");
848
exitstatus = EXIT_FAILURE;
1002
error(0, errno, "sigprocmask");
1003
exitstatus = EX_OSERR;
851
1006
/* Starting a new process to be watched */
1010
} while(pid == -1 and errno == EINTR);
855
exitstatus = EXIT_FAILURE;
1012
error(0, errno, "fork");
1013
exitstatus = EX_OSERR;
859
1017
/* this is the child process */
860
1018
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1020
error(0, errno, "sigaction");
865
1023
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
867
perror("sigprocmask");
1025
error(0, errno, "sigprocmask");
871
1029
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1031
error(0, errno, "dup2");
877
1035
if(dirfd(dir) < 0){
879
1037
above and must now close it manually here. */
882
if(p->environ[0] == NULL){
883
if(execv(filename, p->argv) < 0){
888
if(execve(filename, p->argv, p->environ) < 0){
1040
if(fexecve(plugin_fd, p->argv,
1041
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1042
error(0, errno, "fexecve for %s/%s",
1043
plugindir != NULL ? plugindir : PDIR, dirst->d_name);
895
1048
/* Parent process */
896
close(pipefd[1]); /* Close unused write end of pipe */
1049
TEMP_FAILURE_RETRY(close(pipefd[1])); /* Close unused write end of
1051
TEMP_FAILURE_RETRY(close(plugin_fd));
898
1052
plugin *new_plugin = getplugin(dirst->d_name);
899
if (new_plugin == NULL){
901
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1053
if(new_plugin == NULL){
1054
error(0, errno, "getplugin");
1055
ret = (int)(TEMP_FAILURE_RETRY
1056
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
903
perror("sigprocmask");
1059
error(0, errno, "sigprocmask");
905
exitstatus = EXIT_FAILURE;
1061
exitstatus = EX_OSERR;
912
1068
/* Unblock SIGCHLD so signal handler can be run if this process
913
1069
has already completed */
914
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1070
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1071
&sigchld_action.sa_mask,
916
perror("sigprocmask");
917
exitstatus = EXIT_FAILURE;
1074
error(0, errno, "sigprocmask");
1075
exitstatus = EX_OSERR;
921
FD_SET(new_plugin->fd, &rfds_all);
1079
#if defined (__GNUC__) and defined (__GLIBC__)
1080
#if not __GLIBC_PREREQ(2, 16)
1081
#pragma GCC diagnostic push
1082
#pragma GCC diagnostic ignored "-Wsign-conversion"
1085
FD_SET(new_plugin->fd, &rfds_all); /* Spurious warning from
1086
-Wconversion in GNU libc
1088
#if defined (__GNUC__) and defined (__GLIBC__)
1089
#if not __GLIBC_PREREQ(2, 16)
1090
#pragma GCC diagnostic pop
923
if (maxfd < new_plugin->fd){
1094
if(maxfd < new_plugin->fd){
924
1095
maxfd = new_plugin->fd;
1099
TEMP_FAILURE_RETRY(closedir(dir));
1101
free_plugin(getplugin(NULL));
931
1103
for(plugin *p = plugin_list; p != NULL; p = p->next){
932
1104
if(p->pid != 0){
943
1115
while(plugin_list){
944
1116
fd_set rfds = rfds_all;
945
1117
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
946
if (select_ret == -1){
948
exitstatus = EXIT_FAILURE;
1118
if(select_ret == -1 and errno != EINTR){
1119
error(0, errno, "select");
1120
exitstatus = EX_OSERR;
951
1123
/* OK, now either a process completed, or something can be read
952
1124
from one of them */
953
1125
for(plugin *proc = plugin_list; proc != NULL;){
954
1126
/* Is this process completely done? */
955
if(proc->eof and proc->completed){
1127
if(proc->completed and proc->eof){
956
1128
/* Only accept the plugin output if it exited cleanly */
957
1129
if(not WIFEXITED(proc->status)
958
1130
or WEXITSTATUS(proc->status) != 0){
959
1131
/* Bad exit by plugin */
962
1134
if(WIFEXITED(proc->status)){
963
fprintf(stderr, "Plugin %u exited with status %d\n",
964
(unsigned int) (proc->pid),
1135
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1136
" status %d\n", proc->name,
1137
(intmax_t) (proc->pid),
965
1138
WEXITSTATUS(proc->status));
966
} else if(WIFSIGNALED(proc->status)) {
967
fprintf(stderr, "Plugin %u killed by signal %d\n",
968
(unsigned int) (proc->pid),
969
WTERMSIG(proc->status));
1139
} else if(WIFSIGNALED(proc->status)){
1140
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1141
" signal %d: %s\n", proc->name,
1142
(intmax_t) (proc->pid),
1143
WTERMSIG(proc->status),
1144
strsignal(WTERMSIG(proc->status)));
970
1145
} else if(WCOREDUMP(proc->status)){
971
fprintf(stderr, "Plugin %d dumped core\n",
972
(unsigned int) (proc->pid));
1146
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1147
" core\n", proc->name, (intmax_t) (proc->pid));
976
1151
/* Remove the plugin */
977
FD_CLR(proc->fd, &rfds_all);
1152
#if defined (__GNUC__) and defined (__GLIBC__)
1153
#if not __GLIBC_PREREQ(2, 16)
1154
#pragma GCC diagnostic push
1155
#pragma GCC diagnostic ignored "-Wsign-conversion"
1158
FD_CLR(proc->fd, &rfds_all); /* Spurious warning from
1159
-Wconversion in GNU libc
1161
#if defined (__GNUC__) and defined (__GLIBC__)
1162
#if not __GLIBC_PREREQ(2, 16)
1163
#pragma GCC diagnostic pop
979
1167
/* Block signal while modifying process_list */
980
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1168
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1170
&sigchld_action.sa_mask,
982
perror("sigprocmask");
983
exitstatus = EXIT_FAILURE;
1173
error(0, errno, "sigprocmask");
1174
exitstatus = EX_OSERR;
1009
1201
bool bret = print_out_password(proc->buffer,
1010
1202
proc->buffer_length);
1012
perror("print_out_password");
1013
exitstatus = EXIT_FAILURE;
1204
error(0, errno, "print_out_password");
1205
exitstatus = EX_IOERR;
1018
1210
/* This process has not completed. Does it have any output? */
1019
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1211
#if defined (__GNUC__) and defined (__GLIBC__)
1212
#if not __GLIBC_PREREQ(2, 16)
1213
#pragma GCC diagnostic push
1214
#pragma GCC diagnostic ignored "-Wsign-conversion"
1217
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){ /* Spurious
1223
#if defined (__GNUC__) and defined (__GLIBC__)
1224
#if not __GLIBC_PREREQ(2, 16)
1225
#pragma GCC diagnostic pop
1020
1228
/* This process had nothing to say at this time */
1021
1229
proc = proc->next;
1024
1232
/* Before reading, make the process' data buffer large enough */
1025
1233
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1026
proc->buffer = realloc(proc->buffer, proc->buffer_size
1027
+ (size_t) BUFFER_SIZE);
1028
if (proc->buffer == NULL){
1030
exitstatus = EXIT_FAILURE;
1234
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1235
+ (size_t) BUFFER_SIZE);
1236
if(new_buffer == NULL){
1237
error(0, errno, "malloc");
1238
exitstatus = EX_OSERR;
1241
proc->buffer = new_buffer;
1033
1242
proc->buffer_size += BUFFER_SIZE;
1035
1244
/* Read from the process */
1036
sret = read(proc->fd, proc->buffer + proc->buffer_length,
1245
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1247
+ proc->buffer_length,
1039
1250
/* Read error from this process; ignore the error */
1040
1251
proc = proc->next;