1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
1
/* -*- coding: utf-8 -*- */
3
3
* Mandos plugin runner - Run Mandos plugins
5
* Copyright © 2008-2018 Teddy Hogeborn
6
* Copyright © 2008-2018 Björn Påhlsson
8
* This file is part of Mandos.
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
15
* Mandos is distributed in the hope that it will be useful, but
5
* Copyright © 2008 Teddy Hogeborn & Björn Påhlsson
7
* This program is free software: you can redistribute it and/or
8
* modify it under the terms of the GNU General Public License as
9
* published by the Free Software Foundation, either version 3 of the
10
* License, or (at your option) any later version.
12
* This program is distributed in the hope that it will be useful, but
16
13
* WITHOUT ANY WARRANTY; without even the implied warranty of
17
14
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
18
15
* General Public License for more details.
20
17
* You should have received a copy of the GNU General Public License
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
18
* along with this program. If not, see
19
* <http://www.gnu.org/licenses/>.
23
* Contact the authors at <mandos@recompile.se>.
21
* Contact the authors at <mandos@fukt.bsnet.se>.
26
24
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
28
26
#include <stddef.h> /* size_t, NULL */
29
#include <stdlib.h> /* malloc(), reallocarray(), realloc(),
30
EXIT_SUCCESS, exit() */
27
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
28
EXIT_SUCCESS, realloc() */
31
29
#include <stdbool.h> /* bool, true, false */
32
#include <stdio.h> /* fileno(), fprintf(),
33
stderr, STDOUT_FILENO, fclose() */
34
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
35
WIFEXITED(), WEXITSTATUS(), wait(),
36
pid_t, uid_t, gid_t, getuid(),
30
#include <stdio.h> /* perror, fileno(), fprintf(),
31
stderr, STDOUT_FILENO */
32
#include <sys/types.h> /* DIR, opendir(), stat(), struct
33
stat, waitpid(), WIFEXITED(),
34
WEXITSTATUS(), wait(), pid_t,
35
uid_t, gid_t, getuid(), getgid(),
38
37
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
38
FD_SET(), FD_ISSET(), FD_CLR */
40
39
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS(), WTERMSIG() */
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
41
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
43
42
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
43
#include <dirent.h> /* DIR, struct dirent, opendir(),
44
readdir(), closedir(), dirfd() */
45
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
46
fcntl(), setuid(), setgid(),
47
F_GETFD, F_SETFD, FD_CLOEXEC,
48
access(), pipe(), fork(), close()
49
dup2(), STDOUT_FILENO, _exit(),
50
execv(), write(), read(),
52
52
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
53
FD_CLOEXEC, openat(), scandirat(),
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
54
#include <string.h> /* strsep, strlen(), asprintf() */
57
55
#include <errno.h> /* errno */
58
56
#include <argp.h> /* struct argp_option, struct
59
57
argp_state, struct argp,
428
367
.doc = "Group ID the plugins will run as", .group = 3 },
429
368
{ .name = "debug", .key = 132,
430
369
.doc = "Debug mode", .group = 4 },
431
{ .name = "plugin-helper-dir", .key = 133,
433
.doc = "Specify a different plugin helper directory",
436
* These reproduce what we would get without ARGP_NO_HELP
438
{ .name = "help", .key = '?',
439
.doc = "Give this help list", .group = -1 },
440
{ .name = "usage", .key = -3,
441
.doc = "Give a short usage message", .group = -1 },
442
{ .name = "version", .key = 'V',
443
.doc = "Print program version", .group = -1 },
447
__attribute__((nonnull(3)))
448
error_t parse_opt(int key, char *arg, struct argp_state *state){
373
error_t parse_opt (int key, char *arg, __attribute__((unused))
374
struct argp_state *state) {
453
376
case 'g': /* --global-options */
456
while((plugin_option = strsep(&arg, ",")) != NULL){
457
if(not add_argument(getplugin(NULL), plugin_option)){
379
while((p = strsep(&arg, ",")) != NULL){
383
if(not add_argument(getplugin(NULL), p)){
384
perror("add_argument");
385
return ARGP_ERR_UNKNOWN;
464
390
case 'G': /* --global-env */
465
if(add_environment(getplugin(NULL), arg, true)){
394
if(not add_environment(getplugin(NULL), arg, true)){
395
perror("add_environment");
469
398
case 'o': /* --options-for */
471
char *option_list = strchr(arg, ':');
472
if(option_list == NULL){
473
argp_error(state, "No colon in \"%s\"", arg);
480
argp_error(state, "Empty plugin name");
485
while((option = strsep(&option_list, ",")) != NULL){
486
if(not add_argument(getplugin(arg), option)){
400
char *p_name = strsep(&arg, ":");
401
if(p_name[0] == '\0' or arg == NULL){
404
char *opt = strsep(&arg, ":");
405
if(opt[0] == '\0' or opt == NULL){
409
while((p = strsep(&opt, ",")) != NULL){
413
if(not add_argument(getplugin(p_name), p)){
414
perror("add_argument");
415
return ARGP_ERR_UNKNOWN;
493
420
case 'E': /* --env-for */
495
425
char *envdef = strchr(arg, ':');
496
426
if(envdef == NULL){
497
argp_error(state, "No colon in \"%s\"", arg);
504
argp_error(state, "Empty plugin name");
508
if(add_environment(getplugin(arg), envdef, true)){
430
if(not add_environment(getplugin(arg), envdef+1, true)){
431
perror("add_environment");
513
435
case 'd': /* --disable */
515
437
plugin *p = getplugin(arg);
439
return ARGP_ERR_UNKNOWN;
522
444
case 'e': /* --enable */
524
446
plugin *p = getplugin(arg);
448
return ARGP_ERR_UNKNOWN;
531
453
case 128: /* --plugin-dir */
533
455
plugindir = strdup(arg);
534
if(plugindir != NULL){
456
if(plugindir == NULL){
538
460
case 129: /* --config-file */
539
461
/* This is already done by parse_opt_config_file() */
541
463
case 130: /* --userid */
542
tmp_id = strtoimax(arg, &tmp, 10);
543
if(errno != 0 or tmp == arg or *tmp != '\0'
544
or tmp_id != (uid_t)tmp_id){
545
argp_error(state, "Bad user ID number: \"%s\", using %"
546
PRIdMAX, arg, (intmax_t)uid);
464
uid = (uid_t)strtol(arg, NULL, 10);
552
466
case 131: /* --groupid */
553
tmp_id = strtoimax(arg, &tmp, 10);
554
if(errno != 0 or tmp == arg or *tmp != '\0'
555
or tmp_id != (gid_t)tmp_id){
556
argp_error(state, "Bad group ID number: \"%s\", using %"
557
PRIdMAX, arg, (intmax_t)gid);
467
gid = (gid_t)strtol(arg, NULL, 10);
563
469
case 132: /* --debug */
566
case 133: /* --plugin-helper-dir */
567
free(pluginhelperdir);
568
pluginhelperdir = strdup(arg);
569
if(pluginhelperdir != NULL){
574
* These reproduce what we would get without ARGP_NO_HELP
576
case '?': /* --help */
577
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
578
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
579
__builtin_unreachable();
580
case -3: /* --usage */
581
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
582
argp_state_help(state, state->out_stream,
583
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
584
__builtin_unreachable();
585
case 'V': /* --version */
586
fprintf(state->out_stream, "%s\n", argp_program_version);
590
* When adding more options before this line, remember to also add a
591
* "case" to the "parse_opt_config_file" function below.
593
472
case ARGP_KEY_ARG:
594
473
/* Cryptsetup always passes an argument, which is an empty
595
474
string if "none" was specified in /etc/crypttab. So if
596
475
argument was empty, we ignore it silently. */
477
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
601
__attribute__((fallthrough));
606
483
return ARGP_ERR_UNKNOWN;
608
return errno; /* Set to 0 at start */
611
488
/* This option parser is the same as parse_opt() above, except it
612
489
ignores everything but the --config-file option. */
613
error_t parse_opt_config_file(int key, char *arg,
614
__attribute__((unused))
615
struct argp_state *state){
490
error_t parse_opt_config_file (int key, char *arg,
491
__attribute__((unused))
492
struct argp_state *state) {
618
494
case 'g': /* --global-options */
619
495
case 'G': /* --global-env */
620
496
case 'o': /* --options-for */
712
576
new_arg = strdup(p);
713
577
if(new_arg == NULL){
714
error(0, errno, "strdup");
715
exitstatus = EX_OSERR;
579
exitstatus = EXIT_FAILURE;
720
584
custom_argc += 1;
722
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
723
char **new_argv = reallocarray(custom_argv, (size_t)custom_argc + 1,
726
char **new_argv = NULL;
727
if(((size_t)custom_argc + 1) > (SIZE_MAX / sizeof(char *))){
731
new_argv = realloc(custom_argv, ((size_t)custom_argc + 1)
735
if(new_argv == NULL){
736
error(0, errno, "reallocarray");
737
exitstatus = EX_OSERR;
742
custom_argv = new_argv;
585
custom_argv = realloc(custom_argv, sizeof(char *)
586
* ((unsigned int) custom_argc + 1));
587
if(custom_argv == NULL){
589
exitstatus = EXIT_FAILURE;
745
593
custom_argv[custom_argc-1] = new_arg;
746
custom_argv[custom_argc] = NULL;
594
custom_argv[custom_argc] = NULL;
750
ret = fclose(conffp);
751
} while(ret == EOF and errno == EINTR);
753
error(0, errno, "fclose");
754
exitstatus = EX_IOERR;
759
599
/* Check for harmful errors and go to fallback. Other errors might
760
600
not affect opening plugins */
761
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
762
error(0, errno, "fopen");
763
exitstatus = EX_OSERR;
601
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
603
exitstatus = EXIT_FAILURE;
767
/* If there were any arguments from the configuration file, pass
768
them to parser as command line arguments */
607
/* If there was any arguments from configuration file,
608
pass them to parser as command arguments */
769
609
if(custom_argv != NULL){
770
ret = argp_parse(&argp, custom_argc, custom_argv,
771
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
779
error(0, errno, "argp_parse");
780
exitstatus = EX_OSERR;
783
exitstatus = EX_CONFIG;
610
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
612
if (ret == ARGP_ERR_UNKNOWN){
613
fprintf(stderr, "Unknown error while parsing arguments\n");
614
exitstatus = EXIT_FAILURE;
788
619
/* Parse actual command line arguments, to let them override the
790
ret = argp_parse(&argp, argc, argv,
791
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
799
error(0, errno, "argp_parse");
800
exitstatus = EX_OSERR;
803
exitstatus = EX_USAGE;
808
char *pluginhelperenv;
810
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
811
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
813
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
815
if(ret == -1 or not bret){
816
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
817
" environment variable to \"%s\" for all plugins\n",
818
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
821
free(pluginhelperenv);
621
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
622
if (ret == ARGP_ERR_UNKNOWN){
623
fprintf(stderr, "Unknown error while parsing arguments\n");
624
exitstatus = EXIT_FAILURE;
826
for(plugin *p = plugin_list; p != NULL; p = p->next){
629
for(plugin *p = plugin_list; p != NULL; p=p->next){
827
630
fprintf(stderr, "Plugin: %s has %d arguments\n",
828
631
p->name ? p->name : "Global", p->argc - 1);
829
632
for(char **a = p->argv; *a != NULL; a++){
830
633
fprintf(stderr, "\tArg: %s\n", *a);
832
fprintf(stderr, "...and %d environment variables\n", p->envc);
635
fprintf(stderr, "...and %u environment variables\n", p->envc);
833
636
for(char **a = p->environ; *a != NULL; a++){
834
637
fprintf(stderr, "\t%s\n", *a);
840
/* Work around Debian bug #633582:
841
<https://bugs.debian.org/633582> */
842
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
843
if(plugindir_fd == -1){
845
error(0, errno, "open(\"" PDIR "\")");
848
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
850
error(0, errno, "fstat");
852
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
853
ret = fchown(plugindir_fd, uid, gid);
855
error(0, errno, "fchown");
863
/* Lower permissions */
866
error(0, errno, "setgid");
642
/* Strip permissions down to nobody */
868
643
ret = setuid(uid);
870
error(0, errno, "setuid");
873
/* Open plugin directory with close_on_exec flag */
652
if (plugindir == NULL){
655
dir = opendir(plugindir);
659
perror("Could not open plugin dir");
660
exitstatus = EXIT_FAILURE;
664
/* Set the FD_CLOEXEC flag on the directory, if possible */
875
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
878
#else /* not O_CLOEXEC */
880
#endif /* not O_CLOEXEC */
883
error(0, errno, "Could not open plugin dir");
884
exitstatus = EX_UNAVAILABLE;
889
/* Set the FD_CLOEXEC flag on the directory */
890
ret = set_cloexec_flag(dir_fd);
892
error(0, errno, "set_cloexec_flag");
893
exitstatus = EX_OSERR;
896
#endif /* O_CLOEXEC */
899
int good_name(const struct dirent * const dirent){
900
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
901
"*.dpkg-old", "*.dpkg-bak",
902
"*.dpkg-divert", NULL };
904
#pragma GCC diagnostic push
905
#pragma GCC diagnostic ignored "-Wcast-qual"
907
for(const char **pat = (const char **)patterns;
908
*pat != NULL; pat++){
910
#pragma GCC diagnostic pop
912
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
915
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
916
" matching pattern %s\n", dirent->d_name, *pat);
666
int dir_fd = dirfd(dir);
668
ret = set_cloexec_flag(dir_fd);
670
perror("set_cloexec_flag");
671
exitstatus = EXIT_FAILURE;
924
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
926
if(numplugins == -1){
927
error(0, errno, "Could not scan plugin dir");
929
exitstatus = EX_OSERR;
933
677
FD_ZERO(&rfds_all);
935
679
/* Read and execute any executable in the plugin directory*/
936
for(int i = 0; i < numplugins; i++){
938
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
940
error(0, errno, "Could not open plugin");
944
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
946
error(0, errno, "stat");
681
dirst = readdir(dir);
683
/* All directory entries have been processed */
687
exitstatus = EXIT_FAILURE;
693
d_name_len = strlen(dirst->d_name);
695
/* Ignore dotfiles, backup files and other junk */
697
bool bad_name = false;
699
const char const *bad_prefixes[] = { ".", "#", NULL };
701
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
704
".dpkg-divert", NULL };
705
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
706
size_t pre_len = strlen(*pre);
707
if((d_name_len >= pre_len)
708
and strncmp((dirst->d_name), *pre, pre_len) == 0){
710
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
711
" with bad prefix %s\n", dirst->d_name, *pre);
720
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
721
size_t suf_len = strlen(*suf);
722
if((d_name_len >= suf_len)
723
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
726
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
727
" with bad suffix %s\n", dirst->d_name, *suf);
740
if(plugindir == NULL){
741
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
743
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
750
ret = stat(filename, &st);
952
757
/* Ignore non-executable files */
953
if(not S_ISREG(st.st_mode)
954
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
758
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
957
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
958
" with bad type or mode\n",
959
plugindir != NULL ? plugindir : PDIR,
960
direntries[i]->d_name);
760
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
761
" with bad type or mode\n", filename);
967
plugin *p = getplugin(direntries[i]->d_name);
767
plugin *p = getplugin(dirst->d_name);
969
error(0, errno, "getplugin");
976
775
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
977
direntries[i]->d_name);
987
785
for(char **a = g->argv + 1; *a != NULL; a++){
988
786
if(not add_argument(p, *a)){
989
error(0, errno, "add_argument");
787
perror("add_argument");
992
790
/* Add global environment variables */
993
791
for(char **e = g->environ; *e != NULL; e++){
994
792
if(not add_environment(p, *e, false)){
995
error(0, errno, "add_environment");
793
perror("add_environment");
1000
/* If this plugin has any environment variables, we need to
1001
duplicate the environment from this process, too. */
798
/* If this plugin has any environment variables, we will call
799
using execve and need to duplicate the environment from this
1002
801
if(p->environ[0] != NULL){
1003
802
for(char **e = environ; *e != NULL; e++){
1004
803
if(not add_environment(p, *e, false)){
1005
error(0, errno, "add_environment");
804
perror("add_environment");
1012
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1013
#else /* O_CLOEXEC */
1014
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
1015
#endif /* O_CLOEXEC */
1017
error(0, errno, "pipe");
1018
exitstatus = EX_OSERR;
1019
free(direntries[i]);
1022
if(pipefd[0] >= FD_SETSIZE){
1023
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1027
exitstatus = EX_OSERR;
1028
free(direntries[i]);
813
exitstatus = EXIT_FAILURE;
1032
816
/* Ask OS to automatic close the pipe on exec */
1033
817
ret = set_cloexec_flag(pipefd[0]);
1035
error(0, errno, "set_cloexec_flag");
1038
exitstatus = EX_OSERR;
1039
free(direntries[i]);
819
perror("set_cloexec_flag");
820
exitstatus = EXIT_FAILURE;
1042
823
ret = set_cloexec_flag(pipefd[1]);
1044
error(0, errno, "set_cloexec_flag");
1047
exitstatus = EX_OSERR;
1048
free(direntries[i]);
825
perror("set_cloexec_flag");
826
exitstatus = EXIT_FAILURE;
1051
#endif /* not O_CLOEXEC */
1052
829
/* Block SIGCHLD until process is safely in process list */
1053
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1054
&sigchld_action.sa_mask,
830
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1057
error(0, errno, "sigprocmask");
1058
exitstatus = EX_OSERR;
1059
free(direntries[i]);
832
perror("sigprocmask");
833
exitstatus = EXIT_FAILURE;
1062
836
/* Starting a new process to be watched */
1066
} while(pid == -1 and errno == EINTR);
1068
error(0, errno, "fork");
1069
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1070
&sigchld_action.sa_mask, NULL));
1073
exitstatus = EX_OSERR;
1074
free(direntries[i]);
840
exitstatus = EXIT_FAILURE;
1078
844
/* this is the child process */
1079
845
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1081
error(0, errno, "sigaction");
1084
850
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1086
error(0, errno, "sigprocmask");
852
perror("sigprocmask");
1090
856
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1092
error(0, errno, "dup2");
1096
if(fexecve(plugin_fd, p->argv,
1097
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1098
error(0, errno, "fexecve for %s/%s",
1099
plugindir != NULL ? plugindir : PDIR,
1100
direntries[i]->d_name);
863
/* If dir has no file descriptor, we could not set FD_CLOEXEC
864
above and must now close it manually here. */
867
if(p->environ[0] == NULL){
868
if(execv(filename, p->argv) < 0){
873
if(execve(filename, p->argv, p->environ) < 0){
1105
880
/* Parent process */
1106
881
close(pipefd[1]); /* Close unused write end of pipe */
1108
plugin *new_plugin = getplugin(direntries[i]->d_name);
1109
if(new_plugin == NULL){
1110
error(0, errno, "getplugin");
1111
ret = (int)(TEMP_FAILURE_RETRY
1112
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
883
plugin *new_plugin = getplugin(dirst->d_name);
884
if (new_plugin == NULL){
886
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1115
error(0, errno, "sigprocmask");
888
perror("sigprocmask");
1117
exitstatus = EX_OSERR;
1118
free(direntries[i]);
890
exitstatus = EXIT_FAILURE;
1121
free(direntries[i]);
1123
894
new_plugin->pid = pid;
1124
895
new_plugin->fd = pipefd[0];
1127
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1128
new_plugin->name, (intmax_t) (new_plugin->pid));
1131
897
/* Unblock SIGCHLD so signal handler can be run if this process
1132
898
has already completed */
1133
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1134
&sigchld_action.sa_mask,
899
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1137
error(0, errno, "sigprocmask");
1138
exitstatus = EX_OSERR;
901
perror("sigprocmask");
902
exitstatus = EXIT_FAILURE;
1142
906
FD_SET(new_plugin->fd, &rfds_all);
1144
if(maxfd < new_plugin->fd){
908
if (maxfd < new_plugin->fd){
1145
909
maxfd = new_plugin->fd;
1153
free_plugin(getplugin(NULL));
1155
916
for(plugin *p = plugin_list; p != NULL; p = p->next){
1156
917
if(p->pid != 0){
1167
928
while(plugin_list){
1168
929
fd_set rfds = rfds_all;
1169
930
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
1170
if(select_ret == -1 and errno != EINTR){
1171
error(0, errno, "select");
1172
exitstatus = EX_OSERR;
931
if (select_ret == -1){
933
exitstatus = EXIT_FAILURE;
1175
936
/* OK, now either a process completed, or something can be read
1176
937
from one of them */
1177
938
for(plugin *proc = plugin_list; proc != NULL;){
1178
939
/* Is this process completely done? */
1179
if(proc->completed and proc->eof){
940
if(proc->eof and proc->completed){
1180
941
/* Only accept the plugin output if it exited cleanly */
1181
942
if(not WIFEXITED(proc->status)
1182
943
or WEXITSTATUS(proc->status) != 0){
1183
944
/* Bad exit by plugin */
1186
947
if(WIFEXITED(proc->status)){
1187
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1188
" status %d\n", proc->name,
1189
(intmax_t) (proc->pid),
948
fprintf(stderr, "Plugin %u exited with status %d\n",
949
(unsigned int) (proc->pid),
1190
950
WEXITSTATUS(proc->status));
1191
} else if(WIFSIGNALED(proc->status)){
1192
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1193
" signal %d: %s\n", proc->name,
1194
(intmax_t) (proc->pid),
1195
WTERMSIG(proc->status),
1196
strsignal(WTERMSIG(proc->status)));
951
} else if(WIFSIGNALED(proc->status)) {
952
fprintf(stderr, "Plugin %u killed by signal %d\n",
953
(unsigned int) (proc->pid),
954
WTERMSIG(proc->status));
955
} else if(WCOREDUMP(proc->status)){
956
fprintf(stderr, "Plugin %d dumped core\n",
957
(unsigned int) (proc->pid));
1200
961
/* Remove the plugin */
1201
962
FD_CLR(proc->fd, &rfds_all);
1203
964
/* Block signal while modifying process_list */
1204
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1206
&sigchld_action.sa_mask,
965
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1209
error(0, errno, "sigprocmask");
1210
exitstatus = EX_OSERR;
967
perror("sigprocmask");
968
exitstatus = EXIT_FAILURE;