/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to Makefile

  • Committer: Teddy Hogeborn
  • Date: 2024-09-08 05:08:20 UTC
  • mto: This revision was merged to the branch mainline in revision 410.
  • Revision ID: teddy@recompile.se-20240908050820-jpkid6ufjb9n107o
http://bugs.debian.org/1079588
Fix #1079588 by not outputting to stdout in maintainer scripts

From The Debconf Programmer's Tutorial: "Anything your maintainer
scripts output to standard output is passed into the frontend as a
command".  We must make sure to redirect stdout to stderr for every
command in the postinst and postrm scripts which might output to
stdout.

* debian/mandos-client.postinst (update_initramfs): Add "1>&2" to
  invocations of update-initramfs and /etc/kernel/postinst.d/dracut.
  (add_mandos_user): Add "1>&2" to invocations of usermod, groupmod,
  and adduser.
  (create_keys): Add "1>&2" to invocations of mandos-keygen,
  gpg-connect-agent, certtool, and openssl.
  (create_dh_params): Add "1>&2" to invocations of certtool and
  openssl.  Add "--force" option to "rm".
* debian/mandos-client.postrm (update_initramfs): Add "1>&2" to
  invocations of update-initramfs and /etc/kernel/postinst.d/dracut.

Closes: #1079588
Reported-By: Ben Hutchings <ben@decadent.org.uk>

Show diffs side-by-side

added added

removed removed

Lines of Context:
Makefile
29
29
 
30
30
# For info about _FORTIFY_SOURCE, see feature_test_macros(7)
31
31
# and <https://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html>.
32
 
FORTIFY:=-D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIC
 
32
FORTIFY:=-fstack-protector-all -fPIC
 
33
CPPFLAGS+=-D_FORTIFY_SOURCE=3
33
34
LINK_FORTIFY_LD:=-z relro -z now
34
35
LINK_FORTIFY:=
35
36
 
41
42
#COVERAGE=--coverage
42
43
OPTIMIZE:=-Os -fno-strict-aliasing
43
44
LANGUAGE:=-std=gnu11
44
 
FEATURES:=-D_FILE_OFFSET_BITS=64
 
45
CPPFLAGS+=-D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64
45
46
htmldir:=man
46
 
version:=1.8.8
 
47
version:=1.8.16
47
48
SED:=sed
48
49
PKG_CONFIG?=pkg-config
49
50
 
63
64
# DRACUTMODULE:=$(DESTDIR)/usr/lib/dracut/modules.d/90mandos
64
65
# STATEDIR:=$(DESTDIR)/var/lib/mandos
65
66
# LIBDIR:=$(PREFIX)/lib
 
67
# DBUSPOLICYDIR:=$(DESTDIR)/etc/dbus-1/system.d
66
68
##
67
69
 
68
70
## These settings are for a package-type install
83
85
                        break; \
84
86
                fi; \
85
87
        done)
 
88
DBUSPOLICYDIR:=$(DESTDIR)/usr/share/dbus-1/system.d
86
89
##
87
90
 
88
91
SYSTEMD:=$(DESTDIR)$(shell $(PKG_CONFIG) systemd \
96
99
GNUTLS_LIBS:=$(shell $(PKG_CONFIG) --libs gnutls)
97
100
AVAHI_CFLAGS:=$(shell $(PKG_CONFIG) --cflags-only-I avahi-core)
98
101
AVAHI_LIBS:=$(shell $(PKG_CONFIG) --libs avahi-core)
99
 
GPGME_CFLAGS:=$(shell gpgme-config --cflags; getconf LFS_CFLAGS)
100
 
GPGME_LIBS:=$(shell gpgme-config --libs; getconf LFS_LIBS; \
 
102
GPGME_CFLAGS:=$(shell $(PKG_CONFIG) --cflags-only-I gpgme 2>/dev/null \
 
103
        || gpgme-config --cflags; getconf LFS_CFLAGS)
 
104
GPGME_LIBS:=$(shell $(PKG_CONFIG) --libs gpgme 2>/dev/null \
 
105
        || gpgme-config --libs; getconf LFS_LIBS; \
101
106
        getconf LFS_LDFLAGS)
102
107
LIBNL3_CFLAGS:=$(shell $(PKG_CONFIG) --cflags-only-I libnl-route-3.0)
103
108
LIBNL3_LIBS:=$(shell $(PKG_CONFIG) --libs libnl-route-3.0)
106
111
 
107
112
# Do not change these two
108
113
CFLAGS+=$(WARN) $(DEBUG) $(FORTIFY) $(COVERAGE) $(OPTIMIZE) \
109
 
        $(LANGUAGE) $(FEATURES) -DVERSION='"$(version)"'
 
114
        $(LANGUAGE) -DVERSION='"$(version)"'
110
115
LDFLAGS+=-Xlinker --as-needed $(COVERAGE) $(LINK_FORTIFY) $(strip \
111
116
        ) $(foreach flag,$(LINK_FORTIFY_LD),-Xlinker $(flag))
112
117
 
156
161
 
157
162
objects:=$(addsuffix .o,$(CPROGS))
158
163
 
 
164
.PHONY: all
159
165
all: $(PROGS) mandos.lsm
160
166
 
 
167
.PHONY: doc
161
168
doc: $(DOCS)
162
169
 
 
170
.PHONY: html
163
171
html: $(htmldocs)
164
172
 
165
173
%.5: %.xml common.ent legalnotice.xml
282
290
                $@)
283
291
 
284
292
# Need to add the GnuTLS, Avahi and GPGME libraries
285
 
plugins.d/mandos-client: plugins.d/mandos-client.c
286
 
        $(LINK.c) $^ $(GNUTLS_CFLAGS) $(AVAHI_CFLAGS) $(strip\
287
 
                ) $(GPGME_CFLAGS) $(GNUTLS_LIBS) $(strip\
288
 
                ) $(AVAHI_LIBS) $(GPGME_LIBS) $(LOADLIBES) $(strip\
289
 
                ) $(LDLIBS) -o $@
 
293
plugins.d/mandos-client: CFLAGS += $(GNUTLS_CFLAGS) $(strip \
 
294
        ) $(AVAHI_CFLAGS) $(GPGME_CFLAGS)
 
295
plugins.d/mandos-client: LDLIBS += $(GNUTLS_LIBS) $(strip \
 
296
        ) $(AVAHI_LIBS) $(GPGME_LIBS)
290
297
 
291
298
# Need to add the libnl-route library
292
 
plugin-helpers/mandos-client-iprouteadddel: plugin-helpers/mandos-client-iprouteadddel.c
293
 
        $(LINK.c) $(LIBNL3_CFLAGS) $^ $(LIBNL3_LIBS) $(strip\
294
 
                ) $(LOADLIBES) $(LDLIBS) -o $@
 
299
plugin-helpers/mandos-client-iprouteadddel: CFLAGS += $(LIBNL3_CFLAGS)
 
300
plugin-helpers/mandos-client-iprouteadddel: LDLIBS += $(LIBNL3_LIBS)
295
301
 
296
302
# Need to add the GLib and pthread libraries
297
 
dracut-module/password-agent: dracut-module/password-agent.c
298
 
        $(LINK.c) $(GLIB_CFLAGS) $^ $(GLIB_LIBS) -lpthread $(strip\
299
 
                ) $(LOADLIBES) $(LDLIBS) -o $@
300
 
 
301
 
.PHONY : all doc html clean distclean mostlyclean maintainer-clean \
302
 
        check run-client run-server install install-html \
303
 
        install-server install-client-nokey install-client uninstall \
304
 
        uninstall-server uninstall-client purge purge-server \
305
 
        purge-client
306
 
 
 
303
dracut-module/password-agent: CFLAGS += $(GLIB_CFLAGS)
 
304
# Note: -lpthread is unnecessary with the GNU C library 2.34 or later
 
305
dracut-module/password-agent: LDLIBS += $(GLIB_LIBS) -lpthread
 
306
 
 
307
.PHONY: clean
307
308
clean:
308
309
        -rm --force $(CPROGS) $(objects) $(htmldocs) $(DOCS) core
309
310
 
 
311
.PHONY: distclean
310
312
distclean: clean
 
313
.PHONY: mostlyclean
311
314
mostlyclean: clean
 
315
.PHONY: maintainer-clean
312
316
maintainer-clean: clean
313
317
        -rm --force --recursive keydir confdir statedir
314
318
 
 
319
.PHONY: check
315
320
check: all
316
321
        ./mandos --check
317
322
        ./mandos-ctl --check
321
326
        ./dracut-module/password-agent --test
322
327
 
323
328
# Run the client with a local config and key
 
329
.PHONY: run-client
324
330
run-client: all keydir/seckey.txt keydir/pubkey.txt \
325
331
                        keydir/tls-privkey.pem keydir/tls-pubkey.pem
326
332
        @echo '######################################################'
354
360
keydir/seckey.txt keydir/pubkey.txt keydir/tls-privkey.pem keydir/tls-pubkey.pem: mandos-keygen
355
361
        install --directory keydir
356
362
        ./mandos-keygen --dir keydir --force
 
363
        if ! [ -e keydir/tls-privkey.pem ]; then \
 
364
                install --mode=u=rw /dev/null keydir/tls-privkey.pem; \
 
365
        fi
 
366
        if ! [ -e keydir/tls-pubkey.pem ]; then \
 
367
                install --mode=u=rw /dev/null keydir/tls-pubkey.pem; \
 
368
        fi
357
369
 
358
370
# Run the server with a local config
 
371
.PHONY: run-server
359
372
run-server: confdir/mandos.conf confdir/clients.conf statedir
360
373
        ./mandos --debug --no-dbus --configdir=confdir \
361
374
                --statedir=statedir $(SERVERARGS)
372
385
statedir:
373
386
        install --directory statedir
374
387
 
 
388
.PHONY: install
375
389
install: install-server install-client-nokey
376
390
 
 
391
.PHONY: install-html
377
392
install-html: html
378
393
        install --directory $(htmldir)
379
394
        install --mode=u=rw,go=r --target-directory=$(htmldir) \
380
395
                $(htmldocs)
381
396
 
 
397
.PHONY: install-server
382
398
install-server: doc
383
399
        install --directory $(CONFDIR)
384
400
        if install --directory --mode=u=rwx --owner=$(USER) \
407
423
        install --mode=u=rw --target-directory=$(CONFDIR) \
408
424
                clients.conf
409
425
        install --mode=u=rw,go=r dbus-mandos.conf \
410
 
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
 
426
                $(DBUSPOLICYDIR)/mandos.conf
411
427
        install --mode=u=rwx,go=rx init.d-mandos \
412
428
                $(DESTDIR)/etc/init.d/mandos
413
429
        if [ "$(SYSTEMD)" != "$(DESTDIR)" -a -d "$(SYSTEMD)" ]; then \
431
447
        gzip --best --to-stdout intro.8mandos \
432
448
                > $(MANDIR)/man8/intro.8mandos.gz
433
449
 
 
450
.PHONY: install-client-nokey
434
451
install-client-nokey: all doc
435
452
        install --directory $(LIBDIR)/mandos $(CONFDIR)
436
453
        install --directory --mode=u=rwx $(KEYDIR) \
515
532
        gzip --best --to-stdout dracut-module/password-agent.8mandos \
516
533
                > $(MANDIR)/man8/password-agent.8mandos.gz
517
534
 
 
535
.PHONY: install-client
518
536
install-client: install-client-nokey
519
537
# Post-installation stuff
520
538
        -$(PREFIX)/sbin/mandos-keygen --dir "$(KEYDIR)"
530
548
        fi
531
549
        echo "Now run mandos-keygen --password --dir $(KEYDIR)"
532
550
 
 
551
.PHONY: uninstall
533
552
uninstall: uninstall-server uninstall-client
534
553
 
 
554
.PHONY: uninstall-server
535
555
uninstall-server:
536
556
        -rm --force $(PREFIX)/sbin/mandos \
537
557
                $(PREFIX)/sbin/mandos-ctl \
544
564
        update-rc.d -f mandos remove
545
565
        -rmdir $(CONFDIR)
546
566
 
 
567
.PHONY: uninstall-client
547
568
uninstall-client:
548
569
# Refuse to uninstall client if /etc/crypttab is explicitly configured
549
570
# to use it.
585
606
            done; \
586
607
        fi
587
608
 
 
609
.PHONY: purge
588
610
purge: purge-server purge-client
589
611
 
 
612
.PHONY: purge-server
590
613
purge-server: uninstall-server
591
614
        -rm --force $(CONFDIR)/mandos.conf $(CONFDIR)/clients.conf \
592
615
                $(DESTDIR)/etc/dbus-1/system.d/mandos.conf
597
620
                $(DESTDIR)/var/run/mandos.pid
598
621
        -rmdir $(CONFDIR)
599
622
 
 
623
.PHONY: purge-client
600
624
purge-client: uninstall-client
601
625
        -shred --remove $(KEYDIR)/seckey.txt $(KEYDIR)/tls-privkey.pem
602
626
        -rm --force $(CONFDIR)/plugin-runner.conf \