/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to plugins.d/password-prompt.xml

  • Committer: Teddy Hogeborn
  • Date: 2021-02-03 23:10:42 UTC
  • mto: This revision was merged to the branch mainline in revision 406.
  • Revision ID: teddy@recompile.se-20210203231042-2z3egrvpo1zt7nej
mandos-ctl: Fix bad test for command.Remove and related minor issues

The test for command.Remove removes all clients from the spy server,
and then loops over all clients, looking for the corresponding Remove
command as recorded by the spy server.  But since since there aren't
any clients left after they were removed, no assertions are made, and
the test therefore does nothing.  Fix this.

In tests for command.Approve and command.Deny, add checks that clients
were not somehow removed by the command (in which case, likewise, no
assertions are made).

Add related checks to TestPropertySetterCmd.runTest; i.e. test that a
sequence is not empty before looping over it and making assertions.

* mandos-ctl (TestBaseCommands.test_Remove): Save a copy of the
  original "clients" dict, and loop over those instead.  Add assertion
  that all clients were indeed removed.  Also fix the code which looks
  for the Remove command, which now needs to actually work.
  (TestBaseCommands.test_Approve, TestBaseCommands.test_Deny): Add
  assertion that there are still clients before looping over them.
  (TestPropertySetterCmd.runTest): Add assertion that the list of
  values to get is not empty before looping over them.  Also add check
  that there are still clients before looping over clients.

Show diffs side-by-side

added added

removed removed

Lines of Context:
2
2
<!DOCTYPE refentry PUBLIC "-//OASIS//DTD DocBook XML V4.5//EN"
3
3
        "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd" [
4
4
<!ENTITY COMMANDNAME "password-prompt">
5
 
<!ENTITY TIMESTAMP "2016-03-05">
 
5
<!ENTITY TIMESTAMP "2019-07-27">
6
6
<!ENTITY % common SYSTEM "../common.ent">
7
7
%common;
8
8
]>
40
40
      <year>2014</year>
41
41
      <year>2015</year>
42
42
      <year>2016</year>
 
43
      <year>2017</year>
 
44
      <year>2018</year>
 
45
      <year>2019</year>
43
46
      <holder>Teddy Hogeborn</holder>
44
47
      <holder>Björn Påhlsson</holder>
45
48
    </copyright>
66
69
        >PREFIX</replaceable></arg>
67
70
      </group>
68
71
      <sbr/>
 
72
      <arg choice="opt">
 
73
        <option>--prompt <replaceable>PROMPT</replaceable></option>
 
74
      </arg>
69
75
      <arg choice="opt"><option>--debug</option></arg>
70
76
    </cmdsynopsis>
71
77
    <cmdsynopsis>
107
113
      wrapper, although actual use of that function is not guaranteed
108
114
      or implied.
109
115
    </para>
 
116
    <para>
 
117
      This program tries to detect if a Plymouth daemon
 
118
      (<citerefentry><refentrytitle
 
119
      >plymouthd</refentrytitle><manvolnum>8</manvolnum></citerefentry>)
 
120
      is running, by looking for a
 
121
      <filename>/run/plymouth/pid</filename> file or a process named
 
122
      <quote><literal>plymouthd</literal></quote>.  If it is detected,
 
123
      this process will immediately exit without doing anything.
 
124
    </para>
110
125
  </refsect1>
111
126
  
112
127
  <refsect1 id="options">
135
150
      </varlistentry>
136
151
      
137
152
      <varlistentry>
 
153
        <term><option>--prompt=<replaceable
 
154
        >PROMPT</replaceable></option></term>
 
155
        <listitem>
 
156
          <para>
 
157
            The password prompt.  Using this option will make this
 
158
            program ignore the <envar>CRYPTTAB_SOURCE</envar> and
 
159
            <envar>CRYPTTAB_NAME</envar> environment variables.
 
160
          </para>
 
161
        </listitem>
 
162
      </varlistentry>
 
163
      
 
164
      <varlistentry>
138
165
        <term><option>--debug</option></term>
139
166
        <listitem>
140
167
          <para>
194
221
        <term><envar>CRYPTTAB_NAME</envar></term>
195
222
        <listitem>
196
223
          <para>
197
 
            If set, these environment variables will be assumed to
 
224
            If set, and if the <option>--prompt</option> option is not
 
225
            used, these environment variables will be assumed to
198
226
            contain the source device name and the target device
199
227
            mapper name, respectively, and will be shown as part of
200
228
            the prompt.
202
230
        <para>
203
231
          These variables will normally be inherited from
204
232
          <citerefentry><refentrytitle>plugin-runner</refentrytitle>
205
 
          <manvolnum>8mandos</manvolnum></citerefentry>, which will
206
 
          normally have inherited them from
207
 
          <filename>/scripts/local-top/cryptroot</filename> in the
208
 
          initial <acronym>RAM</acronym> disk environment, which will
209
 
          have set them from parsing kernel arguments and
210
 
          <filename>/conf/conf.d/cryptroot</filename> (also in the
211
 
          initial RAM disk environment), which in turn will have been
212
 
          created when the initial RAM disk image was created by
213
 
          <filename
214
 
          >/usr/share/initramfs-tools/hooks/cryptroot</filename>, by
215
 
          extracting the information of the root file system from
216
 
          <filename >/etc/crypttab</filename>.
 
233
          <manvolnum>8mandos</manvolnum></citerefentry>, which might
 
234
          have in turn inherited them from its calling process.
217
235
        </para>
218
236
        <para>
219
237
          This behavior is meant to exactly mirror the behavior of
220
 
          <command>askpass</command>, the default password prompter.
 
238
          <command>askpass</command>, the default password prompter
 
239
          from initramfs-tools.
221
240
        </para>
222
241
        </listitem>
223
242
      </varlistentry>
298
317
    <title>SEE ALSO</title>
299
318
    <para>
300
319
      <citerefentry><refentrytitle>intro</refentrytitle>
301
 
      <manvolnum>8mandos</manvolnum></citerefentry>
302
 
      <citerefentry><refentrytitle>crypttab</refentrytitle>
303
 
      <manvolnum>5</manvolnum></citerefentry>
 
320
      <manvolnum>8mandos</manvolnum></citerefentry>,
304
321
      <citerefentry><refentrytitle>mandos-client</refentrytitle>
305
 
      <manvolnum>8mandos</manvolnum></citerefentry>
 
322
      <manvolnum>8mandos</manvolnum></citerefentry>,
306
323
      <citerefentry><refentrytitle>plugin-runner</refentrytitle>
307
324
      <manvolnum>8mandos</manvolnum></citerefentry>,
 
325
      <citerefentry><refentrytitle>plymouthd</refentrytitle>
 
326
      <manvolnum>8</manvolnum></citerefentry>
308
327
    </para>
309
328
  </refsect1>
310
329
</refentry>