To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/release
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 237.7.785
- compare with another revision
- download diff
- download tarball
- view history from revision 237.7.785
- Committer: Teddy Hogeborn
- Date: 2021-02-03 23:10:42 UTC
- mto: This revision was merged to the branch mainline in revision 406.
- Revision ID: teddy@recompile.se-20210203231042-2z3egrvpo1zt7nej
mandos-ctl: Fix bad test for command.Remove and related minor issues
The test for command.Remove removes all clients from the spy server,
and then loops over all clients, looking for the corresponding Remove
command as recorded by the spy server. But since since there aren't
any clients left after they were removed, no assertions are made, and
the test therefore does nothing. Fix this.
In tests for command.Approve and command.Deny, add checks that clients
were not somehow removed by the command (in which case, likewise, no
assertions are made).
Add related checks to TestPropertySetterCmd.runTest; i.e. test that a
sequence is not empty before looping over it and making assertions.
* mandos-ctl (TestBaseCommands.test_Remove): Save a copy of the
original "clients" dict, and loop over those instead. Add assertion
that all clients were indeed removed. Also fix the code which looks
for the Remove command, which now needs to actually work.
(TestBaseCommands.test_Approve, TestBaseCommands.test_Deny): Add
assertion that there are still clients before looping over them.
(TestPropertySetterCmd.runTest): Add assertion that the list of
values to get is not empty before looping over them. Also add check
that there are still clients before looping over clients.
The test for command.Remove removes all clients from the spy server,
and then loops over all clients, looking for the corresponding Remove
command as recorded by the spy server. But since since there aren't
any clients left after they were removed, no assertions are made, and
the test therefore does nothing. Fix this.
In tests for command.Approve and command.Deny, add checks that clients
were not somehow removed by the command (in which case, likewise, no
assertions are made).
Add related checks to TestPropertySetterCmd.runTest; i.e. test that a
sequence is not empty before looping over it and making assertions.
* mandos-ctl (TestBaseCommands.test_Remove): Save a copy of the
original "clients" dict, and loop over those instead. Add assertion
that all clients were indeed removed. Also fix the code which looks
for the Remove command, which now needs to actually work.
(TestBaseCommands.test_Approve, TestBaseCommands.test_Deny): Add
assertion that there are still clients before looping over them.
(TestPropertySetterCmd.runTest): Add assertion that the list of
values to get is not empty before looping over them. Also add check
that there are still clients before looping over clients.
- files added:
- DBUS-API
- debian/source
- debian/tests
- debian/upstream
- dracut-module
- network-hooks.d
- plugin-helpers
- files removed:
- debian/mandos-client.config
- files renamed:
- mandos-list => mandos-ctl
- files modified:
- .bzrignore
added
removed
plugin-runner.c
1
/* -*- coding: utf-8 -*- */
1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2008 Teddy Hogeborn
6
* Copyright © 2008 Björn Påhlsson
7
*
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
12
*
13
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2021 Teddy Hogeborn
6
* Copyright © 2008-2021 Björn Påhlsson
7
*
8
* This file is part of Mandos.
9
*
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
14
*
15
* Mandos is distributed in the hope that it will be useful, but
14
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
15
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16
18
* General Public License for more details.
17
19
*
18
20
* You should have received a copy of the GNU General Public License
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
21
22
*
22
* Contact the authors at <mandos@fukt.bsnet.se>.
23
* Contact the authors at <mandos@recompile.se>.
23
24
*/
24
25
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
asprintf() */
26
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
27
getline(), asprintf(), O_CLOEXEC,
28
scandirat(), pipe2() */
29
#include <argp.h> /* argp_program_version,
30
argp_program_bug_address,
31
struct argp_option,
32
struct argp_state, argp_error(),
33
ARGP_NO_EXIT, argp_state_help,
34
ARGP_HELP_STD_HELP,
35
ARGP_HELP_USAGE, ARGP_HELP_EXIT_OK,
36
ARGP_KEY_ARG, ARGP_ERR_UNKNOWN,
37
struct argp, argp_parse(),
38
ARGP_IN_ORDER, ARGP_NO_HELP */
39
#include <stdbool.h> /* bool, false, true */
40
#include <sys/types.h> /* pid_t, sig_atomic_t, uid_t, gid_t,
41
getuid(), setgid(), setuid() */
27
42
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
30
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
37
dirfd() */
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
FD_SET(), FD_ISSET(), FD_CLR */
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS() */
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
43
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
52
close() */
43
#include <iso646.h> /* or, and, not */
44
#include <string.h> /* strcmp(), strdup(), strchrnul(),
45
strncmp(), strlen(), strcpy(),
46
strsep(), strchr(), strsignal() */
47
#include <stdlib.h> /* malloc(), free(), reallocarray(),
48
realloc(), EXIT_SUCCESS */
49
#include <errno.h> /* errno, EINTR, ENOMEM, ECHILD,
50
error_t, EINVAL, EMFILE, ENFILE,
51
ENOENT, ESRCH */
52
#include <stdint.h> /* SIZE_MAX */
53
#define _GNU_SOURCE /* strchrnul(), TEMP_FAILURE_RETRY(),
54
getline(), asprintf(), O_CLOEXEC,
55
scandirat(), pipe2() */
56
#include <unistd.h> /* TEMP_FAILURE_RETRY(), ssize_t,
57
write(), STDOUT_FILENO, uid_t,
58
gid_t, getuid(), fchown(), close(),
59
symlink(), setgid(), setuid(),
60
faccessat(), X_OK, pipe(), pipe2(),
61
fork(), _exit(), dup2(), fexecve(),
62
read(), getpass() */
53
63
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
54
FD_CLOEXEC */
55
#include <string.h> /* strsep, strlen(), asprintf() */
56
#include <errno.h> /* errno */
57
#include <argp.h> /* struct argp_option, struct
58
argp_state, struct argp,
59
argp_parse(), ARGP_ERR_UNKNOWN,
60
ARGP_KEY_END, ARGP_KEY_ARG,
61
error_t */
62
#include <signal.h> /* struct sigaction, sigemptyset(),
63
sigaddset(), sigaction(),
64
sigprocmask(), SIG_BLOCK, SIGCHLD,
65
SIG_UNBLOCK, kill() */
66
#include <errno.h> /* errno, EBADF */
64
FD_CLOEXEC, open(), O_RDONLY,
65
O_CLOEXEC, openat() */
66
#include <sys/wait.h> /* waitpid(), WNOHANG, WIFEXITED(),
67
WEXITSTATUS(), WIFSIGNALED(),
68
WTERMSIG(), wait() */
69
#include <error.h> /* error() */
70
#include <stdio.h> /* FILE, fprintf(), fopen(),
71
getline(), fclose(), EOF,
72
asprintf(), stderr */
73
#include <dirent.h> /* struct dirent, scandirat(),
74
alphasort() */
75
#include <sys/stat.h> /* struct stat, fstat(), S_ISDIR(),
76
lstat(), S_ISREG() */
77
#include <sys/select.h> /* fd_set, FD_ZERO(), FD_SETSIZE,
78
FD_SET(), select(), FD_CLR(),
79
FD_ISSET() */
80
#include <signal.h> /* struct sigaction, SA_NOCLDSTOP,
81
sigemptyset(), sigaddset(),
82
SIGCHLD, sigprocmask(), SIG_BLOCK,
83
SIG_UNBLOCK, kill(), SIGTERM */
84
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
85
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
86
#include <inttypes.h> /* intmax_t, strtoimax(), PRIdMAX */
87
#include <fnmatch.h> /* fnmatch(), FNM_FILE_NAME,
88
FNM_PERIOD, FNM_NOMATCH */
67
89
68
90
#define BUFFER_SIZE 256
69
91
70
92
#define PDIR "/lib/mandos/plugins.d"
93
#define PHDIR "/lib/mandos/plugin-helpers"
71
94
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
72
95
73
96
const char *argp_program_version = "plugin-runner " VERSION;
74
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
97
const char *argp_program_bug_address = "<mandos@recompile.se>";
75
98
76
99
typedef struct plugin{
77
100
char *name; /* can be NULL or any plugin name */
80
103
char **environ;
81
104
int envc;
82
105
bool disabled;
83
106
84
107
/* Variables used for running processes*/
85
108
pid_t pid;
86
109
int fd;
88
111
size_t buffer_size;
89
112
size_t buffer_length;
90
113
bool eof;
91
volatile bool completed;
92
volatile int status;
114
volatile sig_atomic_t completed;
115
int status;
93
116
struct plugin *next;
94
117
} plugin;
95
118
97
120
98
121
/* Gets an existing plugin based on name,
99
122
or if none is found, creates a new one */
123
__attribute__((warn_unused_result))
100
124
static plugin *getplugin(char *name){
101
/* Check for exiting plugin with that name */
102
for (plugin *p = plugin_list; p != NULL; p = p->next){
103
if ((p->name == name)
104
or (p->name and name and (strcmp(p->name, name) == 0))){
125
/* Check for existing plugin with that name */
126
for(plugin *p = plugin_list; p != NULL; p = p->next){
127
if((p->name == name)
128
or (p->name and name and (strcmp(p->name, name) == 0))){
105
129
return p;
106
130
}
107
131
}
108
132
/* Create a new plugin */
109
plugin *new_plugin = malloc(sizeof(plugin));
110
if (new_plugin == NULL){
133
plugin *new_plugin = NULL;
134
do {
135
new_plugin = malloc(sizeof(plugin));
136
} while(new_plugin == NULL and errno == EINTR);
137
if(new_plugin == NULL){
111
138
return NULL;
112
139
}
113
140
char *copy_name = NULL;
114
141
if(name != NULL){
115
copy_name = strdup(name);
142
do {
143
copy_name = strdup(name);
144
} while(copy_name == NULL and errno == EINTR);
116
145
if(copy_name == NULL){
146
int e = errno;
147
free(new_plugin);
148
errno = e;
117
149
return NULL;
118
150
}
119
151
}
120
152
121
*new_plugin = (plugin) { .name = copy_name,
122
.argc = 1,
123
.disabled = false,
124
.next = plugin_list };
153
*new_plugin = (plugin){ .name = copy_name,
154
.argc = 1,
155
.disabled = false,
156
.next = plugin_list };
125
157
126
new_plugin->argv = malloc(sizeof(char *) * 2);
127
if (new_plugin->argv == NULL){
158
do {
159
new_plugin->argv = malloc(sizeof(char *) * 2);
160
} while(new_plugin->argv == NULL and errno == EINTR);
161
if(new_plugin->argv == NULL){
162
int e = errno;
128
163
free(copy_name);
129
164
free(new_plugin);
165
errno = e;
130
166
return NULL;
131
167
}
132
168
new_plugin->argv[0] = copy_name;
133
169
new_plugin->argv[1] = NULL;
134
170
135
new_plugin->environ = malloc(sizeof(char *));
171
do {
172
new_plugin->environ = malloc(sizeof(char *));
173
} while(new_plugin->environ == NULL and errno == EINTR);
136
174
if(new_plugin->environ == NULL){
175
int e = errno;
137
176
free(copy_name);
138
177
free(new_plugin->argv);
139
178
free(new_plugin);
179
errno = e;
140
180
return NULL;
141
181
}
142
182
new_plugin->environ[0] = NULL;
147
187
}
148
188
149
189
/* Helper function for add_argument and add_environment */
190
__attribute__((nonnull, warn_unused_result))
150
191
static bool add_to_char_array(const char *new, char ***array,
151
192
int *len){
152
193
/* Resize the pointed-to array to hold one more pointer */
153
*array = realloc(*array, sizeof(char *)
154
* (size_t) ((*len) + 2));
194
char **new_array = NULL;
195
do {
196
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
197
new_array = reallocarray(*array, (size_t)((*len) + 2),
198
sizeof(char *));
199
#else
200
if(((size_t)((*len) + 2)) > (SIZE_MAX / sizeof(char *))){
201
/* overflow */
202
new_array = NULL;
203
errno = ENOMEM;
204
} else {
205
new_array = realloc(*array, (size_t)((*len) + 2)
206
* sizeof(char *));
207
}
208
#endif
209
} while(new_array == NULL and errno == EINTR);
155
210
/* Malloc check */
156
if(*array == NULL){
211
if(new_array == NULL){
157
212
return false;
158
213
}
214
*array = new_array;
159
215
/* Make a copy of the new string */
160
char *copy = strdup(new);
216
char *copy;
217
do {
218
copy = strdup(new);
219
} while(copy == NULL and errno == EINTR);
161
220
if(copy == NULL){
162
221
return false;
163
222
}
170
229
}
171
230
172
231
/* Add to a plugin's argument vector */
232
__attribute__((nonnull(2), warn_unused_result))
173
233
static bool add_argument(plugin *p, const char *arg){
174
234
if(p == NULL){
175
235
return false;
178
238
}
179
239
180
240
/* Add to a plugin's environment */
241
__attribute__((nonnull(2), warn_unused_result))
181
242
static bool add_environment(plugin *p, const char *def, bool replace){
182
243
if(p == NULL){
183
244
return false;
185
246
/* namelen = length of name of environment variable */
186
247
size_t namelen = (size_t)(strchrnul(def, '=') - def);
187
248
/* Search for this environment variable */
188
for(char **e = p->environ; *e != NULL; e++){
189
if(strncmp(*e, def, namelen + 1) == 0){
249
for(char **envdef = p->environ; *envdef != NULL; envdef++){
250
if(strncmp(*envdef, def, namelen + 1) == 0){
190
251
/* It already exists */
191
252
if(replace){
192
char *new = realloc(*e, strlen(def) + 1);
193
if(new == NULL){
253
char *new_envdef;
254
do {
255
new_envdef = realloc(*envdef, strlen(def) + 1);
256
} while(new_envdef == NULL and errno == EINTR);
257
if(new_envdef == NULL){
194
258
return false;
195
259
}
196
*e = new;
197
strcpy(*e, def);
260
*envdef = new_envdef;
261
strcpy(*envdef, def);
198
262
}
199
263
return true;
200
264
}
202
266
return add_to_char_array(def, &(p->environ), &(p->envc));
203
267
}
204
268
269
#ifndef O_CLOEXEC
205
270
/*
206
271
* Based on the example in the GNU LibC manual chapter 13.13 "File
207
272
* Descriptor Flags".
208
* *Note File Descriptor Flags:(libc)Descriptor Flags.
273
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
209
274
*/
275
__attribute__((warn_unused_result))
210
276
static int set_cloexec_flag(int fd){
211
int ret = fcntl(fd, F_GETFD, 0);
277
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
212
278
/* If reading the flags failed, return error indication now. */
213
279
if(ret < 0){
214
280
return ret;
215
281
}
216
282
/* Store modified flag word in the descriptor. */
217
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
283
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
284
ret | FD_CLOEXEC));
218
285
}
286
#endif /* not O_CLOEXEC */
219
287
220
288
221
289
/* Mark processes as completed when they exit, and save their exit
222
290
status. */
223
291
static void handle_sigchld(__attribute__((unused)) int sig){
292
int old_errno = errno;
224
293
while(true){
225
294
plugin *proc = plugin_list;
226
295
int status;
230
299
break;
231
300
}
232
301
if(pid == -1){
233
if (errno != ECHILD){
234
perror("waitpid");
302
if(errno == ECHILD){
303
/* No child processes */
304
break;
235
305
}
236
/* No child processes */
237
break;
306
error(0, errno, "waitpid");
238
307
}
239
308
240
309
/* A child exited, find it in process_list */
246
315
continue;
247
316
}
248
317
proc->status = status;
249
proc->completed = true;
318
proc->completed = 1;
250
319
}
320
errno = old_errno;
251
321
}
252
322
253
323
/* Prints out a password to stdout */
324
__attribute__((nonnull, warn_unused_result))
254
325
static bool print_out_password(const char *buffer, size_t length){
255
326
ssize_t ret;
256
327
for(size_t written = 0; written < length; written += (size_t)ret){
264
335
}
265
336
266
337
/* Removes and free a plugin from the plugin list */
338
__attribute__((nonnull))
267
339
static void free_plugin(plugin *plugin_node){
268
340
269
for(char **arg = plugin_node->argv; *arg != NULL; arg++){
341
for(char **arg = (plugin_node->argv)+1; *arg != NULL; arg++){
270
342
free(*arg);
271
343
}
344
free(plugin_node->name);
272
345
free(plugin_node->argv);
273
346
for(char **env = plugin_node->environ; *env != NULL; env++){
274
347
free(*env);
275
348
}
276
349
free(plugin_node->environ);
277
350
free(plugin_node->buffer);
278
351
279
352
/* Removes the plugin from the singly-linked list */
280
353
if(plugin_node == plugin_list){
281
354
/* First one - simple */
301
374
302
375
int main(int argc, char *argv[]){
303
376
char *plugindir = NULL;
377
char *pluginhelperdir = NULL;
304
378
char *argfile = NULL;
305
379
FILE *conffp;
306
size_t d_name_len;
307
DIR *dir = NULL;
308
struct dirent *dirst;
380
struct dirent **direntries = NULL;
309
381
struct stat st;
310
382
fd_set rfds_all;
311
383
int ret, maxfd = 0;
384
ssize_t sret;
312
385
uid_t uid = 65534;
313
386
gid_t gid = 65534;
314
387
bool debug = false;
318
391
.sa_flags = SA_NOCLDSTOP };
319
392
char **custom_argv = NULL;
320
393
int custom_argc = 0;
394
int dir_fd = -1;
321
395
322
396
/* Establish a signal handler */
323
397
sigemptyset(&sigchld_action.sa_mask);
324
398
ret = sigaddset(&sigchld_action.sa_mask, SIGCHLD);
325
399
if(ret == -1){
326
perror("sigaddset");
327
exitstatus = EXIT_FAILURE;
400
error(0, errno, "sigaddset");
401
exitstatus = EX_OSERR;
328
402
goto fallback;
329
403
}
330
404
ret = sigaction(SIGCHLD, &sigchld_action, &old_sigchld_action);
331
405
if(ret == -1){
332
perror("sigaction");
333
exitstatus = EXIT_FAILURE;
406
error(0, errno, "sigaction");
407
exitstatus = EX_OSERR;
334
408
goto fallback;
335
409
}
336
410
368
442
.doc = "Group ID the plugins will run as", .group = 3 },
369
443
{ .name = "debug", .key = 132,
370
444
.doc = "Debug mode", .group = 4 },
445
{ .name = "plugin-helper-dir", .key = 133,
446
.arg = "DIRECTORY",
447
.doc = "Specify a different plugin helper directory",
448
.group = 2 },
449
/*
450
* These reproduce what we would get without ARGP_NO_HELP
451
*/
452
{ .name = "help", .key = '?',
453
.doc = "Give this help list", .group = -1 },
454
{ .name = "usage", .key = -3,
455
.doc = "Give a short usage message", .group = -1 },
456
{ .name = "version", .key = 'V',
457
.doc = "Print program version", .group = -1 },
371
458
{ .name = NULL }
372
459
};
373
460
374
error_t parse_opt (int key, char *arg, __attribute__((unused))
375
struct argp_state *state) {
376
switch (key) {
461
__attribute__((nonnull(3)))
462
error_t parse_opt(int key, char *arg, struct argp_state *state){
463
errno = 0;
464
switch(key){
465
char *tmp;
466
intmax_t tmp_id;
377
467
case 'g': /* --global-options */
378
if (arg != NULL){
379
char *p;
380
while((p = strsep(&arg, ",")) != NULL){
381
if(p[0] == '\0'){
382
continue;
383
}
384
if(not add_argument(getplugin(NULL), p)){
385
perror("add_argument");
386
return ARGP_ERR_UNKNOWN;
468
{
469
char *plugin_option;
470
while((plugin_option = strsep(&arg, ",")) != NULL){
471
if(not add_argument(getplugin(NULL), plugin_option)){
472
break;
387
473
}
388
474
}
475
errno = 0;
389
476
}
390
477
break;
391
478
case 'G': /* --global-env */
392
if(arg == NULL){
393
break;
394
}
395
if(not add_environment(getplugin(NULL), arg, true)){
396
perror("add_environment");
479
if(add_environment(getplugin(NULL), arg, true)){
480
errno = 0;
397
481
}
398
482
break;
399
483
case 'o': /* --options-for */
400
if (arg != NULL){
401
char *p_name = strsep(&arg, ":");
402
if(p_name[0] == '\0' or arg == NULL){
403
break;
404
}
405
char *opt = strsep(&arg, ":");
406
if(opt[0] == '\0' or opt == NULL){
407
break;
408
}
409
char *p;
410
while((p = strsep(&opt, ",")) != NULL){
411
if(p[0] == '\0'){
412
continue;
413
}
414
if(not add_argument(getplugin(p_name), p)){
415
perror("add_argument");
416
return ARGP_ERR_UNKNOWN;
417
}
418
}
484
{
485
char *option_list = strchr(arg, ':');
486
if(option_list == NULL){
487
argp_error(state, "No colon in \"%s\"", arg);
488
errno = EINVAL;
489
break;
490
}
491
*option_list = '\0';
492
option_list++;
493
if(arg[0] == '\0'){
494
argp_error(state, "Empty plugin name");
495
errno = EINVAL;
496
break;
497
}
498
char *option;
499
while((option = strsep(&option_list, ",")) != NULL){
500
if(not add_argument(getplugin(arg), option)){
501
break;
502
}
503
}
504
errno = 0;
419
505
}
420
506
break;
421
507
case 'E': /* --env-for */
422
if(arg == NULL){
423
break;
424
}
425
508
{
426
509
char *envdef = strchr(arg, ':');
427
510
if(envdef == NULL){
511
argp_error(state, "No colon in \"%s\"", arg);
512
errno = EINVAL;
428
513
break;
429
514
}
430
515
*envdef = '\0';
431
if(not add_environment(getplugin(arg), envdef+1, true)){
432
perror("add_environment");
516
envdef++;
517
if(arg[0] == '\0'){
518
argp_error(state, "Empty plugin name");
519
errno = EINVAL;
520
break;
521
}
522
if(add_environment(getplugin(arg), envdef, true)){
523
errno = 0;
433
524
}
434
525
}
435
526
break;
436
527
case 'd': /* --disable */
437
if (arg != NULL){
528
{
438
529
plugin *p = getplugin(arg);
439
if(p == NULL){
440
return ARGP_ERR_UNKNOWN;
530
if(p != NULL){
531
p->disabled = true;
532
errno = 0;
441
533
}
442
p->disabled = true;
443
534
}
444
535
break;
445
536
case 'e': /* --enable */
446
if (arg != NULL){
537
{
447
538
plugin *p = getplugin(arg);
448
if(p == NULL){
449
return ARGP_ERR_UNKNOWN;
539
if(p != NULL){
540
p->disabled = false;
541
errno = 0;
450
542
}
451
p->disabled = false;
452
543
}
453
544
break;
454
545
case 128: /* --plugin-dir */
455
546
free(plugindir);
456
547
plugindir = strdup(arg);
457
if(plugindir == NULL){
458
perror("strdup");
459
}
548
if(plugindir != NULL){
549
errno = 0;
550
}
460
551
break;
461
552
case 129: /* --config-file */
462
553
/* This is already done by parse_opt_config_file() */
463
554
break;
464
555
case 130: /* --userid */
465
uid = (uid_t)strtol(arg, NULL, 10);
556
tmp_id = strtoimax(arg, &tmp, 10);
557
if(errno != 0 or tmp == arg or *tmp != '\0'
558
or tmp_id != (uid_t)tmp_id){
559
argp_error(state, "Bad user ID number: \"%s\", using %"
560
PRIdMAX, arg, (intmax_t)uid);
561
break;
562
}
563
uid = (uid_t)tmp_id;
564
errno = 0;
466
565
break;
467
566
case 131: /* --groupid */
468
gid = (gid_t)strtol(arg, NULL, 10);
567
tmp_id = strtoimax(arg, &tmp, 10);
568
if(errno != 0 or tmp == arg or *tmp != '\0'
569
or tmp_id != (gid_t)tmp_id){
570
argp_error(state, "Bad group ID number: \"%s\", using %"
571
PRIdMAX, arg, (intmax_t)gid);
572
break;
573
}
574
gid = (gid_t)tmp_id;
575
errno = 0;
469
576
break;
470
577
case 132: /* --debug */
471
578
debug = true;
472
579
break;
580
case 133: /* --plugin-helper-dir */
581
free(pluginhelperdir);
582
pluginhelperdir = strdup(arg);
583
if(pluginhelperdir != NULL){
584
errno = 0;
585
}
586
break;
587
/*
588
* These reproduce what we would get without ARGP_NO_HELP
589
*/
590
case '?': /* --help */
591
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
592
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
593
__builtin_unreachable();
594
case -3: /* --usage */
595
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
596
argp_state_help(state, state->out_stream,
597
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
598
__builtin_unreachable();
599
case 'V': /* --version */
600
fprintf(state->out_stream, "%s\n", argp_program_version);
601
exit(EXIT_SUCCESS);
602
break;
603
/*
604
* When adding more options before this line, remember to also add a
605
* "case" to the "parse_opt_config_file" function below.
606
*/
473
607
case ARGP_KEY_ARG:
474
608
/* Cryptsetup always passes an argument, which is an empty
475
609
string if "none" was specified in /etc/crypttab. So if
476
610
argument was empty, we ignore it silently. */
477
if(arg[0] != '\0'){
478
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
611
if(arg[0] == '\0'){
612
break;
479
613
}
480
break;
481
case ARGP_KEY_END:
482
break;
614
#if __GNUC__ >= 7
615
__attribute__((fallthrough));
616
#else
617
/* FALLTHROUGH */
618
#endif
483
619
default:
484
620
return ARGP_ERR_UNKNOWN;
485
621
}
486
return 0;
622
return errno; /* Set to 0 at start */
487
623
}
488
624
489
625
/* This option parser is the same as parse_opt() above, except it
490
626
ignores everything but the --config-file option. */
491
error_t parse_opt_config_file (int key, char *arg,
492
__attribute__((unused))
493
struct argp_state *state) {
494
switch (key) {
627
error_t parse_opt_config_file(int key, char *arg,
628
__attribute__((unused))
629
struct argp_state *state){
630
errno = 0;
631
switch(key){
495
632
case 'g': /* --global-options */
496
633
case 'G': /* --global-env */
497
634
case 'o': /* --options-for */
503
640
case 129: /* --config-file */
504
641
free(argfile);
505
642
argfile = strdup(arg);
506
if(argfile == NULL){
507
perror("strdup");
643
if(argfile != NULL){
644
errno = 0;
508
645
}
509
break;
646
break;
510
647
case 130: /* --userid */
511
648
case 131: /* --groupid */
512
649
case 132: /* --debug */
650
case 133: /* --plugin-helper-dir */
651
case '?': /* --help */
652
case -3: /* --usage */
653
case 'V': /* --version */
513
654
case ARGP_KEY_ARG:
514
case ARGP_KEY_END:
515
655
break;
516
656
default:
517
657
return ARGP_ERR_UNKNOWN;
518
658
}
519
return 0;
659
return errno;
520
660
}
521
661
522
662
struct argp argp = { .options = options,
524
664
.args_doc = "",
525
665
.doc = "Mandos plugin runner -- Run plugins" };
526
666
527
/* Parse using the parse_opt_config_file in order to get the custom
667
/* Parse using parse_opt_config_file() in order to get the custom
528
668
config file location, if any. */
529
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
530
if (ret == ARGP_ERR_UNKNOWN){
531
fprintf(stderr, "Unknown error while parsing arguments\n");
532
exitstatus = EXIT_FAILURE;
669
ret = argp_parse(&argp, argc, argv,
670
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
671
NULL, NULL);
672
switch(ret){
673
case 0:
674
break;
675
case ENOMEM:
676
default:
677
errno = ret;
678
error(0, errno, "argp_parse");
679
exitstatus = EX_OSERR;
680
goto fallback;
681
case EINVAL:
682
exitstatus = EX_USAGE;
533
683
goto fallback;
534
684
}
535
685
537
687
argp.parser = parse_opt;
538
688
539
689
/* Open the configfile if available */
540
if (argfile == NULL){
690
if(argfile == NULL){
541
691
conffp = fopen(AFILE, "r");
542
692
} else {
543
693
conffp = fopen(argfile, "r");
544
}
694
}
545
695
if(conffp != NULL){
546
696
char *org_line = NULL;
547
697
char *p, *arg, *new_arg, *line;
548
698
size_t size = 0;
549
ssize_t sret;
550
699
const char whitespace_delims[] = " \r\t\f\v\n";
551
700
const char comment_delim[] = "#";
552
701
553
702
custom_argc = 1;
554
703
custom_argv = malloc(sizeof(char*) * 2);
555
704
if(custom_argv == NULL){
556
perror("malloc");
557
exitstatus = EXIT_FAILURE;
705
error(0, errno, "malloc");
706
exitstatus = EX_OSERR;
558
707
goto fallback;
559
708
}
560
709
custom_argv[0] = argv[0];
561
710
custom_argv[1] = NULL;
562
711
563
712
/* for each line in the config file, strip whitespace and ignore
564
713
commented text */
565
714
while(true){
567
716
if(sret == -1){
568
717
break;
569
718
}
570
719
571
720
line = org_line;
572
721
arg = strsep(&line, comment_delim);
573
722
while((p = strsep(&arg, whitespace_delims)) != NULL){
576
725
}
577
726
new_arg = strdup(p);
578
727
if(new_arg == NULL){
579
perror("strdup");
580
exitstatus = EXIT_FAILURE;
728
error(0, errno, "strdup");
729
exitstatus = EX_OSERR;
581
730
free(org_line);
582
731
goto fallback;
583
732
}
584
733
585
734
custom_argc += 1;
586
custom_argv = realloc(custom_argv, sizeof(char *)
587
* ((unsigned int) custom_argc + 1));
588
if(custom_argv == NULL){
589
perror("realloc");
590
exitstatus = EXIT_FAILURE;
591
free(org_line);
592
goto fallback;
735
{
736
#if defined(__GLIBC_PREREQ) and __GLIBC_PREREQ(2, 26)
737
char **new_argv = reallocarray(custom_argv, (size_t)custom_argc + 1,
738
sizeof(char *));
739
#else
740
char **new_argv = NULL;
741
if(((size_t)custom_argc + 1) > (SIZE_MAX / sizeof(char *))){
742
/* overflow */
743
errno = ENOMEM;
744
} else {
745
new_argv = realloc(custom_argv, ((size_t)custom_argc + 1)
746
* sizeof(char *));
747
}
748
#endif
749
if(new_argv == NULL){
750
error(0, errno, "reallocarray");
751
exitstatus = EX_OSERR;
752
free(new_arg);
753
free(org_line);
754
goto fallback;
755
} else {
756
custom_argv = new_argv;
757
}
593
758
}
594
759
custom_argv[custom_argc-1] = new_arg;
595
custom_argv[custom_argc] = NULL;
760
custom_argv[custom_argc] = NULL;
596
761
}
597
762
}
763
do {
764
ret = fclose(conffp);
765
} while(ret == EOF and errno == EINTR);
766
if(ret == EOF){
767
error(0, errno, "fclose");
768
exitstatus = EX_IOERR;
769
goto fallback;
770
}
598
771
free(org_line);
599
772
} else {
600
773
/* Check for harmful errors and go to fallback. Other errors might
601
774
not affect opening plugins */
602
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
603
perror("fopen");
604
exitstatus = EXIT_FAILURE;
775
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
776
error(0, errno, "fopen");
777
exitstatus = EX_OSERR;
605
778
goto fallback;
606
779
}
607
780
}
608
/* If there was any arguments from configuration file,
609
pass them to parser as command arguments */
781
/* If there were any arguments from the configuration file, pass
782
them to parser as command line arguments */
610
783
if(custom_argv != NULL){
611
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
612
0, NULL);
613
if (ret == ARGP_ERR_UNKNOWN){
614
fprintf(stderr, "Unknown error while parsing arguments\n");
615
exitstatus = EXIT_FAILURE;
784
ret = argp_parse(&argp, custom_argc, custom_argv,
785
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
786
NULL, NULL);
787
switch(ret){
788
case 0:
789
break;
790
case ENOMEM:
791
default:
792
errno = ret;
793
error(0, errno, "argp_parse");
794
exitstatus = EX_OSERR;
795
goto fallback;
796
case EINVAL:
797
exitstatus = EX_CONFIG;
616
798
goto fallback;
617
799
}
618
800
}
619
801
620
802
/* Parse actual command line arguments, to let them override the
621
803
config file */
622
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
623
if (ret == ARGP_ERR_UNKNOWN){
624
fprintf(stderr, "Unknown error while parsing arguments\n");
625
exitstatus = EXIT_FAILURE;
626
goto fallback;
804
ret = argp_parse(&argp, argc, argv,
805
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
806
NULL, NULL);
807
switch(ret){
808
case 0:
809
break;
810
case ENOMEM:
811
default:
812
errno = ret;
813
error(0, errno, "argp_parse");
814
exitstatus = EX_OSERR;
815
goto fallback;
816
case EINVAL:
817
exitstatus = EX_USAGE;
818
goto fallback;
819
}
820
821
{
822
char *pluginhelperenv;
823
bool bret = true;
824
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
825
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
826
if(ret != -1){
827
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
828
}
829
if(ret == -1 or not bret){
830
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
831
" environment variable to \"%s\" for all plugins\n",
832
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
833
}
834
if(ret != -1){
835
free(pluginhelperenv);
836
}
627
837
}
628
838
629
839
if(debug){
630
for(plugin *p = plugin_list; p != NULL; p=p->next){
840
for(plugin *p = plugin_list; p != NULL; p = p->next){
631
841
fprintf(stderr, "Plugin: %s has %d arguments\n",
632
842
p->name ? p->name : "Global", p->argc - 1);
633
843
for(char **a = p->argv; *a != NULL; a++){
634
844
fprintf(stderr, "\tArg: %s\n", *a);
635
845
}
636
fprintf(stderr, "...and %u environment variables\n", p->envc);
846
fprintf(stderr, "...and %d environment variables\n", p->envc);
637
847
for(char **a = p->environ; *a != NULL; a++){
638
848
fprintf(stderr, "\t%s\n", *a);
639
849
}
640
850
}
641
851
}
642
852
643
/* Strip permissions down to nobody */
853
if(getuid() == 0){
854
/* Work around Debian bug #633582:
855
<https://bugs.debian.org/633582> */
856
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
857
if(plugindir_fd == -1){
858
if(errno != ENOENT){
859
error(0, errno, "open(\"" PDIR "\")");
860
}
861
} else {
862
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
863
if(ret == -1){
864
error(0, errno, "fstat");
865
} else {
866
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
867
ret = fchown(plugindir_fd, uid, gid);
868
if(ret == -1){
869
error(0, errno, "fchown");
870
}
871
}
872
}
873
close(plugindir_fd);
874
}
875
876
/* Work around Debian bug #981302
877
<https://bugs.debian.org/981302> */
878
if(lstat("/dev/fd", &st) != 0 and errno == ENOENT){
879
ret = symlink("/proc/self/fd", "/dev/fd");
880
if(ret == -1){
881
error(0, errno, "Failed to create /dev/fd symlink");
882
}
883
}
884
}
885
886
/* Lower permissions */
887
ret = setgid(gid);
888
if(ret == -1){
889
error(0, errno, "setgid");
890
}
644
891
ret = setuid(uid);
645
if (ret == -1){
646
perror("setuid");
647
}
648
setgid(gid);
649
if (ret == -1){
650
perror("setgid");
651
}
652
653
if (plugindir == NULL){
654
dir = opendir(PDIR);
655
} else {
656
dir = opendir(plugindir);
657
}
658
659
if(dir == NULL){
660
perror("Could not open plugin dir");
661
exitstatus = EXIT_FAILURE;
662
goto fallback;
663
}
664
665
/* Set the FD_CLOEXEC flag on the directory, if possible */
892
if(ret == -1){
893
error(0, errno, "setuid");
894
}
895
896
/* Open plugin directory with close_on_exec flag */
666
897
{
667
int dir_fd = dirfd(dir);
668
if(dir_fd >= 0){
669
ret = set_cloexec_flag(dir_fd);
670
if(ret < 0){
671
perror("set_cloexec_flag");
672
exitstatus = EXIT_FAILURE;
673
goto fallback;
898
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
899
#ifdef O_CLOEXEC
900
O_CLOEXEC
901
#else /* not O_CLOEXEC */
902
0
903
#endif /* not O_CLOEXEC */
904
);
905
if(dir_fd == -1){
906
error(0, errno, "Could not open plugin dir");
907
exitstatus = EX_UNAVAILABLE;
908
goto fallback;
909
}
910
911
#ifndef O_CLOEXEC
912
/* Set the FD_CLOEXEC flag on the directory */
913
ret = set_cloexec_flag(dir_fd);
914
if(ret < 0){
915
error(0, errno, "set_cloexec_flag");
916
exitstatus = EX_OSERR;
917
goto fallback;
918
}
919
#endif /* O_CLOEXEC */
920
}
921
922
int good_name(const struct dirent * const dirent){
923
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
924
"*.dpkg-old", "*.dpkg-bak",
925
"*.dpkg-divert", NULL };
926
#ifdef __GNUC__
927
#pragma GCC diagnostic push
928
#pragma GCC diagnostic ignored "-Wcast-qual"
929
#endif
930
for(const char **pat = (const char **)patterns;
931
*pat != NULL; pat++){
932
#ifdef __GNUC__
933
#pragma GCC diagnostic pop
934
#endif
935
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
936
!= FNM_NOMATCH){
937
if(debug){
938
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
939
" matching pattern %s\n", dirent->d_name, *pat);
940
}
941
return 0;
674
942
}
675
943
}
944
return 1;
945
}
946
947
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
948
alphasort);
949
if(numplugins == -1){
950
error(0, errno, "Could not scan plugin dir");
951
direntries = NULL;
952
exitstatus = EX_OSERR;
953
goto fallback;
676
954
}
677
955
678
956
FD_ZERO(&rfds_all);
679
957
680
958
/* Read and execute any executable in the plugin directory*/
681
while(true){
682
dirst = readdir(dir);
683
684
/* All directory entries have been processed */
685
if(dirst == NULL){
686
if (errno == EBADF){
687
perror("readdir");
688
exitstatus = EXIT_FAILURE;
689
goto fallback;
690
}
691
break;
692
}
693
694
d_name_len = strlen(dirst->d_name);
695
696
/* Ignore dotfiles, backup files and other junk */
697
{
698
bool bad_name = false;
699
700
const char const *bad_prefixes[] = { ".", "#", NULL };
701
702
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
703
".dpkg-old",
704
".dpkg-bak",
705
".dpkg-divert", NULL };
706
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
707
size_t pre_len = strlen(*pre);
708
if((d_name_len >= pre_len)
709
and strncmp((dirst->d_name), *pre, pre_len) == 0){
710
if(debug){
711
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
712
" with bad prefix %s\n", dirst->d_name, *pre);
713
}
714
bad_name = true;
715
break;
716
}
717
}
718
if(bad_name){
719
continue;
720
}
721
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
722
size_t suf_len = strlen(*suf);
723
if((d_name_len >= suf_len)
724
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
725
== 0)){
726
if(debug){
727
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
728
" with bad suffix %s\n", dirst->d_name, *suf);
729
}
730
bad_name = true;
731
break;
732
}
733
}
734
735
if(bad_name){
736
continue;
737
}
738
}
739
740
char *filename;
741
if(plugindir == NULL){
742
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
743
} else {
744
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
745
}
746
if(ret < 0){
747
perror("asprintf");
748
continue;
749
}
750
751
ret = stat(filename, &st);
752
if (ret == -1){
753
perror("stat");
754
free(filename);
755
continue;
756
}
757
959
for(int i = 0; i < numplugins; i++){
960
961
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
962
if(plugin_fd == -1){
963
error(0, errno, "Could not open plugin");
964
free(direntries[i]);
965
continue;
966
}
967
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
968
if(ret == -1){
969
error(0, errno, "stat");
970
close(plugin_fd);
971
free(direntries[i]);
972
continue;
973
}
974
758
975
/* Ignore non-executable files */
759
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
976
if(not S_ISREG(st.st_mode)
977
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
978
X_OK, 0)) != 0)){
760
979
if(debug){
761
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
762
" with bad type or mode\n", filename);
980
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
981
" with bad type or mode\n",
982
plugindir != NULL ? plugindir : PDIR,
983
direntries[i]->d_name);
763
984
}
764
free(filename);
985
close(plugin_fd);
986
free(direntries[i]);
765
987
continue;
766
988
}
767
989
768
plugin *p = getplugin(dirst->d_name);
990
plugin *p = getplugin(direntries[i]->d_name);
769
991
if(p == NULL){
770
perror("getplugin");
771
free(filename);
992
error(0, errno, "getplugin");
993
close(plugin_fd);
994
free(direntries[i]);
772
995
continue;
773
996
}
774
997
if(p->disabled){
775
998
if(debug){
776
999
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
777
dirst->d_name);
1000
direntries[i]->d_name);
778
1001
}
779
free(filename);
1002
close(plugin_fd);
1003
free(direntries[i]);
780
1004
continue;
781
1005
}
782
1006
{
785
1009
if(g != NULL){
786
1010
for(char **a = g->argv + 1; *a != NULL; a++){
787
1011
if(not add_argument(p, *a)){
788
perror("add_argument");
1012
error(0, errno, "add_argument");
789
1013
}
790
1014
}
791
1015
/* Add global environment variables */
792
1016
for(char **e = g->environ; *e != NULL; e++){
793
1017
if(not add_environment(p, *e, false)){
794
perror("add_environment");
1018
error(0, errno, "add_environment");
795
1019
}
796
1020
}
797
1021
}
798
1022
}
799
/* If this plugin has any environment variables, we will call
800
using execve and need to duplicate the environment from this
801
process, too. */
1023
/* If this plugin has any environment variables, we need to
1024
duplicate the environment from this process, too. */
802
1025
if(p->environ[0] != NULL){
803
1026
for(char **e = environ; *e != NULL; e++){
804
1027
if(not add_environment(p, *e, false)){
805
perror("add_environment");
1028
error(0, errno, "add_environment");
806
1029
}
807
1030
}
808
1031
}
809
1032
810
1033
int pipefd[2];
811
ret = pipe(pipefd);
812
if (ret == -1){
813
perror("pipe");
814
exitstatus = EXIT_FAILURE;
815
goto fallback;
816
}
1034
#ifndef O_CLOEXEC
1035
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
1036
#else /* O_CLOEXEC */
1037
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
1038
#endif /* O_CLOEXEC */
1039
if(ret == -1){
1040
error(0, errno, "pipe");
1041
exitstatus = EX_OSERR;
1042
free(direntries[i]);
1043
goto fallback;
1044
}
1045
if(pipefd[0] >= FD_SETSIZE){
1046
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
1047
FD_SETSIZE);
1048
close(pipefd[0]);
1049
close(pipefd[1]);
1050
exitstatus = EX_OSERR;
1051
free(direntries[i]);
1052
goto fallback;
1053
}
1054
#ifndef O_CLOEXEC
817
1055
/* Ask OS to automatic close the pipe on exec */
818
1056
ret = set_cloexec_flag(pipefd[0]);
819
1057
if(ret < 0){
820
perror("set_cloexec_flag");
821
exitstatus = EXIT_FAILURE;
1058
error(0, errno, "set_cloexec_flag");
1059
close(pipefd[0]);
1060
close(pipefd[1]);
1061
exitstatus = EX_OSERR;
1062
free(direntries[i]);
822
1063
goto fallback;
823
1064
}
824
1065
ret = set_cloexec_flag(pipefd[1]);
825
1066
if(ret < 0){
826
perror("set_cloexec_flag");
827
exitstatus = EXIT_FAILURE;
1067
error(0, errno, "set_cloexec_flag");
1068
close(pipefd[0]);
1069
close(pipefd[1]);
1070
exitstatus = EX_OSERR;
1071
free(direntries[i]);
828
1072
goto fallback;
829
1073
}
1074
#endif /* not O_CLOEXEC */
830
1075
/* Block SIGCHLD until process is safely in process list */
831
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1076
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1077
&sigchld_action.sa_mask,
1078
NULL));
832
1079
if(ret < 0){
833
perror("sigprocmask");
834
exitstatus = EXIT_FAILURE;
1080
error(0, errno, "sigprocmask");
1081
exitstatus = EX_OSERR;
1082
free(direntries[i]);
835
1083
goto fallback;
836
1084
}
837
1085
/* Starting a new process to be watched */
838
pid_t pid = fork();
1086
pid_t pid;
1087
do {
1088
pid = fork();
1089
} while(pid == -1 and errno == EINTR);
839
1090
if(pid == -1){
840
perror("fork");
841
exitstatus = EXIT_FAILURE;
1091
error(0, errno, "fork");
1092
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1093
&sigchld_action.sa_mask, NULL));
1094
close(pipefd[0]);
1095
close(pipefd[1]);
1096
exitstatus = EX_OSERR;
1097
free(direntries[i]);
842
1098
goto fallback;
843
1099
}
844
1100
if(pid == 0){
845
1101
/* this is the child process */
846
1102
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
847
1103
if(ret < 0){
848
perror("sigaction");
849
_exit(EXIT_FAILURE);
1104
error(0, errno, "sigaction");
1105
_exit(EX_OSERR);
850
1106
}
851
1107
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
852
1108
if(ret < 0){
853
perror("sigprocmask");
854
_exit(EXIT_FAILURE);
1109
error(0, errno, "sigprocmask");
1110
_exit(EX_OSERR);
855
1111
}
856
1112
857
1113
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
858
1114
if(ret == -1){
859
perror("dup2");
860
_exit(EXIT_FAILURE);
1115
error(0, errno, "dup2");
1116
_exit(EX_OSERR);
861
1117
}
862
1118
863
if(dirfd(dir) < 0){
864
/* If dir has no file descriptor, we could not set FD_CLOEXEC
865
above and must now close it manually here. */
866
closedir(dir);
867
}
868
if(p->environ[0] == NULL){
869
if(execv(filename, p->argv) < 0){
870
perror("execv");
871
_exit(EXIT_FAILURE);
872
}
873
} else {
874
if(execve(filename, p->argv, p->environ) < 0){
875
perror("execve");
876
_exit(EXIT_FAILURE);
877
}
1119
if(fexecve(plugin_fd, p->argv,
1120
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1121
error(0, errno, "fexecve for %s/%s",
1122
plugindir != NULL ? plugindir : PDIR,
1123
direntries[i]->d_name);
1124
_exit(EX_OSERR);
878
1125
}
879
1126
/* no return */
880
1127
}
881
1128
/* Parent process */
882
1129
close(pipefd[1]); /* Close unused write end of pipe */
883
free(filename);
884
plugin *new_plugin = getplugin(dirst->d_name);
885
if (new_plugin == NULL){
886
perror("getplugin");
887
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1130
close(plugin_fd);
1131
plugin *new_plugin = getplugin(direntries[i]->d_name);
1132
if(new_plugin == NULL){
1133
error(0, errno, "getplugin");
1134
ret = (int)(TEMP_FAILURE_RETRY
1135
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
1136
NULL)));
888
1137
if(ret < 0){
889
perror("sigprocmask");
1138
error(0, errno, "sigprocmask");
890
1139
}
891
exitstatus = EXIT_FAILURE;
1140
exitstatus = EX_OSERR;
1141
free(direntries[i]);
892
1142
goto fallback;
893
1143
}
1144
free(direntries[i]);
894
1145
895
1146
new_plugin->pid = pid;
896
1147
new_plugin->fd = pipefd[0];
897
1148
1149
if(debug){
1150
fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1151
new_plugin->name, (intmax_t) (new_plugin->pid));
1152
}
1153
898
1154
/* Unblock SIGCHLD so signal handler can be run if this process
899
1155
has already completed */
900
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1156
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1157
&sigchld_action.sa_mask,
1158
NULL));
901
1159
if(ret < 0){
902
perror("sigprocmask");
903
exitstatus = EXIT_FAILURE;
1160
error(0, errno, "sigprocmask");
1161
exitstatus = EX_OSERR;
904
1162
goto fallback;
905
1163
}
906
1164
907
1165
FD_SET(new_plugin->fd, &rfds_all);
908
1166
909
if (maxfd < new_plugin->fd){
1167
if(maxfd < new_plugin->fd){
910
1168
maxfd = new_plugin->fd;
911
1169
}
912
1170
}
913
1171
914
closedir(dir);
915
dir = NULL;
1172
free(direntries);
1173
direntries = NULL;
1174
close(dir_fd);
1175
dir_fd = -1;
1176
free_plugin(getplugin(NULL));
916
1177
917
1178
for(plugin *p = plugin_list; p != NULL; p = p->next){
918
1179
if(p->pid != 0){
929
1190
while(plugin_list){
930
1191
fd_set rfds = rfds_all;
931
1192
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
932
if (select_ret == -1){
933
perror("select");
934
exitstatus = EXIT_FAILURE;
1193
if(select_ret == -1 and errno != EINTR){
1194
error(0, errno, "select");
1195
exitstatus = EX_OSERR;
935
1196
goto fallback;
936
1197
}
937
1198
/* OK, now either a process completed, or something can be read
938
1199
from one of them */
939
1200
for(plugin *proc = plugin_list; proc != NULL;){
940
1201
/* Is this process completely done? */
941
if(proc->eof and proc->completed){
1202
if(proc->completed and proc->eof){
942
1203
/* Only accept the plugin output if it exited cleanly */
943
1204
if(not WIFEXITED(proc->status)
944
1205
or WEXITSTATUS(proc->status) != 0){
945
1206
/* Bad exit by plugin */
946
1207
947
1208
if(debug){
948
1209
if(WIFEXITED(proc->status)){
949
fprintf(stderr, "Plugin %u exited with status %d\n",
950
(unsigned int) (proc->pid),
1210
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1211
" status %d\n", proc->name,
1212
(intmax_t) (proc->pid),
951
1213
WEXITSTATUS(proc->status));
952
} else if(WIFSIGNALED(proc->status)) {
953
fprintf(stderr, "Plugin %u killed by signal %d\n",
954
(unsigned int) (proc->pid),
955
WTERMSIG(proc->status));
956
} else if(WCOREDUMP(proc->status)){
957
fprintf(stderr, "Plugin %d dumped core\n",
958
(unsigned int) (proc->pid));
1214
} else if(WIFSIGNALED(proc->status)){
1215
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1216
" signal %d: %s\n", proc->name,
1217
(intmax_t) (proc->pid),
1218
WTERMSIG(proc->status),
1219
strsignal(WTERMSIG(proc->status)));
959
1220
}
960
1221
}
961
1222
962
1223
/* Remove the plugin */
963
1224
FD_CLR(proc->fd, &rfds_all);
964
1225
965
1226
/* Block signal while modifying process_list */
966
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1227
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1228
(SIG_BLOCK,
1229
&sigchld_action.sa_mask,
1230
NULL));
967
1231
if(ret < 0){
968
perror("sigprocmask");
969
exitstatus = EXIT_FAILURE;
1232
error(0, errno, "sigprocmask");
1233
exitstatus = EX_OSERR;
970
1234
goto fallback;
971
1235
}
972
1236
975
1239
proc = next_plugin;
976
1240
977
1241
/* We are done modifying process list, so unblock signal */
978
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,
979
NULL);
1242
ret = (int)(TEMP_FAILURE_RETRY
1243
(sigprocmask(SIG_UNBLOCK,
1244
&sigchld_action.sa_mask, NULL)));
980
1245
if(ret < 0){
981
perror("sigprocmask");
982
exitstatus = EXIT_FAILURE;
1246
error(0, errno, "sigprocmask");
1247
exitstatus = EX_OSERR;
983
1248
goto fallback;
984
1249
}
985
1250
995
1260
bool bret = print_out_password(proc->buffer,
996
1261
proc->buffer_length);
997
1262
if(not bret){
998
perror("print_out_password");
999
exitstatus = EXIT_FAILURE;
1263
error(0, errno, "print_out_password");
1264
exitstatus = EX_IOERR;
1000
1265
}
1001
1266
goto fallback;
1002
1267
}
1009
1274
}
1010
1275
/* Before reading, make the process' data buffer large enough */
1011
1276
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1012
proc->buffer = realloc(proc->buffer, proc->buffer_size
1013
+ (size_t) BUFFER_SIZE);
1014
if (proc->buffer == NULL){
1015
perror("malloc");
1016
exitstatus = EXIT_FAILURE;
1277
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1278
+ (size_t) BUFFER_SIZE);
1279
if(new_buffer == NULL){
1280
error(0, errno, "malloc");
1281
exitstatus = EX_OSERR;
1017
1282
goto fallback;
1018
1283
}
1284
proc->buffer = new_buffer;
1019
1285
proc->buffer_size += BUFFER_SIZE;
1020
1286
}
1021
1287
/* Read from the process */
1022
ret = read(proc->fd, proc->buffer + proc->buffer_length,
1023
BUFFER_SIZE);
1024
if(ret < 0){
1288
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1289
proc->buffer
1290
+ proc->buffer_length,
1291
BUFFER_SIZE));
1292
if(sret < 0){
1025
1293
/* Read error from this process; ignore the error */
1026
1294
proc = proc->next;
1027
1295
continue;
1028
1296
}
1029
if(ret == 0){
1297
if(sret == 0){
1030
1298
/* got EOF */
1031
1299
proc->eof = true;
1032
1300
} else {
1033
proc->buffer_length += (size_t) ret;
1301
proc->buffer_length += (size_t) sret;
1034
1302
}
1035
1303
}
1036
1304
}
1037
1038
1305
1306
1039
1307
fallback:
1040
1308
1041
if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
1309
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1310
and exitstatus != EX_OK)){
1042
1311
/* Fallback if all plugins failed, none are found or an error
1043
1312
occured */
1044
1313
bool bret;
1052
1321
}
1053
1322
bret = print_out_password(passwordbuffer, len);
1054
1323
if(not bret){
1055
perror("print_out_password");
1056
exitstatus = EXIT_FAILURE;
1324
error(0, errno, "print_out_password");
1325
exitstatus = EX_IOERR;
1057
1326
}
1058
1327
}
1059
1328
1060
1329
/* Restore old signal handler */
1061
1330
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1062
1331
if(ret == -1){
1063
perror("sigaction");
1064
exitstatus = EXIT_FAILURE;
1332
error(0, errno, "sigaction");
1333
exitstatus = EX_OSERR;
1065
1334
}
1066
1335
1067
1336
if(custom_argv != NULL){
1071
1340
free(custom_argv);
1072
1341
}
1073
1342
1074
if(dir != NULL){
1075
closedir(dir);
1343
free(direntries);
1344
1345
if(dir_fd != -1){
1346
close(dir_fd);
1076
1347
}
1077
1348
1078
1349
/* Kill the processes */
1082
1353
ret = kill(p->pid, SIGTERM);
1083
1354
if(ret == -1 and errno != ESRCH){
1084
1355
/* Set-uid proccesses might not get closed */
1085
perror("kill");
1356
error(0, errno, "kill");
1086
1357
}
1087
1358
}
1088
1359
}
1089
1360
1090
1361
/* Wait for any remaining child processes to terminate */
1091
do{
1362
do {
1092
1363
ret = wait(NULL);
1093
1364
} while(ret >= 0);
1094
1365
if(errno != ECHILD){
1095
perror("wait");
1366
error(0, errno, "wait");
1096
1367
}
1097
1368
1098
1369
free_plugin_list();
1099
1370
1100
1371
free(plugindir);
1372
free(pluginhelperdir);
1101
1373
free(argfile);
1102
1374
1103
1375
return exitstatus;
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0