/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to debian/tests/control

  • Committer: teddy at recompile
  • Date: 2020-12-03 20:30:45 UTC
  • mto: This revision was merged to the branch mainline in revision 404.
  • Revision ID: teddy@recompile.se-20201203203045-iqd6nq9y5nwalh1x
Minor fix of a test function

In dracut-module/password-agent, the test function
test_send_password_to_socket_EMSGSIZE() (which tests that the
send_password_to_socket() task function aborts properly when getting
EMSGSIZE when writing to the password socket), part of the test code
is supposed to find a message size which definitely does trigger
EMSGSIZE when send()ing to a socket.  Without a "break" in the proper
place, however, the size given is always exactly 1024 bytes too large.

This is very probably not a problem, since a too large message will
still be too large if it is increased by 1024 bytes, and send(2) in
practice checks the size before reading the buffer.  The biggest issue
would be if some version of send(2) would try to look at the last 1024
bytes of the message buffer before checking the message size; this
would then lead to a buffer over-read when running this test function.
(But even then there would be no security implications since the tests
are not run in the normal operation of the program.)

* dracut-module/password-agent.c
  (test_send_password_to_socket_EMSGSIZE): Break out early when ssret
  < 0 and errno == EMSGSIZE; don't allow loop to increase message_size
  again.

Show diffs side-by-side

added added

removed removed

Lines of Context:
 
1
Test-Command: /usr/sbin/mandos --check
 
2
Restrictions: superficial, allow-stderr
 
3
Features: test-name=mandos-check
 
4
Depends: mandos
 
5
 
 
6
Test-Command: /usr/sbin/mandos-ctl --check --verbose
 
7
Restrictions: allow-stderr
 
8
Features: test-name=mandos-ctl
 
9
Depends: mandos
 
10
 
 
11
Test-Command: /usr/sbin/mandos-keygen --version
 
12
Restrictions: superficial
 
13
Features: test-name=mandos-keygen-version
 
14
Depends: mandos-client
 
15
 
 
16
Test-Command: /usr/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH 2>/dev/null)/mandos/plugin-runner --version
 
17
Restrictions: needs-root, superficial
 
18
Features: test-name=plugin-runner-version
 
19
Depends: mandos-client
 
20
 
 
21
Test-Command: /usr/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH 2>/dev/null)/mandos/plugin-helpers/mandos-client-iprouteadddel --version
 
22
Restrictions: needs-root, superficial
 
23
Features: test-name=mandos-client-iprouteadddel-version
 
24
Depends: mandos-client
 
25
 
 
26
Test-Command: /usr/lib/dracut/modules.d/90mandos/password-agent --test --verbose
 
27
Features: test-name=password-agent
 
28
Depends: mandos-client
 
29
 
 
30
Test-Command: /usr/lib/dracut/modules.d/90mandos/password-agent --test --verbose -p /task-creators/start_mandos_client/suid
 
31
Restrictions: needs-root
 
32
Features: test-name=password-agent-suid
 
33
Depends: mandos-client