/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to debian/rules

  • Committer: teddy at recompile
  • Date: 2020-12-03 20:30:45 UTC
  • mto: This revision was merged to the branch mainline in revision 404.
  • Revision ID: teddy@recompile.se-20201203203045-iqd6nq9y5nwalh1x
Minor fix of a test function

In dracut-module/password-agent, the test function
test_send_password_to_socket_EMSGSIZE() (which tests that the
send_password_to_socket() task function aborts properly when getting
EMSGSIZE when writing to the password socket), part of the test code
is supposed to find a message size which definitely does trigger
EMSGSIZE when send()ing to a socket.  Without a "break" in the proper
place, however, the size given is always exactly 1024 bytes too large.

This is very probably not a problem, since a too large message will
still be too large if it is increased by 1024 bytes, and send(2) in
practice checks the size before reading the buffer.  The biggest issue
would be if some version of send(2) would try to look at the last 1024
bytes of the message buffer before checking the message size; this
would then lead to a buffer over-read when running this test function.
(But even then there would be no security implications since the tests
are not run in the normal operation of the program.)

* dracut-module/password-agent.c
  (test_send_password_to_socket_EMSGSIZE): Break out early when ssret
  < 0 and errno == EMSGSIZE; don't allow loop to increase message_size
  again.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
1
#!/usr/bin/make -f
 
2
 
 
3
ifeq (,$(filter noopt,$(DEB_BUILD_OPTIONS)))
 
4
    MAKEFLAGS += OPTIMIZE=-O0
 
5
endif
 
6
 
 
7
ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
 
8
    NUMJOBS = $(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
 
9
    MAKEFLAGS += -j$(NUMJOBS)
 
10
endif
 
11
 
2
12
%:
3
13
        dh $@
4
14
 
22
32
override_dh_fixperms-arch:
23
33
        dh_fixperms --exclude etc/keys/mandos \
24
34
                --exclude etc/mandos/plugins.d \
25
 
                --exclude usr/lib/$(shell dpkg-architecture -qDEB_HOST_MULTIARCH 2>/dev/null)/mandos/plugins.d \
 
35
                --exclude etc/mandos/plugin-helpers \
 
36
                --exclude usr/lib/$(DEB_HOST_MULTIARCH)/mandos/plugins.d \
 
37
                --exclude usr/lib/$(DEB_HOST_MULTIARCH)/mandos/plugin-helpers \
26
38
                --exclude usr/share/doc/mandos-client/examples/network-hooks.d
27
39
        chmod --recursive g-w -- \
28
40
        "$(CURDIR)/debian/mandos-client/usr/share/doc/mandos-client/examples/network-hooks.d"
31
43
        dh_fixperms --exclude etc/mandos/clients.conf
32
44
 
33
45
override_dh_auto_test-arch: ;
 
46
 
 
47
#bpo## dpkg-shlibdeps sees the "libgnutls28-dev (>= 3.6.6) |
 
48
#bpo## libgnutls28-dev (<< 3.6.0)," in the build-dependencies not as two
 
49
#bpo## alternatives, but as an absolute dependency on libgnutls30 >= 3.6.6.
 
50
#bpo## So we have to do this ugly hack to hide this build dependency if we
 
51
#bpo## compiled with libgnutls30 << 3.6.0.
 
52
#bpo#override_dh_shlibdeps-arch:
 
53
#bpo#   -gnutls_version=$$(dpkg-query --showformat='$${Version}' \
 
54
#bpo#           --show libgnutls30); \
 
55
#bpo#   dpkg --compare-versions $$gnutls_version lt 3.6.0 \
 
56
#bpo#           && { cp --archive debian/control debian/control.orig; sed --in-place --expression='s/libgnutls28-dev (>= 3\.6\.6) |//' debian/control; }
 
57
#bpo#   dh_shlibdeps
 
58
#bpo#   -gnutls_version=$$(dpkg-query --showformat='$${Version}' \
 
59
#bpo#           --show libgnutls30); \
 
60
#bpo#   dpkg --compare-versions $$gnutls_version lt 3.6.0 \
 
61
#bpo#           && mv debian/control.orig debian/control