Fix bug in server Debian package: Fails to start on first install
There has been a very long-standing bug where installation of the server (the "mandos" Debian package) would fail to start the server properly right after installation. It would work on manual (re)start after installation, or after reboot, and even after package purge and reinstall, it would then work the first time. The problem, it turns out, is when the new "_mandos" user (and corresponding group) is created, the D-Bus server is not reloaded, and is therefore not aware of that user, and does not recognize the user and group name in the /etc/dbus-1/system.d/mandos.conf file. The Mandos server, when it tries to start and access the D-Bus, is then not permitted to connect to its D-Bus bus name, and disables D-Bus use as a fallback measure; i.e. the server works, but it is not controllable via D-Bus commands (via mandos-ctl or mandos-monitor). The next time the D-Bus daemon is reloaded for any reason, the new user & group would become visible to the D-Bus daemon and after that, any restart of the Mandos server would succeed and it would bind to its D-Bus name properly, and thereby be visible and controllable by mandos-ctl & mandos-monitor. This was mostly invisible when using sysvinit, but systemd makes the problem visible since the systemd service file for the Mandos server is configured to not consider the Mandos server "started" until the D-Bus name has been bound; this makes the starting of the service wait for 90 seconds and then fail with a timeout error.
Fixing this should also make the Debian CI autopkgtest tests work.
* debian/mandos.postinst (configure): After creating (or renaming) user & group, reload D-Bus daemon (if present).
# Reload D-Bus daemon to be aware of the _mandos user & group
54
if [ -x /etc/init.d/dbus ]; then
55
invoke-rc.d dbus force-reload || :
56
fi
51
57
if ! dpkg-statoverride --list "/var/lib/mandos" >/dev/null \
52
58
2>&1; then
53
59
chown _mandos:_mandos /var/lib/mandos
54
60
chmod u=rwx,go= /var/lib/mandos
55
61
fi
62
63
if dpkg --compare-versions "$2" eq "1.8.0-1" \
64
|| dpkg --compare-versions "$2" eq "1.8.0-1~bpo9+1"; then
65
if grep --quiet --regexp='^[[:space:]]*key_id[[:space:]]*=[[:space:]]*[Ee]3[Bb]0[Cc]44298[Ff][Cc]1[Cc]149[Aa][Ff][Bb][Ff]4[Cc]8996[Ff][Bb]92427[Aa][Ee]41[Ee]4649[Bb]934[Cc][Aa]495991[Bb]7852[Bb]855[[:space:]]*$' /etc/mandos/clients.conf; then