78
79
dbus.OBJECT_MANAGER_IFACE = "org.freedesktop.DBus.ObjectManager"
81
def milliseconds_to_string(ms):
82
td = datetime.timedelta(0, 0, 0, ms)
83
return ("{days}{hours:02}:{minutes:02}:{seconds:02}"
84
.format(days="{}T".format(td.days) if td.days else "",
85
hours=td.seconds // 3600,
86
minutes=(td.seconds % 3600) // 60,
87
seconds=td.seconds % 60))
83
parser = argparse.ArgumentParser()
85
add_command_line_options(parser)
87
options = parser.parse_args()
89
check_option_syntax(parser, options)
91
clientnames = options.client
94
log.setLevel(logging.DEBUG)
96
bus = dbus.SystemBus()
98
mandos_dbus_object = get_mandos_dbus_object(bus)
100
mandos_serv = dbus.Interface(
101
mandos_dbus_object, dbus_interface=server_dbus_interface)
102
mandos_serv_object_manager = dbus.Interface(
103
mandos_dbus_object, dbus_interface=dbus.OBJECT_MANAGER_IFACE)
105
managed_objects = get_managed_objects(mandos_serv_object_manager)
108
for path, ifs_and_props in managed_objects.items():
110
all_clients[path] = ifs_and_props[client_dbus_interface]
114
# Compile dict of (clientpath: properties) to process
116
clients = all_clients
119
for name in clientnames:
120
for objpath, properties in all_clients.items():
121
if properties["Name"] == name:
122
clients[objpath] = properties
125
log.critical("Client not found on server: %r", name)
128
commands = commands_from_options(options)
130
for command in commands:
131
command.run(clients, bus, mandos_serv)
134
def add_command_line_options(parser):
135
parser.add_argument("--version", action="version",
136
version="%(prog)s {}".format(version),
137
help="show version number and exit")
138
parser.add_argument("-a", "--all", action="store_true",
139
help="Select all clients")
140
parser.add_argument("-v", "--verbose", action="store_true",
141
help="Print all fields")
142
parser.add_argument("-j", "--dump-json", action="store_true",
143
help="Dump client data in JSON format")
144
enable_disable = parser.add_mutually_exclusive_group()
145
enable_disable.add_argument("-e", "--enable", action="store_true",
146
help="Enable client")
147
enable_disable.add_argument("-d", "--disable",
149
help="disable client")
150
parser.add_argument("-b", "--bump-timeout", action="store_true",
151
help="Bump timeout for client")
152
start_stop_checker = parser.add_mutually_exclusive_group()
153
start_stop_checker.add_argument("--start-checker",
155
help="Start checker for client")
156
start_stop_checker.add_argument("--stop-checker",
158
help="Stop checker for client")
159
parser.add_argument("-V", "--is-enabled", action="store_true",
160
help="Check if client is enabled")
161
parser.add_argument("-r", "--remove", action="store_true",
162
help="Remove client")
163
parser.add_argument("-c", "--checker",
164
help="Set checker command for client")
165
parser.add_argument("-t", "--timeout", type=string_to_delta,
166
help="Set timeout for client")
167
parser.add_argument("--extended-timeout", type=string_to_delta,
168
help="Set extended timeout for client")
169
parser.add_argument("-i", "--interval", type=string_to_delta,
170
help="Set checker interval for client")
171
approve_deny_default = parser.add_mutually_exclusive_group()
172
approve_deny_default.add_argument(
173
"--approve-by-default", action="store_true",
174
default=None, dest="approved_by_default",
175
help="Set client to be approved by default")
176
approve_deny_default.add_argument(
177
"--deny-by-default", action="store_false",
178
dest="approved_by_default",
179
help="Set client to be denied by default")
180
parser.add_argument("--approval-delay", type=string_to_delta,
181
help="Set delay before client approve/deny")
182
parser.add_argument("--approval-duration", type=string_to_delta,
183
help="Set duration of one client approval")
184
parser.add_argument("-H", "--host", help="Set host for client")
185
parser.add_argument("-s", "--secret",
186
type=argparse.FileType(mode="rb"),
187
help="Set password blob (file) for client")
188
approve_deny = parser.add_mutually_exclusive_group()
189
approve_deny.add_argument(
190
"-A", "--approve", action="store_true",
191
help="Approve any current client request")
192
approve_deny.add_argument("-D", "--deny", action="store_true",
193
help="Deny any current client request")
194
parser.add_argument("--debug", action="store_true",
195
help="Debug mode (show D-Bus commands)")
196
parser.add_argument("--check", action="store_true",
197
help="Run self-test")
198
parser.add_argument("client", nargs="*", help="Client name")
201
def string_to_delta(interval):
202
"""Parse a string and return a datetime.timedelta"""
205
return rfc3339_duration_to_delta(interval)
206
except ValueError as e:
207
log.warning("%s - Parsing as pre-1.6.1 interval instead",
209
return parse_pre_1_6_1_interval(interval)
90
212
def rfc3339_duration_to_delta(duration):
274
## Classes for commands.
276
# Abstract classes first
277
class Command(object):
278
"""Abstract class for commands"""
279
def run(self, mandos, mandos_objmgr, clients):
280
"""Normal commands should implement run_on_one_client(), but
281
commands which want to operate on all clients at the same time
282
can override this run() method instead."""
284
for client, properties in clients.items():
285
self.run_on_one_client(client, properties)
287
class PrintCmd(Command):
288
"""Abstract class for commands printing client details"""
289
all_keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK",
290
"Created", "Interval", "Host", "KeyID",
291
"Fingerprint", "CheckerRunning", "LastEnabled",
292
"ApprovalPending", "ApprovedByDefault",
293
"LastApprovalRequest", "ApprovalDelay",
294
"ApprovalDuration", "Checker", "ExtendedTimeout",
295
"Expires", "LastCheckerStatus")
296
def run(self, mandos, mandos_objmgr, clients):
297
print(self.output(mandos_objmgr, clients.values()))
299
class PropertyCmd(Command):
300
"""Abstract class for Actions for setting one client property"""
301
def run_on_one_client(self, client, properties):
302
"""Set the Client's D-Bus property"""
303
log.debug("D-Bus: %s:%s:%s.Set(%r, %r, %r)", busname,
304
client.__dbus_object_path__,
305
dbus.PROPERTIES_IFACE, client_interface,
306
self.property, self.value_to_set
307
if not isinstance(self.value_to_set, dbus.Boolean)
308
else bool(self.value_to_set))
309
client.Set(client_interface, self.property, self.value_to_set,
310
dbus_interface=dbus.PROPERTIES_IFACE)
312
class ValueArgumentMixIn(object):
313
"""Mixin class for commands taking a value as argument"""
314
def __init__(self, value):
315
self.value_to_set = value
317
class MillisecondsValueArgumentMixIn(ValueArgumentMixIn):
318
"""Mixin class for commands taking a value argument as
321
def value_to_set(self):
324
def value_to_set(self, value):
325
"""When setting, convert value to a datetime.timedelta"""
326
self._vts = int(round(value.total_seconds() * 1000))
328
# Actual (non-abstract) command classes
330
class PrintTableCmd(PrintCmd):
331
def __init__(self, verbose=False):
332
self.verbose = verbose
334
def output(self, mandos_objmgr, clients):
335
default_keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
336
keywords = default_keywords
338
keywords = self.all_keywords
339
return str(self.TableOfClients(clients, keywords))
341
class TableOfClients(object):
344
"Enabled": "Enabled",
345
"Timeout": "Timeout",
346
"LastCheckedOK": "Last Successful Check",
347
"LastApprovalRequest": "Last Approval Request",
348
"Created": "Created",
349
"Interval": "Interval",
351
"Fingerprint": "Fingerprint",
353
"CheckerRunning": "Check Is Running",
354
"LastEnabled": "Last Enabled",
355
"ApprovalPending": "Approval Is Pending",
356
"ApprovedByDefault": "Approved By Default",
357
"ApprovalDelay": "Approval Delay",
358
"ApprovalDuration": "Approval Duration",
359
"Checker": "Checker",
360
"ExtendedTimeout": "Extended Timeout",
361
"Expires": "Expires",
362
"LastCheckerStatus": "Last Checker Status",
365
def __init__(self, clients, keywords, tableheaders=None):
366
self.clients = clients
367
self.keywords = keywords
368
if tableheaders is not None:
369
self.tableheaders = tableheaders
372
return "\n".join(self.rows())
374
if sys.version_info.major == 2:
375
__unicode__ = __str__
377
return str(self).encode(locale.getpreferredencoding())
380
format_string = self.row_formatting_string()
381
rows = [self.header_line(format_string)]
382
rows.extend(self.client_line(client, format_string)
383
for client in self.clients)
386
def row_formatting_string(self):
387
"Format string used to format table rows"
388
return " ".join("{{{key}:{width}}}".format(
389
width=max(len(self.tableheaders[key]),
390
*(len(self.string_from_client(client, key))
391
for client in self.clients)),
393
for key in self.keywords)
395
def string_from_client(self, client, key):
396
return self.valuetostring(client[key], key)
399
def valuetostring(value, keyword):
400
if isinstance(value, dbus.Boolean):
401
return "Yes" if value else "No"
402
if keyword in ("Timeout", "Interval", "ApprovalDelay",
403
"ApprovalDuration", "ExtendedTimeout"):
404
return milliseconds_to_string(value)
407
def header_line(self, format_string):
408
return format_string.format(**self.tableheaders)
410
def client_line(self, client, format_string):
411
return format_string.format(
412
**{key: self.string_from_client(client, key)
413
for key in self.keywords})
417
class DumpJSONCmd(PrintCmd):
418
def output(self, mandos_objmgr, clients):
419
data = {client["Name"]:
420
{key: self.dbus_boolean_to_bool(client[key])
421
for key in self.all_keywords}
422
for client in clients.values()}
423
return json.dumps(data, indent=4, separators=(',', ': '))
425
def dbus_boolean_to_bool(value):
426
if isinstance(value, dbus.Boolean):
430
class IsEnabledCmd(Command):
431
def run_on_one_client(self, client, properties):
432
if self.is_enabled(client, properties):
435
def is_enabled(self, client, properties):
436
log.debug("D-Bus: %s:%s:%s.Get(%r, %r)", busname,
437
client.__dbus_object_path__,
438
dbus.PROPERTIES_IFACE, client_interface,
440
return bool(client.Get(client_interface, "Enabled",
441
dbus_interface=dbus.PROPERTIES_IFACE))
443
class RemoveCmd(Command):
444
def run_on_one_client(self, client, properties):
445
log.debug("D-Bus: %s:%s:%s.RemoveClient(%r)", busname,
446
server_path, server_interface,
447
str(client.__dbus_object_path__))
448
self.mandos.RemoveClient(client.__dbus_object_path__)
450
class ApproveCmd(Command):
451
def run_on_one_client(self, client, properties):
452
log.debug("D-Bus: %s:%s.Approve(True)",
453
client.__dbus_object_path__, client_interface)
454
client.Approve(dbus.Boolean(True),
455
dbus_interface=client_interface)
457
class DenyCmd(Command):
458
def run_on_one_client(self, client, properties):
459
log.debug("D-Bus: %s:%s.Approve(False)",
460
client.__dbus_object_path__, client_interface)
461
client.Approve(dbus.Boolean(False),
462
dbus_interface=client_interface)
464
class EnableCmd(PropertyCmd):
466
value_to_set = dbus.Boolean(True)
468
class DisableCmd(PropertyCmd):
470
value_to_set = dbus.Boolean(False)
472
class BumpTimeoutCmd(PropertyCmd):
473
property = "LastCheckedOK"
476
class StartCheckerCmd(PropertyCmd):
477
property = "CheckerRunning"
478
value_to_set = dbus.Boolean(True)
480
class StopCheckerCmd(PropertyCmd):
481
property = "CheckerRunning"
482
value_to_set = dbus.Boolean(False)
484
class ApproveByDefaultCmd(PropertyCmd):
485
property = "ApprovedByDefault"
486
value_to_set = dbus.Boolean(True)
488
class DenyByDefaultCmd(PropertyCmd):
489
property = "ApprovedByDefault"
490
value_to_set = dbus.Boolean(False)
492
class SetCheckerCmd(PropertyCmd, ValueArgumentMixIn):
495
class SetHostCmd(PropertyCmd, ValueArgumentMixIn):
498
class SetSecretCmd(PropertyCmd, ValueArgumentMixIn):
500
def value_to_set(self):
503
def value_to_set(self, value):
504
"""When setting, read data from supplied file object"""
505
self._vts = value.read()
509
class SetTimeoutCmd(PropertyCmd, MillisecondsValueArgumentMixIn):
512
class SetExtendedTimeoutCmd(PropertyCmd,
513
MillisecondsValueArgumentMixIn):
514
property = "ExtendedTimeout"
516
class SetIntervalCmd(PropertyCmd, MillisecondsValueArgumentMixIn):
517
property = "Interval"
519
class SetApprovalDelayCmd(PropertyCmd,
520
MillisecondsValueArgumentMixIn):
521
property = "ApprovalDelay"
523
class SetApprovalDurationCmd(PropertyCmd,
524
MillisecondsValueArgumentMixIn):
525
property = "ApprovalDuration"
527
def add_command_line_options(parser):
528
parser.add_argument("--version", action="version",
529
version="%(prog)s {}".format(version),
530
help="show version number and exit")
531
parser.add_argument("-a", "--all", action="store_true",
532
help="Select all clients")
533
parser.add_argument("-v", "--verbose", action="store_true",
534
help="Print all fields")
535
parser.add_argument("-j", "--dump-json", action="store_true",
536
help="Dump client data in JSON format")
537
enable_disable = parser.add_mutually_exclusive_group()
538
enable_disable.add_argument("-e", "--enable", action="store_true",
539
help="Enable client")
540
enable_disable.add_argument("-d", "--disable",
542
help="disable client")
543
parser.add_argument("-b", "--bump-timeout", action="store_true",
544
help="Bump timeout for client")
545
start_stop_checker = parser.add_mutually_exclusive_group()
546
start_stop_checker.add_argument("--start-checker",
548
help="Start checker for client")
549
start_stop_checker.add_argument("--stop-checker",
551
help="Stop checker for client")
552
parser.add_argument("-V", "--is-enabled", action="store_true",
553
help="Check if client is enabled")
554
parser.add_argument("-r", "--remove", action="store_true",
555
help="Remove client")
556
parser.add_argument("-c", "--checker",
557
help="Set checker command for client")
558
parser.add_argument("-t", "--timeout", type=string_to_delta,
559
help="Set timeout for client")
560
parser.add_argument("--extended-timeout", type=string_to_delta,
561
help="Set extended timeout for client")
562
parser.add_argument("-i", "--interval", type=string_to_delta,
563
help="Set checker interval for client")
564
approve_deny_default = parser.add_mutually_exclusive_group()
565
approve_deny_default.add_argument(
566
"--approve-by-default", action="store_true",
567
default=None, dest="approved_by_default",
568
help="Set client to be approved by default")
569
approve_deny_default.add_argument(
570
"--deny-by-default", action="store_false",
571
dest="approved_by_default",
572
help="Set client to be denied by default")
573
parser.add_argument("--approval-delay", type=string_to_delta,
574
help="Set delay before client approve/deny")
575
parser.add_argument("--approval-duration", type=string_to_delta,
576
help="Set duration of one client approval")
577
parser.add_argument("-H", "--host", help="Set host for client")
578
parser.add_argument("-s", "--secret",
579
type=argparse.FileType(mode="rb"),
580
help="Set password blob (file) for client")
581
approve_deny = parser.add_mutually_exclusive_group()
582
approve_deny.add_argument(
583
"-A", "--approve", action="store_true",
584
help="Approve any current client request")
585
approve_deny.add_argument("-D", "--deny", action="store_true",
586
help="Deny any current client request")
587
parser.add_argument("--debug", action="store_true",
588
help="Debug mode (show D-Bus commands)")
589
parser.add_argument("--check", action="store_true",
590
help="Run self-test")
591
parser.add_argument("client", nargs="*", help="Client name")
594
def commands_from_options(options):
598
if options.dump_json:
599
commands.append(DumpJSONCmd())
602
commands.append(EnableCmd())
605
commands.append(DisableCmd())
607
if options.bump_timeout:
608
commands.append(BumpTimeoutCmd())
610
if options.start_checker:
611
commands.append(StartCheckerCmd())
613
if options.stop_checker:
614
commands.append(StopCheckerCmd())
616
if options.is_enabled:
617
commands.append(IsEnabledCmd())
619
if options.checker is not None:
620
commands.append(SetCheckerCmd(options.checker))
622
if options.timeout is not None:
623
commands.append(SetTimeoutCmd(options.timeout))
625
if options.extended_timeout:
627
SetExtendedTimeoutCmd(options.extended_timeout))
629
if options.interval is not None:
630
commands.append(SetIntervalCmd(options.interval))
632
if options.approved_by_default is not None:
633
if options.approved_by_default:
634
commands.append(ApproveByDefaultCmd())
636
commands.append(DenyByDefaultCmd())
638
if options.approval_delay is not None:
639
commands.append(SetApprovalDelayCmd(options.approval_delay))
641
if options.approval_duration is not None:
643
SetApprovalDurationCmd(options.approval_duration))
645
if options.host is not None:
646
commands.append(SetHostCmd(options.host))
648
if options.secret is not None:
649
commands.append(SetSecretCmd(options.secret))
652
commands.append(ApproveCmd())
655
commands.append(DenyCmd())
658
commands.append(RemoveCmd())
660
# If no command option has been given, show table of clients,
661
# optionally verbosely
663
commands.append(PrintTableCmd(verbose=options.verbose))
668
385
def check_option_syntax(parser, options):
669
386
"""Apply additional restrictions on options, not expressible in
707
424
options.remove = True
711
parser = argparse.ArgumentParser()
713
add_command_line_options(parser)
715
options = parser.parse_args()
717
check_option_syntax(parser, options)
719
clientnames = options.client
722
log.setLevel(logging.DEBUG)
427
def get_mandos_dbus_object(bus):
428
log.debug("D-Bus: Connect to: (busname=%r, path=%r)",
429
dbus_busname, server_dbus_path)
430
with if_dbus_exception_log_with_exception_and_exit(
431
"Could not connect to Mandos server: %s"):
432
mandos_dbus_object = bus.get_object(dbus_busname,
434
return mandos_dbus_object
437
@contextlib.contextmanager
438
def if_dbus_exception_log_with_exception_and_exit(*args, **kwargs):
725
bus = dbus.SystemBus()
726
log.debug("D-Bus: Connect to: (name=%r, path=%r)", busname,
728
mandos_dbus_objc = bus.get_object(busname, server_path)
729
except dbus.exceptions.DBusException:
730
log.critical("Could not connect to Mandos server")
441
except dbus.exceptions.DBusException as e:
442
log.critical(*(args + (e,)), **kwargs)
733
mandos_serv = dbus.Interface(mandos_dbus_objc,
734
dbus_interface=server_interface)
735
mandos_serv_object_manager = dbus.Interface(
736
mandos_dbus_objc, dbus_interface=dbus.OBJECT_MANAGER_IFACE)
738
# Filter out log message from dbus module
739
dbus_logger = logging.getLogger("dbus.proxies")
446
def get_managed_objects(object_manager):
447
log.debug("D-Bus: %s:%s:%s.GetManagedObjects()", dbus_busname,
448
server_dbus_path, dbus.OBJECT_MANAGER_IFACE)
449
with if_dbus_exception_log_with_exception_and_exit(
450
"Failed to access Mandos server through D-Bus:\n%s"):
451
with SilenceLogger("dbus.proxies"):
452
managed_objects = object_manager.GetManagedObjects()
453
return managed_objects
456
class SilenceLogger(object):
457
"Simple context manager to silence a particular logger"
458
def __init__(self, loggername):
459
self.logger = logging.getLogger(loggername)
462
self.logger.addFilter(self.nullfilter)
740
465
class NullFilter(logging.Filter):
741
466
def filter(self, record):
743
dbus_filter = NullFilter()
745
dbus_logger.addFilter(dbus_filter)
746
log.debug("D-Bus: %s:%s:%s.GetManagedObjects()", busname,
747
server_path, dbus.OBJECT_MANAGER_IFACE)
748
mandos_clients = {path: ifs_and_props[client_interface]
749
for path, ifs_and_props in
750
mandos_serv_object_manager
751
.GetManagedObjects().items()
752
if client_interface in ifs_and_props}
753
except dbus.exceptions.DBusException as e:
754
log.critical("Failed to access Mandos server through D-Bus:"
758
# restore dbus logger
759
dbus_logger.removeFilter(dbus_filter)
761
# Compile dict of (clients: properties) to process
765
clients = {bus.get_object(busname, path): properties
766
for path, properties in mandos_clients.items()}
768
for name in clientnames:
769
for path, client in mandos_clients.items():
770
if client["Name"] == name:
771
client_objc = bus.get_object(busname, path)
772
clients[client_objc] = client
775
log.critical("Client not found on server: %r", name)
778
# Run all commands on clients
779
commands = commands_from_options(options)
780
for command in commands:
781
command.run(mandos_serv, mandos_serv_object_manager, clients)
469
nullfilter = NullFilter()
471
def __exit__(self, exc_type, exc_val, exc_tb):
472
self.logger.removeFilter(self.nullfilter)
475
def commands_from_options(options):
479
if options.is_enabled:
480
commands.append(command.IsEnabled())
483
commands.append(command.Approve())
486
commands.append(command.Deny())
489
commands.append(command.Remove())
491
if options.dump_json:
492
commands.append(command.DumpJSON())
495
commands.append(command.Enable())
498
commands.append(command.Disable())
500
if options.bump_timeout:
501
commands.append(command.BumpTimeout())
503
if options.start_checker:
504
commands.append(command.StartChecker())
506
if options.stop_checker:
507
commands.append(command.StopChecker())
509
if options.approved_by_default is not None:
510
if options.approved_by_default:
511
commands.append(command.ApproveByDefault())
513
commands.append(command.DenyByDefault())
515
if options.checker is not None:
516
commands.append(command.SetChecker(options.checker))
518
if options.host is not None:
519
commands.append(command.SetHost(options.host))
521
if options.secret is not None:
522
commands.append(command.SetSecret(options.secret))
524
if options.timeout is not None:
525
commands.append(command.SetTimeout(options.timeout))
527
if options.extended_timeout:
529
command.SetExtendedTimeout(options.extended_timeout))
531
if options.interval is not None:
532
commands.append(command.SetInterval(options.interval))
534
if options.approval_delay is not None:
536
command.SetApprovalDelay(options.approval_delay))
538
if options.approval_duration is not None:
540
command.SetApprovalDuration(options.approval_duration))
542
# If no command option has been given, show table of clients,
543
# optionally verbosely
545
commands.append(command.PrintTable(verbose=options.verbose))
550
class command(object):
551
"""A namespace for command classes"""
554
"""Abstract base class for commands"""
555
def run(self, clients, bus=None, mandos=None):
556
"""Normal commands should implement run_on_one_client(),
557
but commands which want to operate on all clients at the same time can
558
override this run() method instead.
561
for clientpath, properties in clients.items():
562
log.debug("D-Bus: Connect to: (busname=%r, path=%r)",
563
dbus_busname, str(clientpath))
564
client = bus.get_object(dbus_busname, clientpath)
565
self.run_on_one_client(client, properties)
568
class IsEnabled(Base):
569
def run(self, clients, bus=None, mandos=None):
570
client, properties = next(iter(clients.items()))
571
if self.is_enabled(client, properties):
574
def is_enabled(self, client, properties):
575
return properties["Enabled"]
579
def run_on_one_client(self, client, properties):
580
log.debug("D-Bus: %s:%s:%s.Approve(True)", dbus_busname,
581
client.__dbus_object_path__,
582
client_dbus_interface)
583
client.Approve(dbus.Boolean(True),
584
dbus_interface=client_dbus_interface)
588
def run_on_one_client(self, client, properties):
589
log.debug("D-Bus: %s:%s:%s.Approve(False)", dbus_busname,
590
client.__dbus_object_path__,
591
client_dbus_interface)
592
client.Approve(dbus.Boolean(False),
593
dbus_interface=client_dbus_interface)
597
def run_on_one_client(self, client, properties):
598
log.debug("D-Bus: %s:%s:%s.RemoveClient(%r)",
599
dbus_busname, server_dbus_path,
600
server_dbus_interface,
601
str(client.__dbus_object_path__))
602
self.mandos.RemoveClient(client.__dbus_object_path__)
606
"""Abstract class for commands outputting client details"""
607
all_keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK",
608
"Created", "Interval", "Host", "KeyID",
609
"Fingerprint", "CheckerRunning",
610
"LastEnabled", "ApprovalPending",
611
"ApprovedByDefault", "LastApprovalRequest",
612
"ApprovalDelay", "ApprovalDuration",
613
"Checker", "ExtendedTimeout", "Expires",
616
def run(self, clients, bus=None, mandos=None):
617
print(self.output(clients.values()))
619
def output(self, clients):
620
raise NotImplementedError()
623
class DumpJSON(Output):
624
def output(self, clients):
625
data = {client["Name"]:
626
{key: self.dbus_boolean_to_bool(client[key])
627
for key in self.all_keywords}
628
for client in clients}
629
return json.dumps(data, indent=4, separators=(',', ': '))
632
def dbus_boolean_to_bool(value):
633
if isinstance(value, dbus.Boolean):
638
class PrintTable(Output):
639
def __init__(self, verbose=False):
640
self.verbose = verbose
642
def output(self, clients):
643
default_keywords = ("Name", "Enabled", "Timeout",
645
keywords = default_keywords
647
keywords = self.all_keywords
648
return str(self.TableOfClients(clients, keywords))
650
class TableOfClients(object):
653
"Enabled": "Enabled",
654
"Timeout": "Timeout",
655
"LastCheckedOK": "Last Successful Check",
656
"LastApprovalRequest": "Last Approval Request",
657
"Created": "Created",
658
"Interval": "Interval",
660
"Fingerprint": "Fingerprint",
662
"CheckerRunning": "Check Is Running",
663
"LastEnabled": "Last Enabled",
664
"ApprovalPending": "Approval Is Pending",
665
"ApprovedByDefault": "Approved By Default",
666
"ApprovalDelay": "Approval Delay",
667
"ApprovalDuration": "Approval Duration",
668
"Checker": "Checker",
669
"ExtendedTimeout": "Extended Timeout",
670
"Expires": "Expires",
671
"LastCheckerStatus": "Last Checker Status",
674
def __init__(self, clients, keywords):
675
self.clients = clients
676
self.keywords = keywords
679
return "\n".join(self.rows())
681
if sys.version_info.major == 2:
682
__unicode__ = __str__
684
return str(self).encode(
685
locale.getpreferredencoding())
688
format_string = self.row_formatting_string()
689
rows = [self.header_line(format_string)]
690
rows.extend(self.client_line(client, format_string)
691
for client in self.clients)
694
def row_formatting_string(self):
695
"Format string used to format table rows"
696
return " ".join("{{{key}:{width}}}".format(
697
width=max(len(self.tableheaders[key]),
698
*(len(self.string_from_client(client,
700
for client in self.clients)),
702
for key in self.keywords)
704
def string_from_client(self, client, key):
705
return self.valuetostring(client[key], key)
708
def valuetostring(cls, value, keyword):
709
if isinstance(value, dbus.Boolean):
710
return "Yes" if value else "No"
711
if keyword in ("Timeout", "Interval", "ApprovalDelay",
712
"ApprovalDuration", "ExtendedTimeout"):
713
return cls.milliseconds_to_string(value)
716
def header_line(self, format_string):
717
return format_string.format(**self.tableheaders)
719
def client_line(self, client, format_string):
720
return format_string.format(
721
**{key: self.string_from_client(client, key)
722
for key in self.keywords})
725
def milliseconds_to_string(ms):
726
td = datetime.timedelta(0, 0, 0, ms)
727
return ("{days}{hours:02}:{minutes:02}:{seconds:02}"
728
.format(days="{}T".format(td.days)
730
hours=td.seconds // 3600,
731
minutes=(td.seconds % 3600) // 60,
732
seconds=td.seconds % 60))
735
class Property(Base):
736
"Abstract class for Actions for setting one client property"
738
def run_on_one_client(self, client, properties):
739
"""Set the Client's D-Bus property"""
740
log.debug("D-Bus: %s:%s:%s.Set(%r, %r, %r)", dbus_busname,
741
client.__dbus_object_path__,
742
dbus.PROPERTIES_IFACE, client_dbus_interface,
743
self.propname, self.value_to_set
744
if not isinstance(self.value_to_set,
746
else bool(self.value_to_set))
747
client.Set(client_dbus_interface, self.propname,
749
dbus_interface=dbus.PROPERTIES_IFACE)
753
raise NotImplementedError()
756
class Enable(Property):
758
value_to_set = dbus.Boolean(True)
761
class Disable(Property):
763
value_to_set = dbus.Boolean(False)
766
class BumpTimeout(Property):
767
propname = "LastCheckedOK"
771
class StartChecker(Property):
772
propname = "CheckerRunning"
773
value_to_set = dbus.Boolean(True)
776
class StopChecker(Property):
777
propname = "CheckerRunning"
778
value_to_set = dbus.Boolean(False)
781
class ApproveByDefault(Property):
782
propname = "ApprovedByDefault"
783
value_to_set = dbus.Boolean(True)
786
class DenyByDefault(Property):
787
propname = "ApprovedByDefault"
788
value_to_set = dbus.Boolean(False)
791
class PropertyValue(Property):
792
"Abstract class for Property recieving a value as argument"
793
def __init__(self, value):
794
self.value_to_set = value
797
class SetChecker(PropertyValue):
801
class SetHost(PropertyValue):
805
class SetSecret(PropertyValue):
809
def value_to_set(self):
813
def value_to_set(self, value):
814
"""When setting, read data from supplied file object"""
815
self._vts = value.read()
819
class MillisecondsPropertyValueArgument(PropertyValue):
820
"""Abstract class for PropertyValue taking a value argument as
821
a datetime.timedelta() but should store it as milliseconds."""
824
def value_to_set(self):
828
def value_to_set(self, value):
829
"When setting, convert value from a datetime.timedelta"
830
self._vts = int(round(value.total_seconds() * 1000))
833
class SetTimeout(MillisecondsPropertyValueArgument):
837
class SetExtendedTimeout(MillisecondsPropertyValueArgument):
838
propname = "ExtendedTimeout"
841
class SetInterval(MillisecondsPropertyValueArgument):
842
propname = "Interval"
845
class SetApprovalDelay(MillisecondsPropertyValueArgument):
846
propname = "ApprovalDelay"
849
class SetApprovalDuration(MillisecondsPropertyValueArgument):
850
propname = "ApprovalDuration"
784
class Test_milliseconds_to_string(unittest.TestCase):
786
self.assertEqual(milliseconds_to_string(93785000),
788
def test_no_days(self):
789
self.assertEqual(milliseconds_to_string(7385000), "02:03:05")
790
def test_all_zero(self):
791
self.assertEqual(milliseconds_to_string(0), "00:00:00")
792
def test_no_fractional_seconds(self):
793
self.assertEqual(milliseconds_to_string(400), "00:00:00")
794
self.assertEqual(milliseconds_to_string(900), "00:00:00")
795
self.assertEqual(milliseconds_to_string(1900), "00:00:01")
797
class Test_string_to_delta(unittest.TestCase):
854
class TestCaseWithAssertLogs(unittest.TestCase):
855
"""unittest.TestCase.assertLogs only exists in Python 3.4"""
857
if not hasattr(unittest.TestCase, "assertLogs"):
858
@contextlib.contextmanager
859
def assertLogs(self, logger, level=logging.INFO):
860
capturing_handler = self.CapturingLevelHandler(level)
861
old_level = logger.level
862
old_propagate = logger.propagate
863
logger.addHandler(capturing_handler)
864
logger.setLevel(level)
865
logger.propagate = False
867
yield capturing_handler.watcher
869
logger.propagate = old_propagate
870
logger.removeHandler(capturing_handler)
871
logger.setLevel(old_level)
872
self.assertGreater(len(capturing_handler.watcher.records),
875
class CapturingLevelHandler(logging.Handler):
876
def __init__(self, level, *args, **kwargs):
877
logging.Handler.__init__(self, *args, **kwargs)
878
self.watcher = self.LoggingWatcher([], [])
879
def emit(self, record):
880
self.watcher.records.append(record)
881
self.watcher.output.append(self.format(record))
883
LoggingWatcher = collections.namedtuple("LoggingWatcher",
888
class Test_string_to_delta(TestCaseWithAssertLogs):
798
889
def test_handles_basic_rfc3339(self):
799
890
self.assertEqual(string_to_delta("PT0S"),
800
891
datetime.timedelta())
804
895
datetime.timedelta(0, 1))
805
896
self.assertEqual(string_to_delta("PT2H"),
806
897
datetime.timedelta(0, 7200))
807
899
def test_falls_back_to_pre_1_6_1_with_warning(self):
808
# assertLogs only exists in Python 3.4
809
if hasattr(self, "assertLogs"):
810
with self.assertLogs(log, logging.WARNING):
811
value = string_to_delta("2h")
813
class WarningFilter(logging.Filter):
814
"""Don't show, but record the presence of, warnings"""
815
def filter(self, record):
816
is_warning = record.levelno >= logging.WARNING
817
self.found = is_warning or getattr(self, "found",
819
return not is_warning
820
warning_filter = WarningFilter()
821
log.addFilter(warning_filter)
823
value = string_to_delta("2h")
825
log.removeFilter(warning_filter)
826
self.assertTrue(getattr(warning_filter, "found", False))
900
with self.assertLogs(log, logging.WARNING):
901
value = string_to_delta("2h")
827
902
self.assertEqual(value, datetime.timedelta(0, 7200))
830
class TestCmd(unittest.TestCase):
905
class Test_check_option_syntax(unittest.TestCase):
907
self.parser = argparse.ArgumentParser()
908
add_command_line_options(self.parser)
910
def test_actions_requires_client_or_all(self):
911
for action, value in self.actions.items():
912
options = self.parser.parse_args()
913
setattr(options, action, value)
914
with self.assertParseError():
915
self.check_option_syntax(options)
917
# This mostly corresponds to the definition from has_actions() in
918
# check_option_syntax()
920
# The actual values set here are not that important, but we do
921
# at least stick to the correct types, even though they are
925
"bump_timeout": True,
926
"start_checker": True,
927
"stop_checker": True,
931
"timeout": datetime.timedelta(),
932
"extended_timeout": datetime.timedelta(),
933
"interval": datetime.timedelta(),
934
"approved_by_default": True,
935
"approval_delay": datetime.timedelta(),
936
"approval_duration": datetime.timedelta(),
938
"secret": io.BytesIO(b"x"),
943
@contextlib.contextmanager
944
def assertParseError(self):
945
with self.assertRaises(SystemExit) as e:
946
with self.redirect_stderr_to_devnull():
948
# Exit code from argparse is guaranteed to be "2". Reference:
949
# https://docs.python.org/3/library
950
# /argparse.html#exiting-methods
951
self.assertEqual(e.exception.code, 2)
954
@contextlib.contextmanager
955
def redirect_stderr_to_devnull():
956
null = os.open(os.path.devnull, os.O_RDWR)
957
stderrcopy = os.dup(sys.stderr.fileno())
958
os.dup2(null, sys.stderr.fileno())
964
os.dup2(stderrcopy, sys.stderr.fileno())
967
def check_option_syntax(self, options):
968
check_option_syntax(self.parser, options)
970
def test_actions_all_conflicts_with_verbose(self):
971
for action, value in self.actions.items():
972
options = self.parser.parse_args()
973
setattr(options, action, value)
975
options.verbose = True
976
with self.assertParseError():
977
self.check_option_syntax(options)
979
def test_actions_with_client_conflicts_with_verbose(self):
980
for action, value in self.actions.items():
981
options = self.parser.parse_args()
982
setattr(options, action, value)
983
options.verbose = True
984
options.client = ["foo"]
985
with self.assertParseError():
986
self.check_option_syntax(options)
988
def test_dump_json_conflicts_with_verbose(self):
989
options = self.parser.parse_args()
990
options.dump_json = True
991
options.verbose = True
992
with self.assertParseError():
993
self.check_option_syntax(options)
995
def test_dump_json_conflicts_with_action(self):
996
for action, value in self.actions.items():
997
options = self.parser.parse_args()
998
setattr(options, action, value)
999
options.dump_json = True
1000
with self.assertParseError():
1001
self.check_option_syntax(options)
1003
def test_all_can_not_be_alone(self):
1004
options = self.parser.parse_args()
1006
with self.assertParseError():
1007
self.check_option_syntax(options)
1009
def test_all_is_ok_with_any_action(self):
1010
for action, value in self.actions.items():
1011
options = self.parser.parse_args()
1012
setattr(options, action, value)
1014
self.check_option_syntax(options)
1016
def test_any_action_is_ok_with_one_client(self):
1017
for action, value in self.actions.items():
1018
options = self.parser.parse_args()
1019
setattr(options, action, value)
1020
options.client = ["foo"]
1021
self.check_option_syntax(options)
1023
def test_one_client_with_all_actions_except_is_enabled(self):
1024
options = self.parser.parse_args()
1025
for action, value in self.actions.items():
1026
if action == "is_enabled":
1028
setattr(options, action, value)
1029
options.client = ["foo"]
1030
self.check_option_syntax(options)
1032
def test_two_clients_with_all_actions_except_is_enabled(self):
1033
options = self.parser.parse_args()
1034
for action, value in self.actions.items():
1035
if action == "is_enabled":
1037
setattr(options, action, value)
1038
options.client = ["foo", "barbar"]
1039
self.check_option_syntax(options)
1041
def test_two_clients_are_ok_with_actions_except_is_enabled(self):
1042
for action, value in self.actions.items():
1043
if action == "is_enabled":
1045
options = self.parser.parse_args()
1046
setattr(options, action, value)
1047
options.client = ["foo", "barbar"]
1048
self.check_option_syntax(options)
1050
def test_is_enabled_fails_without_client(self):
1051
options = self.parser.parse_args()
1052
options.is_enabled = True
1053
with self.assertParseError():
1054
self.check_option_syntax(options)
1056
def test_is_enabled_fails_with_two_clients(self):
1057
options = self.parser.parse_args()
1058
options.is_enabled = True
1059
options.client = ["foo", "barbar"]
1060
with self.assertParseError():
1061
self.check_option_syntax(options)
1063
def test_remove_can_only_be_combined_with_action_deny(self):
1064
for action, value in self.actions.items():
1065
if action in {"remove", "deny"}:
1067
options = self.parser.parse_args()
1068
setattr(options, action, value)
1070
options.remove = True
1071
with self.assertParseError():
1072
self.check_option_syntax(options)
1075
class Test_get_mandos_dbus_object(TestCaseWithAssertLogs):
1076
def test_calls_and_returns_get_object_on_bus(self):
1077
class MockBus(object):
1079
def get_object(mockbus_self, busname, dbus_path):
1080
# Note that "self" is still the testcase instance,
1081
# this MockBus instance is in "mockbus_self".
1082
self.assertEqual(busname, dbus_busname)
1083
self.assertEqual(dbus_path, server_dbus_path)
1084
mockbus_self.called = True
1087
mockbus = get_mandos_dbus_object(bus=MockBus())
1088
self.assertIsInstance(mockbus, MockBus)
1089
self.assertTrue(mockbus.called)
1091
def test_logs_and_exits_on_dbus_error(self):
1092
class MockBusFailing(object):
1093
def get_object(self, busname, dbus_path):
1094
raise dbus.exceptions.DBusException("Test")
1096
with self.assertLogs(log, logging.CRITICAL):
1097
with self.assertRaises(SystemExit) as e:
1098
bus = get_mandos_dbus_object(bus=MockBusFailing())
1100
if isinstance(e.exception.code, int):
1101
self.assertNotEqual(e.exception.code, 0)
1103
self.assertIsNotNone(e.exception.code)
1106
class Test_get_managed_objects(TestCaseWithAssertLogs):
1107
def test_calls_and_returns_GetManagedObjects(self):
1108
managed_objects = {"/clients/foo": { "Name": "foo"}}
1109
class MockObjectManager(object):
1110
def GetManagedObjects(self):
1111
return managed_objects
1112
retval = get_managed_objects(MockObjectManager())
1113
self.assertDictEqual(managed_objects, retval)
1115
def test_logs_and_exits_on_dbus_error(self):
1116
dbus_logger = logging.getLogger("dbus.proxies")
1118
class MockObjectManagerFailing(object):
1119
def GetManagedObjects(self):
1120
dbus_logger.error("Test")
1121
raise dbus.exceptions.DBusException("Test")
1123
class CountingHandler(logging.Handler):
1125
def emit(self, record):
1128
counting_handler = CountingHandler()
1130
dbus_logger.addHandler(counting_handler)
1133
with self.assertLogs(log, logging.CRITICAL) as watcher:
1134
with self.assertRaises(SystemExit) as e:
1135
get_managed_objects(MockObjectManagerFailing())
1137
dbus_logger.removeFilter(counting_handler)
1139
# Make sure the dbus logger was suppressed
1140
self.assertEqual(counting_handler.count, 0)
1142
# Test that the dbus_logger still works
1143
with self.assertLogs(dbus_logger, logging.ERROR):
1144
dbus_logger.error("Test")
1146
if isinstance(e.exception.code, int):
1147
self.assertNotEqual(e.exception.code, 0)
1149
self.assertIsNotNone(e.exception.code)
1152
class Test_commands_from_options(unittest.TestCase):
1154
self.parser = argparse.ArgumentParser()
1155
add_command_line_options(self.parser)
1157
def test_is_enabled(self):
1158
self.assert_command_from_args(["--is-enabled", "foo"],
1161
def assert_command_from_args(self, args, command_cls,
1163
"""Assert that parsing ARGS should result in an instance of
1164
COMMAND_CLS with (optionally) all supplied attributes (CMD_ATTRS)."""
1165
options = self.parser.parse_args(args)
1166
check_option_syntax(self.parser, options)
1167
commands = commands_from_options(options)
1168
self.assertEqual(len(commands), 1)
1169
command = commands[0]
1170
self.assertIsInstance(command, command_cls)
1171
for key, value in cmd_attrs.items():
1172
self.assertEqual(getattr(command, key), value)
1174
def test_is_enabled_short(self):
1175
self.assert_command_from_args(["-V", "foo"],
1178
def test_approve(self):
1179
self.assert_command_from_args(["--approve", "foo"],
1182
def test_approve_short(self):
1183
self.assert_command_from_args(["-A", "foo"], command.Approve)
1185
def test_deny(self):
1186
self.assert_command_from_args(["--deny", "foo"], command.Deny)
1188
def test_deny_short(self):
1189
self.assert_command_from_args(["-D", "foo"], command.Deny)
1191
def test_remove(self):
1192
self.assert_command_from_args(["--remove", "foo"],
1195
def test_deny_before_remove(self):
1196
options = self.parser.parse_args(["--deny", "--remove",
1198
check_option_syntax(self.parser, options)
1199
commands = commands_from_options(options)
1200
self.assertEqual(len(commands), 2)
1201
self.assertIsInstance(commands[0], command.Deny)
1202
self.assertIsInstance(commands[1], command.Remove)
1204
def test_deny_before_remove_reversed(self):
1205
options = self.parser.parse_args(["--remove", "--deny",
1207
check_option_syntax(self.parser, options)
1208
commands = commands_from_options(options)
1209
self.assertEqual(len(commands), 2)
1210
self.assertIsInstance(commands[0], command.Deny)
1211
self.assertIsInstance(commands[1], command.Remove)
1213
def test_remove_short(self):
1214
self.assert_command_from_args(["-r", "foo"], command.Remove)
1216
def test_dump_json(self):
1217
self.assert_command_from_args(["--dump-json"],
1220
def test_enable(self):
1221
self.assert_command_from_args(["--enable", "foo"],
1224
def test_enable_short(self):
1225
self.assert_command_from_args(["-e", "foo"], command.Enable)
1227
def test_disable(self):
1228
self.assert_command_from_args(["--disable", "foo"],
1231
def test_disable_short(self):
1232
self.assert_command_from_args(["-d", "foo"], command.Disable)
1234
def test_bump_timeout(self):
1235
self.assert_command_from_args(["--bump-timeout", "foo"],
1236
command.BumpTimeout)
1238
def test_bump_timeout_short(self):
1239
self.assert_command_from_args(["-b", "foo"],
1240
command.BumpTimeout)
1242
def test_start_checker(self):
1243
self.assert_command_from_args(["--start-checker", "foo"],
1244
command.StartChecker)
1246
def test_stop_checker(self):
1247
self.assert_command_from_args(["--stop-checker", "foo"],
1248
command.StopChecker)
1250
def test_approve_by_default(self):
1251
self.assert_command_from_args(["--approve-by-default", "foo"],
1252
command.ApproveByDefault)
1254
def test_deny_by_default(self):
1255
self.assert_command_from_args(["--deny-by-default", "foo"],
1256
command.DenyByDefault)
1258
def test_checker(self):
1259
self.assert_command_from_args(["--checker", ":", "foo"],
1263
def test_checker_empty(self):
1264
self.assert_command_from_args(["--checker", "", "foo"],
1268
def test_checker_short(self):
1269
self.assert_command_from_args(["-c", ":", "foo"],
1273
def test_host(self):
1274
self.assert_command_from_args(["--host", "foo.example.org",
1275
"foo"], command.SetHost,
1276
value_to_set="foo.example.org")
1278
def test_host_short(self):
1279
self.assert_command_from_args(["-H", "foo.example.org",
1280
"foo"], command.SetHost,
1281
value_to_set="foo.example.org")
1283
def test_secret_devnull(self):
1284
self.assert_command_from_args(["--secret", os.path.devnull,
1285
"foo"], command.SetSecret,
1288
def test_secret_tempfile(self):
1289
with tempfile.NamedTemporaryFile(mode="r+b") as f:
1290
value = b"secret\0xyzzy\nbar"
1293
self.assert_command_from_args(["--secret", f.name,
1294
"foo"], command.SetSecret,
1297
def test_secret_devnull_short(self):
1298
self.assert_command_from_args(["-s", os.path.devnull, "foo"],
1302
def test_secret_tempfile_short(self):
1303
with tempfile.NamedTemporaryFile(mode="r+b") as f:
1304
value = b"secret\0xyzzy\nbar"
1307
self.assert_command_from_args(["-s", f.name, "foo"],
1311
def test_timeout(self):
1312
self.assert_command_from_args(["--timeout", "PT5M", "foo"],
1314
value_to_set=300000)
1316
def test_timeout_short(self):
1317
self.assert_command_from_args(["-t", "PT5M", "foo"],
1319
value_to_set=300000)
1321
def test_extended_timeout(self):
1322
self.assert_command_from_args(["--extended-timeout", "PT15M",
1324
command.SetExtendedTimeout,
1325
value_to_set=900000)
1327
def test_interval(self):
1328
self.assert_command_from_args(["--interval", "PT2M", "foo"],
1329
command.SetInterval,
1330
value_to_set=120000)
1332
def test_interval_short(self):
1333
self.assert_command_from_args(["-i", "PT2M", "foo"],
1334
command.SetInterval,
1335
value_to_set=120000)
1337
def test_approval_delay(self):
1338
self.assert_command_from_args(["--approval-delay", "PT30S",
1340
command.SetApprovalDelay,
1343
def test_approval_duration(self):
1344
self.assert_command_from_args(["--approval-duration", "PT1S",
1346
command.SetApprovalDuration,
1349
def test_print_table(self):
1350
self.assert_command_from_args([], command.PrintTable,
1353
def test_print_table_verbose(self):
1354
self.assert_command_from_args(["--verbose"],
1358
def test_print_table_verbose_short(self):
1359
self.assert_command_from_args(["-v"], command.PrintTable,
1363
class TestCommand(unittest.TestCase):
831
1364
"""Abstract class for tests of command classes"""
832
1366
def setUp(self):
834
1368
class MockClient(object):
835
1369
def __init__(self, name, **attributes):
836
self.__dbus_object_path__ = "objpath_{}".format(name)
1370
self.__dbus_object_path__ = "/clients/{}".format(name)
837
1371
self.attributes = attributes
838
1372
self.attributes["Name"] = name
840
def Set(self, interface, property, value, dbus_interface):
841
testcase.assertEqual(interface, client_interface)
842
testcase.assertEqual(dbus_interface,
843
dbus.PROPERTIES_IFACE)
844
self.attributes[property] = value
845
def Get(self, interface, property, dbus_interface):
846
testcase.assertEqual(interface, client_interface)
847
testcase.assertEqual(dbus_interface,
848
dbus.PROPERTIES_IFACE)
849
return self.attributes[property]
1374
def Set(self, interface, propname, value, dbus_interface):
1375
testcase.assertEqual(interface, client_dbus_interface)
1376
testcase.assertEqual(dbus_interface,
1377
dbus.PROPERTIES_IFACE)
1378
self.attributes[propname] = value
1379
def Get(self, interface, propname, dbus_interface):
1380
testcase.assertEqual(interface, client_dbus_interface)
1381
testcase.assertEqual(dbus_interface,
1382
dbus.PROPERTIES_IFACE)
1383
return self.attributes[propname]
850
1384
def Approve(self, approve, dbus_interface):
851
testcase.assertEqual(dbus_interface, client_interface)
1385
testcase.assertEqual(dbus_interface,
1386
client_dbus_interface)
852
1387
self.calls.append(("Approve", (approve,
853
1388
dbus_interface)))
854
1389
self.client = MockClient(
894
1429
ApprovedByDefault=dbus.Boolean(False),
895
1430
LastApprovalRequest="2019-01-03T00:00:00",
896
1431
ApprovalDelay=30000,
897
ApprovalDuration=1000,
1432
ApprovalDuration=93785000,
899
1434
ExtendedTimeout=900000,
900
1435
Expires="2019-02-05T00:00:00",
901
1436
LastCheckerStatus=-2)
902
1437
self.clients = collections.OrderedDict(
904
(self.client, self.client.attributes),
905
(self.other_client, self.other_client.attributes),
1439
("/clients/foo", self.client.attributes),
1440
("/clients/barbar", self.other_client.attributes),
907
self.one_client = {self.client: self.client.attributes}
909
class TestPrintTableCmd(TestCmd):
910
def test_normal(self):
911
output = PrintTableCmd().output(None, self.clients.values())
912
expected_output = """
913
Name Enabled Timeout Last Successful Check
914
foo Yes 00:05:00 2019-02-03T00:00:00
915
barbar Yes 00:05:00 2019-02-04T00:00:00
917
self.assertEqual(output, expected_output)
918
def test_verbose(self):
919
output = PrintTableCmd(verbose=True).output(
920
None, self.clients.values())
921
expected_output = """
922
Name Enabled Timeout Last Successful Check Created Interval Host Key ID Fingerprint Check Is Running Last Enabled Approval Is Pending Approved By Default Last Approval Request Approval Delay Approval Duration Checker Extended Timeout Expires Last Checker Status
923
foo Yes 00:05:00 2019-02-03T00:00:00 2019-01-02T00:00:00 00:02:00 foo.example.org 92ed150794387c03ce684574b1139a6594a34f895daaaf09fd8ea90a27cddb12 778827225BA7DE539C5A7CFA59CFF7CDBD9A5920 No 2019-01-03T00:00:00 No Yes 00:00:00 00:00:01 fping -q -- %(host)s 00:15:00 2019-02-04T00:00:00 0
924
barbar Yes 00:05:00 2019-02-04T00:00:00 2019-01-03T00:00:00 00:02:00 192.0.2.3 0558568eedd67d622f5c83b35a115f796ab612cff5ad227247e46c2b020f441c 3E393AEAEFB84C7E89E2F547B3A107558FCA3A27 Yes 2019-01-04T00:00:00 No No 2019-01-03T00:00:00 00:00:30 00:00:01 : 00:15:00 2019-02-05T00:00:00 -2
926
self.assertEqual(output, expected_output)
927
def test_one_client(self):
928
output = PrintTableCmd().output(None, self.one_client.values())
929
expected_output = """
930
Name Enabled Timeout Last Successful Check
931
foo Yes 00:05:00 2019-02-03T00:00:00
933
self.assertEqual(output, expected_output)
935
class TestDumpJSONCmd(TestCmd):
937
self.expected_json = {
940
"KeyID": ("92ed150794387c03ce684574b1139a65"
941
"94a34f895daaaf09fd8ea90a27cddb12"),
942
"Host": "foo.example.org",
945
"LastCheckedOK": "2019-02-03T00:00:00",
946
"Created": "2019-01-02T00:00:00",
948
"Fingerprint": ("778827225BA7DE539C5A"
949
"7CFA59CFF7CDBD9A5920"),
950
"CheckerRunning": False,
951
"LastEnabled": "2019-01-03T00:00:00",
952
"ApprovalPending": False,
953
"ApprovedByDefault": True,
954
"LastApprovalRequest": "",
956
"ApprovalDuration": 1000,
957
"Checker": "fping -q -- %(host)s",
958
"ExtendedTimeout": 900000,
959
"Expires": "2019-02-04T00:00:00",
960
"LastCheckerStatus": 0,
964
"KeyID": ("0558568eedd67d622f5c83b35a115f79"
965
"6ab612cff5ad227247e46c2b020f441c"),
969
"LastCheckedOK": "2019-02-04T00:00:00",
970
"Created": "2019-01-03T00:00:00",
972
"Fingerprint": ("3E393AEAEFB84C7E89E2"
973
"F547B3A107558FCA3A27"),
974
"CheckerRunning": True,
975
"LastEnabled": "2019-01-04T00:00:00",
976
"ApprovalPending": False,
977
"ApprovedByDefault": False,
978
"LastApprovalRequest": "2019-01-03T00:00:00",
979
"ApprovalDelay": 30000,
980
"ApprovalDuration": 1000,
982
"ExtendedTimeout": 900000,
983
"Expires": "2019-02-05T00:00:00",
984
"LastCheckerStatus": -2,
987
return super(TestDumpJSONCmd, self).setUp()
988
def test_normal(self):
989
json_data = json.loads(DumpJSONCmd().output(None,
991
self.assertDictEqual(json_data, self.expected_json)
992
def test_one_client(self):
993
clients = self.one_client
994
json_data = json.loads(DumpJSONCmd().output(None, clients))
995
expected_json = {"foo": self.expected_json["foo"]}
996
self.assertDictEqual(json_data, expected_json)
998
class TestIsEnabledCmd(TestCmd):
999
def test_is_enabled(self):
1000
self.assertTrue(all(IsEnabledCmd().is_enabled(client, properties)
1001
for client, properties in self.clients.items()))
1002
def test_is_enabled_run_exits_successfully(self):
1442
self.one_client = {"/clients/foo": self.client.attributes}
1448
def get_object(client_bus_name, path):
1449
self.assertEqual(client_bus_name, dbus_busname)
1451
# Note: "self" here is the TestCmd instance, not
1452
# the Bus instance, since this is a static method!
1453
"/clients/foo": self.client,
1454
"/clients/barbar": self.other_client,
1459
class TestBaseCommands(TestCommand):
1461
def test_IsEnabled(self):
1462
self.assertTrue(all(command.IsEnabled().is_enabled(client,
1464
for client, properties
1465
in self.clients.items()))
1467
def test_IsEnabled_run_exits_successfully(self):
1003
1468
with self.assertRaises(SystemExit) as e:
1004
IsEnabledCmd().run(None, None, self.one_client)
1469
command.IsEnabled().run(self.one_client)
1005
1470
if e.exception.code is not None:
1006
1471
self.assertEqual(e.exception.code, 0)
1008
1473
self.assertIsNone(e.exception.code)
1009
def test_is_enabled_run_exits_with_failure(self):
1475
def test_IsEnabled_run_exits_with_failure(self):
1010
1476
self.client.attributes["Enabled"] = dbus.Boolean(False)
1011
1477
with self.assertRaises(SystemExit) as e:
1012
IsEnabledCmd().run(None, None, self.one_client)
1478
command.IsEnabled().run(self.one_client)
1013
1479
if isinstance(e.exception.code, int):
1014
1480
self.assertNotEqual(e.exception.code, 0)
1016
1482
self.assertIsNotNone(e.exception.code)
1018
class TestRemoveCmd(TestCmd):
1019
def test_remove(self):
1484
def test_Approve(self):
1485
command.Approve().run(self.clients, self.bus)
1486
for clientpath in self.clients:
1487
client = self.bus.get_object(dbus_busname, clientpath)
1488
self.assertIn(("Approve", (True, client_dbus_interface)),
1491
def test_Deny(self):
1492
command.Deny().run(self.clients, self.bus)
1493
for clientpath in self.clients:
1494
client = self.bus.get_object(dbus_busname, clientpath)
1495
self.assertIn(("Approve", (False, client_dbus_interface)),
1498
def test_Remove(self):
1020
1499
class MockMandos(object):
1021
1500
def __init__(self):
1022
1501
self.calls = []
1023
1502
def RemoveClient(self, dbus_path):
1024
1503
self.calls.append(("RemoveClient", (dbus_path,)))
1025
1504
mandos = MockMandos()
1026
super(TestRemoveCmd, self).setUp()
1027
RemoveCmd().run(mandos, None, self.clients)
1505
command.Remove().run(self.clients, self.bus, mandos)
1028
1506
self.assertEqual(len(mandos.calls), 2)
1029
for client in self.clients:
1030
self.assertIn(("RemoveClient",
1031
(client.__dbus_object_path__,)),
1507
for clientpath in self.clients:
1508
self.assertIn(("RemoveClient", (clientpath,)),
1034
class TestApproveCmd(TestCmd):
1035
def test_approve(self):
1036
ApproveCmd().run(None, None, self.clients)
1037
for client in self.clients:
1038
self.assertIn(("Approve", (True, client_interface)),
1041
class TestDenyCmd(TestCmd):
1042
def test_deny(self):
1043
DenyCmd().run(None, None, self.clients)
1044
for client in self.clients:
1045
self.assertIn(("Approve", (False, client_interface)),
1048
class TestEnableCmd(TestCmd):
1049
def test_enable(self):
1050
for client in self.clients:
1051
client.attributes["Enabled"] = False
1053
EnableCmd().run(None, None, self.clients)
1055
for client in self.clients:
1056
self.assertTrue(client.attributes["Enabled"])
1058
class TestDisableCmd(TestCmd):
1059
def test_disable(self):
1060
DisableCmd().run(None, None, self.clients)
1062
for client in self.clients:
1063
self.assertFalse(client.attributes["Enabled"])
1065
class Unique(object):
1066
"""Class for objects which exist only to be unique objects, since
1067
unittest.mock.sentinel only exists in Python 3.3"""
1069
class TestPropertyCmd(TestCmd):
1070
"""Abstract class for tests of PropertyCmd classes"""
1514
"KeyID": ("92ed150794387c03ce684574b1139a65"
1515
"94a34f895daaaf09fd8ea90a27cddb12"),
1516
"Host": "foo.example.org",
1519
"LastCheckedOK": "2019-02-03T00:00:00",
1520
"Created": "2019-01-02T00:00:00",
1522
"Fingerprint": ("778827225BA7DE539C5A"
1523
"7CFA59CFF7CDBD9A5920"),
1524
"CheckerRunning": False,
1525
"LastEnabled": "2019-01-03T00:00:00",
1526
"ApprovalPending": False,
1527
"ApprovedByDefault": True,
1528
"LastApprovalRequest": "",
1530
"ApprovalDuration": 1000,
1531
"Checker": "fping -q -- %(host)s",
1532
"ExtendedTimeout": 900000,
1533
"Expires": "2019-02-04T00:00:00",
1534
"LastCheckerStatus": 0,
1538
"KeyID": ("0558568eedd67d622f5c83b35a115f79"
1539
"6ab612cff5ad227247e46c2b020f441c"),
1540
"Host": "192.0.2.3",
1543
"LastCheckedOK": "2019-02-04T00:00:00",
1544
"Created": "2019-01-03T00:00:00",
1546
"Fingerprint": ("3E393AEAEFB84C7E89E2"
1547
"F547B3A107558FCA3A27"),
1548
"CheckerRunning": True,
1549
"LastEnabled": "2019-01-04T00:00:00",
1550
"ApprovalPending": False,
1551
"ApprovedByDefault": False,
1552
"LastApprovalRequest": "2019-01-03T00:00:00",
1553
"ApprovalDelay": 30000,
1554
"ApprovalDuration": 93785000,
1556
"ExtendedTimeout": 900000,
1557
"Expires": "2019-02-05T00:00:00",
1558
"LastCheckerStatus": -2,
1562
def test_DumpJSON_normal(self):
1563
output = command.DumpJSON().output(self.clients.values())
1564
json_data = json.loads(output)
1565
self.assertDictEqual(json_data, self.expected_json)
1567
def test_DumpJSON_one_client(self):
1568
output = command.DumpJSON().output(self.one_client.values())
1569
json_data = json.loads(output)
1570
expected_json = {"foo": self.expected_json["foo"]}
1571
self.assertDictEqual(json_data, expected_json)
1573
def test_PrintTable_normal(self):
1574
output = command.PrintTable().output(self.clients.values())
1575
expected_output = "\n".join((
1576
"Name Enabled Timeout Last Successful Check",
1577
"foo Yes 00:05:00 2019-02-03T00:00:00 ",
1578
"barbar Yes 00:05:00 2019-02-04T00:00:00 ",
1580
self.assertEqual(output, expected_output)
1582
def test_PrintTable_verbose(self):
1583
output = command.PrintTable(verbose=True).output(
1584
self.clients.values())
1599
"Last Successful Check ",
1600
"2019-02-03T00:00:00 ",
1601
"2019-02-04T00:00:00 ",
1604
"2019-01-02T00:00:00 ",
1605
"2019-01-03T00:00:00 ",
1617
("92ed150794387c03ce684574b1139a6594a34f895daaaf09fd8"
1619
("0558568eedd67d622f5c83b35a115f796ab612cff5ad227247e"
1623
"778827225BA7DE539C5A7CFA59CFF7CDBD9A5920 ",
1624
"3E393AEAEFB84C7E89E2F547B3A107558FCA3A27 ",
1626
"Check Is Running ",
1631
"2019-01-03T00:00:00 ",
1632
"2019-01-04T00:00:00 ",
1634
"Approval Is Pending ",
1638
"Approved By Default ",
1642
"Last Approval Request ",
1644
"2019-01-03T00:00:00 ",
1650
"Approval Duration ",
1655
"fping -q -- %(host)s ",
1658
"Extended Timeout ",
1663
"2019-02-04T00:00:00 ",
1664
"2019-02-05T00:00:00 ",
1666
"Last Checker Status",
1671
num_lines = max(len(rows) for rows in columns)
1672
expected_output = "\n".join("".join(rows[line]
1673
for rows in columns)
1674
for line in range(num_lines))
1675
self.assertEqual(output, expected_output)
1677
def test_PrintTable_one_client(self):
1678
output = command.PrintTable().output(self.one_client.values())
1679
expected_output = "\n".join((
1680
"Name Enabled Timeout Last Successful Check",
1681
"foo Yes 00:05:00 2019-02-03T00:00:00 ",
1683
self.assertEqual(output, expected_output)
1686
class TestPropertyCmd(TestCommand):
1687
"""Abstract class for tests of command.Property classes"""
1071
1688
def runTest(self):
1072
1689
if not hasattr(self, "command"):
1075
1692
self.values_to_set)
1076
1693
for value_to_set, value_to_get in zip(self.values_to_set,
1077
1694
values_to_get):
1078
for client in self.clients:
1079
old_value = client.attributes[self.property]
1080
self.assertNotIsInstance(old_value, Unique)
1081
client.attributes[self.property] = Unique()
1695
for clientpath in self.clients:
1696
client = self.bus.get_object(dbus_busname, clientpath)
1697
old_value = client.attributes[self.propname]
1698
self.assertNotIsInstance(old_value, self.Unique)
1699
client.attributes[self.propname] = self.Unique()
1082
1700
self.run_command(value_to_set, self.clients)
1083
for client in self.clients:
1084
value = client.attributes[self.property]
1085
self.assertNotIsInstance(value, Unique)
1701
for clientpath in self.clients:
1702
client = self.bus.get_object(dbus_busname, clientpath)
1703
value = client.attributes[self.propname]
1704
self.assertNotIsInstance(value, self.Unique)
1086
1705
self.assertEqual(value, value_to_get)
1707
class Unique(object):
1708
"""Class for objects which exist only to be unique objects,
1709
since unittest.mock.sentinel only exists in Python 3.3"""
1087
1711
def run_command(self, value, clients):
1088
self.command().run(None, None, clients)
1712
self.command().run(clients, self.bus)
1715
class TestEnableCmd(TestPropertyCmd):
1716
command = command.Enable
1717
propname = "Enabled"
1718
values_to_set = [dbus.Boolean(True)]
1721
class TestDisableCmd(TestPropertyCmd):
1722
command = command.Disable
1723
propname = "Enabled"
1724
values_to_set = [dbus.Boolean(False)]
1090
1727
class TestBumpTimeoutCmd(TestPropertyCmd):
1091
command = BumpTimeoutCmd
1092
property = "LastCheckedOK"
1728
command = command.BumpTimeout
1729
propname = "LastCheckedOK"
1093
1730
values_to_set = [""]
1095
1733
class TestStartCheckerCmd(TestPropertyCmd):
1096
command = StartCheckerCmd
1097
property = "CheckerRunning"
1734
command = command.StartChecker
1735
propname = "CheckerRunning"
1098
1736
values_to_set = [dbus.Boolean(True)]
1100
1739
class TestStopCheckerCmd(TestPropertyCmd):
1101
command = StopCheckerCmd
1102
property = "CheckerRunning"
1740
command = command.StopChecker
1741
propname = "CheckerRunning"
1103
1742
values_to_set = [dbus.Boolean(False)]
1105
1745
class TestApproveByDefaultCmd(TestPropertyCmd):
1106
command = ApproveByDefaultCmd
1107
property = "ApprovedByDefault"
1746
command = command.ApproveByDefault
1747
propname = "ApprovedByDefault"
1108
1748
values_to_set = [dbus.Boolean(True)]
1110
1751
class TestDenyByDefaultCmd(TestPropertyCmd):
1111
command = DenyByDefaultCmd
1112
property = "ApprovedByDefault"
1752
command = command.DenyByDefault
1753
propname = "ApprovedByDefault"
1113
1754
values_to_set = [dbus.Boolean(False)]
1115
class TestValueArgumentPropertyCmd(TestPropertyCmd):
1116
"""Abstract class for tests of PropertyCmd classes using the
1117
ValueArgumentMixIn"""
1757
class TestPropertyValueCmd(TestPropertyCmd):
1758
"""Abstract class for tests of PropertyValueCmd classes"""
1118
1760
def runTest(self):
1119
if type(self) is TestValueArgumentPropertyCmd:
1761
if type(self) is TestPropertyValueCmd:
1121
return super(TestValueArgumentPropertyCmd, self).runTest()
1763
return super(TestPropertyValueCmd, self).runTest()
1122
1765
def run_command(self, value, clients):
1123
self.command(value).run(None, None, clients)
1125
class TestSetCheckerCmd(TestValueArgumentPropertyCmd):
1126
command = SetCheckerCmd
1127
property = "Checker"
1766
self.command(value).run(clients, self.bus)
1769
class TestSetCheckerCmd(TestPropertyValueCmd):
1770
command = command.SetChecker
1771
propname = "Checker"
1128
1772
values_to_set = ["", ":", "fping -q -- %s"]
1130
class TestSetHostCmd(TestValueArgumentPropertyCmd):
1131
command = SetHostCmd
1775
class TestSetHostCmd(TestPropertyValueCmd):
1776
command = command.SetHost
1133
1778
values_to_set = ["192.0.2.3", "foo.example.org"]
1135
class TestSetSecretCmd(TestValueArgumentPropertyCmd):
1136
command = SetSecretCmd
1781
class TestSetSecretCmd(TestPropertyValueCmd):
1782
command = command.SetSecret
1138
1784
values_to_set = [io.BytesIO(b""),
1139
1785
io.BytesIO(b"secret\0xyzzy\nbar")]
1140
1786
values_to_get = [b"", b"secret\0xyzzy\nbar"]
1142
class TestSetTimeoutCmd(TestValueArgumentPropertyCmd):
1143
command = SetTimeoutCmd
1144
property = "Timeout"
1145
values_to_set = [datetime.timedelta(),
1146
datetime.timedelta(minutes=5),
1147
datetime.timedelta(seconds=1),
1148
datetime.timedelta(weeks=1),
1149
datetime.timedelta(weeks=52)]
1150
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1152
class TestSetExtendedTimeoutCmd(TestValueArgumentPropertyCmd):
1153
command = SetExtendedTimeoutCmd
1154
property = "ExtendedTimeout"
1155
values_to_set = [datetime.timedelta(),
1156
datetime.timedelta(minutes=5),
1157
datetime.timedelta(seconds=1),
1158
datetime.timedelta(weeks=1),
1159
datetime.timedelta(weeks=52)]
1160
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1162
class TestSetIntervalCmd(TestValueArgumentPropertyCmd):
1163
command = SetIntervalCmd
1164
property = "Interval"
1165
values_to_set = [datetime.timedelta(),
1166
datetime.timedelta(minutes=5),
1167
datetime.timedelta(seconds=1),
1168
datetime.timedelta(weeks=1),
1169
datetime.timedelta(weeks=52)]
1170
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1172
class TestSetApprovalDelayCmd(TestValueArgumentPropertyCmd):
1173
command = SetApprovalDelayCmd
1174
property = "ApprovalDelay"
1175
values_to_set = [datetime.timedelta(),
1176
datetime.timedelta(minutes=5),
1177
datetime.timedelta(seconds=1),
1178
datetime.timedelta(weeks=1),
1179
datetime.timedelta(weeks=52)]
1180
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1182
class TestSetApprovalDurationCmd(TestValueArgumentPropertyCmd):
1183
command = SetApprovalDurationCmd
1184
property = "ApprovalDuration"
1185
values_to_set = [datetime.timedelta(),
1186
datetime.timedelta(minutes=5),
1187
datetime.timedelta(seconds=1),
1188
datetime.timedelta(weeks=1),
1189
datetime.timedelta(weeks=52)]
1190
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1192
class Test_command_from_options(unittest.TestCase):
1194
self.parser = argparse.ArgumentParser()
1195
add_command_line_options(self.parser)
1196
def assert_command_from_args(self, args, command_cls, **cmd_attrs):
1197
"""Assert that parsing ARGS should result in an instance of
1198
COMMAND_CLS with (optionally) all supplied attributes (CMD_ATTRS)."""
1199
options = self.parser.parse_args(args)
1200
check_option_syntax(self.parser, options)
1201
commands = commands_from_options(options)
1202
self.assertEqual(len(commands), 1)
1203
command = commands[0]
1204
self.assertIsInstance(command, command_cls)
1205
for key, value in cmd_attrs.items():
1206
self.assertEqual(getattr(command, key), value)
1207
def test_print_table(self):
1208
self.assert_command_from_args([], PrintTableCmd,
1211
def test_print_table_verbose(self):
1212
self.assert_command_from_args(["--verbose"], PrintTableCmd,
1215
def test_print_table_verbose_short(self):
1216
self.assert_command_from_args(["-v"], PrintTableCmd,
1219
def test_enable(self):
1220
self.assert_command_from_args(["--enable", "foo"], EnableCmd)
1222
def test_enable_short(self):
1223
self.assert_command_from_args(["-e", "foo"], EnableCmd)
1225
def test_disable(self):
1226
self.assert_command_from_args(["--disable", "foo"],
1229
def test_disable_short(self):
1230
self.assert_command_from_args(["-d", "foo"], DisableCmd)
1232
def test_bump_timeout(self):
1233
self.assert_command_from_args(["--bump-timeout", "foo"],
1236
def test_bump_timeout_short(self):
1237
self.assert_command_from_args(["-b", "foo"], BumpTimeoutCmd)
1239
def test_start_checker(self):
1240
self.assert_command_from_args(["--start-checker", "foo"],
1243
def test_stop_checker(self):
1244
self.assert_command_from_args(["--stop-checker", "foo"],
1247
def test_remove(self):
1248
self.assert_command_from_args(["--remove", "foo"],
1251
def test_remove_short(self):
1252
self.assert_command_from_args(["-r", "foo"], RemoveCmd)
1254
def test_checker(self):
1255
self.assert_command_from_args(["--checker", ":", "foo"],
1256
SetCheckerCmd, value_to_set=":")
1258
def test_checker_empty(self):
1259
self.assert_command_from_args(["--checker", "", "foo"],
1260
SetCheckerCmd, value_to_set="")
1262
def test_checker_short(self):
1263
self.assert_command_from_args(["-c", ":", "foo"],
1264
SetCheckerCmd, value_to_set=":")
1266
def test_timeout(self):
1267
self.assert_command_from_args(["--timeout", "PT5M", "foo"],
1269
value_to_set=300000)
1271
def test_timeout_short(self):
1272
self.assert_command_from_args(["-t", "PT5M", "foo"],
1274
value_to_set=300000)
1276
def test_extended_timeout(self):
1277
self.assert_command_from_args(["--extended-timeout", "PT15M",
1279
SetExtendedTimeoutCmd,
1280
value_to_set=900000)
1282
def test_interval(self):
1283
self.assert_command_from_args(["--interval", "PT2M", "foo"],
1285
value_to_set=120000)
1287
def test_interval_short(self):
1288
self.assert_command_from_args(["-i", "PT2M", "foo"],
1290
value_to_set=120000)
1292
def test_approve_by_default(self):
1293
self.assert_command_from_args(["--approve-by-default", "foo"],
1294
ApproveByDefaultCmd)
1296
def test_deny_by_default(self):
1297
self.assert_command_from_args(["--deny-by-default", "foo"],
1300
def test_approval_delay(self):
1301
self.assert_command_from_args(["--approval-delay", "PT30S",
1302
"foo"], SetApprovalDelayCmd,
1305
def test_approval_duration(self):
1306
self.assert_command_from_args(["--approval-duration", "PT1S",
1307
"foo"], SetApprovalDurationCmd,
1310
def test_host(self):
1311
self.assert_command_from_args(["--host", "foo.example.org",
1313
value_to_set="foo.example.org")
1315
def test_host_short(self):
1316
self.assert_command_from_args(["-H", "foo.example.org",
1318
value_to_set="foo.example.org")
1320
def test_secret_devnull(self):
1321
self.assert_command_from_args(["--secret", os.path.devnull,
1322
"foo"], SetSecretCmd,
1325
def test_secret_tempfile(self):
1326
with tempfile.NamedTemporaryFile(mode="r+b") as f:
1327
value = b"secret\0xyzzy\nbar"
1330
self.assert_command_from_args(["--secret", f.name,
1331
"foo"], SetSecretCmd,
1334
def test_secret_devnull_short(self):
1335
self.assert_command_from_args(["-s", os.path.devnull, "foo"],
1336
SetSecretCmd, value_to_set=b"")
1338
def test_secret_tempfile_short(self):
1339
with tempfile.NamedTemporaryFile(mode="r+b") as f:
1340
value = b"secret\0xyzzy\nbar"
1343
self.assert_command_from_args(["-s", f.name, "foo"],
1347
def test_approve(self):
1348
self.assert_command_from_args(["--approve", "foo"],
1351
def test_approve_short(self):
1352
self.assert_command_from_args(["-A", "foo"], ApproveCmd)
1354
def test_deny(self):
1355
self.assert_command_from_args(["--deny", "foo"], DenyCmd)
1357
def test_deny_short(self):
1358
self.assert_command_from_args(["-D", "foo"], DenyCmd)
1360
def test_dump_json(self):
1361
self.assert_command_from_args(["--dump-json"], DumpJSONCmd)
1363
def test_is_enabled(self):
1364
self.assert_command_from_args(["--is-enabled", "foo"],
1367
def test_is_enabled_short(self):
1368
self.assert_command_from_args(["-V", "foo"], IsEnabledCmd)
1370
def test_deny_before_remove(self):
1371
options = self.parser.parse_args(["--deny", "--remove", "foo"])
1372
check_option_syntax(self.parser, options)
1373
commands = commands_from_options(options)
1374
self.assertEqual(len(commands), 2)
1375
self.assertIsInstance(commands[0], DenyCmd)
1376
self.assertIsInstance(commands[1], RemoveCmd)
1378
def test_deny_before_remove_reversed(self):
1379
options = self.parser.parse_args(["--remove", "--deny", "--all"])
1380
check_option_syntax(self.parser, options)
1381
commands = commands_from_options(options)
1382
self.assertEqual(len(commands), 2)
1383
self.assertIsInstance(commands[0], DenyCmd)
1384
self.assertIsInstance(commands[1], RemoveCmd)
1387
class Test_check_option_syntax(unittest.TestCase):
1388
# This mostly corresponds to the definition from has_actions() in
1389
# check_option_syntax()
1391
# The actual values set here are not that important, but we do
1392
# at least stick to the correct types, even though they are
1396
"bump_timeout": True,
1397
"start_checker": True,
1398
"stop_checker": True,
1402
"timeout": datetime.timedelta(),
1403
"extended_timeout": datetime.timedelta(),
1404
"interval": datetime.timedelta(),
1405
"approved_by_default": True,
1406
"approval_delay": datetime.timedelta(),
1407
"approval_duration": datetime.timedelta(),
1409
"secret": io.BytesIO(b"x"),
1415
self.parser = argparse.ArgumentParser()
1416
add_command_line_options(self.parser)
1418
@contextlib.contextmanager
1419
def assertParseError(self):
1420
with self.assertRaises(SystemExit) as e:
1421
with self.temporarily_suppress_stderr():
1423
# Exit code from argparse is guaranteed to be "2". Reference:
1424
# https://docs.python.org/3/library/argparse.html#exiting-methods
1425
self.assertEqual(e.exception.code, 2)
1428
@contextlib.contextmanager
1429
def temporarily_suppress_stderr():
1430
null = os.open(os.path.devnull, os.O_RDWR)
1431
stderrcopy = os.dup(sys.stderr.fileno())
1432
os.dup2(null, sys.stderr.fileno())
1438
os.dup2(stderrcopy, sys.stderr.fileno())
1439
os.close(stderrcopy)
1441
def check_option_syntax(self, options):
1442
check_option_syntax(self.parser, options)
1444
def test_actions_requires_client_or_all(self):
1445
for action, value in self.actions.items():
1446
options = self.parser.parse_args()
1447
setattr(options, action, value)
1448
with self.assertParseError():
1449
self.check_option_syntax(options)
1451
def test_actions_conflicts_with_verbose(self):
1452
for action, value in self.actions.items():
1453
options = self.parser.parse_args()
1454
setattr(options, action, value)
1455
options.verbose = True
1456
with self.assertParseError():
1457
self.check_option_syntax(options)
1459
def test_dump_json_conflicts_with_verbose(self):
1460
options = self.parser.parse_args()
1461
options.dump_json = True
1462
options.verbose = True
1463
with self.assertParseError():
1464
self.check_option_syntax(options)
1466
def test_dump_json_conflicts_with_action(self):
1467
for action, value in self.actions.items():
1468
options = self.parser.parse_args()
1469
setattr(options, action, value)
1470
options.dump_json = True
1471
with self.assertParseError():
1472
self.check_option_syntax(options)
1474
def test_all_can_not_be_alone(self):
1475
options = self.parser.parse_args()
1477
with self.assertParseError():
1478
self.check_option_syntax(options)
1480
def test_all_is_ok_with_any_action(self):
1481
for action, value in self.actions.items():
1482
options = self.parser.parse_args()
1483
setattr(options, action, value)
1485
self.check_option_syntax(options)
1487
def test_is_enabled_fails_without_client(self):
1488
options = self.parser.parse_args()
1489
options.is_enabled = True
1490
with self.assertParseError():
1491
self.check_option_syntax(options)
1493
def test_is_enabled_works_with_one_client(self):
1494
options = self.parser.parse_args()
1495
options.is_enabled = True
1496
options.client = ["foo"]
1497
self.check_option_syntax(options)
1499
def test_is_enabled_fails_with_two_clients(self):
1500
options = self.parser.parse_args()
1501
options.is_enabled = True
1502
options.client = ["foo", "barbar"]
1503
with self.assertParseError():
1504
self.check_option_syntax(options)
1506
def test_remove_can_only_be_combined_with_action_deny(self):
1507
for action, value in self.actions.items():
1508
if action in {"remove", "deny"}:
1510
options = self.parser.parse_args()
1511
setattr(options, action, value)
1513
options.remove = True
1514
with self.assertParseError():
1515
self.check_option_syntax(options)
1789
class TestSetTimeoutCmd(TestPropertyValueCmd):
1790
command = command.SetTimeout
1791
propname = "Timeout"
1792
values_to_set = [datetime.timedelta(),
1793
datetime.timedelta(minutes=5),
1794
datetime.timedelta(seconds=1),
1795
datetime.timedelta(weeks=1),
1796
datetime.timedelta(weeks=52)]
1797
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1800
class TestSetExtendedTimeoutCmd(TestPropertyValueCmd):
1801
command = command.SetExtendedTimeout
1802
propname = "ExtendedTimeout"
1803
values_to_set = [datetime.timedelta(),
1804
datetime.timedelta(minutes=5),
1805
datetime.timedelta(seconds=1),
1806
datetime.timedelta(weeks=1),
1807
datetime.timedelta(weeks=52)]
1808
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1811
class TestSetIntervalCmd(TestPropertyValueCmd):
1812
command = command.SetInterval
1813
propname = "Interval"
1814
values_to_set = [datetime.timedelta(),
1815
datetime.timedelta(minutes=5),
1816
datetime.timedelta(seconds=1),
1817
datetime.timedelta(weeks=1),
1818
datetime.timedelta(weeks=52)]
1819
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1822
class TestSetApprovalDelayCmd(TestPropertyValueCmd):
1823
command = command.SetApprovalDelay
1824
propname = "ApprovalDelay"
1825
values_to_set = [datetime.timedelta(),
1826
datetime.timedelta(minutes=5),
1827
datetime.timedelta(seconds=1),
1828
datetime.timedelta(weeks=1),
1829
datetime.timedelta(weeks=52)]
1830
values_to_get = [0, 300000, 1000, 604800000, 31449600000]
1833
class TestSetApprovalDurationCmd(TestPropertyValueCmd):
1834
command = command.SetApprovalDuration
1835
propname = "ApprovalDuration"
1836
values_to_set = [datetime.timedelta(),
1837
datetime.timedelta(minutes=5),
1838
datetime.timedelta(seconds=1),
1839
datetime.timedelta(weeks=1),
1840
datetime.timedelta(weeks=52)]
1841
values_to_get = [0, 300000, 1000, 604800000, 31449600000]