/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to mandos-ctl

  • Committer: Teddy Hogeborn
  • Date: 2019-03-06 22:56:24 UTC
  • mto: (237.7.594 trunk)
  • mto: This revision was merged to the branch mainline in revision 382.
  • Revision ID: teddy@recompile.se-20190306225624-834ex7y9sos3vzg4
mandos-ctl: Add test for --checker ""

* mandos-ctl (Test_command_from_options.test_checker_empty): New.

Show diffs side-by-side

added added

removed removed

Lines of Context:
mandos-ctl
42
42
import json
43
43
import unittest
44
44
import logging
 
45
import io
 
46
import tempfile
45
47
 
46
48
import dbus
47
49
 
278
280
        commands which want to operate on all clients at the same time
279
281
        can override this run() method instead."""
280
282
        self.mandos = mandos
281
 
        for client in clients:
282
 
            self.run_on_one_client(client)
 
283
        for client, properties in clients.items():
 
284
            self.run_on_one_client(client, properties)
283
285
 
284
286
class PrintCmd(Command):
285
287
    """Abstract class for commands printing client details"""
295
297
 
296
298
class PropertyCmd(Command):
297
299
    """Abstract class for Actions for setting one client property"""
298
 
    def run_on_one_client(self, client):
 
300
    def run_on_one_client(self, client, properties):
299
301
        """Set the Client's D-Bus property"""
300
302
        client.Set(client_interface, self.property, self.value_to_set,
301
303
                   dbus_interface=dbus.PROPERTIES_IFACE)
323
325
        self.verbose = verbose
324
326
 
325
327
    def output(self, clients):
 
328
        default_keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
 
329
        keywords = default_keywords
326
330
        if self.verbose:
327
331
            keywords = self.all_keywords
328
 
        else:
329
 
            keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
330
332
        return str(self.TableOfClients(clients.values(), keywords))
331
333
 
332
334
    class TableOfClients(object):
419
421
        return value
420
422
 
421
423
class IsEnabledCmd(Command):
422
 
    def run_on_one_client(self, client):
423
 
        if self.is_enabled(client):
 
424
    def run_on_one_client(self, client, properties):
 
425
        if self.is_enabled(client, properties):
424
426
            sys.exit(0)
425
427
        sys.exit(1)
426
 
    def is_enabled(self, client):
427
 
        return client.Get(client_interface, "Enabled",
428
 
                          dbus_interface=dbus.PROPERTIES_IFACE)
 
428
    def is_enabled(self, client, properties):
 
429
        return bool(properties["Enabled"])
429
430
 
430
431
class RemoveCmd(Command):
431
 
    def run_on_one_client(self, client):
 
432
    def run_on_one_client(self, client, properties):
432
433
        self.mandos.RemoveClient(client.__dbus_object_path__)
433
434
 
434
435
class ApproveCmd(Command):
435
 
    def run_on_one_client(self, client):
 
436
    def run_on_one_client(self, client, properties):
436
437
        client.Approve(dbus.Boolean(True),
437
438
                       dbus_interface=client_interface)
438
439
 
439
440
class DenyCmd(Command):
440
 
    def run_on_one_client(self, client):
 
441
    def run_on_one_client(self, client, properties):
441
442
        client.Approve(dbus.Boolean(False),
442
443
                       dbus_interface=client_interface)
443
444
 
476
477
    property = "Host"
477
478
 
478
479
class SetSecretCmd(PropertyCmd, ValueArgumentMixIn):
 
480
    @property
 
481
    def value_to_set(self):
 
482
        return self._vts
 
483
    @value_to_set.setter
 
484
    def value_to_set(self, value):
 
485
        """When setting, read data from supplied file object"""
 
486
        self._vts = value.read()
 
487
        value.close()
479
488
    property = "Secret"
480
489
 
481
490
class SetTimeoutCmd(PropertyCmd, MillisecondsValueArgumentMixIn):
581
590
    parser.add_argument("client", nargs="*", help="Client name")
582
591
 
583
592
 
584
 
def commands_and_clients_from_options(options):
 
593
def commands_from_options(options):
585
594
 
586
595
    commands = []
587
596
 
595
604
        commands.append(DisableCmd())
596
605
 
597
606
    if options.bump_timeout:
598
 
        commands.append(BumpTimeoutCmd(options.bump_timeout))
 
607
        commands.append(BumpTimeoutCmd())
599
608
 
600
609
    if options.start_checker:
601
610
        commands.append(StartCheckerCmd())
610
619
        commands.append(RemoveCmd())
611
620
 
612
621
    if options.checker is not None:
613
 
        commands.append(SetCheckerCmd())
 
622
        commands.append(SetCheckerCmd(options.checker))
614
623
 
615
624
    if options.timeout is not None:
616
625
        commands.append(SetTimeoutCmd(options.timeout))
620
629
            SetExtendedTimeoutCmd(options.extended_timeout))
621
630
 
622
631
    if options.interval is not None:
623
 
        command.append(SetIntervalCmd(options.interval))
 
632
        commands.append(SetIntervalCmd(options.interval))
624
633
 
625
634
    if options.approved_by_default is not None:
626
635
        if options.approved_by_default:
627
 
            command.append(ApproveByDefaultCmd())
 
636
            commands.append(ApproveByDefaultCmd())
628
637
        else:
629
 
            command.append(DenyByDefaultCmd())
 
638
            commands.append(DenyByDefaultCmd())
630
639
 
631
640
    if options.approval_delay is not None:
632
 
        command.append(SetApprovalDelayCmd(options.approval_delay))
 
641
        commands.append(SetApprovalDelayCmd(options.approval_delay))
633
642
 
634
643
    if options.approval_duration is not None:
635
 
        command.append(
 
644
        commands.append(
636
645
            SetApprovalDurationCmd(options.approval_duration))
637
646
 
638
647
    if options.host is not None:
639
 
        command.append(SetHostCmd(options.host))
 
648
        commands.append(SetHostCmd(options.host))
640
649
 
641
650
    if options.secret is not None:
642
 
        command.append(SetSecretCmd(options.secret))
 
651
        commands.append(SetSecretCmd(options.secret))
643
652
 
644
653
    if options.approve:
645
654
        commands.append(ApproveCmd())
652
661
    if not commands:
653
662
        commands.append(PrintTableCmd(verbose=options.verbose))
654
663
 
655
 
    return commands, options.client
 
664
    return commands
656
665
 
657
666
 
658
667
def main():
674
683
    if options.is_enabled and len(options.client) > 1:
675
684
        parser.error("--is-enabled requires exactly one client")
676
685
 
677
 
    commands, clientnames = commands_and_clients_from_options(options)
 
686
    clientnames = options.client
678
687
 
679
688
    try:
680
689
        bus = dbus.SystemBus()
694
703
        def filter(self, record):
695
704
            return False
696
705
    dbus_filter = NullFilter()
697
 
    dbus_logger.addFilter(dbus_filter)
698
706
    try:
699
 
        try:
700
 
            mandos_clients = {path: ifs_and_props[client_interface]
701
 
                              for path, ifs_and_props in
702
 
                              mandos_serv_object_manager
703
 
                              .GetManagedObjects().items()
704
 
                              if client_interface in ifs_and_props}
705
 
        finally:
706
 
            # restore dbus logger
707
 
            dbus_logger.removeFilter(dbus_filter)
 
707
        dbus_logger.addFilter(dbus_filter)
 
708
        mandos_clients = {path: ifs_and_props[client_interface]
 
709
                          for path, ifs_and_props in
 
710
                          mandos_serv_object_manager
 
711
                          .GetManagedObjects().items()
 
712
                          if client_interface in ifs_and_props}
708
713
    except dbus.exceptions.DBusException as e:
709
714
        log.critical("Failed to access Mandos server through D-Bus:"
710
715
                     "\n%s", e)
711
716
        sys.exit(1)
 
717
    finally:
 
718
        # restore dbus logger
 
719
        dbus_logger.removeFilter(dbus_filter)
712
720
 
713
721
    # Compile dict of (clients: properties) to process
714
722
    clients = {}
728
736
                sys.exit(1)
729
737
 
730
738
    # Run all commands on clients
 
739
    commands = commands_from_options(options)
731
740
    for command in commands:
732
741
        command.run(mandos_serv, clients)
733
742
 
747
756
 
748
757
class Test_string_to_delta(unittest.TestCase):
749
758
    def test_handles_basic_rfc3339(self):
 
759
        self.assertEqual(string_to_delta("PT0S"),
 
760
                         datetime.timedelta())
 
761
        self.assertEqual(string_to_delta("P0D"),
 
762
                         datetime.timedelta())
 
763
        self.assertEqual(string_to_delta("PT1S"),
 
764
                         datetime.timedelta(0, 1))
750
765
        self.assertEqual(string_to_delta("PT2H"),
751
766
                         datetime.timedelta(0, 7200))
752
767
    def test_falls_back_to_pre_1_6_1_with_warning(self):
787
802
                testcase.assertEqual(dbus_interface,
788
803
                                     dbus.PROPERTIES_IFACE)
789
804
                self.attributes[property] = value
790
 
                self.calls.append(("Set", (interface, property, value,
791
 
                                           dbus_interface)))
792
805
            def Get(self, interface, property, dbus_interface):
793
806
                testcase.assertEqual(interface, client_interface)
794
807
                testcase.assertEqual(dbus_interface,
795
808
                                     dbus.PROPERTIES_IFACE)
796
 
                self.calls.append(("Get", (interface, property,
797
 
                                           dbus_interface)))
798
809
                return self.attributes[property]
799
 
            def __getitem__(self, key):
800
 
                return self.attributes[key]
801
 
            def __setitem__(self, key, value):
802
 
                self.attributes[key] = value
803
 
        self.clients = collections.OrderedDict([
804
 
            ("foo",
805
 
             MockClient(
806
 
                 "foo",
807
 
                 KeyID=("92ed150794387c03ce684574b1139a65"
808
 
                        "94a34f895daaaf09fd8ea90a27cddb12"),
809
 
                 Secret=b"secret",
810
 
                 Host="foo.example.org",
811
 
                 Enabled=dbus.Boolean(True),
812
 
                 Timeout=300000,
813
 
                 LastCheckedOK="2019-02-03T00:00:00",
814
 
                 Created="2019-01-02T00:00:00",
815
 
                 Interval=120000,
816
 
                 Fingerprint=("778827225BA7DE539C5A"
817
 
                              "7CFA59CFF7CDBD9A5920"),
818
 
                 CheckerRunning=dbus.Boolean(False),
819
 
                 LastEnabled="2019-01-03T00:00:00",
820
 
                 ApprovalPending=dbus.Boolean(False),
821
 
                 ApprovedByDefault=dbus.Boolean(True),
822
 
                 LastApprovalRequest="",
823
 
                 ApprovalDelay=0,
824
 
                 ApprovalDuration=1000,
825
 
                 Checker="fping -q -- %(host)s",
826
 
                 ExtendedTimeout=900000,
827
 
                 Expires="2019-02-04T00:00:00",
828
 
                 LastCheckerStatus=0)),
829
 
            ("barbar",
830
 
             MockClient(
831
 
                 "barbar",
832
 
                 KeyID=("0558568eedd67d622f5c83b35a115f79"
833
 
                        "6ab612cff5ad227247e46c2b020f441c"),
834
 
                 Secret=b"secretbar",
835
 
                 Host="192.0.2.3",
836
 
                 Enabled=dbus.Boolean(True),
837
 
                 Timeout=300000,
838
 
                 LastCheckedOK="2019-02-04T00:00:00",
839
 
                 Created="2019-01-03T00:00:00",
840
 
                 Interval=120000,
841
 
                 Fingerprint=("3E393AEAEFB84C7E89E2"
842
 
                              "F547B3A107558FCA3A27"),
843
 
                 CheckerRunning=dbus.Boolean(True),
844
 
                 LastEnabled="2019-01-04T00:00:00",
845
 
                 ApprovalPending=dbus.Boolean(False),
846
 
                 ApprovedByDefault=dbus.Boolean(False),
847
 
                 LastApprovalRequest="2019-01-03T00:00:00",
848
 
                 ApprovalDelay=30000,
849
 
                 ApprovalDuration=1000,
850
 
                 Checker=":",
851
 
                 ExtendedTimeout=900000,
852
 
                 Expires="2019-02-05T00:00:00",
853
 
                 LastCheckerStatus=-2)),
 
810
            def Approve(self, approve, dbus_interface):
 
811
                testcase.assertEqual(dbus_interface, client_interface)
 
812
                self.calls.append(("Approve", (approve,
 
813
                                               dbus_interface)))
 
814
        self.client = MockClient(
 
815
            "foo",
 
816
            KeyID=("92ed150794387c03ce684574b1139a65"
 
817
                   "94a34f895daaaf09fd8ea90a27cddb12"),
 
818
            Secret=b"secret",
 
819
            Host="foo.example.org",
 
820
            Enabled=dbus.Boolean(True),
 
821
            Timeout=300000,
 
822
            LastCheckedOK="2019-02-03T00:00:00",
 
823
            Created="2019-01-02T00:00:00",
 
824
            Interval=120000,
 
825
            Fingerprint=("778827225BA7DE539C5A"
 
826
                         "7CFA59CFF7CDBD9A5920"),
 
827
            CheckerRunning=dbus.Boolean(False),
 
828
            LastEnabled="2019-01-03T00:00:00",
 
829
            ApprovalPending=dbus.Boolean(False),
 
830
            ApprovedByDefault=dbus.Boolean(True),
 
831
            LastApprovalRequest="",
 
832
            ApprovalDelay=0,
 
833
            ApprovalDuration=1000,
 
834
            Checker="fping -q -- %(host)s",
 
835
            ExtendedTimeout=900000,
 
836
            Expires="2019-02-04T00:00:00",
 
837
            LastCheckerStatus=0)
 
838
        self.other_client = MockClient(
 
839
            "barbar",
 
840
            KeyID=("0558568eedd67d622f5c83b35a115f79"
 
841
                   "6ab612cff5ad227247e46c2b020f441c"),
 
842
            Secret=b"secretbar",
 
843
            Host="192.0.2.3",
 
844
            Enabled=dbus.Boolean(True),
 
845
            Timeout=300000,
 
846
            LastCheckedOK="2019-02-04T00:00:00",
 
847
            Created="2019-01-03T00:00:00",
 
848
            Interval=120000,
 
849
            Fingerprint=("3E393AEAEFB84C7E89E2"
 
850
                         "F547B3A107558FCA3A27"),
 
851
            CheckerRunning=dbus.Boolean(True),
 
852
            LastEnabled="2019-01-04T00:00:00",
 
853
            ApprovalPending=dbus.Boolean(False),
 
854
            ApprovedByDefault=dbus.Boolean(False),
 
855
            LastApprovalRequest="2019-01-03T00:00:00",
 
856
            ApprovalDelay=30000,
 
857
            ApprovalDuration=1000,
 
858
            Checker=":",
 
859
            ExtendedTimeout=900000,
 
860
            Expires="2019-02-05T00:00:00",
 
861
            LastCheckerStatus=-2)
 
862
        self.clients =  collections.OrderedDict(
 
863
            [
 
864
                (self.client, self.client.attributes),
 
865
                (self.other_client, self.other_client.attributes),
854
866
            ])
 
867
        self.one_client = {self.client: self.client.attributes}
855
868
 
856
869
class TestPrintTableCmd(TestCmd):
857
870
    def test_normal(self):
871
884
"""[1:-1]
872
885
        self.assertEqual(output, expected_output)
873
886
    def test_one_client(self):
874
 
        output = PrintTableCmd().output({"foo": self.clients["foo"]})
 
887
        output = PrintTableCmd().output(self.one_client)
875
888
        expected_output = """
876
889
Name Enabled Timeout  Last Successful Check
877
890
foo  Yes     00:05:00 2019-02-03T00:00:00  
935
948
        json_data = json.loads(DumpJSONCmd().output(self.clients))
936
949
        self.assertDictEqual(json_data, self.expected_json)
937
950
    def test_one_client(self):
938
 
        clients = {"foo": self.clients["foo"]}
 
951
        clients = self.one_client
939
952
        json_data = json.loads(DumpJSONCmd().output(clients))
940
953
        expected_json = {"foo": self.expected_json["foo"]}
941
954
        self.assertDictEqual(json_data, expected_json)
942
955
 
943
956
class TestIsEnabledCmd(TestCmd):
944
957
    def test_is_enabled(self):
945
 
        self.assertTrue(all(IsEnabledCmd().is_enabled(client)
946
 
                            for client in self.clients.values()))
947
 
    def test_is_enabled_does_get_attribute(self):
948
 
        client = self.clients["foo"]
949
 
        self.assertTrue(IsEnabledCmd().is_enabled(client))
950
 
        self.assertListEqual(client.calls,
951
 
                             [("Get",
952
 
                               ("se.recompile.Mandos.Client",
953
 
                                "Enabled",
954
 
                                "org.freedesktop.DBus.Properties"))])
 
958
        self.assertTrue(all(IsEnabledCmd().is_enabled(client, properties)
 
959
                            for client, properties in self.clients.items()))
955
960
    def test_is_enabled_run_exits_successfully(self):
956
 
        client = self.clients["foo"]
957
961
        with self.assertRaises(SystemExit) as e:
958
 
            IsEnabledCmd().run_on_one_client(client)
 
962
            IsEnabledCmd().run(None, self.one_client)
959
963
        if e.exception.code is not None:
960
964
            self.assertEqual(e.exception.code, 0)
961
965
        else:
962
966
            self.assertIsNone(e.exception.code)
963
967
    def test_is_enabled_run_exits_with_failure(self):
964
 
        client = self.clients["foo"]
965
 
        client["Enabled"] = dbus.Boolean(False)
 
968
        self.client.attributes["Enabled"] = dbus.Boolean(False)
966
969
        with self.assertRaises(SystemExit) as e:
967
 
            IsEnabledCmd().run_on_one_client(client)
 
970
            IsEnabledCmd().run(None, self.one_client)
968
971
        if isinstance(e.exception.code, int):
969
972
            self.assertNotEqual(e.exception.code, 0)
970
973
        else:
971
974
            self.assertIsNotNone(e.exception.code)
972
975
 
 
976
class TestRemoveCmd(TestCmd):
 
977
    def test_remove(self):
 
978
        class MockMandos(object):
 
979
            def __init__(self):
 
980
                self.calls = []
 
981
            def RemoveClient(self, dbus_path):
 
982
                self.calls.append(("RemoveClient", (dbus_path,)))
 
983
        mandos = MockMandos()
 
984
        super(TestRemoveCmd, self).setUp()
 
985
        RemoveCmd().run(mandos, self.clients)
 
986
        self.assertEqual(len(mandos.calls), 2)
 
987
        for client in self.clients:
 
988
            self.assertIn(("RemoveClient",
 
989
                           (client.__dbus_object_path__,)),
 
990
                          mandos.calls)
 
991
 
 
992
class TestApproveCmd(TestCmd):
 
993
    def test_approve(self):
 
994
        ApproveCmd().run(None, self.clients)
 
995
        for client in self.clients:
 
996
            self.assertIn(("Approve", (True, client_interface)),
 
997
                          client.calls)
 
998
 
 
999
class TestDenyCmd(TestCmd):
 
1000
    def test_deny(self):
 
1001
        DenyCmd().run(None, self.clients)
 
1002
        for client in self.clients:
 
1003
            self.assertIn(("Approve", (False, client_interface)),
 
1004
                          client.calls)
 
1005
 
 
1006
class TestEnableCmd(TestCmd):
 
1007
    def test_enable(self):
 
1008
        for client in self.clients:
 
1009
            client.attributes["Enabled"] = False
 
1010
 
 
1011
        EnableCmd().run(None, self.clients)
 
1012
 
 
1013
        for client in self.clients:
 
1014
            self.assertTrue(client.attributes["Enabled"])
 
1015
 
 
1016
class TestDisableCmd(TestCmd):
 
1017
    def test_disable(self):
 
1018
        DisableCmd().run(None, self.clients)
 
1019
 
 
1020
        for client in self.clients:
 
1021
            self.assertFalse(client.attributes["Enabled"])
 
1022
 
 
1023
class Unique(object):
 
1024
    """Class for objects which exist only to be unique objects, since
 
1025
unittest.mock.sentinel only exists in Python 3.3"""
 
1026
 
 
1027
class TestPropertyCmd(TestCmd):
 
1028
    """Abstract class for tests of PropertyCmd classes"""
 
1029
    def runTest(self):
 
1030
        if not hasattr(self, "command"):
 
1031
            return
 
1032
        values_to_get = getattr(self, "values_to_get",
 
1033
                                self.values_to_set)
 
1034
        for value_to_set, value_to_get in zip(self.values_to_set,
 
1035
                                              values_to_get):
 
1036
            for client in self.clients:
 
1037
                old_value = client.attributes[self.property]
 
1038
                self.assertNotIsInstance(old_value, Unique)
 
1039
                client.attributes[self.property] = Unique()
 
1040
            self.run_command(value_to_set, self.clients)
 
1041
            for client in self.clients:
 
1042
                value = client.attributes[self.property]
 
1043
                self.assertNotIsInstance(value, Unique)
 
1044
                self.assertEqual(value, value_to_get)
 
1045
    def run_command(self, value, clients):
 
1046
        self.command().run(None, clients)
 
1047
 
 
1048
class TestBumpTimeoutCmd(TestPropertyCmd):
 
1049
    command = BumpTimeoutCmd
 
1050
    property = "LastCheckedOK"
 
1051
    values_to_set = [""]
 
1052
 
 
1053
class TestStartCheckerCmd(TestPropertyCmd):
 
1054
    command = StartCheckerCmd
 
1055
    property = "CheckerRunning"
 
1056
    values_to_set = [dbus.Boolean(True)]
 
1057
 
 
1058
class TestStopCheckerCmd(TestPropertyCmd):
 
1059
    command = StopCheckerCmd
 
1060
    property = "CheckerRunning"
 
1061
    values_to_set = [dbus.Boolean(False)]
 
1062
 
 
1063
class TestApproveByDefaultCmd(TestPropertyCmd):
 
1064
    command = ApproveByDefaultCmd
 
1065
    property = "ApprovedByDefault"
 
1066
    values_to_set = [dbus.Boolean(True)]
 
1067
 
 
1068
class TestDenyByDefaultCmd(TestPropertyCmd):
 
1069
    command = DenyByDefaultCmd
 
1070
    property = "ApprovedByDefault"
 
1071
    values_to_set = [dbus.Boolean(False)]
 
1072
 
 
1073
class TestValueArgumentPropertyCmd(TestPropertyCmd):
 
1074
    """Abstract class for tests of PropertyCmd classes using the
 
1075
ValueArgumentMixIn"""
 
1076
    def runTest(self):
 
1077
        if type(self) is TestValueArgumentPropertyCmd:
 
1078
            return
 
1079
        return super(TestValueArgumentPropertyCmd, self).runTest()
 
1080
    def run_command(self, value, clients):
 
1081
        self.command(value).run(None, clients)
 
1082
 
 
1083
class TestSetCheckerCmd(TestValueArgumentPropertyCmd):
 
1084
    command = SetCheckerCmd
 
1085
    property = "Checker"
 
1086
    values_to_set = ["", ":", "fping -q -- %s"]
 
1087
 
 
1088
class TestSetHostCmd(TestValueArgumentPropertyCmd):
 
1089
    command = SetHostCmd
 
1090
    property = "Host"
 
1091
    values_to_set = ["192.0.2.3", "foo.example.org"]
 
1092
 
 
1093
class TestSetSecretCmd(TestValueArgumentPropertyCmd):
 
1094
    command = SetSecretCmd
 
1095
    property = "Secret"
 
1096
    values_to_set = [open("/dev/null", "rb"),
 
1097
                     io.BytesIO(b"secret\0xyzzy\nbar")]
 
1098
    values_to_get = [b"", b"secret\0xyzzy\nbar"]
 
1099
 
 
1100
class TestSetTimeoutCmd(TestValueArgumentPropertyCmd):
 
1101
    command = SetTimeoutCmd
 
1102
    property = "Timeout"
 
1103
    values_to_set = ["P0D", "PT5M", "PT1S", "PT120S", "P1Y"]
 
1104
    values_to_get = [0, 300000, 1000, 120000, 31449600000]
 
1105
 
 
1106
class TestSetExtendedTimeoutCmd(TestValueArgumentPropertyCmd):
 
1107
    command = SetExtendedTimeoutCmd
 
1108
    property = "ExtendedTimeout"
 
1109
    values_to_set = ["P0D", "PT5M", "PT1S", "PT120S", "P1Y"]
 
1110
    values_to_get = [0, 300000, 1000, 120000, 31449600000]
 
1111
 
 
1112
class TestSetIntervalCmd(TestValueArgumentPropertyCmd):
 
1113
    command = SetIntervalCmd
 
1114
    property = "Interval"
 
1115
    values_to_set = ["P0D", "PT5M", "PT1S", "PT120S", "P1Y"]
 
1116
    values_to_get = [0, 300000, 1000, 120000, 31449600000]
 
1117
 
 
1118
class TestSetApprovalDelayCmd(TestValueArgumentPropertyCmd):
 
1119
    command = SetApprovalDelayCmd
 
1120
    property = "ApprovalDelay"
 
1121
    values_to_set = ["P0D", "PT5M", "PT1S", "PT120S", "P1Y"]
 
1122
    values_to_get = [0, 300000, 1000, 120000, 31449600000]
 
1123
 
 
1124
class TestSetApprovalDurationCmd(TestValueArgumentPropertyCmd):
 
1125
    command = SetApprovalDurationCmd
 
1126
    property = "ApprovalDuration"
 
1127
    values_to_set = ["P0D", "PT5M", "PT1S", "PT120S", "P1Y"]
 
1128
    values_to_get = [0, 300000, 1000, 120000, 31449600000]
 
1129
 
 
1130
class Test_command_from_options(unittest.TestCase):
 
1131
    def setUp(self):
 
1132
        self.parser = argparse.ArgumentParser()
 
1133
        add_command_line_options(self.parser)
 
1134
    def assert_command_from_args(self, args, command_cls, **cmd_attrs):
 
1135
        """Assert that parsing ARGS should result in an instance of
 
1136
COMMAND_CLS with (optionally) all supplied attributes (CMD_ATTRS)."""
 
1137
        options = self.parser.parse_args(args)
 
1138
        commands = commands_from_options(options)
 
1139
        self.assertEqual(len(commands), 1)
 
1140
        command = commands[0]
 
1141
        self.assertIsInstance(command, command_cls)
 
1142
        for key, value in cmd_attrs.items():
 
1143
            self.assertEqual(getattr(command, key), value)
 
1144
    def test_print_table(self):
 
1145
        self.assert_command_from_args([], PrintTableCmd,
 
1146
                                      verbose=False)
 
1147
 
 
1148
    def test_print_table_verbose(self):
 
1149
        self.assert_command_from_args(["--verbose"], PrintTableCmd,
 
1150
                                      verbose=True)
 
1151
 
 
1152
    def test_enable(self):
 
1153
        self.assert_command_from_args(["--enable", "foo"], EnableCmd)
 
1154
 
 
1155
    def test_disable(self):
 
1156
        self.assert_command_from_args(["--disable", "foo"],
 
1157
                                      DisableCmd)
 
1158
 
 
1159
    def test_bump_timeout(self):
 
1160
        self.assert_command_from_args(["--bump-timeout", "foo"],
 
1161
                                      BumpTimeoutCmd)
 
1162
 
 
1163
    def test_start_checker(self):
 
1164
        self.assert_command_from_args(["--start-checker", "foo"],
 
1165
                                      StartCheckerCmd)
 
1166
 
 
1167
    def test_stop_checker(self):
 
1168
        self.assert_command_from_args(["--stop-checker", "foo"],
 
1169
                                      StopCheckerCmd)
 
1170
 
 
1171
    def test_remove(self):
 
1172
        self.assert_command_from_args(["--remove", "foo"],
 
1173
                                      RemoveCmd)
 
1174
 
 
1175
    def test_checker(self):
 
1176
        self.assert_command_from_args(["--checker", ":", "foo"],
 
1177
                                      SetCheckerCmd, value_to_set=":")
 
1178
 
 
1179
    def test_checker_empty(self):
 
1180
        self.assert_command_from_args(["--checker", "", "foo"],
 
1181
                                      SetCheckerCmd, value_to_set="")
 
1182
 
 
1183
    def test_timeout(self):
 
1184
        self.assert_command_from_args(["--timeout", "PT5M", "foo"],
 
1185
                                      SetTimeoutCmd,
 
1186
                                      value_to_set=300000)
 
1187
 
 
1188
    def test_extended_timeout(self):
 
1189
        self.assert_command_from_args(["--extended-timeout", "PT15M",
 
1190
                                       "foo"],
 
1191
                                      SetExtendedTimeoutCmd,
 
1192
                                      value_to_set=900000)
 
1193
 
 
1194
    def test_interval(self):
 
1195
        self.assert_command_from_args(["--interval", "PT2M", "foo"],
 
1196
                                      SetIntervalCmd,
 
1197
                                      value_to_set=120000)
 
1198
 
 
1199
    def test_approve_by_default(self):
 
1200
        self.assert_command_from_args(["--approve-by-default", "foo"],
 
1201
                                      ApproveByDefaultCmd)
 
1202
 
 
1203
    def test_deny_by_default(self):
 
1204
        self.assert_command_from_args(["--deny-by-default", "foo"],
 
1205
                                      DenyByDefaultCmd)
 
1206
 
 
1207
    def test_approval_delay(self):
 
1208
        self.assert_command_from_args(["--approval-delay", "PT30S",
 
1209
                                       "foo"], SetApprovalDelayCmd,
 
1210
                                      value_to_set=30000)
 
1211
 
 
1212
    def test_approval_duration(self):
 
1213
        self.assert_command_from_args(["--approval-duration", "PT1S",
 
1214
                                       "foo"], SetApprovalDurationCmd,
 
1215
                                      value_to_set=1000)
 
1216
 
 
1217
    def test_host(self):
 
1218
        self.assert_command_from_args(["--host", "foo.example.org",
 
1219
                                       "foo"], SetHostCmd,
 
1220
                                      value_to_set="foo.example.org")
 
1221
 
 
1222
    def test_secret_devnull(self):
 
1223
        self.assert_command_from_args(["--secret", os.path.devnull,
 
1224
                                       "foo"], SetSecretCmd,
 
1225
                                      value_to_set=b"")
 
1226
 
 
1227
    def test_secret_tempfile(self):
 
1228
        with tempfile.NamedTemporaryFile(mode="r+b") as f:
 
1229
            value = b"secret\0xyzzy\nbar"
 
1230
            f.write(value)
 
1231
            f.seek(0)
 
1232
            self.assert_command_from_args(["--secret", f.name,
 
1233
                                           "foo"], SetSecretCmd,
 
1234
                                          value_to_set=value)
 
1235
 
 
1236
    def test_approve(self):
 
1237
        self.assert_command_from_args(["--approve", "foo"],
 
1238
                                      ApproveCmd)
 
1239
 
 
1240
    def test_deny(self):
 
1241
        self.assert_command_from_args(["--deny", "foo"], DenyCmd)
 
1242
 
 
1243
    def test_dump_json(self):
 
1244
        self.assert_command_from_args(["--dump-json"], DumpJSONCmd)
 
1245
 
 
1246
    def test_is_enabled(self):
 
1247
        self.assert_command_from_args(["--is-enabled", "foo"],
 
1248
                                      IsEnabledCmd)
 
1249
 
973
1250
 
974
1251
 
975
1252
def should_only_run_tests():