/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to mandos-ctl

  • Committer: Teddy Hogeborn
  • Date: 2019-03-03 18:11:39 UTC
  • mto: (237.7.594 trunk)
  • mto: This revision was merged to the branch mainline in revision 382.
  • Revision ID: teddy@recompile.se-20190303181139-f8r50k8bgirs3d5f
mandos-ctl: Add test for IsEnabledCmd class

* mandos-ctl (TestCmd.setUp.MockClient.Set,
              TestCmd.setUp.MockClient.Get): Fix bugs.
  (TestCmd.setUp.MockClient.__setitem__): New.
  (TestIsEnabledCmd): New.

Show diffs side-by-side

added added

removed removed

Lines of Context:
mandos-ctl
42
42
import json
43
43
import unittest
44
44
import logging
45
 
import io
46
 
import tempfile
47
45
 
48
46
import dbus
49
47
 
280
278
        commands which want to operate on all clients at the same time
281
279
        can override this run() method instead."""
282
280
        self.mandos = mandos
283
 
        for client, properties in clients.items():
284
 
            self.run_on_one_client(client, properties)
 
281
        for client in clients:
 
282
            self.run_on_one_client(client)
285
283
 
286
284
class PrintCmd(Command):
287
285
    """Abstract class for commands printing client details"""
297
295
 
298
296
class PropertyCmd(Command):
299
297
    """Abstract class for Actions for setting one client property"""
300
 
    def run_on_one_client(self, client, properties):
 
298
    def run_on_one_client(self, client):
301
299
        """Set the Client's D-Bus property"""
302
300
        client.Set(client_interface, self.property, self.value_to_set,
303
301
                   dbus_interface=dbus.PROPERTIES_IFACE)
325
323
        self.verbose = verbose
326
324
 
327
325
    def output(self, clients):
328
 
        default_keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
329
 
        keywords = default_keywords
330
326
        if self.verbose:
331
327
            keywords = self.all_keywords
 
328
        else:
 
329
            keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
332
330
        return str(self.TableOfClients(clients.values(), keywords))
333
331
 
334
332
    class TableOfClients(object):
421
419
        return value
422
420
 
423
421
class IsEnabledCmd(Command):
424
 
    def run_on_one_client(self, client, properties):
425
 
        if self.is_enabled(client, properties):
 
422
    def run_on_one_client(self, client):
 
423
        if self.is_enabled(client):
426
424
            sys.exit(0)
427
425
        sys.exit(1)
428
 
    def is_enabled(self, client, properties):
429
 
        return bool(properties["Enabled"])
 
426
    def is_enabled(self, client):
 
427
        return client.Get(client_interface, "Enabled",
 
428
                          dbus_interface=dbus.PROPERTIES_IFACE)
430
429
 
431
430
class RemoveCmd(Command):
432
 
    def run_on_one_client(self, client, properties):
 
431
    def run_on_one_client(self, client):
433
432
        self.mandos.RemoveClient(client.__dbus_object_path__)
434
433
 
435
434
class ApproveCmd(Command):
436
 
    def run_on_one_client(self, client, properties):
 
435
    def run_on_one_client(self, client):
437
436
        client.Approve(dbus.Boolean(True),
438
437
                       dbus_interface=client_interface)
439
438
 
440
439
class DenyCmd(Command):
441
 
    def run_on_one_client(self, client, properties):
 
440
    def run_on_one_client(self, client):
442
441
        client.Approve(dbus.Boolean(False),
443
442
                       dbus_interface=client_interface)
444
443
 
477
476
    property = "Host"
478
477
 
479
478
class SetSecretCmd(PropertyCmd, ValueArgumentMixIn):
480
 
    @property
481
 
    def value_to_set(self):
482
 
        return self._vts
483
 
    @value_to_set.setter
484
 
    def value_to_set(self, value):
485
 
        """When setting, read data from supplied file object"""
486
 
        self._vts = value.read()
487
 
        value.close()
488
479
    property = "Secret"
489
480
 
490
481
class SetTimeoutCmd(PropertyCmd, MillisecondsValueArgumentMixIn):
525
516
                options.approve,
526
517
                options.deny))
527
518
 
528
 
def add_command_line_options(parser):
 
519
 
 
520
def commands_and_clients_from_options(args=None):
 
521
    if args is None:
 
522
        args=sys.argv[1:]
 
523
    parser = argparse.ArgumentParser()
529
524
    parser.add_argument("--version", action="version",
530
525
                        version="%(prog)s {}".format(version),
531
526
                        help="show version number and exit")
588
583
    parser.add_argument("--check", action="store_true",
589
584
                        help="Run self-test")
590
585
    parser.add_argument("client", nargs="*", help="Client name")
591
 
 
592
 
 
593
 
def commands_from_options(options):
 
586
    options = parser.parse_args(args=args)
 
587
 
 
588
    if has_actions(options) and not (options.client or options.all):
 
589
        parser.error("Options require clients names or --all.")
 
590
    if options.verbose and has_actions(options):
 
591
        parser.error("--verbose can only be used alone.")
 
592
    if options.dump_json and (options.verbose
 
593
                              or has_actions(options)):
 
594
        parser.error("--dump-json can only be used alone.")
 
595
    if options.all and not has_actions(options):
 
596
        parser.error("--all requires an action.")
 
597
    if options.is_enabled and len(options.client) > 1:
 
598
            parser.error("--is-enabled requires exactly one client")
594
599
 
595
600
    commands = []
596
601
 
604
609
        commands.append(DisableCmd())
605
610
 
606
611
    if options.bump_timeout:
607
 
        commands.append(BumpTimeoutCmd())
 
612
        commands.append(BumpTimeoutCmd(options.bump_timeout))
608
613
 
609
614
    if options.start_checker:
610
615
        commands.append(StartCheckerCmd())
619
624
        commands.append(RemoveCmd())
620
625
 
621
626
    if options.checker is not None:
622
 
        commands.append(SetCheckerCmd(options.checker))
 
627
        commands.append(SetCheckerCmd())
623
628
 
624
629
    if options.timeout is not None:
625
630
        commands.append(SetTimeoutCmd(options.timeout))
629
634
            SetExtendedTimeoutCmd(options.extended_timeout))
630
635
 
631
636
    if options.interval is not None:
632
 
        commands.append(SetIntervalCmd(options.interval))
 
637
        command.append(SetIntervalCmd(options.interval))
633
638
 
634
639
    if options.approved_by_default is not None:
635
640
        if options.approved_by_default:
636
 
            commands.append(ApproveByDefaultCmd())
 
641
            command.append(ApproveByDefaultCmd())
637
642
        else:
638
 
            commands.append(DenyByDefaultCmd())
 
643
            command.append(DenyByDefaultCmd())
639
644
 
640
645
    if options.approval_delay is not None:
641
 
        commands.append(SetApprovalDelayCmd(options.approval_delay))
 
646
        command.append(SetApprovalDelayCmd(options.approval_delay))
642
647
 
643
648
    if options.approval_duration is not None:
644
 
        commands.append(
 
649
        command.append(
645
650
            SetApprovalDurationCmd(options.approval_duration))
646
651
 
647
652
    if options.host is not None:
648
 
        commands.append(SetHostCmd(options.host))
 
653
        command.append(SetHostCmd(options.host))
649
654
 
650
655
    if options.secret is not None:
651
 
        commands.append(SetSecretCmd(options.secret))
 
656
        command.append(SetSecretCmd(options.secret))
652
657
 
653
658
    if options.approve:
654
659
        commands.append(ApproveCmd())
661
666
    if not commands:
662
667
        commands.append(PrintTableCmd(verbose=options.verbose))
663
668
 
664
 
    return commands
 
669
    return commands, options.client
665
670
 
666
671
 
667
672
def main():
668
 
    parser = argparse.ArgumentParser()
669
 
 
670
 
    add_command_line_options(parser)
671
 
 
672
 
    options = parser.parse_args()
673
 
 
674
 
    if has_actions(options) and not (options.client or options.all):
675
 
        parser.error("Options require clients names or --all.")
676
 
    if options.verbose and has_actions(options):
677
 
        parser.error("--verbose can only be used alone.")
678
 
    if options.dump_json and (options.verbose
679
 
                              or has_actions(options)):
680
 
        parser.error("--dump-json can only be used alone.")
681
 
    if options.all and not has_actions(options):
682
 
        parser.error("--all requires an action.")
683
 
    if options.is_enabled and len(options.client) > 1:
684
 
        parser.error("--is-enabled requires exactly one client")
685
 
 
686
 
    clientnames = options.client
 
673
    commands, clientnames = commands_and_clients_from_options()
687
674
 
688
675
    try:
689
676
        bus = dbus.SystemBus()
703
690
        def filter(self, record):
704
691
            return False
705
692
    dbus_filter = NullFilter()
 
693
    dbus_logger.addFilter(dbus_filter)
706
694
    try:
707
 
        dbus_logger.addFilter(dbus_filter)
708
 
        mandos_clients = {path: ifs_and_props[client_interface]
709
 
                          for path, ifs_and_props in
710
 
                          mandos_serv_object_manager
711
 
                          .GetManagedObjects().items()
712
 
                          if client_interface in ifs_and_props}
 
695
        try:
 
696
            mandos_clients = {path: ifs_and_props[client_interface]
 
697
                              for path, ifs_and_props in
 
698
                              mandos_serv_object_manager
 
699
                              .GetManagedObjects().items()
 
700
                              if client_interface in ifs_and_props}
 
701
        finally:
 
702
            # restore dbus logger
 
703
            dbus_logger.removeFilter(dbus_filter)
713
704
    except dbus.exceptions.DBusException as e:
714
705
        log.critical("Failed to access Mandos server through D-Bus:"
715
706
                     "\n%s", e)
716
707
        sys.exit(1)
717
 
    finally:
718
 
        # restore dbus logger
719
 
        dbus_logger.removeFilter(dbus_filter)
720
708
 
721
709
    # Compile dict of (clients: properties) to process
722
710
    clients = {}
736
724
                sys.exit(1)
737
725
 
738
726
    # Run all commands on clients
739
 
    commands = commands_from_options(options)
740
727
    for command in commands:
741
728
        command.run(mandos_serv, clients)
742
729
 
756
743
 
757
744
class Test_string_to_delta(unittest.TestCase):
758
745
    def test_handles_basic_rfc3339(self):
759
 
        self.assertEqual(string_to_delta("PT0S"),
760
 
                         datetime.timedelta())
761
 
        self.assertEqual(string_to_delta("P0D"),
762
 
                         datetime.timedelta())
763
 
        self.assertEqual(string_to_delta("PT1S"),
764
 
                         datetime.timedelta(0, 1))
765
746
        self.assertEqual(string_to_delta("PT2H"),
766
747
                         datetime.timedelta(0, 7200))
767
748
    def test_falls_back_to_pre_1_6_1_with_warning(self):
802
783
                testcase.assertEqual(dbus_interface,
803
784
                                     dbus.PROPERTIES_IFACE)
804
785
                self.attributes[property] = value
 
786
                self.calls.append(("Set", (interface, property, value,
 
787
                                           dbus_interface)))
805
788
            def Get(self, interface, property, dbus_interface):
806
789
                testcase.assertEqual(interface, client_interface)
807
790
                testcase.assertEqual(dbus_interface,
808
791
                                     dbus.PROPERTIES_IFACE)
 
792
                self.calls.append(("Get", (interface, property,
 
793
                                           dbus_interface)))
809
794
                return self.attributes[property]
810
 
            def Approve(self, approve, dbus_interface):
811
 
                testcase.assertEqual(dbus_interface, client_interface)
812
 
                self.calls.append(("Approve", (approve,
813
 
                                               dbus_interface)))
814
 
        self.client = MockClient(
815
 
            "foo",
816
 
            KeyID=("92ed150794387c03ce684574b1139a65"
817
 
                   "94a34f895daaaf09fd8ea90a27cddb12"),
818
 
            Secret=b"secret",
819
 
            Host="foo.example.org",
820
 
            Enabled=dbus.Boolean(True),
821
 
            Timeout=300000,
822
 
            LastCheckedOK="2019-02-03T00:00:00",
823
 
            Created="2019-01-02T00:00:00",
824
 
            Interval=120000,
825
 
            Fingerprint=("778827225BA7DE539C5A"
826
 
                         "7CFA59CFF7CDBD9A5920"),
827
 
            CheckerRunning=dbus.Boolean(False),
828
 
            LastEnabled="2019-01-03T00:00:00",
829
 
            ApprovalPending=dbus.Boolean(False),
830
 
            ApprovedByDefault=dbus.Boolean(True),
831
 
            LastApprovalRequest="",
832
 
            ApprovalDelay=0,
833
 
            ApprovalDuration=1000,
834
 
            Checker="fping -q -- %(host)s",
835
 
            ExtendedTimeout=900000,
836
 
            Expires="2019-02-04T00:00:00",
837
 
            LastCheckerStatus=0)
838
 
        self.other_client = MockClient(
839
 
            "barbar",
840
 
            KeyID=("0558568eedd67d622f5c83b35a115f79"
841
 
                   "6ab612cff5ad227247e46c2b020f441c"),
842
 
            Secret=b"secretbar",
843
 
            Host="192.0.2.3",
844
 
            Enabled=dbus.Boolean(True),
845
 
            Timeout=300000,
846
 
            LastCheckedOK="2019-02-04T00:00:00",
847
 
            Created="2019-01-03T00:00:00",
848
 
            Interval=120000,
849
 
            Fingerprint=("3E393AEAEFB84C7E89E2"
850
 
                         "F547B3A107558FCA3A27"),
851
 
            CheckerRunning=dbus.Boolean(True),
852
 
            LastEnabled="2019-01-04T00:00:00",
853
 
            ApprovalPending=dbus.Boolean(False),
854
 
            ApprovedByDefault=dbus.Boolean(False),
855
 
            LastApprovalRequest="2019-01-03T00:00:00",
856
 
            ApprovalDelay=30000,
857
 
            ApprovalDuration=1000,
858
 
            Checker=":",
859
 
            ExtendedTimeout=900000,
860
 
            Expires="2019-02-05T00:00:00",
861
 
            LastCheckerStatus=-2)
862
 
        self.clients =  collections.OrderedDict(
863
 
            [
864
 
                (self.client, self.client.attributes),
865
 
                (self.other_client, self.other_client.attributes),
 
795
            def __getitem__(self, key):
 
796
                return self.attributes[key]
 
797
            def __setitem__(self, key, value):
 
798
                self.attributes[key] = value
 
799
        self.clients = collections.OrderedDict([
 
800
            ("foo",
 
801
             MockClient(
 
802
                 "foo",
 
803
                 KeyID=("92ed150794387c03ce684574b1139a65"
 
804
                        "94a34f895daaaf09fd8ea90a27cddb12"),
 
805
                 Secret=b"secret",
 
806
                 Host="foo.example.org",
 
807
                 Enabled=dbus.Boolean(True),
 
808
                 Timeout=300000,
 
809
                 LastCheckedOK="2019-02-03T00:00:00",
 
810
                 Created="2019-01-02T00:00:00",
 
811
                 Interval=120000,
 
812
                 Fingerprint=("778827225BA7DE539C5A"
 
813
                              "7CFA59CFF7CDBD9A5920"),
 
814
                 CheckerRunning=dbus.Boolean(False),
 
815
                 LastEnabled="2019-01-03T00:00:00",
 
816
                 ApprovalPending=dbus.Boolean(False),
 
817
                 ApprovedByDefault=dbus.Boolean(True),
 
818
                 LastApprovalRequest="",
 
819
                 ApprovalDelay=0,
 
820
                 ApprovalDuration=1000,
 
821
                 Checker="fping -q -- %(host)s",
 
822
                 ExtendedTimeout=900000,
 
823
                 Expires="2019-02-04T00:00:00",
 
824
                 LastCheckerStatus=0)),
 
825
            ("barbar",
 
826
             MockClient(
 
827
                 "barbar",
 
828
                 KeyID=("0558568eedd67d622f5c83b35a115f79"
 
829
                        "6ab612cff5ad227247e46c2b020f441c"),
 
830
                 Secret=b"secretbar",
 
831
                 Host="192.0.2.3",
 
832
                 Enabled=dbus.Boolean(True),
 
833
                 Timeout=300000,
 
834
                 LastCheckedOK="2019-02-04T00:00:00",
 
835
                 Created="2019-01-03T00:00:00",
 
836
                 Interval=120000,
 
837
                 Fingerprint=("3E393AEAEFB84C7E89E2"
 
838
                              "F547B3A107558FCA3A27"),
 
839
                 CheckerRunning=dbus.Boolean(True),
 
840
                 LastEnabled="2019-01-04T00:00:00",
 
841
                 ApprovalPending=dbus.Boolean(False),
 
842
                 ApprovedByDefault=dbus.Boolean(False),
 
843
                 LastApprovalRequest="2019-01-03T00:00:00",
 
844
                 ApprovalDelay=30000,
 
845
                 ApprovalDuration=1000,
 
846
                 Checker=":",
 
847
                 ExtendedTimeout=900000,
 
848
                 Expires="2019-02-05T00:00:00",
 
849
                 LastCheckerStatus=-2)),
866
850
            ])
867
 
        self.one_client = {self.client: self.client.attributes}
868
851
 
869
852
class TestPrintTableCmd(TestCmd):
870
853
    def test_normal(self):
884
867
"""[1:-1]
885
868
        self.assertEqual(output, expected_output)
886
869
    def test_one_client(self):
887
 
        output = PrintTableCmd().output(self.one_client)
 
870
        output = PrintTableCmd().output({"foo": self.clients["foo"]})
888
871
        expected_output = """
889
872
Name Enabled Timeout  Last Successful Check
890
873
foo  Yes     00:05:00 2019-02-03T00:00:00  
948
931
        json_data = json.loads(DumpJSONCmd().output(self.clients))
949
932
        self.assertDictEqual(json_data, self.expected_json)
950
933
    def test_one_client(self):
951
 
        clients = self.one_client
 
934
        clients = {"foo": self.clients["foo"]}
952
935
        json_data = json.loads(DumpJSONCmd().output(clients))
953
936
        expected_json = {"foo": self.expected_json["foo"]}
954
937
        self.assertDictEqual(json_data, expected_json)
955
938
 
956
939
class TestIsEnabledCmd(TestCmd):
957
940
    def test_is_enabled(self):
958
 
        self.assertTrue(all(IsEnabledCmd().is_enabled(client, properties)
959
 
                            for client, properties in self.clients.items()))
 
941
        self.assertTrue(all(IsEnabledCmd().is_enabled(client)
 
942
                            for client in self.clients.values()))
 
943
    def test_is_enabled_does_get_attribute(self):
 
944
        client = self.clients["foo"]
 
945
        self.assertTrue(IsEnabledCmd().is_enabled(client))
 
946
        self.assertListEqual(client.calls,
 
947
                             [("Get",
 
948
                               ("se.recompile.Mandos.Client",
 
949
                                "Enabled",
 
950
                                "org.freedesktop.DBus.Properties"))])
960
951
    def test_is_enabled_run_exits_successfully(self):
 
952
        client = self.clients["foo"]
961
953
        with self.assertRaises(SystemExit) as e:
962
 
            IsEnabledCmd().run(None, self.one_client)
 
954
            IsEnabledCmd().run_on_one_client(client)
963
955
        if e.exception.code is not None:
964
956
            self.assertEqual(e.exception.code, 0)
965
957
        else:
966
958
            self.assertIsNone(e.exception.code)
967
959
    def test_is_enabled_run_exits_with_failure(self):
968
 
        self.client.attributes["Enabled"] = dbus.Boolean(False)
 
960
        client = self.clients["foo"]
 
961
        client["Enabled"] = dbus.Boolean(False)
969
962
        with self.assertRaises(SystemExit) as e:
970
 
            IsEnabledCmd().run(None, self.one_client)
 
963
            IsEnabledCmd().run_on_one_client(client)
971
964
        if isinstance(e.exception.code, int):
972
965
            self.assertNotEqual(e.exception.code, 0)
973
966
        else:
974
967
            self.assertIsNotNone(e.exception.code)
975
968
 
976
 
class TestRemoveCmd(TestCmd):
977
 
    def test_remove(self):
978
 
        class MockMandos(object):
979
 
            def __init__(self):
980
 
                self.calls = []
981
 
            def RemoveClient(self, dbus_path):
982
 
                self.calls.append(("RemoveClient", (dbus_path,)))
983
 
        mandos = MockMandos()
984
 
        super(TestRemoveCmd, self).setUp()
985
 
        RemoveCmd().run(mandos, self.clients)
986
 
        self.assertEqual(len(mandos.calls), 2)
987
 
        for client in self.clients:
988
 
            self.assertIn(("RemoveClient",
989
 
                           (client.__dbus_object_path__,)),
990
 
                          mandos.calls)
991
 
 
992
 
class TestApproveCmd(TestCmd):
993
 
    def test_approve(self):
994
 
        ApproveCmd().run(None, self.clients)
995
 
        for client in self.clients:
996
 
            self.assertIn(("Approve", (True, client_interface)),
997
 
                          client.calls)
998
 
 
999
 
class TestDenyCmd(TestCmd):
1000
 
    def test_deny(self):
1001
 
        DenyCmd().run(None, self.clients)
1002
 
        for client in self.clients:
1003
 
            self.assertIn(("Approve", (False, client_interface)),
1004
 
                          client.calls)
1005
 
 
1006
 
class TestEnableCmd(TestCmd):
1007
 
    def test_enable(self):
1008
 
        for client in self.clients:
1009
 
            client.attributes["Enabled"] = False
1010
 
 
1011
 
        EnableCmd().run(None, self.clients)
1012
 
 
1013
 
        for client in self.clients:
1014
 
            self.assertTrue(client.attributes["Enabled"])
1015
 
 
1016
 
class TestDisableCmd(TestCmd):
1017
 
    def test_disable(self):
1018
 
        DisableCmd().run(None, self.clients)
1019
 
 
1020
 
        for client in self.clients:
1021
 
            self.assertFalse(client.attributes["Enabled"])
1022
 
 
1023
 
class Unique(object):
1024
 
    """Class for objects which exist only to be unique objects, since
1025
 
unittest.mock.sentinel only exists in Python 3.3"""
1026
 
 
1027
 
class TestPropertyCmd(TestCmd):
1028
 
    """Abstract class for tests of PropertyCmd classes"""
1029
 
    def runTest(self):
1030
 
        if not hasattr(self, "command"):
1031
 
            return
1032
 
        values_to_get = getattr(self, "values_to_get",
1033
 
                                self.values_to_set)
1034
 
        for value_to_set, value_to_get in zip(self.values_to_set,
1035
 
                                              values_to_get):
1036
 
            for client in self.clients:
1037
 
                old_value = client.attributes[self.property]
1038
 
                self.assertNotIsInstance(old_value, Unique)
1039
 
                client.attributes[self.property] = Unique()
1040
 
            self.run_command(value_to_set, self.clients)
1041
 
            for client in self.clients:
1042
 
                value = client.attributes[self.property]
1043
 
                self.assertNotIsInstance(value, Unique)
1044
 
                self.assertEqual(value, value_to_get)
1045
 
    def run_command(self, value, clients):
1046
 
        self.command().run(None, clients)
1047
 
 
1048
 
class TestBumpTimeoutCmd(TestPropertyCmd):
1049
 
    command = BumpTimeoutCmd
1050
 
    property = "LastCheckedOK"
1051
 
    values_to_set = [""]
1052
 
 
1053
 
class TestStartCheckerCmd(TestPropertyCmd):
1054
 
    command = StartCheckerCmd
1055
 
    property = "CheckerRunning"
1056
 
    values_to_set = [dbus.Boolean(True)]
1057
 
 
1058
 
class TestStopCheckerCmd(TestPropertyCmd):
1059
 
    command = StopCheckerCmd
1060
 
    property = "CheckerRunning"
1061
 
    values_to_set = [dbus.Boolean(False)]
1062
 
 
1063
 
class TestApproveByDefaultCmd(TestPropertyCmd):
1064
 
    command = ApproveByDefaultCmd
1065
 
    property = "ApprovedByDefault"
1066
 
    values_to_set = [dbus.Boolean(True)]
1067
 
 
1068
 
class TestDenyByDefaultCmd(TestPropertyCmd):
1069
 
    command = DenyByDefaultCmd
1070
 
    property = "ApprovedByDefault"
1071
 
    values_to_set = [dbus.Boolean(False)]
1072
 
 
1073
 
class TestValueArgumentPropertyCmd(TestPropertyCmd):
1074
 
    """Abstract class for tests of PropertyCmd classes using the
1075
 
ValueArgumentMixIn"""
1076
 
    def runTest(self):
1077
 
        if type(self) is TestValueArgumentPropertyCmd:
1078
 
            return
1079
 
        return super(TestValueArgumentPropertyCmd, self).runTest()
1080
 
    def run_command(self, value, clients):
1081
 
        self.command(value).run(None, clients)
1082
 
 
1083
 
class TestSetCheckerCmd(TestValueArgumentPropertyCmd):
1084
 
    command = SetCheckerCmd
1085
 
    property = "Checker"
1086
 
    values_to_set = ["", ":", "fping -q -- %s"]
1087
 
 
1088
 
class TestSetHostCmd(TestValueArgumentPropertyCmd):
1089
 
    command = SetHostCmd
1090
 
    property = "Host"
1091
 
    values_to_set = ["192.0.2.3", "foo.example.org"]
1092
 
 
1093
 
class TestSetSecretCmd(TestValueArgumentPropertyCmd):
1094
 
    command = SetSecretCmd
1095
 
    property = "Secret"
1096
 
    values_to_set = [open("/dev/null", "rb"),
1097
 
                     io.BytesIO(b"secret\0xyzzy\nbar")]
1098
 
    values_to_get = [b"", b"secret\0xyzzy\nbar"]
1099
 
 
1100
 
class TestSetTimeoutCmd(TestValueArgumentPropertyCmd):
1101
 
    command = SetTimeoutCmd
1102
 
    property = "Timeout"
1103
 
    values_to_set = ["P0D", "PT5M", "PT1S", "PT120S", "P1Y"]
1104
 
    values_to_get = [0, 300000, 1000, 120000, 31449600000]
1105
 
 
1106
 
class TestSetExtendedTimeoutCmd(TestValueArgumentPropertyCmd):
1107
 
    command = SetExtendedTimeoutCmd
1108
 
    property = "ExtendedTimeout"
1109
 
    values_to_set = ["P0D", "PT5M", "PT1S", "PT120S", "P1Y"]
1110
 
    values_to_get = [0, 300000, 1000, 120000, 31449600000]
1111
 
 
1112
 
class TestSetIntervalCmd(TestValueArgumentPropertyCmd):
1113
 
    command = SetIntervalCmd
1114
 
    property = "Interval"
1115
 
    values_to_set = ["P0D", "PT5M", "PT1S", "PT120S", "P1Y"]
1116
 
    values_to_get = [0, 300000, 1000, 120000, 31449600000]
1117
 
 
1118
 
class TestSetApprovalDelayCmd(TestValueArgumentPropertyCmd):
1119
 
    command = SetApprovalDelayCmd
1120
 
    property = "ApprovalDelay"
1121
 
    values_to_set = ["P0D", "PT5M", "PT1S", "PT120S", "P1Y"]
1122
 
    values_to_get = [0, 300000, 1000, 120000, 31449600000]
1123
 
 
1124
 
class TestSetApprovalDurationCmd(TestValueArgumentPropertyCmd):
1125
 
    command = SetApprovalDurationCmd
1126
 
    property = "ApprovalDuration"
1127
 
    values_to_set = ["P0D", "PT5M", "PT1S", "PT120S", "P1Y"]
1128
 
    values_to_get = [0, 300000, 1000, 120000, 31449600000]
1129
 
 
1130
 
class Test_command_from_options(unittest.TestCase):
1131
 
    def setUp(self):
1132
 
        self.parser = argparse.ArgumentParser()
1133
 
        add_command_line_options(self.parser)
1134
 
    def assert_command_from_args(self, args, command_cls, **cmd_attrs):
1135
 
        """Assert that parsing ARGS should result in an instance of
1136
 
COMMAND_CLS with (optionally) all supplied attributes (CMD_ATTRS)."""
1137
 
        options = self.parser.parse_args(args)
1138
 
        commands = commands_from_options(options)
1139
 
        self.assertEqual(len(commands), 1)
1140
 
        command = commands[0]
1141
 
        self.assertIsInstance(command, command_cls)
1142
 
        for key, value in cmd_attrs.items():
1143
 
            self.assertEqual(getattr(command, key), value)
1144
 
    def test_print_table(self):
1145
 
        self.assert_command_from_args([], PrintTableCmd,
1146
 
                                      verbose=False)
1147
 
 
1148
 
    def test_print_table_verbose(self):
1149
 
        self.assert_command_from_args(["--verbose"], PrintTableCmd,
1150
 
                                      verbose=True)
1151
 
 
1152
 
    def test_enable(self):
1153
 
        self.assert_command_from_args(["--enable", "foo"], EnableCmd)
1154
 
 
1155
 
    def test_disable(self):
1156
 
        self.assert_command_from_args(["--disable", "foo"],
1157
 
                                      DisableCmd)
1158
 
 
1159
 
    def test_bump_timeout(self):
1160
 
        self.assert_command_from_args(["--bump-timeout", "foo"],
1161
 
                                      BumpTimeoutCmd)
1162
 
 
1163
 
    def test_start_checker(self):
1164
 
        self.assert_command_from_args(["--start-checker", "foo"],
1165
 
                                      StartCheckerCmd)
1166
 
 
1167
 
    def test_stop_checker(self):
1168
 
        self.assert_command_from_args(["--stop-checker", "foo"],
1169
 
                                      StopCheckerCmd)
1170
 
 
1171
 
    def test_remove(self):
1172
 
        self.assert_command_from_args(["--remove", "foo"],
1173
 
                                      RemoveCmd)
1174
 
 
1175
 
    def test_checker(self):
1176
 
        self.assert_command_from_args(["--checker", ":", "foo"],
1177
 
                                      SetCheckerCmd, value_to_set=":")
1178
 
 
1179
 
    def test_checker_empty(self):
1180
 
        self.assert_command_from_args(["--checker", "", "foo"],
1181
 
                                      SetCheckerCmd, value_to_set="")
1182
 
 
1183
 
    def test_timeout(self):
1184
 
        self.assert_command_from_args(["--timeout", "PT5M", "foo"],
1185
 
                                      SetTimeoutCmd,
1186
 
                                      value_to_set=300000)
1187
 
 
1188
 
    def test_extended_timeout(self):
1189
 
        self.assert_command_from_args(["--extended-timeout", "PT15M",
1190
 
                                       "foo"],
1191
 
                                      SetExtendedTimeoutCmd,
1192
 
                                      value_to_set=900000)
1193
 
 
1194
 
    def test_interval(self):
1195
 
        self.assert_command_from_args(["--interval", "PT2M", "foo"],
1196
 
                                      SetIntervalCmd,
1197
 
                                      value_to_set=120000)
1198
 
 
1199
 
    def test_approve_by_default(self):
1200
 
        self.assert_command_from_args(["--approve-by-default", "foo"],
1201
 
                                      ApproveByDefaultCmd)
1202
 
 
1203
 
    def test_deny_by_default(self):
1204
 
        self.assert_command_from_args(["--deny-by-default", "foo"],
1205
 
                                      DenyByDefaultCmd)
1206
 
 
1207
 
    def test_approval_delay(self):
1208
 
        self.assert_command_from_args(["--approval-delay", "PT30S",
1209
 
                                       "foo"], SetApprovalDelayCmd,
1210
 
                                      value_to_set=30000)
1211
 
 
1212
 
    def test_approval_duration(self):
1213
 
        self.assert_command_from_args(["--approval-duration", "PT1S",
1214
 
                                       "foo"], SetApprovalDurationCmd,
1215
 
                                      value_to_set=1000)
1216
 
 
1217
 
    def test_host(self):
1218
 
        self.assert_command_from_args(["--host", "foo.example.org",
1219
 
                                       "foo"], SetHostCmd,
1220
 
                                      value_to_set="foo.example.org")
1221
 
 
1222
 
    def test_secret_devnull(self):
1223
 
        self.assert_command_from_args(["--secret", os.path.devnull,
1224
 
                                       "foo"], SetSecretCmd,
1225
 
                                      value_to_set=b"")
1226
 
 
1227
 
    def test_secret_tempfile(self):
1228
 
        with tempfile.NamedTemporaryFile(mode="r+b") as f:
1229
 
            value = b"secret\0xyzzy\nbar"
1230
 
            f.write(value)
1231
 
            f.seek(0)
1232
 
            self.assert_command_from_args(["--secret", f.name,
1233
 
                                           "foo"], SetSecretCmd,
1234
 
                                          value_to_set=value)
1235
 
 
1236
 
    def test_approve(self):
1237
 
        self.assert_command_from_args(["--approve", "foo"],
1238
 
                                      ApproveCmd)
1239
 
 
1240
 
    def test_deny(self):
1241
 
        self.assert_command_from_args(["--deny", "foo"], DenyCmd)
1242
 
 
1243
 
    def test_dump_json(self):
1244
 
        self.assert_command_from_args(["--dump-json"], DumpJSONCmd)
1245
 
 
1246
 
    def test_is_enabled(self):
1247
 
        self.assert_command_from_args(["--is-enabled", "foo"],
1248
 
                                      IsEnabledCmd)
1249
 
 
1250
969
 
1251
970
 
1252
971
def should_only_run_tests():