/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to mandos-ctl

  • Committer: Teddy Hogeborn
  • Date: 2019-02-28 18:54:11 UTC
  • mto: (237.7.594 trunk)
  • mto: This revision was merged to the branch mainline in revision 382.
  • Revision ID: teddy@recompile.se-20190228185411-71f49cg8plsvdkub
Add tests to mandos-ctl's milliseconds_to_string function

* mandos-ctl (Test_milliseconds_to_string): New.

Show diffs side-by-side

added added

removed removed

Lines of Context:
mandos-ctl
1
1
#!/usr/bin/python
2
 
# -*- mode: python; coding: utf-8 -*-
3
 
# 
 
2
# -*- mode: python; coding: utf-8; after-save-hook: (lambda () (let ((command (if (and (boundp 'tramp-file-name-structure) (string-match (car tramp-file-name-structure) (buffer-file-name))) (tramp-file-name-localname (tramp-dissect-file-name (buffer-file-name))) (buffer-file-name)))) (if (= (shell-command (format "%s --check" (shell-quote-argument command)) "*Test*") 0) (let ((w (get-buffer-window "*Test*"))) (if w (delete-window w)) (kill-buffer "*Test*")) (display-buffer "*Test*")))); -*-
 
3
#
4
4
# Mandos Monitor - Control and monitor the Mandos server
5
 
# 
6
 
# Copyright © 2008-2014 Teddy Hogeborn
7
 
# Copyright © 2008-2014 Björn Påhlsson
8
 
# 
9
 
# This program is free software: you can redistribute it and/or modify
10
 
# it under the terms of the GNU General Public License as published by
 
5
#
 
6
# Copyright © 2008-2019 Teddy Hogeborn
 
7
# Copyright © 2008-2019 Björn Påhlsson
 
8
#
 
9
# This file is part of Mandos.
 
10
#
 
11
# Mandos is free software: you can redistribute it and/or modify it
 
12
# under the terms of the GNU General Public License as published by
11
13
# the Free Software Foundation, either version 3 of the License, or
12
14
# (at your option) any later version.
13
15
#
14
 
#     This program is distributed in the hope that it will be useful,
15
 
#     but WITHOUT ANY WARRANTY; without even the implied warranty of
 
16
#     Mandos is distributed in the hope that it will be useful, but
 
17
#     WITHOUT ANY WARRANTY; without even the implied warranty of
16
18
#     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
17
19
#     GNU General Public License for more details.
18
 
# 
 
20
#
19
21
# You should have received a copy of the GNU General Public License
20
 
# along with this program.  If not, see
21
 
# <http://www.gnu.org/licenses/>.
22
 
# 
 
22
# along with Mandos.  If not, see <http://www.gnu.org/licenses/>.
 
23
#
23
24
# Contact the authors at <mandos@recompile.se>.
24
 
# 
 
25
#
25
26
 
26
27
from __future__ import (division, absolute_import, print_function,
27
28
                        unicode_literals)
28
29
 
29
 
from future_builtins import *
 
30
try:
 
31
    from future_builtins import *
 
32
except ImportError:
 
33
    pass
30
34
 
31
35
import sys
32
36
import argparse
35
39
import re
36
40
import os
37
41
import collections
38
 
import doctest
 
42
import json
 
43
import unittest
39
44
 
40
45
import dbus
41
46
 
 
47
if sys.version_info.major == 2:
 
48
    str = unicode
 
49
 
42
50
locale.setlocale(locale.LC_ALL, "")
43
51
 
44
52
tablewords = {
51
59
    "Interval": "Interval",
52
60
    "Host": "Host",
53
61
    "Fingerprint": "Fingerprint",
 
62
    "KeyID": "Key ID",
54
63
    "CheckerRunning": "Check Is Running",
55
64
    "LastEnabled": "Last Enabled",
56
65
    "ApprovalPending": "Approval Is Pending",
58
67
    "ApprovalDelay": "Approval Delay",
59
68
    "ApprovalDuration": "Approval Duration",
60
69
    "Checker": "Checker",
61
 
    "ExtendedTimeout" : "Extended Timeout"
62
 
    }
 
70
    "ExtendedTimeout": "Extended Timeout",
 
71
    "Expires": "Expires",
 
72
    "LastCheckerStatus": "Last Checker Status",
 
73
}
63
74
defaultkeywords = ("Name", "Enabled", "Timeout", "LastCheckedOK")
64
75
domain = "se.recompile"
65
76
busname = domain + ".Mandos"
66
77
server_path = "/"
67
78
server_interface = domain + ".Mandos"
68
79
client_interface = domain + ".Mandos.Client"
69
 
version = "1.6.4"
70
 
 
71
 
def timedelta_to_milliseconds(td):
72
 
    """Convert a datetime.timedelta object to milliseconds"""
73
 
    return ((td.days * 24 * 60 * 60 * 1000)
74
 
            + (td.seconds * 1000)
75
 
            + (td.microseconds // 1000))
 
80
version = "1.8.3"
 
81
 
 
82
 
 
83
try:
 
84
    dbus.OBJECT_MANAGER_IFACE
 
85
except AttributeError:
 
86
    dbus.OBJECT_MANAGER_IFACE = "org.freedesktop.DBus.ObjectManager"
 
87
 
76
88
 
77
89
def milliseconds_to_string(ms):
78
90
    td = datetime.timedelta(0, 0, 0, ms)
79
91
    return ("{days}{hours:02}:{minutes:02}:{seconds:02}"
80
 
            .format(days = "{0}T".format(td.days) if td.days else "",
81
 
                    hours = td.seconds // 3600,
82
 
                    minutes = (td.seconds % 3600) // 60,
83
 
                    seconds = td.seconds % 60,
84
 
                    ))
 
92
            .format(days="{}T".format(td.days) if td.days else "",
 
93
                    hours=td.seconds // 3600,
 
94
                    minutes=(td.seconds % 3600) // 60,
 
95
                    seconds=td.seconds % 60))
85
96
 
86
97
 
87
98
def rfc3339_duration_to_delta(duration):
88
99
    """Parse an RFC 3339 "duration" and return a datetime.timedelta
89
 
    
 
100
 
90
101
    >>> rfc3339_duration_to_delta("P7D")
91
102
    datetime.timedelta(7)
92
103
    >>> rfc3339_duration_to_delta("PT60S")
102
113
    >>> rfc3339_duration_to_delta("P1DT3M20S")
103
114
    datetime.timedelta(1, 200)
104
115
    """
105
 
    
 
116
 
106
117
    # Parsing an RFC 3339 duration with regular expressions is not
107
118
    # possible - there would have to be multiple places for the same
108
119
    # values, like seconds.  The current code, while more esoteric, is
109
120
    # cleaner without depending on a parsing library.  If Python had a
110
121
    # built-in library for parsing we would use it, but we'd like to
111
122
    # avoid excessive use of external libraries.
112
 
    
 
123
 
113
124
    # New type for defining tokens, syntax, and semantics all-in-one
114
 
    Token = collections.namedtuple("Token",
115
 
                                   ("regexp", # To match token; if
116
 
                                              # "value" is not None,
117
 
                                              # must have a "group"
118
 
                                              # containing digits
119
 
                                    "value",  # datetime.timedelta or
120
 
                                              # None
121
 
                                    "followers")) # Tokens valid after
122
 
                                                  # this token
 
125
    Token = collections.namedtuple("Token", (
 
126
        "regexp",  # To match token; if "value" is not None, must have
 
127
                   # a "group" containing digits
 
128
        "value",   # datetime.timedelta or None
 
129
        "followers"))           # Tokens valid after this token
123
130
    # RFC 3339 "duration" tokens, syntax, and semantics; taken from
124
131
    # the "duration" ABNF definition in RFC 3339, Appendix A.
125
132
    token_end = Token(re.compile(r"$"), None, frozenset())
126
133
    token_second = Token(re.compile(r"(\d+)S"),
127
134
                         datetime.timedelta(seconds=1),
128
 
                         frozenset((token_end,)))
 
135
                         frozenset((token_end, )))
129
136
    token_minute = Token(re.compile(r"(\d+)M"),
130
137
                         datetime.timedelta(minutes=1),
131
138
                         frozenset((token_second, token_end)))
147
154
                       frozenset((token_month, token_end)))
148
155
    token_week = Token(re.compile(r"(\d+)W"),
149
156
                       datetime.timedelta(weeks=1),
150
 
                       frozenset((token_end,)))
 
157
                       frozenset((token_end, )))
151
158
    token_duration = Token(re.compile(r"P"), None,
152
159
                           frozenset((token_year, token_month,
153
160
                                      token_day, token_time,
154
 
                                      token_week))),
155
 
    # Define starting values
156
 
    value = datetime.timedelta() # Value so far
 
161
                                      token_week)))
 
162
    # Define starting values:
 
163
    # Value so far
 
164
    value = datetime.timedelta()
157
165
    found_token = None
158
 
    followers = frozenset(token_duration,) # Following valid tokens
159
 
    s = duration                # String left to parse
 
166
    # Following valid tokens
 
167
    followers = frozenset((token_duration, ))
 
168
    # String left to parse
 
169
    s = duration
160
170
    # Loop until end token is found
161
171
    while found_token is not token_end:
162
172
        # Search for any currently valid tokens
178
188
                break
179
189
        else:
180
190
            # No currently valid tokens were found
181
 
            raise ValueError("Invalid RFC 3339 duration")
 
191
            raise ValueError("Invalid RFC 3339 duration: {!r}"
 
192
                             .format(duration))
182
193
    # End token found
183
194
    return value
184
195
 
185
196
 
186
197
def string_to_delta(interval):
187
198
    """Parse a string and return a datetime.timedelta
188
 
    
189
 
    >>> string_to_delta("7d")
 
199
 
 
200
    >>> string_to_delta('7d')
190
201
    datetime.timedelta(7)
191
 
    >>> string_to_delta("60s")
 
202
    >>> string_to_delta('60s')
192
203
    datetime.timedelta(0, 60)
193
 
    >>> string_to_delta("60m")
 
204
    >>> string_to_delta('60m')
194
205
    datetime.timedelta(0, 3600)
195
 
    >>> string_to_delta("24h")
 
206
    >>> string_to_delta('24h')
196
207
    datetime.timedelta(1)
197
 
    >>> string_to_delta("1w")
 
208
    >>> string_to_delta('1w')
198
209
    datetime.timedelta(7)
199
 
    >>> string_to_delta("5m 30s")
 
210
    >>> string_to_delta('5m 30s')
200
211
    datetime.timedelta(0, 330)
201
212
    """
202
 
    
 
213
 
203
214
    try:
204
215
        return rfc3339_duration_to_delta(interval)
205
216
    except ValueError:
206
217
        pass
207
 
    
 
218
 
208
219
    value = datetime.timedelta(0)
209
220
    regexp = re.compile(r"(\d+)([dsmhw]?)")
210
 
    
 
221
 
211
222
    for num, suffix in regexp.findall(interval):
212
223
        if suffix == "d":
213
224
            value += datetime.timedelta(int(num))
223
234
            value += datetime.timedelta(0, 0, 0, int(num))
224
235
    return value
225
236
 
 
237
 
226
238
def print_clients(clients, keywords):
227
239
    def valuetostring(value, keyword):
228
240
        if type(value) is dbus.Boolean:
230
242
        if keyword in ("Timeout", "Interval", "ApprovalDelay",
231
243
                       "ApprovalDuration", "ExtendedTimeout"):
232
244
            return milliseconds_to_string(value)
233
 
        return unicode(value)
234
 
    
 
245
        return str(value)
 
246
 
235
247
    # Create format string to print table rows
236
248
    format_string = " ".join("{{{key}:{width}}}".format(
237
 
            width = max(len(tablewords[key]),
238
 
                        max(len(valuetostring(client[key],
239
 
                                              key))
240
 
                            for client in
241
 
                            clients)),
242
 
            key = key) for key in keywords)
 
249
        width=max(len(tablewords[key]),
 
250
                  max(len(valuetostring(client[key], key))
 
251
                      for client in clients)),
 
252
        key=key)
 
253
                             for key in keywords)
243
254
    # Print header line
244
255
    print(format_string.format(**tablewords))
245
256
    for client in clients:
246
 
        print(format_string.format(**dict((key,
247
 
                                           valuetostring(client[key],
248
 
                                                         key))
249
 
                                          for key in keywords)))
 
257
        print(format_string
 
258
              .format(**{key: valuetostring(client[key], key)
 
259
                         for key in keywords}))
 
260
 
250
261
 
251
262
def has_actions(options):
252
263
    return any((options.enable,
268
279
                options.approve,
269
280
                options.deny))
270
281
 
 
282
 
271
283
def main():
272
284
    parser = argparse.ArgumentParser()
273
285
    parser.add_argument("--version", action="version",
274
 
                        version = "%(prog)s {0}".format(version),
 
286
                        version="%(prog)s {}".format(version),
275
287
                        help="show version number and exit")
276
288
    parser.add_argument("-a", "--all", action="store_true",
277
289
                        help="Select all clients")
278
290
    parser.add_argument("-v", "--verbose", action="store_true",
279
291
                        help="Print all fields")
 
292
    parser.add_argument("-j", "--dump-json", action="store_true",
 
293
                        help="Dump client data in JSON format")
280
294
    parser.add_argument("-e", "--enable", action="store_true",
281
295
                        help="Enable client")
282
296
    parser.add_argument("-d", "--disable", action="store_true",
310
324
    parser.add_argument("--approval-duration",
311
325
                        help="Set duration of one client approval")
312
326
    parser.add_argument("-H", "--host", help="Set host for client")
313
 
    parser.add_argument("-s", "--secret", type=file,
 
327
    parser.add_argument("-s", "--secret",
 
328
                        type=argparse.FileType(mode="rb"),
314
329
                        help="Set password blob (file) for client")
315
330
    parser.add_argument("-A", "--approve", action="store_true",
316
331
                        help="Approve any current client request")
320
335
                        help="Run self-test")
321
336
    parser.add_argument("client", nargs="*", help="Client name")
322
337
    options = parser.parse_args()
323
 
    
 
338
 
324
339
    if has_actions(options) and not (options.client or options.all):
325
340
        parser.error("Options require clients names or --all.")
326
341
    if options.verbose and has_actions(options):
327
 
        parser.error("--verbose can only be used alone or with"
328
 
                     " --all.")
 
342
        parser.error("--verbose can only be used alone.")
 
343
    if options.dump_json and (options.verbose
 
344
                              or has_actions(options)):
 
345
        parser.error("--dump-json can only be used alone.")
329
346
    if options.all and not has_actions(options):
330
347
        parser.error("--all requires an action.")
331
348
 
332
 
    if options.check:
333
 
        fail_count, test_count = doctest.testmod()
334
 
        sys.exit(os.EX_OK if fail_count == 0 else 1)
335
 
    
336
349
    try:
337
350
        bus = dbus.SystemBus()
338
351
        mandos_dbus_objc = bus.get_object(busname, server_path)
339
352
    except dbus.exceptions.DBusException:
340
 
        print("Could not connect to Mandos server",
341
 
              file=sys.stderr)
 
353
        print("Could not connect to Mandos server", file=sys.stderr)
342
354
        sys.exit(1)
343
 
    
 
355
 
344
356
    mandos_serv = dbus.Interface(mandos_dbus_objc,
345
 
                                 dbus_interface = server_interface)
346
 
    
347
 
    #block stderr since dbus library prints to stderr
 
357
                                 dbus_interface=server_interface)
 
358
    mandos_serv_object_manager = dbus.Interface(
 
359
        mandos_dbus_objc, dbus_interface=dbus.OBJECT_MANAGER_IFACE)
 
360
 
 
361
    # block stderr since dbus library prints to stderr
348
362
    null = os.open(os.path.devnull, os.O_RDWR)
349
363
    stderrcopy = os.dup(sys.stderr.fileno())
350
364
    os.dup2(null, sys.stderr.fileno())
351
365
    os.close(null)
352
366
    try:
353
367
        try:
354
 
            mandos_clients = mandos_serv.GetAllClientsWithProperties()
 
368
            mandos_clients = {path: ifs_and_props[client_interface]
 
369
                              for path, ifs_and_props in
 
370
                              mandos_serv_object_manager
 
371
                              .GetManagedObjects().items()
 
372
                              if client_interface in ifs_and_props}
355
373
        finally:
356
 
            #restore stderr
 
374
            # restore stderr
357
375
            os.dup2(stderrcopy, sys.stderr.fileno())
358
376
            os.close(stderrcopy)
359
 
    except dbus.exceptions.DBusException:
360
 
        print("Access denied: Accessing mandos server through dbus.",
 
377
    except dbus.exceptions.DBusException as e:
 
378
        print("Access denied: "
 
379
              "Accessing mandos server through D-Bus: {}".format(e),
361
380
              file=sys.stderr)
362
381
        sys.exit(1)
363
 
    
 
382
 
364
383
    # Compile dict of (clients: properties) to process
365
 
    clients={}
366
 
    
 
384
    clients = {}
 
385
 
367
386
    if options.all or not options.client:
368
 
        clients = dict((bus.get_object(busname, path), properties)
369
 
                       for path, properties in
370
 
                       mandos_clients.iteritems())
 
387
        clients = {bus.get_object(busname, path): properties
 
388
                   for path, properties in mandos_clients.items()}
371
389
    else:
372
390
        for name in options.client:
373
 
            for path, client in mandos_clients.iteritems():
 
391
            for path, client in mandos_clients.items():
374
392
                if client["Name"] == name:
375
393
                    client_objc = bus.get_object(busname, path)
376
394
                    clients[client_objc] = client
377
395
                    break
378
396
            else:
379
 
                print("Client not found on server: {0!r}"
 
397
                print("Client not found on server: {!r}"
380
398
                      .format(name), file=sys.stderr)
381
399
                sys.exit(1)
382
 
    
 
400
 
383
401
    if not has_actions(options) and clients:
384
 
        if options.verbose:
385
 
            keywords = ("Name", "Enabled", "Timeout",
386
 
                        "LastCheckedOK", "Created", "Interval",
387
 
                        "Host", "Fingerprint", "CheckerRunning",
 
402
        if options.verbose or options.dump_json:
 
403
            keywords = ("Name", "Enabled", "Timeout", "LastCheckedOK",
 
404
                        "Created", "Interval", "Host", "KeyID",
 
405
                        "Fingerprint", "CheckerRunning",
388
406
                        "LastEnabled", "ApprovalPending",
389
 
                        "ApprovedByDefault",
390
 
                        "LastApprovalRequest", "ApprovalDelay",
391
 
                        "ApprovalDuration", "Checker",
392
 
                        "ExtendedTimeout")
 
407
                        "ApprovedByDefault", "LastApprovalRequest",
 
408
                        "ApprovalDelay", "ApprovalDuration",
 
409
                        "Checker", "ExtendedTimeout", "Expires",
 
410
                        "LastCheckerStatus")
393
411
        else:
394
412
            keywords = defaultkeywords
395
 
        
396
 
        print_clients(clients.values(), keywords)
 
413
 
 
414
        if options.dump_json:
 
415
            json.dump({client["Name"]: {key:
 
416
                                        bool(client[key])
 
417
                                        if isinstance(client[key],
 
418
                                                      dbus.Boolean)
 
419
                                        else client[key]
 
420
                                        for key in keywords}
 
421
                       for client in clients.values()},
 
422
                      fp=sys.stdout, indent=4,
 
423
                      separators=(',', ': '))
 
424
            print()
 
425
        else:
 
426
            print_clients(clients.values(), keywords)
397
427
    else:
398
428
        # Process each client in the list by all selected options
399
429
        for client in clients:
 
430
 
400
431
            def set_client_prop(prop, value):
401
432
                """Set a Client D-Bus property"""
402
433
                client.Set(client_interface, prop, value,
403
434
                           dbus_interface=dbus.PROPERTIES_IFACE)
 
435
 
404
436
            def set_client_prop_ms(prop, value):
405
437
                """Set a Client D-Bus property, converted
406
438
                from a string to milliseconds."""
407
439
                set_client_prop(prop,
408
 
                                timedelta_to_milliseconds
409
 
                                (string_to_delta(value)))
 
440
                                string_to_delta(value).total_seconds()
 
441
                                * 1000)
 
442
 
410
443
            if options.remove:
411
444
                mandos_serv.RemoveClient(client.__dbus_object_path__)
412
445
            if options.enable:
420
453
            if options.stop_checker:
421
454
                set_client_prop("CheckerRunning", dbus.Boolean(False))
422
455
            if options.is_enabled:
423
 
                sys.exit(0 if client.Get(client_interface,
424
 
                                         "Enabled",
425
 
                                         dbus_interface=
426
 
                                         dbus.PROPERTIES_IFACE)
427
 
                         else 1)
 
456
                if client.Get(client_interface, "Enabled",
 
457
                              dbus_interface=dbus.PROPERTIES_IFACE):
 
458
                    sys.exit(0)
 
459
                else:
 
460
                    sys.exit(1)
428
461
            if options.checker is not None:
429
462
                set_client_prop("Checker", options.checker)
430
463
            if options.host is not None:
456
489
                client.Approve(dbus.Boolean(False),
457
490
                               dbus_interface=client_interface)
458
491
 
 
492
 
 
493
class Test_milliseconds_to_string(unittest.TestCase):
 
494
    def test_all(self):
 
495
        self.assertEqual(milliseconds_to_string(93785000),
 
496
                         "1T02:03:05")
 
497
    def test_no_days(self):
 
498
        self.assertEqual(milliseconds_to_string(7385000), "02:03:05")
 
499
    def test_all_zero(self):
 
500
        self.assertEqual(milliseconds_to_string(0), "00:00:00")
 
501
    def test_no_fractional_seconds(self):
 
502
        self.assertEqual(milliseconds_to_string(400), "00:00:00")
 
503
        self.assertEqual(milliseconds_to_string(900), "00:00:00")
 
504
        self.assertEqual(milliseconds_to_string(1900), "00:00:01")
 
505
 
 
506
 
 
507
def should_only_run_tests():
 
508
    parser = argparse.ArgumentParser(add_help=False)
 
509
    parser.add_argument("--check", action='store_true')
 
510
    args, unknown_args = parser.parse_known_args()
 
511
    run_tests = args.check
 
512
    if run_tests:
 
513
        # Remove --check argument from sys.argv
 
514
        sys.argv[1:] = unknown_args
 
515
    return run_tests
 
516
 
 
517
# Add all tests from doctest strings
 
518
def load_tests(loader, tests, none):
 
519
    import doctest
 
520
    tests.addTests(doctest.DocTestSuite())
 
521
    return tests
 
522
 
459
523
if __name__ == "__main__":
460
 
    main()
 
524
    if should_only_run_tests():
 
525
        # Call using ./tdd-python-script --check [--verbose]
 
526
        unittest.main()
 
527
    else:
 
528
        main()