/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to plugins.d/mandos-client.c

  • Committer: Teddy Hogeborn
  • Date: 2018-02-19 21:32:07 UTC
  • mto: (237.7.594 trunk)
  • mto: This revision was merged to the branch mainline in revision 366.
  • Revision ID: teddy@recompile.se-20180219213207-0un0ylegx390pftq
Client bug fixes: Fix file descriptor leaks

* plugin-helpers/mandos-client.c (init_gnutls_global, get_flags):
  Always close files and sockets after they are used.

Show diffs side-by-side

added added

removed removed

Lines of Context:
plugins.d/mandos-client.c
9
9
 * "browse_callback", and parts of "main".
10
10
 * 
11
11
 * Everything else is
12
 
 * Copyright © 2008-2016 Teddy Hogeborn
13
 
 * Copyright © 2008-2016 Björn Påhlsson
14
 
 * 
15
 
 * This program is free software: you can redistribute it and/or
16
 
 * modify it under the terms of the GNU General Public License as
17
 
 * published by the Free Software Foundation, either version 3 of the
18
 
 * License, or (at your option) any later version.
19
 
 * 
20
 
 * This program is distributed in the hope that it will be useful, but
 
12
 * Copyright © 2008-2018 Teddy Hogeborn
 
13
 * Copyright © 2008-2018 Björn Påhlsson
 
14
 * 
 
15
 * This file is part of Mandos.
 
16
 * 
 
17
 * Mandos is free software: you can redistribute it and/or modify it
 
18
 * under the terms of the GNU General Public License as published by
 
19
 * the Free Software Foundation, either version 3 of the License, or
 
20
 * (at your option) any later version.
 
21
 * 
 
22
 * Mandos is distributed in the hope that it will be useful, but
21
23
 * WITHOUT ANY WARRANTY; without even the implied warranty of
22
24
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
23
25
 * General Public License for more details.
24
26
 * 
25
27
 * You should have received a copy of the GNU General Public License
26
 
 * along with this program.  If not, see
27
 
 * <http://www.gnu.org/licenses/>.
 
28
 * along with Mandos.  If not, see <http://www.gnu.org/licenses/>.
28
29
 * 
29
30
 * Contact the authors at <mandos@recompile.se>.
30
31
 */
47
48
                                   strtof(), abort() */
48
49
#include <stdbool.h>            /* bool, false, true */
49
50
#include <string.h>             /* strcmp(), strlen(), strerror(),
50
 
                                   asprintf(), strncpy() */
 
51
                                   asprintf(), strncpy(), strsignal()
 
52
                                */
51
53
#include <sys/ioctl.h>          /* ioctl */
52
54
#include <sys/types.h>          /* socket(), inet_pton(), sockaddr,
53
55
                                   sockaddr_in6, PF_INET6,
611
613
        }
612
614
        params.size += (unsigned int)bytes_read;
613
615
      }
 
616
      close(dhpfile);
614
617
      if(params.data == NULL){
615
618
        dhparamsfilename = NULL;
616
619
      }
625
628
                     safer_gnutls_strerror(ret));
626
629
        dhparamsfilename = NULL;
627
630
      }
 
631
      free(params.data);
628
632
    } while(false);
629
633
  }
630
634
  if(dhparamsfilename == NULL){
1077
1081
    bool match = false;
1078
1082
    {
1079
1083
      char *interface = NULL;
1080
 
      while((interface=argz_next(mc->interfaces, mc->interfaces_size,
1081
 
                                 interface))){
 
1084
      while((interface = argz_next(mc->interfaces,
 
1085
                                   mc->interfaces_size,
 
1086
                                   interface))){
1082
1087
        if(if_nametoindex(interface) == (unsigned int)if_index){
1083
1088
          match = true;
1084
1089
          break;
1237
1242
           with an explicit route added with the server's address.
1238
1243
           
1239
1244
           Avahi bug reference:
1240
 
           http://lists.freedesktop.org/archives/avahi/2010-February/001833.html
 
1245
           https://lists.freedesktop.org/archives/avahi/2010-February/001833.html
1241
1246
           https://bugs.debian.org/587961
1242
1247
        */
1243
1248
        if(debug){
1491
1496
  return retval;
1492
1497
}
1493
1498
 
1494
 
__attribute__((nonnull))
1495
1499
static void resolve_callback(AvahiSServiceResolver *r,
1496
1500
                             AvahiIfIndex interface,
1497
1501
                             AvahiProtocol proto,
1652
1656
      perror_plus("ioctl SIOCGIFFLAGS");
1653
1657
      errno = old_errno;
1654
1658
    }
 
1659
    close(s);
1655
1660
    return false;
1656
1661
  }
 
1662
  close(s);
1657
1663
  return true;
1658
1664
}
1659
1665
 
1920
1926
      return;
1921
1927
    }
1922
1928
  }
 
1929
  int devnull = (int)TEMP_FAILURE_RETRY(open("/dev/null", O_RDONLY));
 
1930
  if(devnull == -1){
 
1931
    perror_plus("open(\"/dev/null\", O_RDONLY)");
 
1932
    return;
 
1933
  }
1923
1934
  int numhooks = scandirat(hookdir_fd, ".", &direntries,
1924
1935
                           runnable_hook, alphasort);
1925
1936
  if(numhooks == -1){
1926
1937
    perror_plus("scandir");
 
1938
    close(devnull);
1927
1939
    return;
1928
1940
  }
1929
1941
  struct dirent *direntry;
1930
1942
  int ret;
1931
 
  int devnull = (int)TEMP_FAILURE_RETRY(open("/dev/null", O_RDONLY));
1932
 
  if(devnull == -1){
1933
 
    perror_plus("open(\"/dev/null\", O_RDONLY)");
1934
 
    return;
1935
 
  }
1936
1943
  for(int i = 0; i < numhooks; i++){
1937
1944
    direntry = direntries[i];
1938
1945
    if(debug){
2194
2201
  
2195
2202
  /* Sleep checking until interface is running.
2196
2203
     Check every 0.25s, up to total time of delay */
2197
 
  for(int i=0; i < delay * 4; i++){
 
2204
  for(int i = 0; i < delay * 4; i++){
2198
2205
    if(interface_is_running(interface)){
2199
2206
      break;
2200
2207
    }
2496
2503
  
2497
2504
  {
2498
2505
    /* Work around Debian bug #633582:
2499
 
       <http://bugs.debian.org/633582> */
 
2506
       <https://bugs.debian.org/633582> */
2500
2507
    
2501
2508
    /* Re-raise privileges */
2502
2509
    ret = raise_privileges();
2957
2964
 end:
2958
2965
  
2959
2966
  if(debug){
2960
 
    fprintf_plus(stderr, "%s exiting\n", argv[0]);
 
2967
    if(signal_received){
 
2968
      fprintf_plus(stderr, "%s exiting due to signal %d: %s\n",
 
2969
                   argv[0], signal_received,
 
2970
                   strsignal(signal_received));
 
2971
    } else {
 
2972
      fprintf_plus(stderr, "%s exiting\n", argv[0]);
 
2973
    }
2961
2974
  }
2962
2975
  
2963
2976
  /* Cleanup things */
3015
3028
      /* Take down the network interfaces which were brought up */
3016
3029
      {
3017
3030
        char *interface = NULL;
3018
 
        while((interface=argz_next(interfaces_to_take_down,
3019
 
                                   interfaces_to_take_down_size,
3020
 
                                   interface))){
 
3031
        while((interface = argz_next(interfaces_to_take_down,
 
3032
                                     interfaces_to_take_down_size,
 
3033
                                     interface))){
3021
3034
          ret = take_down_interface(interface);
3022
3035
          if(ret != 0){
3023
3036
            errno = ret;
3052
3065
                                                | O_PATH));
3053
3066
    if(dir_fd == -1){
3054
3067
      perror_plus("open");
 
3068
      return;
3055
3069
    }
3056
3070
    int numentries = scandirat(dir_fd, ".", &direntries,
3057
3071
                               notdotentries, alphasort);
3074
3088
            clean_dir_at(dir_fd, direntries[i]->d_name, level+1);
3075
3089
            dret = 0;
3076
3090
          }
3077
 
          if(dret == -1){
 
3091
          if((dret == -1) and (errno != ENOENT)){
3078
3092
            fprintf_plus(stderr, "unlink(\"%s/%s\"): %s\n", dirname,
3079
3093
                         direntries[i]->d_name, strerror(errno));
3080
3094
          }
3084
3098
      
3085
3099
      /* need to clean even if 0 because man page doesn't specify */
3086
3100
      free(direntries);
3087
 
      if(numentries == -1){
3088
 
        perror_plus("scandirat");
3089
 
      }
3090
3101
      dret = unlinkat(base, dirname, AT_REMOVEDIR);
3091
3102
      if(dret == -1 and errno != ENOENT){
3092
3103
        perror_plus("rmdir");