/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to plugin-runner.c

  • Committer: Teddy Hogeborn
  • Date: 2018-02-18 01:03:48 UTC
  • mto: (237.7.594 trunk)
  • mto: This revision was merged to the branch mainline in revision 366.
  • Revision ID: teddy@recompile.se-20180218010348-hhjfox5t4py5n5zh
Client: Bug fix: Possible memory leak if failing to open /dev/null

* plugins.d/mandos-client.d (run_network_hooks): Try to open /dev/null
  before reading network hook dir in order to fail early in that case.

Show diffs side-by-side

added added

removed removed

Lines of Context:
564
564
    case '?':                   /* --help */
565
565
      state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
566
566
      argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
567
 
      __builtin_unreachable();
568
567
    case -3:                    /* --usage */
569
568
      state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
570
569
      argp_state_help(state, state->out_stream,
571
570
                      ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
572
 
      __builtin_unreachable();
573
571
    case 'V':                   /* --version */
574
572
      fprintf(state->out_stream, "%s\n", argp_program_version);
575
573
      exit(EXIT_SUCCESS);
585
583
      if(arg[0] == '\0'){
586
584
        break;
587
585
      }
588
 
      /* FALLTHROUGH */
589
586
    default:
590
587
      return ARGP_ERR_UNKNOWN;
591
588
    }
1095
1092
    
1096
1093
    new_plugin->pid = pid;
1097
1094
    new_plugin->fd = pipefd[0];
1098
 
 
1099
 
    if(debug){
1100
 
      fprintf(stderr, "Plugin %s started (PID %" PRIdMAX ")\n",
1101
 
              new_plugin->name, (intmax_t) (new_plugin->pid));
1102
 
    }
1103
 
 
 
1095
    
1104
1096
    /* Unblock SIGCHLD so signal handler can be run if this process
1105
1097
       has already completed */
1106
1098
    ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,