To get this branch, use:
bzr branch
http://bzr.recompile.se/loggerhead/mandos/release
« back to all changes in this revision
Viewing changes to plugin-runner.c
- browse files at revision 237.7.464
- compare with another revision
- download diff
- download tarball
- view history from revision 237.7.464
- Committer: Teddy Hogeborn
- Date: 2018-01-29 19:21:23 UTC
- mto: (237.7.594 trunk)
- mto: This revision was merged to the branch mainline in revision 362.
- Revision ID: teddy@recompile.se-20180129192123-y6brq6tnnnxm2oi2
Fix memory leak in plugin-runner (this fixes Debian bug #886595)
* plugin-runner.c (free_plugin): Bug fix: Also free() plugin name.
* plugin-runner.c (free_plugin): Bug fix: Also free() plugin name.
- files added:
- DBUS-API
- debian/source
- debian/upstream
- network-hooks.d
- plugin-helpers
- files modified:
- .bzrignore
added
removed
plugin-runner.c
1
/* -*- coding: utf-8 -*- */
1
/* -*- coding: utf-8; mode: c; mode: orgtbl -*- */
2
2
/*
3
3
* Mandos plugin runner - Run Mandos plugins
4
4
*
5
* Copyright © 2008,2009 Teddy Hogeborn
6
* Copyright © 2008,2009 Björn Påhlsson
7
*
8
* This program is free software: you can redistribute it and/or
9
* modify it under the terms of the GNU General Public License as
10
* published by the Free Software Foundation, either version 3 of the
11
* License, or (at your option) any later version.
12
*
13
* This program is distributed in the hope that it will be useful, but
5
* Copyright © 2008-2017 Teddy Hogeborn
6
* Copyright © 2008-2017 Björn Påhlsson
7
*
8
* This file is part of Mandos.
9
*
10
* Mandos is free software: you can redistribute it and/or modify it
11
* under the terms of the GNU General Public License as published by
12
* the Free Software Foundation, either version 3 of the License, or
13
* (at your option) any later version.
14
*
15
* Mandos is distributed in the hope that it will be useful, but
14
16
* WITHOUT ANY WARRANTY; without even the implied warranty of
15
17
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16
18
* General Public License for more details.
17
19
*
18
20
* You should have received a copy of the GNU General Public License
19
* along with this program. If not, see
20
* <http://www.gnu.org/licenses/>.
21
* along with Mandos. If not, see <http://www.gnu.org/licenses/>.
21
22
*
22
* Contact the authors at <mandos@fukt.bsnet.se>.
23
* Contact the authors at <mandos@recompile.se>.
23
24
*/
24
25
25
26
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
asprintf() */
27
O_CLOEXEC, pipe2() */
27
28
#include <stddef.h> /* size_t, NULL */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
29
EXIT_SUCCESS, realloc() */
29
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
30
realloc() */
30
31
#include <stdbool.h> /* bool, true, false */
31
#include <stdio.h> /* perror, fileno(), fprintf(),
32
stderr, STDOUT_FILENO */
33
#include <sys/types.h> /* DIR, opendir(), stat(), struct
34
stat, waitpid(), WIFEXITED(),
35
WEXITSTATUS(), wait(), pid_t,
36
uid_t, gid_t, getuid(), getgid(),
37
dirfd() */
32
#include <stdio.h> /* fileno(), fprintf(),
33
stderr, STDOUT_FILENO, fclose() */
34
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
35
WIFEXITED(), WEXITSTATUS(), wait(),
36
pid_t, uid_t, gid_t, getuid(),
37
getgid() */
38
38
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
39
39
FD_SET(), FD_ISSET(), FD_CLR */
40
40
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
WEXITSTATUS() */
42
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
41
WEXITSTATUS(), WTERMSIG() */
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
43
43
#include <iso646.h> /* and, or, not */
44
#include <dirent.h> /* DIR, struct dirent, opendir(),
45
readdir(), closedir(), dirfd() */
46
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
47
fcntl(), setuid(), setgid(),
48
F_GETFD, F_SETFD, FD_CLOEXEC,
49
access(), pipe(), fork(), close()
50
dup2(), STDOUT_FILENO, _exit(),
51
execv(), write(), read(),
52
close() */
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
51
*/
53
52
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
54
FD_CLOEXEC */
55
#include <string.h> /* strsep, strlen(), asprintf() */
53
FD_CLOEXEC, openat(), scandirat(),
54
pipe2() */
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
56
57
#include <errno.h> /* errno */
57
58
#include <argp.h> /* struct argp_option, struct
58
59
argp_state, struct argp,
65
66
SIG_UNBLOCK, kill(), sig_atomic_t
66
67
*/
67
68
#include <errno.h> /* errno, EBADF */
68
#include <inttypes.h> /* intmax_t, SCNdMAX, PRIdMAX, */
69
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
70
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
71
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
72
#include <errno.h> /* errno */
73
#include <error.h> /* error() */
74
#include <fnmatch.h> /* fnmatch() */
69
75
70
76
#define BUFFER_SIZE 256
71
77
72
78
#define PDIR "/lib/mandos/plugins.d"
79
#define PHDIR "/lib/mandos/plugin-helpers"
73
80
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
74
81
75
82
const char *argp_program_version = "plugin-runner " VERSION;
76
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
83
const char *argp_program_bug_address = "<mandos@recompile.se>";
77
84
78
85
typedef struct plugin{
79
86
char *name; /* can be NULL or any plugin name */
82
89
char **environ;
83
90
int envc;
84
91
bool disabled;
85
92
86
93
/* Variables used for running processes*/
87
94
pid_t pid;
88
95
int fd;
99
106
100
107
/* Gets an existing plugin based on name,
101
108
or if none is found, creates a new one */
109
__attribute__((warn_unused_result))
102
110
static plugin *getplugin(char *name){
103
/* Check for exiting plugin with that name */
111
/* Check for existing plugin with that name */
104
112
for(plugin *p = plugin_list; p != NULL; p = p->next){
105
113
if((p->name == name)
106
114
or (p->name and name and (strcmp(p->name, name) == 0))){
108
116
}
109
117
}
110
118
/* Create a new plugin */
111
plugin *new_plugin = malloc(sizeof(plugin));
119
plugin *new_plugin = NULL;
120
do {
121
new_plugin = malloc(sizeof(plugin));
122
} while(new_plugin == NULL and errno == EINTR);
112
123
if(new_plugin == NULL){
113
124
return NULL;
114
125
}
115
126
char *copy_name = NULL;
116
127
if(name != NULL){
117
copy_name = strdup(name);
128
do {
129
copy_name = strdup(name);
130
} while(copy_name == NULL and errno == EINTR);
118
131
if(copy_name == NULL){
132
int e = errno;
119
133
free(new_plugin);
134
errno = e;
120
135
return NULL;
121
136
}
122
137
}
126
141
.disabled = false,
127
142
.next = plugin_list };
128
143
129
new_plugin->argv = malloc(sizeof(char *) * 2);
144
do {
145
new_plugin->argv = malloc(sizeof(char *) * 2);
146
} while(new_plugin->argv == NULL and errno == EINTR);
130
147
if(new_plugin->argv == NULL){
148
int e = errno;
131
149
free(copy_name);
132
150
free(new_plugin);
151
errno = e;
133
152
return NULL;
134
153
}
135
154
new_plugin->argv[0] = copy_name;
136
155
new_plugin->argv[1] = NULL;
137
156
138
new_plugin->environ = malloc(sizeof(char *));
157
do {
158
new_plugin->environ = malloc(sizeof(char *));
159
} while(new_plugin->environ == NULL and errno == EINTR);
139
160
if(new_plugin->environ == NULL){
161
int e = errno;
140
162
free(copy_name);
141
163
free(new_plugin->argv);
142
164
free(new_plugin);
165
errno = e;
143
166
return NULL;
144
167
}
145
168
new_plugin->environ[0] = NULL;
150
173
}
151
174
152
175
/* Helper function for add_argument and add_environment */
176
__attribute__((nonnull, warn_unused_result))
153
177
static bool add_to_char_array(const char *new, char ***array,
154
178
int *len){
155
179
/* Resize the pointed-to array to hold one more pointer */
156
*array = realloc(*array, sizeof(char *)
157
* (size_t) ((*len) + 2));
180
char **new_array = NULL;
181
do {
182
new_array = realloc(*array, sizeof(char *)
183
* (size_t) ((*len) + 2));
184
} while(new_array == NULL and errno == EINTR);
158
185
/* Malloc check */
159
if(*array == NULL){
186
if(new_array == NULL){
160
187
return false;
161
188
}
189
*array = new_array;
162
190
/* Make a copy of the new string */
163
char *copy = strdup(new);
191
char *copy;
192
do {
193
copy = strdup(new);
194
} while(copy == NULL and errno == EINTR);
164
195
if(copy == NULL){
165
196
return false;
166
197
}
173
204
}
174
205
175
206
/* Add to a plugin's argument vector */
207
__attribute__((nonnull(2), warn_unused_result))
176
208
static bool add_argument(plugin *p, const char *arg){
177
209
if(p == NULL){
178
210
return false;
181
213
}
182
214
183
215
/* Add to a plugin's environment */
216
__attribute__((nonnull(2), warn_unused_result))
184
217
static bool add_environment(plugin *p, const char *def, bool replace){
185
218
if(p == NULL){
186
219
return false;
188
221
/* namelen = length of name of environment variable */
189
222
size_t namelen = (size_t)(strchrnul(def, '=') - def);
190
223
/* Search for this environment variable */
191
for(char **e = p->environ; *e != NULL; e++){
192
if(strncmp(*e, def, namelen + 1) == 0){
224
for(char **envdef = p->environ; *envdef != NULL; envdef++){
225
if(strncmp(*envdef, def, namelen + 1) == 0){
193
226
/* It already exists */
194
227
if(replace){
195
char *new = realloc(*e, strlen(def) + 1);
196
if(new == NULL){
228
char *new_envdef;
229
do {
230
new_envdef = realloc(*envdef, strlen(def) + 1);
231
} while(new_envdef == NULL and errno == EINTR);
232
if(new_envdef == NULL){
197
233
return false;
198
234
}
199
*e = new;
200
strcpy(*e, def);
235
*envdef = new_envdef;
236
strcpy(*envdef, def);
201
237
}
202
238
return true;
203
239
}
205
241
return add_to_char_array(def, &(p->environ), &(p->envc));
206
242
}
207
243
244
#ifndef O_CLOEXEC
208
245
/*
209
246
* Based on the example in the GNU LibC manual chapter 13.13 "File
210
247
* Descriptor Flags".
211
* *Note File Descriptor Flags:(libc)Descriptor Flags.
248
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
212
249
*/
250
__attribute__((warn_unused_result))
213
251
static int set_cloexec_flag(int fd){
214
int ret = fcntl(fd, F_GETFD, 0);
252
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
215
253
/* If reading the flags failed, return error indication now. */
216
254
if(ret < 0){
217
255
return ret;
218
256
}
219
257
/* Store modified flag word in the descriptor. */
220
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
258
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
259
ret | FD_CLOEXEC));
221
260
}
261
#endif /* not O_CLOEXEC */
222
262
223
263
224
264
/* Mark processes as completed when they exit, and save their exit
238
278
/* No child processes */
239
279
break;
240
280
}
241
perror("waitpid");
281
error(0, errno, "waitpid");
242
282
}
243
283
244
284
/* A child exited, find it in process_list */
256
296
}
257
297
258
298
/* Prints out a password to stdout */
299
__attribute__((nonnull, warn_unused_result))
259
300
static bool print_out_password(const char *buffer, size_t length){
260
301
ssize_t ret;
261
302
for(size_t written = 0; written < length; written += (size_t)ret){
269
310
}
270
311
271
312
/* Removes and free a plugin from the plugin list */
313
__attribute__((nonnull))
272
314
static void free_plugin(plugin *plugin_node){
273
315
316
free(plugin_node->name);
274
317
for(char **arg = plugin_node->argv; *arg != NULL; arg++){
275
318
free(*arg);
276
319
}
280
323
}
281
324
free(plugin_node->environ);
282
325
free(plugin_node->buffer);
283
326
284
327
/* Removes the plugin from the singly-linked list */
285
328
if(plugin_node == plugin_list){
286
329
/* First one - simple */
306
349
307
350
int main(int argc, char *argv[]){
308
351
char *plugindir = NULL;
352
char *pluginhelperdir = NULL;
309
353
char *argfile = NULL;
310
354
FILE *conffp;
311
size_t d_name_len;
312
DIR *dir = NULL;
313
struct dirent *dirst;
355
struct dirent **direntries = NULL;
314
356
struct stat st;
315
357
fd_set rfds_all;
316
int ret, numchars, maxfd = 0;
358
int ret, maxfd = 0;
317
359
ssize_t sret;
318
intmax_t tmpmax;
319
360
uid_t uid = 65534;
320
361
gid_t gid = 65534;
321
362
bool debug = false;
325
366
.sa_flags = SA_NOCLDSTOP };
326
367
char **custom_argv = NULL;
327
368
int custom_argc = 0;
369
int dir_fd = -1;
328
370
329
371
/* Establish a signal handler */
330
372
sigemptyset(&sigchld_action.sa_mask);
331
373
ret = sigaddset(&sigchld_action.sa_mask, SIGCHLD);
332
374
if(ret == -1){
333
perror("sigaddset");
334
exitstatus = EXIT_FAILURE;
375
error(0, errno, "sigaddset");
376
exitstatus = EX_OSERR;
335
377
goto fallback;
336
378
}
337
379
ret = sigaction(SIGCHLD, &sigchld_action, &old_sigchld_action);
338
380
if(ret == -1){
339
perror("sigaction");
340
exitstatus = EXIT_FAILURE;
381
error(0, errno, "sigaction");
382
exitstatus = EX_OSERR;
341
383
goto fallback;
342
384
}
343
385
375
417
.doc = "Group ID the plugins will run as", .group = 3 },
376
418
{ .name = "debug", .key = 132,
377
419
.doc = "Debug mode", .group = 4 },
420
{ .name = "plugin-helper-dir", .key = 133,
421
.arg = "DIRECTORY",
422
.doc = "Specify a different plugin helper directory",
423
.group = 2 },
424
/*
425
* These reproduce what we would get without ARGP_NO_HELP
426
*/
427
{ .name = "help", .key = '?',
428
.doc = "Give this help list", .group = -1 },
429
{ .name = "usage", .key = -3,
430
.doc = "Give a short usage message", .group = -1 },
431
{ .name = "version", .key = 'V',
432
.doc = "Print program version", .group = -1 },
378
433
{ .name = NULL }
379
434
};
380
435
381
error_t parse_opt(int key, char *arg, __attribute__((unused))
382
struct argp_state *state){
436
__attribute__((nonnull(3)))
437
error_t parse_opt(int key, char *arg, struct argp_state *state){
438
errno = 0;
383
439
switch(key){
440
char *tmp;
441
intmax_t tmp_id;
384
442
case 'g': /* --global-options */
385
if(arg != NULL){
443
{
386
444
char *plugin_option;
387
445
while((plugin_option = strsep(&arg, ",")) != NULL){
388
if(plugin_option[0] == '\0'){
389
continue;
390
}
391
446
if(not add_argument(getplugin(NULL), plugin_option)){
392
perror("add_argument");
393
return ARGP_ERR_UNKNOWN;
447
break;
394
448
}
395
449
}
450
errno = 0;
396
451
}
397
452
break;
398
453
case 'G': /* --global-env */
399
if(arg == NULL){
400
break;
401
}
402
if(not add_environment(getplugin(NULL), arg, true)){
403
perror("add_environment");
454
if(add_environment(getplugin(NULL), arg, true)){
455
errno = 0;
404
456
}
405
457
break;
406
458
case 'o': /* --options-for */
407
if(arg != NULL){
408
char *plugin_name = strsep(&arg, ":");
409
if(plugin_name[0] == '\0'){
410
break;
411
}
412
char *plugin_option;
413
while((plugin_option = strsep(&arg, ",")) != NULL){
414
if(not add_argument(getplugin(plugin_name), plugin_option)){
415
perror("add_argument");
416
return ARGP_ERR_UNKNOWN;
459
{
460
char *option_list = strchr(arg, ':');
461
if(option_list == NULL){
462
argp_error(state, "No colon in \"%s\"", arg);
463
errno = EINVAL;
464
break;
465
}
466
*option_list = '\0';
467
option_list++;
468
if(arg[0] == '\0'){
469
argp_error(state, "Empty plugin name");
470
errno = EINVAL;
471
break;
472
}
473
char *option;
474
while((option = strsep(&option_list, ",")) != NULL){
475
if(not add_argument(getplugin(arg), option)){
476
break;
417
477
}
418
478
}
479
errno = 0;
419
480
}
420
481
break;
421
482
case 'E': /* --env-for */
422
if(arg == NULL){
423
break;
424
}
425
483
{
426
484
char *envdef = strchr(arg, ':');
427
485
if(envdef == NULL){
486
argp_error(state, "No colon in \"%s\"", arg);
487
errno = EINVAL;
428
488
break;
429
489
}
430
490
*envdef = '\0';
431
if(not add_environment(getplugin(arg), envdef+1, true)){
432
perror("add_environment");
491
envdef++;
492
if(arg[0] == '\0'){
493
argp_error(state, "Empty plugin name");
494
errno = EINVAL;
495
break;
496
}
497
if(add_environment(getplugin(arg), envdef, true)){
498
errno = 0;
433
499
}
434
500
}
435
501
break;
436
502
case 'd': /* --disable */
437
if(arg != NULL){
503
{
438
504
plugin *p = getplugin(arg);
439
if(p == NULL){
440
return ARGP_ERR_UNKNOWN;
505
if(p != NULL){
506
p->disabled = true;
507
errno = 0;
441
508
}
442
p->disabled = true;
443
509
}
444
510
break;
445
511
case 'e': /* --enable */
446
if(arg != NULL){
512
{
447
513
plugin *p = getplugin(arg);
448
if(p == NULL){
449
return ARGP_ERR_UNKNOWN;
514
if(p != NULL){
515
p->disabled = false;
516
errno = 0;
450
517
}
451
p->disabled = false;
452
518
}
453
519
break;
454
520
case 128: /* --plugin-dir */
455
521
free(plugindir);
456
522
plugindir = strdup(arg);
457
if(plugindir == NULL){
458
perror("strdup");
459
}
523
if(plugindir != NULL){
524
errno = 0;
525
}
460
526
break;
461
527
case 129: /* --config-file */
462
528
/* This is already done by parse_opt_config_file() */
463
529
break;
464
530
case 130: /* --userid */
465
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
466
if(ret < 1 or tmpmax != (uid_t)tmpmax
467
or arg[numchars] != '\0'){
468
fprintf(stderr, "Bad user ID number: \"%s\", using %"
469
PRIdMAX "\n", arg, (intmax_t)uid);
470
} else {
471
uid = (uid_t)tmpmax;
531
tmp_id = strtoimax(arg, &tmp, 10);
532
if(errno != 0 or tmp == arg or *tmp != '\0'
533
or tmp_id != (uid_t)tmp_id){
534
argp_error(state, "Bad user ID number: \"%s\", using %"
535
PRIdMAX, arg, (intmax_t)uid);
536
break;
472
537
}
538
uid = (uid_t)tmp_id;
539
errno = 0;
473
540
break;
474
541
case 131: /* --groupid */
475
ret = sscanf(arg, "%" SCNdMAX "%n", &tmpmax, &numchars);
476
if(ret < 1 or tmpmax != (gid_t)tmpmax
477
or arg[numchars] != '\0'){
478
fprintf(stderr, "Bad group ID number: \"%s\", using %"
479
PRIdMAX "\n", arg, (intmax_t)gid);
480
} else {
481
gid = (gid_t)tmpmax;
542
tmp_id = strtoimax(arg, &tmp, 10);
543
if(errno != 0 or tmp == arg or *tmp != '\0'
544
or tmp_id != (gid_t)tmp_id){
545
argp_error(state, "Bad group ID number: \"%s\", using %"
546
PRIdMAX, arg, (intmax_t)gid);
547
break;
482
548
}
549
gid = (gid_t)tmp_id;
550
errno = 0;
483
551
break;
484
552
case 132: /* --debug */
485
553
debug = true;
486
554
break;
555
case 133: /* --plugin-helper-dir */
556
free(pluginhelperdir);
557
pluginhelperdir = strdup(arg);
558
if(pluginhelperdir != NULL){
559
errno = 0;
560
}
561
break;
562
/*
563
* These reproduce what we would get without ARGP_NO_HELP
564
*/
565
case '?': /* --help */
566
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
567
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
568
case -3: /* --usage */
569
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
570
argp_state_help(state, state->out_stream,
571
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
572
case 'V': /* --version */
573
fprintf(state->out_stream, "%s\n", argp_program_version);
574
exit(EXIT_SUCCESS);
575
break;
487
576
/*
488
577
* When adding more options before this line, remember to also add a
489
578
* "case" to the "parse_opt_config_file" function below.
492
581
/* Cryptsetup always passes an argument, which is an empty
493
582
string if "none" was specified in /etc/crypttab. So if
494
583
argument was empty, we ignore it silently. */
495
if(arg[0] != '\0'){
496
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
584
if(arg[0] == '\0'){
585
break;
497
586
}
498
break;
499
case ARGP_KEY_END:
500
break;
501
587
default:
502
588
return ARGP_ERR_UNKNOWN;
503
589
}
504
return 0;
590
return errno; /* Set to 0 at start */
505
591
}
506
592
507
593
/* This option parser is the same as parse_opt() above, except it
509
595
error_t parse_opt_config_file(int key, char *arg,
510
596
__attribute__((unused))
511
597
struct argp_state *state){
598
errno = 0;
512
599
switch(key){
513
600
case 'g': /* --global-options */
514
601
case 'G': /* --global-env */
521
608
case 129: /* --config-file */
522
609
free(argfile);
523
610
argfile = strdup(arg);
524
if(argfile == NULL){
525
perror("strdup");
611
if(argfile != NULL){
612
errno = 0;
526
613
}
527
break;
614
break;
528
615
case 130: /* --userid */
529
616
case 131: /* --groupid */
530
617
case 132: /* --debug */
618
case 133: /* --plugin-helper-dir */
619
case '?': /* --help */
620
case -3: /* --usage */
621
case 'V': /* --version */
531
622
case ARGP_KEY_ARG:
532
case ARGP_KEY_END:
533
623
break;
534
624
default:
535
625
return ARGP_ERR_UNKNOWN;
536
626
}
537
return 0;
627
return errno;
538
628
}
539
629
540
630
struct argp argp = { .options = options,
544
634
545
635
/* Parse using parse_opt_config_file() in order to get the custom
546
636
config file location, if any. */
547
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
548
if(ret == ARGP_ERR_UNKNOWN){
549
fprintf(stderr, "Unknown error while parsing arguments\n");
550
exitstatus = EXIT_FAILURE;
637
ret = argp_parse(&argp, argc, argv,
638
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
639
NULL, NULL);
640
switch(ret){
641
case 0:
642
break;
643
case ENOMEM:
644
default:
645
errno = ret;
646
error(0, errno, "argp_parse");
647
exitstatus = EX_OSERR;
648
goto fallback;
649
case EINVAL:
650
exitstatus = EX_USAGE;
551
651
goto fallback;
552
652
}
553
653
559
659
conffp = fopen(AFILE, "r");
560
660
} else {
561
661
conffp = fopen(argfile, "r");
562
}
662
}
563
663
if(conffp != NULL){
564
664
char *org_line = NULL;
565
665
char *p, *arg, *new_arg, *line;
566
666
size_t size = 0;
567
667
const char whitespace_delims[] = " \r\t\f\v\n";
568
668
const char comment_delim[] = "#";
569
669
570
670
custom_argc = 1;
571
671
custom_argv = malloc(sizeof(char*) * 2);
572
672
if(custom_argv == NULL){
573
perror("malloc");
574
exitstatus = EXIT_FAILURE;
673
error(0, errno, "malloc");
674
exitstatus = EX_OSERR;
575
675
goto fallback;
576
676
}
577
677
custom_argv[0] = argv[0];
578
678
custom_argv[1] = NULL;
579
679
580
680
/* for each line in the config file, strip whitespace and ignore
581
681
commented text */
582
682
while(true){
584
684
if(sret == -1){
585
685
break;
586
686
}
587
687
588
688
line = org_line;
589
689
arg = strsep(&line, comment_delim);
590
690
while((p = strsep(&arg, whitespace_delims)) != NULL){
593
693
}
594
694
new_arg = strdup(p);
595
695
if(new_arg == NULL){
596
perror("strdup");
597
exitstatus = EXIT_FAILURE;
696
error(0, errno, "strdup");
697
exitstatus = EX_OSERR;
598
698
free(org_line);
599
699
goto fallback;
600
700
}
601
701
602
702
custom_argc += 1;
603
custom_argv = realloc(custom_argv, sizeof(char *)
604
* ((unsigned int) custom_argc + 1));
605
if(custom_argv == NULL){
606
perror("realloc");
607
exitstatus = EXIT_FAILURE;
608
free(org_line);
609
goto fallback;
703
{
704
char **new_argv = realloc(custom_argv, sizeof(char *)
705
* ((size_t)custom_argc + 1));
706
if(new_argv == NULL){
707
error(0, errno, "realloc");
708
exitstatus = EX_OSERR;
709
free(new_arg);
710
free(org_line);
711
goto fallback;
712
} else {
713
custom_argv = new_argv;
714
}
610
715
}
611
716
custom_argv[custom_argc-1] = new_arg;
612
custom_argv[custom_argc] = NULL;
717
custom_argv[custom_argc] = NULL;
613
718
}
614
719
}
720
do {
721
ret = fclose(conffp);
722
} while(ret == EOF and errno == EINTR);
723
if(ret == EOF){
724
error(0, errno, "fclose");
725
exitstatus = EX_IOERR;
726
goto fallback;
727
}
615
728
free(org_line);
616
729
} else {
617
730
/* Check for harmful errors and go to fallback. Other errors might
618
731
not affect opening plugins */
619
732
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
620
perror("fopen");
621
exitstatus = EXIT_FAILURE;
733
error(0, errno, "fopen");
734
exitstatus = EX_OSERR;
622
735
goto fallback;
623
736
}
624
737
}
625
/* If there was any arguments from configuration file,
626
pass them to parser as command arguments */
738
/* If there were any arguments from the configuration file, pass
739
them to parser as command line arguments */
627
740
if(custom_argv != NULL){
628
ret = argp_parse(&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
629
0, NULL);
630
if(ret == ARGP_ERR_UNKNOWN){
631
fprintf(stderr, "Unknown error while parsing arguments\n");
632
exitstatus = EXIT_FAILURE;
741
ret = argp_parse(&argp, custom_argc, custom_argv,
742
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
743
NULL, NULL);
744
switch(ret){
745
case 0:
746
break;
747
case ENOMEM:
748
default:
749
errno = ret;
750
error(0, errno, "argp_parse");
751
exitstatus = EX_OSERR;
752
goto fallback;
753
case EINVAL:
754
exitstatus = EX_CONFIG;
633
755
goto fallback;
634
756
}
635
757
}
636
758
637
759
/* Parse actual command line arguments, to let them override the
638
760
config file */
639
ret = argp_parse(&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
640
if(ret == ARGP_ERR_UNKNOWN){
641
fprintf(stderr, "Unknown error while parsing arguments\n");
642
exitstatus = EXIT_FAILURE;
643
goto fallback;
761
ret = argp_parse(&argp, argc, argv,
762
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
763
NULL, NULL);
764
switch(ret){
765
case 0:
766
break;
767
case ENOMEM:
768
default:
769
errno = ret;
770
error(0, errno, "argp_parse");
771
exitstatus = EX_OSERR;
772
goto fallback;
773
case EINVAL:
774
exitstatus = EX_USAGE;
775
goto fallback;
776
}
777
778
{
779
char *pluginhelperenv;
780
bool bret = true;
781
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
782
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
783
if(ret != -1){
784
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
785
}
786
if(ret == -1 or not bret){
787
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
788
" environment variable to \"%s\" for all plugins\n",
789
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
790
}
791
if(ret != -1){
792
free(pluginhelperenv);
793
}
644
794
}
645
795
646
796
if(debug){
647
for(plugin *p = plugin_list; p != NULL; p=p->next){
797
for(plugin *p = plugin_list; p != NULL; p = p->next){
648
798
fprintf(stderr, "Plugin: %s has %d arguments\n",
649
799
p->name ? p->name : "Global", p->argc - 1);
650
800
for(char **a = p->argv; *a != NULL; a++){
657
807
}
658
808
}
659
809
660
/* Strip permissions down to nobody */
661
setgid(gid);
810
if(getuid() == 0){
811
/* Work around Debian bug #633582:
812
<https://bugs.debian.org/633582> */
813
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
814
if(plugindir_fd == -1){
815
if(errno != ENOENT){
816
error(0, errno, "open(\"" PDIR "\")");
817
}
818
} else {
819
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
820
if(ret == -1){
821
error(0, errno, "fstat");
822
} else {
823
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
824
ret = fchown(plugindir_fd, uid, gid);
825
if(ret == -1){
826
error(0, errno, "fchown");
827
}
828
}
829
}
830
close(plugindir_fd);
831
}
832
}
833
834
/* Lower permissions */
835
ret = setgid(gid);
662
836
if(ret == -1){
663
perror("setgid");
837
error(0, errno, "setgid");
664
838
}
665
839
ret = setuid(uid);
666
840
if(ret == -1){
667
perror("setuid");
668
}
669
670
if(plugindir == NULL){
671
dir = opendir(PDIR);
672
} else {
673
dir = opendir(plugindir);
674
}
675
676
if(dir == NULL){
677
perror("Could not open plugin dir");
678
exitstatus = EXIT_FAILURE;
679
goto fallback;
680
}
681
682
/* Set the FD_CLOEXEC flag on the directory, if possible */
841
error(0, errno, "setuid");
842
}
843
844
/* Open plugin directory with close_on_exec flag */
683
845
{
684
int dir_fd = dirfd(dir);
685
if(dir_fd >= 0){
686
ret = set_cloexec_flag(dir_fd);
687
if(ret < 0){
688
perror("set_cloexec_flag");
689
exitstatus = EXIT_FAILURE;
690
goto fallback;
846
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
847
#ifdef O_CLOEXEC
848
O_CLOEXEC
849
#else /* not O_CLOEXEC */
850
0
851
#endif /* not O_CLOEXEC */
852
);
853
if(dir_fd == -1){
854
error(0, errno, "Could not open plugin dir");
855
exitstatus = EX_UNAVAILABLE;
856
goto fallback;
857
}
858
859
#ifndef O_CLOEXEC
860
/* Set the FD_CLOEXEC flag on the directory */
861
ret = set_cloexec_flag(dir_fd);
862
if(ret < 0){
863
error(0, errno, "set_cloexec_flag");
864
exitstatus = EX_OSERR;
865
goto fallback;
866
}
867
#endif /* O_CLOEXEC */
868
}
869
870
int good_name(const struct dirent * const dirent){
871
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
872
"*.dpkg-old", "*.dpkg-bak",
873
"*.dpkg-divert", NULL };
874
#ifdef __GNUC__
875
#pragma GCC diagnostic push
876
#pragma GCC diagnostic ignored "-Wcast-qual"
877
#endif
878
for(const char **pat = (const char **)patterns;
879
*pat != NULL; pat++){
880
#ifdef __GNUC__
881
#pragma GCC diagnostic pop
882
#endif
883
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
884
!= FNM_NOMATCH){
885
if(debug){
886
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
887
" matching pattern %s\n", dirent->d_name, *pat);
888
}
889
return 0;
691
890
}
692
891
}
892
return 1;
893
}
894
895
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
896
alphasort);
897
if(numplugins == -1){
898
error(0, errno, "Could not scan plugin dir");
899
direntries = NULL;
900
exitstatus = EX_OSERR;
901
goto fallback;
693
902
}
694
903
695
904
FD_ZERO(&rfds_all);
696
905
697
906
/* Read and execute any executable in the plugin directory*/
698
while(true){
699
dirst = readdir(dir);
700
701
/* All directory entries have been processed */
702
if(dirst == NULL){
703
if(errno == EBADF){
704
perror("readdir");
705
exitstatus = EXIT_FAILURE;
706
goto fallback;
707
}
708
break;
709
}
710
711
d_name_len = strlen(dirst->d_name);
712
713
/* Ignore dotfiles, backup files and other junk */
714
{
715
bool bad_name = false;
716
717
const char const *bad_prefixes[] = { ".", "#", NULL };
718
719
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
720
".dpkg-old",
721
".dpkg-bak",
722
".dpkg-divert", NULL };
723
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
724
size_t pre_len = strlen(*pre);
725
if((d_name_len >= pre_len)
726
and strncmp((dirst->d_name), *pre, pre_len) == 0){
727
if(debug){
728
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
729
" with bad prefix %s\n", dirst->d_name, *pre);
730
}
731
bad_name = true;
732
break;
733
}
734
}
735
if(bad_name){
736
continue;
737
}
738
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
739
size_t suf_len = strlen(*suf);
740
if((d_name_len >= suf_len)
741
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
742
== 0)){
743
if(debug){
744
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
745
" with bad suffix %s\n", dirst->d_name, *suf);
746
}
747
bad_name = true;
748
break;
749
}
750
}
751
752
if(bad_name){
753
continue;
754
}
755
}
756
757
char *filename;
758
if(plugindir == NULL){
759
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
760
} else {
761
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
762
}
763
if(ret < 0){
764
perror("asprintf");
907
for(int i = 0; i < numplugins; i++){
908
909
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
910
if(plugin_fd == -1){
911
error(0, errno, "Could not open plugin");
912
free(direntries[i]);
765
913
continue;
766
914
}
767
768
ret = stat(filename, &st);
915
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
769
916
if(ret == -1){
770
perror("stat");
771
free(filename);
917
error(0, errno, "stat");
918
close(plugin_fd);
919
free(direntries[i]);
772
920
continue;
773
921
}
774
922
775
923
/* Ignore non-executable files */
776
if(not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
924
if(not S_ISREG(st.st_mode)
925
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
926
X_OK, 0)) != 0)){
777
927
if(debug){
778
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
779
" with bad type or mode\n", filename);
928
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
929
" with bad type or mode\n",
930
plugindir != NULL ? plugindir : PDIR,
931
direntries[i]->d_name);
780
932
}
781
free(filename);
933
close(plugin_fd);
934
free(direntries[i]);
782
935
continue;
783
936
}
784
937
785
plugin *p = getplugin(dirst->d_name);
938
plugin *p = getplugin(direntries[i]->d_name);
786
939
if(p == NULL){
787
perror("getplugin");
788
free(filename);
940
error(0, errno, "getplugin");
941
close(plugin_fd);
942
free(direntries[i]);
789
943
continue;
790
944
}
791
945
if(p->disabled){
792
946
if(debug){
793
947
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
794
dirst->d_name);
948
direntries[i]->d_name);
795
949
}
796
free(filename);
950
close(plugin_fd);
951
free(direntries[i]);
797
952
continue;
798
953
}
799
954
{
802
957
if(g != NULL){
803
958
for(char **a = g->argv + 1; *a != NULL; a++){
804
959
if(not add_argument(p, *a)){
805
perror("add_argument");
960
error(0, errno, "add_argument");
806
961
}
807
962
}
808
963
/* Add global environment variables */
809
964
for(char **e = g->environ; *e != NULL; e++){
810
965
if(not add_environment(p, *e, false)){
811
perror("add_environment");
966
error(0, errno, "add_environment");
812
967
}
813
968
}
814
969
}
815
970
}
816
/* If this plugin has any environment variables, we will call
817
using execve and need to duplicate the environment from this
818
process, too. */
971
/* If this plugin has any environment variables, we need to
972
duplicate the environment from this process, too. */
819
973
if(p->environ[0] != NULL){
820
974
for(char **e = environ; *e != NULL; e++){
821
975
if(not add_environment(p, *e, false)){
822
perror("add_environment");
976
error(0, errno, "add_environment");
823
977
}
824
978
}
825
979
}
826
980
827
981
int pipefd[2];
828
ret = pipe(pipefd);
982
#ifndef O_CLOEXEC
983
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
984
#else /* O_CLOEXEC */
985
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
986
#endif /* O_CLOEXEC */
829
987
if(ret == -1){
830
perror("pipe");
831
exitstatus = EXIT_FAILURE;
832
goto fallback;
833
}
988
error(0, errno, "pipe");
989
exitstatus = EX_OSERR;
990
free(direntries[i]);
991
goto fallback;
992
}
993
if(pipefd[0] >= FD_SETSIZE){
994
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
995
FD_SETSIZE);
996
close(pipefd[0]);
997
close(pipefd[1]);
998
exitstatus = EX_OSERR;
999
free(direntries[i]);
1000
goto fallback;
1001
}
1002
#ifndef O_CLOEXEC
834
1003
/* Ask OS to automatic close the pipe on exec */
835
1004
ret = set_cloexec_flag(pipefd[0]);
836
1005
if(ret < 0){
837
perror("set_cloexec_flag");
838
exitstatus = EXIT_FAILURE;
1006
error(0, errno, "set_cloexec_flag");
1007
close(pipefd[0]);
1008
close(pipefd[1]);
1009
exitstatus = EX_OSERR;
1010
free(direntries[i]);
839
1011
goto fallback;
840
1012
}
841
1013
ret = set_cloexec_flag(pipefd[1]);
842
1014
if(ret < 0){
843
perror("set_cloexec_flag");
844
exitstatus = EXIT_FAILURE;
1015
error(0, errno, "set_cloexec_flag");
1016
close(pipefd[0]);
1017
close(pipefd[1]);
1018
exitstatus = EX_OSERR;
1019
free(direntries[i]);
845
1020
goto fallback;
846
1021
}
1022
#endif /* not O_CLOEXEC */
847
1023
/* Block SIGCHLD until process is safely in process list */
848
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1024
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1025
&sigchld_action.sa_mask,
1026
NULL));
849
1027
if(ret < 0){
850
perror("sigprocmask");
851
exitstatus = EXIT_FAILURE;
1028
error(0, errno, "sigprocmask");
1029
exitstatus = EX_OSERR;
1030
free(direntries[i]);
852
1031
goto fallback;
853
1032
}
854
1033
/* Starting a new process to be watched */
855
pid_t pid = fork();
1034
pid_t pid;
1035
do {
1036
pid = fork();
1037
} while(pid == -1 and errno == EINTR);
856
1038
if(pid == -1){
857
perror("fork");
858
exitstatus = EXIT_FAILURE;
1039
error(0, errno, "fork");
1040
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1041
&sigchld_action.sa_mask, NULL));
1042
close(pipefd[0]);
1043
close(pipefd[1]);
1044
exitstatus = EX_OSERR;
1045
free(direntries[i]);
859
1046
goto fallback;
860
1047
}
861
1048
if(pid == 0){
862
1049
/* this is the child process */
863
1050
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
864
1051
if(ret < 0){
865
perror("sigaction");
866
_exit(EXIT_FAILURE);
1052
error(0, errno, "sigaction");
1053
_exit(EX_OSERR);
867
1054
}
868
1055
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
869
1056
if(ret < 0){
870
perror("sigprocmask");
871
_exit(EXIT_FAILURE);
1057
error(0, errno, "sigprocmask");
1058
_exit(EX_OSERR);
872
1059
}
873
1060
874
1061
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
875
1062
if(ret == -1){
876
perror("dup2");
877
_exit(EXIT_FAILURE);
1063
error(0, errno, "dup2");
1064
_exit(EX_OSERR);
878
1065
}
879
1066
880
if(dirfd(dir) < 0){
881
/* If dir has no file descriptor, we could not set FD_CLOEXEC
882
above and must now close it manually here. */
883
closedir(dir);
884
}
885
if(p->environ[0] == NULL){
886
if(execv(filename, p->argv) < 0){
887
perror("execv");
888
_exit(EXIT_FAILURE);
889
}
890
} else {
891
if(execve(filename, p->argv, p->environ) < 0){
892
perror("execve");
893
_exit(EXIT_FAILURE);
894
}
1067
if(fexecve(plugin_fd, p->argv,
1068
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1069
error(0, errno, "fexecve for %s/%s",
1070
plugindir != NULL ? plugindir : PDIR,
1071
direntries[i]->d_name);
1072
_exit(EX_OSERR);
895
1073
}
896
1074
/* no return */
897
1075
}
898
1076
/* Parent process */
899
1077
close(pipefd[1]); /* Close unused write end of pipe */
900
free(filename);
901
plugin *new_plugin = getplugin(dirst->d_name);
1078
close(plugin_fd);
1079
plugin *new_plugin = getplugin(direntries[i]->d_name);
902
1080
if(new_plugin == NULL){
903
perror("getplugin");
904
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1081
error(0, errno, "getplugin");
1082
ret = (int)(TEMP_FAILURE_RETRY
1083
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
1084
NULL)));
905
1085
if(ret < 0){
906
perror("sigprocmask");
1086
error(0, errno, "sigprocmask");
907
1087
}
908
exitstatus = EXIT_FAILURE;
1088
exitstatus = EX_OSERR;
1089
free(direntries[i]);
909
1090
goto fallback;
910
1091
}
1092
free(direntries[i]);
911
1093
912
1094
new_plugin->pid = pid;
913
1095
new_plugin->fd = pipefd[0];
914
1096
915
1097
/* Unblock SIGCHLD so signal handler can be run if this process
916
1098
has already completed */
917
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1099
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1100
&sigchld_action.sa_mask,
1101
NULL));
918
1102
if(ret < 0){
919
perror("sigprocmask");
920
exitstatus = EXIT_FAILURE;
1103
error(0, errno, "sigprocmask");
1104
exitstatus = EX_OSERR;
921
1105
goto fallback;
922
1106
}
923
1107
928
1112
}
929
1113
}
930
1114
931
closedir(dir);
932
dir = NULL;
1115
free(direntries);
1116
direntries = NULL;
1117
close(dir_fd);
1118
dir_fd = -1;
933
1119
free_plugin(getplugin(NULL));
934
1120
935
1121
for(plugin *p = plugin_list; p != NULL; p = p->next){
947
1133
while(plugin_list){
948
1134
fd_set rfds = rfds_all;
949
1135
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
950
if(select_ret == -1){
951
perror("select");
952
exitstatus = EXIT_FAILURE;
1136
if(select_ret == -1 and errno != EINTR){
1137
error(0, errno, "select");
1138
exitstatus = EX_OSERR;
953
1139
goto fallback;
954
1140
}
955
1141
/* OK, now either a process completed, or something can be read
961
1147
if(not WIFEXITED(proc->status)
962
1148
or WEXITSTATUS(proc->status) != 0){
963
1149
/* Bad exit by plugin */
964
1150
965
1151
if(debug){
966
1152
if(WIFEXITED(proc->status)){
967
1153
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
970
1156
WEXITSTATUS(proc->status));
971
1157
} else if(WIFSIGNALED(proc->status)){
972
1158
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
973
" signal %d\n", proc->name,
1159
" signal %d: %s\n", proc->name,
974
1160
(intmax_t) (proc->pid),
975
WTERMSIG(proc->status));
976
} else if(WCOREDUMP(proc->status)){
977
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
978
" core\n", proc->name, (intmax_t) (proc->pid));
1161
WTERMSIG(proc->status),
1162
strsignal(WTERMSIG(proc->status)));
979
1163
}
980
1164
}
981
1165
982
1166
/* Remove the plugin */
983
1167
FD_CLR(proc->fd, &rfds_all);
984
1168
985
1169
/* Block signal while modifying process_list */
986
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1170
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1171
(SIG_BLOCK,
1172
&sigchld_action.sa_mask,
1173
NULL));
987
1174
if(ret < 0){
988
perror("sigprocmask");
989
exitstatus = EXIT_FAILURE;
1175
error(0, errno, "sigprocmask");
1176
exitstatus = EX_OSERR;
990
1177
goto fallback;
991
1178
}
992
1179
995
1182
proc = next_plugin;
996
1183
997
1184
/* We are done modifying process list, so unblock signal */
998
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
999
NULL);
1185
ret = (int)(TEMP_FAILURE_RETRY
1186
(sigprocmask(SIG_UNBLOCK,
1187
&sigchld_action.sa_mask, NULL)));
1000
1188
if(ret < 0){
1001
perror("sigprocmask");
1002
exitstatus = EXIT_FAILURE;
1189
error(0, errno, "sigprocmask");
1190
exitstatus = EX_OSERR;
1003
1191
goto fallback;
1004
1192
}
1005
1193
1015
1203
bool bret = print_out_password(proc->buffer,
1016
1204
proc->buffer_length);
1017
1205
if(not bret){
1018
perror("print_out_password");
1019
exitstatus = EXIT_FAILURE;
1206
error(0, errno, "print_out_password");
1207
exitstatus = EX_IOERR;
1020
1208
}
1021
1209
goto fallback;
1022
1210
}
1029
1217
}
1030
1218
/* Before reading, make the process' data buffer large enough */
1031
1219
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1032
proc->buffer = realloc(proc->buffer, proc->buffer_size
1033
+ (size_t) BUFFER_SIZE);
1034
if(proc->buffer == NULL){
1035
perror("malloc");
1036
exitstatus = EXIT_FAILURE;
1220
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1221
+ (size_t) BUFFER_SIZE);
1222
if(new_buffer == NULL){
1223
error(0, errno, "malloc");
1224
exitstatus = EX_OSERR;
1037
1225
goto fallback;
1038
1226
}
1227
proc->buffer = new_buffer;
1039
1228
proc->buffer_size += BUFFER_SIZE;
1040
1229
}
1041
1230
/* Read from the process */
1042
sret = read(proc->fd, proc->buffer + proc->buffer_length,
1043
BUFFER_SIZE);
1231
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1232
proc->buffer
1233
+ proc->buffer_length,
1234
BUFFER_SIZE));
1044
1235
if(sret < 0){
1045
1236
/* Read error from this process; ignore the error */
1046
1237
proc = proc->next;
1054
1245
}
1055
1246
}
1056
1247
}
1057
1058
1248
1249
1059
1250
fallback:
1060
1251
1061
if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
1252
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1253
and exitstatus != EX_OK)){
1062
1254
/* Fallback if all plugins failed, none are found or an error
1063
1255
occured */
1064
1256
bool bret;
1072
1264
}
1073
1265
bret = print_out_password(passwordbuffer, len);
1074
1266
if(not bret){
1075
perror("print_out_password");
1076
exitstatus = EXIT_FAILURE;
1267
error(0, errno, "print_out_password");
1268
exitstatus = EX_IOERR;
1077
1269
}
1078
1270
}
1079
1271
1080
1272
/* Restore old signal handler */
1081
1273
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1082
1274
if(ret == -1){
1083
perror("sigaction");
1084
exitstatus = EXIT_FAILURE;
1275
error(0, errno, "sigaction");
1276
exitstatus = EX_OSERR;
1085
1277
}
1086
1278
1087
1279
if(custom_argv != NULL){
1091
1283
free(custom_argv);
1092
1284
}
1093
1285
1094
if(dir != NULL){
1095
closedir(dir);
1286
free(direntries);
1287
1288
if(dir_fd != -1){
1289
close(dir_fd);
1096
1290
}
1097
1291
1098
1292
/* Kill the processes */
1102
1296
ret = kill(p->pid, SIGTERM);
1103
1297
if(ret == -1 and errno != ESRCH){
1104
1298
/* Set-uid proccesses might not get closed */
1105
perror("kill");
1299
error(0, errno, "kill");
1106
1300
}
1107
1301
}
1108
1302
}
1109
1303
1110
1304
/* Wait for any remaining child processes to terminate */
1111
do{
1305
do {
1112
1306
ret = wait(NULL);
1113
1307
} while(ret >= 0);
1114
1308
if(errno != ECHILD){
1115
perror("wait");
1309
error(0, errno, "wait");
1116
1310
}
1117
1311
1118
1312
free_plugin_list();
1119
1313
1120
1314
free(plugindir);
1315
free(pluginhelperdir);
1121
1316
free(argfile);
1122
1317
1123
1318
return exitstatus;
Loggerhead is a web-based interface for Breezy
Version: 2.0.2.dev0