18
19
* along with this program. If not, see
19
20
* <http://www.gnu.org/licenses/>.
21
* Contact the authors at <mandos@fukt.bsnet.se>.
22
* Contact the authors at <mandos@recompile.se>.
24
25
#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
26
27
#include <stddef.h> /* size_t, NULL */
27
#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
28
EXIT_SUCCESS, realloc() */
28
#include <stdlib.h> /* malloc(), exit(), EXIT_SUCCESS,
29
30
#include <stdbool.h> /* bool, true, false */
30
#include <stdio.h> /* perror, popen(), fileno(),
31
fprintf(), stderr, STDOUT_FILENO */
32
#include <sys/types.h> /* DIR, opendir(), stat(), struct
33
stat, waitpid(), WIFEXITED(),
34
WEXITSTATUS(), wait(), pid_t,
35
uid_t, gid_t, getuid(), getgid(),
31
#include <stdio.h> /* fileno(), fprintf(),
32
stderr, STDOUT_FILENO, fclose() */
33
#include <sys/types.h> /* fstat(), struct stat, waitpid(),
34
WIFEXITED(), WEXITSTATUS(), wait(),
35
pid_t, uid_t, gid_t, getuid(),
37
37
#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
38
38
FD_SET(), FD_ISSET(), FD_CLR */
39
39
#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
41
#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
40
WEXITSTATUS(), WTERMSIG(),
42
#include <sys/stat.h> /* struct stat, fstat(), S_ISREG() */
42
43
#include <iso646.h> /* and, or, not */
43
#include <dirent.h> /* DIR, struct dirent, opendir(),
44
readdir(), closedir(), dirfd() */
45
#include <unistd.h> /* struct stat, stat(), S_ISREG(),
46
fcntl(), setuid(), setgid(),
47
F_GETFD, F_SETFD, FD_CLOEXEC,
48
access(), pipe(), fork(), close()
49
dup2, STDOUT_FILENO, _exit(),
50
execv(), write(), read(),
44
#include <dirent.h> /* struct dirent, scandirat() */
45
#include <unistd.h> /* fcntl(), F_GETFD, F_SETFD,
46
FD_CLOEXEC, write(), STDOUT_FILENO,
47
struct stat, fstat(), close(),
48
setgid(), setuid(), S_ISREG(),
49
faccessat() pipe2(), fork(),
50
_exit(), dup2(), fexecve(), read()
52
52
#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
54
#include <string.h> /* strsep, strlen(), asprintf() */
53
FD_CLOEXEC, openat(), scandirat(),
55
#include <string.h> /* strsep, strlen(), strsignal(),
56
strcmp(), strncmp() */
55
57
#include <errno.h> /* errno */
56
58
#include <argp.h> /* struct argp_option, struct
57
59
argp_state, struct argp,
61
63
#include <signal.h> /* struct sigaction, sigemptyset(),
62
64
sigaddset(), sigaction(),
63
65
sigprocmask(), SIG_BLOCK, SIGCHLD,
64
SIG_UNBLOCK, kill() */
66
SIG_UNBLOCK, kill(), sig_atomic_t
65
68
#include <errno.h> /* errno, EBADF */
69
#include <inttypes.h> /* intmax_t, PRIdMAX, strtoimax() */
70
#include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_IOERR,
71
EX_CONFIG, EX_UNAVAILABLE, EX_OK */
72
#include <errno.h> /* errno */
73
#include <error.h> /* error() */
74
#include <fnmatch.h> /* fnmatch() */
67
76
#define BUFFER_SIZE 256
69
78
#define PDIR "/lib/mandos/plugins.d"
79
#define PHDIR "/lib/mandos/plugin-helpers"
70
80
#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
72
const char *argp_program_version = "plugin-runner 1.0";
73
const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
82
const char *argp_program_version = "plugin-runner " VERSION;
83
const char *argp_program_bug_address = "<mandos@recompile.se>";
77
85
typedef struct plugin{
78
86
char *name; /* can be NULL or any plugin name */
99
107
/* Gets an existing plugin based on name,
100
108
or if none is found, creates a new one */
109
__attribute__((warn_unused_result))
101
110
static plugin *getplugin(char *name){
102
/* Check for exiting plugin with that name */
103
for (plugin *p = plugin_list; p != NULL; p = p->next){
104
if ((p->name == name)
105
or (p->name and name and (strcmp(p->name, name) == 0))){
111
/* Check for existing plugin with that name */
112
for(plugin *p = plugin_list; p != NULL; p = p->next){
114
or (p->name and name and (strcmp(p->name, name) == 0))){
109
118
/* Create a new plugin */
110
plugin *new_plugin = malloc(sizeof(plugin));
111
if (new_plugin == NULL){
119
plugin *new_plugin = NULL;
121
new_plugin = malloc(sizeof(plugin));
122
} while(new_plugin == NULL and errno == EINTR);
123
if(new_plugin == NULL){
114
126
char *copy_name = NULL;
115
127
if(name != NULL){
116
copy_name = strdup(name);
129
copy_name = strdup(name);
130
} while(copy_name == NULL and errno == EINTR);
117
131
if(copy_name == NULL){
122
*new_plugin = (plugin) { .name = copy_name,
125
.next = plugin_list };
139
*new_plugin = (plugin){ .name = copy_name,
142
.next = plugin_list };
127
new_plugin->argv = malloc(sizeof(char *) * 2);
128
if (new_plugin->argv == NULL){
145
new_plugin->argv = malloc(sizeof(char *) * 2);
146
} while(new_plugin->argv == NULL and errno == EINTR);
147
if(new_plugin->argv == NULL){
130
150
free(new_plugin);
133
154
new_plugin->argv[0] = copy_name;
134
155
new_plugin->argv[1] = NULL;
136
new_plugin->environ = malloc(sizeof(char *));
158
new_plugin->environ = malloc(sizeof(char *));
159
} while(new_plugin->environ == NULL and errno == EINTR);
137
160
if(new_plugin->environ == NULL){
139
163
free(new_plugin->argv);
140
164
free(new_plugin);
143
168
new_plugin->environ[0] = NULL;
203
241
return add_to_char_array(def, &(p->environ), &(p->envc));
207
246
* Based on the example in the GNU LibC manual chapter 13.13 "File
208
247
* Descriptor Flags".
209
* *Note File Descriptor Flags:(libc)Descriptor Flags.
248
| [[info:libc:Descriptor%20Flags][File Descriptor Flags]] |
211
static int set_cloexec_flag(int fd)
213
int ret = fcntl(fd, F_GETFD, 0);
250
__attribute__((warn_unused_result))
251
static int set_cloexec_flag(int fd){
252
int ret = (int)TEMP_FAILURE_RETRY(fcntl(fd, F_GETFD, 0));
214
253
/* If reading the flags failed, return error indication now. */
218
257
/* Store modified flag word in the descriptor. */
219
return fcntl(fd, F_SETFD, ret | FD_CLOEXEC);
258
return (int)TEMP_FAILURE_RETRY(fcntl(fd, F_SETFD,
261
#endif /* not O_CLOEXEC */
223
264
/* Mark processes as completed when they exit, and save their exit
225
void handle_sigchld(__attribute__((unused)) int sig){
266
static void handle_sigchld(__attribute__((unused)) int sig){
267
int old_errno = errno;
227
269
plugin *proc = plugin_list;
370
416
.doc = "Group ID the plugins will run as", .group = 3 },
371
417
{ .name = "debug", .key = 132,
372
418
.doc = "Debug mode", .group = 4 },
419
{ .name = "plugin-helper-dir", .key = 133,
421
.doc = "Specify a different plugin helper directory",
424
* These reproduce what we would get without ARGP_NO_HELP
426
{ .name = "help", .key = '?',
427
.doc = "Give this help list", .group = -1 },
428
{ .name = "usage", .key = -3,
429
.doc = "Give a short usage message", .group = -1 },
430
{ .name = "version", .key = 'V',
431
.doc = "Print program version", .group = -1 },
376
error_t parse_opt (int key, char *arg, __attribute__((unused))
377
struct argp_state *state) {
435
__attribute__((nonnull(3)))
436
error_t parse_opt(int key, char *arg, struct argp_state *state){
379
441
case 'g': /* --global-options */
382
while((p = strsep(&arg, ",")) != NULL){
386
if(not add_argument(getplugin(NULL), p)){
387
perror("add_argument");
388
return ARGP_ERR_UNKNOWN;
444
while((plugin_option = strsep(&arg, ",")) != NULL){
445
if(not add_argument(getplugin(NULL), plugin_option)){
393
452
case 'G': /* --global-env */
398
char *envdef = strdup(arg);
402
if(not add_environment(getplugin(NULL), envdef, true)){
403
perror("add_environment");
453
if(add_environment(getplugin(NULL), arg, true)){
407
457
case 'o': /* --options-for */
409
char *p_name = strsep(&arg, ":");
410
if(p_name[0] == '\0' or arg == NULL){
413
char *opt = strsep(&arg, ":");
414
if(opt[0] == '\0' or opt == NULL){
418
while((p = strsep(&opt, ",")) != NULL){
422
if(not add_argument(getplugin(p_name), p)){
423
perror("add_argument");
424
return ARGP_ERR_UNKNOWN;
459
char *option_list = strchr(arg, ':');
460
if(option_list == NULL){
461
argp_error(state, "No colon in \"%s\"", arg);
468
argp_error(state, "Empty plugin name");
473
while((option = strsep(&option_list, ",")) != NULL){
474
if(not add_argument(getplugin(arg), option)){
429
481
case 'E': /* --env-for */
434
483
char *envdef = strchr(arg, ':');
435
484
if(envdef == NULL){
438
char *p_name = strndup(arg, (size_t) (envdef-arg));
485
argp_error(state, "No colon in \"%s\"", arg);
443
if(not add_environment(getplugin(p_name), envdef, true)){
444
perror("add_environment");
492
argp_error(state, "Empty plugin name");
496
if(add_environment(getplugin(arg), envdef, true)){
448
501
case 'd': /* --disable */
450
503
plugin *p = getplugin(arg);
452
return ARGP_ERR_UNKNOWN;
457
510
case 'e': /* --enable */
459
512
plugin *p = getplugin(arg);
461
return ARGP_ERR_UNKNOWN;
466
519
case 128: /* --plugin-dir */
467
521
plugindir = strdup(arg);
468
if(plugindir == NULL){
522
if(plugindir != NULL){
472
526
case 129: /* --config-file */
473
527
/* This is already done by parse_opt_config_file() */
475
529
case 130: /* --userid */
476
uid = (uid_t)strtol(arg, NULL, 10);
530
tmp_id = strtoimax(arg, &tmp, 10);
531
if(errno != 0 or tmp == arg or *tmp != '\0'
532
or tmp_id != (uid_t)tmp_id){
533
argp_error(state, "Bad user ID number: \"%s\", using %"
534
PRIdMAX, arg, (intmax_t)uid);
478
540
case 131: /* --groupid */
479
gid = (gid_t)strtol(arg, NULL, 10);
541
tmp_id = strtoimax(arg, &tmp, 10);
542
if(errno != 0 or tmp == arg or *tmp != '\0'
543
or tmp_id != (gid_t)tmp_id){
544
argp_error(state, "Bad group ID number: \"%s\", using %"
545
PRIdMAX, arg, (intmax_t)gid);
481
551
case 132: /* --debug */
554
case 133: /* --plugin-helper-dir */
555
free(pluginhelperdir);
556
pluginhelperdir = strdup(arg);
557
if(pluginhelperdir != NULL){
562
* These reproduce what we would get without ARGP_NO_HELP
564
case '?': /* --help */
565
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
566
argp_state_help(state, state->out_stream, ARGP_HELP_STD_HELP);
567
case -3: /* --usage */
568
state->flags &= ~(unsigned int)ARGP_NO_EXIT; /* force exit */
569
argp_state_help(state, state->out_stream,
570
ARGP_HELP_USAGE | ARGP_HELP_EXIT_OK);
571
case 'V': /* --version */
572
fprintf(state->out_stream, "%s\n", argp_program_version);
576
* When adding more options before this line, remember to also add a
577
* "case" to the "parse_opt_config_file" function below.
484
579
case ARGP_KEY_ARG:
485
fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
580
/* Cryptsetup always passes an argument, which is an empty
581
string if "none" was specified in /etc/crypttab. So if
582
argument was empty, we ignore it silently. */
490
587
return ARGP_ERR_UNKNOWN;
589
return errno; /* Set to 0 at start */
495
592
/* This option parser is the same as parse_opt() above, except it
496
593
ignores everything but the --config-file option. */
497
error_t parse_opt_config_file (int key, char *arg,
498
__attribute__((unused))
499
struct argp_state *state) {
594
error_t parse_opt_config_file(int key, char *arg,
595
__attribute__((unused))
596
struct argp_state *state){
501
599
case 'g': /* --global-options */
502
600
case 'G': /* --global-env */
503
601
case 'o': /* --options-for */
582
693
new_arg = strdup(p);
583
694
if(new_arg == NULL){
585
exitstatus = EXIT_FAILURE;
695
error(0, errno, "strdup");
696
exitstatus = EX_OSERR;
590
701
custom_argc += 1;
591
custom_argv = realloc(custom_argv, sizeof(char *)
592
* ((unsigned int) custom_argc + 1));
593
if(custom_argv == NULL){
595
exitstatus = EXIT_FAILURE;
703
char **new_argv = realloc(custom_argv, sizeof(char *)
704
* ((size_t)custom_argc + 1));
705
if(new_argv == NULL){
706
error(0, errno, "realloc");
707
exitstatus = EX_OSERR;
712
custom_argv = new_argv;
599
715
custom_argv[custom_argc-1] = new_arg;
600
custom_argv[custom_argc] = NULL;
716
custom_argv[custom_argc] = NULL;
720
ret = fclose(conffp);
721
} while(ret == EOF and errno == EINTR);
723
error(0, errno, "fclose");
724
exitstatus = EX_IOERR;
605
729
/* Check for harmful errors and go to fallback. Other errors might
606
730
not affect opening plugins */
607
if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
609
exitstatus = EXIT_FAILURE;
731
if(errno == EMFILE or errno == ENFILE or errno == ENOMEM){
732
error(0, errno, "fopen");
733
exitstatus = EX_OSERR;
613
/* If there was any arguments from configuration file,
614
pass them to parser as command arguments */
737
/* If there were any arguments from the configuration file, pass
738
them to parser as command line arguments */
615
739
if(custom_argv != NULL){
616
ret = argp_parse (&argp, custom_argc, custom_argv, ARGP_IN_ORDER,
618
if (ret == ARGP_ERR_UNKNOWN){
619
fprintf(stderr, "Unknown error while parsing arguments\n");
620
exitstatus = EXIT_FAILURE;
740
ret = argp_parse(&argp, custom_argc, custom_argv,
741
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
749
error(0, errno, "argp_parse");
750
exitstatus = EX_OSERR;
753
exitstatus = EX_CONFIG;
625
758
/* Parse actual command line arguments, to let them override the
627
ret = argp_parse (&argp, argc, argv, ARGP_IN_ORDER, 0, NULL);
628
if (ret == ARGP_ERR_UNKNOWN){
629
fprintf(stderr, "Unknown error while parsing arguments\n");
630
exitstatus = EXIT_FAILURE;
760
ret = argp_parse(&argp, argc, argv,
761
ARGP_IN_ORDER | ARGP_NO_EXIT | ARGP_NO_HELP,
769
error(0, errno, "argp_parse");
770
exitstatus = EX_OSERR;
773
exitstatus = EX_USAGE;
778
char *pluginhelperenv;
780
ret = asprintf(&pluginhelperenv, "MANDOSPLUGINHELPERDIR=%s",
781
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
783
bret = add_environment(getplugin(NULL), pluginhelperenv, true);
785
if(ret == -1 or not bret){
786
error(0, errno, "Failed to set MANDOSPLUGINHELPERDIR"
787
" environment variable to \"%s\" for all plugins\n",
788
pluginhelperdir != NULL ? pluginhelperdir : PHDIR);
791
free(pluginhelperenv);
638
799
for(char **a = p->argv; *a != NULL; a++){
639
800
fprintf(stderr, "\tArg: %s\n", *a);
641
fprintf(stderr, "...and %u environment variables\n", p->envc);
802
fprintf(stderr, "...and %d environment variables\n", p->envc);
642
803
for(char **a = p->environ; *a != NULL; a++){
643
804
fprintf(stderr, "\t%s\n", *a);
648
/* Strip permissions down to nobody */
810
/* Work around Debian bug #633582:
811
<http://bugs.debian.org/633582> */
812
int plugindir_fd = open(/* plugindir or */ PDIR, O_RDONLY);
813
if(plugindir_fd == -1){
815
error(0, errno, "open(\"" PDIR "\")");
818
ret = (int)TEMP_FAILURE_RETRY(fstat(plugindir_fd, &st));
820
error(0, errno, "fstat");
822
if(S_ISDIR(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){
823
ret = fchown(plugindir_fd, uid, gid);
825
error(0, errno, "fchown");
833
/* Lower permissions */
836
error(0, errno, "setgid");
649
838
ret = setuid(uid);
658
if (plugindir == NULL){
661
dir = opendir(plugindir);
665
perror("Could not open plugin dir");
666
exitstatus = EXIT_FAILURE;
670
/* Set the FD_CLOEXEC flag on the directory, if possible */
840
error(0, errno, "setuid");
843
/* Open plugin directory with close_on_exec flag */
672
int dir_fd = dirfd(dir);
674
ret = set_cloexec_flag(dir_fd);
676
perror("set_cloexec_flag");
677
exitstatus = EXIT_FAILURE;
845
dir_fd = open(plugindir != NULL ? plugindir : PDIR, O_RDONLY |
848
#else /* not O_CLOEXEC */
850
#endif /* not O_CLOEXEC */
853
error(0, errno, "Could not open plugin dir");
854
exitstatus = EX_UNAVAILABLE;
859
/* Set the FD_CLOEXEC flag on the directory */
860
ret = set_cloexec_flag(dir_fd);
862
error(0, errno, "set_cloexec_flag");
863
exitstatus = EX_OSERR;
866
#endif /* O_CLOEXEC */
869
int good_name(const struct dirent * const dirent){
870
const char * const patterns[] = { ".*", "#*#", "*~", "*.dpkg-new",
871
"*.dpkg-old", "*.dpkg-bak",
872
"*.dpkg-divert", NULL };
874
#pragma GCC diagnostic push
875
#pragma GCC diagnostic ignored "-Wcast-qual"
877
for(const char **pat = (const char **)patterns;
878
*pat != NULL; pat++){
880
#pragma GCC diagnostic pop
882
if(fnmatch(*pat, dirent->d_name, FNM_FILE_NAME | FNM_PERIOD)
885
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
886
" matching pattern %s\n", dirent->d_name, *pat);
894
int numplugins = scandirat(dir_fd, ".", &direntries, good_name,
896
if(numplugins == -1){
897
error(0, errno, "Could not scan plugin dir");
899
exitstatus = EX_OSERR;
683
903
FD_ZERO(&rfds_all);
685
905
/* Read and execute any executable in the plugin directory*/
687
dirst = readdir(dir);
689
/* All directory entries have been processed */
693
exitstatus = EXIT_FAILURE;
699
d_name_len = strlen(dirst->d_name);
701
/* Ignore dotfiles, backup files and other junk */
703
bool bad_name = false;
705
const char const *bad_prefixes[] = { ".", "#", NULL };
707
const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
709
".dpkg-divert", NULL };
710
for(const char **pre = bad_prefixes; *pre != NULL; pre++){
711
size_t pre_len = strlen(*pre);
712
if((d_name_len >= pre_len)
713
and strncmp((dirst->d_name), *pre, pre_len) == 0){
715
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
716
" with bad prefix %s\n", dirst->d_name, *pre);
725
for(const char **suf = bad_suffixes; *suf != NULL; suf++){
726
size_t suf_len = strlen(*suf);
727
if((d_name_len >= suf_len)
728
and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
731
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
732
" with bad suffix %s\n", dirst->d_name, *suf);
745
if(plugindir == NULL){
746
ret = asprintf(&filename, PDIR "/%s", dirst->d_name);
748
ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
755
ret = stat(filename, &st);
906
for(int i = 0; i < numplugins; i++){
908
int plugin_fd = openat(dir_fd, direntries[i]->d_name, O_RDONLY);
910
error(0, errno, "Could not open plugin");
914
ret = (int)TEMP_FAILURE_RETRY(fstat(plugin_fd, &st));
916
error(0, errno, "stat");
762
922
/* Ignore non-executable files */
763
if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
923
if(not S_ISREG(st.st_mode)
924
or (TEMP_FAILURE_RETRY(faccessat(dir_fd, direntries[i]->d_name,
765
fprintf(stderr, "Ignoring plugin dir entry \"%s\""
766
" with bad type or mode\n", filename);
927
fprintf(stderr, "Ignoring plugin dir entry \"%s/%s\""
928
" with bad type or mode\n",
929
plugindir != NULL ? plugindir : PDIR,
930
direntries[i]->d_name);
772
plugin *p = getplugin(dirst->d_name);
937
plugin *p = getplugin(direntries[i]->d_name);
939
error(0, errno, "getplugin");
780
946
fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
947
direntries[i]->d_name);
790
957
for(char **a = g->argv + 1; *a != NULL; a++){
791
958
if(not add_argument(p, *a)){
792
perror("add_argument");
959
error(0, errno, "add_argument");
795
962
/* Add global environment variables */
796
963
for(char **e = g->environ; *e != NULL; e++){
797
964
if(not add_environment(p, *e, false)){
798
perror("add_environment");
965
error(0, errno, "add_environment");
803
/* If this plugin has any environment variables, we will call
804
using execve and need to duplicate the environment from this
970
/* If this plugin has any environment variables, we need to
971
duplicate the environment from this process, too. */
806
972
if(p->environ[0] != NULL){
807
973
for(char **e = environ; *e != NULL; e++){
808
974
if(not add_environment(p, *e, false)){
809
perror("add_environment");
975
error(0, errno, "add_environment");
818
exitstatus = EXIT_FAILURE;
982
ret = (int)TEMP_FAILURE_RETRY(pipe(pipefd));
983
#else /* O_CLOEXEC */
984
ret = (int)TEMP_FAILURE_RETRY(pipe2(pipefd, O_CLOEXEC));
985
#endif /* O_CLOEXEC */
987
error(0, errno, "pipe");
988
exitstatus = EX_OSERR;
992
if(pipefd[0] >= FD_SETSIZE){
993
fprintf(stderr, "pipe()[0] (%d) >= FD_SETSIZE (%d)", pipefd[0],
997
exitstatus = EX_OSERR;
821
1002
/* Ask OS to automatic close the pipe on exec */
822
1003
ret = set_cloexec_flag(pipefd[0]);
824
perror("set_cloexec_flag");
825
exitstatus = EXIT_FAILURE;
1005
error(0, errno, "set_cloexec_flag");
1008
exitstatus = EX_OSERR;
1009
free(direntries[i]);
828
1012
ret = set_cloexec_flag(pipefd[1]);
830
perror("set_cloexec_flag");
831
exitstatus = EXIT_FAILURE;
1014
error(0, errno, "set_cloexec_flag");
1017
exitstatus = EX_OSERR;
1018
free(direntries[i]);
1021
#endif /* not O_CLOEXEC */
834
1022
/* Block SIGCHLD until process is safely in process list */
835
ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1023
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_BLOCK,
1024
&sigchld_action.sa_mask,
837
perror("sigprocmask");
838
exitstatus = EXIT_FAILURE;
1027
error(0, errno, "sigprocmask");
1028
exitstatus = EX_OSERR;
1029
free(direntries[i]);
841
1032
/* Starting a new process to be watched */
1036
} while(pid == -1 and errno == EINTR);
845
exitstatus = EXIT_FAILURE;
1038
error(0, errno, "fork");
1039
TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1040
&sigchld_action.sa_mask, NULL));
1043
exitstatus = EX_OSERR;
1044
free(direntries[i]);
849
1048
/* this is the child process */
850
1049
ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
1051
error(0, errno, "sigaction");
855
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1054
ret = sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
857
perror("sigprocmask");
1056
error(0, errno, "sigprocmask");
861
1060
ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
1062
error(0, errno, "dup2");
868
/* If dir has no file descriptor, we could not set FD_CLOEXEC
869
above and must now close it manually here. */
872
if(p->environ[0] == NULL){
873
if(execv(filename, p->argv) < 0){
878
if(execve(filename, p->argv, p->environ) < 0){
1066
if(fexecve(plugin_fd, p->argv,
1067
(p->environ[0] != NULL) ? p->environ : environ) < 0){
1068
error(0, errno, "fexecve for %s/%s",
1069
plugindir != NULL ? plugindir : PDIR,
1070
direntries[i]->d_name);
885
1075
/* Parent process */
886
1076
close(pipefd[1]); /* Close unused write end of pipe */
888
plugin *new_plugin = getplugin(dirst->d_name);
889
if (new_plugin == NULL){
891
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1078
plugin *new_plugin = getplugin(direntries[i]->d_name);
1079
if(new_plugin == NULL){
1080
error(0, errno, "getplugin");
1081
ret = (int)(TEMP_FAILURE_RETRY
1082
(sigprocmask(SIG_UNBLOCK, &sigchld_action.sa_mask,
893
perror("sigprocmask");
1085
error(0, errno, "sigprocmask");
895
exitstatus = EXIT_FAILURE;
1087
exitstatus = EX_OSERR;
1088
free(direntries[i]);
1091
free(direntries[i]);
899
1093
new_plugin->pid = pid;
900
1094
new_plugin->fd = pipefd[0];
902
1096
/* Unblock SIGCHLD so signal handler can be run if this process
903
1097
has already completed */
904
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
1098
ret = (int)TEMP_FAILURE_RETRY(sigprocmask(SIG_UNBLOCK,
1099
&sigchld_action.sa_mask,
906
perror("sigprocmask");
907
exitstatus = EXIT_FAILURE;
1102
error(0, errno, "sigprocmask");
1103
exitstatus = EX_OSERR;
911
1107
FD_SET(new_plugin->fd, &rfds_all);
913
if (maxfd < new_plugin->fd){
1109
if(maxfd < new_plugin->fd){
914
1110
maxfd = new_plugin->fd;
1118
free_plugin(getplugin(NULL));
922
1120
for(plugin *p = plugin_list; p != NULL; p = p->next){
923
1121
if(p->pid != 0){
929
1127
free_plugin_list();
933
1131
/* Main loop while running plugins exist */
934
1132
while(plugin_list){
935
1133
fd_set rfds = rfds_all;
936
1134
int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
937
if (select_ret == -1){
939
exitstatus = EXIT_FAILURE;
1135
if(select_ret == -1 and errno != EINTR){
1136
error(0, errno, "select");
1137
exitstatus = EX_OSERR;
942
1140
/* OK, now either a process completed, or something can be read
943
1141
from one of them */
944
for(plugin *proc = plugin_list; proc != NULL; proc = proc->next){
1142
for(plugin *proc = plugin_list; proc != NULL;){
945
1143
/* Is this process completely done? */
946
if(proc->eof and proc->completed){
1144
if(proc->completed and proc->eof){
947
1145
/* Only accept the plugin output if it exited cleanly */
948
1146
if(not WIFEXITED(proc->status)
949
1147
or WEXITSTATUS(proc->status) != 0){
950
1148
/* Bad exit by plugin */
953
1151
if(WIFEXITED(proc->status)){
954
fprintf(stderr, "Plugin %u exited with status %d\n",
955
(unsigned int) (proc->pid),
1152
fprintf(stderr, "Plugin %s [%" PRIdMAX "] exited with"
1153
" status %d\n", proc->name,
1154
(intmax_t) (proc->pid),
956
1155
WEXITSTATUS(proc->status));
957
} else if(WIFSIGNALED(proc->status)) {
958
fprintf(stderr, "Plugin %u killed by signal %d\n",
959
(unsigned int) (proc->pid),
960
WTERMSIG(proc->status));
1156
} else if(WIFSIGNALED(proc->status)){
1157
fprintf(stderr, "Plugin %s [%" PRIdMAX "] killed by"
1158
" signal %d: %s\n", proc->name,
1159
(intmax_t) (proc->pid),
1160
WTERMSIG(proc->status),
1161
strsignal(WTERMSIG(proc->status)));
961
1162
} else if(WCOREDUMP(proc->status)){
962
fprintf(stderr, "Plugin %d dumped core\n",
963
(unsigned int) (proc->pid));
1163
fprintf(stderr, "Plugin %s [%" PRIdMAX "] dumped"
1164
" core\n", proc->name, (intmax_t) (proc->pid));
967
1168
/* Remove the plugin */
968
1169
FD_CLR(proc->fd, &rfds_all);
970
1171
/* Block signal while modifying process_list */
971
ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
1172
ret = (int)TEMP_FAILURE_RETRY(sigprocmask
1174
&sigchld_action.sa_mask,
973
perror("sigprocmask");
974
exitstatus = EXIT_FAILURE;
1177
error(0, errno, "sigprocmask");
1178
exitstatus = EX_OSERR;
1182
plugin *next_plugin = proc->next;
977
1183
free_plugin(proc);
978
1186
/* We are done modifying process list, so unblock signal */
979
ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,
1187
ret = (int)(TEMP_FAILURE_RETRY
1188
(sigprocmask(SIG_UNBLOCK,
1189
&sigchld_action.sa_mask, NULL)));
982
perror("sigprocmask");
983
exitstatus = EXIT_FAILURE;
1191
error(0, errno, "sigprocmask");
1192
exitstatus = EX_OSERR;
987
1196
if(plugin_list == NULL){
993
1203
/* This process exited nicely, so print its buffer */
995
1205
bool bret = print_out_password(proc->buffer,
996
1206
proc->buffer_length);
998
perror("print_out_password");
999
exitstatus = EXIT_FAILURE;
1208
error(0, errno, "print_out_password");
1209
exitstatus = EX_IOERR;
1004
1214
/* This process has not completed. Does it have any output? */
1005
1215
if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
1006
1216
/* This process had nothing to say at this time */
1009
1220
/* Before reading, make the process' data buffer large enough */
1010
1221
if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
1011
proc->buffer = realloc(proc->buffer, proc->buffer_size
1012
+ (size_t) BUFFER_SIZE);
1013
if (proc->buffer == NULL){
1015
exitstatus = EXIT_FAILURE;
1222
char *new_buffer = realloc(proc->buffer, proc->buffer_size
1223
+ (size_t) BUFFER_SIZE);
1224
if(new_buffer == NULL){
1225
error(0, errno, "malloc");
1226
exitstatus = EX_OSERR;
1229
proc->buffer = new_buffer;
1018
1230
proc->buffer_size += BUFFER_SIZE;
1020
1232
/* Read from the process */
1021
ret = read(proc->fd, proc->buffer + proc->buffer_length,
1233
sret = TEMP_FAILURE_RETRY(read(proc->fd,
1235
+ proc->buffer_length,
1024
1238
/* Read error from this process; ignore the error */
1029
1244
proc->eof = true;
1031
proc->buffer_length += (size_t) ret;
1246
proc->buffer_length += (size_t) sret;
1039
if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
1254
if(plugin_list == NULL or (exitstatus != EXIT_SUCCESS
1255
and exitstatus != EX_OK)){
1040
1256
/* Fallback if all plugins failed, none are found or an error