/mandos/release

To get this branch, use:
bzr branch http://bzr.recompile.se/loggerhead/mandos/release

« back to all changes in this revision

Viewing changes to mandos

  • Committer: Teddy Hogeborn
  • Date: 2015-07-06 20:14:45 UTC
  • mto: (237.7.594 trunk)
  • mto: This revision was merged to the branch mainline in revision 325.
  • Revision ID: teddy@recompile.se-20150706201445-kq3o6qozigmiqsp9
plugin-runner.xml (EXAMPLE): Use the /usr/lib/<arch> directory.
                             Also explain used options in order.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
#!/usr/bin/python
 
1
#!/usr/bin/python2.7
2
2
# -*- mode: python; coding: utf-8 -*-
3
3
4
4
# Mandos server - give out binary blobs to connecting clients.
11
11
# "AvahiService" class, and some lines in "main".
12
12
13
13
# Everything else is
14
 
# Copyright © 2008-2014 Teddy Hogeborn
15
 
# Copyright © 2008-2014 Björn Påhlsson
 
14
# Copyright © 2008-2015 Teddy Hogeborn
 
15
# Copyright © 2008-2015 Björn Påhlsson
16
16
17
17
# This program is free software: you can redistribute it and/or modify
18
18
# it under the terms of the GNU General Public License as published by
36
36
 
37
37
from future_builtins import *
38
38
 
39
 
import SocketServer as socketserver
 
39
try:
 
40
    import SocketServer as socketserver
 
41
except ImportError:
 
42
    import socketserver
40
43
import socket
41
44
import argparse
42
45
import datetime
47
50
import gnutls.library.functions
48
51
import gnutls.library.constants
49
52
import gnutls.library.types
50
 
import ConfigParser as configparser
 
53
try:
 
54
    import ConfigParser as configparser
 
55
except ImportError:
 
56
    import configparser
51
57
import sys
52
58
import re
53
59
import os
62
68
import struct
63
69
import fcntl
64
70
import functools
65
 
import cPickle as pickle
 
71
try:
 
72
    import cPickle as pickle
 
73
except ImportError:
 
74
    import pickle
66
75
import multiprocessing
67
76
import types
68
77
import binascii
69
78
import tempfile
70
79
import itertools
71
80
import collections
 
81
import codecs
72
82
 
73
83
import dbus
74
84
import dbus.service
75
 
import gobject
 
85
try:
 
86
    import gobject
 
87
except ImportError:
 
88
    from gi.repository import GObject as gobject
76
89
import avahi
77
90
from dbus.mainloop.glib import DBusGMainLoop
78
91
import ctypes
88
101
    except ImportError:
89
102
        SO_BINDTODEVICE = None
90
103
 
91
 
version = "1.6.5"
 
104
if sys.version_info.major == 2:
 
105
    str = unicode
 
106
 
 
107
version = "1.6.9"
92
108
stored_state_file = "clients.pickle"
93
109
 
94
110
logger = logging.getLogger()
95
111
syslogger = None
96
112
 
97
113
try:
98
 
    if_nametoindex = (ctypes.cdll.LoadLibrary
99
 
                      (ctypes.util.find_library("c"))
100
 
                      .if_nametoindex)
 
114
    if_nametoindex = ctypes.cdll.LoadLibrary(
 
115
        ctypes.util.find_library("c")).if_nametoindex
101
116
except (OSError, AttributeError):
 
117
    
102
118
    def if_nametoindex(interface):
103
119
        "Get an interface index the hard way, i.e. using fcntl()"
104
120
        SIOCGIFINDEX = 0x8933  # From /usr/include/linux/sockios.h
105
121
        with contextlib.closing(socket.socket()) as s:
106
122
            ifreq = fcntl.ioctl(s, SIOCGIFINDEX,
107
 
                                struct.pack(str("16s16x"),
108
 
                                            interface))
109
 
        interface_index = struct.unpack(str("I"),
110
 
                                        ifreq[16:20])[0]
 
123
                                struct.pack(b"16s16x", interface))
 
124
        interface_index = struct.unpack("I", ifreq[16:20])[0]
111
125
        return interface_index
112
126
 
113
127
 
115
129
    """init logger and add loglevel"""
116
130
    
117
131
    global syslogger
118
 
    syslogger = (logging.handlers.SysLogHandler
119
 
                 (facility =
120
 
                  logging.handlers.SysLogHandler.LOG_DAEMON,
121
 
                  address = str("/dev/log")))
 
132
    syslogger = (logging.handlers.SysLogHandler(
 
133
        facility = logging.handlers.SysLogHandler.LOG_DAEMON,
 
134
        address = "/dev/log"))
122
135
    syslogger.setFormatter(logging.Formatter
123
136
                           ('Mandos [%(process)d]: %(levelname)s:'
124
137
                            ' %(message)s'))
141
154
 
142
155
class PGPEngine(object):
143
156
    """A simple class for OpenPGP symmetric encryption & decryption"""
 
157
    
144
158
    def __init__(self):
145
159
        self.tempdir = tempfile.mkdtemp(prefix="mandos-")
146
160
        self.gnupgargs = ['--batch',
185
199
    
186
200
    def encrypt(self, data, password):
187
201
        passphrase = self.password_encode(password)
188
 
        with tempfile.NamedTemporaryFile(dir=self.tempdir
189
 
                                         ) as passfile:
 
202
        with tempfile.NamedTemporaryFile(
 
203
                dir=self.tempdir) as passfile:
190
204
            passfile.write(passphrase)
191
205
            passfile.flush()
192
206
            proc = subprocess.Popen(['gpg', '--symmetric',
203
217
    
204
218
    def decrypt(self, data, password):
205
219
        passphrase = self.password_encode(password)
206
 
        with tempfile.NamedTemporaryFile(dir = self.tempdir
207
 
                                         ) as passfile:
 
220
        with tempfile.NamedTemporaryFile(
 
221
                dir = self.tempdir) as passfile:
208
222
            passfile.write(passphrase)
209
223
            passfile.flush()
210
224
            proc = subprocess.Popen(['gpg', '--decrypt',
214
228
                                    stdin = subprocess.PIPE,
215
229
                                    stdout = subprocess.PIPE,
216
230
                                    stderr = subprocess.PIPE)
217
 
            decrypted_plaintext, err = proc.communicate(input
218
 
                                                        = data)
 
231
            decrypted_plaintext, err = proc.communicate(input = data)
219
232
        if proc.returncode != 0:
220
233
            raise PGPError(err)
221
234
        return decrypted_plaintext
224
237
class AvahiError(Exception):
225
238
    def __init__(self, value, *args, **kwargs):
226
239
        self.value = value
227
 
        super(AvahiError, self).__init__(value, *args, **kwargs)
228
 
    def __unicode__(self):
229
 
        return unicode(repr(self.value))
 
240
        return super(AvahiError, self).__init__(value, *args,
 
241
                                                **kwargs)
 
242
 
230
243
 
231
244
class AvahiServiceError(AvahiError):
232
245
    pass
233
246
 
 
247
 
234
248
class AvahiGroupError(AvahiError):
235
249
    pass
236
250
 
256
270
    bus: dbus.SystemBus()
257
271
    """
258
272
    
259
 
    def __init__(self, interface = avahi.IF_UNSPEC, name = None,
260
 
                 servicetype = None, port = None, TXT = None,
261
 
                 domain = "", host = "", max_renames = 32768,
262
 
                 protocol = avahi.PROTO_UNSPEC, bus = None):
 
273
    def __init__(self,
 
274
                 interface = avahi.IF_UNSPEC,
 
275
                 name = None,
 
276
                 servicetype = None,
 
277
                 port = None,
 
278
                 TXT = None,
 
279
                 domain = "",
 
280
                 host = "",
 
281
                 max_renames = 32768,
 
282
                 protocol = avahi.PROTO_UNSPEC,
 
283
                 bus = None):
263
284
        self.interface = interface
264
285
        self.name = name
265
286
        self.type = servicetype
275
296
        self.bus = bus
276
297
        self.entry_group_state_changed_match = None
277
298
    
278
 
    def rename(self):
 
299
    def rename(self, remove=True):
279
300
        """Derived from the Avahi example code"""
280
301
        if self.rename_count >= self.max_renames:
281
302
            logger.critical("No suitable Zeroconf service name found"
282
303
                            " after %i retries, exiting.",
283
304
                            self.rename_count)
284
305
            raise AvahiServiceError("Too many renames")
285
 
        self.name = unicode(self.server
286
 
                            .GetAlternativeServiceName(self.name))
 
306
        self.name = str(
 
307
            self.server.GetAlternativeServiceName(self.name))
 
308
        self.rename_count += 1
287
309
        logger.info("Changing Zeroconf service name to %r ...",
288
310
                    self.name)
289
 
        self.remove()
 
311
        if remove:
 
312
            self.remove()
290
313
        try:
291
314
            self.add()
292
315
        except dbus.exceptions.DBusException as error:
293
 
            logger.critical("D-Bus Exception", exc_info=error)
294
 
            self.cleanup()
295
 
            os._exit(1)
296
 
        self.rename_count += 1
 
316
            if (error.get_dbus_name()
 
317
                == "org.freedesktop.Avahi.CollisionError"):
 
318
                logger.info("Local Zeroconf service name collision.")
 
319
                return self.rename(remove=False)
 
320
            else:
 
321
                logger.critical("D-Bus Exception", exc_info=error)
 
322
                self.cleanup()
 
323
                os._exit(1)
297
324
    
298
325
    def remove(self):
299
326
        """Derived from the Avahi example code"""
337
364
            self.rename()
338
365
        elif state == avahi.ENTRY_GROUP_FAILURE:
339
366
            logger.critical("Avahi: Error in group state changed %s",
340
 
                            unicode(error))
341
 
            raise AvahiGroupError("State changed: {0!s}"
342
 
                                  .format(error))
 
367
                            str(error))
 
368
            raise AvahiGroupError("State changed: {!s}".format(error))
343
369
    
344
370
    def cleanup(self):
345
371
        """Derived from the Avahi example code"""
355
381
    def server_state_changed(self, state, error=None):
356
382
        """Derived from the Avahi example code"""
357
383
        logger.debug("Avahi server state change: %i", state)
358
 
        bad_states = { avahi.SERVER_INVALID:
359
 
                           "Zeroconf server invalid",
360
 
                       avahi.SERVER_REGISTERING: None,
361
 
                       avahi.SERVER_COLLISION:
362
 
                           "Zeroconf server name collision",
363
 
                       avahi.SERVER_FAILURE:
364
 
                           "Zeroconf server failure" }
 
384
        bad_states = {
 
385
            avahi.SERVER_INVALID: "Zeroconf server invalid",
 
386
            avahi.SERVER_REGISTERING: None,
 
387
            avahi.SERVER_COLLISION: "Zeroconf server name collision",
 
388
            avahi.SERVER_FAILURE: "Zeroconf server failure",
 
389
        }
365
390
        if state in bad_states:
366
391
            if bad_states[state] is not None:
367
392
                if error is None:
386
411
                                    follow_name_owner_changes=True),
387
412
                avahi.DBUS_INTERFACE_SERVER)
388
413
        self.server.connect_to_signal("StateChanged",
389
 
                                 self.server_state_changed)
 
414
                                      self.server_state_changed)
390
415
        self.server_state_changed(self.server.GetState())
391
416
 
392
417
 
393
418
class AvahiServiceToSyslog(AvahiService):
394
 
    def rename(self):
 
419
    def rename(self, *args, **kwargs):
395
420
        """Add the new name to the syslog messages"""
396
 
        ret = AvahiService.rename(self)
397
 
        syslogger.setFormatter(logging.Formatter
398
 
                               ('Mandos ({0}) [%(process)d]:'
399
 
                                ' %(levelname)s: %(message)s'
400
 
                                .format(self.name)))
 
421
        ret = AvahiService.rename(self, *args, **kwargs)
 
422
        syslogger.setFormatter(logging.Formatter(
 
423
            'Mandos ({}) [%(process)d]: %(levelname)s: %(message)s'
 
424
            .format(self.name)))
401
425
        return ret
402
426
 
403
 
 
404
 
def timedelta_to_milliseconds(td):
405
 
    "Convert a datetime.timedelta() to milliseconds"
406
 
    return ((td.days * 24 * 60 * 60 * 1000)
407
 
            + (td.seconds * 1000)
408
 
            + (td.microseconds // 1000))
409
 
 
 
427
def call_pipe(connection,       # : multiprocessing.Connection
 
428
              func, *args, **kwargs):
 
429
    """This function is meant to be called by multiprocessing.Process
 
430
    
 
431
    This function runs func(*args, **kwargs), and writes the resulting
 
432
    return value on the provided multiprocessing.Connection.
 
433
    """
 
434
    connection.send(func(*args, **kwargs))
 
435
    connection.close()
410
436
 
411
437
class Client(object):
412
438
    """A representation of a client host served by this server.
439
465
    last_checker_status: integer between 0 and 255 reflecting exit
440
466
                         status of last checker. -1 reflects crashed
441
467
                         checker, -2 means no checker completed yet.
 
468
    last_checker_signal: The signal which killed the last checker, if
 
469
                         last_checker_status is -1
442
470
    last_enabled: datetime.datetime(); (UTC) or None
443
471
    name:       string; from the config file, used in log messages and
444
472
                        D-Bus identifiers
457
485
                          "fingerprint", "host", "interval",
458
486
                          "last_approval_request", "last_checked_ok",
459
487
                          "last_enabled", "name", "timeout")
460
 
    client_defaults = { "timeout": "PT5M",
461
 
                        "extended_timeout": "PT15M",
462
 
                        "interval": "PT2M",
463
 
                        "checker": "fping -q -- %%(host)s",
464
 
                        "host": "",
465
 
                        "approval_delay": "PT0S",
466
 
                        "approval_duration": "PT1S",
467
 
                        "approved_by_default": "True",
468
 
                        "enabled": "True",
469
 
                        }
470
 
    
471
 
    def timeout_milliseconds(self):
472
 
        "Return the 'timeout' attribute in milliseconds"
473
 
        return timedelta_to_milliseconds(self.timeout)
474
 
    
475
 
    def extended_timeout_milliseconds(self):
476
 
        "Return the 'extended_timeout' attribute in milliseconds"
477
 
        return timedelta_to_milliseconds(self.extended_timeout)
478
 
    
479
 
    def interval_milliseconds(self):
480
 
        "Return the 'interval' attribute in milliseconds"
481
 
        return timedelta_to_milliseconds(self.interval)
482
 
    
483
 
    def approval_delay_milliseconds(self):
484
 
        return timedelta_to_milliseconds(self.approval_delay)
 
488
    client_defaults = {
 
489
        "timeout": "PT5M",
 
490
        "extended_timeout": "PT15M",
 
491
        "interval": "PT2M",
 
492
        "checker": "fping -q -- %%(host)s",
 
493
        "host": "",
 
494
        "approval_delay": "PT0S",
 
495
        "approval_duration": "PT1S",
 
496
        "approved_by_default": "True",
 
497
        "enabled": "True",
 
498
    }
485
499
    
486
500
    @staticmethod
487
501
    def config_parser(config):
503
517
            client["enabled"] = config.getboolean(client_name,
504
518
                                                  "enabled")
505
519
            
 
520
            # Uppercase and remove spaces from fingerprint for later
 
521
            # comparison purposes with return value from the
 
522
            # fingerprint() function
506
523
            client["fingerprint"] = (section["fingerprint"].upper()
507
524
                                     .replace(" ", ""))
508
525
            if "secret" in section:
513
530
                          "rb") as secfile:
514
531
                    client["secret"] = secfile.read()
515
532
            else:
516
 
                raise TypeError("No secret or secfile for section {0}"
 
533
                raise TypeError("No secret or secfile for section {}"
517
534
                                .format(section))
518
535
            client["timeout"] = string_to_delta(section["timeout"])
519
536
            client["extended_timeout"] = string_to_delta(
536
553
            server_settings = {}
537
554
        self.server_settings = server_settings
538
555
        # adding all client settings
539
 
        for setting, value in settings.iteritems():
 
556
        for setting, value in settings.items():
540
557
            setattr(self, setting, value)
541
558
        
542
559
        if self.enabled:
550
567
            self.expires = None
551
568
        
552
569
        logger.debug("Creating client %r", self.name)
553
 
        # Uppercase and remove spaces from fingerprint for later
554
 
        # comparison purposes with return value from the fingerprint()
555
 
        # function
556
570
        logger.debug("  Fingerprint: %s", self.fingerprint)
557
571
        self.created = settings.get("created",
558
572
                                    datetime.datetime.utcnow())
565
579
        self.current_checker_command = None
566
580
        self.approved = None
567
581
        self.approvals_pending = 0
568
 
        self.changedstate = (multiprocessing_manager
569
 
                             .Condition(multiprocessing_manager
570
 
                                        .Lock()))
571
 
        self.client_structure = [attr for attr in
572
 
                                 self.__dict__.iterkeys()
 
582
        self.changedstate = multiprocessing_manager.Condition(
 
583
            multiprocessing_manager.Lock())
 
584
        self.client_structure = [attr
 
585
                                 for attr in self.__dict__.iterkeys()
573
586
                                 if not attr.startswith("_")]
574
587
        self.client_structure.append("client_structure")
575
588
        
576
 
        for name, t in inspect.getmembers(type(self),
577
 
                                          lambda obj:
578
 
                                              isinstance(obj,
579
 
                                                         property)):
 
589
        for name, t in inspect.getmembers(
 
590
                type(self), lambda obj: isinstance(obj, property)):
580
591
            if not name.startswith("_"):
581
592
                self.client_structure.append(name)
582
593
    
624
635
        # and every interval from then on.
625
636
        if self.checker_initiator_tag is not None:
626
637
            gobject.source_remove(self.checker_initiator_tag)
627
 
        self.checker_initiator_tag = (gobject.timeout_add
628
 
                                      (self.interval_milliseconds(),
629
 
                                       self.start_checker))
 
638
        self.checker_initiator_tag = gobject.timeout_add(
 
639
            int(self.interval.total_seconds() * 1000),
 
640
            self.start_checker)
630
641
        # Schedule a disable() when 'timeout' has passed
631
642
        if self.disable_initiator_tag is not None:
632
643
            gobject.source_remove(self.disable_initiator_tag)
633
 
        self.disable_initiator_tag = (gobject.timeout_add
634
 
                                   (self.timeout_milliseconds(),
635
 
                                    self.disable))
 
644
        self.disable_initiator_tag = gobject.timeout_add(
 
645
            int(self.timeout.total_seconds() * 1000), self.disable)
636
646
        # Also start a new checker *right now*.
637
647
        self.start_checker()
638
648
    
639
 
    def checker_callback(self, pid, condition, command):
 
649
    def checker_callback(self, source, condition, connection,
 
650
                         command):
640
651
        """The checker has completed, so take appropriate actions."""
641
652
        self.checker_callback_tag = None
642
653
        self.checker = None
643
 
        if os.WIFEXITED(condition):
644
 
            self.last_checker_status = os.WEXITSTATUS(condition)
 
654
        # Read return code from connection (see call_pipe)
 
655
        returncode = connection.recv()
 
656
        connection.close()
 
657
        
 
658
        if returncode >= 0:
 
659
            self.last_checker_status = returncode
 
660
            self.last_checker_signal = None
645
661
            if self.last_checker_status == 0:
646
662
                logger.info("Checker for %(name)s succeeded",
647
663
                            vars(self))
648
664
                self.checked_ok()
649
665
            else:
650
 
                logger.info("Checker for %(name)s failed",
651
 
                            vars(self))
 
666
                logger.info("Checker for %(name)s failed", vars(self))
652
667
        else:
653
668
            self.last_checker_status = -1
 
669
            self.last_checker_signal = -returncode
654
670
            logger.warning("Checker for %(name)s crashed?",
655
671
                           vars(self))
 
672
        return False
656
673
    
657
674
    def checked_ok(self):
658
675
        """Assert that the client has been seen, alive and well."""
659
676
        self.last_checked_ok = datetime.datetime.utcnow()
660
677
        self.last_checker_status = 0
 
678
        self.last_checker_signal = None
661
679
        self.bump_timeout()
662
680
    
663
681
    def bump_timeout(self, timeout=None):
668
686
            gobject.source_remove(self.disable_initiator_tag)
669
687
            self.disable_initiator_tag = None
670
688
        if getattr(self, "enabled", False):
671
 
            self.disable_initiator_tag = (gobject.timeout_add
672
 
                                          (timedelta_to_milliseconds
673
 
                                           (timeout), self.disable))
 
689
            self.disable_initiator_tag = gobject.timeout_add(
 
690
                int(timeout.total_seconds() * 1000), self.disable)
674
691
            self.expires = datetime.datetime.utcnow() + timeout
675
692
    
676
693
    def need_approval(self):
690
707
        # than 'timeout' for the client to be disabled, which is as it
691
708
        # should be.
692
709
        
693
 
        # If a checker exists, make sure it is not a zombie
694
 
        try:
695
 
            pid, status = os.waitpid(self.checker.pid, os.WNOHANG)
696
 
        except AttributeError:
697
 
            pass
698
 
        except OSError as error:
699
 
            if error.errno != errno.ECHILD:
700
 
                raise
701
 
        else:
702
 
            if pid:
703
 
                logger.warning("Checker was a zombie")
704
 
                gobject.source_remove(self.checker_callback_tag)
705
 
                self.checker_callback(pid, status,
706
 
                                      self.current_checker_command)
 
710
        if self.checker is not None and not self.checker.is_alive():
 
711
            logger.warning("Checker was not alive; joining")
 
712
            self.checker.join()
 
713
            self.checker = None
707
714
        # Start a new checker if needed
708
715
        if self.checker is None:
709
716
            # Escape attributes for the shell
710
 
            escaped_attrs = dict(
711
 
                (attr, re.escape(unicode(getattr(self, attr))))
712
 
                for attr in
713
 
                self.runtime_expansions)
 
717
            escaped_attrs = {
 
718
                attr: re.escape(str(getattr(self, attr)))
 
719
                for attr in self.runtime_expansions }
714
720
            try:
715
721
                command = self.checker_command % escaped_attrs
716
722
            except TypeError as error:
717
723
                logger.error('Could not format string "%s"',
718
 
                             self.checker_command, exc_info=error)
719
 
                return True # Try again later
 
724
                             self.checker_command,
 
725
                             exc_info=error)
 
726
                return True     # Try again later
720
727
            self.current_checker_command = command
721
 
            try:
722
 
                logger.info("Starting checker %r for %s",
723
 
                            command, self.name)
724
 
                # We don't need to redirect stdout and stderr, since
725
 
                # in normal mode, that is already done by daemon(),
726
 
                # and in debug mode we don't want to.  (Stdin is
727
 
                # always replaced by /dev/null.)
728
 
                # The exception is when not debugging but nevertheless
729
 
                # running in the foreground; use the previously
730
 
                # created wnull.
731
 
                popen_args = {}
732
 
                if (not self.server_settings["debug"]
733
 
                    and self.server_settings["foreground"]):
734
 
                    popen_args.update({"stdout": wnull,
735
 
                                       "stderr": wnull })
736
 
                self.checker = subprocess.Popen(command,
737
 
                                                close_fds=True,
738
 
                                                shell=True, cwd="/",
739
 
                                                **popen_args)
740
 
            except OSError as error:
741
 
                logger.error("Failed to start subprocess",
742
 
                             exc_info=error)
743
 
                return True
744
 
            self.checker_callback_tag = (gobject.child_watch_add
745
 
                                         (self.checker.pid,
746
 
                                          self.checker_callback,
747
 
                                          data=command))
748
 
            # The checker may have completed before the gobject
749
 
            # watch was added.  Check for this.
750
 
            try:
751
 
                pid, status = os.waitpid(self.checker.pid, os.WNOHANG)
752
 
            except OSError as error:
753
 
                if error.errno == errno.ECHILD:
754
 
                    # This should never happen
755
 
                    logger.error("Child process vanished",
756
 
                                 exc_info=error)
757
 
                    return True
758
 
                raise
759
 
            if pid:
760
 
                gobject.source_remove(self.checker_callback_tag)
761
 
                self.checker_callback(pid, status, command)
 
728
            logger.info("Starting checker %r for %s", command,
 
729
                        self.name)
 
730
            # We don't need to redirect stdout and stderr, since
 
731
            # in normal mode, that is already done by daemon(),
 
732
            # and in debug mode we don't want to.  (Stdin is
 
733
            # always replaced by /dev/null.)
 
734
            # The exception is when not debugging but nevertheless
 
735
            # running in the foreground; use the previously
 
736
            # created wnull.
 
737
            popen_args = { "close_fds": True,
 
738
                           "shell": True,
 
739
                           "cwd": "/" }
 
740
            if (not self.server_settings["debug"]
 
741
                and self.server_settings["foreground"]):
 
742
                popen_args.update({"stdout": wnull,
 
743
                                   "stderr": wnull })
 
744
            pipe = multiprocessing.Pipe(duplex = False)
 
745
            self.checker = multiprocessing.Process(
 
746
                target = call_pipe,
 
747
                args = (pipe[1], subprocess.call, command),
 
748
                kwargs = popen_args)
 
749
            self.checker.start()
 
750
            self.checker_callback_tag = gobject.io_add_watch(
 
751
                pipe[0].fileno(), gobject.IO_IN,
 
752
                self.checker_callback, pipe[0], command)
762
753
        # Re-run this periodically if run by gobject.timeout_add
763
754
        return True
764
755
    
770
761
        if getattr(self, "checker", None) is None:
771
762
            return
772
763
        logger.debug("Stopping checker for %(name)s", vars(self))
773
 
        try:
774
 
            self.checker.terminate()
775
 
            #time.sleep(0.5)
776
 
            #if self.checker.poll() is None:
777
 
            #    self.checker.kill()
778
 
        except OSError as error:
779
 
            if error.errno != errno.ESRCH: # No such process
780
 
                raise
 
764
        self.checker.terminate()
781
765
        self.checker = None
782
766
 
783
767
 
784
 
def dbus_service_property(dbus_interface, signature="v",
785
 
                          access="readwrite", byte_arrays=False):
 
768
def dbus_service_property(dbus_interface,
 
769
                          signature="v",
 
770
                          access="readwrite",
 
771
                          byte_arrays=False):
786
772
    """Decorators for marking methods of a DBusObjectWithProperties to
787
773
    become properties on the D-Bus.
788
774
    
797
783
    # "Set" method, so we fail early here:
798
784
    if byte_arrays and signature != "ay":
799
785
        raise ValueError("Byte arrays not supported for non-'ay'"
800
 
                         " signature {0!r}".format(signature))
 
786
                         " signature {!r}".format(signature))
 
787
    
801
788
    def decorator(func):
802
789
        func._dbus_is_property = True
803
790
        func._dbus_interface = dbus_interface
808
795
            func._dbus_name = func._dbus_name[:-14]
809
796
        func._dbus_get_args_options = {'byte_arrays': byte_arrays }
810
797
        return func
 
798
    
811
799
    return decorator
812
800
 
813
801
 
822
810
                "org.freedesktop.DBus.Property.EmitsChangedSignal":
823
811
                    "false"}
824
812
    """
 
813
    
825
814
    def decorator(func):
826
815
        func._dbus_is_interface = True
827
816
        func._dbus_interface = dbus_interface
828
817
        func._dbus_name = dbus_interface
829
818
        return func
 
819
    
830
820
    return decorator
831
821
 
832
822
 
834
824
    """Decorator to annotate D-Bus methods, signals or properties
835
825
    Usage:
836
826
    
 
827
    @dbus_annotations({"org.freedesktop.DBus.Deprecated": "true",
 
828
                       "org.freedesktop.DBus.Property."
 
829
                       "EmitsChangedSignal": "false"})
837
830
    @dbus_service_property("org.example.Interface", signature="b",
838
831
                           access="r")
839
 
    @dbus_annotations({{"org.freedesktop.DBus.Deprecated": "true",
840
 
                        "org.freedesktop.DBus.Property."
841
 
                        "EmitsChangedSignal": "false"})
842
832
    def Property_dbus_property(self):
843
833
        return dbus.Boolean(False)
844
834
    """
 
835
    
845
836
    def decorator(func):
846
837
        func._dbus_annotations = annotations
847
838
        return func
 
839
    
848
840
    return decorator
849
841
 
850
842
 
851
843
class DBusPropertyException(dbus.exceptions.DBusException):
852
844
    """A base class for D-Bus property-related exceptions
853
845
    """
854
 
    def __unicode__(self):
855
 
        return unicode(str(self))
 
846
    pass
856
847
 
857
848
 
858
849
class DBusPropertyAccessException(DBusPropertyException):
882
873
        If called like _is_dbus_thing("method") it returns a function
883
874
        suitable for use as predicate to inspect.getmembers().
884
875
        """
885
 
        return lambda obj: getattr(obj, "_dbus_is_{0}".format(thing),
 
876
        return lambda obj: getattr(obj, "_dbus_is_{}".format(thing),
886
877
                                   False)
887
878
    
888
879
    def _get_all_dbus_things(self, thing):
889
880
        """Returns a generator of (name, attribute) pairs
890
881
        """
891
 
        return ((getattr(athing.__get__(self), "_dbus_name",
892
 
                         name),
 
882
        return ((getattr(athing.__get__(self), "_dbus_name", name),
893
883
                 athing.__get__(self))
894
884
                for cls in self.__class__.__mro__
895
885
                for name, athing in
896
 
                inspect.getmembers(cls,
897
 
                                   self._is_dbus_thing(thing)))
 
886
                inspect.getmembers(cls, self._is_dbus_thing(thing)))
898
887
    
899
888
    def _get_dbus_property(self, interface_name, property_name):
900
889
        """Returns a bound method if one exists which is a D-Bus
901
890
        property with the specified name and interface.
902
891
        """
903
 
        for cls in  self.__class__.__mro__:
904
 
            for name, value in (inspect.getmembers
905
 
                                (cls,
906
 
                                 self._is_dbus_thing("property"))):
 
892
        for cls in self.__class__.__mro__:
 
893
            for name, value in inspect.getmembers(
 
894
                    cls, self._is_dbus_thing("property")):
907
895
                if (value._dbus_name == property_name
908
896
                    and value._dbus_interface == interface_name):
909
897
                    return value.__get__(self)
910
898
        
911
899
        # No such property
912
 
        raise DBusPropertyNotFound(self.dbus_object_path + ":"
913
 
                                   + interface_name + "."
914
 
                                   + property_name)
 
900
        raise DBusPropertyNotFound("{}:{}.{}".format(
 
901
            self.dbus_object_path, interface_name, property_name))
915
902
    
916
 
    @dbus.service.method(dbus.PROPERTIES_IFACE, in_signature="ss",
 
903
    @dbus.service.method(dbus.PROPERTIES_IFACE,
 
904
                         in_signature="ss",
917
905
                         out_signature="v")
918
906
    def Get(self, interface_name, property_name):
919
907
        """Standard D-Bus property Get() method, see D-Bus standard.
938
926
            # signatures other than "ay".
939
927
            if prop._dbus_signature != "ay":
940
928
                raise ValueError("Byte arrays not supported for non-"
941
 
                                 "'ay' signature {0!r}"
 
929
                                 "'ay' signature {!r}"
942
930
                                 .format(prop._dbus_signature))
943
931
            value = dbus.ByteArray(b''.join(chr(byte)
944
932
                                            for byte in value))
945
933
        prop(value)
946
934
    
947
 
    @dbus.service.method(dbus.PROPERTIES_IFACE, in_signature="s",
 
935
    @dbus.service.method(dbus.PROPERTIES_IFACE,
 
936
                         in_signature="s",
948
937
                         out_signature="a{sv}")
949
938
    def GetAll(self, interface_name):
950
939
        """Standard D-Bus property GetAll() method, see D-Bus
965
954
            if not hasattr(value, "variant_level"):
966
955
                properties[name] = value
967
956
                continue
968
 
            properties[name] = type(value)(value, variant_level=
969
 
                                           value.variant_level+1)
 
957
            properties[name] = type(value)(
 
958
                value, variant_level = value.variant_level + 1)
970
959
        return dbus.Dictionary(properties, signature="sv")
971
960
    
 
961
    @dbus.service.signal(dbus.PROPERTIES_IFACE, signature="sa{sv}as")
 
962
    def PropertiesChanged(self, interface_name, changed_properties,
 
963
                          invalidated_properties):
 
964
        """Standard D-Bus PropertiesChanged() signal, see D-Bus
 
965
        standard.
 
966
        """
 
967
        pass
 
968
    
972
969
    @dbus.service.method(dbus.INTROSPECTABLE_IFACE,
973
970
                         out_signature="s",
974
971
                         path_keyword='object_path',
982
979
                                                   connection)
983
980
        try:
984
981
            document = xml.dom.minidom.parseString(xmlstring)
 
982
            
985
983
            def make_tag(document, name, prop):
986
984
                e = document.createElement("property")
987
985
                e.setAttribute("name", name)
988
986
                e.setAttribute("type", prop._dbus_signature)
989
987
                e.setAttribute("access", prop._dbus_access)
990
988
                return e
 
989
            
991
990
            for if_tag in document.getElementsByTagName("interface"):
992
991
                # Add property tags
993
992
                for tag in (make_tag(document, name, prop)
1005
1004
                            if (name == tag.getAttribute("name")
1006
1005
                                and prop._dbus_interface
1007
1006
                                == if_tag.getAttribute("name")):
1008
 
                                annots.update(getattr
1009
 
                                              (prop,
1010
 
                                               "_dbus_annotations",
1011
 
                                               {}))
1012
 
                        for name, value in annots.iteritems():
 
1007
                                annots.update(getattr(
 
1008
                                    prop, "_dbus_annotations", {}))
 
1009
                        for name, value in annots.items():
1013
1010
                            ann_tag = document.createElement(
1014
1011
                                "annotation")
1015
1012
                            ann_tag.setAttribute("name", name)
1018
1015
                # Add interface annotation tags
1019
1016
                for annotation, value in dict(
1020
1017
                    itertools.chain.from_iterable(
1021
 
                        annotations().iteritems()
1022
 
                        for name, annotations in
1023
 
                        self._get_all_dbus_things("interface")
 
1018
                        annotations().items()
 
1019
                        for name, annotations
 
1020
                        in self._get_all_dbus_things("interface")
1024
1021
                        if name == if_tag.getAttribute("name")
1025
 
                        )).iteritems():
 
1022
                        )).items():
1026
1023
                    ann_tag = document.createElement("annotation")
1027
1024
                    ann_tag.setAttribute("name", annotation)
1028
1025
                    ann_tag.setAttribute("value", value)
1055
1052
    """Convert a UTC datetime.datetime() to a D-Bus type."""
1056
1053
    if dt is None:
1057
1054
        return dbus.String("", variant_level = variant_level)
1058
 
    return dbus.String(dt.isoformat(),
1059
 
                       variant_level=variant_level)
 
1055
    return dbus.String(dt.isoformat(), variant_level=variant_level)
1060
1056
 
1061
1057
 
1062
1058
def alternate_dbus_interfaces(alt_interface_names, deprecate=True):
1082
1078
    (from DBusObjectWithProperties) and interfaces (from the
1083
1079
    dbus_interface_annotations decorator).
1084
1080
    """
 
1081
    
1085
1082
    def wrapper(cls):
1086
1083
        for orig_interface_name, alt_interface_name in (
1087
 
            alt_interface_names.iteritems()):
 
1084
                alt_interface_names.items()):
1088
1085
            attr = {}
1089
1086
            interface_names = set()
1090
1087
            # Go though all attributes of the class
1092
1089
                # Ignore non-D-Bus attributes, and D-Bus attributes
1093
1090
                # with the wrong interface name
1094
1091
                if (not hasattr(attribute, "_dbus_interface")
1095
 
                    or not attribute._dbus_interface
1096
 
                    .startswith(orig_interface_name)):
 
1092
                    or not attribute._dbus_interface.startswith(
 
1093
                        orig_interface_name)):
1097
1094
                    continue
1098
1095
                # Create an alternate D-Bus interface name based on
1099
1096
                # the current name
1100
 
                alt_interface = (attribute._dbus_interface
1101
 
                                 .replace(orig_interface_name,
1102
 
                                          alt_interface_name))
 
1097
                alt_interface = attribute._dbus_interface.replace(
 
1098
                    orig_interface_name, alt_interface_name)
1103
1099
                interface_names.add(alt_interface)
1104
1100
                # Is this a D-Bus signal?
1105
1101
                if getattr(attribute, "_dbus_is_signal", False):
1106
 
                    # Extract the original non-method undecorated
1107
 
                    # function by black magic
1108
 
                    nonmethod_func = (dict(
 
1102
                    if sys.version_info.major == 2:
 
1103
                        # Extract the original non-method undecorated
 
1104
                        # function by black magic
 
1105
                        nonmethod_func = (dict(
1109
1106
                            zip(attribute.func_code.co_freevars,
1110
 
                                attribute.__closure__))["func"]
1111
 
                                      .cell_contents)
 
1107
                                attribute.__closure__))
 
1108
                                          ["func"].cell_contents)
 
1109
                    else:
 
1110
                        nonmethod_func = attribute
1112
1111
                    # Create a new, but exactly alike, function
1113
1112
                    # object, and decorate it to be a new D-Bus signal
1114
1113
                    # with the alternate D-Bus interface name
1115
 
                    new_function = (dbus.service.signal
1116
 
                                    (alt_interface,
1117
 
                                     attribute._dbus_signature)
1118
 
                                    (types.FunctionType(
1119
 
                                nonmethod_func.func_code,
1120
 
                                nonmethod_func.func_globals,
1121
 
                                nonmethod_func.func_name,
1122
 
                                nonmethod_func.func_defaults,
1123
 
                                nonmethod_func.func_closure)))
 
1114
                    if sys.version_info.major == 2:
 
1115
                        new_function = types.FunctionType(
 
1116
                            nonmethod_func.func_code,
 
1117
                            nonmethod_func.func_globals,
 
1118
                            nonmethod_func.func_name,
 
1119
                            nonmethod_func.func_defaults,
 
1120
                            nonmethod_func.func_closure)
 
1121
                    else:
 
1122
                        new_function = types.FunctionType(
 
1123
                            nonmethod_func.__code__,
 
1124
                            nonmethod_func.__globals__,
 
1125
                            nonmethod_func.__name__,
 
1126
                            nonmethod_func.__defaults__,
 
1127
                            nonmethod_func.__closure__)
 
1128
                    new_function = (dbus.service.signal(
 
1129
                        alt_interface,
 
1130
                        attribute._dbus_signature)(new_function))
1124
1131
                    # Copy annotations, if any
1125
1132
                    try:
1126
 
                        new_function._dbus_annotations = (
1127
 
                            dict(attribute._dbus_annotations))
 
1133
                        new_function._dbus_annotations = dict(
 
1134
                            attribute._dbus_annotations)
1128
1135
                    except AttributeError:
1129
1136
                        pass
1130
1137
                    # Define a creator of a function to call both the
1135
1142
                        """This function is a scope container to pass
1136
1143
                        func1 and func2 to the "call_both" function
1137
1144
                        outside of its arguments"""
 
1145
                        
1138
1146
                        def call_both(*args, **kwargs):
1139
1147
                            """This function will emit two D-Bus
1140
1148
                            signals by calling func1 and func2"""
1141
1149
                            func1(*args, **kwargs)
1142
1150
                            func2(*args, **kwargs)
 
1151
                        
1143
1152
                        return call_both
1144
1153
                    # Create the "call_both" function and add it to
1145
1154
                    # the class
1150
1159
                    # object.  Decorate it to be a new D-Bus method
1151
1160
                    # with the alternate D-Bus interface name.  Add it
1152
1161
                    # to the class.
1153
 
                    attr[attrname] = (dbus.service.method
1154
 
                                      (alt_interface,
1155
 
                                       attribute._dbus_in_signature,
1156
 
                                       attribute._dbus_out_signature)
1157
 
                                      (types.FunctionType
1158
 
                                       (attribute.func_code,
1159
 
                                        attribute.func_globals,
1160
 
                                        attribute.func_name,
1161
 
                                        attribute.func_defaults,
1162
 
                                        attribute.func_closure)))
 
1162
                    attr[attrname] = (
 
1163
                        dbus.service.method(
 
1164
                            alt_interface,
 
1165
                            attribute._dbus_in_signature,
 
1166
                            attribute._dbus_out_signature)
 
1167
                        (types.FunctionType(attribute.func_code,
 
1168
                                            attribute.func_globals,
 
1169
                                            attribute.func_name,
 
1170
                                            attribute.func_defaults,
 
1171
                                            attribute.func_closure)))
1163
1172
                    # Copy annotations, if any
1164
1173
                    try:
1165
 
                        attr[attrname]._dbus_annotations = (
1166
 
                            dict(attribute._dbus_annotations))
 
1174
                        attr[attrname]._dbus_annotations = dict(
 
1175
                            attribute._dbus_annotations)
1167
1176
                    except AttributeError:
1168
1177
                        pass
1169
1178
                # Is this a D-Bus property?
1172
1181
                    # object, and decorate it to be a new D-Bus
1173
1182
                    # property with the alternate D-Bus interface
1174
1183
                    # name.  Add it to the class.
1175
 
                    attr[attrname] = (dbus_service_property
1176
 
                                      (alt_interface,
1177
 
                                       attribute._dbus_signature,
1178
 
                                       attribute._dbus_access,
1179
 
                                       attribute
1180
 
                                       ._dbus_get_args_options
1181
 
                                       ["byte_arrays"])
1182
 
                                      (types.FunctionType
1183
 
                                       (attribute.func_code,
1184
 
                                        attribute.func_globals,
1185
 
                                        attribute.func_name,
1186
 
                                        attribute.func_defaults,
1187
 
                                        attribute.func_closure)))
 
1184
                    attr[attrname] = (dbus_service_property(
 
1185
                        alt_interface, attribute._dbus_signature,
 
1186
                        attribute._dbus_access,
 
1187
                        attribute._dbus_get_args_options
 
1188
                        ["byte_arrays"])
 
1189
                                      (types.FunctionType(
 
1190
                                          attribute.func_code,
 
1191
                                          attribute.func_globals,
 
1192
                                          attribute.func_name,
 
1193
                                          attribute.func_defaults,
 
1194
                                          attribute.func_closure)))
1188
1195
                    # Copy annotations, if any
1189
1196
                    try:
1190
 
                        attr[attrname]._dbus_annotations = (
1191
 
                            dict(attribute._dbus_annotations))
 
1197
                        attr[attrname]._dbus_annotations = dict(
 
1198
                            attribute._dbus_annotations)
1192
1199
                    except AttributeError:
1193
1200
                        pass
1194
1201
                # Is this a D-Bus interface?
1197
1204
                    # object.  Decorate it to be a new D-Bus interface
1198
1205
                    # with the alternate D-Bus interface name.  Add it
1199
1206
                    # to the class.
1200
 
                    attr[attrname] = (dbus_interface_annotations
1201
 
                                      (alt_interface)
1202
 
                                      (types.FunctionType
1203
 
                                       (attribute.func_code,
1204
 
                                        attribute.func_globals,
1205
 
                                        attribute.func_name,
1206
 
                                        attribute.func_defaults,
1207
 
                                        attribute.func_closure)))
 
1207
                    attr[attrname] = (
 
1208
                        dbus_interface_annotations(alt_interface)
 
1209
                        (types.FunctionType(attribute.func_code,
 
1210
                                            attribute.func_globals,
 
1211
                                            attribute.func_name,
 
1212
                                            attribute.func_defaults,
 
1213
                                            attribute.func_closure)))
1208
1214
            if deprecate:
1209
1215
                # Deprecate all alternate interfaces
1210
 
                iname="_AlternateDBusNames_interface_annotation{0}"
 
1216
                iname="_AlternateDBusNames_interface_annotation{}"
1211
1217
                for interface_name in interface_names:
 
1218
                    
1212
1219
                    @dbus_interface_annotations(interface_name)
1213
1220
                    def func(self):
1214
1221
                        return { "org.freedesktop.DBus.Deprecated":
1215
 
                                     "true" }
 
1222
                                 "true" }
1216
1223
                    # Find an unused name
1217
1224
                    for aname in (iname.format(i)
1218
1225
                                  for i in itertools.count()):
1222
1229
            if interface_names:
1223
1230
                # Replace the class with a new subclass of it with
1224
1231
                # methods, signals, etc. as created above.
1225
 
                cls = type(b"{0}Alternate".format(cls.__name__),
1226
 
                           (cls,), attr)
 
1232
                cls = type(b"{}Alternate".format(cls.__name__),
 
1233
                           (cls, ), attr)
1227
1234
        return cls
 
1235
    
1228
1236
    return wrapper
1229
1237
 
1230
1238
 
1231
1239
@alternate_dbus_interfaces({"se.recompile.Mandos":
1232
 
                                "se.bsnet.fukt.Mandos"})
 
1240
                            "se.bsnet.fukt.Mandos"})
1233
1241
class ClientDBus(Client, DBusObjectWithProperties):
1234
1242
    """A Client class using D-Bus
1235
1243
    
1239
1247
    """
1240
1248
    
1241
1249
    runtime_expansions = (Client.runtime_expansions
1242
 
                          + ("dbus_object_path",))
 
1250
                          + ("dbus_object_path", ))
 
1251
    
 
1252
    _interface = "se.recompile.Mandos.Client"
1243
1253
    
1244
1254
    # dbus.service.Object doesn't use super(), so we can't either.
1245
1255
    
1248
1258
        Client.__init__(self, *args, **kwargs)
1249
1259
        # Only now, when this client is initialized, can it show up on
1250
1260
        # the D-Bus
1251
 
        client_object_name = unicode(self.name).translate(
 
1261
        client_object_name = str(self.name).translate(
1252
1262
            {ord("."): ord("_"),
1253
1263
             ord("-"): ord("_")})
1254
 
        self.dbus_object_path = (dbus.ObjectPath
1255
 
                                 ("/clients/" + client_object_name))
 
1264
        self.dbus_object_path = dbus.ObjectPath(
 
1265
            "/clients/" + client_object_name)
1256
1266
        DBusObjectWithProperties.__init__(self, self.bus,
1257
1267
                                          self.dbus_object_path)
1258
1268
    
1259
 
    def notifychangeproperty(transform_func,
1260
 
                             dbus_name, type_func=lambda x: x,
1261
 
                             variant_level=1):
 
1269
    def notifychangeproperty(transform_func, dbus_name,
 
1270
                             type_func=lambda x: x,
 
1271
                             variant_level=1,
 
1272
                             invalidate_only=False,
 
1273
                             _interface=_interface):
1262
1274
        """ Modify a variable so that it's a property which announces
1263
1275
        its changes to DBus.
1264
1276
        
1269
1281
                   to the D-Bus.  Default: no transform
1270
1282
        variant_level: D-Bus variant level.  Default: 1
1271
1283
        """
1272
 
        attrname = "_{0}".format(dbus_name)
 
1284
        attrname = "_{}".format(dbus_name)
 
1285
        
1273
1286
        def setter(self, value):
1274
1287
            if hasattr(self, "dbus_object_path"):
1275
1288
                if (not hasattr(self, attrname) or
1276
1289
                    type_func(getattr(self, attrname, None))
1277
1290
                    != type_func(value)):
1278
 
                    dbus_value = transform_func(type_func(value),
1279
 
                                                variant_level
1280
 
                                                =variant_level)
1281
 
                    self.PropertyChanged(dbus.String(dbus_name),
1282
 
                                         dbus_value)
 
1291
                    if invalidate_only:
 
1292
                        self.PropertiesChanged(
 
1293
                            _interface, dbus.Dictionary(),
 
1294
                            dbus.Array((dbus_name, )))
 
1295
                    else:
 
1296
                        dbus_value = transform_func(
 
1297
                            type_func(value),
 
1298
                            variant_level = variant_level)
 
1299
                        self.PropertyChanged(dbus.String(dbus_name),
 
1300
                                             dbus_value)
 
1301
                        self.PropertiesChanged(
 
1302
                            _interface,
 
1303
                            dbus.Dictionary({ dbus.String(dbus_name):
 
1304
                                              dbus_value }),
 
1305
                            dbus.Array())
1283
1306
            setattr(self, attrname, value)
1284
1307
        
1285
1308
        return property(lambda self: getattr(self, attrname), setter)
1291
1314
    enabled = notifychangeproperty(dbus.Boolean, "Enabled")
1292
1315
    last_enabled = notifychangeproperty(datetime_to_dbus,
1293
1316
                                        "LastEnabled")
1294
 
    checker = notifychangeproperty(dbus.Boolean, "CheckerRunning",
1295
 
                                   type_func = lambda checker:
1296
 
                                       checker is not None)
 
1317
    checker = notifychangeproperty(
 
1318
        dbus.Boolean, "CheckerRunning",
 
1319
        type_func = lambda checker: checker is not None)
1297
1320
    last_checked_ok = notifychangeproperty(datetime_to_dbus,
1298
1321
                                           "LastCheckedOK")
1299
1322
    last_checker_status = notifychangeproperty(dbus.Int16,
1302
1325
        datetime_to_dbus, "LastApprovalRequest")
1303
1326
    approved_by_default = notifychangeproperty(dbus.Boolean,
1304
1327
                                               "ApprovedByDefault")
1305
 
    approval_delay = notifychangeproperty(dbus.UInt64,
1306
 
                                          "ApprovalDelay",
1307
 
                                          type_func =
1308
 
                                          timedelta_to_milliseconds)
 
1328
    approval_delay = notifychangeproperty(
 
1329
        dbus.UInt64, "ApprovalDelay",
 
1330
        type_func = lambda td: td.total_seconds() * 1000)
1309
1331
    approval_duration = notifychangeproperty(
1310
1332
        dbus.UInt64, "ApprovalDuration",
1311
 
        type_func = timedelta_to_milliseconds)
 
1333
        type_func = lambda td: td.total_seconds() * 1000)
1312
1334
    host = notifychangeproperty(dbus.String, "Host")
1313
 
    timeout = notifychangeproperty(dbus.UInt64, "Timeout",
1314
 
                                   type_func =
1315
 
                                   timedelta_to_milliseconds)
 
1335
    timeout = notifychangeproperty(
 
1336
        dbus.UInt64, "Timeout",
 
1337
        type_func = lambda td: td.total_seconds() * 1000)
1316
1338
    extended_timeout = notifychangeproperty(
1317
1339
        dbus.UInt64, "ExtendedTimeout",
1318
 
        type_func = timedelta_to_milliseconds)
1319
 
    interval = notifychangeproperty(dbus.UInt64,
1320
 
                                    "Interval",
1321
 
                                    type_func =
1322
 
                                    timedelta_to_milliseconds)
 
1340
        type_func = lambda td: td.total_seconds() * 1000)
 
1341
    interval = notifychangeproperty(
 
1342
        dbus.UInt64, "Interval",
 
1343
        type_func = lambda td: td.total_seconds() * 1000)
1323
1344
    checker_command = notifychangeproperty(dbus.String, "Checker")
 
1345
    secret = notifychangeproperty(dbus.ByteArray, "Secret",
 
1346
                                  invalidate_only=True)
1324
1347
    
1325
1348
    del notifychangeproperty
1326
1349
    
1333
1356
            DBusObjectWithProperties.__del__(self, *args, **kwargs)
1334
1357
        Client.__del__(self, *args, **kwargs)
1335
1358
    
1336
 
    def checker_callback(self, pid, condition, command,
1337
 
                         *args, **kwargs):
1338
 
        self.checker_callback_tag = None
1339
 
        self.checker = None
1340
 
        if os.WIFEXITED(condition):
1341
 
            exitstatus = os.WEXITSTATUS(condition)
 
1359
    def checker_callback(self, source, condition,
 
1360
                         connection, command, *args, **kwargs):
 
1361
        ret = Client.checker_callback(self, source, condition,
 
1362
                                      connection, command, *args,
 
1363
                                      **kwargs)
 
1364
        exitstatus = self.last_checker_status
 
1365
        if exitstatus >= 0:
1342
1366
            # Emit D-Bus signal
1343
1367
            self.CheckerCompleted(dbus.Int16(exitstatus),
1344
 
                                  dbus.Int64(condition),
 
1368
                                  dbus.Int64(0),
1345
1369
                                  dbus.String(command))
1346
1370
        else:
1347
1371
            # Emit D-Bus signal
1348
1372
            self.CheckerCompleted(dbus.Int16(-1),
1349
 
                                  dbus.Int64(condition),
 
1373
                                  dbus.Int64(
 
1374
                                      self.last_checker_signal),
1350
1375
                                  dbus.String(command))
1351
 
        
1352
 
        return Client.checker_callback(self, pid, condition, command,
1353
 
                                       *args, **kwargs)
 
1376
        return ret
1354
1377
    
1355
1378
    def start_checker(self, *args, **kwargs):
1356
1379
        old_checker_pid = getattr(self.checker, "pid", None)
1368
1391
    
1369
1392
    def approve(self, value=True):
1370
1393
        self.approved = value
1371
 
        gobject.timeout_add(timedelta_to_milliseconds
1372
 
                            (self.approval_duration),
1373
 
                            self._reset_approved)
 
1394
        gobject.timeout_add(int(self.approval_duration.total_seconds()
 
1395
                                * 1000), self._reset_approved)
1374
1396
        self.send_changedstate()
1375
1397
    
1376
1398
    ## D-Bus methods, signals & properties
1377
 
    _interface = "se.recompile.Mandos.Client"
1378
1399
    
1379
1400
    ## Interfaces
1380
1401
    
1381
 
    @dbus_interface_annotations(_interface)
1382
 
    def _foo(self):
1383
 
        return { "org.freedesktop.DBus.Property.EmitsChangedSignal":
1384
 
                     "false"}
1385
 
    
1386
1402
    ## Signals
1387
1403
    
1388
1404
    # CheckerCompleted - signal
1398
1414
        pass
1399
1415
    
1400
1416
    # PropertyChanged - signal
 
1417
    @dbus_annotations({"org.freedesktop.DBus.Deprecated": "true"})
1401
1418
    @dbus.service.signal(_interface, signature="sv")
1402
1419
    def PropertyChanged(self, property, value):
1403
1420
        "D-Bus signal"
1467
1484
        return dbus.Boolean(bool(self.approvals_pending))
1468
1485
    
1469
1486
    # ApprovedByDefault - property
1470
 
    @dbus_service_property(_interface, signature="b",
 
1487
    @dbus_service_property(_interface,
 
1488
                           signature="b",
1471
1489
                           access="readwrite")
1472
1490
    def ApprovedByDefault_dbus_property(self, value=None):
1473
1491
        if value is None:       # get
1475
1493
        self.approved_by_default = bool(value)
1476
1494
    
1477
1495
    # ApprovalDelay - property
1478
 
    @dbus_service_property(_interface, signature="t",
 
1496
    @dbus_service_property(_interface,
 
1497
                           signature="t",
1479
1498
                           access="readwrite")
1480
1499
    def ApprovalDelay_dbus_property(self, value=None):
1481
1500
        if value is None:       # get
1482
 
            return dbus.UInt64(self.approval_delay_milliseconds())
 
1501
            return dbus.UInt64(self.approval_delay.total_seconds()
 
1502
                               * 1000)
1483
1503
        self.approval_delay = datetime.timedelta(0, 0, 0, value)
1484
1504
    
1485
1505
    # ApprovalDuration - property
1486
 
    @dbus_service_property(_interface, signature="t",
 
1506
    @dbus_service_property(_interface,
 
1507
                           signature="t",
1487
1508
                           access="readwrite")
1488
1509
    def ApprovalDuration_dbus_property(self, value=None):
1489
1510
        if value is None:       # get
1490
 
            return dbus.UInt64(timedelta_to_milliseconds(
1491
 
                    self.approval_duration))
 
1511
            return dbus.UInt64(self.approval_duration.total_seconds()
 
1512
                               * 1000)
1492
1513
        self.approval_duration = datetime.timedelta(0, 0, 0, value)
1493
1514
    
1494
1515
    # Name - property
1502
1523
        return dbus.String(self.fingerprint)
1503
1524
    
1504
1525
    # Host - property
1505
 
    @dbus_service_property(_interface, signature="s",
 
1526
    @dbus_service_property(_interface,
 
1527
                           signature="s",
1506
1528
                           access="readwrite")
1507
1529
    def Host_dbus_property(self, value=None):
1508
1530
        if value is None:       # get
1509
1531
            return dbus.String(self.host)
1510
 
        self.host = unicode(value)
 
1532
        self.host = str(value)
1511
1533
    
1512
1534
    # Created - property
1513
1535
    @dbus_service_property(_interface, signature="s", access="read")
1520
1542
        return datetime_to_dbus(self.last_enabled)
1521
1543
    
1522
1544
    # Enabled - property
1523
 
    @dbus_service_property(_interface, signature="b",
 
1545
    @dbus_service_property(_interface,
 
1546
                           signature="b",
1524
1547
                           access="readwrite")
1525
1548
    def Enabled_dbus_property(self, value=None):
1526
1549
        if value is None:       # get
1531
1554
            self.disable()
1532
1555
    
1533
1556
    # LastCheckedOK - property
1534
 
    @dbus_service_property(_interface, signature="s",
 
1557
    @dbus_service_property(_interface,
 
1558
                           signature="s",
1535
1559
                           access="readwrite")
1536
1560
    def LastCheckedOK_dbus_property(self, value=None):
1537
1561
        if value is not None:
1540
1564
        return datetime_to_dbus(self.last_checked_ok)
1541
1565
    
1542
1566
    # LastCheckerStatus - property
1543
 
    @dbus_service_property(_interface, signature="n",
1544
 
                           access="read")
 
1567
    @dbus_service_property(_interface, signature="n", access="read")
1545
1568
    def LastCheckerStatus_dbus_property(self):
1546
1569
        return dbus.Int16(self.last_checker_status)
1547
1570
    
1556
1579
        return datetime_to_dbus(self.last_approval_request)
1557
1580
    
1558
1581
    # Timeout - property
1559
 
    @dbus_service_property(_interface, signature="t",
 
1582
    @dbus_service_property(_interface,
 
1583
                           signature="t",
1560
1584
                           access="readwrite")
1561
1585
    def Timeout_dbus_property(self, value=None):
1562
1586
        if value is None:       # get
1563
 
            return dbus.UInt64(self.timeout_milliseconds())
 
1587
            return dbus.UInt64(self.timeout.total_seconds() * 1000)
1564
1588
        old_timeout = self.timeout
1565
1589
        self.timeout = datetime.timedelta(0, 0, 0, value)
1566
1590
        # Reschedule disabling
1575
1599
                    is None):
1576
1600
                    return
1577
1601
                gobject.source_remove(self.disable_initiator_tag)
1578
 
                self.disable_initiator_tag = (
1579
 
                    gobject.timeout_add(
1580
 
                        timedelta_to_milliseconds(self.expires - now),
1581
 
                        self.disable))
 
1602
                self.disable_initiator_tag = gobject.timeout_add(
 
1603
                    int((self.expires - now).total_seconds() * 1000),
 
1604
                    self.disable)
1582
1605
    
1583
1606
    # ExtendedTimeout - property
1584
 
    @dbus_service_property(_interface, signature="t",
 
1607
    @dbus_service_property(_interface,
 
1608
                           signature="t",
1585
1609
                           access="readwrite")
1586
1610
    def ExtendedTimeout_dbus_property(self, value=None):
1587
1611
        if value is None:       # get
1588
 
            return dbus.UInt64(self.extended_timeout_milliseconds())
 
1612
            return dbus.UInt64(self.extended_timeout.total_seconds()
 
1613
                               * 1000)
1589
1614
        self.extended_timeout = datetime.timedelta(0, 0, 0, value)
1590
1615
    
1591
1616
    # Interval - property
1592
 
    @dbus_service_property(_interface, signature="t",
 
1617
    @dbus_service_property(_interface,
 
1618
                           signature="t",
1593
1619
                           access="readwrite")
1594
1620
    def Interval_dbus_property(self, value=None):
1595
1621
        if value is None:       # get
1596
 
            return dbus.UInt64(self.interval_milliseconds())
 
1622
            return dbus.UInt64(self.interval.total_seconds() * 1000)
1597
1623
        self.interval = datetime.timedelta(0, 0, 0, value)
1598
1624
        if getattr(self, "checker_initiator_tag", None) is None:
1599
1625
            return
1600
1626
        if self.enabled:
1601
1627
            # Reschedule checker run
1602
1628
            gobject.source_remove(self.checker_initiator_tag)
1603
 
            self.checker_initiator_tag = (gobject.timeout_add
1604
 
                                          (value, self.start_checker))
1605
 
            self.start_checker()    # Start one now, too
 
1629
            self.checker_initiator_tag = gobject.timeout_add(
 
1630
                value, self.start_checker)
 
1631
            self.start_checker() # Start one now, too
1606
1632
    
1607
1633
    # Checker - property
1608
 
    @dbus_service_property(_interface, signature="s",
 
1634
    @dbus_service_property(_interface,
 
1635
                           signature="s",
1609
1636
                           access="readwrite")
1610
1637
    def Checker_dbus_property(self, value=None):
1611
1638
        if value is None:       # get
1612
1639
            return dbus.String(self.checker_command)
1613
 
        self.checker_command = unicode(value)
 
1640
        self.checker_command = str(value)
1614
1641
    
1615
1642
    # CheckerRunning - property
1616
 
    @dbus_service_property(_interface, signature="b",
 
1643
    @dbus_service_property(_interface,
 
1644
                           signature="b",
1617
1645
                           access="readwrite")
1618
1646
    def CheckerRunning_dbus_property(self, value=None):
1619
1647
        if value is None:       # get
1629
1657
        return self.dbus_object_path # is already a dbus.ObjectPath
1630
1658
    
1631
1659
    # Secret = property
1632
 
    @dbus_service_property(_interface, signature="ay",
1633
 
                           access="write", byte_arrays=True)
 
1660
    @dbus_service_property(_interface,
 
1661
                           signature="ay",
 
1662
                           access="write",
 
1663
                           byte_arrays=True)
1634
1664
    def Secret_dbus_property(self, value):
1635
 
        self.secret = str(value)
 
1665
        self.secret = bytes(value)
1636
1666
    
1637
1667
    del _interface
1638
1668
 
1642
1672
        self._pipe = child_pipe
1643
1673
        self._pipe.send(('init', fpr, address))
1644
1674
        if not self._pipe.recv():
1645
 
            raise KeyError()
 
1675
            raise KeyError(fpr)
1646
1676
    
1647
1677
    def __getattribute__(self, name):
1648
1678
        if name == '_pipe':
1652
1682
        if data[0] == 'data':
1653
1683
            return data[1]
1654
1684
        if data[0] == 'function':
 
1685
            
1655
1686
            def func(*args, **kwargs):
1656
1687
                self._pipe.send(('funcall', name, args, kwargs))
1657
1688
                return self._pipe.recv()[1]
 
1689
            
1658
1690
            return func
1659
1691
    
1660
1692
    def __setattr__(self, name, value):
1672
1704
    def handle(self):
1673
1705
        with contextlib.closing(self.server.child_pipe) as child_pipe:
1674
1706
            logger.info("TCP connection from: %s",
1675
 
                        unicode(self.client_address))
 
1707
                        str(self.client_address))
1676
1708
            logger.debug("Pipe FD: %d",
1677
1709
                         self.server.child_pipe.fileno())
1678
1710
            
1679
 
            session = (gnutls.connection
1680
 
                       .ClientSession(self.request,
1681
 
                                      gnutls.connection
1682
 
                                      .X509Credentials()))
 
1711
            session = gnutls.connection.ClientSession(
 
1712
                self.request, gnutls.connection .X509Credentials())
1683
1713
            
1684
1714
            # Note: gnutls.connection.X509Credentials is really a
1685
1715
            # generic GnuTLS certificate credentials object so long as
1694
1724
            priority = self.server.gnutls_priority
1695
1725
            if priority is None:
1696
1726
                priority = "NORMAL"
1697
 
            (gnutls.library.functions
1698
 
             .gnutls_priority_set_direct(session._c_object,
1699
 
                                         priority, None))
 
1727
            gnutls.library.functions.gnutls_priority_set_direct(
 
1728
                session._c_object, priority, None)
1700
1729
            
1701
1730
            # Start communication using the Mandos protocol
1702
1731
            # Get protocol number
1722
1751
            approval_required = False
1723
1752
            try:
1724
1753
                try:
1725
 
                    fpr = self.fingerprint(self.peer_certificate
1726
 
                                           (session))
 
1754
                    fpr = self.fingerprint(
 
1755
                        self.peer_certificate(session))
1727
1756
                except (TypeError,
1728
1757
                        gnutls.errors.GNUTLSError) as error:
1729
1758
                    logger.warning("Bad certificate: %s", error)
1744
1773
                while True:
1745
1774
                    if not client.enabled:
1746
1775
                        logger.info("Client %s is disabled",
1747
 
                                       client.name)
 
1776
                                    client.name)
1748
1777
                        if self.server.use_dbus:
1749
1778
                            # Emit D-Bus signal
1750
1779
                            client.Rejected("Disabled")
1759
1788
                        if self.server.use_dbus:
1760
1789
                            # Emit D-Bus signal
1761
1790
                            client.NeedApproval(
1762
 
                                client.approval_delay_milliseconds(),
1763
 
                                client.approved_by_default)
 
1791
                                client.approval_delay.total_seconds()
 
1792
                                * 1000, client.approved_by_default)
1764
1793
                    else:
1765
1794
                        logger.warning("Client %s was not approved",
1766
1795
                                       client.name)
1772
1801
                    #wait until timeout or approved
1773
1802
                    time = datetime.datetime.now()
1774
1803
                    client.changedstate.acquire()
1775
 
                    client.changedstate.wait(
1776
 
                        float(timedelta_to_milliseconds(delay)
1777
 
                              / 1000))
 
1804
                    client.changedstate.wait(delay.total_seconds())
1778
1805
                    client.changedstate.release()
1779
1806
                    time2 = datetime.datetime.now()
1780
1807
                    if (time2 - time) >= delay:
1799
1826
                        logger.warning("gnutls send failed",
1800
1827
                                       exc_info=error)
1801
1828
                        return
1802
 
                    logger.debug("Sent: %d, remaining: %d",
1803
 
                                 sent, len(client.secret)
1804
 
                                 - (sent_size + sent))
 
1829
                    logger.debug("Sent: %d, remaining: %d", sent,
 
1830
                                 len(client.secret) - (sent_size
 
1831
                                                       + sent))
1805
1832
                    sent_size += sent
1806
1833
                
1807
1834
                logger.info("Sending secret to %s", client.name)
1824
1851
    def peer_certificate(session):
1825
1852
        "Return the peer's OpenPGP certificate as a bytestring"
1826
1853
        # If not an OpenPGP certificate...
1827
 
        if (gnutls.library.functions
1828
 
            .gnutls_certificate_type_get(session._c_object)
 
1854
        if (gnutls.library.functions.gnutls_certificate_type_get(
 
1855
                session._c_object)
1829
1856
            != gnutls.library.constants.GNUTLS_CRT_OPENPGP):
1830
1857
            # ...do the normal thing
1831
1858
            return session.peer_certificate
1845
1872
    def fingerprint(openpgp):
1846
1873
        "Convert an OpenPGP bytestring to a hexdigit fingerprint"
1847
1874
        # New GnuTLS "datum" with the OpenPGP public key
1848
 
        datum = (gnutls.library.types
1849
 
                 .gnutls_datum_t(ctypes.cast(ctypes.c_char_p(openpgp),
1850
 
                                             ctypes.POINTER
1851
 
                                             (ctypes.c_ubyte)),
1852
 
                                 ctypes.c_uint(len(openpgp))))
 
1875
        datum = gnutls.library.types.gnutls_datum_t(
 
1876
            ctypes.cast(ctypes.c_char_p(openpgp),
 
1877
                        ctypes.POINTER(ctypes.c_ubyte)),
 
1878
            ctypes.c_uint(len(openpgp)))
1853
1879
        # New empty GnuTLS certificate
1854
1880
        crt = gnutls.library.types.gnutls_openpgp_crt_t()
1855
 
        (gnutls.library.functions
1856
 
         .gnutls_openpgp_crt_init(ctypes.byref(crt)))
 
1881
        gnutls.library.functions.gnutls_openpgp_crt_init(
 
1882
            ctypes.byref(crt))
1857
1883
        # Import the OpenPGP public key into the certificate
1858
 
        (gnutls.library.functions
1859
 
         .gnutls_openpgp_crt_import(crt, ctypes.byref(datum),
1860
 
                                    gnutls.library.constants
1861
 
                                    .GNUTLS_OPENPGP_FMT_RAW))
 
1884
        gnutls.library.functions.gnutls_openpgp_crt_import(
 
1885
            crt, ctypes.byref(datum),
 
1886
            gnutls.library.constants.GNUTLS_OPENPGP_FMT_RAW)
1862
1887
        # Verify the self signature in the key
1863
1888
        crtverify = ctypes.c_uint()
1864
 
        (gnutls.library.functions
1865
 
         .gnutls_openpgp_crt_verify_self(crt, 0,
1866
 
                                         ctypes.byref(crtverify)))
 
1889
        gnutls.library.functions.gnutls_openpgp_crt_verify_self(
 
1890
            crt, 0, ctypes.byref(crtverify))
1867
1891
        if crtverify.value != 0:
1868
1892
            gnutls.library.functions.gnutls_openpgp_crt_deinit(crt)
1869
 
            raise (gnutls.errors.CertificateSecurityError
1870
 
                   ("Verify failed"))
 
1893
            raise gnutls.errors.CertificateSecurityError(
 
1894
                "Verify failed")
1871
1895
        # New buffer for the fingerprint
1872
1896
        buf = ctypes.create_string_buffer(20)
1873
1897
        buf_len = ctypes.c_size_t()
1874
1898
        # Get the fingerprint from the certificate into the buffer
1875
 
        (gnutls.library.functions
1876
 
         .gnutls_openpgp_crt_get_fingerprint(crt, ctypes.byref(buf),
1877
 
                                             ctypes.byref(buf_len)))
 
1899
        gnutls.library.functions.gnutls_openpgp_crt_get_fingerprint(
 
1900
            crt, ctypes.byref(buf), ctypes.byref(buf_len))
1878
1901
        # Deinit the certificate
1879
1902
        gnutls.library.functions.gnutls_openpgp_crt_deinit(crt)
1880
1903
        # Convert the buffer to a Python bytestring
1886
1909
 
1887
1910
class MultiprocessingMixIn(object):
1888
1911
    """Like socketserver.ThreadingMixIn, but with multiprocessing"""
 
1912
    
1889
1913
    def sub_process_main(self, request, address):
1890
1914
        try:
1891
1915
            self.finish_request(request, address)
1903
1927
 
1904
1928
class MultiprocessingMixInWithPipe(MultiprocessingMixIn, object):
1905
1929
    """ adds a pipe to the MixIn """
 
1930
    
1906
1931
    def process_request(self, request, client_address):
1907
1932
        """Overrides and wraps the original process_request().
1908
1933
        
1929
1954
        interface:      None or a network interface name (string)
1930
1955
        use_ipv6:       Boolean; to use IPv6 or not
1931
1956
    """
 
1957
    
1932
1958
    def __init__(self, server_address, RequestHandlerClass,
1933
 
                 interface=None, use_ipv6=True, socketfd=None):
 
1959
                 interface=None,
 
1960
                 use_ipv6=True,
 
1961
                 socketfd=None):
1934
1962
        """If socketfd is set, use that file descriptor instead of
1935
1963
        creating a new one with socket.socket().
1936
1964
        """
1977
2005
                             self.interface)
1978
2006
            else:
1979
2007
                try:
1980
 
                    self.socket.setsockopt(socket.SOL_SOCKET,
1981
 
                                           SO_BINDTODEVICE,
1982
 
                                           str(self.interface + '\0'))
 
2008
                    self.socket.setsockopt(
 
2009
                        socket.SOL_SOCKET, SO_BINDTODEVICE,
 
2010
                        (self.interface + "\0").encode("utf-8"))
1983
2011
                except socket.error as error:
1984
2012
                    if error.errno == errno.EPERM:
1985
2013
                        logger.error("No permission to bind to"
2003
2031
                self.server_address = (any_address,
2004
2032
                                       self.server_address[1])
2005
2033
            elif not self.server_address[1]:
2006
 
                self.server_address = (self.server_address[0],
2007
 
                                       0)
 
2034
                self.server_address = (self.server_address[0], 0)
2008
2035
#                 if self.interface:
2009
2036
#                     self.server_address = (self.server_address[0],
2010
2037
#                                            0, # port
2024
2051
    
2025
2052
    Assumes a gobject.MainLoop event loop.
2026
2053
    """
 
2054
    
2027
2055
    def __init__(self, server_address, RequestHandlerClass,
2028
 
                 interface=None, use_ipv6=True, clients=None,
2029
 
                 gnutls_priority=None, use_dbus=True, socketfd=None):
 
2056
                 interface=None,
 
2057
                 use_ipv6=True,
 
2058
                 clients=None,
 
2059
                 gnutls_priority=None,
 
2060
                 use_dbus=True,
 
2061
                 socketfd=None):
2030
2062
        self.enabled = False
2031
2063
        self.clients = clients
2032
2064
        if self.clients is None:
2038
2070
                                interface = interface,
2039
2071
                                use_ipv6 = use_ipv6,
2040
2072
                                socketfd = socketfd)
 
2073
    
2041
2074
    def server_activate(self):
2042
2075
        if self.enabled:
2043
2076
            return socketserver.TCPServer.server_activate(self)
2047
2080
    
2048
2081
    def add_pipe(self, parent_pipe, proc):
2049
2082
        # Call "handle_ipc" for both data and EOF events
2050
 
        gobject.io_add_watch(parent_pipe.fileno(),
2051
 
                             gobject.IO_IN | gobject.IO_HUP,
2052
 
                             functools.partial(self.handle_ipc,
2053
 
                                               parent_pipe =
2054
 
                                               parent_pipe,
2055
 
                                               proc = proc))
 
2083
        gobject.io_add_watch(
 
2084
            parent_pipe.fileno(),
 
2085
            gobject.IO_IN | gobject.IO_HUP,
 
2086
            functools.partial(self.handle_ipc,
 
2087
                              parent_pipe = parent_pipe,
 
2088
                              proc = proc))
2056
2089
    
2057
 
    def handle_ipc(self, source, condition, parent_pipe=None,
2058
 
                   proc = None, client_object=None):
 
2090
    def handle_ipc(self, source, condition,
 
2091
                   parent_pipe=None,
 
2092
                   proc = None,
 
2093
                   client_object=None):
2059
2094
        # error, or the other end of multiprocessing.Pipe has closed
2060
2095
        if condition & (gobject.IO_ERR | gobject.IO_HUP):
2061
2096
            # Wait for other process to exit
2084
2119
                parent_pipe.send(False)
2085
2120
                return False
2086
2121
            
2087
 
            gobject.io_add_watch(parent_pipe.fileno(),
2088
 
                                 gobject.IO_IN | gobject.IO_HUP,
2089
 
                                 functools.partial(self.handle_ipc,
2090
 
                                                   parent_pipe =
2091
 
                                                   parent_pipe,
2092
 
                                                   proc = proc,
2093
 
                                                   client_object =
2094
 
                                                   client))
 
2122
            gobject.io_add_watch(
 
2123
                parent_pipe.fileno(),
 
2124
                gobject.IO_IN | gobject.IO_HUP,
 
2125
                functools.partial(self.handle_ipc,
 
2126
                                  parent_pipe = parent_pipe,
 
2127
                                  proc = proc,
 
2128
                                  client_object = client))
2095
2129
            parent_pipe.send(True)
2096
2130
            # remove the old hook in favor of the new above hook on
2097
2131
            # same fileno
2103
2137
            
2104
2138
            parent_pipe.send(('data', getattr(client_object,
2105
2139
                                              funcname)(*args,
2106
 
                                                         **kwargs)))
 
2140
                                                        **kwargs)))
2107
2141
        
2108
2142
        if command == 'getattr':
2109
2143
            attrname = request[1]
2110
 
            if callable(client_object.__getattribute__(attrname)):
2111
 
                parent_pipe.send(('function',))
 
2144
            if isinstance(client_object.__getattribute__(attrname),
 
2145
                          collections.Callable):
 
2146
                parent_pipe.send(('function', ))
2112
2147
            else:
2113
 
                parent_pipe.send(('data', client_object
2114
 
                                  .__getattribute__(attrname)))
 
2148
                parent_pipe.send((
 
2149
                    'data', client_object.__getattribute__(attrname)))
2115
2150
        
2116
2151
        if command == 'setattr':
2117
2152
            attrname = request[1]
2148
2183
    # avoid excessive use of external libraries.
2149
2184
    
2150
2185
    # New type for defining tokens, syntax, and semantics all-in-one
2151
 
    Token = collections.namedtuple("Token",
2152
 
                                   ("regexp", # To match token; if
2153
 
                                              # "value" is not None,
2154
 
                                              # must have a "group"
2155
 
                                              # containing digits
2156
 
                                    "value",  # datetime.timedelta or
2157
 
                                              # None
2158
 
                                    "followers")) # Tokens valid after
2159
 
                                                  # this token
 
2186
    Token = collections.namedtuple("Token", (
 
2187
        "regexp",  # To match token; if "value" is not None, must have
 
2188
                   # a "group" containing digits
 
2189
        "value",   # datetime.timedelta or None
 
2190
        "followers"))           # Tokens valid after this token
2160
2191
    # RFC 3339 "duration" tokens, syntax, and semantics; taken from
2161
2192
    # the "duration" ABNF definition in RFC 3339, Appendix A.
2162
2193
    token_end = Token(re.compile(r"$"), None, frozenset())
2163
2194
    token_second = Token(re.compile(r"(\d+)S"),
2164
2195
                         datetime.timedelta(seconds=1),
2165
 
                         frozenset((token_end,)))
 
2196
                         frozenset((token_end, )))
2166
2197
    token_minute = Token(re.compile(r"(\d+)M"),
2167
2198
                         datetime.timedelta(minutes=1),
2168
2199
                         frozenset((token_second, token_end)))
2184
2215
                       frozenset((token_month, token_end)))
2185
2216
    token_week = Token(re.compile(r"(\d+)W"),
2186
2217
                       datetime.timedelta(weeks=1),
2187
 
                       frozenset((token_end,)))
 
2218
                       frozenset((token_end, )))
2188
2219
    token_duration = Token(re.compile(r"P"), None,
2189
2220
                           frozenset((token_year, token_month,
2190
2221
                                      token_day, token_time,
2191
 
                                      token_week))),
 
2222
                                      token_week)))
2192
2223
    # Define starting values
2193
2224
    value = datetime.timedelta() # Value so far
2194
2225
    found_token = None
2195
 
    followers = frozenset(token_duration,) # Following valid tokens
 
2226
    followers = frozenset((token_duration, )) # Following valid tokens
2196
2227
    s = duration                # String left to parse
2197
2228
    # Loop until end token is found
2198
2229
    while found_token is not token_end:
2215
2246
                break
2216
2247
        else:
2217
2248
            # No currently valid tokens were found
2218
 
            raise ValueError("Invalid RFC 3339 duration")
 
2249
            raise ValueError("Invalid RFC 3339 duration: {!r}"
 
2250
                             .format(duration))
2219
2251
    # End token found
2220
2252
    return value
2221
2253
 
2245
2277
    timevalue = datetime.timedelta(0)
2246
2278
    for s in interval.split():
2247
2279
        try:
2248
 
            suffix = unicode(s[-1])
 
2280
            suffix = s[-1]
2249
2281
            value = int(s[:-1])
2250
2282
            if suffix == "d":
2251
2283
                delta = datetime.timedelta(value)
2258
2290
            elif suffix == "w":
2259
2291
                delta = datetime.timedelta(0, 0, 0, 0, 0, 0, value)
2260
2292
            else:
2261
 
                raise ValueError("Unknown suffix {0!r}"
2262
 
                                 .format(suffix))
 
2293
                raise ValueError("Unknown suffix {!r}".format(suffix))
2263
2294
        except IndexError as e:
2264
2295
            raise ValueError(*(e.args))
2265
2296
        timevalue += delta
2282
2313
        null = os.open(os.devnull, os.O_NOCTTY | os.O_RDWR)
2283
2314
        if not stat.S_ISCHR(os.fstat(null).st_mode):
2284
2315
            raise OSError(errno.ENODEV,
2285
 
                          "{0} not a character device"
 
2316
                          "{} not a character device"
2286
2317
                          .format(os.devnull))
2287
2318
        os.dup2(null, sys.stdin.fileno())
2288
2319
        os.dup2(null, sys.stdout.fileno())
2298
2329
    
2299
2330
    parser = argparse.ArgumentParser()
2300
2331
    parser.add_argument("-v", "--version", action="version",
2301
 
                        version = "%(prog)s {0}".format(version),
 
2332
                        version = "%(prog)s {}".format(version),
2302
2333
                        help="show version number and exit")
2303
2334
    parser.add_argument("-i", "--interface", metavar="IF",
2304
2335
                        help="Bind to interface IF")
2354
2385
                        "port": "",
2355
2386
                        "debug": "False",
2356
2387
                        "priority":
2357
 
                        "SECURE256:!CTYPE-X.509:+CTYPE-OPENPGP:+SIGN-RSA-SHA224:+SIGN-RSA-RMD160",
 
2388
                        "SECURE256:!CTYPE-X.509:+CTYPE-OPENPGP:!RSA"
 
2389
                        ":+SIGN-RSA-SHA224:+SIGN-RSA-RMD160",
2358
2390
                        "servicename": "Mandos",
2359
2391
                        "use_dbus": "True",
2360
2392
                        "use_ipv6": "True",
2364
2396
                        "statedir": "/var/lib/mandos",
2365
2397
                        "foreground": "False",
2366
2398
                        "zeroconf": "True",
2367
 
                        }
 
2399
                    }
2368
2400
    
2369
2401
    # Parse config file for server-global settings
2370
2402
    server_config = configparser.SafeConfigParser(server_defaults)
2371
2403
    del server_defaults
2372
 
    server_config.read(os.path.join(options.configdir,
2373
 
                                    "mandos.conf"))
 
2404
    server_config.read(os.path.join(options.configdir, "mandos.conf"))
2374
2405
    # Convert the SafeConfigParser object to a dict
2375
2406
    server_settings = server_config.defaults()
2376
2407
    # Use the appropriate methods on the non-string config options
2394
2425
    # Override the settings from the config file with command line
2395
2426
    # options, if set.
2396
2427
    for option in ("interface", "address", "port", "debug",
2397
 
                   "priority", "servicename", "configdir",
2398
 
                   "use_dbus", "use_ipv6", "debuglevel", "restore",
2399
 
                   "statedir", "socket", "foreground", "zeroconf"):
 
2428
                   "priority", "servicename", "configdir", "use_dbus",
 
2429
                   "use_ipv6", "debuglevel", "restore", "statedir",
 
2430
                   "socket", "foreground", "zeroconf"):
2400
2431
        value = getattr(options, option)
2401
2432
        if value is not None:
2402
2433
            server_settings[option] = value
2403
2434
    del options
2404
2435
    # Force all strings to be unicode
2405
2436
    for option in server_settings.keys():
2406
 
        if type(server_settings[option]) is str:
2407
 
            server_settings[option] = unicode(server_settings[option])
 
2437
        if isinstance(server_settings[option], bytes):
 
2438
            server_settings[option] = (server_settings[option]
 
2439
                                       .decode("utf-8"))
2408
2440
    # Force all boolean options to be boolean
2409
2441
    for option in ("debug", "use_dbus", "use_ipv6", "restore",
2410
2442
                   "foreground", "zeroconf"):
2416
2448
    
2417
2449
    ##################################################################
2418
2450
    
2419
 
    if (not server_settings["zeroconf"] and
2420
 
        not (server_settings["port"]
2421
 
             or server_settings["socket"] != "")):
2422
 
            parser.error("Needs port or socket to work without"
2423
 
                         " Zeroconf")
 
2451
    if (not server_settings["zeroconf"]
 
2452
        and not (server_settings["port"]
 
2453
                 or server_settings["socket"] != "")):
 
2454
        parser.error("Needs port or socket to work without Zeroconf")
2424
2455
    
2425
2456
    # For convenience
2426
2457
    debug = server_settings["debug"]
2442
2473
            initlogger(debug, level)
2443
2474
    
2444
2475
    if server_settings["servicename"] != "Mandos":
2445
 
        syslogger.setFormatter(logging.Formatter
2446
 
                               ('Mandos ({0}) [%(process)d]:'
2447
 
                                ' %(levelname)s: %(message)s'
2448
 
                                .format(server_settings
2449
 
                                        ["servicename"])))
 
2476
        syslogger.setFormatter(
 
2477
            logging.Formatter('Mandos ({}) [%(process)d]:'
 
2478
                              ' %(levelname)s: %(message)s'.format(
 
2479
                                  server_settings["servicename"])))
2450
2480
    
2451
2481
    # Parse config file with clients
2452
2482
    client_config = configparser.SafeConfigParser(Client
2460
2490
    socketfd = None
2461
2491
    if server_settings["socket"] != "":
2462
2492
        socketfd = server_settings["socket"]
2463
 
    tcp_server = MandosServer((server_settings["address"],
2464
 
                               server_settings["port"]),
2465
 
                              ClientHandler,
2466
 
                              interface=(server_settings["interface"]
2467
 
                                         or None),
2468
 
                              use_ipv6=use_ipv6,
2469
 
                              gnutls_priority=
2470
 
                              server_settings["priority"],
2471
 
                              use_dbus=use_dbus,
2472
 
                              socketfd=socketfd)
 
2493
    tcp_server = MandosServer(
 
2494
        (server_settings["address"], server_settings["port"]),
 
2495
        ClientHandler,
 
2496
        interface=(server_settings["interface"] or None),
 
2497
        use_ipv6=use_ipv6,
 
2498
        gnutls_priority=server_settings["priority"],
 
2499
        use_dbus=use_dbus,
 
2500
        socketfd=socketfd)
2473
2501
    if not foreground:
2474
2502
        pidfilename = "/run/mandos.pid"
2475
2503
        if not os.path.isdir("/run/."):
2476
2504
            pidfilename = "/var/run/mandos.pid"
2477
2505
        pidfile = None
2478
2506
        try:
2479
 
            pidfile = open(pidfilename, "w")
 
2507
            pidfile = codecs.open(pidfilename, "w", encoding="utf-8")
2480
2508
        except IOError as e:
2481
2509
            logger.error("Could not open file %r", pidfilename,
2482
2510
                         exc_info=e)
2509
2537
        def debug_gnutls(level, string):
2510
2538
            logger.debug("GnuTLS: %s", string[:-1])
2511
2539
        
2512
 
        (gnutls.library.functions
2513
 
         .gnutls_global_set_log_function(debug_gnutls))
 
2540
        gnutls.library.functions.gnutls_global_set_log_function(
 
2541
            debug_gnutls)
2514
2542
        
2515
2543
        # Redirect stdin so all checkers get /dev/null
2516
2544
        null = os.open(os.devnull, os.O_NOCTTY | os.O_RDWR)
2536
2564
    if use_dbus:
2537
2565
        try:
2538
2566
            bus_name = dbus.service.BusName("se.recompile.Mandos",
2539
 
                                            bus, do_not_queue=True)
2540
 
            old_bus_name = (dbus.service.BusName
2541
 
                            ("se.bsnet.fukt.Mandos", bus,
2542
 
                             do_not_queue=True))
2543
 
        except dbus.exceptions.NameExistsException as e:
 
2567
                                            bus,
 
2568
                                            do_not_queue=True)
 
2569
            old_bus_name = dbus.service.BusName(
 
2570
                "se.bsnet.fukt.Mandos", bus,
 
2571
                do_not_queue=True)
 
2572
        except dbus.exceptions.DBusException as e:
2544
2573
            logger.error("Disabling D-Bus:", exc_info=e)
2545
2574
            use_dbus = False
2546
2575
            server_settings["use_dbus"] = False
2547
2576
            tcp_server.use_dbus = False
2548
2577
    if zeroconf:
2549
2578
        protocol = avahi.PROTO_INET6 if use_ipv6 else avahi.PROTO_INET
2550
 
        service = AvahiServiceToSyslog(name =
2551
 
                                       server_settings["servicename"],
2552
 
                                       servicetype = "_mandos._tcp",
2553
 
                                       protocol = protocol, bus = bus)
 
2579
        service = AvahiServiceToSyslog(
 
2580
            name = server_settings["servicename"],
 
2581
            servicetype = "_mandos._tcp",
 
2582
            protocol = protocol,
 
2583
            bus = bus)
2554
2584
        if server_settings["interface"]:
2555
 
            service.interface = (if_nametoindex
2556
 
                                 (str(server_settings["interface"])))
 
2585
            service.interface = if_nametoindex(
 
2586
                server_settings["interface"].encode("utf-8"))
2557
2587
    
2558
2588
    global multiprocessing_manager
2559
2589
    multiprocessing_manager = multiprocessing.Manager()
2578
2608
    if server_settings["restore"]:
2579
2609
        try:
2580
2610
            with open(stored_state_path, "rb") as stored_state:
2581
 
                clients_data, old_client_settings = (pickle.load
2582
 
                                                     (stored_state))
 
2611
                clients_data, old_client_settings = pickle.load(
 
2612
                    stored_state)
2583
2613
            os.remove(stored_state_path)
2584
2614
        except IOError as e:
2585
2615
            if e.errno == errno.ENOENT:
2586
 
                logger.warning("Could not load persistent state: {0}"
2587
 
                                .format(os.strerror(e.errno)))
 
2616
                logger.warning("Could not load persistent state:"
 
2617
                               " {}".format(os.strerror(e.errno)))
2588
2618
            else:
2589
2619
                logger.critical("Could not load persistent state:",
2590
2620
                                exc_info=e)
2591
2621
                raise
2592
2622
        except EOFError as e:
2593
2623
            logger.warning("Could not load persistent state: "
2594
 
                           "EOFError:", exc_info=e)
 
2624
                           "EOFError:",
 
2625
                           exc_info=e)
2595
2626
    
2596
2627
    with PGPEngine() as pgp:
2597
 
        for client_name, client in clients_data.iteritems():
 
2628
        for client_name, client in clients_data.items():
2598
2629
            # Skip removed clients
2599
2630
            if client_name not in client_settings:
2600
2631
                continue
2609
2640
                    # For each value in new config, check if it
2610
2641
                    # differs from the old config value (Except for
2611
2642
                    # the "secret" attribute)
2612
 
                    if (name != "secret" and
2613
 
                        value != old_client_settings[client_name]
2614
 
                        [name]):
 
2643
                    if (name != "secret"
 
2644
                        and (value !=
 
2645
                             old_client_settings[client_name][name])):
2615
2646
                        client[name] = value
2616
2647
                except KeyError:
2617
2648
                    pass
2618
2649
            
2619
2650
            # Clients who has passed its expire date can still be
2620
 
            # enabled if its last checker was successful.  Clients
 
2651
            # enabled if its last checker was successful.  A Client
2621
2652
            # whose checker succeeded before we stored its state is
2622
2653
            # assumed to have successfully run all checkers during
2623
2654
            # downtime.
2625
2656
                if datetime.datetime.utcnow() >= client["expires"]:
2626
2657
                    if not client["last_checked_ok"]:
2627
2658
                        logger.warning(
2628
 
                            "disabling client {0} - Client never "
2629
 
                            "performed a successful checker"
2630
 
                            .format(client_name))
 
2659
                            "disabling client {} - Client never "
 
2660
                            "performed a successful checker".format(
 
2661
                                client_name))
2631
2662
                        client["enabled"] = False
2632
2663
                    elif client["last_checker_status"] != 0:
2633
2664
                        logger.warning(
2634
 
                            "disabling client {0} - Client "
2635
 
                            "last checker failed with error code {1}"
2636
 
                            .format(client_name,
2637
 
                                    client["last_checker_status"]))
 
2665
                            "disabling client {} - Client last"
 
2666
                            " checker failed with error code"
 
2667
                            " {}".format(
 
2668
                                client_name,
 
2669
                                client["last_checker_status"]))
2638
2670
                        client["enabled"] = False
2639
2671
                    else:
2640
 
                        client["expires"] = (datetime.datetime
2641
 
                                             .utcnow()
2642
 
                                             + client["timeout"])
 
2672
                        client["expires"] = (
 
2673
                            datetime.datetime.utcnow()
 
2674
                            + client["timeout"])
2643
2675
                        logger.debug("Last checker succeeded,"
2644
 
                                     " keeping {0} enabled"
2645
 
                                     .format(client_name))
 
2676
                                     " keeping {} enabled".format(
 
2677
                                         client_name))
2646
2678
            try:
2647
 
                client["secret"] = (
2648
 
                    pgp.decrypt(client["encrypted_secret"],
2649
 
                                client_settings[client_name]
2650
 
                                ["secret"]))
 
2679
                client["secret"] = pgp.decrypt(
 
2680
                    client["encrypted_secret"],
 
2681
                    client_settings[client_name]["secret"])
2651
2682
            except PGPError:
2652
2683
                # If decryption fails, we use secret from new settings
2653
 
                logger.debug("Failed to decrypt {0} old secret"
2654
 
                             .format(client_name))
2655
 
                client["secret"] = (
2656
 
                    client_settings[client_name]["secret"])
 
2684
                logger.debug("Failed to decrypt {} old secret".format(
 
2685
                    client_name))
 
2686
                client["secret"] = (client_settings[client_name]
 
2687
                                    ["secret"])
2657
2688
    
2658
2689
    # Add/remove clients based on new changes made to config
2659
2690
    for client_name in (set(old_client_settings)
2664
2695
        clients_data[client_name] = client_settings[client_name]
2665
2696
    
2666
2697
    # Create all client objects
2667
 
    for client_name, client in clients_data.iteritems():
 
2698
    for client_name, client in clients_data.items():
2668
2699
        tcp_server.clients[client_name] = client_class(
2669
 
            name = client_name, settings = client,
 
2700
            name = client_name,
 
2701
            settings = client,
2670
2702
            server_settings = server_settings)
2671
2703
    
2672
2704
    if not tcp_server.clients:
2674
2706
    
2675
2707
    if not foreground:
2676
2708
        if pidfile is not None:
 
2709
            pid = os.getpid()
2677
2710
            try:
2678
2711
                with pidfile:
2679
 
                    pid = os.getpid()
2680
 
                    pidfile.write(str(pid) + "\n".encode("utf-8"))
 
2712
                    print(pid, file=pidfile)
2681
2713
            except IOError:
2682
2714
                logger.error("Could not write to file %r with PID %d",
2683
2715
                             pidfilename, pid)
2688
2720
    signal.signal(signal.SIGTERM, lambda signum, frame: sys.exit())
2689
2721
    
2690
2722
    if use_dbus:
2691
 
        @alternate_dbus_interfaces({"se.recompile.Mandos":
2692
 
                                        "se.bsnet.fukt.Mandos"})
 
2723
        
 
2724
        @alternate_dbus_interfaces(
 
2725
            { "se.recompile.Mandos": "se.bsnet.fukt.Mandos" })
2693
2726
        class MandosDBusService(DBusObjectWithProperties):
2694
2727
            """A D-Bus proxy object"""
 
2728
            
2695
2729
            def __init__(self):
2696
2730
                dbus.service.Object.__init__(self, bus, "/")
 
2731
            
2697
2732
            _interface = "se.recompile.Mandos"
2698
2733
            
2699
2734
            @dbus_interface_annotations(_interface)
2700
2735
            def _foo(self):
2701
 
                return { "org.freedesktop.DBus.Property"
2702
 
                         ".EmitsChangedSignal":
2703
 
                             "false"}
 
2736
                return {
 
2737
                    "org.freedesktop.DBus.Property.EmitsChangedSignal":
 
2738
                    "false" }
2704
2739
            
2705
2740
            @dbus.service.signal(_interface, signature="o")
2706
2741
            def ClientAdded(self, objpath):
2720
2755
            @dbus.service.method(_interface, out_signature="ao")
2721
2756
            def GetAllClients(self):
2722
2757
                "D-Bus method"
2723
 
                return dbus.Array(c.dbus_object_path
2724
 
                                  for c in
 
2758
                return dbus.Array(c.dbus_object_path for c in
2725
2759
                                  tcp_server.clients.itervalues())
2726
2760
            
2727
2761
            @dbus.service.method(_interface,
2729
2763
            def GetAllClientsWithProperties(self):
2730
2764
                "D-Bus method"
2731
2765
                return dbus.Dictionary(
2732
 
                    ((c.dbus_object_path, c.GetAll(""))
2733
 
                     for c in tcp_server.clients.itervalues()),
 
2766
                    { c.dbus_object_path: c.GetAll("")
 
2767
                      for c in tcp_server.clients.itervalues() },
2734
2768
                    signature="oa{sv}")
2735
2769
            
2736
2770
            @dbus.service.method(_interface, in_signature="o")
2774
2808
                
2775
2809
                # A list of attributes that can not be pickled
2776
2810
                # + secret.
2777
 
                exclude = set(("bus", "changedstate", "secret",
2778
 
                               "checker", "server_settings"))
2779
 
                for name, typ in (inspect.getmembers
2780
 
                                  (dbus.service.Object)):
 
2811
                exclude = { "bus", "changedstate", "secret",
 
2812
                            "checker", "server_settings" }
 
2813
                for name, typ in inspect.getmembers(dbus.service
 
2814
                                                    .Object):
2781
2815
                    exclude.add(name)
2782
2816
                
2783
2817
                client_dict["encrypted_secret"] = (client
2790
2824
                del client_settings[client.name]["secret"]
2791
2825
        
2792
2826
        try:
2793
 
            with (tempfile.NamedTemporaryFile
2794
 
                  (mode='wb', suffix=".pickle", prefix='clients-',
2795
 
                   dir=os.path.dirname(stored_state_path),
2796
 
                   delete=False)) as stored_state:
 
2827
            with tempfile.NamedTemporaryFile(
 
2828
                    mode='wb',
 
2829
                    suffix=".pickle",
 
2830
                    prefix='clients-',
 
2831
                    dir=os.path.dirname(stored_state_path),
 
2832
                    delete=False) as stored_state:
2797
2833
                pickle.dump((clients, client_settings), stored_state)
2798
 
                tempname=stored_state.name
 
2834
                tempname = stored_state.name
2799
2835
            os.rename(tempname, stored_state_path)
2800
2836
        except (IOError, OSError) as e:
2801
2837
            if not debug:
2804
2840
                except NameError:
2805
2841
                    pass
2806
2842
            if e.errno in (errno.ENOENT, errno.EACCES, errno.EEXIST):
2807
 
                logger.warning("Could not save persistent state: {0}"
 
2843
                logger.warning("Could not save persistent state: {}"
2808
2844
                               .format(os.strerror(e.errno)))
2809
2845
            else:
2810
2846
                logger.warning("Could not save persistent state:",
2820
2856
            client.disable(quiet=True)
2821
2857
            if use_dbus:
2822
2858
                # Emit D-Bus signal
2823
 
                mandos_dbus_service.ClientRemoved(client
2824
 
                                                  .dbus_object_path,
2825
 
                                                  client.name)
 
2859
                mandos_dbus_service.ClientRemoved(
 
2860
                    client.dbus_object_path, client.name)
2826
2861
        client_settings.clear()
2827
2862
    
2828
2863
    atexit.register(cleanup)
2881
2916
    # Must run before the D-Bus bus name gets deregistered
2882
2917
    cleanup()
2883
2918
 
 
2919
 
2884
2920
if __name__ == '__main__':
2885
2921
    main()